v2026.06.03 hotfix — Sonos cast URL + UPnP picker polish #78

Merged

bvandeusen merged 4 commits from dev into main 2026-06-03 15:30:09 -04:00

Conversation 0 Commits 4 Files Changed 4

+99 -6

4 Commits

Author	SHA1	Message	Date
bvandeusen	7d15f57e86	fix(server): cast token URL honors X-Forwarded-Proto / Host ... On-device test against Sonos showed SetAVTransportURI returning UPnP error 714 (IllegalMimeType). Logcat: POST /api/cast/stream-token -> 200 (token minted) SetAVTransportURI to http://minstrel.fabledsword.com/... <-- 500 from Sonos: SoapFaultException SOAP fault 714 The server is behind a TLS-terminating reverse proxy, so r.TLS is nil and the URL builder emitted http://. Sonos does a HEAD probe to detect the audio MIME type; against an http:// URL that 301s to https://, the probe finds no audio body and bails with 714. The Task 2 code-quality reviewer flagged this exact scenario at the time. Closing it now: honor X-Forwarded-Proto + X-Forwarded-Host before falling back to r.TLS + r.Host. Public URL the speaker fetches now matches the scheme/host the client used to reach the endpoint.	2026-06-03 15:17:34 -04:00
bvandeusen	a9edc12523	fix(android): release-build Timber tree at WARN+ for operator diagnosis ... Debug builds got DebugTree; release builds had no tree planted at all, so Timber.w / Timber.e calls were dropped silently in production. That's how the UPnP select diagnostic-prints went invisible during on-device testing - the released APK had no Timber output reaching logcat. Plant a release-only Tree that emits at WARN and above via android.util.Log.println with the canonical 'Minstrel' tag (or the caller-supplied tag when present). Keeps DEBUG / INFO traffic out of production logcat (the chatty stuff is the part we don't want flooding the buffer) while letting operator-driven adb logcat sessions still see real failures.	2026-06-03 15:01:03 -04:00
bvandeusen	96f12d6aac	fix(android): UPnP select - loud logs on every code path ... Two silent early returns in selectUpnp were swallowing the most likely failure modes: - currentTrack null (nothing playing locally → can't cast a track) - transportFor() returns null (route disappeared or id mismatch) On-device verification reported 'tap collapses the sheet but no audio routes', with logcat empty - one of these was firing without any signal. Each early-return now Timber.w's why; the runCatching block adds Timber.i breadcrumbs at every step (mint token, SetAVTransportURI, Play, done) so the next failure shows exactly how far we got.	2026-06-03 14:59:57 -04:00
bvandeusen	036da9dea8	fix(android): UPnP - clean Sonos friendlyName for picker display ... Sonos uses the friendlyName format 'Room - Device Type - RINCON_<UDN>' The picker was showing it verbatim, so the user saw rows like 'Living Room - Sonos Play:1 Media Renderer - RINCON_5CAAFD79...' Now strips on the first ' - ' for Sonos manufacturer matches, so the chip shows just 'Living Room' / 'Kitchen' / etc. Subtitle (manufacturer + model) still renders below per the existing sheet design, so the device-type info isn't lost. Generic UPnP devices that append a '(192.168.x.x)' IP suffix get that stripped too via an end-of-string-anchored regex. Empty / blank friendlyName still falls back to 'Network speaker'.	2026-06-03 14:54:39 -04:00