2110 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
bvandeusenandClaude Opus 5.5	6028d78844	docs: migration headers keep the before and after, without ids, quotes or one library's numbers (#6277) ... Applies rule 32's migration exception: each header still says what the schema was, what changes and what it prevents, but task, milestone, decision and rule ids are replaced by the practice they stood for, the operator quotes by the decision, single-install counts are dropped, and pointers to a deleted package and an external design doc are gone. golang-migrate keeps no checksum, so editing applied migrations' comments is safe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:34:39 -04:00
bvandeusenandClaude Opus 5.5	1d4ef1a23f	docs: query comments say what each query selects and why, not how it came to be (#6277) ... Rewrites the internal/db/queries comments to rule 32 and regenerates dbq, whose doc comments and embedded SQL carry them. The bugs behind the tiered mixes, the md5 order seed, the score bands and the round-robin arms are restated as the constraint each one enforces; counts from one library and stale cross-references are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:31:13 -04:00
bvandeusenandClaude Opus 5.5	7e6228c13f	docs: library comments say what the scanner and resolver do, not how they came to be (#6277) ... Rewrites the internal/library comment blocks to rule 32. Task, milestone, decision and rule ids are gone; the incidents behind them are restated as the constraint they left (why a file is deleted before its row, why the missing mark is a mark, why duplicates block on duration). Counts and album names from one library are dropped from production comments; test comments keep the names their fixtures use. The tagReadVersion log keeps each version's before and after, without the measurements. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:27:34 -04:00
bvandeusenandClaude Opus 5.5	08a2c06b85	docs: api comments say what the endpoints do, not how they came to be (#6277) ... Rewrites the internal/api comment blocks to rule 32: task, milestone and rule ids gone, the stories behind them restated as the constraint they left, stale references corrected (the stream secret is wired from config, the timezone handler already refreshes the scheduler, the Android app is the native client, the design docs cited are not in the repo). Also rewraps comment lines over 80 columns left by the earlier batches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:23:58 -04:00
bvandeusenandClaude Opus 5.5	fcf5b7e5a8	docs: wanted, dbtest, recommendation and playlists comments say what the code does (#6277) ... The same rewrite as d191a282, for four packages whose comments carried the most history: tuning stories, quotes from the operator, single-install measurements in library_scale.go, and 'used to' accounts of bugs. The constraint each story protected stays as a present-tense reason (why tier 3 is reduced not removed, why the randomised arms take an order seed, why the seed artist is eligible in Songs-like). Comments naming system_cron.go and config.RecommendationConfig, neither of which holds what they claimed, now name the scheduler and internal/recsettings. Checked: non-comment tokens identical to HEAD; gofmt clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:19:15 -04:00
bvandeusenandClaude Opus 5.5	d191a28217	docs: server comments say what the code does, not how it came to be (#6277) ... Comment blocks in cmd/minstrel and 30 smaller internal packages, rewritten to rule 32's standard with each citation read in context: task, milestone and rule ids go, and so do the stories they were attached to ("used to", "Before #N", measurements from one install, quotes, pointers to Fabled Librarian's records and to docs/superpowers files that are not in the repo). Where a story wrapped a real constraint, the constraint stays as a present-tense fact. Comments that had gone stale are corrected: - taste.Config: the tuned values are overlaid by internal/recsettings; it is no longer "a later follow-up". - StorageConfig: the data dir holds art, caches and the stream secret, not only playlist covers. - the Subsonic album list and getUser comments describe what they do today rather than a milestone that would change it. Checked: the non-comment token stream of every changed file matches HEAD, and gofmt -l is empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:15:05 -04:00
bvandeusenandClaude Opus 5.5	9f9609591d	docs: README in the standard order; setup files say what works today (#6277) ... README: logo header, short summary, a compose quick start with one-line comments, first-run steps, a configuration table, setup pitfalls, updating and backups, then features grouped by what you do. The Specs section (it called the Android client the "Flutter companion app"), the dated tag-history sentence and the Fable pointer are gone. Feature lines were checked against the code: radio seeds from a track only, and the Android app plays from its cache rather than offering downloads. .env.example used the SMARTMUSIC_ prefix, which the config loader has not read for a long time, so copying it set nothing. It now uses MINSTREL_. config.example.yaml is also the config the image bakes in at /etc/smartmusic/config.yaml. It listed five recommendation weights (base_weight, like_boost, recency_weight, skip_penalty, jitter_magnitude) that moved to Admin > Tuning; yaml.Unmarshal ignored them silently. They are removed, and the file parses to exactly Default(), so the running server is unchanged. coverart_from_mbcaa is not listed: nothing reads it. docker-compose.yml, the Makefile and the spec banners lose their task and milestone ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:02:25 -04:00
bvandeusenandClaude Opus 5.5	eac320c8d7	test: the notifications view model is built inside each test, after the test Main dispatcher is set (#6275) ... Built as a property initializer it ran at class construction, before MainDispatcherExtension's beforeEach, so viewModelScope.launch in init hit the missing Main dispatcher. Its uncaught exceptions also failed the next coroutine test in the JVM (RetryTransientIoTest). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 09:49:22 -04:00
bvandeusenandClaude Opus 5.5	f381622d20	feat: opening the notifications inbox marks what it shows as read (#6275) ... The web panel and the Android Notifications screen now mark every unread notice they show as read the moment they appear, so the badge clears on a look instead of a dismissal. Rows that were unread keep looking new until the inbox closes. The read goes through read-all with a cutoff of the newest notice shown plus 1 ms, so one that arrived unseen stays unread. 'Mark all read' is gone; opening the inbox does its job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 09:41:37 -04:00
bvandeusenandClaude Opus 5.5	4756e957ce	docs: the shutdown comments say what happens, without the task number ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 09:41:37 -04:00
bvandeusenandClaude Opus 5.5	79b90bda03	fix: shutdown ends the live-event streams so a redeploy drains instead of waiting out its deadline (#5293) ... http.Server.Shutdown waits for in-flight requests but never cancels them, and an SSE stream only ends when its client leaves, so any open tab or signed-in phone held every redeploy for the full 10s and the old task exited 1. With the swarm's stop-first update that was ~10s of downtime per deploy. The bus now closes on shutdown, ending each stream; clients reconnect to the next instance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 06:46:18 -04:00
bvandeusenandClaude Opus 5.5	fefc51439e	fix: Android's admin requests names who asked from the request itself (#6267) ... The admin requests list now sends each requester's username (#6265), so the Android queue reads it off the row instead of fetching the whole admin users list alongside and mapping ids to names. The short id stays as the fallback for a row that comes back without a name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 21:10:17 -04:00
bvandeusenandClaude Opus 5.5	687a7cf3ee	test: the admin requests list test names the requester by their seeded username (#6265) ... seedUser stores users as test-<name>, so the assertion compares against alice.Username rather than the literal "alice". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 20:49:54 -04:00
bvandeusenandClaude Opus 5.5	c98bd359f7	fix: the admin requests list names who asked, not a cut-off user id (#6265) ... /admin/requests showed "by user f7e1ec86" — the first eight characters of the requester's id, a placeholder from the first build. The admin list now sends each requester's username, looked up for the whole page in one query, and the row reads "by <username>". The id stays as the fallback for a list that comes back without names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 20:43:18 -04:00
bvandeusenandClaude Opus 5.5	b9684e6d12	fix: a group of one recording in several slots is settled by getting the album again, not merged (#6184) ... The duplicates review offered only Merge for a wrong-slot group. A merge keeps one copy's title whether or not it is the audio's, and neither sets the release aside nor wants the missing song back. For class mismatch the page now asks which song the recording is. "Get it again" (the operator can't tell) removes every copy; "Keep <title>" keeps that copy and removes the ones under other titles. Either way it runs the resolver's own path: the release the files came from is set aside, the removed copies' tracks stay marked missing and emptied, and the album is wanted again. - library.SettleWrongSlot, POST /api/admin/library/duplicates/{id}/refetch - ListDuplicateGroupsForResolve takes an optional group_id - removeWrongSlots takes the acting operator (manual: not automatic, actor in the audit row) and removes files through removeTrackFileOnDisk, so a read-only library answers library_not_writable Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 13:47:43 -04:00
bvandeusenandClaude Opus 5.5	5bcbc80555	fix: the taste arm round-robins across taste artists, and tag ties follow the order seed (#3880) ... Measured on the operator's library (26,005 tracks, pool scale 2.28): the arms the library scale grows all have far more rows than it asks for, and two arms collapsed whatever their limits were. - taste_overlap ordered by weight then track id, so the strongest taste artist's catalogue filled it: 20 tracks of saib. (197 tracks) out of 174 taste artists, the same lowest-id tracks every time. It now takes one track per taste artist, strongest first, md5-seeded, as similar_artists does since #5297. - tag_overlap broke ties in no order. A one-tag seed ties 7,804 tracks, and the LIMIT took whichever Postgres reached first, which the order seed did not control. Ties now follow md5(id || seed). - library_scale.go records the per-arm measurement beside the reference size it leaves as is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 12:12:58 -04:00
bvandeusenandClaude Opus 5.5	484a81f779	fix: a release its download client will not let Minstrel follow is held back, not taken every pass (#6176) ... The Black Keys' Ohio Players was grabbed 40 times in a day. FabledExchange already held the torrent under another category from before Minstrel took the downloads over: the add answered "duplicate", which counted as added, and Exchange's listing, filtered to Minstrel's category, never showed it. Half an hour later the grab ended gone, and the next pass took it again. - A duplicate add that the client does not list for Minstrel is not a grab: the release is held back for a day with the client's own reason (already downloading X (category)), and the search moves on. Forced, it is refused with that reason. - A release that ends gone a second time within a week is held back for a day, whatever the cause. - release_blocks gains the reason 'gone' (migration 0098), shown as "Held back: its download client lost track of it". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 11:31:57 -04:00
bvandeusenandClaude Opus 5.5	cb1f619a21	fix: a track shorter than the fingerprint span keeps its print (#6178) ... The image's fpcalc 1.5.1 exits 3 with "Error decoding audio frame (End of file)" whenever it reaches the end of a file before -length, at any length, so every track under two minutes failed both the AcoustID lookup print and the duplicate-detection print: 471 lookups and all 1,979 present short tracks' chromaprints. - runFingerprintTool returns the tool's stdout beside a toolExitError. - fpcalcReadToEnd keeps a partial exit whose stderr is the end of file and whose declared DURATION is within the span asked for. A damaged file that stops early declares more than it read, and still fails. - Migration 0097 clears the stored failures so the lookup worker and the fingerprint backfill take those tracks again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 11:01:23 -04:00
bvandeusenandClaude Opus 5.5	e44025435e	fix: ListenBrainz similarity is stored relative to the seed's best, and the candidate arms keep tier order (#6177) ... LB's similarity scores are counts (16 to 1445 for recordings, to 10,875 for artists), and they reached a scorer that reads similarity as 0 to 1. One edge added 64 to 5,800 points under Songs-like, so likes, skips and recency stopped mattering for any candidate with an edge. - ResolveListenBrainzTrackEdges divides each edge by the seed's best score in its whole cached answer. The cache keeps the raw answer. - The worker stores matched and unmatched artist rows over the seed's top artist. - Migration 0096 rescales the rows already stored. - The candidate arms hold sim_score bands so tier 1 stays above tier 2: lb_similar 0.5 + 0.5 x edge, tag_overlap halved, likes_overlap 0.3. Otherwise a seed's weaker LB edges fell below a shared genre tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 10:56:26 -04:00
bvandeusenandClaude Opus 5.5	46e1dd6c9c	test(android): run the sync pass in the test body, not through init's background collector (#5654) ... advanceUntilIdle does not count backgroundScope work as pending, so the pass init would start never ran. The network state is Offline so construction starts none, and each test calls syncSafe itself and asserts lastSyncError stays null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 08:03:51 -04:00
bvandeusenandClaude Opus 5.5	77f06b60f7	test(android): name the 204 body type so Response.success resolves (#5654) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 07:57:29 -04:00
bvandeusenandClaude Opus 5.5	42132810b0	fix(android): sync pulls every page of the change log, and a 404 drops the cached row (#5654) ... The server returns at most 1000 changes per /api/library/sync call and expects clients to loop with the returned cursor. SyncController took one page per trigger (cold start, reconnect), so the cache fell behind a log that a full re-read grows by ~26,000 rows and, past the 30-day compaction, reset through 410 to cursor 0 without ever reaching the merge deletes of 2026-10-09/10. The freshness sweep then re-asked for those tracks every 30 minutes: the same ~100 404s on every pass. - SyncController pages until 204, storing the cursor after each page, and stops on a cursor that does not advance. - MetadataProvider drops a cached album, artist or track the server answers 404 for, so rows orphaned before this fix stop being refetched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 07:52:54 -04:00
bvandeusenandClaude Opus 5.5	210f884b2d	fix: a file tagged with no release group joins the same-named album its folder holds ... Under e45561e2 a file with no group tag took the oldest same-named album row, which left three of Weezer's 1994 bonus tracks on the 2016 album. The lookup now ranks same-named rows by how many tracks they hold from the file's folder; tagReadVersion 8 re-places the existing ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 14:44:45 -04:00
bvandeusenandClaude Opus 5.5	e45561e282	fix: same-titled albums of two release groups are two albums, and a missing track with no disc is on disc 1 ... The scanner found an album by artist and title alone, so Weezer's six self-titled albums (1994–2026) were one 118-track row and their merges, wants and upgrades counted them as one. A same-named row whose release group is known and differs from the file's is now another album; tagReadVersion 7 re-reads the library so existing tracks move to their own rows. WantHoldings compared discs with IS NOT DISTINCT FROM, so a missing track 6 with no disc was never covered by a present disc 1 track 6. Air's Love 2 stayed wanted and was downloaded again for nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 14:13:58 -04:00
bvandeusenandClaude Opus 5.5	f32abc974f	fix: a duplicate fold never deletes a lossless copy for a lossy one, nor folds two versions (M498) ... The first album-copy fold pass on 2026-10-20 removed five FLACs (Måneskin Rush!, Weezer 2016) in favour of mp3s whose only edge was a recording MBID, and an explicit "Suite-Pee" for its clean version. ProposeSurvivor now ranks lossless before tag fit; tag fit still outranks file size, which is what the Humanz rips needed. The fold keys copies by their version words (title and file name), so a clean, live or instrumental copy holding the same title tag is linked, not folded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 12:36:55 -04:00
bvandeusenandClaude Opus 5.5	16a152b862	test: the album-copy fold test makes each album once, as UpsertAlbum folds only by MBID (#5401) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 12:01:16 -04:00
bvandeusenandClaude Opus 5.5	3ebd35e51d	fix: a slot the resolver emptied folds only into a copy of its own song (M498) ... On 2026-10-20 the emptied "Open the Gateway" slot of Auvic's Speed Demons was folded by title into another file tagged "Open the Gateway" that holds Onward (244 s against the song's 254 s), so the album was never wanted back. A wrong-slot removal now stamps tracks.emptied_at (migration 0095) when the album holds no copy of the song as long as its MusicBrainz slot, and missing-pair folding pairs such a row by title only with a track added since: a copy fetched again. A slot whose song the album does hold (VOID DLC's Weeper beside Void's) folds into it as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:55:23 -04:00
bvandeusenandClaude Opus 5.5	09e74a57a2	feat: an album holding a song twice beside its single keeps one copy (#5401) ... A cross-release group was only ever linked, never merged, so an album that held the song twice among the releases kept both: Humanz has Saturnz Barz, Andromeda, We Got the Power and Garage Palace as its FLAC and a YouTube mp3, each beside the single. The resolver now merges an album's extra copies into its best (the one that is not a video rip, else ProposeSurvivor: lossless first) with ReplaceTrack, history and all, then links what is left as one song. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:55:23 -04:00
bvandeusenandClaude Opus 5.5	80ecc2f7e7	fix: imported FLAC, Ogg and Opus files keep their track and disc numbers (#6171) ... The importer wrote track=N/M for every format, which ffmpeg stores in a Vorbis comment as TRACKNUMBER=3/20; dhowden/tag reads a Vorbis TRACKNUMBER with a bare Atoi, so it came back 0. All 245 tracks imported since 2026-10-10 (Humanz, Plastic Beach, the Gorillaz super deluxe and twelve more albums) have no track or disc number, and their album pages have no order. - The importer writes a Vorbis track and disc number alone, with TRACKTOTAL and DISCTOTAL, as Picard does. ID3 and MP4 keep N/M. - ReadTrackAndDisc takes the number before a slash when the Vorbis reader returns 0, for the scanner and for the import's own check of a download. - tagReadVersion 6 re-reads the files already held (tag reads only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:49:44 -04:00
bvandeusenandClaude Opus 5.5	42e48efb79	fix: the duplicate resolver waits for a running scan, so a copy it removes is not marked present again (#6169) ... At boot the scan lists the library, the resolver removes wrong-slot copies and marks their tracks missing, then the scan reconciles from its list and marks them present: 7 of the 13 removed on 2026-10-20 15:00 read as present with no file, and would not be wanted back until a later scan. A pass now waits while a scan younger than StuckScanThreshold is in flight and tries again a minute later; a stuck run does not hold it up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:04:46 -04:00
bvandeusenandClaude Opus 5.5	3a482bd715	fix: AcoustID decides any one-album mismatch the lengths cannot, not only copies each cut to its slot (#6169) ... The first pass on the operator's library held 16 groups. In several, every copy's own lookup names one recording (Wombats Record Shop/Tormentor, Alchemist (2)/Prelude, Monday Chill 8/9, 404sessions), but one copy sits 3-10s from its slot, so the every-copy-fits precondition kept AcoustID out. Now: copies whose lookups all agree are that recording, whatever their fingerprints read; copies of the same audio are asked about as before; and the track list places the recording in one copy's slot, or none. Copies filed as one song are not settled here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 10:52:42 -04:00
bvandeusenandClaude Opus 5.5	18d31e9cdd	feat: one recording cut to several songs' lengths is named by AcoustID; the copy in its slot stays, the rest go, and the release is set aside (#6169) ... Savant's Mortals held one recording as 16 of its 50 tracks, each trimmed to its own slot's MusicBrainz length, so the lengths could not say which slot was its own and every group waited for the operator. When a one-album mismatch is the same audio (identical, or fingerprints within 0.02) and every copy fits its own slot, the resolver asks what the recording is: the copies' own AcoustID lookups, or a fresh lookup of one copy (five a pass). The track list names each slot's recording; the copy in that slot is kept and the others removed, or every copy when the recording is in none of their slots or AcoustID knows none. AcoustID unreachable or answers in several copies' slots: the group waits. Whenever wrong-slot copies are removed, the download the files were imported from is set aside, so the album fetched again is not the same files. Albums imported before Minstrel downloaded anything have none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 10:33:55 -04:00
bvandeusenandClaude Opus 5.5	e3eddab80f	feat: the duplicates review says what each match rests on and plays every copy (#6168) ... Each group now states its evidence: identical audio data, or the share of audio fingerprints that agree. Copies titled as different songs in one acoustic group say so and ask the reviewer to listen, and each copy has a play button so they can. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 10:28:29 -04:00
bvandeusenandClaude Opus 5.5	460e78c955	fix: an album with missing tracks is wanted back by its release group, not only when it carries a release MBID (#6167) ... The release id was only ever used to find the group. 238 albums matched to a group carried none, so their losses, five of the resolver's wrong-slot removals among them, were never fetched again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 10:21:06 -04:00
bvandeusenandClaude Opus 5.5	39029b5cd9	fix: clearing a wrong slot's MBID clears its source too, as tracks_mbid_source_pair requires (M498) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:47:02 -04:00
bvandeusenandClaude Opus 5.5	8daa3d07b5	fix: a slot emptied of another song's file drops that file's recording MBID, so missing-pair folding cannot fold it into the copy kept (M498) ... On 2026-10-20 twelve of the 24 slots the resolver emptied were folded by MBID into the kept copy, so their albums were never wanted back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:39:17 -04:00
bvandeusenandClaude Opus 5.5	304caaee02	fix: the AcoustID rate-limit test bounds arrivals by the service's 3 a second, not the client's send spacing ... Run 9543 saw two arrivals 389ms apart though the client sent them 400ms apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:29:00 -04:00
bvandeusenandClaude Opus 5.5	a3d9effca3	feat: when no slot an album gives one recording is its own, every copy is removed and the album fetched again (M498) ... Shnabubula's whole album, one 45-minute file, was filed as both Fading Light and Looking for Answers. Neither slot fits, so wrongSlots had nothing to keep and held the group. Every copy now goes when each is clearly another song's; a copy near its slot still holds the group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:21:43 -04:00
bvandeusenandClaude Opus 5.5	c8e855ae4a	feat: the duplicate resolver fetches a missing album track list from MusicBrainz to decide a wrong slot, five albums a pass (M498) ... 20 of the 34 groups left for review had no cached track list for their album: the catalogue only reads one when the wanted list or the importer needs it. The resolver now asks catalogue.RefreshReleaseGroup for an album it must decide and the catalogue has never read, through the shared MusicBrainz pacer, at most five a pass (hourly). An unreachable MusicBrainz stops the pass's fetching; a group read and found empty is not asked about again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:02:53 -04:00
bvandeusenandClaude Opus 5.5	c5868c00cc	feat: a version named after a dash counts as a version, and a song held twice beside a wrong slot no longer blocks it (M498) ... - songKey drops a dashed version suffix (" - Instrumental Version", " - Radio Edit", live, remix, mix, acoustic, demo, reprise, rework, VIP), so Andora's "Goodbye Yesterday - Instrumental Version" is distinct, not a wrong slot. - wrongSlots accepts several fitting copies when they share one title (Killjoy twice beside Dreamland): the other slot's copy is removed, and the doubled song is left for the next sweep to find as a pair the resolver merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 06:24:47 -04:00
bvandeusenandClaude Opus 5.5	80c711ac9d	fix: a wrong-slot removal reads without a counted noun (M498) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 23:31:11 -04:00
bvandeusenandClaude Opus 5.5	0f58ebcd6c	feat: duplicates settle themselves: retitled copies across releases link, alike versions on one album are dismissed, and a file in another song's slot is removed so the album is fetched again (M498 #6159-#6162) ... The operator's library had 536 groups waiting for review, 2026-10-19. A sample showed most were one recording under two titles on two releases. - The headline and the Duplicates count leave out cross-release groups, which the resolver keeps and links: the headline read 3,479 when 536 needed review. - Any group spanning albums is cross_release and is linked as one song, whatever its titles say. Nothing is deleted. - One album, two versions named as such ("Lovesick (Instrumental)") and not byte-identical: a new class, distinct, dismissed by the resolver. - One album, one recording under different song titles (mismatch): the album's cached MusicBrainz track list decides. When exactly one slot's song is as long as the file and every other slot's song is clearly not, the other copies are removed and their tracks marked missing, so the reacquisition sweeper wants the album back. Otherwise the group stays for review. - The duplicates_found notice moves from the sweep to the resolver: it names only groups a pass first left for review. - Resolved automatically lists dismissals and wrong-slot removals beside merges. Migration 0094 adds 'distinct' to the class CHECK (rule 36). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 23:22:38 -04:00
bvandeusenandClaude Opus 5.5	8538f0dc68	fix: the playback-error test matches the prefixed username, and announcementFor keeps detekt's two returns (M542) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 22:53:13 -04:00
bvandeusenandClaude Opus 5.5	854c307834	feat: notifications say what changed and alert once: a grouped notice names the tracks, grows without re-alerting, and a phone pile lists its titles (M542 #6146-#6151) ... - An update to a grouped notice keeps its arrival time and email state, so the phone and the email no longer go off again each time it grows. - Notices carry the names of what changed (newest ten), shown as three and "and N more": tracks still missing after the scan's move/replacement fold, duplicate groups new to a sweep, songs merged automatically, and the track and listener a playback error was for. - Duplicates found counts only the groups new to that sweep; playback errors count reports, not the unresolved total. - A scan failure says what stopped and links to Admin > Library. - Android: a pile of more than three alerts lists the newest five titles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 22:44:19 -04:00
bvandeusenandClaude Opus 5.5	2365514e5b	test: TestPlanRoots looks for the empty-list refusal as the message words it (#6129) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 20:40:54 -04:00
bvandeusenandClaude Opus 5.5	edcb3a57ef	feat: the library's folders are set in Admin › Library, and changing a folder moves its tracks with it, keeping their plays, likes and playlists (#6129) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 20:37:03 -04:00
bvandeusenandClaude Opus 5.5	453a977e48	refactor: the admin and user Requests pages draw a request with one RequestRow, and the kind chip is one KindPill there and on Hidden tracks (#5651) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 18:20:53 -04:00
bvandeusenandClaude Opus 5.5	db15713798	refactor: the server says a count one way, words.Count, for notifications, a wanted match's reason and the duplicate resolver's activity line (M505 #5643) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 16:18:50 -04:00
bvandeusenandClaude Opus 5.5	9e24b2b4fc	refactor: every count in the web app is said by one plural(), with the viewer's thousands separator; a source guard names any hand-written copy (M505 #5642) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 16:18:04 -04:00
bvandeusenandClaude Opus 5.5	af2d4f9859	refactor: a running download is worded the same on the admin Overview as on the wanted list, from one liveDownloadLine (M505 #5641) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 16:15:21 -04:00