100 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
bvandeusenandClaude Opus 5.5	5dc6aa9c2f	feat(android): Storage shows the Liked songs and Recently played budgets (#6309) ... Two cap selectors, each with its usage, and a "Keep liked songs offline" switch replace the single cache limit and its next-launch caveat; caps apply at once. Docs that said the liked bucket did not exist are restated, and the audio-cache index's unused per-source eviction queries are deleted: eviction follows the liked set, not the index's source column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 15:23:49 -04:00
bvandeusenandClaude Opus 5.5	ec1e59921b	feat(android): liking a track downloads its audio into the Liked budget on Wi-Fi (#6308) ... LikedAudioPinner downloads liked tracks' whole audio when "Keep liked songs offline" is on: most recently liked first, one at a time, only on an unmetered network while the server is reachable, and only while the Liked budget has room for another track at CD bitrate, so it never pushes out liked audio already on the phone. Tracks liked before this ships are covered by the same pass. Any change (a like, an unlike, the switch, the network) restarts the pass and cancels a download in flight. Supporting changes: - ConnectivityObserver.unmetered: the default network's NOT_METERED bit. - Liked track ids are read newest first, and refreshIds stamps the server's newest-first order into likedAt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 15:23:49 -04:00
bvandeusenandClaude Opus 5.5	7ec8a82871	feat(android): the audio cache keeps a Liked songs budget and a Recently played budget (#6307) ... SimpleCache ran one LRU evictor at the rolling cap, so liked audio was dropped like anything else and the offline Liked pool shrank as other music played. TwoBucketCacheEvictor replaces it: - a span counts against Liked when its track is liked, else Recently played; a liked track that is also played is charged to Liked only; - each budget has its own cap (0 = unlimited) and drops its own least-recently-used audio first; - CacheBudgetSync feeds it the signed-in user's liked ids and the Storage caps, so a like, an unlike or a cap change applies at once; - nothing is evicted until the liked set is known, so startup never trims liked audio as Recently played. The decisions live in a Media3-free BucketLedger with unit tests. CacheConfig and PlayerModule, which only snapshotted the caps at launch, are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 15:16:36 -04:00
bvandeusenandClaude Opus 5.5	b61474744b	chore(android): delete the unread deprecated FabledSwordTokens alias (#6295) ... UI code reads LocalFabledSwordTheme.current; nothing referenced the dark-bound alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 14:23:55 -04:00
bvandeusenandClaude Opus 5.5	1aba1a41e6	fix(tracks): removing a track writes a track_remove audit row (#6294) ... RemoveTrack took the admin's id and dropped it, so a merge left an audit trail and the more destructive removal did not. It now reads the track's title, artist, album and file path before the delete and writes them, with whether the album and artist went too, under the new track_remove action. The audit action groups lose their plan-era U1/U2/U3 headings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 14:16:41 -04:00
bvandeusenandClaude Opus 5.5	0d0b04bff0	test(subsonic): album-list fixture users carry distinct api token hashes (#6293) ... users.api_token_hash is unique, so the second seeded user needs its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 14:05:45 -04:00
bvandeusenandClaude Opus 5.5	f3b124f9b2	feat(subsonic): getAlbumList2 recent and frequent read the caller's play history (#6293) ... type=recent orders the caller's albums by their latest play (skips included); type=frequent orders them by completed plays (skips excluded). Plays of tracks whose file is gone do not count, and both page by size/offset like the other types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:58:09 -04:00
bvandeusenandClaude Opus 5.5	09e78962b2	fix(subsonic): getUser answers an admin's lookup with the requested user (#6292) ... An admin asking for another username got their own name and roles back. The handler now looks the user up by exact username and answers with that user's payload; an unknown username is ErrDataNotFound. A non-admin asking about someone else is still ErrNotAuthorized. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:58:09 -04:00
bvandeusenandClaude Opus 5.5	466912e202	docs: plan-era "v1", "Task N" and "Phase N" wording restated as facts (#6277) ... The marker list behind the earlier server and web passes did not catch "for v1", "Task 5", "Phase 2" or "today: Flutter". Those comments now say what the code does. Corrected: coverart said "both v1 providers" ship on. There are four providers (MBCAA, TheAudioDB, Deezer, Last.fm), and Last.fm, which needs a key, ships off. Non-comment tokens unchanged against HEAD: 10 Go files, 7 TS/Svelte files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:05:03 -04:00
bvandeusenandClaude Opus 5.5	c96231106f	docs: setup files and the client, shared and CI docs describe what is (#6277) ... .dockerignore, .gitignore, deploy/initdb, ci-requirements.md, client/README.md, shared/README.md and two web/scripts test names: dates, issue/rule/spike ids and the stories behind each exclusion removed. Corrected: - client/README.md: the dev lane bundles its own APK; :main no longer exists; main bundles the recorded sidecar instead of re-deriving the version name. Its smoke-test step wrote a bare "v0.2.0", which the server rejects as a sidecar that is not JSON; it now writes the JSON shape, which the README documents. - ci-requirements.md: one workflow, not four; the android lane builds no debug APK; main reads the recorded sidecar. - .gitignore: CI fills client/ on every image build, not tag releases only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:04:02 -04:00
bvandeusenandClaude Opus 5.5	557887bb07	docs: workflow, Dockerfile and brand-tool comments say what each does (#6277) ... release.yml, the Dockerfile and tools/gen-brand-assets.py keep every constraint their comments explain (the tag map, the gate, immutable tags, the shared-daemon Postgres guard, the version/channel split) and drop the history around them: rule and family-idea numbers, issue and run ids, dates, an operator quote, the "this used to say the opposite" paragraphs and one-runner timings. Corrected: the Dockerfile said client/ is filled on tag pushes only; every build fills it (dev and tag push bundle their own APK, main bundles the latest release's). Only full-line `#` comments changed: non-comment lines are identical to HEAD in all three files, and the three run: scripts whose text changed differ only in shell comment lines. The release guard tests match raw workflow text; none of their required or forbidden strings appear in the new comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:01:39 -04:00
bvandeusenandClaude Opus 5.5	ae7e05c579	docs: Android comments say what the app does, not how it came to be (#6277) ... Every flagged comment block in the Android app, its tests and its XML/TOML config, rewritten with the cited issue in view: the constraint is kept, the story behind it dropped, and issue, milestone, rule, phase and drift ids, dates and operator quotes removed. "Mirrors the Flutter client's X" pointers are gone; that client is no longer in the repo. Comments that no longer matched the code, corrected: - SyncController: a 410 resets the cursor and re-pulls; it never dropped the three local caches. - PlayerFactory, PlayerModule, AudioCacheIndexEntity, CacheConfig, CacheSource: there is no eviction worker and no liked-track bucket; SimpleCache evicts by plain LRU over the rolling cap, and the liked cap is stored but unenforced. - CacheSettings, StorageCard: the prefetcher exists (AudioPrefetcher); pin-on-like still does not. - LibraryApi, LibraryRepository, BrowseViewModel: the cache now carries the missing-file mark; the browse indexes stay server-backed for one source of grouping. - OutputRoute: UPnP routes exist; only CAST and SONOS are reserved. - PlayerFactory, RemotePlayerState, OutputPickerController: a failed transport command does not drop the UPnP route. - LibraryScreen: History, Liked and Hidden are real tabs, not placeholders. - AVTransportClient: the extend loop lives in SonosQueueLoader. - "the operator" meaning the listener now says "the user". Verified with a Kotlin lexer comparing every file's non-comment tokens against HEAD: 394 files, 0 differences. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:59:07 -04:00
bvandeusenandClaude Opus 5.5	9f588b6d61	docs: the history phrases the id sweep missed, restated as present-tense facts or traps (#6277) ... A wider pass for "previous", "before the fix", "we shipped" and the like. The chi double-subtree, uppercase Vorbis key and stopPropagation comments now describe the trap they guard; commit hashes, CI run numbers and a deleted file name are gone; uuidString's comment says what it returns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:43:11 -04:00
bvandeusenandClaude Opus 5.5	10d50dccbd	docs: web comments say what the app does, not how it came to be (#6277) ... Rewrites the web app's comments to rule 32. Task, milestone, rule and spec ids are gone; regression stories are restated as the trap they guard (public auth routes, the menu's stopPropagation, universal loads under adapter-static, metric deltas with their margin). Flutter and Tauri mentions now name the Android app or a native shell, operator quotes and dates are dropped, and one library's counts no longer appear outside test fixtures. Verified with a TypeScript-scanner token comparison (template literals and regex literals re-scanned): only comment text changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:42:12 -04:00
bvandeusenandClaude Opus 5.5	6028d78844	docs: migration headers keep the before and after, without ids, quotes or one library's numbers (#6277) ... Applies rule 32's migration exception: each header still says what the schema was, what changes and what it prevents, but task, milestone, decision and rule ids are replaced by the practice they stood for, the operator quotes by the decision, single-install counts are dropped, and pointers to a deleted package and an external design doc are gone. golang-migrate keeps no checksum, so editing applied migrations' comments is safe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:34:39 -04:00
bvandeusenandClaude Opus 5.5	1d4ef1a23f	docs: query comments say what each query selects and why, not how it came to be (#6277) ... Rewrites the internal/db/queries comments to rule 32 and regenerates dbq, whose doc comments and embedded SQL carry them. The bugs behind the tiered mixes, the md5 order seed, the score bands and the round-robin arms are restated as the constraint each one enforces; counts from one library and stale cross-references are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:31:13 -04:00
bvandeusenandClaude Opus 5.5	7e6228c13f	docs: library comments say what the scanner and resolver do, not how they came to be (#6277) ... Rewrites the internal/library comment blocks to rule 32. Task, milestone, decision and rule ids are gone; the incidents behind them are restated as the constraint they left (why a file is deleted before its row, why the missing mark is a mark, why duplicates block on duration). Counts and album names from one library are dropped from production comments; test comments keep the names their fixtures use. The tagReadVersion log keeps each version's before and after, without the measurements. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:27:34 -04:00
bvandeusenandClaude Opus 5.5	08a2c06b85	docs: api comments say what the endpoints do, not how they came to be (#6277) ... Rewrites the internal/api comment blocks to rule 32: task, milestone and rule ids gone, the stories behind them restated as the constraint they left, stale references corrected (the stream secret is wired from config, the timezone handler already refreshes the scheduler, the Android app is the native client, the design docs cited are not in the repo). Also rewraps comment lines over 80 columns left by the earlier batches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:23:58 -04:00
bvandeusenandClaude Opus 5.5	fcf5b7e5a8	docs: wanted, dbtest, recommendation and playlists comments say what the code does (#6277) ... The same rewrite as d191a282, for four packages whose comments carried the most history: tuning stories, quotes from the operator, single-install measurements in library_scale.go, and 'used to' accounts of bugs. The constraint each story protected stays as a present-tense reason (why tier 3 is reduced not removed, why the randomised arms take an order seed, why the seed artist is eligible in Songs-like). Comments naming system_cron.go and config.RecommendationConfig, neither of which holds what they claimed, now name the scheduler and internal/recsettings. Checked: non-comment tokens identical to HEAD; gofmt clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:19:15 -04:00
bvandeusenandClaude Opus 5.5	d191a28217	docs: server comments say what the code does, not how it came to be (#6277) ... Comment blocks in cmd/minstrel and 30 smaller internal packages, rewritten to rule 32's standard with each citation read in context: task, milestone and rule ids go, and so do the stories they were attached to ("used to", "Before #N", measurements from one install, quotes, pointers to Fabled Librarian's records and to docs/superpowers files that are not in the repo). Where a story wrapped a real constraint, the constraint stays as a present-tense fact. Comments that had gone stale are corrected: - taste.Config: the tuned values are overlaid by internal/recsettings; it is no longer "a later follow-up". - StorageConfig: the data dir holds art, caches and the stream secret, not only playlist covers. - the Subsonic album list and getUser comments describe what they do today rather than a milestone that would change it. Checked: the non-comment token stream of every changed file matches HEAD, and gofmt -l is empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:15:05 -04:00
bvandeusenandClaude Opus 5.5	9f9609591d	docs: README in the standard order; setup files say what works today (#6277) ... README: logo header, short summary, a compose quick start with one-line comments, first-run steps, a configuration table, setup pitfalls, updating and backups, then features grouped by what you do. The Specs section (it called the Android client the "Flutter companion app"), the dated tag-history sentence and the Fable pointer are gone. Feature lines were checked against the code: radio seeds from a track only, and the Android app plays from its cache rather than offering downloads. .env.example used the SMARTMUSIC_ prefix, which the config loader has not read for a long time, so copying it set nothing. It now uses MINSTREL_. config.example.yaml is also the config the image bakes in at /etc/smartmusic/config.yaml. It listed five recommendation weights (base_weight, like_boost, recency_weight, skip_penalty, jitter_magnitude) that moved to Admin > Tuning; yaml.Unmarshal ignored them silently. They are removed, and the file parses to exactly Default(), so the running server is unchanged. coverart_from_mbcaa is not listed: nothing reads it. docker-compose.yml, the Makefile and the spec banners lose their task and milestone ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:02:25 -04:00
bvandeusenandClaude Opus 5.5	eac320c8d7	test: the notifications view model is built inside each test, after the test Main dispatcher is set (#6275) ... Built as a property initializer it ran at class construction, before MainDispatcherExtension's beforeEach, so viewModelScope.launch in init hit the missing Main dispatcher. Its uncaught exceptions also failed the next coroutine test in the JVM (RetryTransientIoTest). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 09:49:22 -04:00
bvandeusenandClaude Opus 5.5	f381622d20	feat: opening the notifications inbox marks what it shows as read (#6275) ... The web panel and the Android Notifications screen now mark every unread notice they show as read the moment they appear, so the badge clears on a look instead of a dismissal. Rows that were unread keep looking new until the inbox closes. The read goes through read-all with a cutoff of the newest notice shown plus 1 ms, so one that arrived unseen stays unread. 'Mark all read' is gone; opening the inbox does its job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 09:41:37 -04:00
bvandeusenandClaude Opus 5.5	4756e957ce	docs: the shutdown comments say what happens, without the task number ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 09:41:37 -04:00
bvandeusenandClaude Opus 5.5	79b90bda03	fix: shutdown ends the live-event streams so a redeploy drains instead of waiting out its deadline (#5293) ... http.Server.Shutdown waits for in-flight requests but never cancels them, and an SSE stream only ends when its client leaves, so any open tab or signed-in phone held every redeploy for the full 10s and the old task exited 1. With the swarm's stop-first update that was ~10s of downtime per deploy. The bus now closes on shutdown, ending each stream; clients reconnect to the next instance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 06:46:18 -04:00
bvandeusenandClaude Opus 5.5	fefc51439e	fix: Android's admin requests names who asked from the request itself (#6267) ... The admin requests list now sends each requester's username (#6265), so the Android queue reads it off the row instead of fetching the whole admin users list alongside and mapping ids to names. The short id stays as the fallback for a row that comes back without a name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 21:10:17 -04:00
bvandeusenandClaude Opus 5.5	687a7cf3ee	test: the admin requests list test names the requester by their seeded username (#6265) ... seedUser stores users as test-<name>, so the assertion compares against alice.Username rather than the literal "alice". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 20:49:54 -04:00
bvandeusenandClaude Opus 5.5	c98bd359f7	fix: the admin requests list names who asked, not a cut-off user id (#6265) ... /admin/requests showed "by user f7e1ec86" — the first eight characters of the requester's id, a placeholder from the first build. The admin list now sends each requester's username, looked up for the whole page in one query, and the row reads "by <username>". The id stays as the fallback for a list that comes back without names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 20:43:18 -04:00
bvandeusenandClaude Opus 5.5	b9684e6d12	fix: a group of one recording in several slots is settled by getting the album again, not merged (#6184) ... The duplicates review offered only Merge for a wrong-slot group. A merge keeps one copy's title whether or not it is the audio's, and neither sets the release aside nor wants the missing song back. For class mismatch the page now asks which song the recording is. "Get it again" (the operator can't tell) removes every copy; "Keep <title>" keeps that copy and removes the ones under other titles. Either way it runs the resolver's own path: the release the files came from is set aside, the removed copies' tracks stay marked missing and emptied, and the album is wanted again. - library.SettleWrongSlot, POST /api/admin/library/duplicates/{id}/refetch - ListDuplicateGroupsForResolve takes an optional group_id - removeWrongSlots takes the acting operator (manual: not automatic, actor in the audit row) and removes files through removeTrackFileOnDisk, so a read-only library answers library_not_writable Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 13:47:43 -04:00
bvandeusenandClaude Opus 5.5	5bcbc80555	fix: the taste arm round-robins across taste artists, and tag ties follow the order seed (#3880) ... Measured on the operator's library (26,005 tracks, pool scale 2.28): the arms the library scale grows all have far more rows than it asks for, and two arms collapsed whatever their limits were. - taste_overlap ordered by weight then track id, so the strongest taste artist's catalogue filled it: 20 tracks of saib. (197 tracks) out of 174 taste artists, the same lowest-id tracks every time. It now takes one track per taste artist, strongest first, md5-seeded, as similar_artists does since #5297. - tag_overlap broke ties in no order. A one-tag seed ties 7,804 tracks, and the LIMIT took whichever Postgres reached first, which the order seed did not control. Ties now follow md5(id || seed). - library_scale.go records the per-arm measurement beside the reference size it leaves as is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 12:12:58 -04:00
bvandeusenandClaude Opus 5.5	484a81f779	fix: a release its download client will not let Minstrel follow is held back, not taken every pass (#6176) ... The Black Keys' Ohio Players was grabbed 40 times in a day. FabledExchange already held the torrent under another category from before Minstrel took the downloads over: the add answered "duplicate", which counted as added, and Exchange's listing, filtered to Minstrel's category, never showed it. Half an hour later the grab ended gone, and the next pass took it again. - A duplicate add that the client does not list for Minstrel is not a grab: the release is held back for a day with the client's own reason (already downloading X (category)), and the search moves on. Forced, it is refused with that reason. - A release that ends gone a second time within a week is held back for a day, whatever the cause. - release_blocks gains the reason 'gone' (migration 0098), shown as "Held back: its download client lost track of it". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 11:31:57 -04:00
bvandeusenandClaude Opus 5.5	cb1f619a21	fix: a track shorter than the fingerprint span keeps its print (#6178) ... The image's fpcalc 1.5.1 exits 3 with "Error decoding audio frame (End of file)" whenever it reaches the end of a file before -length, at any length, so every track under two minutes failed both the AcoustID lookup print and the duplicate-detection print: 471 lookups and all 1,979 present short tracks' chromaprints. - runFingerprintTool returns the tool's stdout beside a toolExitError. - fpcalcReadToEnd keeps a partial exit whose stderr is the end of file and whose declared DURATION is within the span asked for. A damaged file that stops early declares more than it read, and still fails. - Migration 0097 clears the stored failures so the lookup worker and the fingerprint backfill take those tracks again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 11:01:23 -04:00
bvandeusenandClaude Opus 5.5	e44025435e	fix: ListenBrainz similarity is stored relative to the seed's best, and the candidate arms keep tier order (#6177) ... LB's similarity scores are counts (16 to 1445 for recordings, to 10,875 for artists), and they reached a scorer that reads similarity as 0 to 1. One edge added 64 to 5,800 points under Songs-like, so likes, skips and recency stopped mattering for any candidate with an edge. - ResolveListenBrainzTrackEdges divides each edge by the seed's best score in its whole cached answer. The cache keeps the raw answer. - The worker stores matched and unmatched artist rows over the seed's top artist. - Migration 0096 rescales the rows already stored. - The candidate arms hold sim_score bands so tier 1 stays above tier 2: lb_similar 0.5 + 0.5 x edge, tag_overlap halved, likes_overlap 0.3. Otherwise a seed's weaker LB edges fell below a shared genre tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 10:56:26 -04:00
bvandeusenandClaude Opus 5.5	46e1dd6c9c	test(android): run the sync pass in the test body, not through init's background collector (#5654) ... advanceUntilIdle does not count backgroundScope work as pending, so the pass init would start never ran. The network state is Offline so construction starts none, and each test calls syncSafe itself and asserts lastSyncError stays null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 08:03:51 -04:00
bvandeusenandClaude Opus 5.5	77f06b60f7	test(android): name the 204 body type so Response.success resolves (#5654) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 07:57:29 -04:00
bvandeusenandClaude Opus 5.5	42132810b0	fix(android): sync pulls every page of the change log, and a 404 drops the cached row (#5654) ... The server returns at most 1000 changes per /api/library/sync call and expects clients to loop with the returned cursor. SyncController took one page per trigger (cold start, reconnect), so the cache fell behind a log that a full re-read grows by ~26,000 rows and, past the 30-day compaction, reset through 410 to cursor 0 without ever reaching the merge deletes of 2026-10-09/10. The freshness sweep then re-asked for those tracks every 30 minutes: the same ~100 404s on every pass. - SyncController pages until 204, storing the cursor after each page, and stops on a cursor that does not advance. - MetadataProvider drops a cached album, artist or track the server answers 404 for, so rows orphaned before this fix stop being refetched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 07:52:54 -04:00
bvandeusenandClaude Opus 5.5	210f884b2d	fix: a file tagged with no release group joins the same-named album its folder holds ... Under e45561e2 a file with no group tag took the oldest same-named album row, which left three of Weezer's 1994 bonus tracks on the 2016 album. The lookup now ranks same-named rows by how many tracks they hold from the file's folder; tagReadVersion 8 re-places the existing ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 14:44:45 -04:00
bvandeusenandClaude Opus 5.5	e45561e282	fix: same-titled albums of two release groups are two albums, and a missing track with no disc is on disc 1 ... The scanner found an album by artist and title alone, so Weezer's six self-titled albums (1994–2026) were one 118-track row and their merges, wants and upgrades counted them as one. A same-named row whose release group is known and differs from the file's is now another album; tagReadVersion 7 re-reads the library so existing tracks move to their own rows. WantHoldings compared discs with IS NOT DISTINCT FROM, so a missing track 6 with no disc was never covered by a present disc 1 track 6. Air's Love 2 stayed wanted and was downloaded again for nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 14:13:58 -04:00
bvandeusenandClaude Opus 5.5	f32abc974f	fix: a duplicate fold never deletes a lossless copy for a lossy one, nor folds two versions (M498) ... The first album-copy fold pass on 2026-10-20 removed five FLACs (Måneskin Rush!, Weezer 2016) in favour of mp3s whose only edge was a recording MBID, and an explicit "Suite-Pee" for its clean version. ProposeSurvivor now ranks lossless before tag fit; tag fit still outranks file size, which is what the Humanz rips needed. The fold keys copies by their version words (title and file name), so a clean, live or instrumental copy holding the same title tag is linked, not folded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 12:36:55 -04:00
bvandeusenandClaude Opus 5.5	16a152b862	test: the album-copy fold test makes each album once, as UpsertAlbum folds only by MBID (#5401) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 12:01:16 -04:00
bvandeusenandClaude Opus 5.5	3ebd35e51d	fix: a slot the resolver emptied folds only into a copy of its own song (M498) ... On 2026-10-20 the emptied "Open the Gateway" slot of Auvic's Speed Demons was folded by title into another file tagged "Open the Gateway" that holds Onward (244 s against the song's 254 s), so the album was never wanted back. A wrong-slot removal now stamps tracks.emptied_at (migration 0095) when the album holds no copy of the song as long as its MusicBrainz slot, and missing-pair folding pairs such a row by title only with a track added since: a copy fetched again. A slot whose song the album does hold (VOID DLC's Weeper beside Void's) folds into it as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:55:23 -04:00
bvandeusenandClaude Opus 5.5	09e74a57a2	feat: an album holding a song twice beside its single keeps one copy (#5401) ... A cross-release group was only ever linked, never merged, so an album that held the song twice among the releases kept both: Humanz has Saturnz Barz, Andromeda, We Got the Power and Garage Palace as its FLAC and a YouTube mp3, each beside the single. The resolver now merges an album's extra copies into its best (the one that is not a video rip, else ProposeSurvivor: lossless first) with ReplaceTrack, history and all, then links what is left as one song. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:55:23 -04:00
bvandeusenandClaude Opus 5.5	80ecc2f7e7	fix: imported FLAC, Ogg and Opus files keep their track and disc numbers (#6171) ... The importer wrote track=N/M for every format, which ffmpeg stores in a Vorbis comment as TRACKNUMBER=3/20; dhowden/tag reads a Vorbis TRACKNUMBER with a bare Atoi, so it came back 0. All 245 tracks imported since 2026-10-10 (Humanz, Plastic Beach, the Gorillaz super deluxe and twelve more albums) have no track or disc number, and their album pages have no order. - The importer writes a Vorbis track and disc number alone, with TRACKTOTAL and DISCTOTAL, as Picard does. ID3 and MP4 keep N/M. - ReadTrackAndDisc takes the number before a slash when the Vorbis reader returns 0, for the scanner and for the import's own check of a download. - tagReadVersion 6 re-reads the files already held (tag reads only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:49:44 -04:00
bvandeusenandClaude Opus 5.5	42e48efb79	fix: the duplicate resolver waits for a running scan, so a copy it removes is not marked present again (#6169) ... At boot the scan lists the library, the resolver removes wrong-slot copies and marks their tracks missing, then the scan reconciles from its list and marks them present: 7 of the 13 removed on 2026-10-20 15:00 read as present with no file, and would not be wanted back until a later scan. A pass now waits while a scan younger than StuckScanThreshold is in flight and tries again a minute later; a stuck run does not hold it up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:04:46 -04:00
bvandeusenandClaude Opus 5.5	3a482bd715	fix: AcoustID decides any one-album mismatch the lengths cannot, not only copies each cut to its slot (#6169) ... The first pass on the operator's library held 16 groups. In several, every copy's own lookup names one recording (Wombats Record Shop/Tormentor, Alchemist (2)/Prelude, Monday Chill 8/9, 404sessions), but one copy sits 3-10s from its slot, so the every-copy-fits precondition kept AcoustID out. Now: copies whose lookups all agree are that recording, whatever their fingerprints read; copies of the same audio are asked about as before; and the track list places the recording in one copy's slot, or none. Copies filed as one song are not settled here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 10:52:42 -04:00
bvandeusenandClaude Opus 5.5	18d31e9cdd	feat: one recording cut to several songs' lengths is named by AcoustID; the copy in its slot stays, the rest go, and the release is set aside (#6169) ... Savant's Mortals held one recording as 16 of its 50 tracks, each trimmed to its own slot's MusicBrainz length, so the lengths could not say which slot was its own and every group waited for the operator. When a one-album mismatch is the same audio (identical, or fingerprints within 0.02) and every copy fits its own slot, the resolver asks what the recording is: the copies' own AcoustID lookups, or a fresh lookup of one copy (five a pass). The track list names each slot's recording; the copy in that slot is kept and the others removed, or every copy when the recording is in none of their slots or AcoustID knows none. AcoustID unreachable or answers in several copies' slots: the group waits. Whenever wrong-slot copies are removed, the download the files were imported from is set aside, so the album fetched again is not the same files. Albums imported before Minstrel downloaded anything have none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 10:33:55 -04:00
bvandeusenandClaude Opus 5.5	e3eddab80f	feat: the duplicates review says what each match rests on and plays every copy (#6168) ... Each group now states its evidence: identical audio data, or the share of audio fingerprints that agree. Copies titled as different songs in one acoustic group say so and ask the reviewer to listen, and each copy has a play button so they can. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 10:28:29 -04:00
bvandeusenandClaude Opus 5.5	460e78c955	fix: an album with missing tracks is wanted back by its release group, not only when it carries a release MBID (#6167) ... The release id was only ever used to find the group. 238 albums matched to a group carried none, so their losses, five of the resolver's wrong-slot removals among them, were never fetched again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 10:21:06 -04:00
bvandeusenandClaude Opus 5.5	39029b5cd9	fix: clearing a wrong slot's MBID clears its source too, as tracks_mbid_source_pair requires (M498) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:47:02 -04:00
bvandeusenandClaude Opus 5.5	8daa3d07b5	fix: a slot emptied of another song's file drops that file's recording MBID, so missing-pair folding cannot fold it into the copy kept (M498) ... On 2026-10-20 twelve of the 24 slots the resolver emptied were folded by MBID into the kept copy, so their albums were never wanted back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:39:17 -04:00
bvandeusenandClaude Opus 5.5	304caaee02	fix: the AcoustID rate-limit test bounds arrivals by the service's 3 a second, not the client's send spacing ... Run 9543 saw two arrivals 389ms apart though the client sent them 400ms apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:29:00 -04:00
bvandeusenandClaude Opus 5.5	a3d9effca3	feat: when no slot an album gives one recording is its own, every copy is removed and the album fetched again (M498) ... Shnabubula's whole album, one 45-minute file, was filed as both Fading Light and Looking for Answers. Neither slot fits, so wrongSlots had nothing to keep and held the group. Every copy now goes when each is clearly another song's; a copy near its slot still holds the group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:21:43 -04:00
bvandeusenandClaude Opus 5.5	c8e855ae4a	feat: the duplicate resolver fetches a missing album track list from MusicBrainz to decide a wrong slot, five albums a pass (M498) ... 20 of the 34 groups left for review had no cached track list for their album: the catalogue only reads one when the wanted list or the importer needs it. The resolver now asks catalogue.RefreshReleaseGroup for an album it must decide and the catalogue has never read, through the shared MusicBrainz pacer, at most five a pass (hourly). An unreachable MusicBrainz stops the pass's fetching; a group read and found empty is not asked about again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:02:53 -04:00
bvandeusenandClaude Opus 5.5	c5868c00cc	feat: a version named after a dash counts as a version, and a song held twice beside a wrong slot no longer blocks it (M498) ... - songKey drops a dashed version suffix (" - Instrumental Version", " - Radio Edit", live, remix, mix, acoustic, demo, reprise, rework, VIP), so Andora's "Goodbye Yesterday - Instrumental Version" is distinct, not a wrong slot. - wrongSlots accepts several fitting copies when they share one title (Killjoy twice beside Dreamland): the other slot's copy is removed, and the doubled song is left for the next sweep to find as a pair the resolver merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 06:24:47 -04:00
bvandeusenandClaude Opus 5.5	80c711ac9d	fix: a wrong-slot removal reads without a counted noun (M498) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 23:31:11 -04:00
bvandeusenandClaude Opus 5.5	0f58ebcd6c	feat: duplicates settle themselves: retitled copies across releases link, alike versions on one album are dismissed, and a file in another song's slot is removed so the album is fetched again (M498 #6159-#6162) ... The operator's library had 536 groups waiting for review, 2026-10-19. A sample showed most were one recording under two titles on two releases. - The headline and the Duplicates count leave out cross-release groups, which the resolver keeps and links: the headline read 3,479 when 536 needed review. - Any group spanning albums is cross_release and is linked as one song, whatever its titles say. Nothing is deleted. - One album, two versions named as such ("Lovesick (Instrumental)") and not byte-identical: a new class, distinct, dismissed by the resolver. - One album, one recording under different song titles (mismatch): the album's cached MusicBrainz track list decides. When exactly one slot's song is as long as the file and every other slot's song is clearly not, the other copies are removed and their tracks marked missing, so the reacquisition sweeper wants the album back. Otherwise the group stays for review. - The duplicates_found notice moves from the sweep to the resolver: it names only groups a pass first left for review. - Resolved automatically lists dismissals and wrong-slot removals beside merges. Migration 0094 adds 'distinct' to the class CHECK (rule 36). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 23:22:38 -04:00
bvandeusenandClaude Opus 5.5	8538f0dc68	fix: the playback-error test matches the prefixed username, and announcementFor keeps detekt's two returns (M542) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 22:53:13 -04:00
bvandeusenandClaude Opus 5.5	854c307834	feat: notifications say what changed and alert once: a grouped notice names the tracks, grows without re-alerting, and a phone pile lists its titles (M542 #6146-#6151) ... - An update to a grouped notice keeps its arrival time and email state, so the phone and the email no longer go off again each time it grows. - Notices carry the names of what changed (newest ten), shown as three and "and N more": tracks still missing after the scan's move/replacement fold, duplicate groups new to a sweep, songs merged automatically, and the track and listener a playback error was for. - Duplicates found counts only the groups new to that sweep; playback errors count reports, not the unresolved total. - A scan failure says what stopped and links to Admin > Library. - Android: a pile of more than three alerts lists the newest five titles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 22:44:19 -04:00
bvandeusenandClaude Opus 5.5	2365514e5b	test: TestPlanRoots looks for the empty-list refusal as the message words it (#6129) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 20:40:54 -04:00
bvandeusenandClaude Opus 5.5	edcb3a57ef	feat: the library's folders are set in Admin › Library, and changing a folder moves its tracks with it, keeping their plays, likes and playlists (#6129) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 20:37:03 -04:00
bvandeusenandClaude Opus 5.5	453a977e48	refactor: the admin and user Requests pages draw a request with one RequestRow, and the kind chip is one KindPill there and on Hidden tracks (#5651) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 18:20:53 -04:00
bvandeusenandClaude Opus 5.5	db15713798	refactor: the server says a count one way, words.Count, for notifications, a wanted match's reason and the duplicate resolver's activity line (M505 #5643) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 16:18:50 -04:00
bvandeusenandClaude Opus 5.5	9e24b2b4fc	refactor: every count in the web app is said by one plural(), with the viewer's thousands separator; a source guard names any hand-written copy (M505 #5642) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 16:18:04 -04:00
bvandeusenandClaude Opus 5.5	af2d4f9859	refactor: a running download is worded the same on the admin Overview as on the wanted list, from one liveDownloadLine (M505 #5641) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 16:15:21 -04:00
bvandeusenandClaude Opus 5.5	622f248ea2	refactor: track lengths and file sizes come from the shared formatters on Missing files, Duplicates, a want's Releases and the app download; an hour-long track reads 1:01:05, not 61:05 (M505 #5639 #5640) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 16:14:01 -04:00
bvandeusenandClaude Opus 5.5	9e7d50b38e	fix: FLAC, Ogg and Opus tracks carry their MusicBrainz recording id from the tag: one reader in library gives the scanner, the backfills and the importer the same ids, and the next scan re-reads the library (#5637) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 15:55:25 -04:00
bvandeusenandClaude Opus 5.5	c1305a547d	feat: the admin Overview shows who is listening, downloads, the library and its disk, and the server's version, uptime and recent errors; a download waiting on you, a client not answering or a full disk count in its verdict (M504 #5627 #5628 #5629 #5630) ... The version moves to internal/buildinfo, so /rest/ping reports the build instead of "dev". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 14:51:41 -04:00
bvandeusenandClaude Opus 5.5	ead0abf0cf	feat: one Missing files page under Collection: folders gone, each with its album's want, last search or download, and Search, Releases and Remove; an album held before its files went is no longer shown as held again (M504 #5626) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 14:44:33 -04:00
bvandeusenandClaude Opus 5.5	38b2325d2d	feat: Reports, Duplicates and Suspect sources live under Collection, with their counts on its rail and a "To look at" line naming the ones waiting; notices link there (M504 #5625) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 14:35:59 -04:00
bvandeusenandClaude Opus 5.5	12725e71b0	fix: the reports test name keeps its apostrophe inside double quotes, and the merge API test sends no unmonitor (M502 #5525) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 13:55:55 -04:00
bvandeusenandClaude Opus 5.5	3a16732883	feat: Minstrel no longer talks to Lidarr: its connection, Delete via Lidarr and the unmonitor options are gone, and the track reports are plain quarantine (M502 #5525) ... Migration 0091 drops lidarr_config and renames the quarantine tables, types, indexes and the history column off the Lidarr name. The Integrations Lidarr card, the Reports "Delete via Lidarr" action, the merge and remove-track unmonitor options, the Lidarr audit actions and error codes go, on the server, web and Android. The README describes acquisition as it is now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 13:48:20 -04:00
bvandeusenandClaude Opus 5.5	c54792c51e	feat: a held album below the quality you settle for, or holding a video rip, stays wanted for a better copy, and the import replaces the old tracks with their likes and plays carried over (M502 #5524) ... - acquisition_settings.upgrade_until (default High quality lossy, Lidarr's cutoff, note #5527; "" is off), an "Upgrade until" row under Searching. - The wanted worker judges held albums hourly: tier per format from size per second (the scanner records no bitrate), the album's worst. Below the cutoff it is wanted for quality; a video rip among its tracks always. - The schedule searches upgrades weekly, after open wants; a release no better than the copy held is refused ("not_better"). - The import matches each file to the track it would replace (recording, then disc/track) and replaces it when it is a rip or the file is a better tier: over the same path in one rename, or filed beside it and the old track folded in (library.ReplaceTrack: file first, then foldTrackInto). Nothing better: the release is set aside. - Collection › Upgrades (Lidarr's Cutoff Unmet); Suspect sources says when a clean copy was looked for instead of Lidarr's search. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 12:24:59 -04:00
bvandeusenandClaude Opus 5.5	a5ad301c94	feat: Users, Diagnostics and Tuning sit on the admin layout like the rest: debug mode is a row action on Users, every admin load error has Try again, and figures carry their scale (M503 #5608) ... - Users: a one-line count of accounts, admins and open invites; Turn on/off debug mode in each row's actions, and a "debug on" badge that opens that account's events - Diagnostics: no title or paragraph of its own; devices named by account, OS, app version and last seen, not client id; opens on ?account= - Tuning: each profile, the taste build and Discover are row groups with one-line hints; the sparkline has a 0–100% axis - Requests, Duplicates, Missing files and Suspect sources: load errors offer Try again - Library: cover art reads "N of M albums have art" Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 11:52:51 -04:00
bvandeusenandClaude Opus 5.5	0049b64ff1	fix: the AcoustID and Library tests expect the new copy and one folder per line (M503 #5607) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 11:30:20 -04:00
bvandeusenandClaude Opus 5.5	7f913e3e70	feat: the admin settings cards read as menus: each a titled group of rows with one short line, status first, failures in words (M503 #5607) ... Indexers and clients, searching, missing files, Lidarr's neighbours, AcoustID, fingerprinting, loudness, outgoing email's schedule, public address and proxies move from paragraph cards to SettingsGroup and SettingRow. Switches are role="switch". Also fixes the two type errors run 9023 found: the Lidarr test result is narrowed before its lists are read, and the tag-source save mock carries version_bumped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 11:25:46 -04:00
bvandeusenandClaude Opus 5.5	7e1cfb8d08	feat: Integrations splits into Library, Acquisition, Metadata sources and Email & network, each a page on the admin rail; the Overview keeps only what needs you (M503 #5607) ... - Library: the folders, Run scan and a row per scan job, cover art, fingerprints and loudness (off the Overview and Duplicates) - Acquisition: indexers and clients, searching, re-acquisition (off Missing files), Lidarr - Metadata sources: AcoustID, and one provider block for cover art and tags in place of the pasted pair - Email & network: outgoing email, the notification schedule, public address, proxies - Lidarr, outgoing email and the provider block are rebuilt as SettingsGroup rows; failures read as sentences, not codes - Duplicates and Missing files say what their setting is and link to where it is set Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 11:21:48 -04:00
bvandeusenandClaude Opus 5.5	0cc4bc686a	fix: a report's details keep the space before a note, and the Reports menu test opens the row it means (M503 #5606) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 10:57:02 -04:00
bvandeusenandClaude Opus 5.5	89a2653995	feat: Admin › Reports is one queue of broken tracks, whether a listener flagged it or it failed to play, one row per track with one set of actions (M503 #5606) ... - /admin/reports folds the quarantine queue and the unresolved playback errors into one row per track, newest first: who flagged it and why, what failed and for whom, the file, with Resolve (clears the reports and marks the errors fixed), Play, Copy details, Delete file and, for an album Lidarr holds, Delete via Lidarr. - One delete path: Delete file removes the track, and its reports and errors go with the row. - A Handled tab shows what was done: reports cleared, files deleted, errors marked fixed or ignored. - The summary counts reports by track across both sources, so the rail, the Overview and the page agree. - /admin/quarantine and /admin/playback-errors redirect to Reports: the notifications and the Android app link to them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 10:53:58 -04:00
bvandeusenandClaude Opus 5.5	864eb45580	feat: Settings uses the width of a wide screen: groups sit in two columns, each narrow enough that a row's control stays near its name (M503 #5595) ... The content was capped at max-w-3xl, so a wide window showed one narrow strip and a lot of empty space. SettingsColumns lays a page's groups out as one column on a phone or narrow window and two side by side from xl up; the page cap moves to 100rem so the columns don't stretch on a very wide screen. - Account: Android app, Profile and Password, with Signed-in devices beside. - Playback: "Between tracks" (crossfade) beside "Volume leveling". - Connections: ListenBrainz beside Subsonic apps. - Appearance, Notifications, About: one column's width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 10:28:06 -04:00
bvandeusenandClaude Opus 5.5	ace7e22e6a	feat: Admin is a left rail with how many wait on you in each queue, and the Overview opens with a verdict, the queues that need you and since when, then the clear ones on one line (M503 #5605) ... - GET /api/admin/summary: every admin queue (requests, reported tracks, playback errors, duplicates, suspect sources, missing files) with its count and the age of its oldest item, in one query. - The admin layout drops the 11-tab strip for SectionRail, as Settings and the Collection have, with each queue's count as its badge; the counts refresh on each admin navigation and every 30s. - The Overview leads with "Nothing needs you." or "N things need you.", lists each waiting queue with "oldest 3d ago" and a link to it, counts a failed library scan as a problem, and names the empty queues on one line. The request and quarantine previews and the stat tiles are gone; those queues are worked on their own pages. A failed summary says so with Try again instead of reading as all-clear. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 09:58:13 -04:00
bvandeusenandClaude Opus 5.5	7c89e59536	fix: admin bugs from the audit: a playback-error delete no longer reports failure, a failed Overview load no longer reads as all-clear, and email settings can't be saved over with defaults (M503 #5604) ... - Playback errors: Delete file stops resolving the error row the track deletion already took with it (ON DELETE CASCADE), which 404'd into "Delete failed". - Overview: a queue that fails to load says so with Try again, and its tile shows a dash, not 0. Delete via Lidarr shows only for an album Lidarr holds while Lidarr is connected. An approve refreshes the Collection. - Quarantine: Delete via Lidarr is in the row menu, so a phone reaches it; "1 report", not "1 reports". - Duplicates: the Keep badge follows the copy picked. - Integrations: provider save failures and load errors are said, not swallowed or shown as "No providers registered"; the Lidarr test catches a failed call; SMTP fills once and Save stays off until it has loaded. Lidarr's blurb says what it is still used for. - Requests: release profiles point at Collection › Following. - Library: an empty library sends an admin to Admin to run a scan, and tells anyone else the admin scans it, instead of opening Settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 09:40:11 -04:00
bvandeusenandClaude Opus 5.5	c94c09aeae	feat: Settings is one page per section down a left rail, Account first, every setting a row; the profile form no longer saves blanks over your name and email (M503 #5595 #5596 #5597) ... - /settings lands on Account: the Android app, profile, password, signed-in devices. Then Playback, Appearance, Notifications, Connections, About. - Each setting is a row (name, one short line, control at the end) in a capped-width column; one-of-N choices are a shared Segmented control. - Collection and Settings share one SectionRail. - Connections leads ListenBrainz with a status line: not connected, connected and not sending, or sending with the last scrobble's age. - Notifications prints its column labels once; the digest email's settings link points at /settings/notifications. - #5596: the profile form now loads what is stored and sends only the fields that changed. It used to start blank, and the server reads a blank as "clear", so one Save wiped the display name and email. - Recommendation metrics moves to Library › Your listening, and Hidden tracks gets a Library tab. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 23:34:51 -04:00
bvandeusenandClaude Opus 5.5	c0c0f8a71f	feat: Now Playing's cover grows to fill the screen, and the page takes the cover's dominant colour as Android does (#5592) ... The web colour helper now picks Palette's dominant swatch (5-bit quantise, Palette's default filter, median cut to 16, the most-populated box) instead of the 1x1 mean, so the web and Android agree; PlayerBar's accent strip shares it. Now Playing draws Android's gradient (55% at the top, 18% at 45%, then the page) as a masked background colour that fades over 600ms between tracks, holding the old colour until the new resolves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 23:05:05 -04:00
bvandeusenandClaude Opus 5.5	2f2573dd07	fix: the re-tag test sets its clock one statement at a time, as a prepared statement takes only one (M502 #5579) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 22:23:16 -04:00
bvandeusenandClaude Opus 5.5	a8786abace	feat: Collection › Unmatched lists the library albums no MusicBrainz album matched, each matched by hand from a search or a link, or left off (M502 #5579) ... Like Lidarr's Unmapped Files. A local band's album, which MusicBrainz will never have, is left off: never matched again and not counted. A re-tagged album is matched again on the next listing. The Collection's verdict now says when library albums need matching. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 22:12:30 -04:00
bvandeusenandClaude Opus 5.5	10be068dcc	fix: the player bar's heart is Lucide's, outlined then filled as on Android, and its title and artist read at the size of the rest of the page (#5580) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 22:12:29 -04:00
bvandeusenandClaude Opus 5.5	358849de77	feat: the Wanted view becomes Collection, shaped like Lidarr: an artist catalogue first, the state sections down a left rail (M502 #5577) ... The section opens on a catalogue of every artist on the list, A–Z with a letter rail, each card showing how many of their albums are held. An artist opens on their page: every album of theirs, held or not, with its status, search, releases and tracks. Wanted, Missing files, Activity, Following and Blocked sit down a left rail as the sections that show state; Held is gone, the catalogue shows it. The section moves from /wanted to /collection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 21:14:33 -04:00
bvandeusenandClaude Opus 5.5	a4fbe44bd5	feat: the Wanted view lists artists A–Z with their albums inside, each album's tracks a click away (M502 #5572) ... The list runs like the library: artists by the library's sort name, each artist's albums oldest first, grouped under the artist (linked into the library when it holds them). A filter narrows it to an artist or album by name, on the server, so it finds what has not been scrolled to. Tracks opens an album's track list: the library's own for an album it holds, a lost file marked, otherwise MusicBrainz's standard edition, named. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 18:43:32 -04:00
bvandeusenandClaude Opus 5.5	ca57133c8a	fix: a release group whose title names a live, remix or demo version is wanted only when the profile allows that version (M502 #5573) ... MusicBrainz types My Chemical Romance's "Common People (Recorded For BBC Radio 1)" as a plain Single, so a studio-only follow wanted it. Passes now reads the title's qualifier (brackets, or after a dash) for the version it names and treats it as a secondary type; a version no type names, an acoustic or instrumental one, no profile passes. The follow check takes off the list an open follow want the rule now refuses. Judge counts bbc, sessions and unplugged as live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 18:39:35 -04:00
bvandeusenandClaude Opus 5.5	7ef1fca90c	fix: an album holding every track of an edition, and more besides, is that release group (M502 #5569) ... Savant's "Void" folder holds all 23 tracks of the VOID (DLC) edition plus 20 more, and was refused at 23 of 43. A whole edition of three or more tracks now matches whatever else the folder holds; singles and two-track releases still need most of the album's tracks, since many albums hold their songs. Matcher version 4 retries the refusals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 18:14:56 -04:00
bvandeusenandClaude Opus 5.5	1936fe77c6	fix: the matcher-retry test stamps the listing's cutoff after its albums exist, as a listing done before them would not see them (M502 #5569) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 17:51:42 -04:00
bvandeusenandClaude Opus 5.5	bf409d5f3f	fix: a second copy of a track counts once, joining words don't part two titles, and a newer matcher retries an older one's refusals (M502 #5569) ... The second run's refusals were mostly albums holding a track twice (a two-track single with three files), which no edition can pair, and release names that differ only in "+" against "/". Tracks are now read once per disc, number and title, and "and", "&" and "+" count for nothing when titles are compared; an edition's own title also counts as the album's name. library_album_matches records which matcher version decided each album. Refusals by an older version are matched again, even after the listing is done, so an improvement reaches them without a migration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 17:44:06 -04:00
bvandeusenandClaude Opus 5.5	80d2fdc3ab	fix: under the album's own name, matching track titles are enough to match it; a refusal says which track differed and how (M502 #5569) ... The first run on the library refused singles whose one track has the album's title ("0 of 1 agree") and near-complete albums (11 of 14), because every track's length had to fit as well. Lengths now only decide between groups whose names merely overlap. The reason for a refusal names the first track that differed, with both titles and lengths, so what is left can be judged. Migration 0087 clears the refusals so those albums are matched again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 17:29:42 -04:00
bvandeusenandClaude Opus 5.5	b887ab759b	fix: every library album is matched to MusicBrainz before it is listed, by its tags, its artist's discography or a search, and checked against its tracks (M502 #5569) ... The one-time listing took only albums whose tags already named their release group and artist, and left 340 off the list. The rest are now matched: the release their tags name, else the artist's release groups called what the album is called, else a MusicBrainz search by artist and title. A group found by name is taken only when its tracks agree with the album's (by disc and number, then title; length and title, or recording), so a partial copy still matches and a same-titled other album does not. library_album_matches records each album the listing decided, listed or unmatched with why, so an album taken off the list is never re-listed. The albums no match was found for are named on the Held tab. Album rows with no tracks are no longer counted. The length and title checks move from the importer to release, shared by both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 17:16:05 -04:00
bvandeusenandClaude Opus 5.5	2c677b3184	feat: the library's albums go on the wanted list as held, once; after that the list is the truth (M502 #5567) ... A one-time job in the wanted worker lists every album in the library as a held want, one per release group, with a record that it happened (acquisition_settings.library_listed_at). Albums whose tags name only a release are named on MusicBrainz first, 120 a pass; what nothing names is counted and shown on the Held tab. Re-acquisition now wants back only albums on the list. Taking a held album off the list leaves its files, and it is never fetched back; albums put in the library folder by hand afterwards are not added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 16:13:46 -04:00
bvandeusenandClaude Opus 5.5	bc198a9389	fix: the Activity test's page carries clients_down as a value, not a literal Page<T> would refuse (M502 #5523) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 15:35:21 -04:00
bvandeusenandClaude Opus 5.5	8245f4406e	feat: download lifecycle — stalled and failed downloads are given up and searched again; imported ones seed, then go (M502 #5523) ... Ported from Fabled Librarian's System 104. A new lifecycle poller, every ten minutes: - a download the client fails is given up at once; - one nobody shares, or still fetching its file list, past the stall setting (6 h) is asked for again three times, then given up; - giving up removes the download with its files, holds the release back for a week (release_blocks.expires_at), ends the grab and searches the album again, with no limit per album; - a running download the client stops listing for half an hour ends and is searched again, not held back; an empty list is not taken as gone; - an imported download seeds to ratio 2.0 or 14 days, then is removed; - a download the client would not remove is asked again every pass. Every condition and act is one open row per (client, download, condition) in download_interventions. Activity shows what is wrong with a download and how often it was retried, why one ended, its seeding, and a banner for a client that does not answer. A running download can be given up by hand (set aside for good). The seed ratio, seed days and stall hours are on the search settings card. The download client lookup moves to acquire.DownloadClientFor, shared by the importer and the lifecycle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 15:27:22 -04:00
bvandeusenandClaude Opus 5.5	d9e00d8bc2	fix: the integrations test's library folder isn't /music, which a Lidarr root folder there is named (M502 #5522) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 10:53:43 -04:00
bvandeusenandClaude Opus 5.5	f268b4df09	fix: WantList's prop is list, not state, which Svelte reads as the $state store; the length test's 4-minute case fits within 3% (M502 #5522) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 10:44:21 -04:00
bvandeusenandClaude Opus 5.5	ebbc49b902	feat: import with verification, and a Wanted view of its own (M502 #5522) ... A finished download is checked against MusicBrainz before anything is filed: the files are paired with an edition's tracks by position or path, and AcoustID, tag ids, lengths and titles say whether it is the album. What is the album is copied into the library as Artist/Album (Year)/Artist - Album - NN - Title, tagged with Picard's MusicBrainz ids, and scanned; the download keeps seeding. What is not is refused: set aside, removed from the client, and the album searched for again. A download the check cannot settle waits for a person, who imports it anyway or refuses it. Tracks the library already holds are skipped. The wanted list leaves Admin for a top-level Wanted view, admin-only and web-only, with tabs for Wanted, Activity (downloads and their imports, the ones needing a person first), Missing files, Held, Following (with the release-type profiles, moved off Integrations) and Blocked. The search settings gain "File new music into" when the library has several folders. The search pass logs why each failed search failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-10 10:36:21 -04:00