fix(server/m7-cover-sources): forward-fix CI — unused-parameter lint

revive's unused-parameter rule flagged 7 test handler/method args:
- provider_test.go: fakeProvider.Configure(s) and
  fakeAlbumProvider.FetchAlbumCover(ctx, mbid) — interface
  conformance dummies that don't use their args.
- provider_mbcaa_test.go: 4 httptest handlers that ignore one or
  both of (w, r).
- provider_theaudiodb_test.go: the disabled-provider negative
  test's httptest handler.

All 7 renamed to _ per revive's convention.
This commit is contained in:
2026-05-06 17:59:29 -04:00
parent 4911b2a0d5
commit fabbe777ec
3 changed files with 7 additions and 7 deletions
+4 -4
View File
@@ -69,7 +69,7 @@ func TestMBCAAProvider_FetchAlbumCover_Success(t *testing.T) {
}
func TestMBCAAProvider_FetchAlbumCover_NotFound(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
http.Error(w, "not found", http.StatusNotFound)
}))
defer srv.Close()
@@ -82,7 +82,7 @@ func TestMBCAAProvider_FetchAlbumCover_NotFound(t *testing.T) {
}
func TestMBCAAProvider_FetchAlbumCover_DisabledReturnsNotFound(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
srv := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, _ *http.Request) {
t.Error("server should not be hit when provider is disabled")
}))
defer srv.Close()
@@ -117,7 +117,7 @@ func TestMBCAAProvider_Configure_TogglesEnabled(t *testing.T) {
}
func TestMBCAAProvider_TestConnection_TreatsNotFoundAsSuccess(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
http.Error(w, "not found", http.StatusNotFound)
}))
defer srv.Close()
@@ -129,7 +129,7 @@ func TestMBCAAProvider_TestConnection_TreatsNotFoundAsSuccess(t *testing.T) {
}
func TestMBCAAProvider_TestConnection_PropagatesTransient(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
http.Error(w, "boom", http.StatusInternalServerError)
}))
defer srv.Close()
+2 -2
View File
@@ -19,7 +19,7 @@ func (f *fakeProvider) ID() string { return f.id }
func (f *fakeProvider) DisplayName() string { return f.display }
func (f *fakeProvider) RequiresAPIKey() bool { return f.requiresKey }
func (f *fakeProvider) DefaultEnabled() bool { return f.defaultOn }
func (f *fakeProvider) Configure(s ProviderSettings) error { return nil }
func (f *fakeProvider) Configure(_ ProviderSettings) error { return nil }
// fakeAlbumProvider opts into the AlbumCoverProvider capability for
// the capability-filter test.
@@ -27,7 +27,7 @@ type fakeAlbumProvider struct {
fakeProvider
}
func (f *fakeAlbumProvider) FetchAlbumCover(ctx context.Context, mbid string) ([]byte, error) {
func (f *fakeAlbumProvider) FetchAlbumCover(_ context.Context, _ string) ([]byte, error) {
return []byte("img"), nil
}
@@ -245,7 +245,7 @@ func TestTheAudioDB_DefaultsToTestKeyOnEmpty(t *testing.T) {
}
func TestTheAudioDB_DisabledReturnsNotFound(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
srv := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, _ *http.Request) {
t.Error("server should not be hit when provider is disabled")
}))
defer srv.Close()