From fabbe777ece88802cac0c1520ba0a135bc0aa422 Mon Sep 17 00:00:00 2001 From: Bryan Van Deusen Date: Wed, 6 May 2026 17:59:29 -0400 Subject: [PATCH] =?UTF-8?q?fix(server/m7-cover-sources):=20forward-fix=20C?= =?UTF-8?q?I=20=E2=80=94=20unused-parameter=20lint?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit revive's unused-parameter rule flagged 7 test handler/method args: - provider_test.go: fakeProvider.Configure(s) and fakeAlbumProvider.FetchAlbumCover(ctx, mbid) — interface conformance dummies that don't use their args. - provider_mbcaa_test.go: 4 httptest handlers that ignore one or both of (w, r). - provider_theaudiodb_test.go: the disabled-provider negative test's httptest handler. All 7 renamed to _ per revive's convention. --- internal/coverart/provider_mbcaa_test.go | 8 ++++---- internal/coverart/provider_test.go | 4 ++-- internal/coverart/provider_theaudiodb_test.go | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/internal/coverart/provider_mbcaa_test.go b/internal/coverart/provider_mbcaa_test.go index f224156f..568898d5 100644 --- a/internal/coverart/provider_mbcaa_test.go +++ b/internal/coverart/provider_mbcaa_test.go @@ -69,7 +69,7 @@ func TestMBCAAProvider_FetchAlbumCover_Success(t *testing.T) { } func TestMBCAAProvider_FetchAlbumCover_NotFound(t *testing.T) { - srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { http.Error(w, "not found", http.StatusNotFound) })) defer srv.Close() @@ -82,7 +82,7 @@ func TestMBCAAProvider_FetchAlbumCover_NotFound(t *testing.T) { } func TestMBCAAProvider_FetchAlbumCover_DisabledReturnsNotFound(t *testing.T) { - srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + srv := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, _ *http.Request) { t.Error("server should not be hit when provider is disabled") })) defer srv.Close() @@ -117,7 +117,7 @@ func TestMBCAAProvider_Configure_TogglesEnabled(t *testing.T) { } func TestMBCAAProvider_TestConnection_TreatsNotFoundAsSuccess(t *testing.T) { - srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { http.Error(w, "not found", http.StatusNotFound) })) defer srv.Close() @@ -129,7 +129,7 @@ func TestMBCAAProvider_TestConnection_TreatsNotFoundAsSuccess(t *testing.T) { } func TestMBCAAProvider_TestConnection_PropagatesTransient(t *testing.T) { - srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { http.Error(w, "boom", http.StatusInternalServerError) })) defer srv.Close() diff --git a/internal/coverart/provider_test.go b/internal/coverart/provider_test.go index 55f33423..9b33ffee 100644 --- a/internal/coverart/provider_test.go +++ b/internal/coverart/provider_test.go @@ -19,7 +19,7 @@ func (f *fakeProvider) ID() string { return f.id } func (f *fakeProvider) DisplayName() string { return f.display } func (f *fakeProvider) RequiresAPIKey() bool { return f.requiresKey } func (f *fakeProvider) DefaultEnabled() bool { return f.defaultOn } -func (f *fakeProvider) Configure(s ProviderSettings) error { return nil } +func (f *fakeProvider) Configure(_ ProviderSettings) error { return nil } // fakeAlbumProvider opts into the AlbumCoverProvider capability for // the capability-filter test. @@ -27,7 +27,7 @@ type fakeAlbumProvider struct { fakeProvider } -func (f *fakeAlbumProvider) FetchAlbumCover(ctx context.Context, mbid string) ([]byte, error) { +func (f *fakeAlbumProvider) FetchAlbumCover(_ context.Context, _ string) ([]byte, error) { return []byte("img"), nil } diff --git a/internal/coverart/provider_theaudiodb_test.go b/internal/coverart/provider_theaudiodb_test.go index 60823703..7e7dd666 100644 --- a/internal/coverart/provider_theaudiodb_test.go +++ b/internal/coverart/provider_theaudiodb_test.go @@ -245,7 +245,7 @@ func TestTheAudioDB_DefaultsToTestKeyOnEmpty(t *testing.T) { } func TestTheAudioDB_DisabledReturnsNotFound(t *testing.T) { - srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + srv := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, _ *http.Request) { t.Error("server should not be hit when provider is disabled") })) defer srv.Close()