506 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
bvandeusenandClaude Opus 5.5	c6f10f157d	Timeline shows archived notes too, each one labelled Archived ... Timeline lists everything not in Trash. The card's Archived label is now hidden only on the Archive page, read off the route: Timeline keeps its own list and never sets the board's view, so arriving from the Archive used to leave the store saying "archived". Task #6318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 17:29:40 -04:00
bvandeusenandClaude Opus 5.5	66fd5707b7	tagQueryAt decides in one check, within detekt's return limit ... Task #6316. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 16:38:36 -04:00
bvandeusenandClaude Opus 5.5	7e96683f01	The archive-search tests sign in and keep the listed notes alive ... The integration test registers the owner before writing notes, and the core test binds the "all" listing before borrowing ids from it. Task #6315. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 16:28:01 -04:00
bvandeusenandClaude Opus 5.5	ba97003ea0	Android editor suggests existing tags while a #tag is typed ... The web editor's `#` suggestions, ported: with the caret in a `#tag`, a row of chips under the field offers the existing tags that finish it, prefix matches first and busiest first. A tap puts in the whole name and a space. The rules are the web's tags.ts, with the same test cases. Task #6316. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 16:23:08 -04:00
bvandeusenandClaude Opus 5.5	b98a0c315f	Search and tags look through the Archive, and archived cards say so ... A search or a tag filter on the main board, and a tag's own view, now list every note not in Trash (a new `all` board view on the server and in the core), so finished work can still be looked up. Archive and Trash keep a search inside themselves. An archived note met anywhere but the Archive carries an "Archived" chip at the top of its card, on the web and on Android. Task #6315. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 16:23:08 -04:00
bvandeusenandClaude Opus 5.5	5780220ff1	The image build stops pruning the runner's shared Docker daemon ... The build job ran `docker system prune -af` on the runner's shared Docker daemon. That deletes every image no container is using at that moment, including images other repos' jobs had just pulled and were about to start. Jobs with a service container wait ~14s for it to become healthy between pull and create, and fail with "No such image" when a prune lands inside that wait (CI-runner #16). The runner host prunes nightly instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 10:20:33 -04:00
bvandeusenandClaude Opus 5.5	d1f8d1f561	The app links to its source, from an admin setting (#6228) ... #6228 "The app offers its source: a Source link from an admin setting (AGPL §13)". The AGPL requires a modified copy run for others over a network to offer them its source; Forge's #2282 is the shape followed. - Settings → General gains "Source code" (`source_url`), defaulting to the public repo so a stock install makes the offer. Empty hides it. - It is an http(s)-only URL setting, refused otherwise on save, and `safe_link` refuses anything else again when it is published, because the web renders it as an href. - /api/config carries it; the web shows "Source" beside the build number at the foot of the sidebar. The offline desktop's config has no such field, so the link stays hidden there. - ci.yml's client-bake comments no longer call the forge private; the repo has been public since #2091. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 21:20:07 -04:00
bvandeusenandClaude Opus 5.5	06ed76814f	Inkwell is licensed AGPL-3.0-only (#6227) ... #6227 "License Inkwell under AGPL-3.0-only: LICENSE file and SPDX identifier". The operator chose AGPL-3.0-only, as for FabledStash (#6212). - LICENSE is the canonical GNU AGPL v3 text from gnu.org: 661 lines, md5 eb1e647870add0502f8f010b19de32af, the same file as FabledStash's. - AGPL-3.0-only is declared in pyproject.toml, frontend/package.json (and its lockfile root entry), the four crates, and tauri.conf.json's bundle. - The pacman package declared MIT; it now declares AGPL-3.0-only. - pyproject's build floor moves to setuptools>=77, the first release that reads `license` as an SPDX expression. - The README's Licence section names the licence, links LICENSE, and states the network clause in one sentence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 21:12:37 -04:00
bvandeusenandClaude Opus 5.5	b354bc4871	README quick-start keeps restart: unless-stopped ... f16224b dropped it from the inline compose file, reading rule 198 "Shipped compose files run on the orchestrator's defaults" as covering it. The rule keeps plain Compose's restart: unless-stopped: Compose defaults to `no`, so without it a crash or reboot leaves the stack down, and Swarm ignores the key. docker-compose.yml already carries it (#6220). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 21:02:02 -04:00
bvandeusenandClaude Opus 5.5	f16224b07c	Root, CI, docs and packaging describe the project to a stranger (#6225) ... #6225 "Comment standard sweep: root, config, CI workflows, docs and packaging", milestone 546 "Bring the repo to the comment standard (rule 32) and compose defaults (rule 198)". - README restructured in newcomer order: what it is, quick start, configuration, setup pitfalls, updating and backups, features, troubleshooting, development, licence. Its quick-start compose carries no restart policy. - Dockerfile and .env.example trimmed to one or two lines per setting. - Workflows, packaging scripts and docs lose issue, run, note, rule and milestone references and their history narration. Comments that still described path filters and "step 6" as future work now state what the workflows do. - ci-requirements.md rewritten against the current workflows. It said the build gated on typecheck and lint only, the integration lane did not gate, a v* tag published :latest, and ci-tauri lacked bsdtar and zstd; none of those is true now (the last checked against run 9630's log). - Echo strings in guard-forward.sh and version.sh drop their note citations; every string a test asserts on is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 20:44:02 -04:00
bvandeusenandClaude Opus 5.5	01b53118b9	Core and desktop comments describe the code to a stranger (#6224) ... Milestone 546 "Bring the repo to the comment standard (rule 32) and compose defaults (rule 198)", step #6224 "Comment standard sweep: Rust core and desktop client". Doc comments and comments across inkwell-core, the Tauri app and desktop/packaging now say what the code does and the non-obvious why in the present tense. Gone: milestone tags (M10.x, M11.3, M13, M304, M315, M314, milestone 325), issue and Scribe-note numbers, family-idea and family-rule citations, the run numbers and commit hashes behind past bugs, and the narration of what used to be (the stable channel before it held its own bundles, CARGO_PKG_VERSION as the shown version, the MANIFEST_TAG split, the store's missing tests, the old PKGBUILD). The schema's migration notes keep what each step does and why, without "until now". The forge is called the forge rather than Forgejo. Hazards stay as facts: the dev-rolling tag that must not shadow the branch, the manifest matched on this build's version, the APK's fixed name surviving the prune, the LIKE guard in v9, -wal/-shm moving with the renamed store, panic = abort ending the app. 34 files, comments only: a comment-stripping diff of every changed file against HEAD is identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 20:30:37 -04:00
bvandeusenandClaude Opus 5.5	0a631219ee	Android comments describe the code to a stranger (#6223) ... Milestone 546 "Bring the repo to the comment standard (rule 32) and compose defaults (rule 198)", step #6223 "Comment standard sweep: Android client". KDoc, comments, manifest and resource notes, Gradle and TOML comments and the ffi crate's docs now state what the code does and the non-obvious why in the present tense. Issue, Scribe-note, milestone (M13, M304, M315, M12) and family-idea references are gone, as are comparisons to Minstrel and the narration of what used to be: the capture sheet the editor replaced, the per-note colour story, the operator's device-pass feedback, the bindgen-as-[[bin]] failure, the 0.60 edge alpha before it was re-solved, and the checker bugs behind check-strings/check-symbols. Hazards stay as facts: the signing key that can't be rotated, the alias that keeps the earlier name, PKCS12's single password, unwind over abort, the UTC date-picker read, the DerivedTint/colors.ts mirror. One stale claim is gone: DerivedTint said the web had no test runner, but notes/grammar.test.ts runs the same tint cases. detekt.yml said "these two places" over a list of five. 49 files, comments only: a comment-stripping diff of every changed file against HEAD is identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 20:24:52 -04:00
bvandeusenandClaude Opus 5.5	715b648b95	Web client comments describe the code to a stranger (#6222) ... Milestone 546 "Bring the repo to the comment standard (rule 32) and compose defaults (rule 198)", step #6222 "Comment standard sweep: web client (frontend/)". Comments, docstrings and template notes across frontend/ now say what the code does and the non-obvious why as present-tense facts. Issue, task, note, milestone and family-idea references are gone, along with narration of what used to happen: the titles index's wiki-link origin and its once-per-session load (#5165), the card-controls overlap a phone showed (task 2697), the M7 and M10.9 labels, and the card unification behind the reminders lens (task 1913). Hazards stay as facts, among them LEAVE_MS matching the editor's leave duration, the Android client twin that must not be widened, and keeping leavers in flow in the multi-column masonry. 62 files, comments only: a comment-stripping diff of every changed file against HEAD is identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 20:17:13 -04:00
bvandeusenandClaude Opus 5.5	a51a563fe7	Server comments describe the code to a stranger (#6221) ... Rule 32 "Comments describe the product to a stranger" sweep over src/, alembic/ and tests/. Comments and docstrings now say what the code does and the reason as a present-tense constraint, briefly. Removed: - issue, task, note, rule, milestone and family-idea references - "used to" / before-and-after narration - quotes of decisions and incident stories from the deploying instance - paragraph-length arguments, where a line or two carries the fact Kept every hazard as a present-tense fact, e.g. timing oracles, the proxy hop direction, and migrations that must stay frozen. Also: - Three test names lose "still"/"used to"/"pre_m304" phrasing. - pyproject's description drops "FabledSword family". The history these comments carried stays in Scribe and in git log. A comment-stripping diff (Scribe snippet #6226 "codeonly.py — prove a diff changed only comments") shows no code changed apart from the renamed tests and the description string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 20:07:47 -04:00
bvandeusenandClaude Opus 5.5	5556bb2136	Compose files run on the orchestrator's defaults (#6220) ... Shipped stacks drop every healthcheck and the depends_on service_healthy wait, per rule 198 "Shipped compose files run on the orchestrator's defaults: no healthcheck, no restart policy". A pg_isready healthcheck turns slow storage into a killed database. The app needs neither: inkwell.dbwait waits up to 60s for Postgres at start, and the engine's pool_pre_ping retries per request. - docker-compose.yml: db and app healthchecks removed; depends_on is a plain start order. Comments cut to one or two lines per setting under rule 32 "Comments describe the product to a stranger": the family/rule references are gone, and the three-way port explanation points at docs/public-hosting.md, which already holds it. - docker-compose.dev.yml: db healthcheck and service_healthy removed; header shortened. - README: the copy-paste stack loses the same two blocks. restart: unless-stopped stays: plain Compose defaults to no restart, and Swarm ignores the key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 19:45:46 -04:00
bvandeusenandClaude Opus 5.5	854cb4b403	Android: a hardware keyboard's arrow keys move the cursor (#6199) ... Scribe #6199 "Android: a hardware keyboard's arrow keys move focus instead of the cursor". Compose's text field sends the arrow keys of any device reporting D-pad keys to focus search before the field sees them, and a physical keyboard reports exactly that, so left and right jumped to the neighbouring control. Cancelling focus search in those directions hands the key back to the field. Up and down move between a field's lines, and from its first or last line on to the field above or below; single-line checklist rows still step row to row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 17:14:32 -04:00
bvandeusenandClaude Opus 5.5	19487b079a	Attached images open full size and copy back out (#6198) ... Scribe #6198 "An attached image can't be viewed large or copied back out". Web and desktop: clicking an image in the editor opens it full size, with Copy image (re-encoded to PNG, the one type every clipboard accepts), Download and Close. Copy hides where the browser has no async clipboard, such as a server reached over plain http; right-clicking the full-size image still copies there. Android: long-pressing an image in the editor copies it to the clipboard; a tap still opens it full size in the phone's viewer. Opening and copying share one hand-out that copies the file out of the blob store behind a FileProvider URI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 17:14:32 -04:00
bvandeusenandClaude Opus 5.5	142fafe0ed	Android recent tags: reuse ui/Time.kt's epochMillis (#5931) ... RecentTags.kt declared a second epochMillis(String?): Long beside Time.kt's epochMillis(String): Long?. A string literal resolved to the existing one, so the test asserted 0 against its null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 15:16:29 -04:00
bvandeusenandClaude Opus 5.5	7cb05b77c6	Android drawer: rememberTagViews lives with the recent-tags code (#5931) ... detekt's function-count limit on BoardScreen.kt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 15:07:09 -04:00
bvandeusenandClaude Opus 5.5	96e9fbfb3a	Android drawer: tag-view tracking in its own composable (#5931) ... detekt's cyclomatic-complexity limit on BoardScreen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 14:58:39 -04:00
bvandeusenandClaude Opus 5.5	1a212e6779	Android drawer: keep the board screen's imports in order (#5931) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 14:51:10 -04:00
bvandeusenandClaude Opus 5.5	ea831d1857	Rail and drawer: only the 5 tags most recently used or viewed (#5931) ... A long tag list pushed the drawer's Archive, Trash and Sync off screen on Android, where Tags still sat above them (#5915 only reordered the web rail). Tags now come last on Android too, and both clients list the five tags most recently used or viewed, by name, with "All tags (N)" opening the rest in place. Used: the newest untrashed note carrying the tag. GET /api/labels and the core's list_labels return it as last_used, and each client also folds in the notes it holds, so a tag applied a moment ago counts before the next listing. Viewed: opening the tag's lens, remembered on the device (per user on the web). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 14:41:33 -04:00
bvandeusenandClaude Opus 5.5	74d0d3d88e	Email: the Inkwell logo in the header ... The header showed only a yellow dot before the site name. It now shows the app icon, embedded in the message as an inline part (cid:inkwell-logo, the HTML part becoming multipart/related) rather than linked: most clients block remote images, the app fetches nothing (rule 164), and Gmail drops SVG and data: images. The PNG is a copy of frontend/public/icon-192.png, shipped as package data; a test keeps the two identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 14:30:18 -04:00
bvandeusenandClaude Opus 5.5	c04e949c40	Stored credentials are encrypted at rest (#5927) ... #5927 "Adopt the family idea secret.Box": the SMTP password and the backup bucket's secret key were kept as plain text in the settings table, so a copy of the database alone could read them. - New sealing.py: AES-GCM under an HKDF-derived key, each value bound to its setting's name. The key is a random file, /var/inkwell/sealing.key (0600), made on first use. It lives on the data volume, not in the database, which is where the signing secret sits by default. - set_settings seals a secret before storing it; get_setting opens it. A value that no longer opens (key file lost) reads as not set, so Settings asks for it again. - At startup, credentials stored before this are sealed in place, so nothing has to be re-entered. A data folder that can't be written never stops the server; saving a password then answers with the reason. - New dependency: cryptography (approved by the operator). Also #1919 "Deprecate / remove the PWA": kept. Its service worker caches only the offline page, so an installed copy always runs the live build. One stale comment in sw.js is corrected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 14:18:41 -04:00
bvandeusenandClaude Opus 5.5	edcb5c4c11	Backups: a daily dedupe-friendly tar to a folder or S3, with restore (#5918-#5921) ... #5918 "Backup file": an uncompressed tar of per-table JSON Lines (primary-key order, sorted keys) plus every attachment file, with fixed tar headers, a dated name, and an atomic write through a dot-named .part file. Unchanged rows are the same bytes every day, so restic off-site stores only the edits. No credential ever enters a backup. #5919 "Backup destinations": a folder, or an S3-compatible bucket through a stdlib SigV4 put/list client (checked against AWS's published signatures), with an upload limit. Test destination only lists, so an append-only key works. #5920 "Backup job": daily at a chosen hour, Back up now, a 1/2/4 h retry ladder, a one-hour deadline, an advisory lock, the last 30 runs, and an overdue verdict on Settings -> Backups. #5921 "Restore": python -m inkwell.restore FILE into an empty instance, an integration test that backs up and restores, and docs/backups.md with Fabled Archives as the worked example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 13:54:51 -04:00
bvandeusenandClaude Opus 5.5	c0de50d85d	Email: one branded HTML layout with a text part, and invites can be emailed (#5917) ... Each email was a subject and a plain-text f-string at its call site. mail_templates.py now holds one layout: the site name, a heading, the message, a button for the link and a footer saying who sent it and why. Every email (password reset, test, invite) is a function returning its subject, text and HTML. mailer.send sends them as multipart/alternative, text first. The HTML is email-shaped: tables, inline styles, no images or fonts, and every value from settings or a person escaped. POST /api/invites takes send_email. It is refused before anything is made when email is off or the invite names no address. The link is built from the public address. A failed send leaves the invite standing with email_error, so the admin still gets the link once. The invite form offers "Email the link to …" when email is on and an address is filled in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 13:43:13 -04:00
bvandeusenandClaude Opus 5.5	5cc71c3050	Settings: tabs instead of one long page, and a review pass (#5916) ... Settings was every registry group, then invites, accounts, groups and activity, in one scroll. It is now six tabs held in ?tab=: - General: General, Notes, Attachments, Links. - People: Access, Invites, Accounts, Groups. - Email, with a line saying whether email is on and what it still needs. - Security. - Activity. A registry group that no tab names lands on General, so it can't go missing. Save saves only the current tab. Edits waiting on other tabs keep their values and mark their tab with a dot. Leaving the page with unsaved edits asks first. Review fixes: - On a phone, a field stacks under its label instead of overflowing beside it. - Descriptions are easier to read. - The SMTP encryption choice shows readable names (choice_labels). - The test-email button uses .btn-sm and is disabled while email is off. - The accounts list is headed Accounts, not People, now that People is a tab. - The docs point at the new paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 13:41:03 -04:00
bvandeusenandClaude Opus 5.5	c63375b092	Rail: Tags sit below the other nav items (#5915) ... Tags is the one list in the rail that grows without limit, so everything with a fixed place goes above it and stays put. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 13:38:49 -04:00
bvandeusenandClaude Opus 5.5	8d67fc0da5	Web editor: a typed #tag shows as a chip, and # suggests existing tags (#5913, #5914) ... The tag row under the text was a copy of the note's labels taken when the editor opened. A #tag in the body becomes a tag on the server's side of a save, so the copy never learned of it until the note was reopened. Every save now hands its note back, and the row is refreshed from it. Typing # in a prose block or a checklist item opens the tags that already exist: prefix matches first, busiest first. Arrows move, Enter or Tab puts the tag in, Esc closes only the menu. The grammar and ranking live in notes/tags.ts with tests, so the menu never offers a tag the server would not derive. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 13:38:49 -04:00
bvandeusenandClaude Opus 5.5	67df94350c	DRY pass #3: the "from the text" mark is one composable (#5373) ... The label picker and the editor's tag row each wrote the same Text: the label_from_tag string, labelSmall, onSurfaceVariant, 8dp start padding. Chips.kt's FromTextMark() is now both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 20:14:24 -04:00
bvandeusenandClaude Opus 5.5	d6204d320a	One tag-name fold on the web and on Android, beside the core's (#5373, #5385) ... The web compared or keyed tag names with name.toLowerCase() at five sites: the labels store's merge check, LabelPicker's create check, NoteCard's colour map, and colors.ts twice. Android had three, plus TagsScreen's rename dialog using equals(ignoreCase = true). Each now calls foldTag(name), which says what the core's derive::fold and the server's labeling.named say. Android's rename dialog now predicts a merge the same way the core decides one. Per-character ignoreCase and full lowercasing disagree on letters like İ, whose lowercase is two characters. LabelPicker's search filter keeps its own lowercasing: that is search, not identity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 17:05:30 -04:00
bvandeusenandClaude Opus 5.5	0ecff7eeb9	Core: tag names fold every letter, as the server does (#5385) ... SQLite's lower() folds ASCII only, so a device could hold "Café" and "CAFÉ" as two tags while the server held one. derive::fold (to_lowercase) is now the one comparison. It is registered as the deterministic SQL function fold() on every connection (schema::migrate), and find_or_create, the rename clash, the pull clash and the unique index all use it. derive's push_unique used eq_ignore_ascii_case and now folds the same way. v14 merges pairs a device already holds before rebuilding the index. The older row survives, as in rename_label. Memberships move with via_tag kept, affected notes go dirty, and the merged-away row is a pending delete. It is written out rather than calling store::merge_labels so the migration doesn't depend on store code that later versions may change. rusqlite gains its "functions" feature (operator-approved, 2026-10-08). grammar.json gains "#café and #CAFÉ" -> ["café"], which all three implementations run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 17:01:42 -04:00
bvandeusenandClaude Opus 5.5	921c0a47bd	Real plurals: the web's sync messages and Android's tag counts ... Web: one counted(n, one, other) helper. The sync screen's three "(s)" messages (attachments that didn't download, changes refused, files that didn't upload) now say "1 file" / "2 files". The six hand-written ternaries (SyncView x2, ImportNotes, GroupList, ShareDialog, LabelsModal) use it too. Android: tags_count was two strings chosen in code, and is now <plurals>. The delete confirmation read "It is on 1 notes … removed from all of them" and now has a one form of its own. Operator decision on #5371, 2026-10-08. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 16:57:09 -04:00
bvandeusenandClaude Opus 5.5	29dd6dd351	Revert the forced APK failure (#5419) ... Run 8849 watched the gate reject: the APK job failed, "Build the server image" was skipped, ci.yml 8850 stood down, nothing was dispatched, and :dev still resolves to package version 11662 (pushed by 8848). This push checks the green direction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 16:54:41 -04:00
bvandeusenandClaude Opus 5.5	eb6a1ff3ef	Web: Activity loads older events as you scroll, no Show older button ... Preference 172. ScrollSentinel watches the end of a cursor-paged list and asks for the next page a screen early. It asks once per cursor, keeps going when a page lands without pushing the end off screen, and stops on a failure until Try again (an observer re-firing on a failure is a request loop). A failed older page now gets its own error beside the retry, instead of replacing the list's load error. Adapted from fabledstash's ScrollSentinel (snippet 3760). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 16:54:19 -04:00
bvandeusenandClaude Opus 5.5	962637ea8b	TEMPORARY: force the APK job red to watch the image gate reject (#5419) ... Reverted by the next commit. Expect: build fails, server-image skipped, no ci.yml dispatch, :dev unmoved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 16:51:54 -04:00
bvandeusenandClaude Opus 5.5	b2d50009d3	android.yml: a red Android lane no longer publishes the server image (#5419) ... server-image ran under always(), so a failed core check or APK build still dispatched ci.yml. Run 8839 published :<sha> for 0ecdbfe while its APK lane (8835) was red. Rule 177: nothing publishes on red. With always() dropped, the dispatch needs rust and build to succeed. A skipped decide still skips it, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 16:51:34 -04:00
bvandeusenandClaude Opus 5.5	76fe96d135	MainActivity imports OnEachForeground (#5372) ... fb95c9b moved the foreground latch into ui/ForegroundTransitions.kt, but MainActivity lives one package up and imports what it uses from ui by name; run 8835's compileDebugKotlin stopped on the two unresolved calls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 16:05:41 -04:00
bvandeusenandClaude Opus 5.5	ef22910154	DRY pass #3: the labels store swaps a returned label in one way (#5373) ... rename and setColor each found the label and replaced it, keeping the count the single-label PATCH doesn't recompute; keepingCount(updated) is that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:39:25 -04:00
bvandeusenandClaude Opus 5.5	cd8df384a4	DRY pass #3: one compact dialog button (#5373) ... ShareDialog's Share and NoteEditor's Add note / Close each spelled out the same compact button, smaller than .btn. .btn-compact is its shape and .btn-compact-primary its brand fill; Close keeps its neutral colours beside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:38:36 -04:00
bvandeusenandClaude Opus 5.5	0ecdbfe257	desktop.yml: every job has its own deadline (#5409) ... Run 8830's Linux bundle sat on a rust-lld link whose 17 threads were all parked on futexes until the runner's own 30-minute cap ended it. verify, the Linux and Windows builds get 20 minutes (warm runs take ~4, and a cold one compiles the tree in about two), the manifest 5. Kept under the runner's cap so these are the limits that fire. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:37:34 -04:00
bvandeusenandClaude Opus 5.5	78810d8832	DRY pass #3: core tests open their store and seed a label one way (#5373) ... Five test modules wrote the same db() over memory_conn, and portable.rs unwrapped it inline; local::test_db() is that. Four pull/push tests wrote the same label INSERT; local::seed_label(conn, id, name, dirty) is it. Both are cfg(test), beside memory_conn, as wire::sample_note is beside wire::Note. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:17:30 -04:00
bvandeusenandClaude Opus 5.5	1b128a9374	DRY pass #3: a secret setting is the text input with a password type (#5373) ... SettingsView drew secret and plain text settings as two inputs differing only in type, autocomplete and the saved-value placeholder; one input binds those. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:16:16 -04:00
bvandeusenandClaude Opus 5.5	9dcdb43568	DRY pass #3: both sync work requests take one network-and-backoff policy (#5373) ... enable and pushSoon each set the CONNECTED constraint and the 30-second exponential backoff; B.online() on WorkRequest.Builder sets both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:16:04 -04:00
bvandeusenandClaude Opus 5.5	91ec677025	DRY pass #3: checklist near-misses live in the grammar fixture (#5373) ... test_notes.py and derive.rs each kept the same six lines of prose that look like a checklist item. Four were already task_lines cases in grammar.json; the other two (empty brackets, no bullet) join them, so the web suite now tests them too, and both hand lists go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:15:17 -04:00
bvandeusenandClaude Opus 5.5	0e21b8e7f1	DRY pass #3: SyncView's update choices are one fieldset, twice (#5373) ... The source and channel fieldsets were the same markup over different options. updateChoices holds each set with its legend, radio name and when it is offered, and one v-for draws them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:14:10 -04:00
bvandeusenandClaude Opus 5.5	31d8b1e65b	DRY pass #3: unlinking a device by id or by its own token is one tail (#5373) ... revoke_self and revoke_device each loaded the caller's DeviceToken, deleted it, committed and audited DEVICE_UNLINKED; _unlink_device(which) is that, owner-scoped as before, with each route keeping only how it names the row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:13:39 -04:00
bvandeusenandClaude Opus 5.5	498b23789c	DRY pass #3: one one-time secret reveal (#5373) ... AccountView's device-token reveal was OneTimeLink's markup and copy handler again. OneTimeLink becomes OneTimeSecret (value, note, noun = link | token), and the account page shows a new token through it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:13:18 -04:00
bvandeusenandClaude Opus 5.5	a0249564e2	DRY pass #3: the web asks one question about a password's length (#5373) ... RegisterView and ResetPasswordView each wrote the min-length check and its message; config.passwordRefusal(password) is that check, the web's side of auth._password_refusal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:12:32 -04:00
bvandeusenandClaude Opus 5.5	8c45725a2a	DRY pass #2, batch 8, F17: a person and an account have one shape each (#5372) ... Web: GroupList's Person was adapters/repo's Member field for field, and AccountList's Account was the session store's User; both now import them. The bridge's Identity stays, as the Tauri mirror of the core's struct. Server: auth._serialize_user and accounts' _serialize_account wrote the same four fields. serialize.serialize_user is serialize_person plus is_admin, and the account list adds created_at to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 15:11:29 -04:00