bvandeusen
58766dbebe
The PR1-T2 admin handler migration replaced bespoke 500-class messages
("lookup failed", "refetch failed", "trigger failed", "bump failed",
"remove failed", "update failed", "schedule row missing", "re-read
failed", "read failed") with apierror.Internal(err), which forces the
wire Message to "internal server error". That violates the PR1
contract that errEnvelope{Code, Message} must remain byte-identical
for existing clients.
Add apierror.InternalMsg(message, cause) — a 500-class constructor
that preserves the call site's user-facing message while keeping the
cause attached for logging and errors.Is. Re-migrate the 12 admin
sites whose pre-1cc7eb6 source had a non-empty bespoke Message so
they restore the original wire string. Sites whose original Message
was empty stay on Internal(err) (humanization to "internal server
error" is a tolerable improvement, not a regression).
admin_smtp.go's send_failed site (line 129) was already preserved
via a raw &apierror.Error literal in 1cc7eb6 and needs no fix.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
67 lines
2.2 KiB
Go
67 lines
2.2 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"net/http"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
"github.com/jackc/pgx/v5"
|
|
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/apierror"
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/coverart"
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
|
)
|
|
|
|
type adminCoverRefetchResp struct {
|
|
AlbumID string `json:"album_id"`
|
|
CoverArtPath *string `json:"cover_art_path"`
|
|
CoverArtSource *string `json:"cover_art_source"`
|
|
}
|
|
|
|
// handleAdminAlbumRefetchCover implements POST /api/admin/albums/{id}/cover/refetch.
|
|
// Synchronously clears + re-runs the enricher for one album.
|
|
func (h *handlers) handleAdminAlbumRefetchCover(w http.ResponseWriter, r *http.Request) {
|
|
albumID, ok := parseUUID(chi.URLParam(r, "id"))
|
|
if !ok {
|
|
writeErr(w, apierror.BadRequest("bad_request", "invalid album id"))
|
|
return
|
|
}
|
|
if err := h.coverart.RetryAlbum(r.Context(), albumID); err != nil {
|
|
if errors.Is(err, coverart.ErrNotFound) || errors.Is(err, pgx.ErrNoRows) {
|
|
writeErr(w, &apierror.Error{Status: http.StatusNotFound, Code: "not_found", Message: "album not found"})
|
|
return
|
|
}
|
|
writeErrWithLog(w, h.logger, "admin: cover refetch failed", apierror.InternalMsg("refetch failed", err))
|
|
return
|
|
}
|
|
row, err := dbq.New(h.pool).GetAlbumWithFirstTrackPath(r.Context(), albumID)
|
|
if err != nil {
|
|
writeErrWithLog(w, h.logger, "admin: post-refetch read failed", apierror.InternalMsg("read failed", err))
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, adminCoverRefetchResp{
|
|
AlbumID: uuidToString(albumID),
|
|
CoverArtPath: row.CoverArtPath,
|
|
CoverArtSource: row.CoverArtSource,
|
|
})
|
|
}
|
|
|
|
type adminBulkRefetchResp struct {
|
|
Queued int `json:"queued"`
|
|
}
|
|
|
|
// handleAdminBulkRefetchCovers implements POST /api/admin/covers/refetch-missing.
|
|
// Returns immediately; actual drain runs in a background goroutine bounded by
|
|
// the configured backfill cap.
|
|
func (h *handlers) handleAdminBulkRefetchCovers(w http.ResponseWriter, _ *http.Request) {
|
|
cap := h.coverArtBackfillCap
|
|
go func() {
|
|
bgCtx := context.Background()
|
|
if _, err := h.coverart.EnrichRetryMissing(bgCtx, cap); err != nil {
|
|
h.logger.Warn("admin: bulk cover refetch failed", "err", err)
|
|
}
|
|
}()
|
|
writeJSON(w, http.StatusOK, adminBulkRefetchResp{Queued: cap})
|
|
}
|