release / govulncheck (push) Successful in 15s
release / web (push) Failing after 1m21s
release / go (push) Successful in 1m35s
release / integration (push) Failing after 4m57s
release / android (push) Successful in 5m11s
release / Build signed APK (releases and dev) (push) Successful in 5m28s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Skipped
release / Verify release artifacts (tag releases only) (push) Skipped
Minstrel keeps its own list of what it is to get, keyed by MusicBrainz release group. A want comes from an approved request, a new release by a followed artist, or an album whose files went missing, and is held once the library has a full edition of it. - Migration 0081: release_type_profiles (Standard seeded: Album, EP, Single, studio only), follows, follow_seen_groups and wants. lidarr_requests becomes requests with plain *_mbid columns; approved album and track requests move onto the wanted list, approved artist requests become follows, and the library's album artists start out followed. missing_reacquisitions and the retry settings go. - internal/wanted: follows are checked against MusicBrainz discographies daily. The first check sets a baseline, and only releases after it are wanted unless the follow asked for what already exists. Profiles filter by primary and secondary type, so live recordings stay out unless a profile ticks Live. - internal/requests (was lidarrrequests): approving puts the request on the wanted list, and an artist request can be approved on a chosen profile. A request completes when its want is held. - The re-acquisition sweeper wants a missing album back instead of asking Lidarr; searching for it is the search schedule's (#5521). - Web: an admin Wanted page (Wanted, Missing files, Held, Following), a follow control on artist pages, a release-type profiles card on Integrations, "Approve on a profile" on Requests, and want state on Missing files. The artist detail API returns the artist's MBID. - Android: the request body sends artist_mbid, album_mbid and track_mbid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
216 lines
7.7 KiB
Go
216 lines
7.7 KiB
Go
package api
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
|
)
|
|
|
|
// missingTrackView is one track whose file the scan could not find.
|
|
//
|
|
// The text fields come from the tracks row, not from the filesystem, which is
|
|
// the point: the recording is still a known thing with a title, an artist and
|
|
// a play history — only its bytes are absent. LastPlayedAt is nullable because
|
|
// plenty of missing files were never played, and that is exactly the signal an
|
|
// operator wants when deciding whether to bother re-acquiring one.
|
|
type missingTrackView struct {
|
|
TrackID string `json:"track_id"`
|
|
Title string `json:"title"`
|
|
ArtistID string `json:"artist_id"`
|
|
ArtistName string `json:"artist_name"`
|
|
AlbumID string `json:"album_id"`
|
|
AlbumTitle string `json:"album_title"`
|
|
FilePath string `json:"file_path"`
|
|
DurationSec int32 `json:"duration_sec"`
|
|
MissingSince string `json:"missing_since"`
|
|
LastPlayedAt *string `json:"last_played_at"`
|
|
}
|
|
|
|
// reacquisitionStateView is what the wanted list says about one album
|
|
// (milestone #290, M502 #5520): when it was wanted back, and when the library
|
|
// held it again. A missing album with no want yet is still inside the grace
|
|
// window, or MusicBrainz cannot name it.
|
|
type reacquisitionStateView struct {
|
|
WantedAt *string `json:"wanted_at"`
|
|
HeldAt *string `json:"held_at"`
|
|
}
|
|
|
|
// missingGroupView is a directory's worth of missing tracks.
|
|
//
|
|
// Grouping is the whole ergonomic argument for this surface. The case that
|
|
// produced #2523 was three reorganised albums showing up as ~40 individually
|
|
// missing files; presented flat that reads as forty problems, presented by
|
|
// folder it reads as three. MissingSince is the EARLIEST mark in the group,
|
|
// so a directory sorts and reads by when it first went away.
|
|
type missingGroupView struct {
|
|
Directory string `json:"directory"`
|
|
MissingSince string `json:"missing_since"`
|
|
Tracks []missingTrackView `json:"tracks"`
|
|
// Nil when nothing has been attempted for this group's album — the
|
|
// common case for a folder that just went missing, and distinct from
|
|
// an attempts:0 record, which cannot occur.
|
|
Reacquisition *reacquisitionStateView `json:"reacquisition"`
|
|
}
|
|
|
|
// adminMissingResponse is the paged envelope. Total counts TRACKS, not
|
|
// groups — it is what the nav badge shows, and "12 files missing" is the
|
|
// honest number even when they happen to sit in two folders.
|
|
type adminMissingResponse struct {
|
|
Total int64 `json:"total"`
|
|
Limit int `json:"limit"`
|
|
Offset int `json:"offset"`
|
|
Groups []missingGroupView `json:"groups"`
|
|
}
|
|
|
|
// handleListMissingTracks implements GET /api/admin/library/missing.
|
|
//
|
|
// Read-only by design. Nothing on this surface deletes a track: a missing file
|
|
// keeps its row, its history and its likes because it may come back, and if it
|
|
// comes back renamed the scanner adopts it (#2528). The surface exists so an
|
|
// operator can SEE what the library has lost and act on it deliberately.
|
|
func (h *handlers) handleListMissingTracks(w http.ResponseWriter, r *http.Request) {
|
|
limit, offset, err := parsePaging(r.URL.Query())
|
|
if err != nil {
|
|
writeAdminJSONErr(w, http.StatusBadRequest, "invalid_paging")
|
|
return
|
|
}
|
|
|
|
q := dbq.New(h.pool)
|
|
total, err := q.CountMissingTracks(r.Context())
|
|
if err != nil {
|
|
h.logger.Error("admin: count missing tracks", "err", err)
|
|
writeAdminJSONErr(w, http.StatusInternalServerError, "server_error")
|
|
return
|
|
}
|
|
rows, err := q.ListMissingTracks(r.Context(), dbq.ListMissingTracksParams{
|
|
PageLimit: int32(limit),
|
|
PageOffset: int32(offset),
|
|
})
|
|
if err != nil {
|
|
h.logger.Error("admin: list missing tracks", "err", err)
|
|
writeAdminJSONErr(w, http.StatusInternalServerError, "server_error")
|
|
return
|
|
}
|
|
|
|
groups := groupMissingByDirectory(rows)
|
|
h.attachReacquisitionState(r, q, rows, groups)
|
|
|
|
out := adminMissingResponse{
|
|
Total: total,
|
|
Limit: limit,
|
|
Offset: offset,
|
|
Groups: groups,
|
|
}
|
|
writeJSON(w, http.StatusOK, out)
|
|
}
|
|
|
|
// groupMissingByDirectory folds the ordered rows into per-directory groups.
|
|
//
|
|
// It relies on ListMissingTracks ordering by directory, so a simple run-length
|
|
// fold is enough and no map is needed — which also preserves the query's
|
|
// ordering in the response instead of Go's random map iteration. A page
|
|
// boundary can split one directory across two pages; that is accepted rather
|
|
// than paging by group, because the alternative costs a second query to find
|
|
// the page's directories and this surface's realistic N is small.
|
|
func groupMissingByDirectory(rows []dbq.ListMissingTracksRow) []missingGroupView {
|
|
groups := make([]missingGroupView, 0, 8)
|
|
for _, row := range rows {
|
|
t := missingTrackView{
|
|
TrackID: uuidToString(row.ID),
|
|
Title: row.Title,
|
|
ArtistID: uuidToString(row.ArtistID),
|
|
ArtistName: row.ArtistName,
|
|
AlbumID: uuidToString(row.AlbumID),
|
|
AlbumTitle: row.AlbumTitle,
|
|
FilePath: row.FilePath,
|
|
DurationSec: row.DurationMs / 1000,
|
|
MissingSince: formatTimestamp(row.MissingSince),
|
|
}
|
|
if row.LastPlayedAt.Valid {
|
|
s := formatTimestamp(row.LastPlayedAt)
|
|
t.LastPlayedAt = &s
|
|
}
|
|
|
|
if n := len(groups); n > 0 && groups[n-1].Directory == row.Directory {
|
|
groups[n-1].Tracks = append(groups[n-1].Tracks, t)
|
|
continue
|
|
}
|
|
groups = append(groups, missingGroupView{
|
|
Directory: row.Directory,
|
|
// First row of a run carries the group's timestamp. Rows are
|
|
// ordered within a directory by disc/track, not by mark time, so
|
|
// this is "the mark on the first track" rather than the minimum —
|
|
// they are the same value in the case that matters (a whole folder
|
|
// vanishing at once) and close enough otherwise.
|
|
MissingSince: t.MissingSince,
|
|
Tracks: []missingTrackView{t},
|
|
})
|
|
}
|
|
return groups
|
|
}
|
|
|
|
// attachReacquisitionState decorates each group with its album's want.
|
|
//
|
|
// Best-effort: this is context on a list whose primary job is showing what is
|
|
// missing, so a failure here leaves the groups bare rather than failing the
|
|
// page. One batched query for the whole page, not one per group.
|
|
//
|
|
// A group is keyed by directory while a want is keyed by album, and those
|
|
// line up in practice (an album's files live in one folder) but are not
|
|
// guaranteed to — a directory holding two albums takes the first album's
|
|
// state, which is the same album its first track belongs to.
|
|
func (h *handlers) attachReacquisitionState(
|
|
r *http.Request,
|
|
q *dbq.Queries,
|
|
rows []dbq.ListMissingTracksRow,
|
|
groups []missingGroupView,
|
|
) {
|
|
if len(groups) == 0 {
|
|
return
|
|
}
|
|
// Directory -> the album its first row belongs to, matching the order
|
|
// groupMissingByDirectory folded them in.
|
|
dirAlbum := make(map[string]pgtype.UUID, len(groups))
|
|
ids := make([]pgtype.UUID, 0, len(groups))
|
|
for _, row := range rows {
|
|
if _, seen := dirAlbum[row.Directory]; seen {
|
|
continue
|
|
}
|
|
dirAlbum[row.Directory] = row.AlbumID
|
|
ids = append(ids, row.AlbumID)
|
|
}
|
|
|
|
wants, err := q.GetWantsForAlbums(r.Context(), ids)
|
|
if err != nil {
|
|
h.logger.Warn("admin missing: want lookup failed", "err", err)
|
|
return
|
|
}
|
|
// Newest want first, so the first seen per album is its current one.
|
|
byAlbum := make(map[string]dbq.GetWantsForAlbumsRow, len(wants))
|
|
for _, w := range wants {
|
|
if _, seen := byAlbum[uuidToString(w.AlbumID)]; !seen {
|
|
byAlbum[uuidToString(w.AlbumID)] = w
|
|
}
|
|
}
|
|
for i := range groups {
|
|
albumID, ok := dirAlbum[groups[i].Directory]
|
|
if !ok {
|
|
continue
|
|
}
|
|
w, ok := byAlbum[uuidToString(albumID)]
|
|
if !ok {
|
|
continue
|
|
}
|
|
view := &reacquisitionStateView{}
|
|
wantedAt := formatTimestamp(w.WantedAt)
|
|
view.WantedAt = &wantedAt
|
|
if w.FulfilledAt.Valid {
|
|
heldAt := formatTimestamp(w.FulfilledAt)
|
|
view.HeldAt = &heldAt
|
|
}
|
|
groups[i].Reacquisition = view
|
|
}
|
|
}
|