bvandeusen
58766dbebe
The PR1-T2 admin handler migration replaced bespoke 500-class messages
("lookup failed", "refetch failed", "trigger failed", "bump failed",
"remove failed", "update failed", "schedule row missing", "re-read
failed", "read failed") with apierror.Internal(err), which forces the
wire Message to "internal server error". That violates the PR1
contract that errEnvelope{Code, Message} must remain byte-identical
for existing clients.
Add apierror.InternalMsg(message, cause) — a 500-class constructor
that preserves the call site's user-facing message while keeping the
cause attached for logging and errors.Is. Re-migrate the 12 admin
sites whose pre-1cc7eb6 source had a non-empty bespoke Message so
they restore the original wire string. Sites whose original Message
was empty stay on Internal(err) (humanization to "internal server
error" is a tolerable improvement, not a regression).
admin_smtp.go's send_failed site (line 129) was already preserved
via a raw &apierror.Error literal in 1cc7eb6 and needs no fix.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
39 lines
1.3 KiB
Go
39 lines
1.3 KiB
Go
package api
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/apierror"
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
|
)
|
|
|
|
// coverageRollupResp is the wire shape for GET /api/admin/library/coverage.
|
|
// All fields are non-negative counts. with_art + pending + settled = total;
|
|
// pending_no_mbid is a subset of pending.
|
|
type coverageRollupResp struct {
|
|
Total int64 `json:"total"`
|
|
WithArt int64 `json:"with_art"`
|
|
Pending int64 `json:"pending"`
|
|
Settled int64 `json:"settled"`
|
|
PendingNoMbid int64 `json:"pending_no_mbid"`
|
|
}
|
|
|
|
// handleGetLibraryCoverage implements GET /api/admin/library/coverage.
|
|
// Surfaces a library-wide rollup of albums.cover_art_source for the admin
|
|
// dashboard gauge. Always 200; zeros on an empty library.
|
|
func (h *handlers) handleGetLibraryCoverage(w http.ResponseWriter, r *http.Request) {
|
|
q := dbq.New(h.pool)
|
|
row, err := q.GetAlbumCoverageRollup(r.Context())
|
|
if err != nil {
|
|
writeErrWithLog(w, h.logger, "admin: get coverage rollup", apierror.InternalMsg("lookup failed", err))
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, coverageRollupResp{
|
|
Total: row.Total,
|
|
WithArt: row.WithArt,
|
|
Pending: row.Pending,
|
|
Settled: row.Settled,
|
|
PendingNoMbid: row.PendingNoMbid,
|
|
})
|
|
}
|