bvandeusen/minstrel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 38 Wiki Activity

fix(ci): scope integration Postgres discovery to this job's network #53

Merged
bvandeusen merged 262 commits from dev into main 2026-05-18 22:50:36 -04:00
Conversation 0 Commits 262 Files Changed 299
+27003
bvandeusen commented 2026-05-18 22:50:25 -04:00 (Migrated from git.fabledsword.com)
Copy Link
Copy Source

CI-only hotfix on top of v2026.05.19.0.

The integration job discovered its Postgres via docker ps --filter name=integration, which matches every concurrent integration run's service container. A dev push and the main-merge run overlapping on the shared act_runner daemon produced 2 candidates → the "expected exactly 1" guard aborted. That's a concurrency race in the discovery, not a code defect — the released v2026.05.19.0 code is unaffected (a clean, non-overlapping re-run of that job passes).

Fix: scope discovery by network intersection — act_runner attaches the job container and its service container to a shared per-job network, so select the postgres on a network this job container is also on. Dev-compose container still skipped explicitly. Now concurrency-safe (each run finds only its own postgres).

No application/code change; .forgejo/workflows/test-go.yml only.

CI-only hotfix on top of v2026.05.19.0. The integration job discovered its Postgres via `docker ps --filter name=integration`, which matches **every concurrent integration run's** service container. A dev push and the main-merge run overlapping on the shared act_runner daemon produced 2 candidates → the "expected exactly 1" guard aborted. That's a concurrency race in the discovery, not a code defect — the released v2026.05.19.0 code is unaffected (a clean, non-overlapping re-run of that job passes). Fix: scope discovery by network intersection — act_runner attaches the job container and its service container to a shared per-job network, so select the postgres on a network this job container is also on. Dev-compose container still skipped explicitly. Now concurrency-safe (each run finds only its own postgres). No application/code change; `.forgejo/workflows/test-go.yml` only.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
deps
Dependency update (Renovate)
 deps:major
Major dependency bump — held for manual review
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bvandeusen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bvandeusen/minstrel#53
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?