ci: drop push:dev trigger; PR is the gate #25

Merged
bvandeusen merged 262 commits from dev into main 2026-04-28 08:35:54 -04:00
bvandeusen commented 2026-04-28 00:05:58 -04:00 (Migrated from git.fabledsword.com)

Tiny CI workflow change. Drops the push: branches: [dev] trigger from .forgejo/workflows/test.yml; the pull_request: branches: [main] trigger remains.

Why

Forgejo Actions fires BOTH events when:

  1. Push commit to dev (with an open PR against main) → push event
  2. PR head moves → pull_request event

Result: every PR commit was producing two runs of the same workflow on the same SHA. Visible on PR #24 — runs #182 (push, dev) and #183 (pull_request, #24) for the same commit 95d68e3. Same pattern on PR #21, #22, #23.

After this change: only one run per PR commit. Roughly halves CI usage.

Trade-off

Direct pushes to dev without an open PR will no longer trigger CI on their own. Acceptable because:

  • The project workflow is always dev → PR → main. The PR is the gate.
  • The moment a PR opens, the pull_request event fires and runs the workflow.
  • Local pushes to dev for in-progress work are typically followed by a PR within the same dev session.

Test plan

This PR itself will validate the change — only one test.yml run should fire (for the pull_request event). If two runs appear, the change didn't work.

🤖 Generated with Claude Code

Tiny CI workflow change. Drops the `push: branches: [dev]` trigger from `.forgejo/workflows/test.yml`; the `pull_request: branches: [main]` trigger remains. ## Why Forgejo Actions fires BOTH events when: 1. Push commit to `dev` (with an open PR against `main`) → `push` event 2. PR head moves → `pull_request` event Result: every PR commit was producing two runs of the same workflow on the same SHA. Visible on PR #24 — runs `#182` (push, dev) and `#183` (pull_request, #24) for the same commit `95d68e3`. Same pattern on PR #21, #22, #23. After this change: only one run per PR commit. Roughly halves CI usage. ## Trade-off Direct pushes to `dev` without an open PR will no longer trigger CI on their own. Acceptable because: - The project workflow is always `dev → PR → main`. The PR is the gate. - The moment a PR opens, the `pull_request` event fires and runs the workflow. - Local pushes to `dev` for in-progress work are typically followed by a PR within the same dev session. ## Test plan This PR itself will validate the change — only **one** test.yml run should fire (for the `pull_request` event). If two runs appear, the change didn't work. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bvandeusen/minstrel#25