Compare commits
107 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 29fee5aa37 | |||
| 02336967b4 | |||
| 452e29bc59 | |||
| f6ee837be6 | |||
| d27dd69bfc | |||
| b991fde3fe | |||
| 335940cf23 | |||
| 60085b1368 | |||
| fb95a462fb | |||
| 67bacac84b | |||
| e59ccba961 | |||
| e38189470b | |||
| 5511f87b4b | |||
| e5ab471ce1 | |||
| 28b0107925 | |||
| bfad4dddb6 | |||
| d1e276204e | |||
| 2df35e6227 | |||
| 573aa4226d | |||
| 30fc7603d4 | |||
| 86d67f6fc6 | |||
| 8cb9a8b797 | |||
| 7339815ea9 | |||
| 2a18e91c39 | |||
| 507c532f6d | |||
| bf0ef5e0c3 | |||
| 6efb3159d5 | |||
| 8f1bc60757 | |||
| c29d25d1cb | |||
| 2ebe6229b7 | |||
| 6a08d94255 | |||
| 3e7b2582a2 | |||
| baa601765e | |||
| 3db90020d4 | |||
| 7367595e71 | |||
| 158a5d7506 | |||
| f2fa441405 | |||
| a324454efe | |||
| 03c13d21c6 | |||
| 0119eacf14 | |||
| 0504cae27c | |||
| 64db364834 | |||
| 99462185b4 | |||
| 395a6efb26 | |||
| 1a2de0e738 | |||
| 32c8d4f28f | |||
| f732c49645 | |||
| ae5de91006 | |||
| 369ed800b9 | |||
| 7cfaafd360 | |||
| 22bd06a578 | |||
| efa52484d4 | |||
| 3e52ff7fa3 | |||
| 89ded7b46c | |||
| bb9e979876 | |||
| e282766268 | |||
| 046ee8d576 | |||
| b5c5dbbe76 | |||
| 872b0de304 | |||
| 89d8b4b5a0 | |||
| 6b7e4f1dee | |||
| c2168afbf0 | |||
| 7fac264c73 | |||
| 46c8edfa82 | |||
| 230da7bdcb | |||
| 5cd342d521 | |||
| b4801c2dd3 | |||
| 90d8aae51a | |||
| 15063ca0b4 | |||
| f7dfeff256 | |||
| 84fc6b8d1b | |||
| ee7f0cdb42 | |||
| 3ffa5608d8 | |||
| a5500aeeff | |||
| 170614baf1 | |||
| b466b6494a | |||
| 9acad5461e | |||
| 1f0f7eee1a | |||
| 0d009b34e2 | |||
| 5fc04f14b7 | |||
| a09b636e1a | |||
| 356f8f5d6c | |||
| 96aa2407d9 | |||
| e856172d60 | |||
| ab62a3d118 | |||
| a3c0aed63e | |||
| 1ddde12959 | |||
| f1b4652c77 | |||
| 261b44522d | |||
| 6f20a75f9b | |||
| 2d5f0691c2 | |||
| e8a515dac4 | |||
| acc7149537 | |||
| 4ede37d9ad | |||
| 4bd069430b | |||
| 22152b1ba3 | |||
| 572325e23f | |||
| 8d466ebdd5 | |||
| af5744f8ab | |||
| c7549bbe48 | |||
| 9cac664679 | |||
| c08f4ace80 | |||
| c1df2af992 | |||
| a7f35a5d6d | |||
| e610948307 | |||
| 8c00ee21c7 | |||
| 2500914498 |
@@ -72,6 +72,25 @@ jobs:
|
||||
if: github.event_name == 'push' && !startsWith(github.ref, 'refs/tags/')
|
||||
run: flutter build apk --debug
|
||||
|
||||
- name: Decode signing keystore
|
||||
if: startsWith(github.ref, 'refs/tags/v')
|
||||
# Reconstructs the release keystore from a base64-encoded
|
||||
# CI secret so every tagged build is signed with the same
|
||||
# key. Without this, each CI runner would generate its own
|
||||
# debug keystore and Android would refuse to upgrade an
|
||||
# existing install (signature mismatch).
|
||||
shell: bash
|
||||
env:
|
||||
ANDROID_KEYSTORE_B64: ${{ secrets.ANDROID_KEYSTORE_B64 }}
|
||||
run: |
|
||||
if [ -z "${ANDROID_KEYSTORE_B64}" ]; then
|
||||
echo "::error::ANDROID_KEYSTORE_B64 secret is missing — release builds need a consistent signing key"
|
||||
exit 1
|
||||
fi
|
||||
KEYSTORE_PATH="${RUNNER_TEMP}/minstrel-release.keystore"
|
||||
echo "${ANDROID_KEYSTORE_B64}" | base64 -d > "${KEYSTORE_PATH}"
|
||||
echo "ANDROID_KEYSTORE_PATH=${KEYSTORE_PATH}" >> "${GITHUB_ENV}"
|
||||
|
||||
- name: Build release APK
|
||||
if: startsWith(github.ref, 'refs/tags/v')
|
||||
# Inject the tag (sans leading 'v') as the build's --build-name
|
||||
@@ -79,7 +98,15 @@ jobs:
|
||||
# reports — otherwise the in-app update banner would always
|
||||
# think the user is behind because pubspec.yaml's static
|
||||
# version drifts from the actual release tag.
|
||||
#
|
||||
# ANDROID_KEYSTORE_PATH is set by the previous step;
|
||||
# build.gradle.kts picks it up and signs the release APK with
|
||||
# the operator's persistent keystore.
|
||||
shell: bash
|
||||
env:
|
||||
ANDROID_STORE_PASSWORD: ${{ secrets.ANDROID_STORE_PASSWORD }}
|
||||
ANDROID_KEY_ALIAS: ${{ secrets.ANDROID_KEY_ALIAS }}
|
||||
ANDROID_KEY_PASSWORD: ${{ secrets.ANDROID_KEY_PASSWORD }}
|
||||
run: |
|
||||
TAG="${GITHUB_REF#refs/tags/v}"
|
||||
flutter build apk --release --build-name="${TAG}"
|
||||
|
||||
+34
-2
@@ -14,6 +14,7 @@ import (
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/config"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/coverart"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/db"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/eventbus"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/library"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/lidarrconfig"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/lidarrrequests"
|
||||
@@ -24,6 +25,7 @@ import (
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/server"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/similarity"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/subsonic"
|
||||
syncpkg "git.fabledsword.com/bvandeusen/minstrel/internal/sync"
|
||||
)
|
||||
|
||||
func main() {
|
||||
@@ -146,9 +148,38 @@ func run() error {
|
||||
// import requests and reconciles them against the library. Short-circuits
|
||||
// to no-op when lidarr_config.enabled = false.
|
||||
lidarrCfg := lidarrconfig.New(pool)
|
||||
lidarrReconciler := lidarrrequests.NewReconciler(pool, lidarrCfg, logger.With("component", "lidarr"))
|
||||
// Live-event bus shared between SSE subscribers (api.Mount) and
|
||||
// background workers that publish (reconciler today; scanner later).
|
||||
// Constructed before any service that publishes so they all share the
|
||||
// same instance.
|
||||
bus := eventbus.New()
|
||||
// Scan-run lifecycle events use a package-level setter rather than
|
||||
// threading the bus through RunScan + TryStartScan + the Scheduler
|
||||
// + every test caller. Per-process singleton, set once at startup.
|
||||
library.SetEventBus(bus)
|
||||
lidarrReconciler := lidarrrequests.NewReconciler(pool, lidarrCfg, logger.With("component", "lidarr"), bus)
|
||||
go lidarrReconciler.Run(ctx)
|
||||
|
||||
// library_changes compactor (#357 follow-up). Daily tick; deletes
|
||||
// rows older than the configured retention so the change-log table
|
||||
// doesn't grow unbounded. Clients that drop offline longer than
|
||||
// retention hit the /api/library/sync 410 fallback and resync.
|
||||
libraryChangesCompactor := syncpkg.NewCompactor(pool, logger.With("component", "library_changes_compactor"))
|
||||
go libraryChangesCompactor.Run(ctx)
|
||||
|
||||
// Per-user system-playlist scheduler (#392 Half B). Fires each
|
||||
// active user's daily build at 03:00 in their stored timezone.
|
||||
// Replaces the 24h-anchored cron loop (removed in the next commit
|
||||
// of this arc).
|
||||
playlistScheduler, err := playlists.NewScheduler(pool, logger.With("component", "playlist_scheduler"), cfg.Storage.DataDir)
|
||||
if err != nil {
|
||||
return fmt.Errorf("init playlist scheduler: %w", err)
|
||||
}
|
||||
if err := playlistScheduler.Start(ctx); err != nil {
|
||||
return fmt.Errorf("start playlist scheduler: %w", err)
|
||||
}
|
||||
defer playlistScheduler.Stop()
|
||||
|
||||
// Ensure DataDir exists before any service tries to write into it.
|
||||
// Fatal on failure: a non-writable data_dir silently breaks every
|
||||
// downstream cache (playlist covers, artist art, album-cover fallback)
|
||||
@@ -173,7 +204,8 @@ func run() error {
|
||||
srv := server.New(logger, pool, scanner, subsonic.Config{
|
||||
AllowPlaintextPassword: cfg.Subsonic.AllowPlaintextPassword,
|
||||
}, cfg.Events, cfg.Recommendation, cfg.Storage.DataDir, cfg.Branding, coverEnricher, cfg.Library.CoverArtBackfillCap, coverSettings, scanner, scanCfg, scheduler)
|
||||
playlists.StartSystemPlaylistCron(ctx, pool, logger.With("component", "system_playlist_cron"), cfg.Storage.DataDir)
|
||||
srv.Bus = bus
|
||||
srv.PlaylistScheduler = playlistScheduler
|
||||
httpServer := &http.Server{
|
||||
Addr: cfg.Server.Address,
|
||||
Handler: srv.Router(),
|
||||
|
||||
@@ -30,11 +30,38 @@ android {
|
||||
versionName = flutter.versionName
|
||||
}
|
||||
|
||||
// Real release signing config — populated only when CI exports
|
||||
// ANDROID_KEYSTORE_PATH (decoded from a base64 secret) plus the
|
||||
// matching password/alias env vars. Without these (local
|
||||
// `flutter build apk --release` runs), the release build falls
|
||||
// through to the debug keystore so local builds still work.
|
||||
//
|
||||
// Why this matters: Flutter's default `flutter run --release` and
|
||||
// CI's earlier setup both signed with the per-machine debug
|
||||
// keystore (~/.android/debug.keystore). Every CI runner generated
|
||||
// its own debug key, so consecutive release APKs had different
|
||||
// signatures and Android refused to upgrade an existing install.
|
||||
val keystorePath: String? = System.getenv("ANDROID_KEYSTORE_PATH")
|
||||
if (keystorePath != null && keystorePath.isNotEmpty()) {
|
||||
signingConfigs {
|
||||
create("release") {
|
||||
storeFile = file(keystorePath)
|
||||
storePassword = System.getenv("ANDROID_STORE_PASSWORD")
|
||||
keyAlias = System.getenv("ANDROID_KEY_ALIAS")
|
||||
keyPassword = System.getenv("ANDROID_KEY_PASSWORD")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
buildTypes {
|
||||
release {
|
||||
// TODO: Add your own signing config for the release build.
|
||||
// Signing with the debug keys for now, so `flutter run --release` works.
|
||||
signingConfig = signingConfigs.getByName("debug")
|
||||
signingConfig = if (keystorePath != null && keystorePath.isNotEmpty()) {
|
||||
signingConfigs.getByName("release")
|
||||
} else {
|
||||
// Local-only fallback so `flutter run --release` works
|
||||
// without the keystore. CI must export ANDROID_KEYSTORE_PATH.
|
||||
signingConfigs.getByName("debug")
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../shared/live_events_provider.dart';
|
||||
import '../shared/widgets/main_app_bar_actions.dart';
|
||||
import '../theme/theme_extension.dart';
|
||||
import 'admin_providers.dart';
|
||||
@@ -12,6 +13,15 @@ class AdminQuarantineScreen extends ConsumerWidget {
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
// #402 wire-up: any quarantine event (flag from a user / admin
|
||||
// resolve / file delete / lidarr delete) refreshes the admin queue.
|
||||
ref.listen<AsyncValue<LiveEvent>>(liveEventsProvider, (_, next) {
|
||||
final e = next.asData?.value;
|
||||
if (e == null) return;
|
||||
if (e.kind.startsWith('quarantine.')) {
|
||||
ref.invalidate(adminQuarantineProvider);
|
||||
}
|
||||
});
|
||||
final items = ref.watch(adminQuarantineProvider);
|
||||
return Scaffold(
|
||||
backgroundColor: fs.obsidian,
|
||||
|
||||
@@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../models/admin_user.dart';
|
||||
import '../shared/live_events_provider.dart';
|
||||
import '../shared/widgets/main_app_bar_actions.dart';
|
||||
import '../theme/theme_extension.dart';
|
||||
import 'admin_providers.dart';
|
||||
@@ -13,6 +14,15 @@ class AdminRequestsScreen extends ConsumerWidget {
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
// #402 wire-up: invalidate the admin requests list when a user
|
||||
// creates/cancels/admin approves/rejects/reconciler completes —
|
||||
// request.status_changed covers all of them.
|
||||
ref.listen<AsyncValue<LiveEvent>>(liveEventsProvider, (_, next) {
|
||||
final e = next.asData?.value;
|
||||
if (e?.kind == 'request.status_changed') {
|
||||
ref.invalidate(adminRequestsProvider);
|
||||
}
|
||||
});
|
||||
final requests = ref.watch(adminRequestsProvider);
|
||||
// Best-effort lookup for requester usernames. If the users provider
|
||||
// hasn't loaded yet, valueOrNull is null and rows fall back to the
|
||||
|
||||
@@ -3,6 +3,7 @@ import 'package:dio/dio.dart';
|
||||
import '../../models/album.dart';
|
||||
import '../../models/artist.dart';
|
||||
import '../../models/home_data.dart';
|
||||
import '../../models/home_index.dart';
|
||||
import '../../models/track.dart';
|
||||
|
||||
/// LibraryApi wraps the server's native /api/* library surface.
|
||||
@@ -27,6 +28,24 @@ class LibraryApi {
|
||||
return HomeData.fromJson(r.data ?? const {});
|
||||
}
|
||||
|
||||
/// GET /api/home/index — per-item rendering variant. Returns just IDs
|
||||
/// per section; client hydrates each tile via the per-entity
|
||||
/// endpoints. ~10× smaller than /api/home on populated libraries so
|
||||
/// the cold-visit round-trip is correspondingly short.
|
||||
Future<HomeIndex> getHomeIndex() async {
|
||||
final r = await _dio.get<Map<String, dynamic>>('/api/home/index');
|
||||
return HomeIndex.fromJson(r.data ?? const {});
|
||||
}
|
||||
|
||||
/// GET /api/tracks/{id}. Returns the canonical TrackRef. Used by
|
||||
/// the HydrationQueue to populate cached_tracks on a per-tile miss
|
||||
/// — the existing endpoint already joins album + artist so the
|
||||
/// response carries everything TrackRef needs.
|
||||
Future<TrackRef> getTrack(String id) async {
|
||||
final r = await _dio.get<Map<String, dynamic>>('/api/tracks/$id');
|
||||
return TrackRef.fromJson(r.data ?? const {});
|
||||
}
|
||||
|
||||
/// GET /api/artists/{id}. Server returns ArtistDetail which embeds
|
||||
/// ArtistRef inline; ArtistRef.fromJson already reads only the fields
|
||||
/// it cares about, so passing the whole body is correct.
|
||||
@@ -35,6 +54,24 @@ class LibraryApi {
|
||||
return ArtistRef.fromJson(r.data ?? const {});
|
||||
}
|
||||
|
||||
/// GET /api/artists/{id} — full response with the ArtistRef AND the
|
||||
/// embedded album list, both parsed. Single round-trip variant used
|
||||
/// by CacheFiller and other callers that want to populate both
|
||||
/// cached_artists and cached_albums in one shot. The existing
|
||||
/// getArtist / getArtistAlbums keep working for callers that only
|
||||
/// need one half — they hit the same URL but the per-id Riverpod
|
||||
/// caching layer dedupes.
|
||||
Future<({ArtistRef artist, List<AlbumRef> albums})> getArtistDetail(
|
||||
String id) async {
|
||||
final r = await _dio.get<Map<String, dynamic>>('/api/artists/$id');
|
||||
final body = r.data ?? const <String, dynamic>{};
|
||||
final artist = ArtistRef.fromJson(body);
|
||||
final albums = ((body['albums'] as List?) ?? const [])
|
||||
.map((e) => AlbumRef.fromJson((e as Map).cast<String, dynamic>()))
|
||||
.toList(growable: false);
|
||||
return (artist: artist, albums: albums);
|
||||
}
|
||||
|
||||
/// Pulls the "albums" array out of the same ArtistDetail body. Callers
|
||||
/// that need both the artist and its albums should issue two provider
|
||||
/// reads (artistProvider + artistAlbumsProvider) — both hit the same
|
||||
|
||||
@@ -38,4 +38,12 @@ class MeApi {
|
||||
);
|
||||
return SystemPlaylistsStatus.fromJson(r.data ?? const {});
|
||||
}
|
||||
|
||||
/// PUT /api/me/timezone — submit the device's IANA timezone. The
|
||||
/// scheduler uses this to fire the user's daily playlist build at
|
||||
/// 03:00 in their local time. See AuthController._sendTimezoneIfStale
|
||||
/// for the weekly cadence trigger.
|
||||
Future<void> putTimezone(String timezone) async {
|
||||
await _dio.put<void>('/api/me/timezone', data: {'timezone': timezone});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,8 +1,12 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import 'cache/cache_filler.dart';
|
||||
import 'cache/metadata_prefetcher.dart';
|
||||
import 'cache/mutation_queue.dart';
|
||||
import 'cache/prefetcher.dart';
|
||||
import 'cache/sync_controller.dart';
|
||||
import 'shared/live_events_dispatcher.dart';
|
||||
import 'shared/routing.dart';
|
||||
import 'theme/theme_data.dart';
|
||||
import 'theme/theme_mode_provider.dart';
|
||||
@@ -27,6 +31,30 @@ class _MinstrelAppState extends ConsumerState<MinstrelApp> {
|
||||
// ignore: unawaited_futures
|
||||
ref.read(syncControllerProvider.notifier).sync();
|
||||
ref.read(prefetcherProvider);
|
||||
// Metadata prefetcher: when /api/home returns, fire background
|
||||
// albumProvider/artistProvider reads for the top-N items in
|
||||
// each section so subsequent taps are drift hits, not network
|
||||
// round trips.
|
||||
ref.read(metadataPrefetcherProvider);
|
||||
// Live events (#392): subscribes to /api/events/stream and
|
||||
// invalidates publicly-scoped providers when relevant events
|
||||
// arrive. Also installs an AppLifecycleState observer for
|
||||
// resume-time defensive invalidation.
|
||||
ref.read(liveEventsDispatcherProvider);
|
||||
// Cache filler: background sweeper that walks cached_artists
|
||||
// / cached_albums for missing relations and fetches the
|
||||
// per-entity detail so tapping an artist surfaces albums
|
||||
// immediately (drift hit, no /api/artists/:id round-trip at
|
||||
// tap time). First sweep 10s after launch; every 5 minutes
|
||||
// thereafter. Throttled 200ms between requests so it never
|
||||
// competes with user activity.
|
||||
ref.read(cacheFillerProvider);
|
||||
// Mutation replayer: drains the cached_mutations queue when
|
||||
// connectivity comes back. Controllers (LikesController,
|
||||
// MyQuarantineController, the add-to-playlist + request flows)
|
||||
// enqueue on REST failure so user intent persists across
|
||||
// network loss instead of getting rolled back.
|
||||
ref.read(mutationReplayerProvider);
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
@@ -2,12 +2,17 @@ import 'dart:convert';
|
||||
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:flutter_secure_storage/flutter_secure_storage.dart';
|
||||
import 'package:flutter_timezone/flutter_timezone.dart';
|
||||
|
||||
import '../api/endpoints/me.dart';
|
||||
import '../library/library_providers.dart' show dioProvider;
|
||||
import '../models/user.dart';
|
||||
|
||||
const _kServerUrl = 'server_url';
|
||||
const _kSessionToken = 'session_token';
|
||||
const _kCurrentUser = 'current_user';
|
||||
const _kServerUrl = 'server_url';
|
||||
const _kSessionToken = 'session_token';
|
||||
const _kCurrentUser = 'current_user';
|
||||
const _kTzLastSentAt = 'tz_last_sent_at';
|
||||
const _weeklyMs = 7 * 24 * 60 * 60 * 1000;
|
||||
|
||||
final secureStorageProvider = Provider<FlutterSecureStorage>(
|
||||
(ref) => const FlutterSecureStorage(),
|
||||
@@ -29,7 +34,12 @@ class AuthController extends AsyncNotifier<User?> {
|
||||
_storage = ref.watch(secureStorageProvider);
|
||||
final raw = await _storage.read(key: _kCurrentUser);
|
||||
if (raw == null) return null;
|
||||
return User.fromJson(jsonDecode(raw) as Map<String, dynamic>);
|
||||
final user = User.fromJson(jsonDecode(raw) as Map<String, dynamic>);
|
||||
// Fire-and-forget timezone send on app start with an existing
|
||||
// session — no-op when last_sent_at is fresh.
|
||||
// ignore: unawaited_futures
|
||||
_sendTimezoneIfStale();
|
||||
return user;
|
||||
}
|
||||
|
||||
Future<void> setServerUrl(String url) async {
|
||||
@@ -42,6 +52,8 @@ class AuthController extends AsyncNotifier<User?> {
|
||||
await _storage.write(key: _kCurrentUser, value: userJson);
|
||||
ref.invalidate(sessionTokenProvider);
|
||||
state = AsyncData(User.fromJson(jsonDecode(userJson) as Map<String, dynamic>));
|
||||
// ignore: unawaited_futures
|
||||
_sendTimezoneIfStale();
|
||||
}
|
||||
|
||||
Future<void> clearSession() async {
|
||||
@@ -50,6 +62,27 @@ class AuthController extends AsyncNotifier<User?> {
|
||||
ref.invalidate(sessionTokenProvider);
|
||||
state = const AsyncData(null);
|
||||
}
|
||||
|
||||
/// Sends the device's current IANA timezone to PUT /api/me/timezone
|
||||
/// when the last successful send was >7 days ago (or never).
|
||||
/// Cadence persists in flutter_secure_storage so it survives app
|
||||
/// restarts. Failures are swallowed: the server keeps its previous
|
||||
/// value (or 'UTC' default) until the next attempt.
|
||||
Future<void> _sendTimezoneIfStale() async {
|
||||
try {
|
||||
final lastStr = await _storage.read(key: _kTzLastSentAt);
|
||||
final lastMs = lastStr == null ? 0 : int.tryParse(lastStr) ?? 0;
|
||||
final nowMs = DateTime.now().millisecondsSinceEpoch;
|
||||
if (nowMs - lastMs < _weeklyMs) return;
|
||||
final tz = await FlutterTimezone.getLocalTimezone();
|
||||
if (tz.isEmpty) return;
|
||||
final dio = await ref.read(dioProvider.future);
|
||||
await MeApi(dio).putTimezone(tz);
|
||||
await _storage.write(key: _kTzLastSentAt, value: nowMs.toString());
|
||||
} catch (_) {
|
||||
// Non-fatal — server falls back to UTC or last-known value.
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
final authControllerProvider =
|
||||
|
||||
+19
-2
@@ -17,10 +17,21 @@ import '../models/track.dart';
|
||||
import 'db.dart';
|
||||
|
||||
extension CachedArtistAdapter on CachedArtist {
|
||||
ArtistRef toRef() => ArtistRef(
|
||||
/// `coverAlbumId` lets the caller pass a representative album id so
|
||||
/// the ArtistRef carries a reconstructed `/api/albums/<id>/cover`
|
||||
/// URL. cached_artists doesn't store this directly — the server
|
||||
/// derives it from the most-recent album at query time — so drift
|
||||
/// readers that want the cover URL join cached_albums and pass the
|
||||
/// first album's id through. Empty string yields empty coverUrl,
|
||||
/// matching the server's behavior for endpoints that don't carry
|
||||
/// the lookup (artist detail, search, raw cached_artists row reads).
|
||||
ArtistRef toRef({String coverAlbumId = ''}) => ArtistRef(
|
||||
id: id,
|
||||
name: name,
|
||||
sortName: sortName,
|
||||
coverUrl: coverAlbumId.isNotEmpty
|
||||
? '/api/albums/$coverAlbumId/cover'
|
||||
: '',
|
||||
);
|
||||
}
|
||||
|
||||
@@ -88,6 +99,12 @@ extension TrackRefDriftWrite on TrackRef {
|
||||
extension CachedPlaylistAdapter on CachedPlaylist {
|
||||
/// `ownerUsername` is server-derived; cache stores the userId only.
|
||||
/// Pass empty unless a join supplies it.
|
||||
/// `coverUrl` is reconstructed deterministically from the playlist
|
||||
/// id — the server serves the cached collage at this path
|
||||
/// (handleGetPlaylistCover). Mirrors the album-cover trick. When
|
||||
/// the server hasn't built a collage yet (system playlists with no
|
||||
/// tracks at build time), the endpoint 404s and PlaylistCard's
|
||||
/// ServerImage falls back to its slate placeholder.
|
||||
Playlist toRef({String ownerUsername = ''}) => Playlist(
|
||||
id: id,
|
||||
userId: userId,
|
||||
@@ -96,7 +113,7 @@ extension CachedPlaylistAdapter on CachedPlaylist {
|
||||
isPublic: isPublic,
|
||||
systemVariant: systemVariant,
|
||||
trackCount: trackCount,
|
||||
coverUrl: '', // server-derived; cache doesn't persist
|
||||
coverUrl: '/api/playlists/$id/cover',
|
||||
ownerUsername: ownerUsername,
|
||||
createdAt: '',
|
||||
updatedAt: '',
|
||||
|
||||
+39
-6
@@ -83,6 +83,27 @@ class AudioCacheManager {
|
||||
return path;
|
||||
}
|
||||
|
||||
/// Registers a file already on disk in the cache index. Intended for
|
||||
/// the streaming path (LockCachingAudioSource) which writes the file
|
||||
/// itself; we need an index row so eviction can find and delete it
|
||||
/// when usage exceeds the cap. `source` defaults to incidental so
|
||||
/// stream-cached tracks are first to be evicted.
|
||||
Future<void> registerStreamCache(
|
||||
String trackId,
|
||||
String path,
|
||||
int sizeBytes, {
|
||||
CacheSource source = CacheSource.incidental,
|
||||
}) async {
|
||||
await _db.into(_db.audioCacheIndex).insertOnConflictUpdate(
|
||||
AudioCacheIndexCompanion.insert(
|
||||
trackId: trackId,
|
||||
path: path,
|
||||
sizeBytes: sizeBytes,
|
||||
source: source,
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Removes a track from the index AND deletes the file.
|
||||
Future<void> unpin(String trackId) async {
|
||||
final row = await (_db.select(_db.audioCacheIndex)
|
||||
@@ -96,13 +117,25 @@ class AudioCacheManager {
|
||||
.go();
|
||||
}
|
||||
|
||||
/// Total bytes used by the cache.
|
||||
/// Total bytes used by the cache. Walks the cache directory directly
|
||||
/// instead of summing the index, because the streaming-as-you-play
|
||||
/// path (audio_handler's LockCachingAudioSource) writes files
|
||||
/// without registering an index row. The index sum would always
|
||||
/// understate (often to zero) for users who only stream.
|
||||
Future<int> usageBytes() async {
|
||||
final result = await _db.customSelect(
|
||||
'SELECT COALESCE(SUM(size_bytes), 0) AS total FROM audio_cache_index',
|
||||
readsFrom: {_db.audioCacheIndex},
|
||||
).getSingle();
|
||||
return result.read<int>('total');
|
||||
final dir = Directory(await _tracksDir());
|
||||
if (!await dir.exists()) return 0;
|
||||
var total = 0;
|
||||
await for (final entity in dir.list(followLinks: false)) {
|
||||
if (entity is File) {
|
||||
try {
|
||||
total += await entity.length();
|
||||
} catch (_) {
|
||||
// Race against concurrent writes / deletes — just skip.
|
||||
}
|
||||
}
|
||||
}
|
||||
return total;
|
||||
}
|
||||
|
||||
/// Evicts files until usage ≤ targetBytes. Eviction order:
|
||||
|
||||
+235
@@ -0,0 +1,235 @@
|
||||
// Background metadata sweeper that walks the drift cache for missing
|
||||
// relations and fills them via /api/artists/:id + /api/albums/:id.
|
||||
// Cover bytes for newly-filled albums are pre-warmed too so the
|
||||
// per-tile display path doesn't have to wait on network.
|
||||
//
|
||||
// Why this layer on top of SyncController and HydrationQueue:
|
||||
// - SyncController.sync only ingests entities the server emitted
|
||||
// into the library_changes delta for this user. For a fresh
|
||||
// install, that's everything; for an existing user, only recent
|
||||
// changes. The per-artist album list and per-album track list
|
||||
// are NOT in those deltas — they're derived at query time.
|
||||
// - HydrationQueue fills these lazily on tile render. CacheFiller
|
||||
// fills them proactively on a slow schedule so tapping an artist
|
||||
// surfaces albums immediately instead of triggering a fresh
|
||||
// /api/artists/:id at tap time.
|
||||
//
|
||||
// Pacing is conservative — 200ms between requests, max 200 entities
|
||||
// per sweep, 5-minute interval. Designed to never compete with user
|
||||
// activity. Wall time on a 1000-artist library: ~3-4 minutes spread
|
||||
// over multiple sweeps.
|
||||
|
||||
import 'dart:async';
|
||||
|
||||
import 'package:drift/drift.dart' show Variable;
|
||||
import 'package:flutter/foundation.dart' show debugPrint;
|
||||
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../auth/auth_provider.dart'
|
||||
show serverUrlProvider, sessionTokenProvider;
|
||||
import '../cache/adapters.dart';
|
||||
import '../cache/audio_cache_manager.dart' show appDbProvider;
|
||||
import '../cache/connectivity_provider.dart';
|
||||
import '../library/library_providers.dart' show libraryApiProvider;
|
||||
|
||||
class CacheFiller {
|
||||
CacheFiller(this._ref);
|
||||
final Ref _ref;
|
||||
|
||||
Timer? _initialTimer;
|
||||
Timer? _intervalTimer;
|
||||
bool _running = false;
|
||||
bool _disposed = false;
|
||||
|
||||
/// Delay between launch and the first sweep. Long enough for
|
||||
/// SyncController to land its initial /api/library/sync so the
|
||||
/// CacheFiller's "unfilled relations" query has meaningful work.
|
||||
static const _initialDelay = Duration(seconds: 10);
|
||||
|
||||
/// Cadence between sweeps. Once a sweep finds nothing to do (steady
|
||||
/// state) the interval becomes a cheap drift query + early exit.
|
||||
static const _interval = Duration(minutes: 5);
|
||||
|
||||
/// Throttle between per-entity REST requests so the filler doesn't
|
||||
/// saturate the server or compete with user-initiated playback.
|
||||
static const _requestThrottle = Duration(milliseconds: 200);
|
||||
|
||||
/// Per-sweep cap. Without this, a fresh install with thousands of
|
||||
/// artists would tie up the network for many minutes in one go.
|
||||
/// The next sweep continues where this one left off (the WHERE
|
||||
/// NOT EXISTS query naturally skips already-filled rows).
|
||||
static const _maxIdsPerSweep = 200;
|
||||
|
||||
void start() {
|
||||
_initialTimer = Timer(_initialDelay, _sweep);
|
||||
_intervalTimer = Timer.periodic(_interval, (_) => _sweep());
|
||||
}
|
||||
|
||||
Future<void> _sweep() async {
|
||||
if (_disposed || _running) return;
|
||||
final online = await _ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true);
|
||||
if (!online) return;
|
||||
_running = true;
|
||||
try {
|
||||
await _fillArtists();
|
||||
if (_disposed) return;
|
||||
await _fillAlbums();
|
||||
} catch (e, st) {
|
||||
debugPrint('cache_filler: sweep failed: $e\n$st');
|
||||
} finally {
|
||||
_running = false;
|
||||
}
|
||||
}
|
||||
|
||||
/// Find artists with no albums in cache and fetch /api/artists/:id
|
||||
/// for each (single round-trip yields artist + albums via the new
|
||||
/// getArtistDetail API method). Newly-discovered album covers
|
||||
/// land in flutter_cache_manager's disk cache too so the next
|
||||
/// visit to the artist's albums grid paints from disk.
|
||||
Future<void> _fillArtists() async {
|
||||
final db = _ref.read(appDbProvider);
|
||||
final rows = await db.customSelect(
|
||||
'''
|
||||
SELECT a.id FROM cached_artists a
|
||||
WHERE NOT EXISTS (
|
||||
SELECT 1 FROM cached_albums b WHERE b.artist_id = a.id
|
||||
)
|
||||
LIMIT ?
|
||||
''',
|
||||
variables: [Variable.withInt(_maxIdsPerSweep)],
|
||||
).get();
|
||||
final ids = rows.map((r) => r.read<String>('id')).toList();
|
||||
if (ids.isEmpty) return;
|
||||
|
||||
final api = await _ref.read(libraryApiProvider.future);
|
||||
final newAlbumIds = <String>[];
|
||||
|
||||
for (final id in ids) {
|
||||
if (_disposed) return;
|
||||
try {
|
||||
final detail = await api.getArtistDetail(id);
|
||||
await db.transaction(() async {
|
||||
await db
|
||||
.into(db.cachedArtists)
|
||||
.insertOnConflictUpdate(detail.artist.toDrift());
|
||||
if (detail.albums.isNotEmpty) {
|
||||
await db.batch((b) {
|
||||
b.insertAllOnConflictUpdate(
|
||||
db.cachedAlbums,
|
||||
detail.albums.map((a) => a.toDrift()).toList(),
|
||||
);
|
||||
});
|
||||
newAlbumIds.addAll(detail.albums.map((a) => a.id));
|
||||
}
|
||||
});
|
||||
} catch (e) {
|
||||
debugPrint('cache_filler: fillArtist($id) failed: $e');
|
||||
}
|
||||
await Future.delayed(_requestThrottle);
|
||||
}
|
||||
|
||||
if (newAlbumIds.isNotEmpty) {
|
||||
await _prewarmCovers(newAlbumIds);
|
||||
}
|
||||
}
|
||||
|
||||
/// Find albums with no tracks in cache and fetch /api/albums/:id
|
||||
/// for each. The bulk response carries the album's track list which
|
||||
/// we persist into cached_tracks for instant album detail render
|
||||
/// on the next visit.
|
||||
Future<void> _fillAlbums() async {
|
||||
final db = _ref.read(appDbProvider);
|
||||
final rows = await db.customSelect(
|
||||
'''
|
||||
SELECT a.id FROM cached_albums a
|
||||
WHERE NOT EXISTS (
|
||||
SELECT 1 FROM cached_tracks t WHERE t.album_id = a.id
|
||||
)
|
||||
LIMIT ?
|
||||
''',
|
||||
variables: [Variable.withInt(_maxIdsPerSweep)],
|
||||
).get();
|
||||
final ids = rows.map((r) => r.read<String>('id')).toList();
|
||||
if (ids.isEmpty) return;
|
||||
|
||||
final api = await _ref.read(libraryApiProvider.future);
|
||||
for (final id in ids) {
|
||||
if (_disposed) return;
|
||||
try {
|
||||
final result = await api.getAlbum(id);
|
||||
if (result.tracks.isNotEmpty) {
|
||||
await db.batch((b) {
|
||||
b.insertAllOnConflictUpdate(
|
||||
db.cachedTracks,
|
||||
result.tracks.map((t) => t.toDrift()).toList(),
|
||||
);
|
||||
});
|
||||
}
|
||||
} catch (e) {
|
||||
debugPrint('cache_filler: fillAlbum($id) failed: $e');
|
||||
}
|
||||
await Future.delayed(_requestThrottle);
|
||||
}
|
||||
}
|
||||
|
||||
/// Pre-warm album cover bytes via flutter_cache_manager so the
|
||||
/// per-tile ServerImage / CachedNetworkImage paints from disk on
|
||||
/// the user's first visit. Mirrors SyncController's prewarm
|
||||
/// helper — duplicated here intentionally to keep this file self-
|
||||
/// contained; a shared helper can come out of #357 follow-up if
|
||||
/// the duplication grows.
|
||||
Future<void> _prewarmCovers(List<String> albumIds) async {
|
||||
final baseUrl = await _ref.read(serverUrlProvider.future);
|
||||
if (baseUrl == null || baseUrl.isEmpty) return;
|
||||
final token = await _ref.read(sessionTokenProvider.future);
|
||||
final headers = (token != null && token.isNotEmpty)
|
||||
? {'Authorization': 'Bearer $token'}
|
||||
: <String, String>{};
|
||||
final base = baseUrl.endsWith('/')
|
||||
? baseUrl.substring(0, baseUrl.length - 1)
|
||||
: baseUrl;
|
||||
final mgr = DefaultCacheManager();
|
||||
|
||||
var idx = 0;
|
||||
Future<void> worker() async {
|
||||
while (idx < albumIds.length) {
|
||||
if (_disposed) return;
|
||||
final i = idx++;
|
||||
try {
|
||||
await mgr.downloadFile(
|
||||
'$base/api/albums/${albumIds[i]}/cover',
|
||||
authHeaders: headers,
|
||||
);
|
||||
} catch (_) {
|
||||
// Best-effort prewarm — 404 (missing collage) and 401
|
||||
// (token refresh races) shouldn't abort the rest.
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Concurrency 3 — same as SyncController's prewarm. Covers are
|
||||
// small enough that more parallelism doesn't help much and
|
||||
// burns radio.
|
||||
await Future.wait(List.generate(3, (_) => worker()));
|
||||
}
|
||||
|
||||
void dispose() {
|
||||
_disposed = true;
|
||||
_initialTimer?.cancel();
|
||||
_intervalTimer?.cancel();
|
||||
}
|
||||
}
|
||||
|
||||
/// Read once at app start (from app.dart's postFrameCallback) to
|
||||
/// activate the filler. Disposed via ref.onDispose when the provider
|
||||
/// scope tears down; in practice the scope lives for the app's
|
||||
/// lifetime so dispose only fires on uninstall / process death.
|
||||
final cacheFillerProvider = Provider<CacheFiller>((ref) {
|
||||
final filler = CacheFiller(ref);
|
||||
ref.onDispose(filler.dispose);
|
||||
filler.start();
|
||||
return filler;
|
||||
});
|
||||
+36
-11
@@ -19,6 +19,10 @@ import 'dart:async';
|
||||
|
||||
import 'package:flutter/foundation.dart' show debugPrint;
|
||||
|
||||
// `tag` parameter is preserved for future ad-hoc instrumentation.
|
||||
// Normal operation only logs failure paths so the per-screen log
|
||||
// noise stays low.
|
||||
|
||||
/// Wraps the watch + cold-cache fallback pattern. Generic over:
|
||||
/// D — the drift row type (or TypedResult for joins)
|
||||
/// T — the result type the caller wants (e.g. `List<ArtistRef>`)
|
||||
@@ -43,14 +47,23 @@ Stream<T> cacheFirst<D, T>({
|
||||
// refresh for this stream subscription, so we don't fire one on every
|
||||
// drift re-emission (otherwise the populate cycles forever).
|
||||
var revalidated = false;
|
||||
void log(String msg) {
|
||||
if (tag != null) debugPrint('cacheFirst[$tag]: $msg');
|
||||
}
|
||||
|
||||
// Tracks whether we've already tried a cold-cache fetch on this
|
||||
// subscription. Without this, providers can spin forever in the
|
||||
// rows-empty branch when fetchAndPopulate writes rows that don't
|
||||
// match THIS filter — e.g. three liked-tab streams sharing one
|
||||
// populate: the track populate writes track-typed rows, drift
|
||||
// watch fires for the cached_likes table, the album stream
|
||||
// re-emits with rows-empty (no album likes), the rows-empty
|
||||
// branch re-fires populate, repeats forever. Setting this guard
|
||||
// makes the first fetch attempt also the last for any given
|
||||
// subscription.
|
||||
var coldFetchAttempted = false;
|
||||
|
||||
await for (final rows in driftStream) {
|
||||
if (rows.isNotEmpty) {
|
||||
log('drift hit (${rows.length} rows)');
|
||||
yield toResult(rows);
|
||||
coldFetchAttempted = true;
|
||||
// Stale-while-revalidate: yield cache immediately, then kick off
|
||||
// a REST refresh in the background. Drift watch() picks up the
|
||||
// resulting writes and re-emits via this same stream loop.
|
||||
@@ -62,20 +75,32 @@ Stream<T> cacheFirst<D, T>({
|
||||
}
|
||||
continue;
|
||||
}
|
||||
log('drift miss; checking connectivity');
|
||||
// rows is empty. If we've already attempted a cold fetch and
|
||||
// drift is still empty for this filter, yield empty so the UI
|
||||
// shows the no-content state instead of spinning forever.
|
||||
if (coldFetchAttempted) {
|
||||
yield toResult(rows);
|
||||
continue;
|
||||
}
|
||||
coldFetchAttempted = true;
|
||||
if (await isOnline()) {
|
||||
log('online; calling fetchAndPopulate');
|
||||
try {
|
||||
await fetchAndPopulate();
|
||||
log('fetchAndPopulate done; awaiting drift re-emit');
|
||||
// The drift watch() stream re-emits with the populated rows on
|
||||
// the next loop iteration. Don't yield here.
|
||||
// Yield the current (still-empty) rows so the UI moves past
|
||||
// loading even if populate was a no-op for this filter
|
||||
// (server returned nothing matching, or all rows were
|
||||
// already in drift via sync). If populate DID write rows
|
||||
// matching this filter, the drift watch's next emission
|
||||
// yields them via the rows.isNotEmpty branch — UI briefly
|
||||
// shows empty then populates, instead of spinning.
|
||||
yield toResult(rows);
|
||||
} catch (e, st) {
|
||||
log('fetchAndPopulate failed: $e\n$st');
|
||||
if (tag != null) {
|
||||
debugPrint('cacheFirst[$tag]: fetchAndPopulate failed: $e\n$st');
|
||||
}
|
||||
yield toResult(rows); // empty result; caller surfaces error
|
||||
}
|
||||
} else {
|
||||
log('offline; yielding empty');
|
||||
yield toResult(rows); // empty result; offline
|
||||
}
|
||||
}
|
||||
|
||||
Vendored
+154
-1
@@ -115,6 +115,116 @@ class SyncMetadata extends Table {
|
||||
Set<Column> get primaryKey => {id};
|
||||
}
|
||||
|
||||
/// Single-row cache of the /api/home response (#357 follow-up). The
|
||||
/// home screen is the first thing the user sees on app open; storing
|
||||
/// the last successful HomeData as JSON lets us yield it immediately
|
||||
/// before the REST round-trip resolves, eliminating the cold-start
|
||||
/// blank on slow / remote connections. Schema 3+.
|
||||
class CachedHomeSnapshot extends Table {
|
||||
IntColumn get id => integer().withDefault(const Constant(1))();
|
||||
TextColumn get json => text()();
|
||||
DateTimeColumn get updatedAt => dateTime().withDefault(currentDateAndTime)();
|
||||
@override
|
||||
Set<Column> get primaryKey => {id};
|
||||
}
|
||||
|
||||
/// Single-row cache of the /api/me/history response. Mirrors the
|
||||
/// CachedHomeSnapshot pattern: opening the History tab in the Library
|
||||
/// screen yields the last-known page immediately while a fresh REST
|
||||
/// pull lands underneath via SWR. Also makes basic offline scrollback
|
||||
/// possible — the last fetched page survives both app restart and
|
||||
/// loss of connectivity. Schema 4+.
|
||||
class CachedHistorySnapshot extends Table {
|
||||
IntColumn get id => integer().withDefault(const Constant(1))();
|
||||
TextColumn get json => text()();
|
||||
DateTimeColumn get updatedAt => dateTime().withDefault(currentDateAndTime)();
|
||||
@override
|
||||
Set<Column> get primaryKey => {id};
|
||||
}
|
||||
|
||||
/// Single-row cache of the /api/me/system-playlists-status response.
|
||||
/// The home Playlists row reads this every render to pick between
|
||||
/// real cards and placeholder cards for For-You / Discover / Songs-
|
||||
/// like slots, so a fresh-mount cold fetch produces a visible
|
||||
/// "building / pending / failed" flicker. Storing the last result
|
||||
/// as a JSON blob means the home renders with the prior status
|
||||
/// instantly, then SWR refreshes underneath. Schema 7+.
|
||||
class CachedSystemPlaylistsStatus extends Table {
|
||||
IntColumn get id => integer().withDefault(const Constant(1))();
|
||||
TextColumn get json => text()();
|
||||
DateTimeColumn get updatedAt => dateTime().withDefault(currentDateAndTime)();
|
||||
@override
|
||||
Set<Column> get primaryKey => {id};
|
||||
}
|
||||
|
||||
/// Section→position→entity-id index for the home screen, populated
|
||||
/// from the per-item discovery endpoint `/api/home/index`. Each row
|
||||
/// pins one tile slot to an entity; the actual entity data lives in
|
||||
/// cached_albums / cached_artists / cached_tracks. The home screen
|
||||
/// reads this table to know the layout, then hydrates each tile
|
||||
/// against the entity tables (per-item rendering). Schema 6+.
|
||||
class CachedHomeIndex extends Table {
|
||||
/// One of: 'recently_added_albums', 'rediscover_albums',
|
||||
/// 'rediscover_artists', 'most_played_tracks', 'last_played_artists'.
|
||||
/// Mirrors the keys /api/home and /api/home/index emit.
|
||||
TextColumn get section => text()();
|
||||
IntColumn get position => integer()();
|
||||
/// One of: 'album', 'artist', 'track'. Used to dispatch hydration
|
||||
/// to the right per-entity endpoint.
|
||||
TextColumn get entityType => text()();
|
||||
TextColumn get entityId => text()();
|
||||
DateTimeColumn get fetchedAt => dateTime().withDefault(currentDateAndTime)();
|
||||
@override
|
||||
Set<Column> get primaryKey => {section, position};
|
||||
}
|
||||
|
||||
/// Outbound mutation queue for offline-resilient REST calls. Likes,
|
||||
/// quarantine flag/unflag, playlist appendTracks, Lidarr request
|
||||
/// create/cancel all enqueue here on REST failure so the user's
|
||||
/// intent persists across network loss. MutationReplayer drains on
|
||||
/// connectivity transitions and a 1-minute periodic tick; entries
|
||||
/// with attempts >= 5 are skipped (the server treats them as
|
||||
/// permanent failures and library_changes sync will correct any
|
||||
/// resulting drift drift on next sync). Schema 8+.
|
||||
class CachedMutations extends Table {
|
||||
IntColumn get id => integer().autoIncrement()();
|
||||
/// Stable kind string (see mutation_queue.dart constants). The
|
||||
/// replayer looks up the handler in a kind→Function map; unknown
|
||||
/// kinds are dropped to avoid getting stuck.
|
||||
TextColumn get kind => text()();
|
||||
/// JSON-encoded payload — args needed to replay the REST call.
|
||||
/// Shape depends on kind; see mutation_queue.dart.
|
||||
TextColumn get payload => text()();
|
||||
DateTimeColumn get createdAt => dateTime().withDefault(currentDateAndTime)();
|
||||
/// When the last drain attempt fired against this row. Null until
|
||||
/// the first attempt. Useful for diagnostic queries.
|
||||
DateTimeColumn get lastAttemptAt => dateTime().nullable()();
|
||||
IntColumn get attempts => integer().withDefault(const Constant(0))();
|
||||
}
|
||||
|
||||
/// Caller-scoped quarantine ("hidden") rows. Mirrors the wire shape of
|
||||
/// /api/quarantine/mine — fully denormalized (track + album + artist
|
||||
/// fields inline) because the Hidden tab renders straight from this row
|
||||
/// without joining other tables. Columnar (vs JSON blob) so flag/unflag
|
||||
/// can do row-level INSERT/DELETE; the drift watch() emission feeds
|
||||
/// MyQuarantineController state directly. Schema 5+.
|
||||
class CachedQuarantineMine extends Table {
|
||||
TextColumn get trackId => text()();
|
||||
TextColumn get reason => text()();
|
||||
TextColumn get notes => text().nullable()();
|
||||
TextColumn get createdAt => text()();
|
||||
TextColumn get trackTitle => text()();
|
||||
IntColumn get trackDurationMs => integer().withDefault(const Constant(0))();
|
||||
TextColumn get albumId => text()();
|
||||
TextColumn get albumTitle => text()();
|
||||
TextColumn get albumCoverArtPath => text().nullable()();
|
||||
TextColumn get artistId => text()();
|
||||
TextColumn get artistName => text()();
|
||||
DateTimeColumn get fetchedAt => dateTime().withDefault(currentDateAndTime)();
|
||||
@override
|
||||
Set<Column> get primaryKey => {trackId};
|
||||
}
|
||||
|
||||
enum CacheSource { manual, autoLiked, autoPlaylist, autoPrefetch, incidental }
|
||||
|
||||
@DriftDatabase(tables: [
|
||||
@@ -126,12 +236,18 @@ enum CacheSource { manual, autoLiked, autoPlaylist, autoPrefetch, incidental }
|
||||
CachedPlaylistTracks,
|
||||
AudioCacheIndex,
|
||||
SyncMetadata,
|
||||
CachedHomeSnapshot,
|
||||
CachedHistorySnapshot,
|
||||
CachedQuarantineMine,
|
||||
CachedHomeIndex,
|
||||
CachedSystemPlaylistsStatus,
|
||||
CachedMutations,
|
||||
])
|
||||
class AppDb extends _$AppDb {
|
||||
AppDb([QueryExecutor? e]) : super(e ?? driftDatabase(name: 'minstrel_cache'));
|
||||
|
||||
@override
|
||||
int get schemaVersion => 2;
|
||||
int get schemaVersion => 8;
|
||||
|
||||
@override
|
||||
MigrationStrategy get migration => MigrationStrategy(
|
||||
@@ -147,6 +263,43 @@ class AppDb extends _$AppDb {
|
||||
// pre-existing rows until they happen to change server-side.
|
||||
await customStatement('UPDATE sync_metadata SET cursor = 0');
|
||||
}
|
||||
if (from < 3) {
|
||||
// Schema 3: cached_home_snapshot for #357 drift-first
|
||||
// home page. No existing rows to migrate — table starts
|
||||
// empty; the first /api/home fetch populates it.
|
||||
await m.createTable(cachedHomeSnapshot);
|
||||
}
|
||||
if (from < 4) {
|
||||
// Schema 4: cached_history_snapshot for drift-first
|
||||
// History tab. Same pattern as cached_home_snapshot —
|
||||
// empty on upgrade; first /api/me/history fetch populates.
|
||||
await m.createTable(cachedHistorySnapshot);
|
||||
}
|
||||
if (from < 5) {
|
||||
// Schema 5: cached_quarantine_mine for drift-first Hidden
|
||||
// tab. Empty on upgrade; first /api/quarantine/mine fetch
|
||||
// populates. Optimistic flag/unflag also writes here.
|
||||
await m.createTable(cachedQuarantineMine);
|
||||
}
|
||||
if (from < 6) {
|
||||
// Schema 6: cached_home_index for per-item rendering.
|
||||
// Empty on upgrade; first /api/home/index fetch populates.
|
||||
// cached_home_snapshot stays in place for now — older
|
||||
// builds still read from it as a fallback path.
|
||||
await m.createTable(cachedHomeIndex);
|
||||
}
|
||||
if (from < 7) {
|
||||
// Schema 7: cached_system_playlists_status. Single-row
|
||||
// snapshot of /api/me/system-playlists-status used by the
|
||||
// home Playlists row. Empty on upgrade; first fetch
|
||||
// populates.
|
||||
await m.createTable(cachedSystemPlaylistsStatus);
|
||||
}
|
||||
if (from < 8) {
|
||||
// Schema 8: cached_mutations outbound queue. Empty on
|
||||
// upgrade; populated by controllers when REST calls fail.
|
||||
await m.createTable(cachedMutations);
|
||||
}
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
+139
@@ -0,0 +1,139 @@
|
||||
// Per-item hydration coordinator for the home/playlist/liked surfaces.
|
||||
//
|
||||
// Tile widgets are reactive to their per-entity drift row. On first
|
||||
// build, if drift has no row for the requested id, the tile asks this
|
||||
// queue to hydrate it. The queue dispatches one /api/<type>/:id
|
||||
// request, writes the result to drift, and the drift watch() on the
|
||||
// tile re-emits with the populated row.
|
||||
//
|
||||
// Concurrency cap: HydrationQueue limits the number of in-flight
|
||||
// requests so a 50-tile home screen doesn't fire 50 parallel /api/
|
||||
// calls and stall the auth-token-bound dio pool. In-flight dedup
|
||||
// (keyed by `<type>:<id>`) ensures a single hydration when multiple
|
||||
// tiles share an entity (rare on home, common when several screens
|
||||
// reference the same album).
|
||||
//
|
||||
// Failures are swallowed — a single failed hydration leaves the tile
|
||||
// in skeleton state. A future retry-on-visit pass can layer on top
|
||||
// without changing the queue's contract.
|
||||
|
||||
import 'dart:async';
|
||||
import 'dart:collection';
|
||||
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../cache/adapters.dart';
|
||||
import '../cache/audio_cache_manager.dart' show appDbProvider;
|
||||
import '../library/library_providers.dart' show libraryApiProvider;
|
||||
|
||||
/// Bounded-concurrency request queue for per-entity hydration. One
|
||||
/// instance per Riverpod scope (provider singleton below).
|
||||
class HydrationQueue {
|
||||
HydrationQueue(this._ref);
|
||||
final Ref _ref;
|
||||
|
||||
/// Concurrent slot count. 4 keeps the dio token pool from saturating
|
||||
/// while still pulling tiles down faster than a serial loop. Bump
|
||||
/// if profiling shows the queue idle while the network is healthy.
|
||||
static const _maxConcurrent = 4;
|
||||
|
||||
final Queue<_HydrationRequest> _pending = Queue();
|
||||
final Set<String> _inFlightKeys = {};
|
||||
int _inFlight = 0;
|
||||
|
||||
/// Request hydration for (entityType, entityId). Idempotent — second
|
||||
/// call for the same key while the first is queued or in flight is
|
||||
/// dropped, so multiple tile rebuilds during a fast scroll don't
|
||||
/// inflate the queue.
|
||||
void enqueue({required String entityType, required String entityId}) {
|
||||
if (entityId.isEmpty) return;
|
||||
final key = '$entityType:$entityId';
|
||||
if (_inFlightKeys.contains(key)) return;
|
||||
if (_pending.any((r) => r.key == key)) return;
|
||||
_pending.add(_HydrationRequest(
|
||||
entityType: entityType, entityId: entityId, key: key));
|
||||
_pump();
|
||||
}
|
||||
|
||||
void _pump() {
|
||||
while (_inFlight < _maxConcurrent && _pending.isNotEmpty) {
|
||||
final req = _pending.removeFirst();
|
||||
_inFlightKeys.add(req.key);
|
||||
_inFlight++;
|
||||
// Unawaited on purpose — _pump returns immediately so further
|
||||
// enqueues can fill remaining slots while this one runs.
|
||||
unawaited(_execute(req).whenComplete(() {
|
||||
_inFlight--;
|
||||
_inFlightKeys.remove(req.key);
|
||||
_pump();
|
||||
}));
|
||||
}
|
||||
}
|
||||
|
||||
Future<void> _execute(_HydrationRequest req) async {
|
||||
try {
|
||||
switch (req.entityType) {
|
||||
case 'album':
|
||||
await _hydrateAlbum(req.entityId);
|
||||
case 'artist':
|
||||
await _hydrateArtist(req.entityId);
|
||||
case 'track':
|
||||
await _hydrateTrack(req.entityId);
|
||||
}
|
||||
} catch (_) {
|
||||
// Swallow — tile stays in skeleton. A retry-on-visit pass can
|
||||
// layer on top later without changing this contract.
|
||||
}
|
||||
}
|
||||
|
||||
Future<void> _hydrateAlbum(String id) async {
|
||||
final api = await _ref.read(libraryApiProvider.future);
|
||||
final result = await api.getAlbum(id);
|
||||
final db = _ref.read(appDbProvider);
|
||||
// Album + tracks come bundled in the same response; persist both
|
||||
// so opening the album detail later is also a drift hit.
|
||||
await db.transaction(() async {
|
||||
await db
|
||||
.into(db.cachedAlbums)
|
||||
.insertOnConflictUpdate(result.album.toDrift());
|
||||
if (result.tracks.isNotEmpty) {
|
||||
await db.batch((b) {
|
||||
b.insertAllOnConflictUpdate(
|
||||
db.cachedTracks, result.tracks.map((t) => t.toDrift()).toList());
|
||||
});
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
Future<void> _hydrateArtist(String id) async {
|
||||
final api = await _ref.read(libraryApiProvider.future);
|
||||
final fresh = await api.getArtist(id);
|
||||
final db = _ref.read(appDbProvider);
|
||||
await db.into(db.cachedArtists).insertOnConflictUpdate(fresh.toDrift());
|
||||
}
|
||||
|
||||
Future<void> _hydrateTrack(String id) async {
|
||||
final api = await _ref.read(libraryApiProvider.future);
|
||||
final fresh = await api.getTrack(id);
|
||||
final db = _ref.read(appDbProvider);
|
||||
await db.into(db.cachedTracks).insertOnConflictUpdate(fresh.toDrift());
|
||||
}
|
||||
}
|
||||
|
||||
class _HydrationRequest {
|
||||
_HydrationRequest({
|
||||
required this.entityType,
|
||||
required this.entityId,
|
||||
required this.key,
|
||||
});
|
||||
final String entityType;
|
||||
final String entityId;
|
||||
final String key;
|
||||
}
|
||||
|
||||
/// Singleton queue scoped to the Riverpod container. Kept as a plain
|
||||
/// Provider (not StateProvider) since the queue's internal state is
|
||||
/// pump-driven, not reactively observed.
|
||||
final hydrationQueueProvider = Provider<HydrationQueue>((ref) {
|
||||
return HydrationQueue(ref);
|
||||
});
|
||||
@@ -0,0 +1,74 @@
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../library/library_providers.dart';
|
||||
import '../models/home_data.dart';
|
||||
|
||||
/// Pre-warms the drift cache for likely-tap targets. Conservative on
|
||||
/// purpose: only warms artistProvider rows (single row, single round
|
||||
/// trip per id) and only ever fires once per id per session. Album
|
||||
/// detail is NOT prewarmed — the albumProvider auto-fetches its track
|
||||
/// list when missing, and pre-warming N albums fans out N parallel
|
||||
/// "fetch tracks" round trips that compete with the user's actual
|
||||
/// playback request for bandwidth.
|
||||
class MetadataPrefetcher {
|
||||
MetadataPrefetcher(this._ref) {
|
||||
_ref.listen<AsyncValue<HomeData>>(homeProvider, (_, next) {
|
||||
next.whenData(_warmHome);
|
||||
});
|
||||
}
|
||||
|
||||
final Ref _ref;
|
||||
|
||||
/// Per-session dedupe so re-rendering a screen (every UI rebuild
|
||||
/// fires the data: callback) doesn't trigger N more fetches for
|
||||
/// ids we've already warmed.
|
||||
final Set<String> _warmedArtists = {};
|
||||
|
||||
/// Cap per section. Covers what fits on screen without scrolling.
|
||||
static const _topN = 8;
|
||||
|
||||
/// Pre-warm artists. Albums are intentionally not pre-warmed —
|
||||
/// see class comment.
|
||||
void warmArtists(Iterable<String> ids) {
|
||||
var n = 0;
|
||||
for (final id in ids) {
|
||||
if (id.isEmpty) continue;
|
||||
if (!_warmedArtists.add(id)) continue; // already warmed
|
||||
if (n++ >= _topN) break;
|
||||
_swallow(_ref.read(artistProvider(id).future));
|
||||
}
|
||||
}
|
||||
|
||||
void _warmHome(HomeData h) {
|
||||
final artistIds = <String>{};
|
||||
for (final a in h.recentlyAddedAlbums.take(_topN)) {
|
||||
if (a.artistId.isNotEmpty) artistIds.add(a.artistId);
|
||||
}
|
||||
for (final a in h.rediscoverAlbums.take(_topN)) {
|
||||
if (a.artistId.isNotEmpty) artistIds.add(a.artistId);
|
||||
}
|
||||
for (final ar in h.rediscoverArtists.take(_topN)) {
|
||||
if (ar.id.isNotEmpty) artistIds.add(ar.id);
|
||||
}
|
||||
for (final ar in h.lastPlayedArtists.take(_topN)) {
|
||||
if (ar.id.isNotEmpty) artistIds.add(ar.id);
|
||||
}
|
||||
for (final t in h.mostPlayedTracks.take(_topN)) {
|
||||
if (t.artistId.isNotEmpty) artistIds.add(t.artistId);
|
||||
}
|
||||
warmArtists(artistIds);
|
||||
}
|
||||
|
||||
/// Discards the return value and any error from a fire-and-forget
|
||||
/// provider read. We don't care about the value here — we only want
|
||||
/// the side effect of writing drift.
|
||||
void _swallow(Future<Object?> f) {
|
||||
f.then<void>((_) {}).onError((_, __) {});
|
||||
}
|
||||
}
|
||||
|
||||
/// Read once at app start to activate the prefetcher (e.g. wire it
|
||||
/// from a top-level Consumer or main.dart container override).
|
||||
final metadataPrefetcherProvider = Provider<MetadataPrefetcher>((ref) {
|
||||
return MetadataPrefetcher(ref);
|
||||
});
|
||||
+296
@@ -0,0 +1,296 @@
|
||||
// Outbound mutation queue for offline-resilient REST calls.
|
||||
//
|
||||
// Controllers (LikesController, MyQuarantineController, the add-to-
|
||||
// playlist sheet, the Discover request flow, the Requests cancel
|
||||
// action) write their optimistic local state to drift first and try
|
||||
// the corresponding REST call. On failure they enqueue here. The
|
||||
// replayer drains the queue when connectivity comes back; the user's
|
||||
// intent persists across network loss without rolling back their
|
||||
// visible action.
|
||||
//
|
||||
// Why this is separate from SyncController: sync ingests AUTHORITATIVE
|
||||
// SERVER state into drift. The mutation queue carries USER INTENT
|
||||
// outbound to the server. They flow in opposite directions and
|
||||
// shouldn't be conflated — sync wins on conflict (server is the
|
||||
// source of truth), and a mutation that fails forever (5 attempts)
|
||||
// is dropped on the trust that next sync will reconcile drift to
|
||||
// match the server's actual state.
|
||||
//
|
||||
// Drop semantics: 5 attempts then drop. The drop is intentional —
|
||||
// holding onto a forever-failing mutation just delays sync's
|
||||
// reconciliation. The user's optimistic drift state will diverge
|
||||
// from server, and the next library_changes delta corrects it.
|
||||
|
||||
import 'dart:async';
|
||||
import 'dart:convert';
|
||||
|
||||
import 'package:dio/dio.dart' show DioException, DioExceptionType;
|
||||
import 'package:drift/drift.dart';
|
||||
import 'package:flutter/foundation.dart' show debugPrint;
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../api/endpoints/discover.dart';
|
||||
import '../api/endpoints/likes.dart';
|
||||
import '../library/library_providers.dart' show dioProvider;
|
||||
import '../likes/likes_provider.dart' show likesApiProvider;
|
||||
import '../models/lidarr.dart' show LidarrRequestKind;
|
||||
import '../playlists/playlists_provider.dart' show playlistsApiProvider;
|
||||
import '../quarantine/quarantine_provider.dart' show quarantineApiProvider;
|
||||
import '../requests/requests_provider.dart' show requestsApiProvider;
|
||||
import 'audio_cache_manager.dart' show appDbProvider;
|
||||
import 'connectivity_provider.dart';
|
||||
import 'db.dart';
|
||||
|
||||
/// Stable kind constants. Each controller emits one of these via
|
||||
/// MutationQueue.enqueue; the replayer dispatches by kind.
|
||||
class MutationKinds {
|
||||
MutationKinds._();
|
||||
static const likeAdd = 'like.add';
|
||||
static const likeRemove = 'like.remove';
|
||||
static const quarantineFlag = 'quarantine.flag';
|
||||
static const quarantineUnflag = 'quarantine.unflag';
|
||||
static const playlistAppend = 'playlist.append';
|
||||
static const requestCreate = 'request.create';
|
||||
static const requestCancel = 'request.cancel';
|
||||
}
|
||||
|
||||
class MutationQueue {
|
||||
MutationQueue(this._ref);
|
||||
final Ref _ref;
|
||||
|
||||
/// Persist a mutation for replay. Caller has already done the
|
||||
/// optimistic local mutation (drift write, in-memory state update)
|
||||
/// — this only records the REST call that needs to fire eventually.
|
||||
Future<void> enqueue(String kind, Map<String, dynamic> payload) async {
|
||||
final db = _ref.read(appDbProvider);
|
||||
await db.into(db.cachedMutations).insert(
|
||||
CachedMutationsCompanion.insert(
|
||||
kind: kind,
|
||||
payload: jsonEncode(payload),
|
||||
),
|
||||
);
|
||||
// Nudge the replayer in case we're online right now.
|
||||
unawaited(_ref.read(mutationReplayerProvider).drain());
|
||||
}
|
||||
|
||||
/// Count of pending mutations (attempts < 5). Diagnostic / future
|
||||
/// UI surface for a "syncing N pending changes" indicator.
|
||||
Future<int> pendingCount() async {
|
||||
final db = _ref.read(appDbProvider);
|
||||
final rows = await db.customSelect(
|
||||
'SELECT COUNT(*) AS c FROM cached_mutations WHERE attempts < 5',
|
||||
).get();
|
||||
return rows.first.read<int>('c');
|
||||
}
|
||||
}
|
||||
|
||||
final mutationQueueProvider =
|
||||
Provider<MutationQueue>((ref) => MutationQueue(ref));
|
||||
|
||||
class MutationReplayer {
|
||||
MutationReplayer(this._ref);
|
||||
final Ref _ref;
|
||||
|
||||
Timer? _initialTimer;
|
||||
Timer? _intervalTimer;
|
||||
bool _running = false;
|
||||
bool _disposed = false;
|
||||
|
||||
/// Periodic poll cadence. The connectivity listener catches most
|
||||
/// transitions; this is the belt-and-suspenders for cases where
|
||||
/// connectivity_plus misses a state change (e.g. flaky Wi-Fi).
|
||||
static const _interval = Duration(minutes: 1);
|
||||
|
||||
/// Max replay attempts before we drop a mutation. 5 is enough to
|
||||
/// span a few reconnection cycles without holding onto a forever-
|
||||
/// broken request. See file header for the drop rationale.
|
||||
static const _maxAttempts = 5;
|
||||
|
||||
void start() {
|
||||
// Drain shortly after launch in case there are queued mutations
|
||||
// from a prior session that died offline. 3s lets the auth +
|
||||
// server-url + dio providers finish their async warmup.
|
||||
_initialTimer = Timer(const Duration(seconds: 3), drain);
|
||||
// Periodic ticker is the only reconnect signal. We previously had
|
||||
// a ref.listen(connectivityProvider, …) edge trigger here, but
|
||||
// subscribing at start-time eagerly mounted the connectivity
|
||||
// StreamProvider and leaked its initial-timeout Timer through
|
||||
// tests that never reach the auth state. The drain() loop itself
|
||||
// gates on connectivity via the .future read below.
|
||||
_intervalTimer = Timer.periodic(_interval, (_) => drain());
|
||||
}
|
||||
|
||||
/// Walk the queue oldest-first, replaying each mutation. Stops on
|
||||
/// any transient network error (we'll retry on the next tick); a
|
||||
/// permanent error (404 etc.) increments the attempt counter and
|
||||
/// moves on to the next mutation. This is public so MutationQueue.
|
||||
/// enqueue can trigger an immediate attempt after writing.
|
||||
Future<void> drain() async {
|
||||
if (_disposed || _running) return;
|
||||
final online = await _ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true);
|
||||
if (!online) return;
|
||||
_running = true;
|
||||
try {
|
||||
while (!_disposed) {
|
||||
final db = _ref.read(appDbProvider);
|
||||
final next = await (db.select(db.cachedMutations)
|
||||
..where((t) => t.attempts.isSmallerThanValue(_maxAttempts))
|
||||
..orderBy([(t) => OrderingTerm.asc(t.createdAt)])
|
||||
..limit(1))
|
||||
.getSingleOrNull();
|
||||
if (next == null) break;
|
||||
|
||||
final handler = _handlers[next.kind];
|
||||
if (handler == null) {
|
||||
debugPrint('mutation_replayer: unknown kind ${next.kind}, dropping');
|
||||
await (db.delete(db.cachedMutations)
|
||||
..where((t) => t.id.equals(next.id)))
|
||||
.go();
|
||||
continue;
|
||||
}
|
||||
|
||||
Map<String, dynamic> payload;
|
||||
try {
|
||||
payload = jsonDecode(next.payload) as Map<String, dynamic>;
|
||||
} catch (e) {
|
||||
debugPrint('mutation_replayer: bad payload for ${next.kind}: $e');
|
||||
await (db.delete(db.cachedMutations)
|
||||
..where((t) => t.id.equals(next.id)))
|
||||
.go();
|
||||
continue;
|
||||
}
|
||||
|
||||
try {
|
||||
await handler(_ref, payload);
|
||||
await (db.delete(db.cachedMutations)
|
||||
..where((t) => t.id.equals(next.id)))
|
||||
.go();
|
||||
} on DioException catch (e) {
|
||||
await (db.update(db.cachedMutations)
|
||||
..where((t) => t.id.equals(next.id)))
|
||||
.write(CachedMutationsCompanion(
|
||||
attempts: Value(next.attempts + 1),
|
||||
lastAttemptAt: Value(DateTime.now()),
|
||||
));
|
||||
if (_isTransient(e)) {
|
||||
// Network is flaky again — bail and try the whole queue
|
||||
// later. The current mutation will be retried next tick.
|
||||
break;
|
||||
}
|
||||
// Permanent failure (4xx/5xx with a real response). Leave
|
||||
// the row with bumped attempts and move on to the next so
|
||||
// one bad mutation doesn't block the others.
|
||||
} catch (e, st) {
|
||||
debugPrint('mutation_replayer: unexpected error: $e\n$st');
|
||||
await (db.update(db.cachedMutations)
|
||||
..where((t) => t.id.equals(next.id)))
|
||||
.write(CachedMutationsCompanion(
|
||||
attempts: Value(next.attempts + 1),
|
||||
lastAttemptAt: Value(DateTime.now()),
|
||||
));
|
||||
}
|
||||
}
|
||||
} finally {
|
||||
_running = false;
|
||||
}
|
||||
}
|
||||
|
||||
bool _isTransient(DioException e) {
|
||||
switch (e.type) {
|
||||
case DioExceptionType.connectionError:
|
||||
case DioExceptionType.connectionTimeout:
|
||||
case DioExceptionType.sendTimeout:
|
||||
case DioExceptionType.receiveTimeout:
|
||||
return true;
|
||||
default:
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
void dispose() {
|
||||
_disposed = true;
|
||||
_initialTimer?.cancel();
|
||||
_intervalTimer?.cancel();
|
||||
}
|
||||
}
|
||||
|
||||
final mutationReplayerProvider = Provider<MutationReplayer>((ref) {
|
||||
final r = MutationReplayer(ref);
|
||||
ref.onDispose(r.dispose);
|
||||
r.start();
|
||||
return r;
|
||||
});
|
||||
|
||||
/// Type signature for kind-specific replay handlers.
|
||||
typedef _Handler = Future<void> Function(Ref, Map<String, dynamic>);
|
||||
|
||||
/// Kind → handler dispatch. Each handler decodes its payload and
|
||||
/// re-fires the original REST call. Throws on failure (caught by the
|
||||
/// replayer's drain loop above).
|
||||
///
|
||||
/// Payload shapes (see also enqueue call sites for the writer side):
|
||||
/// * like.add / like.remove: {'kind': 'track'|'album'|'artist', 'id': uuid}
|
||||
/// * quarantine.flag: {'trackId': uuid, 'reason': str, 'notes': str}
|
||||
/// * quarantine.unflag: {'trackId': uuid}
|
||||
/// * playlist.append: {'playlistId': uuid, 'trackIds': [uuid, …]}
|
||||
/// * request.create: {full createRequest args; see DiscoverApi}
|
||||
/// * request.cancel: {'id': uuid}
|
||||
final Map<String, _Handler> _handlers = {
|
||||
MutationKinds.likeAdd: (ref, p) async {
|
||||
final api = await ref.read(likesApiProvider.future);
|
||||
await api.like(_likeKindFromString(p['kind'] as String), p['id'] as String);
|
||||
},
|
||||
MutationKinds.likeRemove: (ref, p) async {
|
||||
final api = await ref.read(likesApiProvider.future);
|
||||
await api.unlike(
|
||||
_likeKindFromString(p['kind'] as String), p['id'] as String);
|
||||
},
|
||||
MutationKinds.quarantineFlag: (ref, p) async {
|
||||
final api = await ref.read(quarantineApiProvider.future);
|
||||
await api.flag(
|
||||
p['trackId'] as String,
|
||||
p['reason'] as String,
|
||||
notes: (p['notes'] as String?) ?? '',
|
||||
);
|
||||
},
|
||||
MutationKinds.quarantineUnflag: (ref, p) async {
|
||||
final api = await ref.read(quarantineApiProvider.future);
|
||||
await api.unflag(p['trackId'] as String);
|
||||
},
|
||||
MutationKinds.playlistAppend: (ref, p) async {
|
||||
final api = await ref.read(playlistsApiProvider.future);
|
||||
final ids = (p['trackIds'] as List).cast<String>();
|
||||
await api.appendTracks(p['playlistId'] as String, ids);
|
||||
},
|
||||
MutationKinds.requestCreate: (ref, p) async {
|
||||
final dio = await ref.read(dioProvider.future);
|
||||
final api = DiscoverApi(dio);
|
||||
await api.createRequest(
|
||||
kind: _lidarrKindFromString(p['kind'] as String),
|
||||
artistMbid: p['artistMbid'] as String,
|
||||
artistName: p['artistName'] as String,
|
||||
albumMbid: p['albumMbid'] as String?,
|
||||
albumTitle: p['albumTitle'] as String?,
|
||||
trackMbid: p['trackMbid'] as String?,
|
||||
trackTitle: p['trackTitle'] as String?,
|
||||
);
|
||||
},
|
||||
MutationKinds.requestCancel: (ref, p) async {
|
||||
final api = await ref.read(requestsApiProvider.future);
|
||||
await api.cancel(p['id'] as String);
|
||||
},
|
||||
};
|
||||
|
||||
LikeKind _likeKindFromString(String s) => switch (s) {
|
||||
'album' => LikeKind.album,
|
||||
'artist' => LikeKind.artist,
|
||||
_ => LikeKind.track,
|
||||
};
|
||||
|
||||
LidarrRequestKind _lidarrKindFromString(String s) => switch (s) {
|
||||
'album' => LidarrRequestKind.album,
|
||||
'track' => LidarrRequestKind.track,
|
||||
_ => LidarrRequestKind.artist,
|
||||
};
|
||||
+43
-6
@@ -1,6 +1,9 @@
|
||||
import 'dart:async';
|
||||
|
||||
import 'package:audio_service/audio_service.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../player/album_color_extractor.dart';
|
||||
import '../player/player_provider.dart';
|
||||
import 'audio_cache_manager.dart';
|
||||
import 'cache_settings_provider.dart';
|
||||
@@ -39,14 +42,48 @@ class Prefetcher {
|
||||
(currentIdx + settings.prefetchWindow).clamp(0, queue.length - 1);
|
||||
|
||||
final mgr = _ref.read(audioCacheManagerProvider);
|
||||
final coverCache = _ref.read(albumCoverCacheProvider);
|
||||
final colorCache = _ref.read(albumColorCacheProvider);
|
||||
|
||||
// Walk the window. For each upcoming track we want THREE things
|
||||
// ready when the player transitions into it:
|
||||
//
|
||||
// 1. Audio file on disk (otherwise playback stalls on stream
|
||||
// load — the original prefetcher concern).
|
||||
// 2. Cover bytes on disk under AlbumCoverCache (otherwise
|
||||
// _toMediaItem's peekCached returns null, mediaItem
|
||||
// broadcasts with artUri=null, and the now-playing screen
|
||||
// stalls in _scheduleSwap awaiting precacheImage of a file
|
||||
// that doesn't exist yet).
|
||||
// 3. Palette color extracted and memoized in AlbumColorCache
|
||||
// (otherwise the gradient backdrop has to wait for
|
||||
// PaletteGenerator to run after the cover lands —
|
||||
// visible as the cover snapping in before the gradient).
|
||||
//
|
||||
// Each call is idempotent (cache-aware): if already cached, it's
|
||||
// a no-op. Everything fire-and-forget so the reconcile completes
|
||||
// quickly even on a fresh queue.
|
||||
for (var i = currentIdx; i <= endIdx; i++) {
|
||||
final trackId = queue[i].id;
|
||||
if (await mgr.isCached(trackId)) continue;
|
||||
// Fire-and-forget; downloads happen in the background. Errors
|
||||
// inside pin() are caught + cleaned up internally.
|
||||
// ignore: unawaited_futures
|
||||
mgr.pin(trackId, source: CacheSource.autoPrefetch);
|
||||
final media = queue[i];
|
||||
final trackId = media.id;
|
||||
final albumId = media.extras?['album_id'] as String?;
|
||||
|
||||
if (!await mgr.isCached(trackId)) {
|
||||
// ignore: unawaited_futures
|
||||
mgr.pin(trackId, source: CacheSource.autoPrefetch);
|
||||
}
|
||||
|
||||
if (albumId != null && albumId.isNotEmpty) {
|
||||
// Cover bytes: getOrFetch returns the file path; the side
|
||||
// effect (writing to disk) is what we care about.
|
||||
// ignore: unawaited_futures
|
||||
coverCache.getOrFetch(albumId);
|
||||
// Palette: getOrExtract chains off coverCache.getOrFetch so
|
||||
// it'll wait for the cover before sampling — safe to call
|
||||
// in parallel here.
|
||||
// ignore: unawaited_futures
|
||||
colorCache.getOrExtract(albumId);
|
||||
}
|
||||
}
|
||||
|
||||
// Eviction pass after pinning new files.
|
||||
|
||||
+72
-2
@@ -1,6 +1,10 @@
|
||||
import 'dart:async';
|
||||
|
||||
import 'package:drift/drift.dart' as drift;
|
||||
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../auth/auth_provider.dart' show serverUrlProvider, sessionTokenProvider;
|
||||
import '../library/library_providers.dart' show dioProvider;
|
||||
import 'audio_cache_manager.dart' show appDbProvider;
|
||||
import 'db.dart';
|
||||
@@ -75,6 +79,14 @@ class SyncController extends AsyncNotifier<SyncResult?> {
|
||||
|
||||
var upsertCount = 0;
|
||||
var deleteCount = 0;
|
||||
// IDs of upserted entities whose covers we'll pre-warm after the
|
||||
// transaction commits. Filled inside the loops; consumed by
|
||||
// _prewarmCovers fire-and-forget below. Artist covers are
|
||||
// server-derived from "most-recent album" and aren't
|
||||
// reconstructible client-side — album pre-warm already covers an
|
||||
// artist's primary visual via its detail-page header.
|
||||
final albumCoverIds = <String>[];
|
||||
final playlistCoverIds = <String>[];
|
||||
|
||||
await db.transaction(() async {
|
||||
// ---- Upserts ----
|
||||
@@ -85,9 +97,12 @@ class SyncController extends AsyncNotifier<SyncResult?> {
|
||||
upsertCount++;
|
||||
}
|
||||
for (final a in (upserts['album'] as List? ?? const [])) {
|
||||
final m = a as Map<String, dynamic>;
|
||||
await db.into(db.cachedAlbums).insertOnConflictUpdate(
|
||||
_albumFromJson(a as Map<String, dynamic>),
|
||||
_albumFromJson(m),
|
||||
);
|
||||
final id = m['id'];
|
||||
if (id is String && id.isNotEmpty) albumCoverIds.add(id);
|
||||
upsertCount++;
|
||||
}
|
||||
for (final t in (upserts['track'] as List? ?? const [])) {
|
||||
@@ -130,9 +145,12 @@ class SyncController extends AsyncNotifier<SyncResult?> {
|
||||
upsertCount++;
|
||||
}
|
||||
for (final p in (upserts['playlist'] as List? ?? const [])) {
|
||||
final m = p as Map<String, dynamic>;
|
||||
await db.into(db.cachedPlaylists).insertOnConflictUpdate(
|
||||
_playlistFromJson(p as Map<String, dynamic>),
|
||||
_playlistFromJson(m),
|
||||
);
|
||||
final id = m['id'];
|
||||
if (id is String && id.isNotEmpty) playlistCoverIds.add(id);
|
||||
upsertCount++;
|
||||
}
|
||||
for (final pt in (upserts['playlist_track'] as List? ?? const [])) {
|
||||
@@ -224,6 +242,15 @@ class SyncController extends AsyncNotifier<SyncResult?> {
|
||||
);
|
||||
});
|
||||
|
||||
// Fire-and-forget cover pre-warm so a cold-start scroll through
|
||||
// the home grid paints from disk on the very first frame instead
|
||||
// of firing one HTTP request per visible tile. Unawaited because
|
||||
// the sync's "done" signal should fire as soon as the metadata
|
||||
// delta is durable; cover downloads can finish in the background.
|
||||
if (albumCoverIds.isNotEmpty || playlistCoverIds.isNotEmpty) {
|
||||
unawaited(_prewarmCovers(albumCoverIds, playlistCoverIds));
|
||||
}
|
||||
|
||||
final result = SyncResult(
|
||||
upserts: upsertCount,
|
||||
deletes: deleteCount,
|
||||
@@ -237,6 +264,49 @@ class SyncController extends AsyncNotifier<SyncResult?> {
|
||||
}
|
||||
}
|
||||
|
||||
/// Downloads cover bytes for each id into the shared flutter_cache_
|
||||
/// manager disk cache that cached_network_image reads from.
|
||||
/// Best-effort: per-URL failures (404 collage-not-built-yet, 401
|
||||
/// during a token refresh race, network blip) are swallowed so one
|
||||
/// missing cover doesn't abort the rest.
|
||||
///
|
||||
/// Concurrency 3 balances disk-warming throughput against starving
|
||||
/// foreground UI work — covers are ~30-200KB each, so three in
|
||||
/// flight saturates most LAN connections without pinning the radio.
|
||||
Future<void> _prewarmCovers(
|
||||
List<String> albumIds,
|
||||
List<String> playlistIds,
|
||||
) async {
|
||||
final baseUrl = await ref.read(serverUrlProvider.future);
|
||||
if (baseUrl == null || baseUrl.isEmpty) return;
|
||||
final token = await ref.read(sessionTokenProvider.future);
|
||||
final headers = (token != null && token.isNotEmpty)
|
||||
? {'Authorization': 'Bearer $token'}
|
||||
: <String, String>{};
|
||||
final base =
|
||||
baseUrl.endsWith('/') ? baseUrl.substring(0, baseUrl.length - 1) : baseUrl;
|
||||
final urls = <String>[
|
||||
for (final id in albumIds) '$base/api/albums/$id/cover',
|
||||
for (final id in playlistIds) '$base/api/playlists/$id/cover',
|
||||
];
|
||||
final mgr = DefaultCacheManager();
|
||||
var index = 0;
|
||||
Future<void> worker() async {
|
||||
while (index < urls.length) {
|
||||
final i = index++;
|
||||
try {
|
||||
await mgr.downloadFile(urls[i], authHeaders: headers);
|
||||
} catch (_) {
|
||||
// Best-effort prewarm — failures are expected for system
|
||||
// playlists whose collage hasn't been built yet, and for
|
||||
// any transient auth race. Don't surface or abort.
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
await Future.wait(List.generate(3, (_) => worker()));
|
||||
}
|
||||
|
||||
CachedArtistsCompanion _artistFromJson(Map<String, dynamic> j) =>
|
||||
CachedArtistsCompanion.insert(
|
||||
id: j['id'] as String,
|
||||
|
||||
+144
@@ -0,0 +1,144 @@
|
||||
// Per-entity tile providers for the per-item rendering architecture
|
||||
// (see docs/superpowers/specs/2026-05-13-per-item-rendering-design.md).
|
||||
//
|
||||
// Each provider is a StreamProvider.family<EntityRef?, String> keyed
|
||||
// by entity id. The stream:
|
||||
// 1. Watches the entity's drift row
|
||||
// 2. Yields the populated row on every emission
|
||||
// 3. Yields null while the row is absent (UI shows skeleton)
|
||||
// 4. On the first missing-row emission, enqueues a hydration via
|
||||
// HydrationQueue so the row eventually lands
|
||||
//
|
||||
// The tile widget reacts to AsyncValue<EntityRef?>:
|
||||
// - loading or data:null → skeleton
|
||||
// - data:non-null → real card
|
||||
// - error → error placeholder
|
||||
//
|
||||
// Subscriptions are per-tile. A 50-tile home screen creates 50 drift
|
||||
// subscriptions; drift handles this fine in practice but worth
|
||||
// measuring if a future surface scales to hundreds.
|
||||
|
||||
import 'package:drift/drift.dart' as drift show OrderingTerm;
|
||||
import 'package:drift/drift.dart' show leftOuterJoin;
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../cache/adapters.dart';
|
||||
import '../cache/audio_cache_manager.dart' show appDbProvider;
|
||||
import '../models/album.dart';
|
||||
import '../models/artist.dart';
|
||||
import '../models/track.dart';
|
||||
import 'hydration_queue.dart';
|
||||
|
||||
/// Watches the cached_albums row for [id]. Triggers background
|
||||
/// hydration on miss; yields the row once it lands.
|
||||
final albumTileProvider =
|
||||
StreamProvider.family<AlbumRef?, String>((ref, id) async* {
|
||||
if (id.isEmpty) {
|
||||
yield null;
|
||||
return;
|
||||
}
|
||||
final db = ref.watch(appDbProvider);
|
||||
final query = (db.select(db.cachedAlbums)..where((t) => t.id.equals(id)))
|
||||
.join([
|
||||
leftOuterJoin(db.cachedArtists,
|
||||
db.cachedArtists.id.equalsExp(db.cachedAlbums.artistId)),
|
||||
]);
|
||||
var enqueued = false;
|
||||
await for (final rows in query.watch()) {
|
||||
if (rows.isEmpty) {
|
||||
if (!enqueued) {
|
||||
enqueued = true;
|
||||
ref
|
||||
.read(hydrationQueueProvider)
|
||||
.enqueue(entityType: 'album', entityId: id);
|
||||
}
|
||||
yield null;
|
||||
continue;
|
||||
}
|
||||
final r = rows.first;
|
||||
final album = r.readTable(db.cachedAlbums);
|
||||
final artist = r.readTableOrNull(db.cachedArtists);
|
||||
yield album.toRef(artistName: artist?.name ?? '');
|
||||
}
|
||||
});
|
||||
|
||||
/// Watches the cached_artists row for [id]. Triggers background
|
||||
/// hydration on miss; yields the row once it lands.
|
||||
///
|
||||
/// LEFT JOIN cached_albums ordered by sort_title so the first row per
|
||||
/// artist carries a representative album id; toRef() reconstructs
|
||||
/// `/api/albums/<id>/cover` from it. Without this join the ArtistRef
|
||||
/// has an empty coverUrl and tiles fall back to the music-notes
|
||||
/// placeholder even though the server has the cover available.
|
||||
final artistTileProvider =
|
||||
StreamProvider.family<ArtistRef?, String>((ref, id) async* {
|
||||
if (id.isEmpty) {
|
||||
yield null;
|
||||
return;
|
||||
}
|
||||
final db = ref.watch(appDbProvider);
|
||||
final query = (db.select(db.cachedArtists)..where((t) => t.id.equals(id)))
|
||||
.join([
|
||||
leftOuterJoin(db.cachedAlbums,
|
||||
db.cachedAlbums.artistId.equalsExp(db.cachedArtists.id)),
|
||||
])
|
||||
..orderBy([drift.OrderingTerm.asc(db.cachedAlbums.sortTitle)]);
|
||||
var enqueued = false;
|
||||
await for (final rows in query.watch()) {
|
||||
if (rows.isEmpty) {
|
||||
if (!enqueued) {
|
||||
enqueued = true;
|
||||
ref
|
||||
.read(hydrationQueueProvider)
|
||||
.enqueue(entityType: 'artist', entityId: id);
|
||||
}
|
||||
yield null;
|
||||
continue;
|
||||
}
|
||||
// First row has the alphabetically-first album (or null if artist
|
||||
// has no albums in drift yet — yields a coverless ArtistRef which
|
||||
// the UI falls back to the placeholder icon for).
|
||||
final artist = rows.first.readTable(db.cachedArtists);
|
||||
final firstAlbum = rows.first.readTableOrNull(db.cachedAlbums);
|
||||
yield artist.toRef(coverAlbumId: firstAlbum?.id ?? '');
|
||||
}
|
||||
});
|
||||
|
||||
/// Watches the cached_tracks row for [id]. Triggers background
|
||||
/// hydration on miss; yields the row once it lands.
|
||||
final trackTileProvider =
|
||||
StreamProvider.family<TrackRef?, String>((ref, id) async* {
|
||||
if (id.isEmpty) {
|
||||
yield null;
|
||||
return;
|
||||
}
|
||||
final db = ref.watch(appDbProvider);
|
||||
final query = (db.select(db.cachedTracks)..where((t) => t.id.equals(id)))
|
||||
.join([
|
||||
leftOuterJoin(db.cachedArtists,
|
||||
db.cachedArtists.id.equalsExp(db.cachedTracks.artistId)),
|
||||
leftOuterJoin(db.cachedAlbums,
|
||||
db.cachedAlbums.id.equalsExp(db.cachedTracks.albumId)),
|
||||
]);
|
||||
var enqueued = false;
|
||||
await for (final rows in query.watch()) {
|
||||
if (rows.isEmpty) {
|
||||
if (!enqueued) {
|
||||
enqueued = true;
|
||||
ref
|
||||
.read(hydrationQueueProvider)
|
||||
.enqueue(entityType: 'track', entityId: id);
|
||||
}
|
||||
yield null;
|
||||
continue;
|
||||
}
|
||||
final r = rows.first;
|
||||
final t = r.readTable(db.cachedTracks);
|
||||
final a = r.readTableOrNull(db.cachedArtists);
|
||||
final al = r.readTableOrNull(db.cachedAlbums);
|
||||
yield t.toRef(
|
||||
artistName: a?.name ?? '',
|
||||
albumTitle: al?.title ?? '',
|
||||
);
|
||||
}
|
||||
});
|
||||
@@ -1,3 +1,4 @@
|
||||
import 'package:cached_network_image/cached_network_image.dart';
|
||||
import 'package:dio/dio.dart';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
@@ -5,6 +6,7 @@ import 'package:go_router/go_router.dart';
|
||||
|
||||
import '../api/endpoints/discover.dart';
|
||||
import '../api/errors.dart';
|
||||
import '../cache/mutation_queue.dart';
|
||||
import '../library/library_providers.dart' show dioProvider;
|
||||
import '../models/lidarr.dart';
|
||||
import '../shared/widgets/main_app_bar_actions.dart';
|
||||
@@ -47,14 +49,23 @@ class _DiscoverScreenState extends ConsumerState<DiscoverScreen> {
|
||||
|
||||
Future<void> _request(LidarrSearchResult row) async {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final args = {
|
||||
'kind': _kind.wire,
|
||||
'artistMbid':
|
||||
_kind == LidarrRequestKind.artist ? row.mbid : row.artistMbid,
|
||||
'artistName':
|
||||
_kind == LidarrRequestKind.artist ? row.name : row.secondaryText,
|
||||
'albumMbid': _kind == LidarrRequestKind.album ? row.mbid : null,
|
||||
'albumTitle': _kind == LidarrRequestKind.album ? row.name : null,
|
||||
};
|
||||
try {
|
||||
final api = await ref.read(_discoverApiProvider.future);
|
||||
await api.createRequest(
|
||||
kind: _kind,
|
||||
artistMbid: _kind == LidarrRequestKind.artist ? row.mbid : row.artistMbid,
|
||||
artistName: _kind == LidarrRequestKind.artist ? row.name : row.secondaryText,
|
||||
albumMbid: _kind == LidarrRequestKind.album ? row.mbid : null,
|
||||
albumTitle: _kind == LidarrRequestKind.album ? row.name : null,
|
||||
artistMbid: args['artistMbid'] as String,
|
||||
artistName: args['artistName'] as String,
|
||||
albumMbid: args['albumMbid'],
|
||||
albumTitle: args['albumTitle'],
|
||||
);
|
||||
if (mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(SnackBar(
|
||||
@@ -64,12 +75,18 @@ class _DiscoverScreenState extends ConsumerState<DiscoverScreen> {
|
||||
// Re-run search to refresh the `requested` flag on the row.
|
||||
_runSearch();
|
||||
}
|
||||
} on DioException catch (e) {
|
||||
} on DioException catch (_) {
|
||||
// Queue for replay so the user's request persists across
|
||||
// network loss. We don't have a drift table for in-flight
|
||||
// requests yet, so the row won't show on the Requests screen
|
||||
// until replay succeeds — accept that for v1.
|
||||
await ref
|
||||
.read(mutationQueueProvider)
|
||||
.enqueue(MutationKinds.requestCreate, args);
|
||||
if (mounted) {
|
||||
final code = ApiError.fromDio(e).code;
|
||||
ScaffoldMessenger.of(context).showSnackBar(SnackBar(
|
||||
content: Text('Request failed: $code'),
|
||||
backgroundColor: fs.error,
|
||||
content: Text('Request queued: ${row.name}'),
|
||||
backgroundColor: fs.iron,
|
||||
));
|
||||
}
|
||||
}
|
||||
@@ -204,9 +221,14 @@ class _ResultTile extends StatelessWidget {
|
||||
color: fs.slate,
|
||||
child: row.imageUrl.isEmpty
|
||||
? Icon(Icons.album, color: fs.ash)
|
||||
: Image.network(row.imageUrl, fit: BoxFit.cover,
|
||||
errorBuilder: (_, __, ___) =>
|
||||
Icon(Icons.album, color: fs.ash)),
|
||||
: CachedNetworkImage(
|
||||
imageUrl: row.imageUrl,
|
||||
fit: BoxFit.cover,
|
||||
fadeInDuration: const Duration(milliseconds: 120),
|
||||
fadeOutDuration: Duration.zero,
|
||||
errorWidget: (_, __, ___) =>
|
||||
Icon(Icons.album, color: fs.ash),
|
||||
),
|
||||
),
|
||||
),
|
||||
const SizedBox(width: 12),
|
||||
|
||||
@@ -92,10 +92,31 @@ class ArtistDetailScreen extends ConsumerWidget {
|
||||
child: IconButton(
|
||||
icon: Icon(Icons.play_arrow, color: fs.parchment),
|
||||
onPressed: () async {
|
||||
final tracks = await ref.read(artistTracksProvider(id).future);
|
||||
if (tracks.isEmpty) return;
|
||||
final shuffled = [...tracks]..shuffle();
|
||||
ref.read(playerActionsProvider).playTracks(shuffled);
|
||||
try {
|
||||
final tracks =
|
||||
await ref.read(artistTracksProvider(id).future);
|
||||
if (tracks.isEmpty) {
|
||||
if (context.mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
const SnackBar(
|
||||
content: Text(
|
||||
'No tracks found for this artist yet.')),
|
||||
);
|
||||
}
|
||||
return;
|
||||
}
|
||||
final shuffled = [...tracks]..shuffle();
|
||||
await ref
|
||||
.read(playerActionsProvider)
|
||||
.playTracks(shuffled);
|
||||
} catch (e) {
|
||||
debugPrint('artist_detail: play failed: $e');
|
||||
if (context.mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
SnackBar(content: Text("Couldn't start playback: $e")),
|
||||
);
|
||||
}
|
||||
}
|
||||
},
|
||||
),
|
||||
),
|
||||
@@ -109,7 +130,8 @@ class ArtistDetailScreen extends ConsumerWidget {
|
||||
albums.when(
|
||||
error: (e, _) => Center(child: Text('$e', style: TextStyle(color: fs.error))),
|
||||
loading: () => const Padding(padding: EdgeInsets.all(16), child: Center(child: CircularProgressIndicator())),
|
||||
data: (list) => LayoutBuilder(builder: (ctx, constraints) {
|
||||
data: (list) {
|
||||
return LayoutBuilder(builder: (ctx, constraints) {
|
||||
const cols = 3;
|
||||
const sidePad = 8.0;
|
||||
const gap = 8.0;
|
||||
@@ -117,10 +139,11 @@ class ArtistDetailScreen extends ConsumerWidget {
|
||||
(constraints.maxWidth - sidePad * 2 - gap * (cols - 1)) /
|
||||
cols;
|
||||
// Card content: cover (cellW - 16) + 8 + title (≤2 lines
|
||||
// ≈ 36) + small fudge. Artist line is suppressed in this
|
||||
// ≈ 36) + slack. Artist line is suppressed in this
|
||||
// grid (showArtist: false) since the page header already
|
||||
// names the artist.
|
||||
final cellH = (cellW - 16) + 8 + 36 + 4;
|
||||
// names the artist. Slack is generous on purpose — line-
|
||||
// height variations would otherwise overflow by 1px.
|
||||
final cellH = (cellW - 16) + 8 + 36 + 8;
|
||||
return GridView.builder(
|
||||
shrinkWrap: true,
|
||||
physics: const NeverScrollableScrollPhysics(),
|
||||
@@ -144,7 +167,8 @@ class ArtistDetailScreen extends ConsumerWidget {
|
||||
);
|
||||
},
|
||||
);
|
||||
}),
|
||||
});
|
||||
},
|
||||
),
|
||||
]);
|
||||
}
|
||||
|
||||
@@ -4,8 +4,7 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:go_router/go_router.dart';
|
||||
|
||||
import '../api/errors.dart';
|
||||
import '../models/album.dart';
|
||||
import '../models/artist.dart';
|
||||
import '../cache/tile_providers.dart';
|
||||
import '../models/playlist.dart';
|
||||
import '../models/system_playlists_status.dart';
|
||||
import '../models/track.dart';
|
||||
@@ -14,6 +13,7 @@ import '../playlists/widgets/playlist_card.dart';
|
||||
import '../playlists/widgets/playlist_placeholder_card.dart';
|
||||
import '../shared/widgets/connection_error_banner.dart';
|
||||
import '../shared/widgets/main_app_bar_actions.dart';
|
||||
import '../shared/widgets/skeletons.dart';
|
||||
import '../theme/theme_extension.dart';
|
||||
import 'library_providers.dart';
|
||||
import 'widgets/album_card.dart';
|
||||
@@ -21,13 +21,18 @@ import 'widgets/artist_card.dart';
|
||||
import 'widgets/compact_track_card.dart';
|
||||
import 'widgets/horizontal_scroll_row.dart';
|
||||
|
||||
/// Home screen. Per-item rendering: a tiny /api/home/index discovery
|
||||
/// fetch returns just section→IDs, then each tile hydrates itself
|
||||
/// against the per-entity drift tables (sync-populated) with REST
|
||||
/// fallback via the HydrationQueue. Cold-visit dead air shrinks to a
|
||||
/// single small round-trip; tiles materialize as their data lands.
|
||||
class HomeScreen extends ConsumerWidget {
|
||||
const HomeScreen({super.key});
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final home = ref.watch(homeProvider);
|
||||
final index = ref.watch(homeIndexProvider);
|
||||
final allPlaylists = ref.watch(playlistsListProvider('all'));
|
||||
final status = ref.watch(systemPlaylistsStatusProvider);
|
||||
return Scaffold(
|
||||
@@ -39,40 +44,33 @@ class HomeScreen extends ConsumerWidget {
|
||||
actions: const [MainAppBarActions(currentRoute: '/home')],
|
||||
),
|
||||
body: SafeArea(
|
||||
child: home.when(
|
||||
child: index.when(
|
||||
error: (e, _) {
|
||||
final code = e is DioException ? ApiError.fromDio(e).code : 'unknown';
|
||||
if (code == 'connection_refused') {
|
||||
return ConnectionErrorBanner(
|
||||
onRetry: () => ref.refresh(homeProvider),
|
||||
onRetry: () => ref.refresh(homeIndexProvider),
|
||||
);
|
||||
}
|
||||
return Center(child: Text('$e', style: TextStyle(color: fs.error)));
|
||||
},
|
||||
loading: () => _HomeSkeleton(fs: fs),
|
||||
data: (h) => RefreshIndicator(
|
||||
onRefresh: () async => ref.refresh(homeProvider.future),
|
||||
onRefresh: () async => ref.refresh(homeIndexProvider.future),
|
||||
child: ListView(
|
||||
// ClampingScrollPhysics: no bounce overscroll past the
|
||||
// content. Combined with the bottom padding below, this
|
||||
// makes "scroll to end" land the last item just above the
|
||||
// player bar — no empty void.
|
||||
physics: const ClampingScrollPhysics(),
|
||||
children: [
|
||||
_PlaylistsSection(
|
||||
playlists: allPlaylists.value?.owned ?? const [],
|
||||
status: status.value ?? SystemPlaylistsStatus.empty(),
|
||||
),
|
||||
_RecentlyAddedSection(albums: h.recentlyAddedAlbums),
|
||||
_RecentlyAddedSection(ids: h.recentlyAddedAlbums),
|
||||
_RediscoverSection(
|
||||
albums: h.rediscoverAlbums,
|
||||
artists: h.rediscoverArtists,
|
||||
albumIds: h.rediscoverAlbums,
|
||||
artistIds: h.rediscoverArtists,
|
||||
),
|
||||
_MostPlayedSection(tracks: h.mostPlayedTracks),
|
||||
_LastPlayedSection(artists: h.lastPlayedArtists),
|
||||
// Bottom padding ≈ player bar height (top row 80 + seek
|
||||
// 30 + padding 16 ≈ ~140) so the last section's bottom
|
||||
// edge lands right above the player when scrolled.
|
||||
_MostPlayedSection(ids: h.mostPlayedTracks),
|
||||
_LastPlayedSection(ids: h.lastPlayedArtists),
|
||||
const SizedBox(height: 140),
|
||||
],
|
||||
),
|
||||
@@ -83,6 +81,146 @@ class HomeScreen extends ConsumerWidget {
|
||||
}
|
||||
}
|
||||
|
||||
// ─── Per-tile widgets ────────────────────────────────────────────────
|
||||
|
||||
/// Duration of the skeleton→content cross-fade. 220ms reads as "tile
|
||||
/// settled into place" — longer drags, shorter feels like a hard cut.
|
||||
/// Each tile cross-fades independently when its data lands, so the
|
||||
/// natural cascade from the hydration queue's bounded concurrency
|
||||
/// produces a staged-reveal feel without any per-tile delay math.
|
||||
const Duration _tileRevealDuration = Duration(milliseconds: 220);
|
||||
|
||||
/// Album tile: skeleton until albumTileProvider yields a populated row.
|
||||
class _AlbumTile extends ConsumerWidget {
|
||||
const _AlbumTile({required this.id});
|
||||
final String id;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final asyncAlbum = ref.watch(albumTileProvider(id));
|
||||
final album = asyncAlbum.asData?.value;
|
||||
return AnimatedSwitcher(
|
||||
duration: _tileRevealDuration,
|
||||
switchInCurve: Curves.easeOut,
|
||||
child: album == null
|
||||
? const SkeletonAlbumTile(key: ValueKey('skeleton'))
|
||||
: AlbumCard(
|
||||
key: ValueKey('album-${album.id}'),
|
||||
album: album,
|
||||
onTap: () =>
|
||||
context.push('/albums/${album.id}', extra: album),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Artist tile: skeleton until artistTileProvider yields a populated row.
|
||||
class _ArtistTile extends ConsumerWidget {
|
||||
const _ArtistTile({required this.id});
|
||||
final String id;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final asyncArtist = ref.watch(artistTileProvider(id));
|
||||
final artist = asyncArtist.asData?.value;
|
||||
return AnimatedSwitcher(
|
||||
duration: _tileRevealDuration,
|
||||
switchInCurve: Curves.easeOut,
|
||||
child: artist == null
|
||||
? const SkeletonArtistTile(key: ValueKey('skeleton'))
|
||||
: ArtistCard(
|
||||
key: ValueKey('artist-${artist.id}'),
|
||||
artist: artist,
|
||||
onTap: () =>
|
||||
context.push('/artists/${artist.id}', extra: artist),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Track tile (used by Most-Played). On tap, gathers the currently-
|
||||
/// hydrated TrackRefs for the whole section so playback flows like
|
||||
/// it did with the bulk-loaded list. Tracks that haven't hydrated yet
|
||||
/// are skipped from the play list — typically transient on a cold
|
||||
/// visit since hydration runs in parallel and finishes quickly.
|
||||
class _TrackTile extends ConsumerWidget {
|
||||
const _TrackTile({required this.id, required this.sectionIds});
|
||||
final String id;
|
||||
final List<String> sectionIds;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final asyncTrack = ref.watch(trackTileProvider(id));
|
||||
final track = asyncTrack.asData?.value;
|
||||
return AnimatedSwitcher(
|
||||
duration: _tileRevealDuration,
|
||||
switchInCurve: Curves.easeOut,
|
||||
child: track == null
|
||||
? const _CompactTrackSkeleton(key: ValueKey('skeleton'))
|
||||
: CompactTrackCard(
|
||||
key: ValueKey('track-${track.id}'),
|
||||
track: track,
|
||||
sectionTracks: _resolveSectionTracks(ref, sectionIds),
|
||||
index:
|
||||
sectionIds.indexOf(id).clamp(0, sectionIds.length - 1),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Snapshots the section's current track states. Used at tile
|
||||
/// construction time — CompactTrackCard's onTap uses it as the play
|
||||
/// queue. Tracks still hydrating are dropped; once they land, a
|
||||
/// rebuild re-runs this lookup so the queue grows naturally.
|
||||
static List<TrackRef> _resolveSectionTracks(WidgetRef ref, List<String> ids) {
|
||||
final out = <TrackRef>[];
|
||||
for (final i in ids) {
|
||||
final v = ref.read(trackTileProvider(i)).asData?.value;
|
||||
if (v != null) out.add(v);
|
||||
}
|
||||
return out;
|
||||
}
|
||||
}
|
||||
|
||||
/// Compact-track placeholder. 56dp cover + two text lines, matched to
|
||||
/// CompactTrackCard so swapping in the real card doesn't shift the
|
||||
/// row's height.
|
||||
class _CompactTrackSkeleton extends StatelessWidget {
|
||||
const _CompactTrackSkeleton({super.key});
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
return Container(
|
||||
width: 240,
|
||||
margin: const EdgeInsets.symmetric(horizontal: 4),
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8, vertical: 6),
|
||||
child: Row(children: [
|
||||
Container(
|
||||
width: 56,
|
||||
height: 56,
|
||||
decoration: BoxDecoration(
|
||||
color: fs.slate,
|
||||
borderRadius: BorderRadius.circular(6),
|
||||
),
|
||||
),
|
||||
const SizedBox(width: 8),
|
||||
Expanded(
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
mainAxisAlignment: MainAxisAlignment.center,
|
||||
children: [
|
||||
Container(width: 120, height: 12, color: fs.slate),
|
||||
const SizedBox(height: 6),
|
||||
Container(width: 80, height: 10, color: fs.slate),
|
||||
],
|
||||
),
|
||||
),
|
||||
]),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
// ─── Sections ────────────────────────────────────────────────────────
|
||||
|
||||
class _PlaylistsSection extends StatelessWidget {
|
||||
const _PlaylistsSection({required this.playlists, required this.status});
|
||||
final List<Playlist> playlists;
|
||||
@@ -129,13 +267,16 @@ List<_PlaylistRowItem> _buildPlaylistsRow(
|
||||
return null;
|
||||
}
|
||||
|
||||
// Slot 1: For-You.
|
||||
final forYou = findFirst((p) => p.systemVariant == 'for_you');
|
||||
out.add(forYou != null
|
||||
? _RealPlaylist(forYou)
|
||||
: _PlaceholderPlaylist('For You', _variantFor('for-you', status)));
|
||||
|
||||
// Slots 2-4: Songs-like (real first, padded to 3).
|
||||
final discover = findFirst((p) => p.systemVariant == 'discover');
|
||||
out.add(discover != null
|
||||
? _RealPlaylist(discover)
|
||||
: _PlaceholderPlaylist('Discover', _variantFor('discover', status)));
|
||||
|
||||
final songsLike = ownedAll
|
||||
.where((p) => p.systemVariant == 'songs_like_artist')
|
||||
.take(3)
|
||||
@@ -146,7 +287,6 @@ List<_PlaylistRowItem> _buildPlaylistsRow(
|
||||
: _PlaceholderPlaylist('Songs like…', _variantFor('songs-like', status)));
|
||||
}
|
||||
|
||||
// User-created trail (server returns most-recently-updated first).
|
||||
for (final p in ownedAll.where((p) => p.systemVariant == null)) {
|
||||
out.add(_RealPlaylist(p));
|
||||
}
|
||||
@@ -162,44 +302,38 @@ String _variantFor(String slot, SystemPlaylistsStatus s) {
|
||||
}
|
||||
|
||||
class _RecentlyAddedSection extends StatelessWidget {
|
||||
const _RecentlyAddedSection({required this.albums});
|
||||
final List<AlbumRef> albums;
|
||||
const _RecentlyAddedSection({required this.ids});
|
||||
final List<String> ids;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
if (albums.isEmpty) {
|
||||
if (ids.isEmpty) {
|
||||
return const _EmptySection(
|
||||
title: 'Recently added',
|
||||
message: "Nothing added yet. Scan a folder via the server's config.",
|
||||
);
|
||||
}
|
||||
final controller = ScrollController();
|
||||
final rows = _chunk(albums, 25);
|
||||
final rows = _chunk(ids, 25);
|
||||
return Column(crossAxisAlignment: CrossAxisAlignment.start, children: [
|
||||
for (var i = 0; i < rows.length; i++)
|
||||
HorizontalScrollRow(
|
||||
title: i == 0 ? 'Recently added' : '',
|
||||
controller: controller,
|
||||
children: rows[i]
|
||||
.map((a) => AlbumCard(
|
||||
album: a,
|
||||
onTap: () =>
|
||||
context.push('/albums/${a.id}', extra: a),
|
||||
))
|
||||
.toList(),
|
||||
children: rows[i].map((id) => _AlbumTile(id: id)).toList(),
|
||||
),
|
||||
]);
|
||||
}
|
||||
}
|
||||
|
||||
class _RediscoverSection extends StatelessWidget {
|
||||
const _RediscoverSection({required this.albums, required this.artists});
|
||||
final List<AlbumRef> albums;
|
||||
final List<ArtistRef> artists;
|
||||
const _RediscoverSection({required this.albumIds, required this.artistIds});
|
||||
final List<String> albumIds;
|
||||
final List<String> artistIds;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
if (albums.isEmpty && artists.isEmpty) {
|
||||
if (albumIds.isEmpty && artistIds.isEmpty) {
|
||||
return const _EmptySection(
|
||||
title: 'Rediscover',
|
||||
message:
|
||||
@@ -207,47 +341,35 @@ class _RediscoverSection extends StatelessWidget {
|
||||
);
|
||||
}
|
||||
return Column(crossAxisAlignment: CrossAxisAlignment.start, children: [
|
||||
if (albums.isNotEmpty)
|
||||
if (albumIds.isNotEmpty)
|
||||
HorizontalScrollRow(
|
||||
title: 'Rediscover',
|
||||
children: albums
|
||||
.map((a) => AlbumCard(
|
||||
album: a,
|
||||
onTap: () =>
|
||||
context.push('/albums/${a.id}', extra: a),
|
||||
))
|
||||
.toList(),
|
||||
children: albumIds.map((id) => _AlbumTile(id: id)).toList(),
|
||||
),
|
||||
if (artists.isNotEmpty)
|
||||
if (artistIds.isNotEmpty)
|
||||
HorizontalScrollRow(
|
||||
title: albums.isEmpty ? 'Rediscover' : '',
|
||||
title: albumIds.isEmpty ? 'Rediscover' : '',
|
||||
height: 168,
|
||||
children: artists
|
||||
.map((ar) => ArtistCard(
|
||||
artist: ar,
|
||||
onTap: () =>
|
||||
context.push('/artists/${ar.id}', extra: ar),
|
||||
))
|
||||
.toList(),
|
||||
children: artistIds.map((id) => _ArtistTile(id: id)).toList(),
|
||||
),
|
||||
]);
|
||||
}
|
||||
}
|
||||
|
||||
class _MostPlayedSection extends StatelessWidget {
|
||||
const _MostPlayedSection({required this.tracks});
|
||||
final List<TrackRef> tracks;
|
||||
const _MostPlayedSection({required this.ids});
|
||||
final List<String> ids;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
if (tracks.isEmpty) {
|
||||
if (ids.isEmpty) {
|
||||
return const _EmptySection(
|
||||
title: 'Most played',
|
||||
message: 'No plays to draw from. Listen to something.',
|
||||
);
|
||||
}
|
||||
final controller = ScrollController();
|
||||
final rows = _chunk(tracks, 25);
|
||||
final rows = _chunk(ids, 25);
|
||||
return Column(crossAxisAlignment: CrossAxisAlignment.start, children: [
|
||||
for (var i = 0; i < rows.length; i++)
|
||||
HorizontalScrollRow(
|
||||
@@ -255,12 +377,7 @@ class _MostPlayedSection extends StatelessWidget {
|
||||
height: 64,
|
||||
controller: controller,
|
||||
children: [
|
||||
for (var j = 0; j < rows[i].length; j++)
|
||||
CompactTrackCard(
|
||||
track: rows[i][j],
|
||||
sectionTracks: tracks,
|
||||
index: i * 25 + j,
|
||||
),
|
||||
for (final id in rows[i]) _TrackTile(id: id, sectionIds: ids),
|
||||
],
|
||||
),
|
||||
]);
|
||||
@@ -268,12 +385,12 @@ class _MostPlayedSection extends StatelessWidget {
|
||||
}
|
||||
|
||||
class _LastPlayedSection extends StatelessWidget {
|
||||
const _LastPlayedSection({required this.artists});
|
||||
final List<ArtistRef> artists;
|
||||
const _LastPlayedSection({required this.ids});
|
||||
final List<String> ids;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
if (artists.isEmpty) {
|
||||
if (ids.isEmpty) {
|
||||
return const _EmptySection(
|
||||
title: 'Last played',
|
||||
message: 'No recent plays.',
|
||||
@@ -282,13 +399,7 @@ class _LastPlayedSection extends StatelessWidget {
|
||||
return HorizontalScrollRow(
|
||||
title: 'Last played',
|
||||
height: 168,
|
||||
children: artists
|
||||
.map((ar) => ArtistCard(
|
||||
artist: ar,
|
||||
onTap: () =>
|
||||
context.push('/artists/${ar.id}', extra: ar),
|
||||
))
|
||||
.toList(),
|
||||
children: ids.map((id) => _ArtistTile(id: id)).toList(),
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -319,11 +430,11 @@ class _EmptySection extends StatelessWidget {
|
||||
}
|
||||
}
|
||||
|
||||
/// Cold-start skeleton. Renders the same shape as the real home (a few
|
||||
/// section titles + card-sized placeholders) so the page feels alive
|
||||
/// while /api/home is in flight, instead of a 30-second blank spinner.
|
||||
/// Each section drops in independently as data arrives via the
|
||||
/// individual providers.
|
||||
/// Cold-start skeleton — shown only between mount and the first
|
||||
/// homeIndexProvider emission (typically a single drift query + small
|
||||
/// REST round-trip). Each section then renders its own per-tile
|
||||
/// skeletons internally, so this widget's role is just the very first
|
||||
/// pre-discovery frame.
|
||||
class _HomeSkeleton extends StatelessWidget {
|
||||
const _HomeSkeleton({required this.fs});
|
||||
final FabledSwordTheme fs;
|
||||
@@ -376,26 +487,7 @@ class _SkeletonSection extends StatelessWidget {
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16),
|
||||
physics: const NeverScrollableScrollPhysics(),
|
||||
itemCount: 6,
|
||||
itemBuilder: (_, __) => Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8),
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
Container(
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
decoration: BoxDecoration(
|
||||
color: fs.slate,
|
||||
borderRadius: BorderRadius.circular(6),
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 8),
|
||||
Container(width: coverSize * 0.7, height: 12, color: fs.slate),
|
||||
const SizedBox(height: 4),
|
||||
Container(width: coverSize * 0.4, height: 10, color: fs.iron),
|
||||
],
|
||||
),
|
||||
),
|
||||
itemBuilder: (_, __) => SkeletonAlbumTile(width: cardWidth),
|
||||
),
|
||||
),
|
||||
]);
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import 'dart:async';
|
||||
import 'dart:convert';
|
||||
|
||||
import 'package:dio/dio.dart';
|
||||
import 'package:drift/drift.dart' as drift;
|
||||
@@ -16,6 +17,7 @@ import '../cache/db.dart';
|
||||
import '../models/album.dart';
|
||||
import '../models/artist.dart';
|
||||
import '../models/home_data.dart';
|
||||
import '../models/home_index.dart';
|
||||
import '../models/track.dart';
|
||||
|
||||
/// Shared authenticated dio. This is the ONLY place tokenResolver is wired
|
||||
@@ -42,33 +44,224 @@ final libraryApiProvider = FutureProvider<LibraryApi>((ref) async {
|
||||
return LibraryApi(await ref.watch(dioProvider.future));
|
||||
});
|
||||
|
||||
final homeProvider = FutureProvider<HomeData>((ref) async {
|
||||
return (await ref.watch(libraryApiProvider.future)).getHome();
|
||||
/// Drift-first home data (#357 follow-up). The home screen is the first
|
||||
/// view the user sees on app open; without a local cache the cold-start
|
||||
/// blocks on the /api/home round-trip, which is the dominant felt-
|
||||
/// latency on slow / remote connections.
|
||||
///
|
||||
/// Cache layout: a single row in `cached_home_snapshot` storing the
|
||||
/// last successful HomeData as JSON. On stream subscription:
|
||||
///
|
||||
/// - If a row exists, yield it immediately (parsed from JSON) and
|
||||
/// kick off a background revalidation against /api/home (SWR).
|
||||
/// The drift watch() re-emits when the new row is written.
|
||||
/// - If no row exists yet (cold cache), fetch /api/home synchronously,
|
||||
/// upsert into drift, and emit. Subsequent emissions come from the
|
||||
/// drift watch as background revalidations land.
|
||||
///
|
||||
/// The HomeData JSON encodes back to the same wire shape /api/home
|
||||
/// emits, so the existing HomeData.fromJson handles both sources.
|
||||
final homeProvider = StreamProvider<HomeData>((ref) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
return cacheFirst<CachedHomeSnapshotData, HomeData>(
|
||||
driftStream: db.select(db.cachedHomeSnapshot).watch(),
|
||||
fetchAndPopulate: () async {
|
||||
final api = await ref.read(libraryApiProvider.future);
|
||||
final fresh = await api.getHome();
|
||||
await db.into(db.cachedHomeSnapshot).insertOnConflictUpdate(
|
||||
CachedHomeSnapshotCompanion.insert(
|
||||
json: _encodeHomeData(fresh),
|
||||
updatedAt: drift.Value(DateTime.now()),
|
||||
),
|
||||
);
|
||||
},
|
||||
toResult: (rows) => rows.isEmpty
|
||||
? const HomeData(
|
||||
recentlyAddedAlbums: [],
|
||||
rediscoverAlbums: [],
|
||||
rediscoverArtists: [],
|
||||
mostPlayedTracks: [],
|
||||
lastPlayedArtists: [],
|
||||
)
|
||||
: HomeData.fromJson(jsonDecode(rows.first.json) as Map<String, dynamic>),
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
// SWR: when cached snapshot exists, still hit /api/home in the
|
||||
// background so the user sees the freshest curation. The cache
|
||||
// mostly serves the first frame, not the canonical state.
|
||||
alwaysRefresh: true,
|
||||
tag: 'home',
|
||||
);
|
||||
});
|
||||
|
||||
/// Drift-first per-item home index. Reads from cached_home_index
|
||||
/// (populated by /api/home/index discovery) and yields a HomeIndex
|
||||
/// the screen consumes to lay out section→tile slots. Each tile is
|
||||
/// rendered by a per-entity tile provider that hydrates itself.
|
||||
///
|
||||
/// Section keys mirror the server's response shape so the encode /
|
||||
/// decode round-trip is straightforward — the table stores
|
||||
/// (section, position, entityType, entityId), and toResult reassembles
|
||||
/// the parallel ID lists.
|
||||
final homeIndexProvider = StreamProvider<HomeIndex>((ref) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
final query = (db.select(db.cachedHomeIndex)
|
||||
..orderBy([
|
||||
(t) => drift.OrderingTerm.asc(t.section),
|
||||
(t) => drift.OrderingTerm.asc(t.position),
|
||||
]))
|
||||
.watch();
|
||||
return cacheFirst<CachedHomeIndexData, HomeIndex>(
|
||||
driftStream: query,
|
||||
fetchAndPopulate: () async {
|
||||
final api = await ref.read(libraryApiProvider.future);
|
||||
final fresh = await api.getHomeIndex();
|
||||
// Full replace in a transaction so the watch() sees exactly one
|
||||
// post-fetch emission with the merged state. Section ordering is
|
||||
// re-asserted on read (orderBy above) so the write order doesn't
|
||||
// matter — letting us batch flat instead of section-by-section.
|
||||
await db.transaction(() async {
|
||||
await db.delete(db.cachedHomeIndex).go();
|
||||
await db.batch((b) {
|
||||
void rows(String section, String entityType, List<String> ids) {
|
||||
for (var i = 0; i < ids.length; i++) {
|
||||
b.insert(
|
||||
db.cachedHomeIndex,
|
||||
CachedHomeIndexCompanion.insert(
|
||||
section: section,
|
||||
position: i,
|
||||
entityType: entityType,
|
||||
entityId: ids[i],
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
rows('recently_added_albums', 'album', fresh.recentlyAddedAlbums);
|
||||
rows('rediscover_albums', 'album', fresh.rediscoverAlbums);
|
||||
rows('rediscover_artists', 'artist', fresh.rediscoverArtists);
|
||||
rows('most_played_tracks', 'track', fresh.mostPlayedTracks);
|
||||
rows('last_played_artists', 'artist', fresh.lastPlayedArtists);
|
||||
});
|
||||
});
|
||||
},
|
||||
toResult: (rows) {
|
||||
final recentlyAddedAlbums = <String>[];
|
||||
final rediscoverAlbums = <String>[];
|
||||
final rediscoverArtists = <String>[];
|
||||
final mostPlayedTracks = <String>[];
|
||||
final lastPlayedArtists = <String>[];
|
||||
for (final r in rows) {
|
||||
switch (r.section) {
|
||||
case 'recently_added_albums':
|
||||
recentlyAddedAlbums.add(r.entityId);
|
||||
case 'rediscover_albums':
|
||||
rediscoverAlbums.add(r.entityId);
|
||||
case 'rediscover_artists':
|
||||
rediscoverArtists.add(r.entityId);
|
||||
case 'most_played_tracks':
|
||||
mostPlayedTracks.add(r.entityId);
|
||||
case 'last_played_artists':
|
||||
lastPlayedArtists.add(r.entityId);
|
||||
}
|
||||
}
|
||||
return HomeIndex(
|
||||
recentlyAddedAlbums: recentlyAddedAlbums,
|
||||
rediscoverAlbums: rediscoverAlbums,
|
||||
rediscoverArtists: rediscoverArtists,
|
||||
mostPlayedTracks: mostPlayedTracks,
|
||||
lastPlayedArtists: lastPlayedArtists,
|
||||
);
|
||||
},
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
// SWR: cached layout shows instantly; fresh /api/home/index lands
|
||||
// in the background and tiles re-resolve as the table mutates.
|
||||
alwaysRefresh: true,
|
||||
tag: 'homeIndex',
|
||||
);
|
||||
});
|
||||
|
||||
/// Encodes HomeData back to the wire-format JSON shape /api/home
|
||||
/// emits, so HomeData.fromJson can round-trip through the drift cache.
|
||||
String _encodeHomeData(HomeData h) => jsonEncode({
|
||||
'recently_added_albums': h.recentlyAddedAlbums.map(_albumToJson).toList(),
|
||||
'rediscover_albums': h.rediscoverAlbums.map(_albumToJson).toList(),
|
||||
'rediscover_artists': h.rediscoverArtists.map(_artistToJson).toList(),
|
||||
'most_played_tracks': h.mostPlayedTracks.map(_trackToJson).toList(),
|
||||
'last_played_artists': h.lastPlayedArtists.map(_artistToJson).toList(),
|
||||
});
|
||||
|
||||
Map<String, dynamic> _albumToJson(AlbumRef a) => {
|
||||
'id': a.id,
|
||||
'title': a.title,
|
||||
'sort_title': a.sortTitle,
|
||||
'artist_id': a.artistId,
|
||||
'artist_name': a.artistName,
|
||||
'year': a.year,
|
||||
'track_count': a.trackCount,
|
||||
'duration_sec': a.durationSec,
|
||||
'cover_url': a.coverUrl,
|
||||
};
|
||||
|
||||
Map<String, dynamic> _artistToJson(ArtistRef a) => {
|
||||
'id': a.id,
|
||||
'name': a.name,
|
||||
'sort_name': a.sortName,
|
||||
'album_count': a.albumCount,
|
||||
'cover_url': a.coverUrl,
|
||||
};
|
||||
|
||||
Map<String, dynamic> _trackToJson(TrackRef t) => {
|
||||
'id': t.id,
|
||||
'title': t.title,
|
||||
'album_id': t.albumId,
|
||||
'album_title': t.albumTitle,
|
||||
'artist_id': t.artistId,
|
||||
'artist_name': t.artistName,
|
||||
'track_number': t.trackNumber,
|
||||
'disc_number': t.discNumber,
|
||||
'duration_sec': t.durationSec,
|
||||
'stream_url': t.streamUrl,
|
||||
};
|
||||
|
||||
/// Drift-first per #357 plan C. Watches cached_artists for the row;
|
||||
/// when empty + online, fetches via REST + populates drift, which
|
||||
/// re-emits via watch().
|
||||
final artistProvider =
|
||||
StreamProvider.family<ArtistRef, String>((ref, id) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
return cacheFirst<CachedArtist, ArtistRef>(
|
||||
driftStream: (db.select(db.cachedArtists)..where((t) => t.id.equals(id)))
|
||||
.watch(),
|
||||
// LEFT JOIN cached_albums for cover-URL reconstruction (see
|
||||
// CachedArtistAdapter.toRef). First row carries the alphabetically-
|
||||
// first album.
|
||||
final query = (db.select(db.cachedArtists)..where((t) => t.id.equals(id)))
|
||||
.join([
|
||||
drift.leftOuterJoin(db.cachedAlbums,
|
||||
db.cachedAlbums.artistId.equalsExp(db.cachedArtists.id)),
|
||||
])
|
||||
..orderBy([drift.OrderingTerm.asc(db.cachedAlbums.sortTitle)]);
|
||||
return cacheFirst<drift.TypedResult, ArtistRef>(
|
||||
driftStream: query.watch(),
|
||||
fetchAndPopulate: () async {
|
||||
final api = await ref.read(libraryApiProvider.future);
|
||||
final fresh = await api.getArtist(id);
|
||||
await db.into(db.cachedArtists).insertOnConflictUpdate(fresh.toDrift());
|
||||
},
|
||||
toResult: (rows) => rows.isEmpty
|
||||
? const ArtistRef(id: '', name: '')
|
||||
: rows.first.toRef(),
|
||||
toResult: (rows) {
|
||||
if (rows.isEmpty) return const ArtistRef(id: '', name: '');
|
||||
final artist = rows.first.readTable(db.cachedArtists);
|
||||
final firstAlbum = rows.first.readTableOrNull(db.cachedAlbums);
|
||||
return artist.toRef(coverAlbumId: firstAlbum?.id ?? '');
|
||||
},
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
// SWR: yield cache instantly on hit, refresh in the background so
|
||||
// the row catches up to server state without making the user wait.
|
||||
alwaysRefresh: true,
|
||||
// No alwaysRefresh: artist rows don't change frequently, and the
|
||||
// metadata prefetcher creates many subscriptions in parallel —
|
||||
// each silently re-fetching once would saturate the request
|
||||
// pipeline behind the user's actual playback request.
|
||||
tag: 'artist($id)',
|
||||
);
|
||||
});
|
||||
@@ -100,6 +293,13 @@ final artistAlbumsProvider =
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
// SWR: re-fetch the full album list on every visit. Without this,
|
||||
// a previously-incomplete drift cache (e.g. user had only opened
|
||||
// one album by this artist, so cachedAlbums had just that row)
|
||||
// would render forever as a partial list. The prefetcher only
|
||||
// warms artistProvider (single row), so this provider isn't
|
||||
// mass-instantiated and the storm risk that motivated dropping
|
||||
// alwaysRefresh elsewhere doesn't apply here.
|
||||
alwaysRefresh: true,
|
||||
tag: 'artistAlbums($artistId)',
|
||||
);
|
||||
@@ -137,7 +337,6 @@ final artistTracksProvider =
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
alwaysRefresh: true,
|
||||
tag: 'artistTracks($artistId)',
|
||||
);
|
||||
});
|
||||
@@ -169,10 +368,7 @@ final albumProvider = StreamProvider.family<
|
||||
// Once-per-subscription guard so we don't re-fetch in a loop if the
|
||||
// server genuinely returns zero tracks (or if the fetch fails).
|
||||
var fetchAttempted = false;
|
||||
// SWR revalidation guard — fire one background refresh per
|
||||
// subscription on the first complete cache hit, so the displayed
|
||||
// data catches up to server state without making the user wait.
|
||||
var revalidated = false;
|
||||
// (revalidated flag removed; see SWR note below the yield.)
|
||||
|
||||
Future<bool> isOnline() async {
|
||||
try {
|
||||
@@ -191,11 +387,9 @@ final albumProvider = StreamProvider.family<
|
||||
Future<bool> fetchAndPopulate() async {
|
||||
try {
|
||||
final api = await ref.read(libraryApiProvider.future);
|
||||
debugPrint('albumProvider($albumId): calling getAlbum');
|
||||
final fresh = await api
|
||||
.getAlbum(albumId)
|
||||
.timeout(const Duration(seconds: 10));
|
||||
debugPrint('albumProvider($albumId): got ${fresh.tracks.length} tracks, writing to drift');
|
||||
// Collect every artist mentioned by the album + its tracks so
|
||||
// the JOINs that drive both the album header and the track rows
|
||||
// have something to bind to. Without this, drift returns null
|
||||
@@ -228,7 +422,6 @@ final albumProvider = StreamProvider.family<
|
||||
b.insertAllOnConflictUpdate(db.cachedTracks,
|
||||
fresh.tracks.map((t) => t.toDrift()).toList());
|
||||
});
|
||||
debugPrint('albumProvider($albumId): drift write done; awaiting watch re-emit');
|
||||
return true;
|
||||
} catch (e, st) {
|
||||
debugPrint('albumProvider($albumId): cold-cache fetch failed: $e\n$st');
|
||||
@@ -239,7 +432,6 @@ final albumProvider = StreamProvider.family<
|
||||
await for (final albumRows in albumQuery.watch()) {
|
||||
// Case 1: no album row at all → cold-fetch.
|
||||
if (albumRows.isEmpty) {
|
||||
debugPrint('albumProvider($albumId): drift miss, attempting cold-cache fetch');
|
||||
if (fetchAttempted) {
|
||||
// Already tried and got nothing back.
|
||||
yield (
|
||||
@@ -249,10 +441,7 @@ final albumProvider = StreamProvider.family<
|
||||
continue;
|
||||
}
|
||||
fetchAttempted = true;
|
||||
final online = await isOnline();
|
||||
debugPrint('albumProvider($albumId): online=$online');
|
||||
if (!online) {
|
||||
debugPrint('albumProvider($albumId): offline, yielding empty');
|
||||
if (!await isOnline()) {
|
||||
yield (
|
||||
album: const AlbumRef(id: '', title: '', artistId: ''),
|
||||
tracks: const <TrackRef>[],
|
||||
@@ -269,7 +458,6 @@ final albumProvider = StreamProvider.family<
|
||||
// On success, drift watch re-emits with rows; loop continues.
|
||||
continue;
|
||||
}
|
||||
debugPrint('albumProvider($albumId): drift hit (${albumRows.length} rows)');
|
||||
|
||||
final albumRow = albumRows.first;
|
||||
final album = albumRow.readTable(db.cachedAlbums).toRef(
|
||||
@@ -284,7 +472,6 @@ final albumProvider = StreamProvider.family<
|
||||
// fetchAndPopulate so the album becomes complete; drift watch
|
||||
// re-emits and we land in the populated branch on the next pass.
|
||||
if (trackRows.isEmpty && !fetchAttempted) {
|
||||
debugPrint('albumProvider($albumId): album hit but no tracks; fetching');
|
||||
fetchAttempted = true;
|
||||
if (await isOnline()) {
|
||||
final ok = await fetchAndPopulate();
|
||||
@@ -303,15 +490,13 @@ final albumProvider = StreamProvider.family<
|
||||
);
|
||||
}).toList();
|
||||
|
||||
// SWR: first complete cache hit triggers one background refresh
|
||||
// so we don't show stale data indefinitely. Drift watch re-emits
|
||||
// on success and the next iteration yields the fresh data.
|
||||
if (!revalidated && trackRows.isNotEmpty) {
|
||||
revalidated = true;
|
||||
if (await isOnline()) {
|
||||
unawaited(fetchAndPopulate());
|
||||
}
|
||||
}
|
||||
// Note: NO SWR here on purpose. Prior code kicked a background
|
||||
// refresh on every first cache hit, which combined with the
|
||||
// metadata prefetcher meant every prewarmed album id triggered
|
||||
// an extra fetch even when drift was already populated. Tracks
|
||||
// and album metadata don't change on the same timescale as
|
||||
// playlists; a stale read is fine until the user invalidates
|
||||
// (pull-to-refresh) or the album is genuinely re-fetched.
|
||||
|
||||
yield (album: album, tracks: tracks);
|
||||
}
|
||||
|
||||
@@ -1,3 +1,6 @@
|
||||
import 'dart:convert';
|
||||
|
||||
import 'package:drift/drift.dart' as drift;
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:go_router/go_router.dart';
|
||||
@@ -5,17 +8,26 @@ import 'package:go_router/go_router.dart';
|
||||
import '../api/endpoints/library_lists.dart';
|
||||
import '../api/endpoints/likes.dart';
|
||||
import '../api/endpoints/me.dart';
|
||||
import '../auth/auth_provider.dart' show authControllerProvider;
|
||||
import '../cache/adapters.dart';
|
||||
import '../cache/audio_cache_manager.dart' show appDbProvider;
|
||||
import '../cache/cache_first.dart';
|
||||
import '../cache/connectivity_provider.dart';
|
||||
import '../cache/db.dart';
|
||||
import '../cache/metadata_prefetcher.dart';
|
||||
import '../cache/tile_providers.dart';
|
||||
import '../library/library_providers.dart' show dioProvider;
|
||||
import '../models/album.dart';
|
||||
import '../models/artist.dart';
|
||||
import '../models/history_event.dart';
|
||||
// Aliased: Flutter's Material exports a `Page` class (Navigator 2.0
|
||||
// route descriptor) that conflicts with our wire-format Page<T>.
|
||||
import '../models/page.dart' as wire;
|
||||
import '../models/quarantine_mine.dart';
|
||||
import '../models/track.dart';
|
||||
import '../player/player_provider.dart';
|
||||
import '../quarantine/quarantine_provider.dart';
|
||||
import '../shared/live_events_provider.dart';
|
||||
import '../shared/widgets/main_app_bar_actions.dart';
|
||||
import '../shared/widgets/skeletons.dart';
|
||||
import '../shared/widgets/server_image.dart';
|
||||
import '../theme/theme_extension.dart';
|
||||
import 'widgets/album_card.dart';
|
||||
import 'widgets/artist_card.dart';
|
||||
@@ -37,33 +49,294 @@ final _meApiProvider = FutureProvider<MeApi>((ref) async {
|
||||
return MeApi(await ref.watch(dioProvider.future));
|
||||
});
|
||||
|
||||
final _libraryArtistsProvider = FutureProvider<wire.Paged<ArtistRef>>((ref) async {
|
||||
return (await ref.watch(_libraryListsApiProvider.future)).listArtists();
|
||||
/// Drift-first all-artists list. Reads cached_artists ordered by
|
||||
/// sortName; GridView.builder takes care of lazy widget construction
|
||||
/// so loading the full set up front is fine for typical library sizes.
|
||||
/// SWR refresh on every subscription hits /api/artists with a generous
|
||||
/// limit so newly-scanned-but-not-yet-synced rows land soon after.
|
||||
///
|
||||
/// The old AsyncNotifier+loadMore infinite-scroll path went away: the
|
||||
/// previous "fetch one page at a time as you scroll" felt like the
|
||||
/// rest of the app was buffering when this tab was the slow surface,
|
||||
/// and SyncController already populates the full set of artist rows
|
||||
/// via /api/library/sync.
|
||||
final _libraryArtistsProvider = StreamProvider<List<ArtistRef>>((ref) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
// LEFT JOIN cached_albums so each artist row carries a representative
|
||||
// album id for cover-URL reconstruction. Sorted by artist sortName
|
||||
// then album sortTitle: the first row per artist gets the
|
||||
// alphabetically-first album. Dedup happens in toResult.
|
||||
final query = db.select(db.cachedArtists).join([
|
||||
drift.leftOuterJoin(db.cachedAlbums,
|
||||
db.cachedAlbums.artistId.equalsExp(db.cachedArtists.id)),
|
||||
])
|
||||
..orderBy([
|
||||
drift.OrderingTerm.asc(db.cachedArtists.sortName),
|
||||
drift.OrderingTerm.asc(db.cachedAlbums.sortTitle),
|
||||
]);
|
||||
return cacheFirst<drift.TypedResult, List<ArtistRef>>(
|
||||
driftStream: query.watch(),
|
||||
fetchAndPopulate: () async {
|
||||
// Cold-cache fallback: sync should have populated drift already,
|
||||
// but a fresh install + first Library visit before sync completes
|
||||
// will be empty. Fetch a generous chunk via /api/artists and
|
||||
// persist; subsequent SWR refreshes keep things current.
|
||||
final api = await ref.read(_libraryListsApiProvider.future);
|
||||
final fresh = await api.listArtists(limit: 1000, offset: 0);
|
||||
await db.batch((b) {
|
||||
b.insertAllOnConflictUpdate(
|
||||
db.cachedArtists,
|
||||
fresh.items.map((a) => a.toDrift()).toList(),
|
||||
);
|
||||
});
|
||||
},
|
||||
toResult: (rows) {
|
||||
// The join multiplies rows by album count; dedup by artist id
|
||||
// keeping the first occurrence so we get one ArtistRef per
|
||||
// artist with the alphabetically-first album's id for the
|
||||
// cover-URL projection. Artists with no albums in drift yet
|
||||
// come through as a single row with null cachedAlbums and an
|
||||
// empty coverUrl — UI falls back to the placeholder icon.
|
||||
final seen = <String>{};
|
||||
final out = <ArtistRef>[];
|
||||
for (final r in rows) {
|
||||
final a = r.readTable(db.cachedArtists);
|
||||
if (!seen.add(a.id)) continue;
|
||||
final album = r.readTableOrNull(db.cachedAlbums);
|
||||
out.add(a.toRef(coverAlbumId: album?.id ?? ''));
|
||||
}
|
||||
return out;
|
||||
},
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
alwaysRefresh: true,
|
||||
tag: 'libraryArtists',
|
||||
);
|
||||
});
|
||||
|
||||
final _libraryAlbumsProvider = FutureProvider<wire.Paged<AlbumRef>>((ref) async {
|
||||
return (await ref.watch(_libraryListsApiProvider.future)).listAlbums();
|
||||
/// Drift-first all-albums list. Joins cached_albums with cached_artists
|
||||
/// for the artistName field. Same cold-cache fallback + SWR refresh
|
||||
/// pattern as libraryArtistsProvider.
|
||||
final _libraryAlbumsProvider = StreamProvider<List<AlbumRef>>((ref) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
final query = db.select(db.cachedAlbums).join([
|
||||
drift.leftOuterJoin(db.cachedArtists,
|
||||
db.cachedArtists.id.equalsExp(db.cachedAlbums.artistId)),
|
||||
])
|
||||
..orderBy([drift.OrderingTerm.asc(db.cachedAlbums.sortTitle)]);
|
||||
return cacheFirst<drift.TypedResult, List<AlbumRef>>(
|
||||
driftStream: query.watch(),
|
||||
fetchAndPopulate: () async {
|
||||
final api = await ref.read(_libraryListsApiProvider.future);
|
||||
final fresh = await api.listAlbums(limit: 1000, offset: 0);
|
||||
await db.batch((b) {
|
||||
b.insertAllOnConflictUpdate(
|
||||
db.cachedAlbums,
|
||||
fresh.items.map((a) => a.toDrift()).toList(),
|
||||
);
|
||||
});
|
||||
},
|
||||
toResult: (rows) => rows.map((r) {
|
||||
final album = r.readTable(db.cachedAlbums);
|
||||
final artist = r.readTableOrNull(db.cachedArtists);
|
||||
return album.toRef(artistName: artist?.name ?? '');
|
||||
}).toList(),
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
alwaysRefresh: true,
|
||||
tag: 'libraryAlbums',
|
||||
);
|
||||
});
|
||||
|
||||
final _historyProvider = FutureProvider<HistoryPage>((ref) async {
|
||||
return (await ref.watch(_meApiProvider.future)).history();
|
||||
// Drift-first History tab. Mirrors homeProvider's pattern: store the
|
||||
// last /api/me/history page as JSON in a single-row drift table, yield
|
||||
// it immediately on subscribe (so the tab paints from disk on cold
|
||||
// open), then SWR-refresh in the background. Also gives basic offline
|
||||
// scrollback — the last fetched page survives connectivity loss.
|
||||
//
|
||||
// JSON blob (vs columnar) because the page is small, always read whole,
|
||||
// and the HistoryPage.fromJson constructor already accepts the wire
|
||||
// shape — no schema-evolution pain when server-side fields change.
|
||||
final _historyProvider = StreamProvider<HistoryPage>((ref) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
return cacheFirst<CachedHistorySnapshotData, HistoryPage>(
|
||||
driftStream: db.select(db.cachedHistorySnapshot).watch(),
|
||||
fetchAndPopulate: () async {
|
||||
final api = await ref.read(_meApiProvider.future);
|
||||
final fresh = await api.history();
|
||||
await db.into(db.cachedHistorySnapshot).insertOnConflictUpdate(
|
||||
CachedHistorySnapshotCompanion.insert(
|
||||
json: _encodeHistoryPage(fresh),
|
||||
updatedAt: drift.Value(DateTime.now()),
|
||||
),
|
||||
);
|
||||
},
|
||||
toResult: (rows) => rows.isEmpty
|
||||
? const HistoryPage(events: [], hasMore: false)
|
||||
: HistoryPage.fromJson(
|
||||
jsonDecode(rows.first.json) as Map<String, dynamic>),
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
// SWR: yield cache instantly, then refresh in the background so the
|
||||
// tab reflects the freshest plays. Matches homeProvider behavior.
|
||||
alwaysRefresh: true,
|
||||
tag: 'history',
|
||||
);
|
||||
});
|
||||
|
||||
final _likedTracksProvider = FutureProvider<wire.Paged<TrackRef>>((ref) async {
|
||||
return (await ref.watch(_likesApiProvider.future)).listTracks();
|
||||
/// Encodes HistoryPage back to the wire-format JSON shape
|
||||
/// /api/me/history emits, so HistoryPage.fromJson can round-trip
|
||||
/// through the drift cache.
|
||||
String _encodeHistoryPage(HistoryPage h) => jsonEncode({
|
||||
'events': h.events
|
||||
.map((e) => {
|
||||
'id': e.id,
|
||||
'played_at': e.playedAt,
|
||||
'track': {
|
||||
'id': e.track.id,
|
||||
'title': e.track.title,
|
||||
'album_id': e.track.albumId,
|
||||
'album_title': e.track.albumTitle,
|
||||
'artist_id': e.track.artistId,
|
||||
'artist_name': e.track.artistName,
|
||||
'track_number': e.track.trackNumber,
|
||||
'disc_number': e.track.discNumber,
|
||||
'duration_sec': e.track.durationSec,
|
||||
'stream_url': e.track.streamUrl,
|
||||
},
|
||||
})
|
||||
.toList(),
|
||||
'has_more': h.hasMore,
|
||||
});
|
||||
|
||||
// Per-item Liked tabs (Slice E of the per-item rendering pass).
|
||||
// Each provider yields just the ordered list of entity IDs; the UI
|
||||
// then renders per-tile widgets that hydrate each entity individually
|
||||
// via albumTileProvider / artistTileProvider / trackTileProvider.
|
||||
//
|
||||
// Reads come from cached_likes (sync- and optimistic-write-populated),
|
||||
// projected with ORDER BY likedAt DESC. fetchAndPopulate hits the
|
||||
// cheap /api/likes/ids endpoint — the bulk /api/likes/* endpoints
|
||||
// that returned fully denormalized entities are no longer needed for
|
||||
// this path since tile providers handle entity hydration themselves.
|
||||
//
|
||||
// likedAt ordering note: cached_likes.likedAt is whatever drift
|
||||
// assigned via currentDateAndTime when the row was first inserted
|
||||
// (either by sync or LikesController). insertOrIgnore on subsequent
|
||||
// fetches preserves the existing likedAt so ordering stays stable.
|
||||
// Approximate but acceptable — matches prior Slice 3 behavior.
|
||||
|
||||
List<String> _idsForEntity(List<CachedLike> rows) =>
|
||||
rows.map((r) => r.entityId).toList(growable: false);
|
||||
|
||||
final _likedTrackIdsProvider = StreamProvider<List<String>>((ref) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
final query = (db.select(db.cachedLikes)
|
||||
..where((t) => t.entityType.equals('track'))
|
||||
..orderBy([(t) => drift.OrderingTerm.desc(t.likedAt)]))
|
||||
.watch();
|
||||
return cacheFirst<CachedLike, List<String>>(
|
||||
driftStream: query,
|
||||
fetchAndPopulate: () => _populateLikeIds(ref),
|
||||
toResult: _idsForEntity,
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
alwaysRefresh: true,
|
||||
tag: 'likedTrackIds',
|
||||
);
|
||||
});
|
||||
|
||||
final _likedAlbumsProvider = FutureProvider<wire.Paged<AlbumRef>>((ref) async {
|
||||
return (await ref.watch(_likesApiProvider.future)).listAlbums();
|
||||
final _likedAlbumIdsProvider = StreamProvider<List<String>>((ref) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
final query = (db.select(db.cachedLikes)
|
||||
..where((t) => t.entityType.equals('album'))
|
||||
..orderBy([(t) => drift.OrderingTerm.desc(t.likedAt)]))
|
||||
.watch();
|
||||
return cacheFirst<CachedLike, List<String>>(
|
||||
driftStream: query,
|
||||
fetchAndPopulate: () => _populateLikeIds(ref),
|
||||
toResult: _idsForEntity,
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
alwaysRefresh: true,
|
||||
tag: 'likedAlbumIds',
|
||||
);
|
||||
});
|
||||
|
||||
final _likedArtistsProvider = FutureProvider<wire.Paged<ArtistRef>>((ref) async {
|
||||
return (await ref.watch(_likesApiProvider.future)).listArtists();
|
||||
final _likedArtistIdsProvider = StreamProvider<List<String>>((ref) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
final query = (db.select(db.cachedLikes)
|
||||
..where((t) => t.entityType.equals('artist'))
|
||||
..orderBy([(t) => drift.OrderingTerm.desc(t.likedAt)]))
|
||||
.watch();
|
||||
return cacheFirst<CachedLike, List<String>>(
|
||||
driftStream: query,
|
||||
fetchAndPopulate: () => _populateLikeIds(ref),
|
||||
toResult: _idsForEntity,
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
alwaysRefresh: true,
|
||||
tag: 'likedArtistIds',
|
||||
);
|
||||
});
|
||||
|
||||
final _quarantineProvider = FutureProvider<List<QuarantineMineRow>>((ref) async {
|
||||
return (await ref.watch(_meApiProvider.future)).quarantineMine();
|
||||
});
|
||||
/// Shared cold-cache populator: hits /api/likes/ids once and writes
|
||||
/// rows for all three entity types via insertOrIgnore. The three
|
||||
/// providers above all trigger this on their first empty-drift
|
||||
/// emission; the dedup in cacheFirst's revalidate state plus drift's
|
||||
/// insertOrIgnore semantics make the multiple-trigger case cheap.
|
||||
Future<void> _populateLikeIds(Ref ref) async {
|
||||
final api = await ref.read(_likesApiProvider.future);
|
||||
final user = ref.read(authControllerProvider).value;
|
||||
if (user == null) return;
|
||||
final fresh = await api.ids();
|
||||
final db = ref.read(appDbProvider);
|
||||
await db.batch((b) {
|
||||
for (final id in fresh.tracks) {
|
||||
b.insert(
|
||||
db.cachedLikes,
|
||||
CachedLikesCompanion.insert(
|
||||
userId: user.id,
|
||||
entityType: 'track',
|
||||
entityId: id,
|
||||
),
|
||||
mode: drift.InsertMode.insertOrIgnore,
|
||||
);
|
||||
}
|
||||
for (final id in fresh.albums) {
|
||||
b.insert(
|
||||
db.cachedLikes,
|
||||
CachedLikesCompanion.insert(
|
||||
userId: user.id,
|
||||
entityType: 'album',
|
||||
entityId: id,
|
||||
),
|
||||
mode: drift.InsertMode.insertOrIgnore,
|
||||
);
|
||||
}
|
||||
for (final id in fresh.artists) {
|
||||
b.insert(
|
||||
db.cachedLikes,
|
||||
CachedLikesCompanion.insert(
|
||||
userId: user.id,
|
||||
entityType: 'artist',
|
||||
entityId: id,
|
||||
),
|
||||
mode: drift.InsertMode.insertOrIgnore,
|
||||
);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
// Hidden tab uses the canonical `myQuarantineProvider` (AsyncNotifier with
|
||||
// optimistic flag/unflag) so flagging from any kebab and unflagging from
|
||||
// the Hidden tab keep one source of truth.
|
||||
|
||||
class LibraryScreen extends ConsumerStatefulWidget {
|
||||
const LibraryScreen({super.key});
|
||||
@@ -85,6 +358,19 @@ class _LibraryScreenState extends ConsumerState<LibraryScreen>
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
// Pre-warm every tab's provider on Library mount so swiping
|
||||
// between tabs feels instant rather than each tab paying its
|
||||
// own cold-cache cost on first visit. ref.listen subscribes
|
||||
// without rebuilding LibraryScreen on emit; subscriptions stay
|
||||
// alive for the lifetime of this widget. cacheFirst handles
|
||||
// dedupe of concurrent fetchAndPopulate triggers.
|
||||
ref.listen(_libraryArtistsProvider, (_, __) {});
|
||||
ref.listen(_libraryAlbumsProvider, (_, __) {});
|
||||
ref.listen(_historyProvider, (_, __) {});
|
||||
ref.listen(_likedTrackIdsProvider, (_, __) {});
|
||||
ref.listen(_likedAlbumIdsProvider, (_, __) {});
|
||||
ref.listen(_likedArtistIdsProvider, (_, __) {});
|
||||
ref.listen(myQuarantineProvider, (_, __) {});
|
||||
return Scaffold(
|
||||
backgroundColor: fs.obsidian,
|
||||
appBar: AppBar(
|
||||
@@ -131,29 +417,58 @@ class _ArtistsTab extends ConsumerWidget {
|
||||
return ref.watch(_libraryArtistsProvider).when(
|
||||
loading: () => const Center(child: CircularProgressIndicator()),
|
||||
error: (e, _) => Center(child: Text('$e', style: TextStyle(color: fs.error))),
|
||||
data: (page) => page.items.isEmpty
|
||||
data: (artists) {
|
||||
// Warm details for the first screenful so taps are instant.
|
||||
ref
|
||||
.read(metadataPrefetcherProvider)
|
||||
.warmArtists(artists.map((a) => a.id));
|
||||
return artists.isEmpty
|
||||
? Center(child: Text("No artists yet — scan a library folder via the server's config.", style: TextStyle(color: fs.ash), textAlign: TextAlign.center))
|
||||
: RefreshIndicator(
|
||||
onRefresh: () async => ref.refresh(_libraryArtistsProvider.future),
|
||||
child: GridView.builder(
|
||||
padding: const EdgeInsets.all(8),
|
||||
gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(
|
||||
crossAxisCount: 3,
|
||||
mainAxisSpacing: 8,
|
||||
crossAxisSpacing: 8,
|
||||
childAspectRatio: 0.78,
|
||||
),
|
||||
itemCount: page.items.length,
|
||||
itemBuilder: (ctx, i) {
|
||||
final artist = page.items[i];
|
||||
return ArtistCard(
|
||||
artist: artist,
|
||||
onTap: () => ctx.push('/artists/${artist.id}',
|
||||
extra: artist),
|
||||
);
|
||||
},
|
||||
),
|
||||
),
|
||||
// LayoutBuilder + cell-aware ArtistCard width mirrors
|
||||
// the AlbumsTab pattern so the circular avatar stays
|
||||
// a true circle on narrow grid cells.
|
||||
//
|
||||
// Drift-first: GridView holds the full sorted list;
|
||||
// .builder lazily realizes only visible cells, so
|
||||
// even on large libraries the up-front cost is just
|
||||
// a sort over cached_artists, not N network round
|
||||
// trips.
|
||||
child: LayoutBuilder(builder: (ctx, constraints) {
|
||||
const cols = 3;
|
||||
const sidePad = 8.0;
|
||||
const gap = 8.0;
|
||||
final cellW = (constraints.maxWidth -
|
||||
sidePad * 2 -
|
||||
gap * (cols - 1)) /
|
||||
cols;
|
||||
// avatar (cellW - 16) + gap (8) + 1 line name (~18)
|
||||
// + slack matched to AlbumsTab's overflow guard.
|
||||
final cellH = (cellW - 16) + 8 + 18 + 8;
|
||||
return GridView.builder(
|
||||
padding: const EdgeInsets.all(sidePad),
|
||||
gridDelegate:
|
||||
SliverGridDelegateWithFixedCrossAxisCount(
|
||||
crossAxisCount: cols,
|
||||
mainAxisExtent: cellH,
|
||||
mainAxisSpacing: gap,
|
||||
crossAxisSpacing: gap,
|
||||
),
|
||||
itemCount: artists.length,
|
||||
itemBuilder: (ctx, i) {
|
||||
final artist = artists[i];
|
||||
return ArtistCard(
|
||||
artist: artist,
|
||||
width: cellW,
|
||||
onTap: () => ctx.push('/artists/${artist.id}',
|
||||
extra: artist),
|
||||
);
|
||||
},
|
||||
);
|
||||
}),
|
||||
);
|
||||
},
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -167,13 +482,16 @@ class _AlbumsTab extends ConsumerWidget {
|
||||
return ref.watch(_libraryAlbumsProvider).when(
|
||||
loading: () => const Center(child: CircularProgressIndicator()),
|
||||
error: (e, _) => Center(child: Text('$e', style: TextStyle(color: fs.error))),
|
||||
data: (page) => page.items.isEmpty
|
||||
data: (albums) {
|
||||
return albums.isEmpty
|
||||
? Center(child: Text("No albums yet — scan a library folder via the server's config.", style: TextStyle(color: fs.ash), textAlign: TextAlign.center))
|
||||
: RefreshIndicator(
|
||||
onRefresh: () async => ref.refresh(_libraryAlbumsProvider.future),
|
||||
// Same responsive 3-up grid as the artist detail
|
||||
// album list — LayoutBuilder + AlbumCard sized to the
|
||||
// cell, mainAxisExtent matched to actual card height.
|
||||
// Drift-first; full sorted list, lazy realization via
|
||||
// GridView.builder.
|
||||
child: LayoutBuilder(builder: (ctx, constraints) {
|
||||
const cols = 3;
|
||||
const sidePad = 8.0;
|
||||
@@ -183,19 +501,23 @@ class _AlbumsTab extends ConsumerWidget {
|
||||
gap * (cols - 1)) /
|
||||
cols;
|
||||
// cover (cellW - 16) + gap (8) + 2-line title (~36)
|
||||
// + artist line (~16) + small fudge.
|
||||
final cellH = (cellW - 16) + 8 + 36 + 16 + 4;
|
||||
// + artist line (~16) + slack. Slack is generous on
|
||||
// purpose — line-height + font scaling variations
|
||||
// would otherwise overflow the cell by a pixel
|
||||
// (logged as a noisy RenderFlex warning).
|
||||
final cellH = (cellW - 16) + 8 + 36 + 16 + 8;
|
||||
return GridView.builder(
|
||||
padding: const EdgeInsets.all(sidePad),
|
||||
gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
|
||||
gridDelegate:
|
||||
SliverGridDelegateWithFixedCrossAxisCount(
|
||||
crossAxisCount: cols,
|
||||
mainAxisExtent: cellH,
|
||||
mainAxisSpacing: gap,
|
||||
crossAxisSpacing: gap,
|
||||
),
|
||||
itemCount: page.items.length,
|
||||
itemCount: albums.length,
|
||||
itemBuilder: (ctx, i) {
|
||||
final album = page.items[i];
|
||||
final album = albums[i];
|
||||
return AlbumCard(
|
||||
album: album,
|
||||
width: cellW,
|
||||
@@ -206,7 +528,8 @@ class _AlbumsTab extends ConsumerWidget {
|
||||
},
|
||||
);
|
||||
}),
|
||||
),
|
||||
);
|
||||
},
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -252,79 +575,82 @@ class _LikedTab extends ConsumerWidget {
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final tracksA = ref.watch(_likedTracksProvider);
|
||||
final albumsA = ref.watch(_likedAlbumsProvider);
|
||||
final artistsA = ref.watch(_likedArtistsProvider);
|
||||
// SSE wire-up: any cross-device like / unlike triggers a refresh
|
||||
// of the discovery providers. LikesController handles local
|
||||
// mutations optimistically through the same cached_likes table,
|
||||
// so toggling a like locally re-emits the streams instantly
|
||||
// without needing an invalidate here.
|
||||
ref.listen<AsyncValue<LiveEvent>>(liveEventsProvider, (_, next) {
|
||||
final e = next.asData?.value;
|
||||
if (e == null) return;
|
||||
switch (e.kind) {
|
||||
case 'track.liked':
|
||||
case 'track.unliked':
|
||||
case 'album.liked':
|
||||
case 'album.unliked':
|
||||
case 'artist.liked':
|
||||
case 'artist.unliked':
|
||||
ref.invalidate(_likedTrackIdsProvider);
|
||||
ref.invalidate(_likedAlbumIdsProvider);
|
||||
ref.invalidate(_likedArtistIdsProvider);
|
||||
}
|
||||
});
|
||||
final tracksA = ref.watch(_likedTrackIdsProvider);
|
||||
final albumsA = ref.watch(_likedAlbumIdsProvider);
|
||||
final artistsA = ref.watch(_likedArtistIdsProvider);
|
||||
|
||||
if (tracksA.isLoading || albumsA.isLoading || artistsA.isLoading) {
|
||||
return const Center(child: CircularProgressIndicator());
|
||||
}
|
||||
final t = tracksA.value;
|
||||
final al = albumsA.value;
|
||||
final ar = artistsA.value;
|
||||
if (t == null || al == null || ar == null) {
|
||||
final trackIds = tracksA.value;
|
||||
final albumIds = albumsA.value;
|
||||
final artistIds = artistsA.value;
|
||||
if (trackIds == null || albumIds == null || artistIds == null) {
|
||||
return Center(child: Text("Couldn't load liked items.", style: TextStyle(color: fs.error)));
|
||||
}
|
||||
if (t.items.isEmpty && al.items.isEmpty && ar.items.isEmpty) {
|
||||
if (trackIds.isEmpty && albumIds.isEmpty && artistIds.isEmpty) {
|
||||
return Center(child: Text('No liked artists, albums, or tracks yet.', style: TextStyle(color: fs.ash), textAlign: TextAlign.center));
|
||||
}
|
||||
return RefreshIndicator(
|
||||
onRefresh: () async {
|
||||
await Future.wait([
|
||||
ref.refresh(_likedTracksProvider.future),
|
||||
ref.refresh(_likedAlbumsProvider.future),
|
||||
ref.refresh(_likedArtistsProvider.future),
|
||||
ref.refresh(_likedTrackIdsProvider.future),
|
||||
ref.refresh(_likedAlbumIdsProvider.future),
|
||||
ref.refresh(_likedArtistIdsProvider.future),
|
||||
]);
|
||||
},
|
||||
child: ListView(children: [
|
||||
if (ar.items.isNotEmpty) ...[
|
||||
_SectionHeader(label: 'Artists', count: ar.total),
|
||||
if (artistIds.isNotEmpty) ...[
|
||||
_SectionHeader(label: 'Artists', count: artistIds.length),
|
||||
SizedBox(
|
||||
height: 168,
|
||||
child: ListView.builder(
|
||||
scrollDirection: Axis.horizontal,
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8),
|
||||
itemCount: ar.items.length,
|
||||
itemBuilder: (ctx, i) {
|
||||
final artist = ar.items[i];
|
||||
return ArtistCard(
|
||||
artist: artist,
|
||||
onTap: () =>
|
||||
ctx.push('/artists/${artist.id}', extra: artist),
|
||||
);
|
||||
},
|
||||
itemCount: artistIds.length,
|
||||
itemBuilder: (ctx, i) =>
|
||||
_LikedArtistTile(id: artistIds[i]),
|
||||
),
|
||||
),
|
||||
],
|
||||
if (al.items.isNotEmpty) ...[
|
||||
_SectionHeader(label: 'Albums', count: al.total),
|
||||
if (albumIds.isNotEmpty) ...[
|
||||
_SectionHeader(label: 'Albums', count: albumIds.length),
|
||||
SizedBox(
|
||||
height: 200,
|
||||
child: ListView.builder(
|
||||
scrollDirection: Axis.horizontal,
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8),
|
||||
itemCount: al.items.length,
|
||||
itemBuilder: (ctx, i) {
|
||||
final album = al.items[i];
|
||||
return AlbumCard(
|
||||
album: album,
|
||||
onTap: () =>
|
||||
ctx.push('/albums/${album.id}', extra: album),
|
||||
);
|
||||
},
|
||||
itemCount: albumIds.length,
|
||||
itemBuilder: (ctx, i) =>
|
||||
_LikedAlbumTile(id: albumIds[i]),
|
||||
),
|
||||
),
|
||||
],
|
||||
if (t.items.isNotEmpty) ...[
|
||||
_SectionHeader(label: 'Tracks', count: t.total),
|
||||
...t.items.asMap().entries.map((e) {
|
||||
return TrackRow(
|
||||
track: e.value,
|
||||
onTap: () => ref
|
||||
.read(playerActionsProvider)
|
||||
.playTracks(t.items, initialIndex: e.key),
|
||||
);
|
||||
}),
|
||||
if (trackIds.isNotEmpty) ...[
|
||||
_SectionHeader(label: 'Tracks', count: trackIds.length),
|
||||
...trackIds.map(
|
||||
(id) => _LikedTrackRow(id: id, sectionIds: trackIds),
|
||||
),
|
||||
],
|
||||
const SizedBox(height: 96),
|
||||
]),
|
||||
@@ -332,13 +658,102 @@ class _LikedTab extends ConsumerWidget {
|
||||
}
|
||||
}
|
||||
|
||||
/// Skeleton→content cross-fade duration. Matches home_screen so the
|
||||
/// reveal feel is consistent across surfaces. See _tileRevealDuration
|
||||
/// in home_screen.dart for the rationale.
|
||||
const Duration _likedTileReveal = Duration(milliseconds: 220);
|
||||
|
||||
/// Liked-Artists carousel tile. Skeleton until artistTileProvider
|
||||
/// yields a populated row.
|
||||
class _LikedArtistTile extends ConsumerWidget {
|
||||
const _LikedArtistTile({required this.id});
|
||||
final String id;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final artist = ref.watch(artistTileProvider(id)).asData?.value;
|
||||
return AnimatedSwitcher(
|
||||
duration: _likedTileReveal,
|
||||
switchInCurve: Curves.easeOut,
|
||||
child: artist == null
|
||||
? const SkeletonArtistTile(key: ValueKey('skeleton'))
|
||||
: ArtistCard(
|
||||
key: ValueKey('artist-${artist.id}'),
|
||||
artist: artist,
|
||||
onTap: () =>
|
||||
context.push('/artists/${artist.id}', extra: artist),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Liked-Albums carousel tile. Skeleton until albumTileProvider
|
||||
/// yields a populated row.
|
||||
class _LikedAlbumTile extends ConsumerWidget {
|
||||
const _LikedAlbumTile({required this.id});
|
||||
final String id;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final album = ref.watch(albumTileProvider(id)).asData?.value;
|
||||
return AnimatedSwitcher(
|
||||
duration: _likedTileReveal,
|
||||
switchInCurve: Curves.easeOut,
|
||||
child: album == null
|
||||
? const SkeletonAlbumTile(key: ValueKey('skeleton'))
|
||||
: AlbumCard(
|
||||
key: ValueKey('album-${album.id}'),
|
||||
album: album,
|
||||
onTap: () => context.push('/albums/${album.id}', extra: album),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Liked-Tracks list row. Skeleton until trackTileProvider yields a
|
||||
/// populated row. Tap plays the section starting at this track,
|
||||
/// using whichever tracks are currently hydrated; still-loading
|
||||
/// tracks are skipped from the play queue and join on next rebuild.
|
||||
class _LikedTrackRow extends ConsumerWidget {
|
||||
const _LikedTrackRow({required this.id, required this.sectionIds});
|
||||
final String id;
|
||||
final List<String> sectionIds;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final track = ref.watch(trackTileProvider(id)).asData?.value;
|
||||
return AnimatedSwitcher(
|
||||
duration: _likedTileReveal,
|
||||
switchInCurve: Curves.easeOut,
|
||||
child: track == null
|
||||
? const SkeletonTrackRow(key: ValueKey('skeleton'))
|
||||
: TrackRow(
|
||||
key: ValueKey('track-${track.id}'),
|
||||
track: track,
|
||||
onTap: () {
|
||||
final hydrated = <TrackRef>[];
|
||||
for (final i in sectionIds) {
|
||||
final v = ref.read(trackTileProvider(i)).asData?.value;
|
||||
if (v != null) hydrated.add(v);
|
||||
}
|
||||
final start = hydrated.indexWhere((t) => t.id == id);
|
||||
ref.read(playerActionsProvider).playTracks(
|
||||
hydrated,
|
||||
initialIndex: start < 0 ? 0 : start,
|
||||
);
|
||||
},
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
class _HiddenTab extends ConsumerWidget {
|
||||
const _HiddenTab();
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
return ref.watch(_quarantineProvider).when(
|
||||
return ref.watch(myQuarantineProvider).when(
|
||||
loading: () => const Center(child: CircularProgressIndicator()),
|
||||
error: (e, _) => Center(child: Text('$e', style: TextStyle(color: fs.error))),
|
||||
data: (rows) => rows.isEmpty
|
||||
@@ -350,7 +765,7 @@ class _HiddenTab extends ConsumerWidget {
|
||||
),
|
||||
)
|
||||
: RefreshIndicator(
|
||||
onRefresh: () async => ref.refresh(_quarantineProvider.future),
|
||||
onRefresh: () async => ref.refresh(myQuarantineProvider.future),
|
||||
child: ListView.separated(
|
||||
itemCount: rows.length,
|
||||
separatorBuilder: (_, __) => Divider(height: 1, color: fs.iron),
|
||||
@@ -361,12 +776,12 @@ class _HiddenTab extends ConsumerWidget {
|
||||
}
|
||||
}
|
||||
|
||||
class _QuarantineTile extends StatelessWidget {
|
||||
class _QuarantineTile extends ConsumerWidget {
|
||||
const _QuarantineTile({required this.row});
|
||||
final QuarantineMineRow row;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final reasonLabel = switch (row.reason) {
|
||||
'bad_rip' => 'Bad rip',
|
||||
@@ -375,9 +790,25 @@ class _QuarantineTile extends StatelessWidget {
|
||||
'duplicate' => 'Duplicate',
|
||||
_ => 'Other',
|
||||
};
|
||||
final coverUrl = row.albumId.isNotEmpty ? '/api/albums/${row.albumId}/cover' : '';
|
||||
return Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 10),
|
||||
child: Row(crossAxisAlignment: CrossAxisAlignment.start, children: [
|
||||
ClipRRect(
|
||||
borderRadius: BorderRadius.circular(4),
|
||||
child: SizedBox(
|
||||
width: 56,
|
||||
height: 56,
|
||||
child: coverUrl.isEmpty
|
||||
? Container(color: fs.slate)
|
||||
: ServerImage(
|
||||
url: coverUrl,
|
||||
fit: BoxFit.cover,
|
||||
fallback: Container(color: fs.slate),
|
||||
),
|
||||
),
|
||||
),
|
||||
const SizedBox(width: 12),
|
||||
Expanded(
|
||||
child: Column(crossAxisAlignment: CrossAxisAlignment.start, children: [
|
||||
Text(
|
||||
@@ -394,17 +825,41 @@ class _QuarantineTile extends StatelessWidget {
|
||||
),
|
||||
Padding(
|
||||
padding: const EdgeInsets.only(top: 4),
|
||||
child: Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 6, vertical: 2),
|
||||
decoration: BoxDecoration(
|
||||
color: fs.iron,
|
||||
borderRadius: BorderRadius.circular(4),
|
||||
child: Row(children: [
|
||||
Container(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 6, vertical: 2),
|
||||
decoration: BoxDecoration(
|
||||
color: fs.iron,
|
||||
borderRadius: BorderRadius.circular(4),
|
||||
),
|
||||
child: Text(reasonLabel, style: TextStyle(color: fs.ash, fontSize: 11)),
|
||||
),
|
||||
child: Text(reasonLabel, style: TextStyle(color: fs.ash, fontSize: 11)),
|
||||
),
|
||||
if (row.createdAt.isNotEmpty) ...[
|
||||
const SizedBox(width: 8),
|
||||
Text(_relativeTime(row.createdAt),
|
||||
style: TextStyle(color: fs.ash, fontSize: 11)),
|
||||
],
|
||||
]),
|
||||
),
|
||||
]),
|
||||
),
|
||||
IconButton(
|
||||
tooltip: 'Unhide',
|
||||
icon: Icon(Icons.restore, color: fs.ash, size: 20),
|
||||
onPressed: () async {
|
||||
try {
|
||||
await ref.read(myQuarantineProvider.notifier).unflag(row.trackId);
|
||||
} catch (_) {
|
||||
// Optimistic rollback handled by the notifier; surface
|
||||
// the failure only if the user kept the tab open.
|
||||
if (context.mounted) {
|
||||
ScaffoldMessenger.of(context).showSnackBar(
|
||||
const SnackBar(content: Text('Could not unhide; try again.')),
|
||||
);
|
||||
}
|
||||
}
|
||||
},
|
||||
),
|
||||
]),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1,11 +1,15 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:flutter_svg/flutter_svg.dart';
|
||||
|
||||
import '../../models/album.dart';
|
||||
import '../../player/player_provider.dart';
|
||||
import '../../shared/widgets/server_image.dart';
|
||||
import '../../theme/theme_extension.dart';
|
||||
import '../library_providers.dart';
|
||||
import 'play_circle_button.dart';
|
||||
|
||||
class AlbumCard extends StatelessWidget {
|
||||
class AlbumCard extends ConsumerWidget {
|
||||
const AlbumCard({
|
||||
required this.album,
|
||||
required this.onTap,
|
||||
@@ -32,7 +36,7 @@ class AlbumCard extends StatelessWidget {
|
||||
final bool showArtist;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final coverSize = width - 16;
|
||||
return SizedBox(
|
||||
@@ -47,17 +51,29 @@ class AlbumCard extends StatelessWidget {
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
ClipRRect(
|
||||
borderRadius: BorderRadius.circular(6),
|
||||
child: Container(
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
color: fs.slate,
|
||||
child: album.coverUrl.isEmpty
|
||||
? SvgPicture.asset('assets/svg/album-fallback.svg',
|
||||
fit: BoxFit.cover)
|
||||
: ServerImage(url: album.coverUrl, fit: BoxFit.cover),
|
||||
),
|
||||
// Stack: cover image + overlaid play button at bottom-right.
|
||||
Stack(
|
||||
children: [
|
||||
ClipRRect(
|
||||
borderRadius: BorderRadius.circular(6),
|
||||
child: Container(
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
color: fs.slate,
|
||||
child: album.coverUrl.isEmpty
|
||||
? SvgPicture.asset('assets/svg/album-fallback.svg',
|
||||
fit: BoxFit.cover)
|
||||
: ServerImage(url: album.coverUrl, fit: BoxFit.cover),
|
||||
),
|
||||
),
|
||||
Positioned(
|
||||
bottom: 6,
|
||||
right: 6,
|
||||
child: PlayCircleButton(
|
||||
onPressed: () => _playAlbum(ref),
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
const SizedBox(height: 8),
|
||||
Text(
|
||||
@@ -80,4 +96,17 @@ class AlbumCard extends StatelessWidget {
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Fetches the album's tracks via /api/albums/{id} and starts playback
|
||||
/// from the first track. Errors are swallowed by the button's outer
|
||||
/// try/finally; callers don't surface them — failed fetches just keep
|
||||
/// the spinner visible until the button is retapped.
|
||||
Future<void> _playAlbum(WidgetRef ref) async {
|
||||
final api = await ref.read(libraryApiProvider.future);
|
||||
final result = await api.getAlbum(album.id);
|
||||
if (result.tracks.isEmpty) return;
|
||||
await ref
|
||||
.read(playerActionsProvider)
|
||||
.playTracks(result.tracks, initialIndex: 0);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,20 +1,38 @@
|
||||
import 'dart:math';
|
||||
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:flutter_svg/flutter_svg.dart';
|
||||
|
||||
import '../../models/artist.dart';
|
||||
import '../../player/player_provider.dart';
|
||||
import '../../shared/widgets/server_image.dart';
|
||||
import '../../theme/theme_extension.dart';
|
||||
import '../library_providers.dart';
|
||||
import 'play_circle_button.dart';
|
||||
|
||||
class ArtistCard extends StatelessWidget {
|
||||
const ArtistCard({required this.artist, required this.onTap, super.key});
|
||||
class ArtistCard extends ConsumerWidget {
|
||||
const ArtistCard({
|
||||
required this.artist,
|
||||
required this.onTap,
|
||||
this.width = 140,
|
||||
super.key,
|
||||
});
|
||||
final ArtistRef artist;
|
||||
final VoidCallback onTap;
|
||||
|
||||
/// Outer width of the card. Avatar is a circle of width-16 (8dp
|
||||
/// horizontal padding either side). Default suits horizontal lists;
|
||||
/// grids should pass the cell width so the avatar shrinks
|
||||
/// proportionally and stays a true circle.
|
||||
final double width;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final coverSize = width - 16;
|
||||
return SizedBox(
|
||||
width: 140,
|
||||
width: width,
|
||||
child: Material(
|
||||
color: Colors.transparent,
|
||||
child: InkWell(
|
||||
@@ -22,16 +40,36 @@ class ArtistCard extends StatelessWidget {
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8),
|
||||
child: Column(crossAxisAlignment: CrossAxisAlignment.start, children: [
|
||||
ClipOval(
|
||||
child: Container(
|
||||
width: 124,
|
||||
height: 124,
|
||||
color: fs.slate,
|
||||
child: artist.coverUrl.isEmpty
|
||||
? SvgPicture.asset('assets/svg/album-fallback.svg',
|
||||
fit: BoxFit.cover)
|
||||
: ServerImage(url: artist.coverUrl, fit: BoxFit.cover),
|
||||
),
|
||||
// Stack: circular avatar + overlaid play button at bottom-right.
|
||||
// Avatar size derives from the [width] parameter so the
|
||||
// Library Artists 3-column grid can pass its cell width
|
||||
// (~109dp on typical phones) and the avatar stays a
|
||||
// perfect circle. Previous hardcoded 124×124 got squeezed
|
||||
// horizontally in the grid (cell narrower than 124+16
|
||||
// padding) but kept its 124dp height — ClipOval produced
|
||||
// a visible vertical ellipse. Mirrors AlbumCard's width-
|
||||
// parameter convention.
|
||||
Stack(
|
||||
children: [
|
||||
ClipOval(
|
||||
child: Container(
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
color: fs.slate,
|
||||
child: artist.coverUrl.isEmpty
|
||||
? SvgPicture.asset('assets/svg/album-fallback.svg',
|
||||
fit: BoxFit.cover)
|
||||
: ServerImage(url: artist.coverUrl, fit: BoxFit.cover),
|
||||
),
|
||||
),
|
||||
Positioned(
|
||||
bottom: 4,
|
||||
right: 4,
|
||||
child: PlayCircleButton(
|
||||
onPressed: () => _playArtistShuffle(ref),
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
const SizedBox(height: 8),
|
||||
Text(
|
||||
@@ -46,4 +84,18 @@ class ArtistCard extends StatelessWidget {
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Fetches the artist's tracks via /api/artists/{id}/tracks, shuffles
|
||||
/// them (Fisher-Yates, default Random), and plays from index 0.
|
||||
/// Matches the web ArtistCard's `playQueue(shuffle(tracks), 0)`.
|
||||
Future<void> _playArtistShuffle(WidgetRef ref) async {
|
||||
final api = await ref.read(libraryApiProvider.future);
|
||||
final tracks = await api.getArtistTracks(artist.id);
|
||||
if (tracks.isEmpty) return;
|
||||
final shuffled = List.of(tracks);
|
||||
shuffled.shuffle(Random());
|
||||
await ref
|
||||
.read(playerActionsProvider)
|
||||
.playTracks(shuffled, initialIndex: 0);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,96 @@
|
||||
import 'package:flutter/material.dart';
|
||||
|
||||
import '../../theme/theme_extension.dart';
|
||||
|
||||
/// Always-visible 44dp circular play button overlaid on home-screen
|
||||
/// card art (AlbumCard / ArtistCard / PlaylistCard). Mirrors the
|
||||
/// hover-revealed `.play-overlay` on the web cards, but always shown
|
||||
/// because hover is not a real interaction on touch.
|
||||
///
|
||||
/// Manages its own loading state via [_starting] so the caller's tap
|
||||
/// handler can be `Future<void> Function()` without worrying about
|
||||
/// re-entrancy. Disabled state suppresses the tap (used for empty
|
||||
/// playlists).
|
||||
class PlayCircleButton extends StatefulWidget {
|
||||
const PlayCircleButton({
|
||||
required this.onPressed,
|
||||
this.enabled = true,
|
||||
this.size = 44,
|
||||
super.key,
|
||||
});
|
||||
|
||||
/// Tap handler. Returns a Future so the button can show a spinner
|
||||
/// during the play setup (fetch detail tracks, etc.).
|
||||
final Future<void> Function() onPressed;
|
||||
|
||||
/// When false, the button is rendered semi-transparent and taps are
|
||||
/// ignored. Empty playlists / artists with no tracks should disable.
|
||||
final bool enabled;
|
||||
|
||||
/// Outer diameter in logical pixels. 44 is the iOS / Android
|
||||
/// touch-target minimum; matches the design doc.
|
||||
final double size;
|
||||
|
||||
@override
|
||||
State<PlayCircleButton> createState() => _PlayCircleButtonState();
|
||||
}
|
||||
|
||||
class _PlayCircleButtonState extends State<PlayCircleButton> {
|
||||
bool _starting = false;
|
||||
|
||||
Future<void> _handleTap() async {
|
||||
if (_starting || !widget.enabled) return;
|
||||
setState(() => _starting = true);
|
||||
try {
|
||||
await widget.onPressed();
|
||||
} finally {
|
||||
if (mounted) setState(() => _starting = false);
|
||||
}
|
||||
}
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final iconSize = widget.size * 0.5;
|
||||
return Material(
|
||||
color: Colors.transparent,
|
||||
shape: const CircleBorder(),
|
||||
child: InkResponse(
|
||||
onTap: widget.enabled ? _handleTap : null,
|
||||
radius: widget.size / 2,
|
||||
containedInkWell: true,
|
||||
customBorder: const CircleBorder(),
|
||||
child: Container(
|
||||
width: widget.size,
|
||||
height: widget.size,
|
||||
decoration: BoxDecoration(
|
||||
color: fs.accent.withValues(alpha: widget.enabled ? 1.0 : 0.5),
|
||||
shape: BoxShape.circle,
|
||||
boxShadow: const [
|
||||
BoxShadow(
|
||||
color: Color(0x66000000),
|
||||
blurRadius: 6,
|
||||
offset: Offset(0, 2),
|
||||
),
|
||||
],
|
||||
),
|
||||
alignment: Alignment.center,
|
||||
child: _starting
|
||||
? SizedBox(
|
||||
width: iconSize,
|
||||
height: iconSize,
|
||||
child: CircularProgressIndicator(
|
||||
strokeWidth: 2,
|
||||
valueColor: AlwaysStoppedAnimation<Color>(fs.parchment),
|
||||
),
|
||||
)
|
||||
: Icon(
|
||||
Icons.play_arrow,
|
||||
color: fs.parchment,
|
||||
size: iconSize,
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -1,11 +1,13 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../../models/track.dart';
|
||||
import '../../player/player_provider.dart';
|
||||
import '../../shared/widgets/track_actions/track_actions_button.dart';
|
||||
import '../../theme/theme_extension.dart';
|
||||
import 'cached_indicator.dart';
|
||||
|
||||
class TrackRow extends StatelessWidget {
|
||||
class TrackRow extends ConsumerWidget {
|
||||
const TrackRow({
|
||||
required this.track,
|
||||
required this.onTap,
|
||||
@@ -23,56 +25,75 @@ class TrackRow extends StatelessWidget {
|
||||
final bool actions;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final mins = (track.durationSec ~/ 60).toString().padLeft(2, '0');
|
||||
final secs = (track.durationSec % 60).toString().padLeft(2, '0');
|
||||
return InkWell(
|
||||
onTap: onTap,
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 6),
|
||||
child: Row(children: [
|
||||
if (track.trackNumber != null)
|
||||
SizedBox(
|
||||
width: 22,
|
||||
child: Text(
|
||||
track.trackNumber.toString(),
|
||||
style: TextStyle(color: fs.ash, fontSize: 13),
|
||||
),
|
||||
),
|
||||
Expanded(
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Text(
|
||||
track.title,
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
style: TextStyle(color: fs.parchment, fontSize: 14),
|
||||
// Watch the currently-playing media item so the row's accent
|
||||
// highlight tracks playback state. Matches _QueueRow's visual
|
||||
// treatment in queue_screen.dart so the "you are here" cue is
|
||||
// consistent across album / playlist / queue surfaces.
|
||||
final currentId = ref.watch(mediaItemProvider).value?.id;
|
||||
final isCurrent = currentId != null && currentId == track.id;
|
||||
return Container(
|
||||
decoration: BoxDecoration(
|
||||
color: isCurrent ? fs.iron : null,
|
||||
border: isCurrent
|
||||
? Border(left: BorderSide(color: fs.accent, width: 2))
|
||||
: null,
|
||||
),
|
||||
child: InkWell(
|
||||
onTap: onTap,
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 6),
|
||||
child: Row(children: [
|
||||
if (track.trackNumber != null)
|
||||
SizedBox(
|
||||
width: 22,
|
||||
child: Text(
|
||||
track.trackNumber.toString(),
|
||||
style: TextStyle(color: fs.ash, fontSize: 13),
|
||||
),
|
||||
// Skip the artist line entirely when empty so the row
|
||||
// height collapses to a single line of title — keeps
|
||||
// dense album views from looking padded.
|
||||
if (track.artistName.isNotEmpty)
|
||||
),
|
||||
Expanded(
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Text(
|
||||
track.artistName,
|
||||
track.title,
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
style: TextStyle(color: fs.ash, fontSize: 12),
|
||||
style: TextStyle(
|
||||
color: isCurrent ? fs.accent : fs.parchment,
|
||||
fontSize: 14,
|
||||
fontWeight:
|
||||
isCurrent ? FontWeight.w500 : FontWeight.w400,
|
||||
),
|
||||
),
|
||||
],
|
||||
// Skip the artist line entirely when empty so the row
|
||||
// height collapses to a single line of title — keeps
|
||||
// dense album views from looking padded.
|
||||
if (track.artistName.isNotEmpty)
|
||||
Text(
|
||||
track.artistName,
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
style: TextStyle(color: fs.ash, fontSize: 12),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
CachedIndicator(trackId: track.id),
|
||||
Text('$mins:$secs', style: TextStyle(color: fs.ash, fontSize: 12)),
|
||||
if (trailing != null)
|
||||
Padding(
|
||||
padding: const EdgeInsets.only(left: 8),
|
||||
child: trailing!,
|
||||
),
|
||||
if (actions) TrackActionsButton(track: track),
|
||||
]),
|
||||
CachedIndicator(trackId: track.id),
|
||||
Text('$mins:$secs', style: TextStyle(color: fs.ash, fontSize: 12)),
|
||||
if (trailing != null)
|
||||
Padding(
|
||||
padding: const EdgeInsets.only(left: 8),
|
||||
child: trailing!,
|
||||
),
|
||||
if (actions) TrackActionsButton(track: track),
|
||||
]),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -7,6 +7,7 @@ import '../cache/audio_cache_manager.dart' show appDbProvider;
|
||||
import '../cache/cache_first.dart';
|
||||
import '../cache/connectivity_provider.dart';
|
||||
import '../cache/db.dart';
|
||||
import '../cache/mutation_queue.dart';
|
||||
import '../library/library_providers.dart';
|
||||
|
||||
final likesApiProvider = FutureProvider<LikesApi>((ref) async {
|
||||
@@ -147,26 +148,18 @@ class LikesController {
|
||||
} else {
|
||||
await api.like(kind, id);
|
||||
}
|
||||
} catch (e, st) {
|
||||
// Rollback drift
|
||||
if (wasLiked) {
|
||||
await db.into(db.cachedLikes).insert(
|
||||
CachedLikesCompanion.insert(
|
||||
userId: user.id,
|
||||
entityType: entityType,
|
||||
entityId: id,
|
||||
),
|
||||
mode: drift.InsertMode.insertOrIgnore,
|
||||
);
|
||||
} else {
|
||||
await (db.delete(db.cachedLikes)
|
||||
..where((t) =>
|
||||
t.userId.equals(user.id) &
|
||||
t.entityType.equals(entityType) &
|
||||
t.entityId.equals(id)))
|
||||
.go();
|
||||
}
|
||||
Error.throwWithStackTrace(e, st);
|
||||
} catch (_) {
|
||||
// REST failed (network or HTTP). Don't roll back drift — the
|
||||
// user's intent is to like/unlike, and we want that visible to
|
||||
// them even when offline. Queue the call for replay; the
|
||||
// MutationReplayer will retry on next connectivity transition.
|
||||
// If retries exhaust (5 attempts), the row drops and the next
|
||||
// SyncController.sync brings drift back in line with the
|
||||
// server's authoritative state.
|
||||
await _ref.read(mutationQueueProvider).enqueue(
|
||||
wasLiked ? MutationKinds.likeRemove : MutationKinds.likeAdd,
|
||||
{'kind': entityType, 'id': id},
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,41 @@
|
||||
/// Mirrors internal/api/types.go HomeIndexPayload. Five flat slices of
|
||||
/// entity ID strings — the per-item rendering variant of HomeData.
|
||||
/// Section name implies entity type; no per-entry type tag is needed.
|
||||
///
|
||||
/// Slices are non-null after fromJson so callers can branch on `length`
|
||||
/// instead of dealing with null sections.
|
||||
class HomeIndex {
|
||||
const HomeIndex({
|
||||
required this.recentlyAddedAlbums,
|
||||
required this.rediscoverAlbums,
|
||||
required this.rediscoverArtists,
|
||||
required this.mostPlayedTracks,
|
||||
required this.lastPlayedArtists,
|
||||
});
|
||||
|
||||
final List<String> recentlyAddedAlbums;
|
||||
final List<String> rediscoverAlbums;
|
||||
final List<String> rediscoverArtists;
|
||||
final List<String> mostPlayedTracks;
|
||||
final List<String> lastPlayedArtists;
|
||||
|
||||
static const empty = HomeIndex(
|
||||
recentlyAddedAlbums: [],
|
||||
rediscoverAlbums: [],
|
||||
rediscoverArtists: [],
|
||||
mostPlayedTracks: [],
|
||||
lastPlayedArtists: [],
|
||||
);
|
||||
|
||||
factory HomeIndex.fromJson(Map<String, dynamic> j) {
|
||||
List<String> ids(String key) =>
|
||||
((j[key] as List?) ?? const []).map((e) => e.toString()).toList();
|
||||
return HomeIndex(
|
||||
recentlyAddedAlbums: ids('recently_added_albums'),
|
||||
rediscoverAlbums: ids('rediscover_albums'),
|
||||
rediscoverArtists: ids('rediscover_artists'),
|
||||
mostPlayedTracks: ids('most_played_tracks'),
|
||||
lastPlayedArtists: ids('last_played_artists'),
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,92 @@
|
||||
// Dominant-color extraction from album cover art (#396 item 1).
|
||||
// The full-screen Now Playing screen uses this to paint a top-to-bottom
|
||||
// gradient backdrop that grounds each track in its album's palette.
|
||||
//
|
||||
// Implementation: reuses AlbumCoverCache to get a local file path for
|
||||
// the cover, then runs PaletteGenerator over it. Results are cached
|
||||
// in-memory keyed by album_id so back-to-back plays of the same album
|
||||
// don't repeat the work. Cache is process-lifetime; album-art changes
|
||||
// are rare enough that LRU eviction isn't worth the complexity.
|
||||
//
|
||||
// Returns null on any failure (no cover, empty album_id, palette
|
||||
// extraction returned nothing). Callers fall back to the FabledSword
|
||||
// obsidian color for the gradient when null.
|
||||
|
||||
import 'dart:io';
|
||||
|
||||
import 'package:flutter/painting.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:palette_generator/palette_generator.dart';
|
||||
|
||||
import 'player_provider.dart';
|
||||
|
||||
/// Caches dominant colors keyed by album_id. Process-lifetime; refilled
|
||||
/// on app restart.
|
||||
class AlbumColorCache {
|
||||
AlbumColorCache(this._ref);
|
||||
|
||||
final Ref _ref;
|
||||
final Map<String, Color?> _cache = {};
|
||||
|
||||
/// Returns the dominant color for the album's cover, or null if no
|
||||
/// cover is available or extraction fails. Same call for the same
|
||||
/// album_id is cached after the first successful resolution.
|
||||
Future<Color?> getOrExtract(String albumId) async {
|
||||
if (albumId.isEmpty) return null;
|
||||
if (_cache.containsKey(albumId)) return _cache[albumId];
|
||||
final color = await _extract(albumId);
|
||||
_cache[albumId] = color;
|
||||
return color;
|
||||
}
|
||||
|
||||
/// Synchronous peek. Returns the previously-extracted color if this
|
||||
/// album has been resolved this process; otherwise null. Used by
|
||||
/// the now-playing fast-path swap so a warm cache transitions the
|
||||
/// gradient in lockstep with the audio, instead of awaiting the
|
||||
/// async [getOrExtract] future. A null return means "either no
|
||||
/// extraction yet or extraction returned null" — caller falls back
|
||||
/// to the async path.
|
||||
Color? peekColor(String albumId) => _cache[albumId];
|
||||
|
||||
Future<Color?> _extract(String albumId) async {
|
||||
try {
|
||||
final coverCache = _ref.read(albumCoverCacheProvider);
|
||||
final path = await coverCache.getOrFetch(albumId);
|
||||
if (path == null) return null;
|
||||
final file = File(path);
|
||||
if (!await file.exists()) return null;
|
||||
final palette = await PaletteGenerator.fromImageProvider(
|
||||
FileImage(file),
|
||||
// Small target size: palette extraction is CPU-bound and the
|
||||
// gradient only needs a single dominant color, so we don't
|
||||
// need full-resolution sampling.
|
||||
size: const Size(80, 80),
|
||||
maximumColorCount: 8,
|
||||
);
|
||||
// Prefer the explicit dominant color; fall back to the strongest
|
||||
// muted swatch (which tends to read better as a background than
|
||||
// a hot vibrant pick), then any populated swatch.
|
||||
final swatch = palette.dominantColor ??
|
||||
palette.darkMutedColor ??
|
||||
palette.darkVibrantColor ??
|
||||
palette.mutedColor;
|
||||
return swatch?.color;
|
||||
} catch (_) {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
final albumColorCacheProvider = Provider<AlbumColorCache>(
|
||||
(ref) => AlbumColorCache(ref),
|
||||
);
|
||||
|
||||
/// Family provider: dominant color for the given album_id, or null if
|
||||
/// no cover / extraction failed. The Now Playing screen watches this
|
||||
/// keyed by the current MediaItem's album_id.
|
||||
final albumColorProvider = FutureProvider.family<Color?, String>(
|
||||
(ref, albumId) async {
|
||||
final cache = ref.watch(albumColorCacheProvider);
|
||||
return cache.getOrExtract(albumId);
|
||||
},
|
||||
);
|
||||
@@ -27,6 +27,32 @@ class AlbumCoverCache {
|
||||
/// same album dedupe to one fetch.
|
||||
final Map<String, Future<String?>> _inflight = {};
|
||||
|
||||
/// Cached covers directory path resolved once on the first
|
||||
/// async cacheDir call, then reused for sync existsSync() checks
|
||||
/// in [peekCached]. Without this every "is the cover already on
|
||||
/// disk?" check would have to await path_provider, blocking the
|
||||
/// MediaItem broadcast on every track change.
|
||||
String? _coversDirPath;
|
||||
|
||||
/// Returns the local file path for [albumId]'s cover if it's
|
||||
/// already cached on disk, or null otherwise. Synchronous — uses
|
||||
/// File.existsSync() against a path computed from the directory
|
||||
/// resolved by an earlier async [getOrFetch] call. Returns null
|
||||
/// until at least one getOrFetch has populated _coversDirPath.
|
||||
///
|
||||
/// The audio handler uses this to seed MediaItem.artUri on the
|
||||
/// initial broadcast so external media controllers (Wear, Android
|
||||
/// Auto, Bluetooth) see the cover on the first frame for warm-cache
|
||||
/// tracks. Cold-cache tracks still fall back to the async
|
||||
/// _loadArtForCurrentItem path.
|
||||
String? peekCached(String albumId) {
|
||||
if (albumId.isEmpty) return null;
|
||||
final dir = _coversDirPath;
|
||||
if (dir == null) return null;
|
||||
final path = '$dir/$albumId.jpg';
|
||||
return File(path).existsSync() ? path : null;
|
||||
}
|
||||
|
||||
/// Returns local file path to the album cover, or null on any
|
||||
/// failure (network, 4xx/5xx, disk full, empty albumId).
|
||||
Future<String?> getOrFetch(String albumId) {
|
||||
@@ -44,6 +70,9 @@ class AlbumCoverCache {
|
||||
final dir = await _cacheDirFactory();
|
||||
final coversDir = Directory('${dir.path}/album_covers');
|
||||
await coversDir.create(recursive: true);
|
||||
// Cache the resolved directory so [peekCached] can do its
|
||||
// existsSync() check without re-awaiting path_provider.
|
||||
_coversDirPath = coversDir.path;
|
||||
final filePath = '${coversDir.path}/$albumId.jpg';
|
||||
final file = File(filePath);
|
||||
if (await file.exists()) return filePath;
|
||||
|
||||
@@ -12,12 +12,32 @@ import 'album_cover_cache.dart';
|
||||
|
||||
class MinstrelAudioHandler extends BaseAudioHandler with QueueHandler, SeekHandler {
|
||||
MinstrelAudioHandler() {
|
||||
_player.playbackEventStream.listen(_broadcastState);
|
||||
_player.playbackEventStream.listen(
|
||||
_broadcastState,
|
||||
// ExoPlayer surfaces stream errors (404, premature EOS, decoder
|
||||
// failure, network drop) here. Logging alone leaves the UI
|
||||
// claiming "now playing X" while audio is silent — the user-
|
||||
// observable mismatch between visual and audio state. Skip
|
||||
// forward so the queue advances past the failed track and
|
||||
// mediaItem updates to whatever's actually playing. If the
|
||||
// failure is at the queue tail, just_audio will go idle on its
|
||||
// own and _broadcastState reflects that.
|
||||
onError: (Object e, StackTrace st) {
|
||||
debugPrint('audio_handler: playbackEventStream error: $e\n$st');
|
||||
unawaited(_handlePlaybackError());
|
||||
},
|
||||
);
|
||||
_player.currentIndexStream.listen(_onCurrentIndexChanged);
|
||||
// Re-broadcast on shuffle/repeat changes so the PlaybackState's
|
||||
// shuffleMode + repeatMode fields stay current for UI subscribers.
|
||||
_player.shuffleModeEnabledStream.listen((_) => _broadcastState(null));
|
||||
_player.loopModeStream.listen((_) => _broadcastState(null));
|
||||
// Watch buffered-position so we can register stream-cached files
|
||||
// in the audio cache index once they're fully downloaded. Without
|
||||
// this, files written by LockCachingAudioSource never appear in
|
||||
// the index and the eviction loop can't reclaim them.
|
||||
_player.bufferedPositionStream
|
||||
.listen((_) => unawaited(_maybeRegisterStreamCache()));
|
||||
}
|
||||
|
||||
final AudioPlayer _player = AudioPlayer();
|
||||
@@ -25,6 +45,42 @@ class MinstrelAudioHandler extends BaseAudioHandler with QueueHandler, SeekHandl
|
||||
String? _token;
|
||||
AlbumCoverCache? _coverCache;
|
||||
AudioCacheManager? _audioCacheManager;
|
||||
LikeBridge? _likeBridge;
|
||||
|
||||
/// Trackers to dedupe registration — once we've inserted an index row
|
||||
/// for a trackId, don't repeat the work on every buffered-position
|
||||
/// emit. Cleared on dispose only; surviving across queue rebuilds is
|
||||
/// fine because the index is itself the source of truth.
|
||||
final Set<String> _streamCacheRegistered = {};
|
||||
|
||||
/// Cached on first use so we don't hit the platform channel every
|
||||
/// time the buffered-position stream emits (~200ms cadence).
|
||||
String? _cacheDirPath;
|
||||
|
||||
/// True while _fillRemainingSources is doing backward-fill inserts
|
||||
/// at index 0..initialIndex-1. Each insert shifts the player's
|
||||
/// currentIndex (it tracks the actively-playing source through
|
||||
/// list mutations), and the resulting _onCurrentIndexChanged
|
||||
/// callbacks would push the wrong MediaItem onto the stream
|
||||
/// (queue.value[shifted_idx] != actively-playing track). When
|
||||
/// the fill completes, currentIndex == initialIndex, mediaItem
|
||||
/// is already correct, and we re-enable normal listener behavior.
|
||||
bool _suppressIndexUpdates = false;
|
||||
|
||||
/// Increments on every setQueueFromTracks call. The background
|
||||
/// fill task captures the value at start and bails if the live
|
||||
/// counter has moved on — without this, a stale fill will keep
|
||||
/// addAudioSource'ing tracks from the previous playlist into the
|
||||
/// new queue, leaving the player "locked" to a corrupted state.
|
||||
int _queueGeneration = 0;
|
||||
|
||||
/// Tracks the most recent setQueueFromTracks() input so
|
||||
/// skipToQueueItem can reconstruct the source list. just_audio
|
||||
/// requires every source to be built before it can be a skip
|
||||
/// target, but setQueueFromTracks only builds the initial source
|
||||
/// and fills the rest in the background — so a skip to an index
|
||||
/// past the fill front needs to rebuild from the stored tracks.
|
||||
List<TrackRef> _lastTracks = const [];
|
||||
|
||||
/// Volume stream for UI subscribers. Mirrors the just_audio player's
|
||||
/// volume directly; set via setVolume(double).
|
||||
@@ -44,37 +100,141 @@ class MinstrelAudioHandler extends BaseAudioHandler with QueueHandler, SeekHandl
|
||||
required String? token,
|
||||
AlbumCoverCache? coverCache,
|
||||
AudioCacheManager? audioCacheManager,
|
||||
LikeBridge? likeBridge,
|
||||
}) {
|
||||
_baseUrl = baseUrl;
|
||||
_token = token;
|
||||
if (coverCache != null) _coverCache = coverCache;
|
||||
if (likeBridge != null) _likeBridge = likeBridge;
|
||||
if (audioCacheManager != null) _audioCacheManager = audioCacheManager;
|
||||
debugPrint('audio_handler.configure: baseUrl="$baseUrl" '
|
||||
'tokenPresent=${token != null && token.isNotEmpty} '
|
||||
'coverCachePresent=${_coverCache != null} '
|
||||
'audioCachePresent=${_audioCacheManager != null}');
|
||||
}
|
||||
|
||||
Future<void> setQueueFromTracks(List<TrackRef> tracks, {int initialIndex = 0}) async {
|
||||
final items = tracks.map(_toMediaItem).toList();
|
||||
queue.add(items);
|
||||
if (items.isNotEmpty) {
|
||||
mediaItem.add(items[initialIndex.clamp(0, items.length - 1)]);
|
||||
if (tracks.isEmpty) return;
|
||||
final clampedInitial = initialIndex.clamp(0, tracks.length - 1);
|
||||
|
||||
// Bump the generation FIRST. Any in-flight _fillRemainingSources
|
||||
// from a previous play will see the mismatch on its next gen
|
||||
// check and stop calling player mutations — important so a stale
|
||||
// fill doesn't append old-playlist tracks into the new queue.
|
||||
final myGen = ++_queueGeneration;
|
||||
_lastTracks = tracks;
|
||||
|
||||
// Pause the old source immediately so the previous track stops
|
||||
// audibly the moment the user taps, instead of bleeding through
|
||||
// until the new source finishes building. setAudioSources below
|
||||
// will swap the source list cleanly; pause is the simplest way
|
||||
// to silence the player during the (possibly multi-100ms) build.
|
||||
if (_player.playing) {
|
||||
await _player.pause();
|
||||
}
|
||||
|
||||
debugPrint('audio_handler.setQueueFromTracks: '
|
||||
'_baseUrl="$_baseUrl" trackCount=${tracks.length}');
|
||||
final sources = await Future.wait(tracks.map(_buildAudioSource));
|
||||
// Build MediaItems up front (pure — no side effects); we'll
|
||||
// broadcast queue/mediaItem only AFTER setAudioSources resolves
|
||||
// so the audio engine and the UI flip together. If the build
|
||||
// throws, the UI stays on the previous track (correct: audio
|
||||
// also stays on the previous track since setAudioSources never
|
||||
// ran).
|
||||
final items = tracks.map(_toMediaItem).toList();
|
||||
|
||||
await _player.setAudioSources(
|
||||
sources,
|
||||
initialIndex: initialIndex,
|
||||
);
|
||||
// Build only the initial source for fast start. Remaining
|
||||
// sources stream in via _fillRemainingSources() — addAudioSource
|
||||
// for next/auto-advance tracks, insertAudioSource for skipPrev.
|
||||
final AudioSource initial;
|
||||
try {
|
||||
initial = await _buildAudioSource(tracks[clampedInitial]);
|
||||
} catch (e, st) {
|
||||
// Source build failed (bad URL, missing baseUrl, etc.). Don't
|
||||
// broadcast the new state — leaving queue/mediaItem on the
|
||||
// previous track keeps UI in sync with what the player is
|
||||
// actually doing (which is "still on the previous track,
|
||||
// paused").
|
||||
debugPrint('audio_handler: _buildAudioSource failed: $e\n$st');
|
||||
return;
|
||||
}
|
||||
if (myGen != _queueGeneration) {
|
||||
debugPrint('audio_handler: superseded before setAudioSources (gen=$myGen)');
|
||||
return;
|
||||
}
|
||||
|
||||
// Suppress _onCurrentIndexChanged side effects while the source
|
||||
// list is being swapped — without this, a transient currentIndex
|
||||
// emission during setAudioSources could broadcast the OLD queue's
|
||||
// entry at the NEW index. Re-enabled after the broadcasts land.
|
||||
_suppressIndexUpdates = true;
|
||||
try {
|
||||
await _player.setAudioSources([initial], initialIndex: 0);
|
||||
// Broadcast in this order: queue first (so any consumer that
|
||||
// reacts to mediaItem and reads queue.value sees the consistent
|
||||
// pair), then mediaItem.
|
||||
queue.add(items);
|
||||
mediaItem.add(items[clampedInitial]);
|
||||
} finally {
|
||||
_suppressIndexUpdates = false;
|
||||
}
|
||||
|
||||
// Kick the cover fetch for the initial item — async, doesn't block
|
||||
// playback. Subsequent track changes are handled by the
|
||||
// currentIndexStream listener.
|
||||
unawaited(_loadArtForCurrentItem());
|
||||
unawaited(_fillRemainingSources(tracks, clampedInitial, myGen));
|
||||
}
|
||||
|
||||
/// Switches playback to the [index]th queue item. The full
|
||||
/// just_audio source list isn't necessarily built yet
|
||||
/// (_fillRemainingSources runs in the background), so we
|
||||
/// reconstruct from the stored TrackRef list rather than calling
|
||||
/// _player.seek(index: ...) on a possibly-missing source. Calling
|
||||
/// setQueueFromTracks again is the safe path: it bumps the
|
||||
/// generation, cancels any in-flight fill, rebuilds source[0] as
|
||||
/// the target, and re-fills around. play() restarts playback so
|
||||
/// queue taps feel like "jump to this song" rather than "set the
|
||||
/// pointer and wait for me to press play."
|
||||
@override
|
||||
Future<void> skipToQueueItem(int index) async {
|
||||
if (index < 0 || index >= _lastTracks.length) return;
|
||||
await setQueueFromTracks(_lastTracks, initialIndex: index);
|
||||
await play();
|
||||
}
|
||||
|
||||
/// Background fill of the rest of the just_audio source list after
|
||||
/// the initial source is playing. Forward direction first (most
|
||||
/// common skipNext target). Backward inserts shift the player's
|
||||
/// currentIndex; we suppress _onCurrentIndexChanged side effects
|
||||
/// for those so the mediaItem stream doesn't bounce to the wrong
|
||||
/// queue entry.
|
||||
///
|
||||
/// `gen` is the queue generation captured when this fill started.
|
||||
/// Every loop iteration checks against _queueGeneration; if a
|
||||
/// newer setQueueFromTracks has run (user tapped play on something
|
||||
/// else), bail immediately so we don't pollute the new queue with
|
||||
/// addAudioSource calls from this stale fill.
|
||||
Future<void> _fillRemainingSources(
|
||||
List<TrackRef> tracks, int initialIndex, int gen) async {
|
||||
for (var i = initialIndex + 1; i < tracks.length; i++) {
|
||||
if (gen != _queueGeneration) return;
|
||||
try {
|
||||
final src = await _buildAudioSource(tracks[i]);
|
||||
if (gen != _queueGeneration) return;
|
||||
await _player.addAudioSource(src);
|
||||
} catch (e) {
|
||||
debugPrint('audio_handler: forward fill failed for ${tracks[i].id}: $e');
|
||||
}
|
||||
}
|
||||
if (initialIndex > 0) {
|
||||
_suppressIndexUpdates = true;
|
||||
try {
|
||||
for (var i = 0; i < initialIndex; i++) {
|
||||
if (gen != _queueGeneration) return;
|
||||
final src = await _buildAudioSource(tracks[i]);
|
||||
if (gen != _queueGeneration) return;
|
||||
await _player.insertAudioSource(i, src);
|
||||
}
|
||||
} catch (e) {
|
||||
debugPrint('audio_handler: backward fill failed: $e');
|
||||
} finally {
|
||||
// Only release the flag if we're still the active gen — a
|
||||
// newer setQueueFromTracks already reset it for itself.
|
||||
if (gen == _queueGeneration) _suppressIndexUpdates = false;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
String _resolveStreamUrl(TrackRef t) {
|
||||
@@ -103,7 +263,6 @@ class MinstrelAudioHandler extends BaseAudioHandler with QueueHandler, SeekHandl
|
||||
if (mgr != null) {
|
||||
final path = await mgr.pathFor(t.id);
|
||||
if (path != null) {
|
||||
debugPrint('audio_handler: cache hit for track.id=${t.id} → file://$path');
|
||||
return AudioSource.uri(Uri.file(path));
|
||||
}
|
||||
}
|
||||
@@ -127,17 +286,14 @@ class MinstrelAudioHandler extends BaseAudioHandler with QueueHandler, SeekHandl
|
||||
// pin / Download buttons cover the index path; LockCaching handles
|
||||
// the network optimization.
|
||||
if (mgr != null) {
|
||||
final cacheDir = await getApplicationCacheDirectory();
|
||||
final cacheFile = File('${cacheDir.path}/audio_cache/${t.id}.mp3');
|
||||
debugPrint('audio_handler: cache miss for track.id=${t.id}, '
|
||||
'using LockCachingAudioSource → ${cacheFile.path}');
|
||||
_cacheDirPath ??= (await getApplicationCacheDirectory()).path;
|
||||
final cacheFile = File('${_cacheDirPath!}/audio_cache/${t.id}.mp3');
|
||||
// ignore: experimental_member_use
|
||||
return LockCachingAudioSource(parsed,
|
||||
headers: headers, cacheFile: cacheFile);
|
||||
}
|
||||
|
||||
// 3. No manager configured: plain network source (legacy path).
|
||||
debugPrint('audio_handler: no cache manager; track.id=${t.id} → "$url"');
|
||||
return AudioSource.uri(parsed, headers: headers);
|
||||
}
|
||||
|
||||
@@ -174,18 +330,101 @@ class MinstrelAudioHandler extends BaseAudioHandler with QueueHandler, SeekHandl
|
||||
final extras = <String, dynamic>{};
|
||||
if (t.albumId.isNotEmpty) extras['album_id'] = t.albumId;
|
||||
if (t.artistId.isNotEmpty) extras['artist_id'] = t.artistId;
|
||||
// Sync-peek the album cover cache so warm-cache tracks broadcast
|
||||
// with artUri populated on the first frame. External media
|
||||
// controllers (Android Wear, Bluetooth dashes, Auto, lock screen)
|
||||
// can only render the cover bytes that audio_service hands them
|
||||
// at MediaItem broadcast time; the later async _loadArtForCurrent
|
||||
// Item path repopulates for cold-cache tracks. Without this seed,
|
||||
// every track change starts with a generic icon on the watch and
|
||||
// only gets the real cover after one or two seconds.
|
||||
final coverPath = (t.albumId.isNotEmpty && _coverCache != null)
|
||||
? _coverCache!.peekCached(t.albumId)
|
||||
: null;
|
||||
// MediaItem.rating intentionally NOT set: audio_service propagates
|
||||
// it to MediaSession.setRating(), but the Android session also
|
||||
// needs setRatingType(RATING_HEART) configured to expose that to
|
||||
// controllers — audio_service doesn't surface that config knob,
|
||||
// and broadcasting an unanchored rating made Wear OS reject the
|
||||
// session entirely. The LikeBridge wiring stays in place so
|
||||
// setRating can still fire from any surface that DOES route it,
|
||||
// we just don't advertise it.
|
||||
return MediaItem(
|
||||
id: t.id,
|
||||
title: t.title,
|
||||
artist: t.artistName,
|
||||
album: t.albumTitle,
|
||||
duration: Duration(seconds: t.durationSec),
|
||||
artUri: coverPath != null ? Uri.file(coverPath) : null,
|
||||
extras: extras.isEmpty ? null : extras,
|
||||
);
|
||||
}
|
||||
|
||||
/// Once a track is fully buffered (LockCaching has written the whole
|
||||
/// file to disk), insert an audio_cache_index row so the file shows
|
||||
/// up to AudioCacheManager.evict() and clearAll(). No-op if the
|
||||
/// cache manager isn't configured, no current track, the file isn't
|
||||
/// fully buffered yet, the on-disk file is missing, or we already
|
||||
/// registered this trackId during this subscription.
|
||||
Future<void> _maybeRegisterStreamCache() async {
|
||||
final mgr = _audioCacheManager;
|
||||
if (mgr == null) return;
|
||||
final current = mediaItem.value;
|
||||
if (current == null) return;
|
||||
final trackId = current.id;
|
||||
if (_streamCacheRegistered.contains(trackId)) return;
|
||||
|
||||
final dur = _player.duration;
|
||||
if (dur == null) return;
|
||||
final buf = _player.bufferedPosition;
|
||||
// 200ms slack for header bytes / encoding rounding.
|
||||
if (buf < dur - const Duration(milliseconds: 200)) return;
|
||||
|
||||
_cacheDirPath ??= (await getApplicationCacheDirectory()).path;
|
||||
final path = '${_cacheDirPath!}/audio_cache/$trackId.mp3';
|
||||
final file = File(path);
|
||||
if (!await file.exists()) return;
|
||||
final size = await file.length();
|
||||
if (size <= 0) return;
|
||||
|
||||
_streamCacheRegistered.add(trackId);
|
||||
await mgr.registerStreamCache(trackId, path, size);
|
||||
}
|
||||
|
||||
/// Called when playbackEventStream emits an error. Skips past the
|
||||
/// failing track so the UI and audio re-converge — without this,
|
||||
/// _player goes silent on a 404 / decoder failure / EOS but
|
||||
/// mediaItem stays on the failed track and the user sees a "now
|
||||
/// playing" header for something that isn't.
|
||||
///
|
||||
/// If we're at the last track, seekToNext is a no-op; the state
|
||||
/// drops to idle and _broadcastState reflects that.
|
||||
Future<void> _handlePlaybackError() async {
|
||||
final currentIdx = _player.currentIndex;
|
||||
final queueLen = queue.value.length;
|
||||
if (currentIdx == null || currentIdx + 1 >= queueLen) {
|
||||
// Last track or no queue context — just pause; _broadcastState
|
||||
// already reflects the idle/error processingState.
|
||||
try {
|
||||
await _player.pause();
|
||||
} catch (_) {}
|
||||
return;
|
||||
}
|
||||
try {
|
||||
await _player.seekToNext();
|
||||
} catch (_) {
|
||||
// If seekToNext fails too (next source not built yet, etc.),
|
||||
// there's nothing safe to do — pause and let the user recover
|
||||
// manually.
|
||||
try {
|
||||
await _player.pause();
|
||||
} catch (_) {}
|
||||
}
|
||||
}
|
||||
|
||||
void _onCurrentIndexChanged(int? idx) {
|
||||
if (idx == null) return;
|
||||
if (_suppressIndexUpdates) return;
|
||||
// Push the new track's MediaItem onto the mediaItem stream so
|
||||
// the player UI rebuilds with the new title/artist/album/cover.
|
||||
// Without this, the bar and full player stayed pinned to whichever
|
||||
@@ -232,6 +471,45 @@ class MinstrelAudioHandler extends BaseAudioHandler with QueueHandler, SeekHandl
|
||||
@override
|
||||
Future<void> skipToPrevious() => _player.seekToPrevious();
|
||||
|
||||
/// Heart rating from external surfaces (Wear's favorite button,
|
||||
/// lock-screen like) → LikesController.toggle(track). We only
|
||||
/// route through the bridge when the rating actually flips relative
|
||||
/// to the current state, so repeated taps from a flaky controller
|
||||
/// don't ping-pong the like.
|
||||
@override
|
||||
Future<void> setRating(Rating rating, [Map<String, dynamic>? extras]) async {
|
||||
final media = mediaItem.value;
|
||||
final bridge = _likeBridge;
|
||||
if (media == null || bridge == null) return;
|
||||
final currentlyLiked = bridge.isTrackLiked(media.id);
|
||||
final wantLiked = rating.hasHeart();
|
||||
if (currentlyLiked == wantLiked) return;
|
||||
try {
|
||||
await bridge.toggleTrackLike(media.id);
|
||||
} catch (_) {
|
||||
// LikesController already rolls back on REST failure; nothing
|
||||
// to do here beyond letting the broadcast skip.
|
||||
return;
|
||||
}
|
||||
// Re-emit so the watch's heart icon updates immediately.
|
||||
mediaItem.add(media.copyWith(rating: Rating.newHeartRating(wantLiked)));
|
||||
}
|
||||
|
||||
/// Re-emits the current mediaItem with a fresh rating pulled from
|
||||
/// the LikeBridge. Called by PlayerActions on likedIdsProvider
|
||||
/// changes so the watch / lock-screen heart icon updates when the
|
||||
/// user toggles a like from TrackRow, the kebab menu, or another
|
||||
/// device's playback (SSE-routed). No-op if no track is playing
|
||||
/// or the like state didn't change.
|
||||
void refreshCurrentRating() {
|
||||
final media = mediaItem.value;
|
||||
final bridge = _likeBridge;
|
||||
if (media == null || bridge == null) return;
|
||||
final liked = bridge.isTrackLiked(media.id);
|
||||
if (media.rating?.hasHeart() == liked) return;
|
||||
mediaItem.add(media.copyWith(rating: Rating.newHeartRating(liked)));
|
||||
}
|
||||
|
||||
@override
|
||||
Future<void> setShuffleMode(AudioServiceShuffleMode shuffleMode) async {
|
||||
await _player
|
||||
@@ -274,6 +552,18 @@ class MinstrelAudioHandler extends BaseAudioHandler with QueueHandler, SeekHandl
|
||||
// systemActions enumerates which actions the system can invoke
|
||||
// on us — without play/pause/skip in here, taps on lock-screen
|
||||
// controls don't route back to the handler on Android 13+.
|
||||
//
|
||||
// v2026.05.13.3 added stop, skipToQueueItem, setShuffleMode,
|
||||
// setRepeatMode, and setRating to this set; reverted because
|
||||
// Pixel Watch 2 stopped showing controls entirely after that
|
||||
// change. The MediaSession contract on Wear OS requires more
|
||||
// setup than just advertising the action (e.g. setRatingType
|
||||
// for setRating) and audio_service doesn't expose those knobs.
|
||||
// Keep the override methods themselves (skipToQueueItem is
|
||||
// still routed via QueueScreen's direct handler call;
|
||||
// setRating is harmless if never invoked) so we don't lose
|
||||
// the underlying functionality — just don't tell the system
|
||||
// we support them.
|
||||
systemActions: const {
|
||||
MediaAction.play,
|
||||
MediaAction.pause,
|
||||
@@ -304,3 +594,27 @@ class MinstrelAudioHandler extends BaseAudioHandler with QueueHandler, SeekHandl
|
||||
));
|
||||
}
|
||||
}
|
||||
|
||||
/// Adapter that lets the audio handler call into the app's
|
||||
/// LikesController without depending on Riverpod directly. Constructed
|
||||
/// in PlayerActions where ref is available; consumed inside the audio
|
||||
/// handler's setRating override and MediaItem builder to keep external
|
||||
/// media controllers (Wear, lock screen, Auto) in sync with the
|
||||
/// likedIds drift cache.
|
||||
class LikeBridge {
|
||||
const LikeBridge({
|
||||
required this.toggleTrackLike,
|
||||
required this.isTrackLiked,
|
||||
});
|
||||
|
||||
/// Flip the like state for [trackId]. Returns a Future that resolves
|
||||
/// once the underlying LikesController has both updated drift
|
||||
/// optimistically and rolled the change through the REST API
|
||||
/// (errors result in drift rollback inside LikesController).
|
||||
final Future<void> Function(String trackId) toggleTrackLike;
|
||||
|
||||
/// Read the current like state for [trackId] from the drift-backed
|
||||
/// likedIdsProvider. Synchronous because the audio handler needs
|
||||
/// to populate MediaItem.rating on the broadcast hot path.
|
||||
final bool Function(String trackId) isTrackLiked;
|
||||
}
|
||||
|
||||
@@ -11,8 +11,20 @@ import '../models/track.dart';
|
||||
import '../shared/widgets/server_image.dart';
|
||||
import '../shared/widgets/track_actions/track_actions_button.dart';
|
||||
import '../theme/theme_extension.dart';
|
||||
import 'album_color_extractor.dart';
|
||||
import 'player_provider.dart';
|
||||
|
||||
/// Hero tag shared between the mini player's cover and the full-screen
|
||||
/// _AlbumArt's cover so tapping the mini bar animates the artwork from
|
||||
/// the bar's footprint to the full-screen size. Stable per-route (not
|
||||
/// keyed by media.id) so the transition works regardless of what's
|
||||
/// playing.
|
||||
const String kPlayerCoverHeroTag = 'player-cover';
|
||||
|
||||
/// Duration for the AnimatedSwitcher / AnimatedContainer track-change
|
||||
/// crossfade. ~300ms reads as a smooth transition without dragging.
|
||||
const Duration _trackChangeDuration = Duration(milliseconds: 300);
|
||||
|
||||
/// Full-screen player. Mounted on /now-playing. Pushed via a slide-up
|
||||
/// transition (see routing.dart). Dismisses three ways:
|
||||
///
|
||||
@@ -33,6 +45,133 @@ class _NowPlayingScreenState extends ConsumerState<NowPlayingScreen> {
|
||||
// dismiss. Reset on each drag start.
|
||||
double _dragOffset = 0;
|
||||
|
||||
/// The MediaItem currently displayed on the screen. Held separately
|
||||
/// from the live mediaItemProvider so we can preload the new track's
|
||||
/// cover bytes + dominant color BEFORE flipping the visible state.
|
||||
/// Without this gate the full-player UI swapped to the new track's
|
||||
/// title/cover slot immediately while the image was still decoding,
|
||||
/// producing a visible "pop in" once the bytes arrived.
|
||||
MediaItem? _displayedMedia;
|
||||
|
||||
/// Dominant color of [_displayedMedia]'s cover. Tweened by the
|
||||
/// backdrop AnimatedContainer when it changes.
|
||||
Color? _displayedDominant;
|
||||
|
||||
/// The id of the most-recent track we kicked a preload for. Used to
|
||||
/// drop stale preload completions when the user skips rapidly past
|
||||
/// a track whose cover hadn't finished decoding yet.
|
||||
String? _pendingPreloadId;
|
||||
|
||||
@override
|
||||
void initState() {
|
||||
super.initState();
|
||||
// Seed displayed state from the current mediaItem if a track is
|
||||
// already playing when the full player is opened. ref.listen
|
||||
// below only fires on CHANGES after subscription, so without
|
||||
// this seed the screen sits on "Nothing playing." even though
|
||||
// the mini bar shows a live track — the listener never gets a
|
||||
// mediaItem emission because the stream's current value hasn't
|
||||
// changed.
|
||||
final current = ref.read(mediaItemProvider).value;
|
||||
if (current == null) return;
|
||||
_displayedMedia = current;
|
||||
// Best-effort synchronous color seed: if albumColorProvider has
|
||||
// already extracted this album's dominant color earlier in the
|
||||
// session, pull it now so the backdrop renders correctly on
|
||||
// first frame. Otherwise the post-frame _scheduleSwap below
|
||||
// resolves it asynchronously and AnimatedContainer tweens.
|
||||
final albumId = current.extras?['album_id'] as String?;
|
||||
if (albumId != null && albumId.isNotEmpty) {
|
||||
_displayedDominant =
|
||||
ref.read(albumColorProvider(albumId)).asData?.value;
|
||||
}
|
||||
// Kick the preload pipeline post-frame so the cover bytes are
|
||||
// decoded + the dominant color is resolved even when the user
|
||||
// opens the player to a track that hasn't yet flowed through
|
||||
// ref.listen.
|
||||
WidgetsBinding.instance.addPostFrameCallback((_) {
|
||||
if (!mounted) return;
|
||||
_scheduleSwap(current);
|
||||
});
|
||||
}
|
||||
|
||||
/// Preload the new track's cover bytes + dominant color, then
|
||||
/// atomically flip _displayedMedia / _displayedDominant. Until both
|
||||
/// resolve, the screen continues to render the previous track —
|
||||
/// the new title/cover/gradient appear together in one frame.
|
||||
///
|
||||
/// Concurrency: if a second track change arrives while the first
|
||||
/// preload is still in flight, the older preload's
|
||||
/// _pendingPreloadId check fails and its completion is dropped.
|
||||
Future<void> _scheduleSwap(MediaItem newMedia) async {
|
||||
_pendingPreloadId = newMedia.id;
|
||||
|
||||
// Fast path: when Prefetcher has already warmed both the cover
|
||||
// bytes (file:// artUri populated via _toMediaItem's peekCached)
|
||||
// AND the palette color (AlbumColorCache.peekColor returns
|
||||
// non-null), we can commit synchronously. The slow async path
|
||||
// exists for genuine cold-cache moments (first play of an album
|
||||
// that sync hasn't seen yet); the fast path is what makes the
|
||||
// common in-queue auto-advance flip the visual in lockstep with
|
||||
// the audio transition instead of lagging a tick behind.
|
||||
final artUri = newMedia.artUri;
|
||||
final albumId = newMedia.extras?['album_id'] as String?;
|
||||
if (artUri != null &&
|
||||
artUri.isScheme('file') &&
|
||||
albumId != null &&
|
||||
albumId.isNotEmpty) {
|
||||
final cachedColor = ref.read(albumColorCacheProvider).peekColor(albumId);
|
||||
if (cachedColor != null) {
|
||||
if (!mounted) return;
|
||||
if (_pendingPreloadId != newMedia.id) return;
|
||||
setState(() {
|
||||
_displayedMedia = newMedia;
|
||||
_displayedDominant = cachedColor;
|
||||
});
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
// Slow path: cover and/or color are not yet cached. Hold the
|
||||
// current displayed state, preload, then atomic-commit.
|
||||
//
|
||||
// 1. Precache the cover image bytes so when _AlbumArt mounts with
|
||||
// the new media, FileImage paints synchronously. Non-file
|
||||
// artUris fall through to ServerImage which handles its own
|
||||
// network load + 120ms fade — they won't snap.
|
||||
if (artUri != null && artUri.isScheme('file') && context.mounted) {
|
||||
try {
|
||||
await precacheImage(FileImage(File.fromUri(artUri)), context);
|
||||
} catch (_) {
|
||||
// Decode failed (missing file, corrupt bytes) — proceed
|
||||
// anyway; _AlbumArt's errorBuilder shows the slate fallback.
|
||||
}
|
||||
}
|
||||
|
||||
// 2. Wait for the dominant-color extraction so the gradient is
|
||||
// populated when we swap. PaletteGenerator runs against the
|
||||
// same FileImage, typically resolving within ~50ms once the
|
||||
// decode completes.
|
||||
Color? newDominant;
|
||||
if (albumId != null && albumId.isNotEmpty) {
|
||||
try {
|
||||
newDominant = await ref.read(albumColorProvider(albumId).future);
|
||||
} catch (_) {
|
||||
// Color extraction failed — keep the previous dominant so the
|
||||
// backdrop doesn't drop to obsidian on the swap.
|
||||
}
|
||||
}
|
||||
|
||||
// 3. Atomic flip. Bail if a newer swap superseded us, or the
|
||||
// screen was disposed mid-preload.
|
||||
if (!mounted) return;
|
||||
if (_pendingPreloadId != newMedia.id) return;
|
||||
setState(() {
|
||||
_displayedMedia = newMedia;
|
||||
if (newDominant != null) _displayedDominant = newDominant;
|
||||
});
|
||||
}
|
||||
|
||||
void _onDragStart(DragStartDetails _) {
|
||||
_dragOffset = 0;
|
||||
}
|
||||
@@ -55,10 +194,61 @@ class _NowPlayingScreenState extends ConsumerState<NowPlayingScreen> {
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final media = ref.watch(mediaItemProvider).value;
|
||||
final playback = ref.watch(playbackStateProvider).value;
|
||||
|
||||
if (media == null) {
|
||||
// Listen for mediaItem changes and schedule a preload-then-swap.
|
||||
// Build renders _displayedMedia / _displayedDominant; the live
|
||||
// mediaItemProvider only drives the swap pipeline.
|
||||
//
|
||||
// Decision process:
|
||||
// - On the first non-null mediaItem after mount, seed
|
||||
// _displayedMedia immediately so the screen has something to
|
||||
// paint.
|
||||
// - On a track id change, kick off a preload. The new track's
|
||||
// cover bytes + dominant color must both resolve before we
|
||||
// flip the displayed state. The user sees the previous track
|
||||
// in full until the new one is fully ready, then a clean
|
||||
// atomic swap (no fade, no placeholder flash).
|
||||
// - On the same track id but the artUri-bearing rebroadcast
|
||||
// (audio_handler sends MediaItem twice on track change),
|
||||
// refresh through the same preload pipeline so the displayed
|
||||
// cover reflects the freshly-written AlbumCoverCache file.
|
||||
ref.listen<AsyncValue<MediaItem?>>(mediaItemProvider, (prev, next) {
|
||||
final newMedia = next.asData?.value;
|
||||
if (newMedia == null) {
|
||||
if (_displayedMedia != null) {
|
||||
setState(() {
|
||||
_displayedMedia = null;
|
||||
_displayedDominant = null;
|
||||
_pendingPreloadId = null;
|
||||
});
|
||||
}
|
||||
return;
|
||||
}
|
||||
if (_displayedMedia == null) {
|
||||
// First mount with a track playing — seed immediately, then
|
||||
// kick the preload pipeline to update the dominant color and
|
||||
// ensure the cover is decoded.
|
||||
setState(() => _displayedMedia = newMedia);
|
||||
_scheduleSwap(newMedia);
|
||||
return;
|
||||
}
|
||||
final isNewTrack = newMedia.id != _displayedMedia!.id;
|
||||
final coverGotPopulated =
|
||||
newMedia.id == _displayedMedia!.id &&
|
||||
newMedia.artUri != null &&
|
||||
_displayedMedia!.artUri == null;
|
||||
if (isNewTrack || coverGotPopulated) {
|
||||
_scheduleSwap(newMedia);
|
||||
}
|
||||
});
|
||||
|
||||
final playback = ref.watch(playbackStateProvider).value;
|
||||
final displayedMedia = _displayedMedia;
|
||||
|
||||
if (displayedMedia == null) {
|
||||
// Either nothing playing, or the very first mount before a
|
||||
// mediaItem has been emitted. The ref.listen above will seed
|
||||
// _displayedMedia as soon as a non-null MediaItem arrives.
|
||||
return const Scaffold(body: Center(child: Text('Nothing playing.')));
|
||||
}
|
||||
|
||||
@@ -67,12 +257,21 @@ class _NowPlayingScreenState extends ConsumerState<NowPlayingScreen> {
|
||||
// only fires on state transitions and would leave the bar frozen
|
||||
// between them.
|
||||
final pos = ref.watch(positionProvider).value ?? Duration.zero;
|
||||
final dur = media.duration ?? Duration.zero;
|
||||
final dur = displayedMedia.duration ?? Duration.zero;
|
||||
final isPlaying = playback?.playing == true;
|
||||
final shuffleOn = playback?.shuffleMode == AudioServiceShuffleMode.all;
|
||||
final repeatMode = playback?.repeatMode ?? AudioServiceRepeatMode.none;
|
||||
final actions = ref.read(playerActionsProvider);
|
||||
final albumId = (media.extras?['album_id'] as String?) ?? '';
|
||||
final albumId = (displayedMedia.extras?['album_id'] as String?) ?? '';
|
||||
|
||||
// Backdrop color: render the dominant we've already committed to
|
||||
// _displayedDominant. AnimatedContainer tweens between successive
|
||||
// values, so the only color changes the user sees are the
|
||||
// atomic-with-cover swaps from _scheduleSwap. 0.55 alpha keeps
|
||||
// the gradient present without overwhelming the title/artist
|
||||
// text below.
|
||||
final dominant = _displayedDominant ?? fs.obsidian;
|
||||
final gradientTop = dominant.withValues(alpha: 0.55);
|
||||
|
||||
return Scaffold(
|
||||
backgroundColor: fs.obsidian,
|
||||
@@ -84,7 +283,17 @@ class _NowPlayingScreenState extends ConsumerState<NowPlayingScreen> {
|
||||
onVerticalDragUpdate: _onDragUpdate,
|
||||
onVerticalDragEnd: _onDragEnd,
|
||||
behavior: HitTestBehavior.translucent,
|
||||
child: SafeArea(
|
||||
child: AnimatedContainer(
|
||||
duration: _trackChangeDuration,
|
||||
decoration: BoxDecoration(
|
||||
gradient: LinearGradient(
|
||||
begin: Alignment.topCenter,
|
||||
end: Alignment.bottomCenter,
|
||||
colors: [gradientTop, fs.obsidian],
|
||||
stops: const [0.0, 0.7],
|
||||
),
|
||||
),
|
||||
child: SafeArea(
|
||||
child: Column(
|
||||
children: [
|
||||
_TopBar(fs: fs),
|
||||
@@ -94,26 +303,46 @@ class _NowPlayingScreenState extends ConsumerState<NowPlayingScreen> {
|
||||
child: Column(
|
||||
children: [
|
||||
const Spacer(),
|
||||
_AlbumArt(media: media, albumId: albumId, fs: fs),
|
||||
// No AnimatedSwitcher: _displayedMedia only
|
||||
// advances after the preload pipeline has the
|
||||
// new cover + color ready, so a track change
|
||||
// is an atomic swap. Fading would just smear a
|
||||
// transition the user explicitly asked us not
|
||||
// to add.
|
||||
_AlbumArt(
|
||||
media: displayedMedia, albumId: albumId, fs: fs),
|
||||
const SizedBox(height: 28),
|
||||
_TitleRow(media: media, fs: fs),
|
||||
_TitleRow(media: displayedMedia, fs: fs),
|
||||
const SizedBox(height: 4),
|
||||
Text(
|
||||
media.artist ?? '',
|
||||
style: TextStyle(color: fs.ash, fontSize: 14),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
Column(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Text(
|
||||
displayedMedia.artist ?? '',
|
||||
style: TextStyle(color: fs.ash, fontSize: 14),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
if ((displayedMedia.album ?? '').isNotEmpty) ...[
|
||||
const SizedBox(height: 2),
|
||||
Text(
|
||||
displayedMedia.album!,
|
||||
style: TextStyle(color: fs.ash, fontSize: 12),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
],
|
||||
],
|
||||
),
|
||||
if ((media.album ?? '').isNotEmpty) ...[
|
||||
const SizedBox(height: 2),
|
||||
Text(
|
||||
media.album!,
|
||||
style: TextStyle(color: fs.ash, fontSize: 12),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
],
|
||||
const SizedBox(height: 32),
|
||||
const SizedBox(height: 24),
|
||||
_SecondaryControls(
|
||||
fs: fs,
|
||||
actions: actions,
|
||||
shuffleOn: shuffleOn,
|
||||
repeatMode: repeatMode,
|
||||
media: displayedMedia,
|
||||
),
|
||||
const SizedBox(height: 8),
|
||||
_SeekRow(position: pos, duration: dur, fs: fs, ref: ref),
|
||||
const SizedBox(height: 24),
|
||||
_PrimaryControls(
|
||||
@@ -122,19 +351,13 @@ class _NowPlayingScreenState extends ConsumerState<NowPlayingScreen> {
|
||||
isPlaying: isPlaying,
|
||||
),
|
||||
const SizedBox(height: 24),
|
||||
_SecondaryControls(
|
||||
fs: fs,
|
||||
actions: actions,
|
||||
shuffleOn: shuffleOn,
|
||||
repeatMode: repeatMode,
|
||||
),
|
||||
const SizedBox(height: 24),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -203,9 +426,18 @@ class _AlbumArt extends StatelessWidget {
|
||||
aspectRatio: 1,
|
||||
child: ConstrainedBox(
|
||||
constraints: const BoxConstraints(maxWidth: 320, maxHeight: 320),
|
||||
child: ClipRRect(
|
||||
borderRadius: BorderRadius.circular(8),
|
||||
child: cover,
|
||||
child: Hero(
|
||||
tag: kPlayerCoverHeroTag,
|
||||
// flightShuttleBuilder ensures the in-flight Hero renders the
|
||||
// destination's cover image (not the mini bar's small one)
|
||||
// during the entire animation, which reads as a smooth grow
|
||||
// rather than a swap mid-flight.
|
||||
flightShuttleBuilder:
|
||||
(_, __, ___, ____, toHeroContext) => toHeroContext.widget,
|
||||
child: ClipRRect(
|
||||
borderRadius: BorderRadius.circular(8),
|
||||
child: cover,
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
@@ -219,48 +451,14 @@ class _TitleRow extends StatelessWidget {
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
// Stack: title centered absolutely in the row; like + kebab pinned
|
||||
// to the right edge. Padding on the title equals the actions' width
|
||||
// so it stays optically centered without colliding with them.
|
||||
return SizedBox(
|
||||
height: 32,
|
||||
child: Stack(
|
||||
alignment: Alignment.center,
|
||||
children: [
|
||||
Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 64),
|
||||
child: Text(
|
||||
media.title,
|
||||
style: TextStyle(color: fs.parchment, fontSize: 22),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
textAlign: TextAlign.center,
|
||||
),
|
||||
),
|
||||
Positioned(
|
||||
right: 0,
|
||||
child: Row(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
LikeButton(kind: LikeKind.track, id: media.id, size: 22),
|
||||
TrackActionsButton(
|
||||
track: TrackRef(
|
||||
id: media.id,
|
||||
title: media.title,
|
||||
albumId: (media.extras?['album_id'] as String?) ?? '',
|
||||
albumTitle: media.album ?? '',
|
||||
artistId: (media.extras?['artist_id'] as String?) ?? '',
|
||||
artistName: media.artist ?? '',
|
||||
durationSec: media.duration?.inSeconds ?? 0,
|
||||
streamUrl: '',
|
||||
),
|
||||
hideQueueActions: true,
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
// Title-only — like + kebab moved into _SecondaryControls above
|
||||
// the seek bar so they share the same row as shuffle/repeat/queue.
|
||||
return Text(
|
||||
media.title,
|
||||
style: TextStyle(color: fs.parchment, fontSize: 22),
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
textAlign: TextAlign.center,
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -365,17 +563,23 @@ class _PrimaryControls extends StatelessWidget {
|
||||
}
|
||||
}
|
||||
|
||||
/// Action row sitting just above the seek bar. Holds shuffle / repeat
|
||||
/// / queue plus the like + kebab that used to live in the title row,
|
||||
/// so the title can sit truly centered above and this row carries
|
||||
/// every per-track action in one place.
|
||||
class _SecondaryControls extends StatelessWidget {
|
||||
const _SecondaryControls({
|
||||
required this.fs,
|
||||
required this.actions,
|
||||
required this.shuffleOn,
|
||||
required this.repeatMode,
|
||||
required this.media,
|
||||
});
|
||||
final FabledSwordTheme fs;
|
||||
final PlayerActions actions;
|
||||
final bool shuffleOn;
|
||||
final AudioServiceRepeatMode repeatMode;
|
||||
final MediaItem media;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
@@ -411,6 +615,31 @@ class _SecondaryControls extends StatelessWidget {
|
||||
icon: Icon(Icons.queue_music, color: fs.ash),
|
||||
onPressed: () => GoRouter.of(context).push('/queue'),
|
||||
),
|
||||
LikeButton(kind: LikeKind.track, id: media.id, size: 22),
|
||||
TrackActionsButton(
|
||||
track: TrackRef(
|
||||
id: media.id,
|
||||
title: media.title,
|
||||
albumId: (media.extras?['album_id'] as String?) ?? '',
|
||||
albumTitle: media.album ?? '',
|
||||
artistId: (media.extras?['artist_id'] as String?) ?? '',
|
||||
artistName: media.artist ?? '',
|
||||
durationSec: media.duration?.inSeconds ?? 0,
|
||||
streamUrl: '',
|
||||
),
|
||||
hideQueueActions: true,
|
||||
// /now-playing lives outside the ShellRoute. Pushing
|
||||
// /artists/:id or /albums/:id (both shell-children) on top
|
||||
// of it would make go_router try to mount a duplicate
|
||||
// ShellRoute (the same _debugCheckDuplicatedPageKeys crash
|
||||
// we hit before with /queue). Await our own pop fully
|
||||
// before pushing the destination so go_router never sees
|
||||
// both pages active in the same frame.
|
||||
onNavigate: (path) async {
|
||||
await Navigator.of(context).maybePop();
|
||||
if (context.mounted) GoRouter.of(context).push(path);
|
||||
},
|
||||
),
|
||||
],
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
import 'dart:io';
|
||||
|
||||
import 'package:audio_service/audio_service.dart';
|
||||
import 'package:cached_network_image/cached_network_image.dart';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:go_router/go_router.dart';
|
||||
@@ -10,6 +11,7 @@ import '../likes/like_button.dart';
|
||||
import '../models/track.dart';
|
||||
import '../shared/widgets/track_actions/track_actions_button.dart';
|
||||
import '../theme/theme_extension.dart';
|
||||
import 'now_playing_screen.dart' show kPlayerCoverHeroTag;
|
||||
import 'player_provider.dart';
|
||||
|
||||
/// Compact player bar mounted at the bottom of the app shell. Mini
|
||||
@@ -26,16 +28,37 @@ import 'player_provider.dart';
|
||||
/// Tap anywhere on the bar (including art/title) ascends to the full
|
||||
/// player. A vertical drag upward also ascends, so the gesture mirrors
|
||||
/// the drag-down dismissal on the full screen.
|
||||
class PlayerBar extends ConsumerWidget {
|
||||
class PlayerBar extends ConsumerStatefulWidget {
|
||||
const PlayerBar({super.key});
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
ConsumerState<PlayerBar> createState() => _PlayerBarState();
|
||||
}
|
||||
|
||||
class _PlayerBarState extends ConsumerState<PlayerBar> {
|
||||
/// Last non-null artUri we've seen from the mediaItem stream. Held
|
||||
/// across the audio_handler's two-broadcast track-change pattern
|
||||
/// (bare MediaItem first, then with artUri once AlbumCoverCache
|
||||
/// resolves) so the mini bar keeps showing the previous track's
|
||||
/// cover until the new one is known. Without this hold the bar
|
||||
/// flickered to the slate placeholder for ~100ms on every track
|
||||
/// change.
|
||||
Uri? _lastArtUri;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final media = ref.watch(mediaItemProvider).value;
|
||||
final playback = ref.watch(playbackStateProvider).value;
|
||||
if (media == null) return const SizedBox.shrink();
|
||||
|
||||
// Capture the latest non-null artUri so _TrackInfo's cover stays
|
||||
// continuous across track changes.
|
||||
if (media.artUri != null) _lastArtUri = media.artUri;
|
||||
final displayMedia = media.artUri == null && _lastArtUri != null
|
||||
? media.copyWith(artUri: _lastArtUri)
|
||||
: media;
|
||||
|
||||
// positionProvider is just_audio's positionStream (~200ms cadence)
|
||||
// so the mini bar's seek crawls forward smoothly. PlaybackState
|
||||
// only updates on event transitions and would leave it frozen.
|
||||
@@ -63,7 +86,7 @@ class PlayerBar extends ConsumerWidget {
|
||||
child: Row(
|
||||
crossAxisAlignment: CrossAxisAlignment.center,
|
||||
children: [
|
||||
Expanded(child: _TrackInfo(media: media)),
|
||||
Expanded(child: _TrackInfo(media: displayMedia)),
|
||||
const SizedBox(width: 8),
|
||||
_PlayControls(playback: playback, ref: ref),
|
||||
],
|
||||
@@ -88,29 +111,56 @@ class _TrackInfo extends StatelessWidget {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final artistName = (media.artist ?? '').trim();
|
||||
|
||||
// Cover is wrapped in a Hero with the shared kPlayerCoverHeroTag so
|
||||
// tapping the mini bar to expand into NowPlayingScreen animates the
|
||||
// artwork from this 48dp footprint to the full-screen size rather
|
||||
// than fade-cutting. Tag is stable per-route (not keyed by media.id)
|
||||
// so the transition works regardless of what's playing.
|
||||
//
|
||||
// Why no transition / placeholder handling: the audio_handler
|
||||
// broadcasts MediaItem twice on track change — once with artUri
|
||||
// null (the new track's bare metadata), then with artUri set once
|
||||
// AlbumCoverCache resolves. The widget tree above hands us the
|
||||
// most-recent non-null artUri (`displayArtUri`), so the previous
|
||||
// track's cover stays visible across that null gap and the new
|
||||
// cover snaps in the moment its artUri arrives. Rapid change is
|
||||
// fine here per operator preference; AnimatedSwitcher previously
|
||||
// smeared the swap and made the slate placeholder visible.
|
||||
final displayArtUri = media.artUri;
|
||||
final Widget cover;
|
||||
if (displayArtUri != null) {
|
||||
// CachedNetworkImageProvider for HTTPS art URIs so the mini bar
|
||||
// hits the same disk cache the rest of the UI uses (ServerImage,
|
||||
// discover thumbnails). FileImage stays for the file:// branch
|
||||
// populated by AlbumCoverCache — bytes are already on disk and a
|
||||
// second cache layer would only burn duplicate space.
|
||||
cover = Image(
|
||||
image: displayArtUri.isScheme('file')
|
||||
? FileImage(File.fromUri(displayArtUri)) as ImageProvider
|
||||
: CachedNetworkImageProvider(displayArtUri.toString()),
|
||||
width: 48,
|
||||
height: 48,
|
||||
// Without a fit, Image paints the source at its intrinsic
|
||||
// resolution inside the 48dp box — a thumbnail-sized cover
|
||||
// would render as a tiny inset. Cover stretches/crops to fill
|
||||
// the box uniformly.
|
||||
fit: BoxFit.cover,
|
||||
errorBuilder: (_, __, ___) =>
|
||||
Container(width: 48, height: 48, color: fs.slate),
|
||||
);
|
||||
} else {
|
||||
cover = Container(width: 48, height: 48, color: fs.slate);
|
||||
}
|
||||
return Row(
|
||||
// Default centering vertically aligns the like/kebab buttons
|
||||
// against the album art (48dp) — visually they span the title +
|
||||
// artist block instead of sitting on the title baseline.
|
||||
crossAxisAlignment: CrossAxisAlignment.center,
|
||||
children: [
|
||||
if (media.artUri != null)
|
||||
Image(
|
||||
image: media.artUri!.isScheme('file')
|
||||
? FileImage(File.fromUri(media.artUri!)) as ImageProvider
|
||||
: NetworkImage(media.artUri.toString()),
|
||||
width: 48,
|
||||
height: 48,
|
||||
// Without a fit, Image paints the source at its intrinsic
|
||||
// resolution inside the 48dp box — a thumbnail-sized cover
|
||||
// would render as a tiny inset. Cover stretches/crops to
|
||||
// fill the box uniformly.
|
||||
fit: BoxFit.cover,
|
||||
errorBuilder: (_, __, ___) =>
|
||||
Container(width: 48, height: 48, color: fs.slate),
|
||||
)
|
||||
else
|
||||
Container(width: 48, height: 48, color: fs.slate),
|
||||
Hero(
|
||||
tag: kPlayerCoverHeroTag,
|
||||
child: cover,
|
||||
),
|
||||
const SizedBox(width: 12),
|
||||
Expanded(
|
||||
child: Column(
|
||||
|
||||
@@ -1,10 +1,12 @@
|
||||
import 'package:audio_service/audio_service.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../api/endpoints/likes.dart' show LikeKind;
|
||||
import '../api/endpoints/radio.dart';
|
||||
import '../auth/auth_provider.dart';
|
||||
import '../cache/audio_cache_manager.dart';
|
||||
import '../library/library_providers.dart' show dioProvider;
|
||||
import '../likes/likes_provider.dart';
|
||||
import '../models/track.dart';
|
||||
import 'album_cover_cache.dart';
|
||||
import 'audio_handler.dart';
|
||||
@@ -49,7 +51,18 @@ final positionProvider = StreamProvider<Duration>(
|
||||
);
|
||||
|
||||
class PlayerActions {
|
||||
PlayerActions(this._ref);
|
||||
PlayerActions(this._ref) {
|
||||
// Keep MediaItem.rating in sync with the drift-backed likedIds
|
||||
// cache so external media surfaces (Wear's heart button, lock-
|
||||
// screen favorite, Auto's like icon) reflect the current state
|
||||
// even when the user toggles a like from somewhere other than
|
||||
// the watch itself — e.g. tapping the heart on a TrackRow, the
|
||||
// kebab menu, or another logged-in device propagating via SSE.
|
||||
_ref.listen<AsyncValue<LikedIds>>(likedIdsProvider, (_, next) {
|
||||
if (next.value == null) return;
|
||||
_ref.read(audioHandlerProvider).refreshCurrentRating();
|
||||
});
|
||||
}
|
||||
final Ref _ref;
|
||||
|
||||
Future<void> playTracks(List<TrackRef> tracks, {int initialIndex = 0}) async {
|
||||
@@ -63,11 +76,28 @@ class PlayerActions {
|
||||
token: token,
|
||||
coverCache: cache,
|
||||
audioCacheManager: audioCache,
|
||||
likeBridge: _buildLikeBridge(),
|
||||
);
|
||||
await h.setQueueFromTracks(tracks, initialIndex: initialIndex);
|
||||
await h.play();
|
||||
}
|
||||
|
||||
/// Builds the adapter the audio handler uses to read + flip the
|
||||
/// current track's like state in response to external media-
|
||||
/// controller events (Wear's heart button, lock-screen favorite).
|
||||
/// Constructed here because the audio handler is initialized in
|
||||
/// main.dart before the ProviderScope exists; passing the bridge
|
||||
/// in via configure() keeps the handler Riverpod-agnostic while
|
||||
/// still letting it call into LikesController + likedIdsProvider.
|
||||
LikeBridge _buildLikeBridge() {
|
||||
return LikeBridge(
|
||||
toggleTrackLike: (id) =>
|
||||
_ref.read(likesControllerProvider).toggle(LikeKind.track, id),
|
||||
isTrackLiked: (id) =>
|
||||
_ref.read(likedIdsProvider).value?.has(LikeKind.track, id) ?? false,
|
||||
);
|
||||
}
|
||||
|
||||
Future<void> playNext(TrackRef track) async {
|
||||
final h = _ref.read(audioHandlerProvider);
|
||||
await h.playNext(track);
|
||||
|
||||
@@ -7,18 +7,49 @@ import '../cache/db.dart';
|
||||
import '../models/playlist.dart';
|
||||
import '../models/track.dart';
|
||||
import '../player/player_provider.dart';
|
||||
import '../shared/live_events_provider.dart';
|
||||
import '../shared/widgets/track_actions/track_actions_button.dart';
|
||||
import '../theme/theme_extension.dart';
|
||||
import 'playlists_provider.dart';
|
||||
|
||||
class PlaylistDetailScreen extends ConsumerWidget {
|
||||
const PlaylistDetailScreen({required this.id, super.key});
|
||||
const PlaylistDetailScreen({required this.id, this.seed, super.key});
|
||||
final String id;
|
||||
|
||||
/// Optional Playlist passed via go_router extra so the header
|
||||
/// (title, cover, track count, play/download CTAs) can render
|
||||
/// before the full detail fetch resolves. Same pattern as album
|
||||
/// + artist nav hydration.
|
||||
final Playlist? seed;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
// #402 wire-up: invalidate the detail provider on playlist.updated /
|
||||
// .tracks_changed events whose payload matches the visible id. On
|
||||
// .deleted matching this id, navigate back so the user isn't left
|
||||
// staring at a gone-from-server playlist.
|
||||
ref.listen<AsyncValue<LiveEvent>>(liveEventsProvider, (_, next) {
|
||||
final e = next.asData?.value;
|
||||
if (e == null) return;
|
||||
final eventPlaylistId = e.data['playlist_id'] as String?;
|
||||
if (eventPlaylistId != id) return;
|
||||
switch (e.kind) {
|
||||
case 'playlist.updated':
|
||||
case 'playlist.tracks_changed':
|
||||
ref.invalidate(playlistDetailProvider(id));
|
||||
case 'playlist.deleted':
|
||||
if (context.mounted) context.pop();
|
||||
}
|
||||
});
|
||||
final detail = ref.watch(playlistDetailProvider(id));
|
||||
|
||||
// Resolve the best playlist info available for the AppBar title.
|
||||
final livePlaylist = detail.value?.playlist;
|
||||
final headerName = (livePlaylist != null && livePlaylist.name.isNotEmpty)
|
||||
? livePlaylist.name
|
||||
: (seed?.name ?? '');
|
||||
|
||||
return Scaffold(
|
||||
backgroundColor: fs.obsidian,
|
||||
appBar: AppBar(
|
||||
@@ -28,27 +59,118 @@ class PlaylistDetailScreen extends ConsumerWidget {
|
||||
icon: Icon(Icons.arrow_back, color: fs.parchment),
|
||||
onPressed: () => context.pop(),
|
||||
),
|
||||
title: detail.maybeWhen(
|
||||
data: (d) => Text(
|
||||
d.playlist.name,
|
||||
style: TextStyle(color: fs.parchment),
|
||||
overflow: TextOverflow.ellipsis,
|
||||
title: headerName.isEmpty
|
||||
? const SizedBox.shrink()
|
||||
: Text(
|
||||
headerName,
|
||||
style: TextStyle(color: fs.parchment),
|
||||
overflow: TextOverflow.ellipsis,
|
||||
),
|
||||
),
|
||||
// AnimatedSwitcher between the skeleton body and the real body
|
||||
// smooths the cold-visit moment when bulk detail lands. 220ms
|
||||
// matches the per-tile reveal feel used on home / liked tabs.
|
||||
body: AnimatedSwitcher(
|
||||
duration: const Duration(milliseconds: 220),
|
||||
switchInCurve: Curves.easeOut,
|
||||
child: detail.when(
|
||||
loading: () => _SkeletonBody(
|
||||
key: const ValueKey('skeleton'),
|
||||
seed: seed,
|
||||
),
|
||||
orElse: () => const SizedBox.shrink(),
|
||||
error: (e, _) => Center(
|
||||
key: const ValueKey('error'),
|
||||
child: Text('$e', style: TextStyle(color: fs.error)),
|
||||
),
|
||||
data: (d) => _Body(key: const ValueKey('body'), detail: d),
|
||||
),
|
||||
),
|
||||
body: detail.when(
|
||||
loading: () => const Center(child: CircularProgressIndicator()),
|
||||
error: (e, _) =>
|
||||
Center(child: Text('$e', style: TextStyle(color: fs.error))),
|
||||
data: (d) => _Body(detail: d),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Cold-visit body: header from the seed (if any) + N skeleton rows.
|
||||
/// N comes from the seed's trackCount so the row count matches the
|
||||
/// real list when it lands — no layout jump on swap. Without a seed
|
||||
/// (deep link straight to a playlist with no prior cache) the
|
||||
/// skeleton renders a small default and grows when real data arrives.
|
||||
class _SkeletonBody extends StatelessWidget {
|
||||
const _SkeletonBody({super.key, this.seed});
|
||||
final Playlist? seed;
|
||||
|
||||
static const _defaultSkeletonCount = 8;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final count = seed?.trackCount ?? _defaultSkeletonCount;
|
||||
return ListView.builder(
|
||||
itemCount: count + 1, // +1 for header
|
||||
itemBuilder: (ctx, i) {
|
||||
if (i == 0) {
|
||||
return Padding(
|
||||
padding: const EdgeInsets.fromLTRB(16, 8, 16, 16),
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
if (seed != null && seed!.description.isNotEmpty)
|
||||
Padding(
|
||||
padding: const EdgeInsets.only(bottom: 12),
|
||||
child: Text(
|
||||
seed!.description,
|
||||
style: TextStyle(color: fs.ash, fontSize: 13),
|
||||
),
|
||||
),
|
||||
Text(
|
||||
seed == null
|
||||
? 'Loading…'
|
||||
: '${seed!.trackCount} ${seed!.trackCount == 1 ? "track" : "tracks"}',
|
||||
style: TextStyle(color: fs.ash, fontSize: 12),
|
||||
),
|
||||
],
|
||||
),
|
||||
);
|
||||
}
|
||||
return const _PlaylistTrackSkeleton();
|
||||
},
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Skeleton matched to _PlaylistTrackRow's layout (no cover image —
|
||||
/// playlist rows are text-only). Two text-shaped placeholders for
|
||||
/// title + secondary line, plus a duration block on the right.
|
||||
class _PlaylistTrackSkeleton extends StatelessWidget {
|
||||
const _PlaylistTrackSkeleton();
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
return Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 10),
|
||||
child: Row(
|
||||
children: [
|
||||
Expanded(
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Container(width: 200, height: 14, color: fs.slate),
|
||||
const SizedBox(height: 6),
|
||||
Container(width: 140, height: 12, color: fs.slate),
|
||||
],
|
||||
),
|
||||
),
|
||||
const SizedBox(width: 16),
|
||||
Container(width: 32, height: 12, color: fs.slate),
|
||||
],
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
class _Body extends ConsumerWidget {
|
||||
const _Body({required this.detail});
|
||||
const _Body({super.key, required this.detail});
|
||||
final PlaylistDetail detail;
|
||||
|
||||
@override
|
||||
@@ -179,51 +301,69 @@ class _Header extends ConsumerWidget {
|
||||
}
|
||||
}
|
||||
|
||||
class _PlaylistTrackRow extends StatelessWidget {
|
||||
class _PlaylistTrackRow extends ConsumerWidget {
|
||||
const _PlaylistTrackRow({required this.row, required this.onTap});
|
||||
final PlaylistTrack row;
|
||||
final VoidCallback? onTap;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final mins = (row.durationSec ~/ 60).toString().padLeft(2, '0');
|
||||
final secs = (row.durationSec % 60).toString().padLeft(2, '0');
|
||||
final color = row.isAvailable ? fs.parchment : fs.ash;
|
||||
return InkWell(
|
||||
onTap: onTap,
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 10),
|
||||
child: Row(children: [
|
||||
Expanded(
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
Text(
|
||||
row.title,
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
style: TextStyle(
|
||||
color: color,
|
||||
fontSize: 14,
|
||||
decoration: row.isAvailable
|
||||
? null
|
||||
: TextDecoration.lineThrough,
|
||||
// "Now playing" highlight — matches _QueueRow and TrackRow so the
|
||||
// user sees which playlist row is current without reading the
|
||||
// player bar. Unavailable rows never match.
|
||||
final currentId = ref.watch(mediaItemProvider).value?.id;
|
||||
final isCurrent = row.isAvailable &&
|
||||
currentId != null &&
|
||||
currentId == row.trackId;
|
||||
final baseColor = row.isAvailable ? fs.parchment : fs.ash;
|
||||
final titleColor = isCurrent ? fs.accent : baseColor;
|
||||
return Container(
|
||||
decoration: BoxDecoration(
|
||||
color: isCurrent ? fs.iron : null,
|
||||
border: isCurrent
|
||||
? Border(left: BorderSide(color: fs.accent, width: 2))
|
||||
: null,
|
||||
),
|
||||
child: InkWell(
|
||||
onTap: onTap,
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 10),
|
||||
child: Row(children: [
|
||||
Expanded(
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
children: [
|
||||
Text(
|
||||
row.title,
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
style: TextStyle(
|
||||
color: titleColor,
|
||||
fontSize: 14,
|
||||
fontWeight:
|
||||
isCurrent ? FontWeight.w500 : FontWeight.w400,
|
||||
decoration: row.isAvailable
|
||||
? null
|
||||
: TextDecoration.lineThrough,
|
||||
),
|
||||
),
|
||||
),
|
||||
Text(
|
||||
'${row.artistName} · ${row.albumTitle}',
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
style: TextStyle(color: fs.ash, fontSize: 12),
|
||||
),
|
||||
],
|
||||
Text(
|
||||
'${row.artistName} · ${row.albumTitle}',
|
||||
maxLines: 1,
|
||||
overflow: TextOverflow.ellipsis,
|
||||
style: TextStyle(color: fs.ash, fontSize: 12),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
Text('$mins:$secs', style: TextStyle(color: fs.ash, fontSize: 12)),
|
||||
if (row.trackId != null)
|
||||
TrackActionsButton(track: _toTrackRef(row)),
|
||||
]),
|
||||
Text('$mins:$secs', style: TextStyle(color: fs.ash, fontSize: 12)),
|
||||
if (row.trackId != null)
|
||||
TrackActionsButton(track: _toTrackRef(row)),
|
||||
]),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -51,7 +51,7 @@ class PlaylistsListScreen extends ConsumerWidget {
|
||||
final p = items[i];
|
||||
return _PlaylistTile(
|
||||
playlist: p,
|
||||
onTap: () => ctx.push('/playlists/${p.id}'),
|
||||
onTap: () => ctx.push('/playlists/${p.id}', extra: p),
|
||||
);
|
||||
},
|
||||
),
|
||||
@@ -83,7 +83,11 @@ class _PlaylistTile extends StatelessWidget {
|
||||
color: fs.slate,
|
||||
child: playlist.coverUrl.isEmpty
|
||||
? Icon(Icons.queue_music, color: fs.ash)
|
||||
: ServerImage(url: playlist.coverUrl, fit: BoxFit.cover),
|
||||
: ServerImage(
|
||||
url: playlist.coverUrl,
|
||||
fit: BoxFit.cover,
|
||||
fallback: Icon(Icons.queue_music, color: fs.ash),
|
||||
),
|
||||
),
|
||||
),
|
||||
const SizedBox(width: 12),
|
||||
|
||||
@@ -1,5 +1,7 @@
|
||||
import 'dart:async';
|
||||
import 'dart:convert';
|
||||
|
||||
import 'package:dio/dio.dart';
|
||||
import 'package:drift/drift.dart' as drift;
|
||||
import 'package:flutter/foundation.dart' show debugPrint;
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
@@ -39,12 +41,21 @@ final playlistsListProvider =
|
||||
fetchAndPopulate: () async {
|
||||
final api = await ref.read(playlistsApiProvider.future);
|
||||
final fresh = await api.list(kind: kind);
|
||||
final ownedSysCount =
|
||||
fresh.owned.where((p) => p.systemVariant != null).length;
|
||||
debugPrint(
|
||||
'playlistsListProvider($kind): wire returned owned=${fresh.owned.length} '
|
||||
'(system=$ownedSysCount) public=${fresh.public.length}');
|
||||
|
||||
// Reconcile: BuildSystemPlaylists rotates system-playlist UUIDs
|
||||
// every rebuild, so insertOrReplace alone leaves stale rows in
|
||||
// drift. Tapping one of those stale tiles 404s. Delete every
|
||||
// owned drift row whose id isn't in the fresh response, then
|
||||
// upsert the fresh set.
|
||||
final freshOwnedIds =
|
||||
fresh.owned.map((p) => p.id).toSet();
|
||||
await db.batch((b) {
|
||||
if (user != null) {
|
||||
b.deleteWhere(db.cachedPlaylists, (t) {
|
||||
return t.userId.equals(user.id) &
|
||||
t.id.isNotIn(freshOwnedIds);
|
||||
});
|
||||
}
|
||||
for (final p in fresh.all) {
|
||||
b.insert(db.cachedPlaylists, p.toDrift(),
|
||||
mode: drift.InsertMode.insertOrReplace);
|
||||
@@ -66,13 +77,6 @@ final playlistsListProvider =
|
||||
.where((r) => r.userId != user.id && r.isPublic)
|
||||
.map((r) => r.toRef())
|
||||
.toList();
|
||||
final ownedSys = owned.where((p) => p.isSystem).length;
|
||||
final driftSys = filtered.where((r) => r.systemVariant != null).length;
|
||||
debugPrint(
|
||||
'playlistsListProvider($kind): drift rows=${rows.length} '
|
||||
'filtered=${filtered.length} (system=$driftSys) '
|
||||
'owned=${owned.length} (system=$ownedSys) pub=${pub.length} '
|
||||
'userId=${user.id}');
|
||||
return PlaylistsList(owned: owned, public: pub);
|
||||
},
|
||||
isOnline: () async => (await ref
|
||||
@@ -138,18 +142,31 @@ final playlistDetailProvider =
|
||||
Future<bool> fetchAndPopulate() async {
|
||||
try {
|
||||
final api = await ref.read(playlistsApiProvider.future);
|
||||
debugPrint('playlistDetailProvider($id): calling get');
|
||||
final fresh = await api.get(id).timeout(const Duration(seconds: 10));
|
||||
debugPrint(
|
||||
'playlistDetailProvider($id): got ${fresh.tracks.length} tracks, writing');
|
||||
|
||||
// Collect the artist + album rows referenced by these tracks so
|
||||
// the JOINs that build artistName/albumTitle in the row view
|
||||
// have something to bind to. Without this, system-playlist tracks
|
||||
// surface with empty artist/album columns.
|
||||
// Collect the track + artist + album rows referenced by these
|
||||
// playlist entries. Without writing the cachedTracks rows
|
||||
// themselves, the detail-screen JOIN against cachedTracks
|
||||
// returns null on every row (only the playlist_tracks join
|
||||
// succeeds), so the UI shows a list with empty titles and
|
||||
// unplayable tracks.
|
||||
final tracks = <String, _TrackRefRow>{};
|
||||
final artists = <String, ArtistRefRow>{};
|
||||
final albums = <String, AlbumRefRow>{};
|
||||
for (final t in fresh.tracks) {
|
||||
final tId = t.trackId;
|
||||
if (tId != null && tId.isNotEmpty) {
|
||||
tracks.putIfAbsent(
|
||||
tId,
|
||||
() => _TrackRefRow(
|
||||
id: tId,
|
||||
title: t.title,
|
||||
albumId: t.albumId ?? '',
|
||||
artistId: t.artistId ?? '',
|
||||
durationSec: t.durationSec,
|
||||
),
|
||||
);
|
||||
}
|
||||
final aId = t.artistId;
|
||||
final aName = t.artistName;
|
||||
if (aId != null && aId.isNotEmpty && aName.isNotEmpty) {
|
||||
@@ -198,6 +215,25 @@ final playlistDetailProvider =
|
||||
.toList(),
|
||||
);
|
||||
}
|
||||
if (tracks.isNotEmpty) {
|
||||
// Insert/update cachedTracks so the detail screen's JOIN
|
||||
// produces real titles + durations. We don't have
|
||||
// track_number / disc_number on the wire (PlaylistTrack
|
||||
// omits them), so they default to 0 — UI doesn't surface
|
||||
// them on this screen so it's fine.
|
||||
b.insertAllOnConflictUpdate(
|
||||
db.cachedTracks,
|
||||
tracks.values
|
||||
.map((t) => CachedTracksCompanion.insert(
|
||||
id: t.id,
|
||||
albumId: t.albumId,
|
||||
artistId: t.artistId,
|
||||
title: t.title,
|
||||
durationMs: drift.Value(t.durationSec * 1000),
|
||||
))
|
||||
.toList(),
|
||||
);
|
||||
}
|
||||
if (albums.isNotEmpty) {
|
||||
b.insertAllOnConflictUpdate(
|
||||
db.cachedAlbums,
|
||||
@@ -212,10 +248,21 @@ final playlistDetailProvider =
|
||||
);
|
||||
}
|
||||
});
|
||||
debugPrint(
|
||||
'playlistDetailProvider($id): drift write done; awaiting watch re-emit');
|
||||
return true;
|
||||
} catch (e, st) {
|
||||
// 404 = the playlist row in drift is stale (BuildSystemPlaylists
|
||||
// rotates UUIDs on each rebuild, so old For-You / Songs-Like
|
||||
// tiles can outlive the actual server-side playlist). Wipe the
|
||||
// stale row + its track positions so the home tile disappears
|
||||
// on next render and we don't keep trying.
|
||||
if (e is DioException && e.response?.statusCode == 404) {
|
||||
await db.batch((b) {
|
||||
b.deleteWhere(
|
||||
db.cachedPlaylistTracks, (t) => t.playlistId.equals(id));
|
||||
b.deleteWhere(db.cachedPlaylists, (t) => t.id.equals(id));
|
||||
});
|
||||
return false;
|
||||
}
|
||||
debugPrint('playlistDetailProvider($id): fetch failed: $e\n$st');
|
||||
return false;
|
||||
}
|
||||
@@ -224,11 +271,9 @@ final playlistDetailProvider =
|
||||
// Once-per-subscription guard so an empty server response doesn't
|
||||
// cause repeated re-fetches.
|
||||
var fetchAttempted = false;
|
||||
var revalidated = false;
|
||||
|
||||
await for (final playlistRows in playlistQuery.watch()) {
|
||||
if (playlistRows.isEmpty) {
|
||||
debugPrint('playlistDetailProvider($id): drift miss, cold-fetching');
|
||||
if (fetchAttempted) {
|
||||
yield emptyDetail();
|
||||
continue;
|
||||
@@ -243,9 +288,6 @@ final playlistDetailProvider =
|
||||
continue;
|
||||
}
|
||||
|
||||
debugPrint(
|
||||
'playlistDetailProvider($id): drift hit (${playlistRows.length} rows)');
|
||||
|
||||
final playlist = playlistRows.first.toRef();
|
||||
final trackRows = await tracksQuery.get();
|
||||
|
||||
@@ -254,8 +296,6 @@ final playlistDetailProvider =
|
||||
// tracks for system playlists). Trigger the same fetch, drift
|
||||
// watch re-emits with populated tracks.
|
||||
if (trackRows.isEmpty && !fetchAttempted) {
|
||||
debugPrint(
|
||||
'playlistDetailProvider($id): playlist hit but no tracks; fetching');
|
||||
fetchAttempted = true;
|
||||
if (await isOnline()) {
|
||||
final ok = await fetchAndPopulate();
|
||||
@@ -283,13 +323,12 @@ final playlistDetailProvider =
|
||||
|
||||
yield PlaylistDetail(playlist: playlist, tracks: tracks);
|
||||
|
||||
// SWR: first complete cache hit kicks one background refresh.
|
||||
if (!revalidated && trackRows.isNotEmpty) {
|
||||
revalidated = true;
|
||||
if (await isOnline()) {
|
||||
unawaited(fetchAndPopulate());
|
||||
}
|
||||
}
|
||||
// No SWR refresh here. The aggregate playlistsListProvider does
|
||||
// alwaysRefresh (system playlists rotate UUIDs), but per-detail
|
||||
// refresh on every visit was multiplying with the prefetcher's
|
||||
// parallel fetches and starving user-initiated playback. Pull-
|
||||
// to-refresh on the detail page invalidates the provider, which
|
||||
// is the right path for an explicit refresh.
|
||||
}
|
||||
});
|
||||
|
||||
@@ -309,8 +348,56 @@ class AlbumRefRow {
|
||||
final String artistId;
|
||||
}
|
||||
|
||||
class _TrackRefRow {
|
||||
_TrackRefRow({
|
||||
required this.id,
|
||||
required this.title,
|
||||
required this.albumId,
|
||||
required this.artistId,
|
||||
required this.durationSec,
|
||||
});
|
||||
final String id;
|
||||
final String title;
|
||||
final String albumId;
|
||||
final String artistId;
|
||||
final int durationSec;
|
||||
}
|
||||
|
||||
/// Drift-first per #357 pattern. Reads from cached_system_playlists_
|
||||
/// status (single-row JSON blob populated by /api/me/system-playlists-
|
||||
/// status). Home Playlists row reads this every render to choose
|
||||
/// between real cards and "building / pending / failed" placeholders
|
||||
/// — drift-first means the row paints with the prior status instantly
|
||||
/// rather than flickering through SystemPlaylistsStatus.empty() while
|
||||
/// the REST round-trip resolves. SWR refresh on every visit keeps it
|
||||
/// current.
|
||||
final systemPlaylistsStatusProvider =
|
||||
FutureProvider<SystemPlaylistsStatus>((ref) async {
|
||||
final dio = await ref.watch(dioProvider.future);
|
||||
return MeApi(dio).systemPlaylistsStatus();
|
||||
StreamProvider<SystemPlaylistsStatus>((ref) {
|
||||
final db = ref.watch(appDbProvider);
|
||||
return cacheFirst<CachedSystemPlaylistsStatusData, SystemPlaylistsStatus>(
|
||||
driftStream: db.select(db.cachedSystemPlaylistsStatus).watch(),
|
||||
fetchAndPopulate: () async {
|
||||
final dio = await ref.read(dioProvider.future);
|
||||
final fresh = await MeApi(dio).systemPlaylistsStatus();
|
||||
await db.into(db.cachedSystemPlaylistsStatus).insertOnConflictUpdate(
|
||||
CachedSystemPlaylistsStatusCompanion.insert(
|
||||
json: jsonEncode({
|
||||
'in_flight': fresh.inFlight,
|
||||
'last_run_at': fresh.lastRunAt,
|
||||
'last_error': fresh.lastError,
|
||||
}),
|
||||
updatedAt: drift.Value(DateTime.now()),
|
||||
),
|
||||
);
|
||||
},
|
||||
toResult: (rows) => rows.isEmpty
|
||||
? SystemPlaylistsStatus.empty()
|
||||
: SystemPlaylistsStatus.fromJson(
|
||||
jsonDecode(rows.first.json) as Map<String, dynamic>),
|
||||
isOnline: () async => (await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true)),
|
||||
alwaysRefresh: true,
|
||||
tag: 'systemPlaylistsStatus',
|
||||
);
|
||||
});
|
||||
|
||||
@@ -1,40 +1,72 @@
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:go_router/go_router.dart';
|
||||
|
||||
import '../../library/widgets/play_circle_button.dart';
|
||||
import '../../models/playlist.dart';
|
||||
import '../../models/track.dart';
|
||||
import '../../player/player_provider.dart';
|
||||
import '../../shared/widgets/server_image.dart';
|
||||
import '../../theme/theme_extension.dart';
|
||||
import '../playlists_provider.dart';
|
||||
|
||||
/// Mirrors the web PlaylistCard. ~176dp wide, square cover (~144dp),
|
||||
/// name + optional system-variant badge below. Tap pushes
|
||||
/// `/playlists/{id}`.
|
||||
class PlaylistCard extends StatelessWidget {
|
||||
/// `/playlists/{id}`. The bottom-right play button fetches the
|
||||
/// playlist and starts playback from track 0; disabled when the
|
||||
/// playlist has no tracks.
|
||||
class PlaylistCard extends ConsumerWidget {
|
||||
const PlaylistCard({super.key, required this.playlist});
|
||||
|
||||
final Playlist playlist;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final hasTracks = playlist.trackCount > 0;
|
||||
return SizedBox(
|
||||
width: 176,
|
||||
child: Material(
|
||||
color: Colors.transparent,
|
||||
child: InkWell(
|
||||
onTap: () => context.push('/playlists/${playlist.id}'),
|
||||
onTap: () =>
|
||||
context.push('/playlists/${playlist.id}', extra: playlist),
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8),
|
||||
child: Column(crossAxisAlignment: CrossAxisAlignment.start, children: [
|
||||
ClipRRect(
|
||||
borderRadius: BorderRadius.circular(6),
|
||||
child: Container(
|
||||
width: 144,
|
||||
height: 144,
|
||||
color: fs.slate,
|
||||
child: playlist.coverUrl.isEmpty
|
||||
? Icon(Icons.queue_music, color: fs.ash, size: 56)
|
||||
: ServerImage(url: playlist.coverUrl, fit: BoxFit.cover),
|
||||
),
|
||||
// Stack: collage + overlaid play button at bottom-right.
|
||||
Stack(
|
||||
children: [
|
||||
ClipRRect(
|
||||
borderRadius: BorderRadius.circular(6),
|
||||
child: Container(
|
||||
width: 144,
|
||||
height: 144,
|
||||
color: fs.slate,
|
||||
// coverUrl is deterministic per playlist (see
|
||||
// CachedPlaylistAdapter.toRef). When the server's
|
||||
// collage isn't built yet, ServerImage's
|
||||
// errorBuilder shows the queue_music icon over the
|
||||
// slate background.
|
||||
child: playlist.coverUrl.isEmpty
|
||||
? Icon(Icons.queue_music, color: fs.ash, size: 56)
|
||||
: ServerImage(
|
||||
url: playlist.coverUrl,
|
||||
fit: BoxFit.cover,
|
||||
fallback:
|
||||
Icon(Icons.queue_music, color: fs.ash, size: 56),
|
||||
),
|
||||
),
|
||||
),
|
||||
Positioned(
|
||||
bottom: 6,
|
||||
right: 6,
|
||||
child: PlayCircleButton(
|
||||
enabled: hasTracks,
|
||||
onPressed: () => _playPlaylist(ref),
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
const SizedBox(height: 8),
|
||||
Text(
|
||||
@@ -65,4 +97,29 @@ class PlaylistCard extends StatelessWidget {
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/// Fetches the playlist via /api/playlists/{id}, materializes each
|
||||
/// PlaylistTrack into a TrackRef (filtering out unavailable rows
|
||||
/// whose `trackId` is null after a track-delete), and plays from
|
||||
/// index 0. Mirrors the web PlaylistCard's onPlayClick.
|
||||
Future<void> _playPlaylist(WidgetRef ref) async {
|
||||
final api = await ref.read(playlistsApiProvider.future);
|
||||
final detail = await api.get(playlist.id);
|
||||
final refs = <TrackRef>[];
|
||||
for (final t in detail.tracks) {
|
||||
if (t.trackId == null) continue;
|
||||
refs.add(TrackRef(
|
||||
id: t.trackId!,
|
||||
title: t.title,
|
||||
albumId: t.albumId ?? '',
|
||||
albumTitle: t.albumTitle,
|
||||
artistId: t.artistId ?? '',
|
||||
artistName: t.artistName,
|
||||
durationSec: t.durationSec,
|
||||
streamUrl: t.streamUrl ?? '',
|
||||
));
|
||||
}
|
||||
if (refs.isEmpty) return;
|
||||
await ref.read(playerActionsProvider).playTracks(refs, initialIndex: 0);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,7 +1,14 @@
|
||||
import 'dart:async';
|
||||
|
||||
import 'package:drift/drift.dart' as drift;
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../api/endpoints/me.dart';
|
||||
import '../api/endpoints/quarantine.dart';
|
||||
import '../cache/audio_cache_manager.dart' show appDbProvider;
|
||||
import '../cache/connectivity_provider.dart';
|
||||
import '../cache/db.dart';
|
||||
import '../cache/mutation_queue.dart';
|
||||
import '../library/library_providers.dart' show dioProvider;
|
||||
import '../models/quarantine_mine.dart';
|
||||
import '../models/track.dart';
|
||||
@@ -10,58 +17,165 @@ final quarantineApiProvider = FutureProvider<QuarantineApi>((ref) async {
|
||||
return QuarantineApi(await ref.watch(dioProvider.future));
|
||||
});
|
||||
|
||||
/// Drift-first ("hidden") tab controller. Reads from cached_quarantine_
|
||||
/// mine via a drift watch() subscription set up in build(), so any drift
|
||||
/// mutation (incoming sync, optimistic flag/unflag, SSE-triggered
|
||||
/// refresh) re-emits the list automatically.
|
||||
///
|
||||
/// API surface unchanged from the prior FutureProvider-backed controller
|
||||
/// — call sites still do `ref.read(myQuarantineProvider.notifier).flag()`
|
||||
/// / `.unflag()` / `.isHidden()`. Internal storage moved from in-memory
|
||||
/// AsyncNotifier state to drift so the Hidden tab paints from disk on
|
||||
/// cold open and the quarantine list is queryable offline.
|
||||
class MyQuarantineController extends AsyncNotifier<List<QuarantineMineRow>> {
|
||||
@override
|
||||
Future<List<QuarantineMineRow>> build() async {
|
||||
final dio = await ref.watch(dioProvider.future);
|
||||
return MeApi(dio).quarantineMine();
|
||||
final db = ref.watch(appDbProvider);
|
||||
|
||||
// Subscribe to drift first so any mutation (incoming sync, flag/
|
||||
// unflag, etc.) propagates without needing a manual invalidate.
|
||||
// Disposed when the provider rebuilds or the listener detaches.
|
||||
final sub = db.select(db.cachedQuarantineMine).watch().listen((rows) {
|
||||
state = AsyncData(rows.map(_rowToModel).toList());
|
||||
});
|
||||
ref.onDispose(sub.cancel);
|
||||
|
||||
// SWR refresh on every build so the freshest server-side state
|
||||
// overtakes drift in the background. Don't await — UI gets the
|
||||
// cached snapshot first, freshness lands later via the watch().
|
||||
unawaited(_refreshFromServer());
|
||||
|
||||
final initial = await db.select(db.cachedQuarantineMine).get();
|
||||
return initial.map(_rowToModel).toList();
|
||||
}
|
||||
|
||||
/// Hits /api/quarantine/mine and replaces the local table with the
|
||||
/// authoritative server set. Best-effort: offline / 5xx / unresolved
|
||||
/// dependencies (e.g. uninitialised serverUrl in tests) all collapse
|
||||
/// to a no-op — drift stays on the prior cached state.
|
||||
Future<void> _refreshFromServer() async {
|
||||
try {
|
||||
final online = await ref
|
||||
.read(connectivityProvider.future)
|
||||
.timeout(const Duration(seconds: 3), onTimeout: () => true);
|
||||
if (!online) return;
|
||||
final dio = await ref.read(dioProvider.future);
|
||||
final fresh = await MeApi(dio).quarantineMine();
|
||||
final db = ref.read(appDbProvider);
|
||||
await db.transaction(() async {
|
||||
// Full replace — quarantine list is small and we want server
|
||||
// unflags from other devices to take effect. Doing this in a
|
||||
// transaction means the watch() sees exactly one emission with
|
||||
// the merged state, not a delete-then-insert flicker.
|
||||
await db.delete(db.cachedQuarantineMine).go();
|
||||
for (final r in fresh) {
|
||||
await db
|
||||
.into(db.cachedQuarantineMine)
|
||||
.insertOnConflictUpdate(_modelToCompanion(r));
|
||||
}
|
||||
});
|
||||
} catch (_) {
|
||||
// Swallow — cached state stays visible.
|
||||
}
|
||||
}
|
||||
|
||||
/// True when this track is in the caller's quarantine list.
|
||||
bool isHidden(String trackId) =>
|
||||
(state.value ?? const []).any((r) => r.trackId == trackId);
|
||||
|
||||
/// Optimistic flag: prepends a synthetic row, calls server,
|
||||
/// rolls back on error.
|
||||
/// Optimistic flag: inserts the synthetic row into drift (watch fires
|
||||
/// immediately so the UI updates), calls server, rolls back on error.
|
||||
Future<void> flag(TrackRef track, String reason, String notes) async {
|
||||
final api = await ref.read(quarantineApiProvider.future);
|
||||
final current = state.value ?? const <QuarantineMineRow>[];
|
||||
if (current.any((r) => r.trackId == track.id)) return; // already hidden
|
||||
final synthetic = QuarantineMineRow(
|
||||
final db = ref.read(appDbProvider);
|
||||
final existed = await (db.select(db.cachedQuarantineMine)
|
||||
..where((t) => t.trackId.equals(track.id)))
|
||||
.getSingleOrNull();
|
||||
if (existed != null) return; // already hidden
|
||||
|
||||
final companion = CachedQuarantineMineCompanion.insert(
|
||||
trackId: track.id,
|
||||
reason: reason,
|
||||
notes: notes.isEmpty ? null : notes,
|
||||
notes: notes.isEmpty
|
||||
? const drift.Value.absent()
|
||||
: drift.Value(notes),
|
||||
createdAt: DateTime.now().toUtc().toIso8601String(),
|
||||
trackTitle: track.title,
|
||||
trackDurationMs: track.durationSec * 1000,
|
||||
trackDurationMs: drift.Value(track.durationSec * 1000),
|
||||
albumId: track.albumId,
|
||||
albumTitle: track.albumTitle,
|
||||
artistId: track.artistId,
|
||||
artistName: track.artistName,
|
||||
);
|
||||
state = AsyncData([synthetic, ...current]);
|
||||
await db.into(db.cachedQuarantineMine).insertOnConflictUpdate(companion);
|
||||
|
||||
try {
|
||||
final api = await ref.read(quarantineApiProvider.future);
|
||||
await api.flag(track.id, reason, notes: notes);
|
||||
} catch (e, st) {
|
||||
state = AsyncData(current);
|
||||
Error.throwWithStackTrace(e, st);
|
||||
} catch (_) {
|
||||
// REST failed — don't roll back; queue for replay so the user's
|
||||
// "hide this track" intent persists offline.
|
||||
await ref.read(mutationQueueProvider).enqueue(
|
||||
MutationKinds.quarantineFlag,
|
||||
{'trackId': track.id, 'reason': reason, 'notes': notes},
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Optimistic unflag: removes the row, calls server, rolls back on error.
|
||||
/// Optimistic unflag: removes the drift row, calls server, queues
|
||||
/// the call on failure so the unhide intent persists offline.
|
||||
Future<void> unflag(String trackId) async {
|
||||
final api = await ref.read(quarantineApiProvider.future);
|
||||
final current = state.value ?? const <QuarantineMineRow>[];
|
||||
final removed = current.where((r) => r.trackId == trackId).toList();
|
||||
if (removed.isEmpty) return;
|
||||
state = AsyncData(current.where((r) => r.trackId != trackId).toList());
|
||||
final db = ref.read(appDbProvider);
|
||||
final existing = await (db.select(db.cachedQuarantineMine)
|
||||
..where((t) => t.trackId.equals(trackId)))
|
||||
.getSingleOrNull();
|
||||
if (existing == null) return;
|
||||
|
||||
await (db.delete(db.cachedQuarantineMine)
|
||||
..where((t) => t.trackId.equals(trackId)))
|
||||
.go();
|
||||
|
||||
try {
|
||||
final api = await ref.read(quarantineApiProvider.future);
|
||||
await api.unflag(trackId);
|
||||
} catch (e, st) {
|
||||
state = AsyncData(current);
|
||||
Error.throwWithStackTrace(e, st);
|
||||
} catch (_) {
|
||||
// Don't restore the drift row; queue the unflag for replay.
|
||||
await ref
|
||||
.read(mutationQueueProvider)
|
||||
.enqueue(MutationKinds.quarantineUnflag, {'trackId': trackId});
|
||||
}
|
||||
}
|
||||
|
||||
static QuarantineMineRow _rowToModel(CachedQuarantineMineData r) =>
|
||||
QuarantineMineRow(
|
||||
trackId: r.trackId,
|
||||
reason: r.reason,
|
||||
notes: r.notes,
|
||||
createdAt: r.createdAt,
|
||||
trackTitle: r.trackTitle,
|
||||
trackDurationMs: r.trackDurationMs,
|
||||
albumId: r.albumId,
|
||||
albumTitle: r.albumTitle,
|
||||
albumCoverArtPath: r.albumCoverArtPath,
|
||||
artistId: r.artistId,
|
||||
artistName: r.artistName,
|
||||
);
|
||||
|
||||
static CachedQuarantineMineCompanion _modelToCompanion(QuarantineMineRow r) =>
|
||||
CachedQuarantineMineCompanion.insert(
|
||||
trackId: r.trackId,
|
||||
reason: r.reason,
|
||||
notes: r.notes == null ? const drift.Value.absent() : drift.Value(r.notes),
|
||||
createdAt: r.createdAt,
|
||||
trackTitle: r.trackTitle,
|
||||
trackDurationMs: drift.Value(r.trackDurationMs),
|
||||
albumId: r.albumId,
|
||||
albumTitle: r.albumTitle,
|
||||
albumCoverArtPath: r.albumCoverArtPath == null
|
||||
? const drift.Value.absent()
|
||||
: drift.Value(r.albumCoverArtPath),
|
||||
artistId: r.artistId,
|
||||
artistName: r.artistName,
|
||||
);
|
||||
}
|
||||
|
||||
final myQuarantineProvider =
|
||||
|
||||
@@ -3,6 +3,7 @@ import 'dart:async';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../api/endpoints/requests.dart';
|
||||
import '../cache/mutation_queue.dart';
|
||||
import '../library/library_providers.dart' show dioProvider;
|
||||
import '../models/admin_request.dart';
|
||||
|
||||
@@ -41,17 +42,20 @@ class MyRequestsController extends AsyncNotifier<List<AdminRequest>> {
|
||||
}
|
||||
}
|
||||
|
||||
/// Optimistic remove + REST cancel. Restores the row on failure so
|
||||
/// the user can retry — silent failure would lie about success.
|
||||
/// Optimistic remove + REST cancel. On failure the row stays
|
||||
/// removed in-memory and the cancel is queued for replay — this
|
||||
/// keeps the user's intent visible across network loss instead of
|
||||
/// restoring a row they explicitly asked to remove.
|
||||
Future<void> cancel(String id) async {
|
||||
final api = await ref.read(requestsApiProvider.future);
|
||||
final current = state.value ?? const <AdminRequest>[];
|
||||
state = AsyncData(current.where((r) => r.id != id).toList());
|
||||
try {
|
||||
await api.cancel(id);
|
||||
} catch (e, st) {
|
||||
state = AsyncData(current);
|
||||
Error.throwWithStackTrace(e, st);
|
||||
} catch (_) {
|
||||
await ref
|
||||
.read(mutationQueueProvider)
|
||||
.enqueue(MutationKinds.requestCancel, {'id': id});
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -3,6 +3,7 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:go_router/go_router.dart';
|
||||
|
||||
import '../models/admin_request.dart';
|
||||
import '../shared/live_events_provider.dart';
|
||||
import '../shared/widgets/main_app_bar_actions.dart';
|
||||
import '../theme/theme_extension.dart';
|
||||
import 'requests_provider.dart';
|
||||
@@ -13,6 +14,16 @@ class RequestsScreen extends ConsumerWidget {
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
// #402 wire-up: refresh the user's own requests list on
|
||||
// request.status_changed. Server-side events are user-scoped
|
||||
// (admin actions on someone else's request route to that other
|
||||
// user's stream); the dispatcher's filter already drops mismatches.
|
||||
ref.listen<AsyncValue<LiveEvent>>(liveEventsProvider, (_, next) {
|
||||
final e = next.asData?.value;
|
||||
if (e?.kind == 'request.status_changed') {
|
||||
ref.invalidate(myRequestsProvider);
|
||||
}
|
||||
});
|
||||
final requests = ref.watch(myRequestsProvider);
|
||||
|
||||
return Scaffold(
|
||||
|
||||
@@ -0,0 +1,104 @@
|
||||
// Maps incoming LiveEvent kinds to provider invalidations.
|
||||
//
|
||||
// Activated by ref.read(liveEventsDispatcherProvider) in app.dart; once
|
||||
// activated, the dispatcher listens to liveEventsProvider for the
|
||||
// lifetime of the ProviderScope and invalidates the small set of
|
||||
// public-scoped providers we know about.
|
||||
//
|
||||
// Screen-scoped providers (file-private providers in library_screen.dart,
|
||||
// admin handlers, etc.) opt in to live-refresh by themselves listening
|
||||
// to liveEventsProvider — the dispatcher only handles cross-screen,
|
||||
// publicly-importable providers. This keeps the dispatcher small and
|
||||
// avoids a back-edge dependency from /shared onto every feature folder.
|
||||
//
|
||||
// Includes an AppLifecycleState resume handler that defensively
|
||||
// invalidates the same set on app foreground. SSE will catch up on its
|
||||
// own, but on cold-start or after a long background period the
|
||||
// re-invalidate is fast and avoids stale data flashing before the
|
||||
// stream reconnects.
|
||||
|
||||
import 'package:flutter/widgets.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../library/library_providers.dart' show homeProvider;
|
||||
import '../quarantine/quarantine_provider.dart';
|
||||
import 'live_events_provider.dart';
|
||||
|
||||
/// Activates the SSE → invalidation dispatcher for the lifetime of the
|
||||
/// containing ProviderScope. Read this once at startup (from app.dart);
|
||||
/// the provider's body runs once, sets up listeners, and returns a
|
||||
/// sentinel value.
|
||||
final liveEventsDispatcherProvider = Provider<_LiveEventsDispatcher>((ref) {
|
||||
final d = _LiveEventsDispatcher(ref);
|
||||
ref.onDispose(d.dispose);
|
||||
return d;
|
||||
});
|
||||
|
||||
class _LiveEventsDispatcher with WidgetsBindingObserver {
|
||||
_LiveEventsDispatcher(this._ref) {
|
||||
// Subscribe to the event stream. Each emitted event invokes
|
||||
// _handle. Errors / disconnects auto-rebuild the underlying
|
||||
// provider; we don't need to react to them here.
|
||||
_sub = _ref.listen<AsyncValue<LiveEvent>>(
|
||||
liveEventsProvider,
|
||||
(_, next) => next.whenData(_handle),
|
||||
fireImmediately: false,
|
||||
);
|
||||
WidgetsBinding.instance.addObserver(this);
|
||||
}
|
||||
|
||||
final Ref _ref;
|
||||
late final ProviderSubscription<AsyncValue<LiveEvent>> _sub;
|
||||
|
||||
void _handle(LiveEvent e) {
|
||||
// Map event kinds to provider invalidations. Keep this list short:
|
||||
// only providers reachable from /shared. Screen-private providers
|
||||
// listen to liveEventsProvider themselves.
|
||||
switch (e.kind) {
|
||||
case 'quarantine.flagged':
|
||||
case 'quarantine.unflagged':
|
||||
case 'quarantine.resolved':
|
||||
case 'quarantine.file_deleted':
|
||||
case 'quarantine.deleted_via_lidarr':
|
||||
_ref.invalidate(myQuarantineProvider);
|
||||
// Hidden / liked / album rows referencing a deleted track may
|
||||
// now be stale — homeProvider re-fetch refreshes the cards.
|
||||
_ref.invalidate(homeProvider);
|
||||
case 'playlist.created':
|
||||
case 'playlist.updated':
|
||||
case 'playlist.deleted':
|
||||
case 'playlist.tracks_changed':
|
||||
// Home renders a Playlists row; refresh it so a delete or add
|
||||
// is reflected immediately. Detail screens that need the
|
||||
// mutated row will get a separate invalidate from their own
|
||||
// listener (filed as a follow-up).
|
||||
_ref.invalidate(homeProvider);
|
||||
case 'scan.run_started':
|
||||
case 'scan.run_finished':
|
||||
// Admin scan card provider lives in the admin feature folder
|
||||
// and is file-private today; will be invalidated by the admin
|
||||
// dashboard's own listener once that exists.
|
||||
break;
|
||||
default:
|
||||
// track.liked / track.unliked / request.status_changed reach
|
||||
// screen-private providers; their screens listen directly.
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
@override
|
||||
void didChangeAppLifecycleState(AppLifecycleState state) {
|
||||
if (state == AppLifecycleState.resumed) {
|
||||
// Defensive cold-start invalidation. SSE will catch up on its
|
||||
// own, but the re-invalidate flushes any stale data that
|
||||
// landed while the app was backgrounded.
|
||||
_ref.invalidate(myQuarantineProvider);
|
||||
_ref.invalidate(homeProvider);
|
||||
}
|
||||
}
|
||||
|
||||
void dispose() {
|
||||
WidgetsBinding.instance.removeObserver(this);
|
||||
_sub.close();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,126 @@
|
||||
// Subscribes to the server's Server-Sent Events stream
|
||||
// (GET /api/events/stream, see Fable #392) and exposes a parsed event
|
||||
// stream as a Riverpod StreamProvider. Consumers wire invalidation
|
||||
// behavior in live_events_dispatcher.dart.
|
||||
//
|
||||
// On disconnect (network blip, server restart, token rotation), the
|
||||
// provider's StreamController completes; the dispatcher's auto-rebuild
|
||||
// when the auth state changes re-subscribes. Explicit exponential
|
||||
// backoff lives at the dispatcher layer so we don't re-create the dio
|
||||
// connection too aggressively.
|
||||
|
||||
import 'dart:async';
|
||||
import 'dart:convert';
|
||||
|
||||
import 'package:dio/dio.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../auth/auth_provider.dart';
|
||||
import '../library/library_providers.dart' show dioProvider;
|
||||
|
||||
/// Parsed event from the server's SSE stream. `kind` follows
|
||||
/// "domain.action" naming; `data` carries the payload map.
|
||||
class LiveEvent {
|
||||
const LiveEvent({required this.kind, required this.userId, required this.data});
|
||||
|
||||
final String kind;
|
||||
final String userId;
|
||||
final Map<String, dynamic> data;
|
||||
|
||||
@override
|
||||
String toString() => 'LiveEvent($kind, user=$userId, data=$data)';
|
||||
}
|
||||
|
||||
/// Streams parsed LiveEvent values from /api/events/stream. Errors and
|
||||
/// disconnects surface as stream errors; the dispatcher decides whether
|
||||
/// to retry.
|
||||
final liveEventsProvider = StreamProvider<LiveEvent>((ref) async* {
|
||||
// Gate the subscription on having both a server URL and a session
|
||||
// token. If either is missing, emit nothing and let the provider
|
||||
// auto-rebuild when auth state lands.
|
||||
final token = await ref.watch(sessionTokenProvider.future);
|
||||
if (token == null || token.isEmpty) {
|
||||
return;
|
||||
}
|
||||
final dio = await ref.watch(dioProvider.future);
|
||||
|
||||
final controller = StreamController<LiveEvent>();
|
||||
ref.onDispose(controller.close);
|
||||
|
||||
// ignore: unawaited_futures
|
||||
_runSubscription(dio, controller);
|
||||
|
||||
yield* controller.stream;
|
||||
});
|
||||
|
||||
/// Runs the dio streaming request and pushes parsed events into
|
||||
/// [controller]. Closes the controller when the stream ends or errors.
|
||||
Future<void> _runSubscription(Dio dio, StreamController<LiveEvent> controller) async {
|
||||
try {
|
||||
final resp = await dio.get<ResponseBody>(
|
||||
'/api/events/stream',
|
||||
options: Options(
|
||||
responseType: ResponseType.stream,
|
||||
// No timeout — the server emits 15s heartbeats; idle timeouts
|
||||
// on the client side would tear down a healthy connection.
|
||||
receiveTimeout: Duration.zero,
|
||||
headers: const {'Accept': 'text/event-stream'},
|
||||
),
|
||||
);
|
||||
|
||||
// SSE frames are delimited by blank lines. Accumulate raw bytes
|
||||
// into a string buffer; flush parsed events on each "\n\n".
|
||||
var buffer = '';
|
||||
await for (final chunk in resp.data!.stream) {
|
||||
buffer += utf8.decode(chunk, allowMalformed: true);
|
||||
while (true) {
|
||||
final i = buffer.indexOf('\n\n');
|
||||
if (i < 0) break;
|
||||
final frame = buffer.substring(0, i);
|
||||
buffer = buffer.substring(i + 2);
|
||||
final event = _parseFrame(frame);
|
||||
if (event != null && !controller.isClosed) {
|
||||
controller.add(event);
|
||||
}
|
||||
}
|
||||
}
|
||||
if (!controller.isClosed) {
|
||||
await controller.close();
|
||||
}
|
||||
} catch (e, st) {
|
||||
if (!controller.isClosed) {
|
||||
controller.addError(e, st);
|
||||
await controller.close();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Parses one SSE frame. Heartbeat comments (starting with ":") and
|
||||
/// frames without a `data:` line return null. Frames with a `data:`
|
||||
/// payload that doesn't parse as JSON are also dropped (logged at
|
||||
/// debug level by the caller if needed).
|
||||
LiveEvent? _parseFrame(String frame) {
|
||||
String? kind;
|
||||
String? dataLine;
|
||||
for (final line in frame.split('\n')) {
|
||||
if (line.isEmpty || line.startsWith(':')) {
|
||||
continue;
|
||||
}
|
||||
if (line.startsWith('event:')) {
|
||||
kind = line.substring(6).trim();
|
||||
} else if (line.startsWith('data:')) {
|
||||
dataLine = line.substring(5).trim();
|
||||
}
|
||||
}
|
||||
if (dataLine == null) return null;
|
||||
try {
|
||||
final decoded = jsonDecode(dataLine) as Map<String, dynamic>;
|
||||
return LiveEvent(
|
||||
kind: kind ?? (decoded['kind'] as String? ?? ''),
|
||||
userId: decoded['user_id'] as String? ?? '',
|
||||
data: (decoded['data'] as Map<String, dynamic>?) ?? const {},
|
||||
);
|
||||
} catch (_) {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
@@ -9,6 +9,7 @@ import '../library/album_detail_screen.dart';
|
||||
import '../library/artist_detail_screen.dart';
|
||||
import '../models/album.dart';
|
||||
import '../models/artist.dart';
|
||||
import '../models/playlist.dart';
|
||||
import '../discover/discover_screen.dart';
|
||||
import '../library/home_screen.dart';
|
||||
import '../library/library_screen.dart';
|
||||
@@ -85,6 +86,14 @@ GoRouter buildRouter(Ref ref) {
|
||||
},
|
||||
),
|
||||
),
|
||||
// /queue lives outside the ShellRoute too. Why: pushing /queue
|
||||
// from /now-playing (which is also outside the shell) used to
|
||||
// cause go_router to mount a second ShellRoute instance under
|
||||
// the existing one, producing a duplicate page-key assertion
|
||||
// (NavigatorState._debugCheckDuplicatedPageKeys). Top-level
|
||||
// routes can stack on each other freely; shell-children can't
|
||||
// when something on top of the shell is already routing.
|
||||
GoRoute(path: '/queue', builder: (_, __) => const QueueScreen()),
|
||||
ShellRoute(
|
||||
builder: (ctx, state, child) => VersionGate(child: _ShellWithPlayerBar(child: child)),
|
||||
routes: [
|
||||
@@ -105,7 +114,6 @@ GoRouter buildRouter(Ref ref) {
|
||||
seed: s.extra is AlbumRef ? s.extra as AlbumRef : null,
|
||||
),
|
||||
),
|
||||
GoRoute(path: '/queue', builder: (_, __) => const QueueScreen()),
|
||||
GoRoute(path: '/search', builder: (_, __) => const SearchScreen()),
|
||||
GoRoute(path: '/library', builder: (_, __) => const LibraryScreen()),
|
||||
GoRoute(path: '/discover', builder: (_, __) => const DiscoverScreen()),
|
||||
@@ -113,7 +121,10 @@ GoRouter buildRouter(Ref ref) {
|
||||
GoRoute(path: '/playlists', builder: (_, __) => const PlaylistsListScreen()),
|
||||
GoRoute(
|
||||
path: '/playlists/:id',
|
||||
builder: (_, s) => PlaylistDetailScreen(id: s.pathParameters['id']!),
|
||||
builder: (_, s) => PlaylistDetailScreen(
|
||||
id: s.pathParameters['id']!,
|
||||
seed: s.extra is Playlist ? s.extra as Playlist : null,
|
||||
),
|
||||
),
|
||||
GoRoute(path: '/requests', builder: (_, __) => const RequestsScreen()),
|
||||
GoRoute(path: '/admin', builder: (_, __) => const AdminLandingScreen()),
|
||||
@@ -140,6 +151,11 @@ class _ShellWithPlayerBar extends ConsumerWidget {
|
||||
final hasBanner = ref.watch(shouldShowUpdateBannerProvider) != null;
|
||||
return Column(
|
||||
children: [
|
||||
// VersionTooOldBanner above UpdateBanner: a server-rejects-you
|
||||
// soft warning carries more user-relevant urgency than the APK
|
||||
// download prompt below it. The two banners can coexist
|
||||
// (server says you're too old AND a local APK is queued).
|
||||
const VersionTooOldBanner(),
|
||||
const UpdateBanner(),
|
||||
Expanded(
|
||||
child: hasBanner
|
||||
|
||||
@@ -1,9 +1,12 @@
|
||||
import 'package:cached_network_image/cached_network_image.dart';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_cache_manager/flutter_cache_manager.dart'
|
||||
show HttpExceptionWithStatus;
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
|
||||
import '../../auth/auth_provider.dart';
|
||||
|
||||
/// Image.network wrapper that resolves server-relative URLs (e.g.
|
||||
/// CachedNetworkImage wrapper that resolves server-relative URLs (e.g.
|
||||
/// `/api/albums/<id>/cover`) against the configured server base URL
|
||||
/// from [serverUrlProvider]. Absolute URLs (with scheme) pass through
|
||||
/// unchanged. Empty/null base or empty URL render the [fallback]
|
||||
@@ -12,6 +15,11 @@ import '../../auth/auth_provider.dart';
|
||||
///
|
||||
/// Mirrors the absolute-or-relative logic the audio handler uses for
|
||||
/// stream URLs, so cover art and audio resolve URLs the same way.
|
||||
///
|
||||
/// Uses CachedNetworkImage so cover bytes land on disk (path_provider
|
||||
/// temp dir, keyed by URL) and survive scroll-off + app restart. The
|
||||
/// previous Image.network behavior cached only in-memory, so the cold-
|
||||
/// start home grid re-downloaded every cover.
|
||||
class ServerImage extends ConsumerWidget {
|
||||
const ServerImage({
|
||||
super.key,
|
||||
@@ -31,17 +39,18 @@ class ServerImage extends ConsumerWidget {
|
||||
final base = ref.watch(serverUrlProvider).value;
|
||||
final resolved = _resolve(base, url);
|
||||
if (resolved == null) return empty;
|
||||
// Cover endpoints are gated by RequireUser server-side. Image.network
|
||||
// doesn't carry cookies/Bearer tokens automatically the way the
|
||||
// browser's <img> tag does, so we forward the session token as a
|
||||
// header. Without this, the server returns 401 and the image fails.
|
||||
// Cover endpoints are gated by RequireUser server-side. The image
|
||||
// loader doesn't carry cookies/Bearer tokens automatically the way
|
||||
// the browser's <img> tag does, so we forward the session token as
|
||||
// a header. Without this, the server returns 401 and the image
|
||||
// fails.
|
||||
//
|
||||
// sessionTokenProvider is a FutureProvider — on first read after a
|
||||
// hot restart its .value is null until the secure-storage read
|
||||
// resolves. If we fired Image.network with headers:null at that
|
||||
// moment, the network image cache would lock in the 401 response
|
||||
// and never retry. Instead, hold the fallback until the token is
|
||||
// available, then mount the Image with the auth header attached.
|
||||
// resolves. If we mounted the image with httpHeaders:null at that
|
||||
// moment, the disk cache would lock in the 401 response and never
|
||||
// retry. Hold the fallback until the token is available, then
|
||||
// mount the image with the auth header attached.
|
||||
final tokenAsync = ref.watch(sessionTokenProvider);
|
||||
return tokenAsync.when(
|
||||
loading: () => empty,
|
||||
@@ -49,14 +58,34 @@ class ServerImage extends ConsumerWidget {
|
||||
data: (token) {
|
||||
final headers = (token != null && token.isNotEmpty)
|
||||
? {'Authorization': 'Bearer $token'}
|
||||
: null;
|
||||
return Image.network(
|
||||
resolved,
|
||||
: <String, String>{};
|
||||
return CachedNetworkImage(
|
||||
imageUrl: resolved,
|
||||
httpHeaders: headers,
|
||||
fit: fit,
|
||||
headers: headers,
|
||||
// 120ms feels like cover bytes settling in on a cache miss
|
||||
// (smoother than the abrupt zero-fade); on cache hits the
|
||||
// image is decoded synchronously so the fade is imperceptible.
|
||||
// The default 500ms is too long — looks like a regression on
|
||||
// a populated grid.
|
||||
fadeInDuration: const Duration(milliseconds: 120),
|
||||
fadeOutDuration: Duration.zero,
|
||||
// Keep failures local — a single 401/timeout shouldn't dump
|
||||
// a stack trace or replace the parent Container's background.
|
||||
errorBuilder: (_, __, ___) => empty,
|
||||
errorWidget: (_, __, ___) => empty,
|
||||
// Filter expected 404s out of dev console noise: playlist
|
||||
// collages aren't built until the playlist has tracks and
|
||||
// the build job runs (system playlists like For-You /
|
||||
// Discover hit this on first-render). The errorWidget
|
||||
// already renders the fallback for the user; this just
|
||||
// keeps the dev console clean. Non-404 errors still
|
||||
// surface so auth/connectivity issues remain visible.
|
||||
errorListener: (err) {
|
||||
if (err is HttpExceptionWithStatus && err.statusCode == 404) {
|
||||
return;
|
||||
}
|
||||
debugPrint('ServerImage: $err');
|
||||
},
|
||||
);
|
||||
},
|
||||
);
|
||||
|
||||
@@ -0,0 +1,199 @@
|
||||
// Skeleton placeholder widgets for the per-item rendering architecture
|
||||
// (see docs/superpowers/specs/2026-05-13-per-item-rendering-design.md).
|
||||
//
|
||||
// Each skeleton matches the exact dimensions of its corresponding real
|
||||
// card so the layout doesn't shift when content lands. A subtle
|
||||
// shimmer sweep makes the page feel alive while individual tiles
|
||||
// hydrate against drift / REST in the background.
|
||||
//
|
||||
// Self-contained shimmer (no `shimmer` package dep) so we can keep
|
||||
// pubspec lean and tune the sweep colors against FabledSword tokens.
|
||||
|
||||
import 'package:flutter/material.dart';
|
||||
|
||||
import '../../theme/theme_extension.dart';
|
||||
|
||||
/// Period of one full shimmer sweep across the skeleton.
|
||||
const Duration _shimmerPeriod = Duration(milliseconds: 1200);
|
||||
|
||||
/// Wraps a child with a slow-moving highlight band on top of the
|
||||
/// skeleton's base color. Cheap — uses a single AnimationController
|
||||
/// per surface and a LinearGradient shader.
|
||||
class _Shimmer extends StatefulWidget {
|
||||
const _Shimmer({required this.child});
|
||||
final Widget child;
|
||||
|
||||
@override
|
||||
State<_Shimmer> createState() => _ShimmerState();
|
||||
}
|
||||
|
||||
class _ShimmerState extends State<_Shimmer>
|
||||
with SingleTickerProviderStateMixin {
|
||||
late final AnimationController _ctrl = AnimationController(
|
||||
vsync: this,
|
||||
duration: _shimmerPeriod,
|
||||
)..repeat();
|
||||
|
||||
@override
|
||||
void dispose() {
|
||||
_ctrl.dispose();
|
||||
super.dispose();
|
||||
}
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
return AnimatedBuilder(
|
||||
animation: _ctrl,
|
||||
builder: (context, child) {
|
||||
return ShaderMask(
|
||||
blendMode: BlendMode.srcATop,
|
||||
shaderCallback: (rect) {
|
||||
// Sweep starts off-screen left, ends off-screen right.
|
||||
final dx = (_ctrl.value * 2 - 1) * rect.width;
|
||||
return LinearGradient(
|
||||
begin: Alignment.centerLeft,
|
||||
end: Alignment.centerRight,
|
||||
colors: [
|
||||
fs.slate,
|
||||
fs.iron,
|
||||
fs.slate,
|
||||
],
|
||||
stops: const [0.0, 0.5, 1.0],
|
||||
transform: _SlideGradient(dx),
|
||||
).createShader(rect);
|
||||
},
|
||||
child: child,
|
||||
);
|
||||
},
|
||||
child: widget.child,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Helper for translating a gradient horizontally inside its rect.
|
||||
class _SlideGradient extends GradientTransform {
|
||||
const _SlideGradient(this.dx);
|
||||
final double dx;
|
||||
|
||||
@override
|
||||
Matrix4 transform(Rect bounds, {TextDirection? textDirection}) {
|
||||
return Matrix4.translationValues(dx, 0, 0);
|
||||
}
|
||||
}
|
||||
|
||||
/// Skeleton matched to AlbumCard's 140px outer width / 124px cover /
|
||||
/// title + artist text rows. Used in horizontal carousels where the
|
||||
/// real card lives.
|
||||
class SkeletonAlbumTile extends StatelessWidget {
|
||||
const SkeletonAlbumTile({super.key, this.width = 140});
|
||||
final double width;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final coverSize = width - 16;
|
||||
return _Shimmer(
|
||||
child: SizedBox(
|
||||
width: width,
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8),
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
ClipRRect(
|
||||
borderRadius: BorderRadius.circular(6),
|
||||
child: Container(
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
color: fs.slate,
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 8),
|
||||
Container(width: coverSize * 0.8, height: 14, color: fs.slate),
|
||||
const SizedBox(height: 4),
|
||||
Container(width: coverSize * 0.6, height: 12, color: fs.slate),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Skeleton matched to ArtistCard's 140px / 124px round-thumb shape.
|
||||
class SkeletonArtistTile extends StatelessWidget {
|
||||
const SkeletonArtistTile({super.key, this.width = 140});
|
||||
final double width;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
final coverSize = width - 16;
|
||||
return _Shimmer(
|
||||
child: SizedBox(
|
||||
width: width,
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 8),
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Container(
|
||||
width: coverSize,
|
||||
height: coverSize,
|
||||
decoration: BoxDecoration(
|
||||
color: fs.slate,
|
||||
shape: BoxShape.circle,
|
||||
),
|
||||
),
|
||||
const SizedBox(height: 8),
|
||||
Container(width: coverSize * 0.7, height: 14, color: fs.slate),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// Skeleton matched to TrackRow's vertical-list layout. 56dp cover +
|
||||
/// title + artist line, similar to the real row.
|
||||
class SkeletonTrackRow extends StatelessWidget {
|
||||
const SkeletonTrackRow({super.key});
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
return _Shimmer(
|
||||
child: Padding(
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 10),
|
||||
child: Row(
|
||||
children: [
|
||||
Container(
|
||||
width: 56,
|
||||
height: 56,
|
||||
decoration: BoxDecoration(
|
||||
color: fs.slate,
|
||||
borderRadius: BorderRadius.circular(6),
|
||||
),
|
||||
),
|
||||
const SizedBox(width: 12),
|
||||
Expanded(
|
||||
child: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.start,
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
children: [
|
||||
Container(width: 180, height: 14, color: fs.slate),
|
||||
const SizedBox(height: 6),
|
||||
Container(width: 120, height: 12, color: fs.slate),
|
||||
],
|
||||
),
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -11,6 +11,7 @@ class TrackActionsButton extends StatelessWidget {
|
||||
super.key,
|
||||
required this.track,
|
||||
this.hideQueueActions = false,
|
||||
this.onNavigate,
|
||||
});
|
||||
|
||||
final TrackRef track;
|
||||
@@ -19,6 +20,11 @@ class TrackActionsButton extends StatelessWidget {
|
||||
/// screen where the menu's track IS the currently-playing one.
|
||||
final bool hideQueueActions;
|
||||
|
||||
/// Forwarded to TrackActionsSheet.onNavigate. The host receives the
|
||||
/// destination path AFTER the sheet has popped and is responsible
|
||||
/// for navigating to it (typically: pop self first, then push).
|
||||
final Future<void> Function(String path)? onNavigate;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
@@ -29,6 +35,7 @@ class TrackActionsButton extends StatelessWidget {
|
||||
context,
|
||||
track,
|
||||
hideQueueActions: hideQueueActions,
|
||||
onNavigate: onNavigate,
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1,8 +1,12 @@
|
||||
import 'package:drift/drift.dart' as drift;
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:go_router/go_router.dart';
|
||||
|
||||
import '../../../api/endpoints/likes.dart';
|
||||
import '../../../cache/audio_cache_manager.dart' show appDbProvider;
|
||||
import '../../../cache/db.dart';
|
||||
import '../../../cache/mutation_queue.dart';
|
||||
import '../../../likes/likes_provider.dart';
|
||||
import '../../../models/track.dart';
|
||||
import '../../../player/player_provider.dart';
|
||||
@@ -21,15 +25,27 @@ class TrackActionsSheet extends ConsumerWidget {
|
||||
super.key,
|
||||
required this.track,
|
||||
required this.hideQueueActions,
|
||||
this.onNavigate,
|
||||
});
|
||||
|
||||
final TrackRef track;
|
||||
final bool hideQueueActions;
|
||||
|
||||
/// Optional hook for "Go to album" / "Go to artist". Called with
|
||||
/// the destination route path AFTER the sheet has popped. Lets
|
||||
/// callers that live OUTSIDE the ShellRoute (e.g. the full player
|
||||
/// at /now-playing) pop themselves first then push, so go_router
|
||||
/// doesn't try to mount a second ShellRoute on top of the active
|
||||
/// top-level route. When null, the sheet does its own
|
||||
/// context.push, which is correct for surfaces already inside the
|
||||
/// shell (mini player, track rows on detail screens, etc.).
|
||||
final Future<void> Function(String path)? onNavigate;
|
||||
|
||||
static Future<void> show(
|
||||
BuildContext context,
|
||||
TrackRef track, {
|
||||
bool hideQueueActions = false,
|
||||
Future<void> Function(String path)? onNavigate,
|
||||
}) {
|
||||
return showModalBottomSheet<void>(
|
||||
context: context,
|
||||
@@ -37,6 +53,7 @@ class TrackActionsSheet extends ConsumerWidget {
|
||||
builder: (_) => TrackActionsSheet(
|
||||
track: track,
|
||||
hideQueueActions: hideQueueActions,
|
||||
onNavigate: onNavigate,
|
||||
),
|
||||
);
|
||||
}
|
||||
@@ -141,7 +158,12 @@ class TrackActionsSheet extends ConsumerWidget {
|
||||
label: 'Go to album',
|
||||
onTap: () {
|
||||
Navigator.pop(context);
|
||||
context.push('/albums/${track.albumId}');
|
||||
final path = '/albums/${track.albumId}';
|
||||
if (onNavigate != null) {
|
||||
onNavigate!(path);
|
||||
} else {
|
||||
context.push(path);
|
||||
}
|
||||
},
|
||||
),
|
||||
_MenuItem(
|
||||
@@ -150,7 +172,12 @@ class TrackActionsSheet extends ConsumerWidget {
|
||||
label: 'Go to artist',
|
||||
onTap: () {
|
||||
Navigator.pop(context);
|
||||
context.push('/artists/${track.artistId}');
|
||||
final path = '/artists/${track.artistId}';
|
||||
if (onNavigate != null) {
|
||||
onNavigate!(path);
|
||||
} else {
|
||||
context.push(path);
|
||||
}
|
||||
},
|
||||
),
|
||||
const _Divider(),
|
||||
@@ -232,7 +259,38 @@ typedef AddToPlaylistAction = Future<void> Function(String playlistId, String tr
|
||||
|
||||
final addToPlaylistActionProvider = Provider<AddToPlaylistAction>((ref) {
|
||||
return (playlistId, trackId) async {
|
||||
final api = await ref.read(playlistsApiProvider.future);
|
||||
await api.appendTracks(playlistId, [trackId]);
|
||||
final db = ref.read(appDbProvider);
|
||||
// Optimistic drift write so the playlist detail screen shows the
|
||||
// new track instantly. The position is best-effort — append after
|
||||
// the current max for this playlist. The server's authoritative
|
||||
// position lands on next playlistDetailProvider fetch (SWR), or
|
||||
// when the queued mutation replays.
|
||||
final maxPos = await (db.selectOnly(db.cachedPlaylistTracks)
|
||||
..addColumns([db.cachedPlaylistTracks.position.max()])
|
||||
..where(db.cachedPlaylistTracks.playlistId.equals(playlistId)))
|
||||
.getSingleOrNull();
|
||||
final nextPos =
|
||||
((maxPos?.read(db.cachedPlaylistTracks.position.max()) ?? -1) + 1);
|
||||
await db.into(db.cachedPlaylistTracks).insertOnConflictUpdate(
|
||||
CachedPlaylistTracksCompanion.insert(
|
||||
playlistId: playlistId,
|
||||
trackId: trackId,
|
||||
position: drift.Value(nextPos),
|
||||
),
|
||||
);
|
||||
|
||||
try {
|
||||
final api = await ref.read(playlistsApiProvider.future);
|
||||
await api.appendTracks(playlistId, [trackId]);
|
||||
} catch (_) {
|
||||
// REST failed — keep the optimistic drift row; queue the call.
|
||||
await ref.read(mutationQueueProvider).enqueue(
|
||||
MutationKinds.playlistAppend,
|
||||
{
|
||||
'playlistId': playlistId,
|
||||
'trackIds': [trackId],
|
||||
},
|
||||
);
|
||||
}
|
||||
};
|
||||
});
|
||||
|
||||
@@ -1,3 +1,6 @@
|
||||
import 'dart:async';
|
||||
|
||||
import 'package:dio/dio.dart';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:package_info_plus/package_info_plus.dart';
|
||||
@@ -6,61 +9,255 @@ import 'package:pub_semver/pub_semver.dart';
|
||||
import '../../api/client.dart';
|
||||
import '../../api/endpoints/health.dart';
|
||||
import '../../auth/auth_provider.dart';
|
||||
import '../../theme/theme_extension.dart';
|
||||
|
||||
final _versionCheckProvider = FutureProvider<_VersionResult>((ref) async {
|
||||
final url = await ref.watch(serverUrlProvider.future);
|
||||
if (url == null) return _VersionResult.skipped;
|
||||
final dio = ApiClient.buildDio(baseUrl: url, tokenResolver: () async => null);
|
||||
final body = await HealthApi(dio).check();
|
||||
final min = body['min_client_version'];
|
||||
if (min == null || min.isEmpty) return _VersionResult.skipped;
|
||||
final info = await PackageInfo.fromPlatform();
|
||||
final mine = Version.parse(info.version);
|
||||
final required = Version.parse(min);
|
||||
return mine < required ? _VersionResult.tooOld : _VersionResult.ok;
|
||||
});
|
||||
/// Result of the most recent /healthz version compatibility check.
|
||||
///
|
||||
/// `skipped` means the server didn't emit a `min_client_version` field
|
||||
/// (older servers, partial deploys). Treat as compatible.
|
||||
enum VersionResult { ok, tooOld, skipped }
|
||||
|
||||
enum _VersionResult { ok, tooOld, skipped }
|
||||
VersionResult _resultFromString(String? s) {
|
||||
switch (s) {
|
||||
case 'ok':
|
||||
return VersionResult.ok;
|
||||
case 'tooOld':
|
||||
return VersionResult.tooOld;
|
||||
default:
|
||||
return VersionResult.skipped;
|
||||
}
|
||||
}
|
||||
|
||||
class VersionGate extends ConsumerWidget {
|
||||
String _stringFromResult(VersionResult r) {
|
||||
switch (r) {
|
||||
case VersionResult.ok:
|
||||
return 'ok';
|
||||
case VersionResult.tooOld:
|
||||
return 'tooOld';
|
||||
case VersionResult.skipped:
|
||||
return 'skipped';
|
||||
}
|
||||
}
|
||||
|
||||
/// Drives the version-compatibility check against /healthz. Non-blocking:
|
||||
/// the controller hydrates from a 1h-throttled cache on boot, exposes
|
||||
/// the current `VersionResult`, and refreshes itself in the background.
|
||||
/// UI (VersionGate + _VersionTooOldBanner) reads this state to decide
|
||||
/// whether to surface the "too old" banner — never blocks rendering.
|
||||
///
|
||||
/// Cache keys live in flutter_secure_storage so the cadence survives
|
||||
/// app restarts. 1h throttle bounds /healthz traffic; explicit
|
||||
/// `recheck()` (from the banner's "Check now" button or app resume)
|
||||
/// bypasses the throttle.
|
||||
class VersionCheckController extends AsyncNotifier<VersionResult> {
|
||||
static const _kResult = 'version_check_result';
|
||||
static const _kAtMs = 'version_check_at_ms';
|
||||
// 1 minute. The /healthz response is sub-1KB and the call is
|
||||
// non-blocking, so a tight cadence buys faster recovery from
|
||||
// server-side min_client_version bumps without measurable cost. The
|
||||
// gate also acts as a safety net against duplicate calls when the
|
||||
// periodic timer and a resume event fire close together.
|
||||
static const _staleMs = 60 * 1000;
|
||||
|
||||
@override
|
||||
Future<VersionResult> build() async {
|
||||
final storage = ref.read(secureStorageProvider);
|
||||
final resultStr = await storage.read(key: _kResult);
|
||||
final atStr = await storage.read(key: _kAtMs);
|
||||
final cached = _resultFromString(resultStr);
|
||||
final at = int.tryParse(atStr ?? '') ?? 0;
|
||||
final nowMs = DateTime.now().millisecondsSinceEpoch;
|
||||
|
||||
// Fire background recheck on cold-start when cache is missing or stale.
|
||||
// Doesn't block: build returns the cached result immediately; the
|
||||
// recheck updates state asynchronously when it lands.
|
||||
if (nowMs - at > _staleMs) {
|
||||
Future.microtask(_runCheck);
|
||||
}
|
||||
return cached;
|
||||
}
|
||||
|
||||
/// Force a fresh check, bypassing the 1h staleness gate. Used by the
|
||||
/// "Check now" banner button and (indirectly) by the AppLifecycleState
|
||||
/// resume observer in VersionGate.
|
||||
Future<void> recheck() async => _runCheck();
|
||||
|
||||
/// Recheck only if the cache is older than the 1h throttle. No-op
|
||||
/// when fresh. Used on app resume to avoid hammering /healthz when
|
||||
/// the user is briefly switching between apps.
|
||||
Future<void> recheckIfStale() async {
|
||||
final storage = ref.read(secureStorageProvider);
|
||||
final atStr = await storage.read(key: _kAtMs);
|
||||
final at = int.tryParse(atStr ?? '') ?? 0;
|
||||
if (DateTime.now().millisecondsSinceEpoch - at > _staleMs) {
|
||||
await _runCheck();
|
||||
}
|
||||
}
|
||||
|
||||
Future<void> _runCheck() async {
|
||||
try {
|
||||
final url = await ref.read(serverUrlProvider.future);
|
||||
if (url == null || url.isEmpty) return;
|
||||
// Bounded timeouts for a health probe — the default
|
||||
// ApiClient.buildDio dio is tuned for actual data fetches
|
||||
// (8s connect + 30s receive). /healthz should resolve in
|
||||
// tens of milliseconds; failing fast unblocks slow networks.
|
||||
final dio = ApiClient.buildDio(
|
||||
baseUrl: url,
|
||||
tokenResolver: () async => null,
|
||||
);
|
||||
dio.options.connectTimeout = const Duration(seconds: 3);
|
||||
dio.options.receiveTimeout = const Duration(seconds: 2);
|
||||
final body = await HealthApi(dio).check();
|
||||
final min = body['min_client_version'];
|
||||
VersionResult result;
|
||||
if (min == null || min.isEmpty) {
|
||||
result = VersionResult.skipped;
|
||||
} else {
|
||||
final info = await PackageInfo.fromPlatform();
|
||||
final mine = Version.parse(info.version);
|
||||
final required = Version.parse(min);
|
||||
result = mine < required ? VersionResult.tooOld : VersionResult.ok;
|
||||
}
|
||||
// Persist + flip state. Storage write before state assignment so
|
||||
// a hot reload immediately after won't see a fresh state with a
|
||||
// stale cache.
|
||||
final storage = ref.read(secureStorageProvider);
|
||||
await storage.write(key: _kResult, value: _stringFromResult(result));
|
||||
await storage.write(
|
||||
key: _kAtMs,
|
||||
value: DateTime.now().millisecondsSinceEpoch.toString(),
|
||||
);
|
||||
state = AsyncData(result);
|
||||
} on DioException catch (_) {
|
||||
// Network error / timeout. Keep the cached state; don't bump the
|
||||
// timestamp so the next staleness check still triggers a retry.
|
||||
} catch (_) {
|
||||
// Other errors (PackageInfo, parsing, etc.). Same handling —
|
||||
// soft-fail so the UI never sees an error state from a defensive
|
||||
// background check.
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
final versionCheckProvider =
|
||||
AsyncNotifierProvider<VersionCheckController, VersionResult>(
|
||||
VersionCheckController.new,
|
||||
);
|
||||
|
||||
/// Wraps the shell. Non-blocking: always renders the child. Activates
|
||||
/// the version check controller on mount and reruns it on app resume
|
||||
/// (gated by the controller's 1h staleness throttle).
|
||||
class VersionGate extends ConsumerStatefulWidget {
|
||||
const VersionGate({required this.child, super.key});
|
||||
final Widget child;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
return ref.watch(_versionCheckProvider).when(
|
||||
data: (r) => r == _VersionResult.tooOld ? const _TooOldScreen() : child,
|
||||
error: (_, __) => child, // soft-fail if /healthz is unreachable; let the rest of the flow surface a real error
|
||||
loading: () => const Scaffold(body: Center(child: CircularProgressIndicator())),
|
||||
);
|
||||
}
|
||||
ConsumerState<VersionGate> createState() => _VersionGateState();
|
||||
}
|
||||
|
||||
class _TooOldScreen extends StatelessWidget {
|
||||
const _TooOldScreen();
|
||||
class _VersionGateState extends ConsumerState<VersionGate>
|
||||
with WidgetsBindingObserver {
|
||||
// Polling interval during active foreground use. Paired with the
|
||||
// controller's 1m staleness gate so concurrent fires (timer + resume)
|
||||
// dedupe to a single network call. Tight cadence is affordable —
|
||||
// /healthz is sub-1KB and the call is non-blocking.
|
||||
static const _pollInterval = Duration(minutes: 1);
|
||||
Timer? _pollTimer;
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
return const Scaffold(
|
||||
body: SafeArea(
|
||||
child: Padding(
|
||||
padding: EdgeInsets.all(24),
|
||||
child: Center(
|
||||
child: Column(
|
||||
mainAxisAlignment: MainAxisAlignment.center,
|
||||
children: [
|
||||
Text(
|
||||
'Update required',
|
||||
style: TextStyle(fontSize: 24, fontWeight: FontWeight.w500),
|
||||
),
|
||||
SizedBox(height: 12),
|
||||
Text(
|
||||
'This client is too old for that Minstrel server. Install the latest build to continue.',
|
||||
textAlign: TextAlign.center,
|
||||
),
|
||||
],
|
||||
void initState() {
|
||||
super.initState();
|
||||
// Read once so the provider's build() runs; the controller
|
||||
// hydrates from cache + fires a background check when stale.
|
||||
ref.read(versionCheckProvider);
|
||||
WidgetsBinding.instance.addObserver(this);
|
||||
_startPolling();
|
||||
}
|
||||
|
||||
@override
|
||||
void dispose() {
|
||||
_stopPolling();
|
||||
WidgetsBinding.instance.removeObserver(this);
|
||||
super.dispose();
|
||||
}
|
||||
|
||||
void _startPolling() {
|
||||
_pollTimer?.cancel();
|
||||
_pollTimer = Timer.periodic(_pollInterval, (_) {
|
||||
// ignore: unawaited_futures
|
||||
ref.read(versionCheckProvider.notifier).recheckIfStale();
|
||||
});
|
||||
}
|
||||
|
||||
void _stopPolling() {
|
||||
_pollTimer?.cancel();
|
||||
_pollTimer = null;
|
||||
}
|
||||
|
||||
@override
|
||||
void didChangeAppLifecycleState(AppLifecycleState state) {
|
||||
switch (state) {
|
||||
case AppLifecycleState.resumed:
|
||||
// Re-arm the timer + fire one immediate (staleness-gated) check
|
||||
// so users who foreground after a long away period get a fresh
|
||||
// result without waiting for the next tick.
|
||||
// ignore: unawaited_futures
|
||||
ref.read(versionCheckProvider.notifier).recheckIfStale();
|
||||
_startPolling();
|
||||
case AppLifecycleState.paused:
|
||||
case AppLifecycleState.inactive:
|
||||
case AppLifecycleState.hidden:
|
||||
case AppLifecycleState.detached:
|
||||
// Stop firing while backgrounded — no need to burn battery on
|
||||
// health probes the user can't see the result of.
|
||||
_stopPolling();
|
||||
}
|
||||
}
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) => widget.child;
|
||||
}
|
||||
|
||||
/// Banner that surfaces when the server reports our client is too old.
|
||||
/// Non-blocking: the rest of the app keeps working (offline-mode-style
|
||||
/// — locally cached metadata + audio still play). Tap "Check now" to
|
||||
/// force a re-check after installing a new build.
|
||||
class VersionTooOldBanner extends ConsumerWidget {
|
||||
const VersionTooOldBanner({super.key});
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context, WidgetRef ref) {
|
||||
final asyncResult = ref.watch(versionCheckProvider);
|
||||
final result = asyncResult.asData?.value;
|
||||
if (result != VersionResult.tooOld) return const SizedBox.shrink();
|
||||
final fs = Theme.of(context).extension<FabledSwordTheme>()!;
|
||||
return SafeArea(
|
||||
bottom: false,
|
||||
child: Container(
|
||||
color: fs.error.withValues(alpha: 0.15),
|
||||
padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 10),
|
||||
child: Row(children: [
|
||||
Icon(Icons.warning_amber_rounded, color: fs.error, size: 18),
|
||||
const SizedBox(width: 8),
|
||||
Expanded(
|
||||
child: Text(
|
||||
"This app is older than the server requires. "
|
||||
"You can keep using cached content; install an update when ready.",
|
||||
style: TextStyle(color: fs.parchment, fontSize: 13),
|
||||
),
|
||||
),
|
||||
),
|
||||
TextButton(
|
||||
onPressed: () =>
|
||||
ref.read(versionCheckProvider.notifier).recheck(),
|
||||
style: TextButton.styleFrom(
|
||||
foregroundColor: fs.parchment,
|
||||
minimumSize: const Size(0, 36),
|
||||
padding: const EdgeInsets.symmetric(horizontal: 12),
|
||||
),
|
||||
child: const Text('Check now'),
|
||||
),
|
||||
]),
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -121,6 +121,30 @@ packages:
|
||||
url: "https://pub.dev"
|
||||
source: hosted
|
||||
version: "8.12.6"
|
||||
cached_network_image:
|
||||
dependency: "direct main"
|
||||
description:
|
||||
name: cached_network_image
|
||||
sha256: "7c1183e361e5c8b0a0f21a28401eecdbde252441106a9816400dd4c2b2424916"
|
||||
url: "https://pub.dev"
|
||||
source: hosted
|
||||
version: "3.4.1"
|
||||
cached_network_image_platform_interface:
|
||||
dependency: transitive
|
||||
description:
|
||||
name: cached_network_image_platform_interface
|
||||
sha256: "35814b016e37fbdc91f7ae18c8caf49ba5c88501813f73ce8a07027a395e2829"
|
||||
url: "https://pub.dev"
|
||||
source: hosted
|
||||
version: "4.1.1"
|
||||
cached_network_image_web:
|
||||
dependency: transitive
|
||||
description:
|
||||
name: cached_network_image_web
|
||||
sha256: "980842f4e8e2535b8dbd3d5ca0b1f0ba66bf61d14cc3a17a9b4788a3685ba062"
|
||||
url: "https://pub.dev"
|
||||
source: hosted
|
||||
version: "1.3.1"
|
||||
characters:
|
||||
dependency: transitive
|
||||
description:
|
||||
@@ -327,7 +351,7 @@ packages:
|
||||
source: sdk
|
||||
version: "0.0.0"
|
||||
flutter_cache_manager:
|
||||
dependency: transitive
|
||||
dependency: "direct main"
|
||||
description:
|
||||
name: flutter_cache_manager
|
||||
sha256: "400b6592f16a4409a7f2bb929a9a7e38c72cceb8ffb99ee57bbf2cb2cecf8386"
|
||||
@@ -411,6 +435,14 @@ packages:
|
||||
description: flutter
|
||||
source: sdk
|
||||
version: "0.0.0"
|
||||
flutter_timezone:
|
||||
dependency: "direct main"
|
||||
description:
|
||||
name: flutter_timezone
|
||||
sha256: "13b2109ad75651faced4831bf262e32559e44aa549426eab8a597610d385d934"
|
||||
url: "https://pub.dev"
|
||||
source: hosted
|
||||
version: "4.1.1"
|
||||
flutter_web_plugins:
|
||||
dependency: transitive
|
||||
description: flutter
|
||||
@@ -664,6 +696,14 @@ packages:
|
||||
url: "https://pub.dev"
|
||||
source: hosted
|
||||
version: "9.3.0"
|
||||
octo_image:
|
||||
dependency: transitive
|
||||
description:
|
||||
name: octo_image
|
||||
sha256: "34faa6639a78c7e3cbe79be6f9f96535867e879748ade7d17c9b1ae7536293bd"
|
||||
url: "https://pub.dev"
|
||||
source: hosted
|
||||
version: "2.1.0"
|
||||
package_config:
|
||||
dependency: transitive
|
||||
description:
|
||||
@@ -688,6 +728,14 @@ packages:
|
||||
url: "https://pub.dev"
|
||||
source: hosted
|
||||
version: "3.2.1"
|
||||
palette_generator:
|
||||
dependency: "direct main"
|
||||
description:
|
||||
name: palette_generator
|
||||
sha256: "4420f7ccc3f0a4a906144e73f8b6267cd940b64f57a7262e95cb8cec3a8ae0ed"
|
||||
url: "https://pub.dev"
|
||||
source: hosted
|
||||
version: "0.3.3+7"
|
||||
path:
|
||||
dependency: transitive
|
||||
description:
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
name: minstrel
|
||||
description: Minstrel mobile client
|
||||
publish_to: 'none'
|
||||
version: 2026.5.11+1
|
||||
version: 2026.5.14+5
|
||||
|
||||
environment:
|
||||
sdk: '>=3.5.0 <4.0.0'
|
||||
@@ -28,6 +28,21 @@ dependencies:
|
||||
drift_flutter: ^0.2.0
|
||||
sqlite3_flutter_libs: ^0.5.24
|
||||
connectivity_plus: ^6.0.5
|
||||
flutter_timezone: ^4.1.1
|
||||
palette_generator: ^0.3.3
|
||||
# Disk-persistent image cache. Image.network only caches in memory, so
|
||||
# cover art repainted after a scroll-off or app restart re-fetches from
|
||||
# the server. cached_network_image stores the bytes under
|
||||
# path_provider's temp dir keyed by URL, surviving both. Used directly
|
||||
# by ServerImage (auth-aware path) and as CachedNetworkImageProvider
|
||||
# for the mini bar (which composes its own Image widget).
|
||||
cached_network_image: ^3.4.1
|
||||
# flutter_cache_manager is the disk-cache layer cached_network_image
|
||||
# sits on top of. SyncController uses DefaultCacheManager directly to
|
||||
# pre-warm covers during metadata sync, so a cold-start home grid
|
||||
# paints from disk on the very first scroll rather than firing a
|
||||
# network round-trip per tile.
|
||||
flutter_cache_manager: ^3.4.1
|
||||
|
||||
dev_dependencies:
|
||||
flutter_test:
|
||||
|
||||
+9
-2
@@ -32,9 +32,16 @@ void main() {
|
||||
isOnline: () async => true,
|
||||
);
|
||||
|
||||
final firstFuture = results.first;
|
||||
// Post-coldFetchAttempted guard, cacheFirst yields the current
|
||||
// (still-empty) rows after the fetch returns, so the stream
|
||||
// never hangs when populate is a no-op for this filter. The
|
||||
// simulated drift re-emit then yields the populated rows.
|
||||
// Capture the Future *before* feeding the controller so the
|
||||
// listener is subscribed when the first add() lands.
|
||||
final emissionsFuture = results.take(2).toList();
|
||||
controller.add([]);
|
||||
expect(await firstFuture, 42);
|
||||
final emissions = await emissionsFuture;
|
||||
expect(emissions, [0, 42]);
|
||||
expect(fetchCalled, 1);
|
||||
await controller.close();
|
||||
});
|
||||
|
||||
@@ -5,53 +5,51 @@ import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:minstrel/api/endpoints/playlists.dart';
|
||||
import 'package:minstrel/library/home_screen.dart';
|
||||
import 'package:minstrel/library/library_providers.dart';
|
||||
import 'package:minstrel/models/album.dart';
|
||||
import 'package:minstrel/models/artist.dart';
|
||||
import 'package:minstrel/models/home_data.dart';
|
||||
import 'package:minstrel/models/home_index.dart';
|
||||
import 'package:minstrel/models/playlist.dart';
|
||||
import 'package:minstrel/models/system_playlists_status.dart';
|
||||
import 'package:minstrel/playlists/playlists_provider.dart';
|
||||
import 'package:minstrel/theme/theme_data.dart';
|
||||
|
||||
const _emptyHome = HomeData(
|
||||
recentlyAddedAlbums: [],
|
||||
rediscoverAlbums: [],
|
||||
rediscoverArtists: [],
|
||||
mostPlayedTracks: [],
|
||||
lastPlayedArtists: [],
|
||||
);
|
||||
// All tests pump an empty HomeIndex unless they care about populated
|
||||
// section IDs — per-tile hydration is intentionally not exercised here
|
||||
// (that requires drift, and the @Tags(['drift']) tier covers it).
|
||||
// What this suite verifies is the screen's section-level shape:
|
||||
// placeholders / empty-state copy / section presence given the index.
|
||||
const _emptyIndex = HomeIndex.empty;
|
||||
|
||||
void main() {
|
||||
testWidgets('renders 4 placeholder cards in Playlists row when no system playlists exist',
|
||||
(tester) async {
|
||||
await tester.pumpWidget(ProviderScope(
|
||||
overrides: [
|
||||
homeProvider.overrideWith((ref) async => _emptyHome),
|
||||
homeIndexProvider.overrideWith((ref) => Stream.value(_emptyIndex)),
|
||||
playlistsListProvider('all').overrideWith(
|
||||
(ref) => Stream.value(PlaylistsList.empty()),
|
||||
),
|
||||
systemPlaylistsStatusProvider.overrideWith(
|
||||
(ref) async => SystemPlaylistsStatus.empty(),
|
||||
(ref) => Stream.value(SystemPlaylistsStatus.empty()),
|
||||
),
|
||||
],
|
||||
child: MaterialApp(theme: buildThemeData(), home: const HomeScreen()),
|
||||
));
|
||||
await tester.pumpAndSettle();
|
||||
// For-You placeholder + 3 Songs-like placeholders.
|
||||
// For-You placeholder + Discover placeholder + 3 Songs-like placeholders.
|
||||
expect(find.text('For You'), findsOneWidget);
|
||||
expect(find.text('Discover'), findsOneWidget);
|
||||
expect(find.text('Songs like…'), findsNWidgets(3));
|
||||
});
|
||||
|
||||
testWidgets('renders empty-state copy for each section when home payload is empty',
|
||||
testWidgets('renders empty-state copy for each section when the index is empty',
|
||||
(tester) async {
|
||||
await tester.pumpWidget(ProviderScope(
|
||||
overrides: [
|
||||
homeProvider.overrideWith((ref) async => _emptyHome),
|
||||
homeIndexProvider.overrideWith((ref) => Stream.value(_emptyIndex)),
|
||||
playlistsListProvider('all').overrideWith(
|
||||
(ref) => Stream.value(PlaylistsList.empty()),
|
||||
),
|
||||
systemPlaylistsStatusProvider.overrideWith(
|
||||
(ref) async => SystemPlaylistsStatus.empty(),
|
||||
(ref) => Stream.value(SystemPlaylistsStatus.empty()),
|
||||
),
|
||||
],
|
||||
child: MaterialApp(theme: buildThemeData(), home: const HomeScreen()),
|
||||
@@ -87,13 +85,13 @@ void main() {
|
||||
);
|
||||
await tester.pumpWidget(ProviderScope(
|
||||
overrides: [
|
||||
homeProvider.overrideWith((ref) async => _emptyHome),
|
||||
homeIndexProvider.overrideWith((ref) => Stream.value(_emptyIndex)),
|
||||
playlistsListProvider('all').overrideWith(
|
||||
(ref) => Stream.value(
|
||||
const PlaylistsList(owned: [forYou], public: [])),
|
||||
),
|
||||
systemPlaylistsStatusProvider.overrideWith(
|
||||
(ref) async => SystemPlaylistsStatus.empty(),
|
||||
(ref) => Stream.value(SystemPlaylistsStatus.empty()),
|
||||
),
|
||||
],
|
||||
child: MaterialApp(theme: buildThemeData(), home: const HomeScreen()),
|
||||
@@ -104,34 +102,8 @@ void main() {
|
||||
expect(find.text('for you'), findsOneWidget);
|
||||
});
|
||||
|
||||
testWidgets('renders home rollups when payload is non-empty', (tester) async {
|
||||
const home = HomeData(
|
||||
recentlyAddedAlbums: [
|
||||
AlbumRef(id: 'a', title: 'Geogaddi', artistId: 'x', artistName: 'BoC'),
|
||||
],
|
||||
rediscoverAlbums: [],
|
||||
rediscoverArtists: [
|
||||
ArtistRef(id: 'r', name: 'Aphex Twin'),
|
||||
],
|
||||
mostPlayedTracks: [],
|
||||
lastPlayedArtists: [],
|
||||
);
|
||||
await tester.pumpWidget(ProviderScope(
|
||||
overrides: [
|
||||
homeProvider.overrideWith((ref) async => home),
|
||||
playlistsListProvider('all').overrideWith(
|
||||
(ref) => Stream.value(PlaylistsList.empty()),
|
||||
),
|
||||
systemPlaylistsStatusProvider.overrideWith(
|
||||
(ref) async => SystemPlaylistsStatus.empty(),
|
||||
),
|
||||
],
|
||||
child: MaterialApp(theme: buildThemeData(), home: const HomeScreen()),
|
||||
));
|
||||
await tester.pumpAndSettle();
|
||||
expect(find.text('Recently added'), findsOneWidget);
|
||||
expect(find.text('Geogaddi'), findsOneWidget);
|
||||
expect(find.text('Rediscover'), findsOneWidget);
|
||||
expect(find.text('Aphex Twin'), findsOneWidget);
|
||||
});
|
||||
// Section-with-populated-IDs coverage lives in the drift-tagged
|
||||
// integration suite (Slice F follow-up) because per-tile providers
|
||||
// require a real (in-memory) drift DB. The flutter-ci runner skips
|
||||
// drift tests pending libsqlite3.
|
||||
}
|
||||
|
||||
@@ -1,11 +1,23 @@
|
||||
@Tags(['drift'])
|
||||
library;
|
||||
|
||||
import 'package:drift/native.dart' show NativeDatabase;
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
|
||||
import 'package:minstrel/api/endpoints/quarantine.dart';
|
||||
import 'package:minstrel/models/quarantine_mine.dart';
|
||||
import 'package:minstrel/cache/audio_cache_manager.dart' show appDbProvider;
|
||||
import 'package:minstrel/cache/db.dart';
|
||||
import 'package:minstrel/models/track.dart';
|
||||
import 'package:minstrel/quarantine/quarantine_provider.dart';
|
||||
|
||||
// SKIP NOTE: drift's NativeDatabase needs the system libsqlite3.so.
|
||||
// The flutter-ci runner image doesn't ship it. Same skip as
|
||||
// sync_controller_test.dart — unblock by adding libsqlite3-dev to the
|
||||
// CI image, or switch to sqlite3/wasm. On-device runs cover real
|
||||
// behaviour today.
|
||||
const _skipDrift = 'libsqlite3 missing on flutter-ci runner; on-device covers';
|
||||
|
||||
class _StubQuarantineApi implements QuarantineApi {
|
||||
_StubQuarantineApi({this.shouldThrow = false});
|
||||
bool shouldThrow;
|
||||
@@ -25,13 +37,6 @@ class _StubQuarantineApi implements QuarantineApi {
|
||||
}
|
||||
}
|
||||
|
||||
class _StubController extends MyQuarantineController {
|
||||
_StubController(this._initial);
|
||||
final List<QuarantineMineRow> _initial;
|
||||
@override
|
||||
Future<List<QuarantineMineRow>> build() async => _initial;
|
||||
}
|
||||
|
||||
const _track = TrackRef(
|
||||
id: 't1',
|
||||
title: 'Roygbiv',
|
||||
@@ -44,75 +49,95 @@ const _track = TrackRef(
|
||||
streamUrl: '',
|
||||
);
|
||||
|
||||
const _existing = QuarantineMineRow(
|
||||
trackId: 't1',
|
||||
reason: 'bad_rip',
|
||||
notes: null,
|
||||
createdAt: '2026-05-01T00:00:00Z',
|
||||
trackTitle: 'Roygbiv',
|
||||
trackDurationMs: 137000,
|
||||
albumId: 'a1',
|
||||
albumTitle: 'Geogaddi',
|
||||
artistId: 'ar1',
|
||||
artistName: 'Boards of Canada',
|
||||
);
|
||||
ProviderContainer _container({required AppDb db, required QuarantineApi api}) {
|
||||
return ProviderContainer(overrides: [
|
||||
appDbProvider.overrideWithValue(db),
|
||||
quarantineApiProvider.overrideWith((ref) async => api),
|
||||
]);
|
||||
}
|
||||
|
||||
Future<void> _seed(AppDb db) async {
|
||||
await db.into(db.cachedQuarantineMine).insert(
|
||||
CachedQuarantineMineCompanion.insert(
|
||||
trackId: 't1',
|
||||
reason: 'bad_rip',
|
||||
createdAt: '2026-05-01T00:00:00Z',
|
||||
trackTitle: 'Roygbiv',
|
||||
albumId: 'a1',
|
||||
albumTitle: 'Geogaddi',
|
||||
artistId: 'ar1',
|
||||
artistName: 'Boards of Canada',
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
void main() {
|
||||
test('flag prepends synthetic row and calls server', () async {
|
||||
test('flag inserts a drift row and calls the server', skip: _skipDrift,
|
||||
() async {
|
||||
final db = AppDb(NativeDatabase.memory());
|
||||
addTearDown(db.close);
|
||||
final api = _StubQuarantineApi();
|
||||
final container = ProviderContainer(overrides: [
|
||||
quarantineApiProvider.overrideWith((ref) async => api),
|
||||
myQuarantineProvider.overrideWith(() => _StubController(const [])),
|
||||
]);
|
||||
final container = _container(db: db, api: api);
|
||||
addTearDown(container.dispose);
|
||||
|
||||
await container.read(myQuarantineProvider.future);
|
||||
await container.read(myQuarantineProvider.notifier).flag(_track, 'bad_rip', '');
|
||||
await container
|
||||
.read(myQuarantineProvider.notifier)
|
||||
.flag(_track, 'bad_rip', '');
|
||||
|
||||
expect(api.flagCalls, 1);
|
||||
final list = container.read(myQuarantineProvider).value!;
|
||||
expect(list, hasLength(1));
|
||||
expect(list.first.trackId, 't1');
|
||||
expect(list.first.reason, 'bad_rip');
|
||||
final rows = await db.select(db.cachedQuarantineMine).get();
|
||||
expect(rows, hasLength(1));
|
||||
expect(rows.first.trackId, 't1');
|
||||
expect(rows.first.reason, 'bad_rip');
|
||||
});
|
||||
|
||||
test('flag rolls back on server failure', () async {
|
||||
test('flag keeps drift optimistic + queues mutation on server failure',
|
||||
skip: _skipDrift, () async {
|
||||
final db = AppDb(NativeDatabase.memory());
|
||||
addTearDown(db.close);
|
||||
final api = _StubQuarantineApi(shouldThrow: true);
|
||||
final container = ProviderContainer(overrides: [
|
||||
quarantineApiProvider.overrideWith((ref) async => api),
|
||||
myQuarantineProvider.overrideWith(() => _StubController(const [])),
|
||||
]);
|
||||
final container = _container(db: db, api: api);
|
||||
addTearDown(container.dispose);
|
||||
|
||||
await container.read(myQuarantineProvider.future);
|
||||
await expectLater(
|
||||
() => container
|
||||
.read(myQuarantineProvider.notifier)
|
||||
.flag(_track, 'bad_rip', ''),
|
||||
throwsException,
|
||||
);
|
||||
expect(container.read(myQuarantineProvider).value, isEmpty);
|
||||
// No longer rethrows — flag swallows the REST failure and queues
|
||||
// for replay so the user's intent persists offline.
|
||||
await container
|
||||
.read(myQuarantineProvider.notifier)
|
||||
.flag(_track, 'bad_rip', '');
|
||||
final rows = await db.select(db.cachedQuarantineMine).get();
|
||||
expect(rows, hasLength(1),
|
||||
reason: 'optimistic drift row should persist across REST failure');
|
||||
final mutations = await db.select(db.cachedMutations).get();
|
||||
expect(mutations, hasLength(1),
|
||||
reason: 'failed flag should have been enqueued for replay');
|
||||
expect(mutations.first.kind, 'quarantine.flag');
|
||||
});
|
||||
|
||||
test('unflag removes the row and calls server', () async {
|
||||
test('unflag deletes the drift row and calls the server', skip: _skipDrift,
|
||||
() async {
|
||||
final db = AppDb(NativeDatabase.memory());
|
||||
addTearDown(db.close);
|
||||
await _seed(db);
|
||||
final api = _StubQuarantineApi();
|
||||
final container = ProviderContainer(overrides: [
|
||||
quarantineApiProvider.overrideWith((ref) async => api),
|
||||
myQuarantineProvider.overrideWith(() => _StubController(const [_existing])),
|
||||
]);
|
||||
final container = _container(db: db, api: api);
|
||||
addTearDown(container.dispose);
|
||||
|
||||
await container.read(myQuarantineProvider.future);
|
||||
await container.read(myQuarantineProvider.notifier).unflag('t1');
|
||||
|
||||
expect(api.unflagCalls, 1);
|
||||
expect(container.read(myQuarantineProvider).value, isEmpty);
|
||||
final rows = await db.select(db.cachedQuarantineMine).get();
|
||||
expect(rows, isEmpty);
|
||||
});
|
||||
|
||||
test('isHidden reflects current state', () async {
|
||||
final container = ProviderContainer(overrides: [
|
||||
myQuarantineProvider.overrideWith(() => _StubController(const [_existing])),
|
||||
]);
|
||||
test('isHidden reflects drift state', skip: _skipDrift, () async {
|
||||
final db = AppDb(NativeDatabase.memory());
|
||||
addTearDown(db.close);
|
||||
await _seed(db);
|
||||
final api = _StubQuarantineApi();
|
||||
final container = _container(db: db, api: api);
|
||||
addTearDown(container.dispose);
|
||||
|
||||
await container.read(myQuarantineProvider.future);
|
||||
|
||||
@@ -5,10 +5,12 @@ go 1.23.0
|
||||
require (
|
||||
github.com/dhowden/tag v0.0.0-20240417053706-3d75831295e8
|
||||
github.com/go-chi/chi/v5 v5.2.5
|
||||
github.com/go-co-op/gocron/v2 v2.21.2
|
||||
github.com/golang-migrate/migrate/v4 v4.18.2
|
||||
github.com/google/uuid v1.6.0
|
||||
github.com/jackc/pgerrcode v0.0.0-20220416144525-469b46aa5efa
|
||||
github.com/jackc/pgx/v5 v5.7.4
|
||||
github.com/stretchr/testify v1.9.0
|
||||
github.com/stretchr/testify v1.11.1
|
||||
golang.org/x/crypto v0.35.0
|
||||
gopkg.in/yaml.v3 v3.0.1
|
||||
)
|
||||
@@ -20,7 +22,9 @@ require (
|
||||
github.com/jackc/pgpassfile v1.0.0 // indirect
|
||||
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
|
||||
github.com/jackc/puddle/v2 v2.2.2 // indirect
|
||||
github.com/jonboulle/clockwork v0.5.0 // indirect
|
||||
github.com/pmezard/go-difflib v1.0.0 // indirect
|
||||
github.com/robfig/cron/v3 v3.0.1 // indirect
|
||||
github.com/rogpeppe/go-internal v1.14.1 // indirect
|
||||
go.uber.org/atomic v1.7.0 // indirect
|
||||
golang.org/x/sync v0.11.0 // indirect
|
||||
|
||||
@@ -21,6 +21,8 @@ github.com/felixge/httpsnoop v1.0.4 h1:NFTV2Zj1bL4mc9sqWACXbQFVBBg2W3GPvqp8/ESS2
|
||||
github.com/felixge/httpsnoop v1.0.4/go.mod h1:m8KPJKqk1gH5J9DgRY2ASl2lWCfGKXixSwevea8zH2U=
|
||||
github.com/go-chi/chi/v5 v5.2.5 h1:Eg4myHZBjyvJmAFjFvWgrqDTXFyOzjj7YIm3L3mu6Ug=
|
||||
github.com/go-chi/chi/v5 v5.2.5/go.mod h1:X7Gx4mteadT3eDOMTsXzmI4/rwUpOwBHLpAfupzFJP0=
|
||||
github.com/go-co-op/gocron/v2 v2.21.2 h1:bD8/YwkojYHgXFr3iEulL148KBdTbKVxUZzFKpXcdbY=
|
||||
github.com/go-co-op/gocron/v2 v2.21.2/go.mod h1:5lEiCKk1oVJV39Zg7/YG10OnaVrDAV5GGR6O0663k6U=
|
||||
github.com/go-logr/logr v1.4.2 h1:6pFjapn8bFcIbiKo3XT4j/BhANplGihG6tvd+8rYgrY=
|
||||
github.com/go-logr/logr v1.4.2/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY=
|
||||
github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag=
|
||||
@@ -29,6 +31,8 @@ github.com/gogo/protobuf v1.3.2 h1:Ov1cvc58UF3b5XjBnZv7+opcTcQFZebYjWzi34vdm4Q=
|
||||
github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q=
|
||||
github.com/golang-migrate/migrate/v4 v4.18.2 h1:2VSCMz7x7mjyTXx3m2zPokOY82LTRgxK1yQYKo6wWQ8=
|
||||
github.com/golang-migrate/migrate/v4 v4.18.2/go.mod h1:2CM6tJvn2kqPXwnXO/d3rAQYiyoIm180VsO8PRX6Rpk=
|
||||
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
|
||||
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
|
||||
github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
|
||||
github.com/hashicorp/errwrap v1.1.0 h1:OxrOeh75EUXMY8TBjag2fzXGZ40LB6IKw45YeGUDY2I=
|
||||
github.com/hashicorp/errwrap v1.1.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
|
||||
@@ -44,6 +48,8 @@ github.com/jackc/pgx/v5 v5.7.4 h1:9wKznZrhWa2QiHL+NjTSPP6yjl3451BX3imWDnokYlg=
|
||||
github.com/jackc/pgx/v5 v5.7.4/go.mod h1:ncY89UGWxg82EykZUwSpUKEfccBGGYq1xjrOpsbsfGQ=
|
||||
github.com/jackc/puddle/v2 v2.2.2 h1:PR8nw+E/1w0GLuRFSmiioY6UooMp6KJv0/61nB7icHo=
|
||||
github.com/jackc/puddle/v2 v2.2.2/go.mod h1:vriiEXHvEE654aYKXXjOvZM39qJ0q+azkZFrfEOc3H4=
|
||||
github.com/jonboulle/clockwork v0.5.0 h1:Hyh9A8u51kptdkR+cqRpT1EebBwTn1oK9YfGYbdFz6I=
|
||||
github.com/jonboulle/clockwork v0.5.0/go.mod h1:3mZlmanh0g2NDKO5TWZVJAfofYk64M7XN3SzBPjZF60=
|
||||
github.com/kr/pretty v0.3.0 h1:WgNl7dwNpEZ6jJ9k1snq4pZsg7DOEN8hP9Xw0Tsjwk0=
|
||||
github.com/kr/pretty v0.3.0/go.mod h1:640gp4NfQd8pI5XOwp5fnNeVWj67G7CFk/SaSQn7NBk=
|
||||
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
|
||||
@@ -64,13 +70,15 @@ github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
|
||||
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
|
||||
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
|
||||
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
|
||||
github.com/robfig/cron/v3 v3.0.1 h1:WdRxkvbJztn8LMz/QEvLN5sBU+xKpSqwwUO1Pjr4qDs=
|
||||
github.com/robfig/cron/v3 v3.0.1/go.mod h1:eQICP3HwyT7UooqI/z+Ov+PtYAWygg1TEWWzGIFLtro=
|
||||
github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ=
|
||||
github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7so1lCWt35ZSgc=
|
||||
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
|
||||
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
|
||||
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
|
||||
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
|
||||
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
|
||||
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
|
||||
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
|
||||
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.54.0 h1:TT4fX+nBOA/+LUkobKGW1ydGcn+G3vRw9+g5HwCphpk=
|
||||
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.54.0/go.mod h1:L7UH0GbB0p47T4Rri3uHjbpCFYrVrwc1I25QhNPiGK8=
|
||||
go.opentelemetry.io/otel v1.29.0 h1:PdomN/Al4q/lN6iBJEN3AwPvUiHPMlt93c8bqTG5Llw=
|
||||
@@ -81,6 +89,8 @@ go.opentelemetry.io/otel/trace v1.29.0 h1:J/8ZNK4XgR7a21DZUAsbF8pZ5Jcw1VhACmnYt3
|
||||
go.opentelemetry.io/otel/trace v1.29.0/go.mod h1:eHl3w0sp3paPkYstJOmAimxhiFXPg+MMTlEh3nsQgWQ=
|
||||
go.uber.org/atomic v1.7.0 h1:ADUqmZGgLDDfbSL9ZmPxKTybcoEYHgpYfELNoN+7hsw=
|
||||
go.uber.org/atomic v1.7.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc=
|
||||
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
|
||||
go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
|
||||
golang.org/x/crypto v0.35.0 h1:b15kiHdrGCHrP6LvwaQ3c03kgNhhiMgvlhxHQhmg2Xs=
|
||||
golang.org/x/crypto v0.35.0/go.mod h1:dy7dXNW32cAb/6/PRuTNsix8T+vJAqvuIy5Bli/x0YQ=
|
||||
golang.org/x/sync v0.11.0 h1:GGz8+XQP4FvTTrjZPzNKTMFtSXH80RAzG+5ghFPgK9w=
|
||||
|
||||
@@ -111,6 +111,8 @@ func (h *handlers) handleResolveQuarantine(w http.ResponseWriter, r *http.Reques
|
||||
writeAdminJSONErr(w, http.StatusInternalServerError, "server_error")
|
||||
return
|
||||
}
|
||||
// Broadcast: affects every user who'd flagged this track.
|
||||
h.publishQuarantineEvent("quarantine.resolved", pgtype.UUID{}, id, true)
|
||||
writeJSON(w, http.StatusOK, actionResultView{
|
||||
ActionID: uuidToString(action.ID),
|
||||
AffectedUsers: action.AffectedUsers,
|
||||
@@ -140,6 +142,9 @@ func (h *handlers) handleDeleteQuarantineFile(w http.ResponseWriter, r *http.Req
|
||||
}
|
||||
return
|
||||
}
|
||||
// Broadcast: the track row is gone; every client's library/likes/queue
|
||||
// invalidates so stale references stop showing.
|
||||
h.publishQuarantineEvent("quarantine.file_deleted", pgtype.UUID{}, id, true)
|
||||
writeJSON(w, http.StatusOK, actionResultView{
|
||||
ActionID: uuidToString(action.ID),
|
||||
AffectedUsers: action.AffectedUsers,
|
||||
@@ -179,6 +184,8 @@ func (h *handlers) handleDeleteQuarantineViaLidarr(w http.ResponseWriter, r *htt
|
||||
}
|
||||
return
|
||||
}
|
||||
// Broadcast: same rationale as delete-file — track row gone everywhere.
|
||||
h.publishQuarantineEvent("quarantine.deleted_via_lidarr", pgtype.UUID{}, id, true)
|
||||
writeJSON(w, http.StatusOK, actionResultView{
|
||||
ActionID: uuidToString(action.ID),
|
||||
AffectedUsers: action.AffectedUsers,
|
||||
|
||||
@@ -125,6 +125,7 @@ func (h *handlers) handleApproveRequest(w http.ResponseWriter, r *http.Request)
|
||||
return
|
||||
}
|
||||
|
||||
h.publishRequestStatusChanged(row)
|
||||
writeJSON(w, http.StatusOK, requestViewFrom(row))
|
||||
}
|
||||
|
||||
@@ -164,5 +165,6 @@ func (h *handlers) handleRejectRequest(w http.ResponseWriter, r *http.Request) {
|
||||
return
|
||||
}
|
||||
|
||||
h.publishRequestStatusChanged(row)
|
||||
writeJSON(w, http.StatusOK, requestViewFrom(row))
|
||||
}
|
||||
|
||||
+9
-1
@@ -14,6 +14,7 @@ import (
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/auth"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/config"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/coverart"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/eventbus"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/library"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/lidarrconfig"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/lidarrquarantine"
|
||||
@@ -27,7 +28,7 @@ import (
|
||||
// Mount attaches /api/* handlers to r. Public endpoints (login) are outside
|
||||
// RequireUser; everything else is gated by the middleware. The events writer
|
||||
// is shared with the Subsonic mount so /rest/scrobble feeds the same store.
|
||||
func Mount(r chi.Router, pool *pgxpool.Pool, logger *slog.Logger, events *playevents.Writer, recCfg config.RecommendationConfig, lidarrCfg *lidarrconfig.Service, lidarrReqs *lidarrrequests.Service, lidarrQuar *lidarrquarantine.Service, tracksSvc *tracks.Service, playlistsSvc *playlists.Service, coverEnricher *coverart.Enricher, coverBackfillCap int, coverSettings *coverart.SettingsService, scanner *library.Scanner, scanCfg library.RunScanConfig, scheduler *library.Scheduler, dataDir string, sender mailer.Sender) {
|
||||
func Mount(r chi.Router, pool *pgxpool.Pool, logger *slog.Logger, events *playevents.Writer, recCfg config.RecommendationConfig, lidarrCfg *lidarrconfig.Service, lidarrReqs *lidarrrequests.Service, lidarrQuar *lidarrquarantine.Service, tracksSvc *tracks.Service, playlistsSvc *playlists.Service, coverEnricher *coverart.Enricher, coverBackfillCap int, coverSettings *coverart.SettingsService, scanner *library.Scanner, scanCfg library.RunScanConfig, scheduler *library.Scheduler, dataDir string, sender mailer.Sender, bus *eventbus.Bus, playlistScheduler *playlists.Scheduler) {
|
||||
rng := rand.New(rand.NewSource(rand.Int63()))
|
||||
h := &handlers{
|
||||
pool: pool, logger: logger, events: events, recCfg: recCfg,
|
||||
@@ -45,6 +46,8 @@ func Mount(r chi.Router, pool *pgxpool.Pool, logger *slog.Logger, events *playev
|
||||
scheduler: scheduler,
|
||||
dataDir: dataDir,
|
||||
mailer: sender,
|
||||
eventbus: bus,
|
||||
playlistScheduler: playlistScheduler,
|
||||
}
|
||||
|
||||
r.Route("/api", func(api chi.Router) {
|
||||
@@ -62,6 +65,7 @@ func Mount(r chi.Router, pool *pgxpool.Pool, logger *slog.Logger, events *playev
|
||||
authed.Get("/me/history", h.handleGetMyHistory)
|
||||
authed.Put("/me/password", h.handleChangePassword)
|
||||
authed.Put("/me/profile", h.handleUpdateMyProfile)
|
||||
authed.Put("/me/timezone", h.handlePutTimezone)
|
||||
authed.Get("/me/api-token", h.handleGetMyAPIToken)
|
||||
authed.Post("/me/api-token", h.handleRegenerateMyAPIToken)
|
||||
|
||||
@@ -78,7 +82,9 @@ func Mount(r chi.Router, pool *pgxpool.Pool, logger *slog.Logger, events *playev
|
||||
authed.Get("/radio", h.handleRadio)
|
||||
authed.Get("/discover/suggestions", h.handleListSuggestions)
|
||||
authed.Get("/home", h.handleGetHome)
|
||||
authed.Get("/home/index", h.handleGetHomeIndex)
|
||||
authed.Post("/events", h.handleEvents)
|
||||
authed.Get("/events/stream", h.handleEventsStream)
|
||||
authed.Post("/likes/tracks/{id}", h.handleLikeTrack)
|
||||
authed.Delete("/likes/tracks/{id}", h.handleUnlikeTrack)
|
||||
authed.Post("/likes/albums/{id}", h.handleLikeAlbum)
|
||||
@@ -191,4 +197,6 @@ type handlers struct {
|
||||
scheduler *library.Scheduler
|
||||
dataDir string
|
||||
mailer mailer.Sender
|
||||
eventbus *eventbus.Bus
|
||||
playlistScheduler *playlists.Scheduler
|
||||
}
|
||||
|
||||
@@ -202,6 +202,17 @@ func (h *handlers) handleRegister(w http.ResponseWriter, r *http.Request) {
|
||||
map[string]any{"token": usedInviteToken})
|
||||
}
|
||||
|
||||
// Register the new user with the playlist scheduler so their daily
|
||||
// builds are scheduled without waiting for the hourly reconciliation
|
||||
// pass. Failure here is logged but doesn't fail registration — the
|
||||
// next hourly pass will pick them up.
|
||||
if h.playlistScheduler != nil {
|
||||
if err := h.playlistScheduler.Refresh(r.Context(), user.ID); err != nil {
|
||||
h.logger.Warn("api: scheduler refresh after registration",
|
||||
"user_id", uuidToString(user.ID), "err", err)
|
||||
}
|
||||
}
|
||||
|
||||
writeJSON(w, http.StatusOK, LoginResponse{
|
||||
Token: sessionToken,
|
||||
User: UserView{
|
||||
|
||||
@@ -0,0 +1,109 @@
|
||||
// Small helpers for posting live events to the SSE bus (#392). Producers
|
||||
// call these from their handler success paths so the wire shape stays in
|
||||
// one place. Each helper is a no-op when h.eventbus is nil (older callers
|
||||
// or tests that don't construct a bus); production always has one.
|
||||
|
||||
package api
|
||||
|
||||
import (
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/eventbus"
|
||||
"github.com/jackc/pgx/v5/pgtype"
|
||||
)
|
||||
|
||||
// publishLikeEvent broadcasts a track/album/artist like or unlike. The
|
||||
// event is scoped to the user (so only their own clients invalidate); the
|
||||
// payload includes the entity_type and entity_id so the dispatcher can
|
||||
// invalidate the right query keys.
|
||||
func (h *handlers) publishLikeEvent(userID, entityID pgtype.UUID, entityType string, liked bool) {
|
||||
if h.eventbus == nil {
|
||||
return
|
||||
}
|
||||
kind := "track.liked"
|
||||
if !liked {
|
||||
kind = "track.unliked"
|
||||
}
|
||||
if entityType == "album" {
|
||||
if liked {
|
||||
kind = "album.liked"
|
||||
} else {
|
||||
kind = "album.unliked"
|
||||
}
|
||||
}
|
||||
if entityType == "artist" {
|
||||
if liked {
|
||||
kind = "artist.liked"
|
||||
} else {
|
||||
kind = "artist.unliked"
|
||||
}
|
||||
}
|
||||
h.eventbus.Publish(eventbus.Event{
|
||||
Kind: kind,
|
||||
UserID: uuidToString(userID),
|
||||
Data: map[string]any{
|
||||
"entity_type": entityType,
|
||||
"entity_id": uuidToString(entityID),
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
// publishQuarantineEvent broadcasts a quarantine action. User-side
|
||||
// flag/unflag are scoped to the user; admin-side resolve / delete-file /
|
||||
// delete-via-lidarr are broadcast (empty UserID) because a single admin
|
||||
// action can affect every user who'd flagged that track — every client
|
||||
// invalidates and the non-affected ones no-op when the query result
|
||||
// matches their cache.
|
||||
func (h *handlers) publishQuarantineEvent(kind string, userID, trackID pgtype.UUID, broadcast bool) {
|
||||
if h.eventbus == nil {
|
||||
return
|
||||
}
|
||||
scope := ""
|
||||
if !broadcast {
|
||||
scope = uuidToString(userID)
|
||||
}
|
||||
h.eventbus.Publish(eventbus.Event{
|
||||
Kind: kind,
|
||||
UserID: scope,
|
||||
Data: map[string]any{
|
||||
"track_id": uuidToString(trackID),
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
// publishPlaylistEvent broadcasts a playlist mutation to the owner so
|
||||
// their other clients invalidate the affected playlist (and playlist list)
|
||||
// providers. Public-playlist subscribers are out of scope here — they'd
|
||||
// need a separate "playlists.public_updated" broadcast, deferred until
|
||||
// the multi-user case is exercised.
|
||||
func (h *handlers) publishPlaylistEvent(kind string, ownerID, playlistID pgtype.UUID) {
|
||||
if h.eventbus == nil {
|
||||
return
|
||||
}
|
||||
h.eventbus.Publish(eventbus.Event{
|
||||
Kind: kind,
|
||||
UserID: uuidToString(ownerID),
|
||||
Data: map[string]any{
|
||||
"playlist_id": uuidToString(playlistID),
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
// publishRequestStatusChanged broadcasts a Lidarr request status flip to
|
||||
// the request's original requester so their /requests page reflects the
|
||||
// new state without manual refresh. Admin actors (approve / reject) still
|
||||
// route to the requester's user_id, not the admin's — the original user
|
||||
// is who needs to see the update.
|
||||
func (h *handlers) publishRequestStatusChanged(row dbq.LidarrRequest) {
|
||||
if h.eventbus == nil {
|
||||
return
|
||||
}
|
||||
h.eventbus.Publish(eventbus.Event{
|
||||
Kind: "request.status_changed",
|
||||
UserID: uuidToString(row.UserID),
|
||||
Data: map[string]any{
|
||||
"request_id": uuidToString(row.ID),
|
||||
"status": string(row.Status),
|
||||
"kind": string(row.Kind),
|
||||
},
|
||||
})
|
||||
}
|
||||
@@ -0,0 +1,135 @@
|
||||
// Live event stream — Server-Sent Events at GET /api/events/stream.
|
||||
//
|
||||
// Clients (today: Flutter) subscribe to be notified of state changes
|
||||
// elsewhere in the system (likes, request status flips, quarantine
|
||||
// resolutions, scan progress, playlist mutations) so static screens
|
||||
// can invalidate cached data without explicit user action.
|
||||
//
|
||||
// Wire-format: standard SSE. Each event has the shape
|
||||
//
|
||||
// event: <kind>
|
||||
// data: <json payload>
|
||||
//
|
||||
// where <kind> follows "domain.action" naming and <json payload>
|
||||
// matches `eventbus.Event`. A heartbeat comment line is emitted every
|
||||
// 15 seconds to keep idle connections alive through proxies / NATs.
|
||||
//
|
||||
// Scoping: events with `user_id` matching the connected user OR with
|
||||
// empty `user_id` (broadcast) are forwarded. Other users' events are
|
||||
// dropped silently before reaching the wire.
|
||||
|
||||
package api
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"time"
|
||||
|
||||
"github.com/jackc/pgx/v5/pgtype"
|
||||
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/auth"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/eventbus"
|
||||
)
|
||||
|
||||
// userUUIDString renders a pgtype.UUID in canonical 8-4-4-4-12 form so
|
||||
// the SSE handler can compare against eventbus.Event.UserID strings.
|
||||
// Other packages keep their own copies of this same pattern; consolidating
|
||||
// is out of scope for this slice.
|
||||
func userUUIDString(u pgtype.UUID) string {
|
||||
if !u.Valid {
|
||||
return ""
|
||||
}
|
||||
return fmt.Sprintf("%x-%x-%x-%x-%x",
|
||||
u.Bytes[0:4], u.Bytes[4:6], u.Bytes[6:8], u.Bytes[8:10], u.Bytes[10:16])
|
||||
}
|
||||
|
||||
const (
|
||||
// sseSubscriberBuffer bounds per-connection event queue depth. Events
|
||||
// beyond this are dropped (logged at debug); the client resyncs via
|
||||
// normal /api/* fetches when reconnecting or focusing.
|
||||
sseSubscriberBuffer = 64
|
||||
// sseHeartbeatInterval keeps proxy connections alive. SSE spec allows
|
||||
// a comment line (starts with ":") as a no-op heartbeat.
|
||||
sseHeartbeatInterval = 15 * time.Second
|
||||
)
|
||||
|
||||
func (h *handlers) handleEventsStream(w http.ResponseWriter, r *http.Request) {
|
||||
user, ok := auth.UserFromContext(r.Context())
|
||||
if !ok {
|
||||
http.Error(w, "unauthorized", http.StatusUnauthorized)
|
||||
return
|
||||
}
|
||||
|
||||
flusher, ok := w.(http.Flusher)
|
||||
if !ok {
|
||||
http.Error(w, "streaming unsupported", http.StatusInternalServerError)
|
||||
return
|
||||
}
|
||||
|
||||
// Standard SSE headers. X-Accel-Buffering disables nginx's response
|
||||
// buffering when Minstrel sits behind it; harmless on direct
|
||||
// connections.
|
||||
w.Header().Set("Content-Type", "text/event-stream")
|
||||
w.Header().Set("Cache-Control", "no-cache")
|
||||
w.Header().Set("Connection", "keep-alive")
|
||||
w.Header().Set("X-Accel-Buffering", "no")
|
||||
w.WriteHeader(http.StatusOK)
|
||||
|
||||
// Initial comment so the client sees the connection open immediately
|
||||
// even if no real event lands for a while.
|
||||
if _, err := fmt.Fprintf(w, ": connected\n\n"); err != nil {
|
||||
return
|
||||
}
|
||||
flusher.Flush()
|
||||
|
||||
ch, unsub := h.eventbus.Subscribe(sseSubscriberBuffer)
|
||||
defer unsub()
|
||||
|
||||
heartbeat := time.NewTicker(sseHeartbeatInterval)
|
||||
defer heartbeat.Stop()
|
||||
|
||||
userIDStr := userUUIDString(user.ID)
|
||||
ctx := r.Context()
|
||||
|
||||
for {
|
||||
select {
|
||||
case <-ctx.Done():
|
||||
return
|
||||
|
||||
case <-heartbeat.C:
|
||||
if _, err := fmt.Fprintf(w, ": heartbeat\n\n"); err != nil {
|
||||
return
|
||||
}
|
||||
flusher.Flush()
|
||||
|
||||
case e, ok := <-ch:
|
||||
if !ok {
|
||||
// Bus closed our subscription (rare; only on full shutdown).
|
||||
return
|
||||
}
|
||||
// Scope filter: forward only events scoped to this user or
|
||||
// broadcast events (empty UserID).
|
||||
if e.UserID != "" && e.UserID != userIDStr {
|
||||
continue
|
||||
}
|
||||
if err := writeSSEEvent(w, e); err != nil {
|
||||
return
|
||||
}
|
||||
flusher.Flush()
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// writeSSEEvent serializes one bus event in SSE wire format. JSON
|
||||
// marshal errors collapse the event to an "error" kind so the client
|
||||
// at least sees something rather than silent drops.
|
||||
func writeSSEEvent(w http.ResponseWriter, e eventbus.Event) error {
|
||||
payload, err := json.Marshal(e)
|
||||
if err != nil {
|
||||
_, werr := fmt.Fprintf(w, "event: error\ndata: {\"msg\":\"marshal failed\"}\n\n")
|
||||
return werr
|
||||
}
|
||||
_, err = fmt.Fprintf(w, "event: %s\ndata: %s\n\n", e.Kind, payload)
|
||||
return err
|
||||
}
|
||||
@@ -49,6 +49,54 @@ func (h *handlers) handleGetHome(w http.ResponseWriter, r *http.Request) {
|
||||
writeJSON(w, http.StatusOK, out)
|
||||
}
|
||||
|
||||
// handleGetHomeIndex implements GET /api/home/index. Returns the same
|
||||
// five sections /api/home computes, but as flat slices of entity IDs
|
||||
// rather than denormalized objects. Drives the Flutter per-item
|
||||
// rendering path — the client hydrates each tile against the
|
||||
// per-entity endpoints, so this response is tiny (a few KB at most)
|
||||
// and the cold-visit round-trip is correspondingly short.
|
||||
//
|
||||
// Shares the recommendation.HomeData computation with /api/home; the
|
||||
// DB cost is identical. A future optimisation could add ID-only
|
||||
// query variants, but the JSON savings already shrink the wire
|
||||
// payload by roughly an order of magnitude on populated libraries.
|
||||
func (h *handlers) handleGetHomeIndex(w http.ResponseWriter, r *http.Request) {
|
||||
user, ok := requireUser(w, r)
|
||||
if !ok {
|
||||
return
|
||||
}
|
||||
data, err := recommendation.HomeData(r.Context(), h.pool, user.ID)
|
||||
if err != nil {
|
||||
h.logger.Error("api: home index data", "err", err)
|
||||
writeErr(w, apierror.InternalMsg("failed to load home", err))
|
||||
return
|
||||
}
|
||||
|
||||
out := HomeIndexPayload{
|
||||
RecentlyAddedAlbums: make([]string, 0, len(data.RecentlyAddedAlbums)),
|
||||
RediscoverAlbums: make([]string, 0, len(data.RediscoverAlbums)),
|
||||
RediscoverArtists: make([]string, 0, len(data.RediscoverArtists)),
|
||||
MostPlayedTracks: make([]string, 0, len(data.MostPlayedTracks)),
|
||||
LastPlayedArtists: make([]string, 0, len(data.LastPlayedArtists)),
|
||||
}
|
||||
for _, row := range data.RecentlyAddedAlbums {
|
||||
out.RecentlyAddedAlbums = append(out.RecentlyAddedAlbums, uuidToString(row.Album.ID))
|
||||
}
|
||||
for _, row := range data.RediscoverAlbums {
|
||||
out.RediscoverAlbums = append(out.RediscoverAlbums, uuidToString(row.Album.ID))
|
||||
}
|
||||
for _, row := range data.RediscoverArtists {
|
||||
out.RediscoverArtists = append(out.RediscoverArtists, uuidToString(row.Artist.ID))
|
||||
}
|
||||
for _, row := range data.MostPlayedTracks {
|
||||
out.MostPlayedTracks = append(out.MostPlayedTracks, uuidToString(row.Track.ID))
|
||||
}
|
||||
for _, row := range data.LastPlayedArtists {
|
||||
out.LastPlayedArtists = append(out.LastPlayedArtists, uuidToString(row.Artist.ID))
|
||||
}
|
||||
writeJSON(w, http.StatusOK, out)
|
||||
}
|
||||
|
||||
// Compile-time guard that dbq has the row types we need; if the SQL is
|
||||
// regenerated with a different name, this fails fast at build time.
|
||||
var _ = dbq.ListMostPlayedTracksForUserRow{}.Track
|
||||
|
||||
@@ -77,3 +77,67 @@ func TestHome_RecentlyAddedSurfacesAlbums(t *testing.T) {
|
||||
t.Errorf("artist_name = %q, want ArtistOne", got.RecentlyAddedAlbums[0].ArtistName)
|
||||
}
|
||||
}
|
||||
|
||||
func newHomeIndexRouter(h *handlers) chi.Router {
|
||||
r := chi.NewRouter()
|
||||
r.Get("/api/home/index", h.handleGetHomeIndex)
|
||||
return r
|
||||
}
|
||||
|
||||
func doGetHomeIndex(h *handlers, user dbq.User) *httptest.ResponseRecorder {
|
||||
req := httptest.NewRequest(http.MethodGet, "/api/home/index", nil)
|
||||
req = withUser(req, user)
|
||||
w := httptest.NewRecorder()
|
||||
newHomeIndexRouter(h).ServeHTTP(w, req)
|
||||
return w
|
||||
}
|
||||
|
||||
func TestHomeIndex_EmptyForNewUser(t *testing.T) {
|
||||
h, pool := testHandlers(t)
|
||||
user := seedUser(t, pool, "alice", "pw", false)
|
||||
|
||||
w := doGetHomeIndex(h, user)
|
||||
if w.Code != http.StatusOK {
|
||||
t.Fatalf("status = %d, want 200; body = %s", w.Code, w.Body.String())
|
||||
}
|
||||
var got HomeIndexPayload
|
||||
if err := json.Unmarshal(w.Body.Bytes(), &got); err != nil {
|
||||
t.Fatalf("decode: %v", err)
|
||||
}
|
||||
// Same non-nil slice contract as /api/home so client parsers can
|
||||
// trust `length == 0` instead of branching on null.
|
||||
if got.RecentlyAddedAlbums == nil || got.RediscoverAlbums == nil ||
|
||||
got.RediscoverArtists == nil || got.MostPlayedTracks == nil ||
|
||||
got.LastPlayedArtists == nil {
|
||||
t.Errorf("payload has nil slice: %+v", got)
|
||||
}
|
||||
if len(got.RecentlyAddedAlbums) != 0 {
|
||||
t.Errorf("RecentlyAddedAlbums len = %d, want 0", len(got.RecentlyAddedAlbums))
|
||||
}
|
||||
}
|
||||
|
||||
func TestHomeIndex_RecentlyAddedReturnsIDs(t *testing.T) {
|
||||
h, pool := testHandlers(t)
|
||||
user := seedUser(t, pool, "alice", "pw", false)
|
||||
q := dbq.New(pool)
|
||||
artist, _ := q.UpsertArtist(context.Background(), dbq.UpsertArtistParams{
|
||||
Name: "ArtistOne", SortName: "ArtistOne",
|
||||
})
|
||||
album, _ := q.UpsertAlbum(context.Background(), dbq.UpsertAlbumParams{
|
||||
Title: "Newest", SortTitle: "Newest", ArtistID: artist.ID,
|
||||
})
|
||||
|
||||
w := doGetHomeIndex(h, user)
|
||||
if w.Code != http.StatusOK {
|
||||
t.Fatalf("status = %d, body = %s", w.Code, w.Body.String())
|
||||
}
|
||||
var got HomeIndexPayload
|
||||
_ = json.Unmarshal(w.Body.Bytes(), &got)
|
||||
if len(got.RecentlyAddedAlbums) != 1 {
|
||||
t.Fatalf("len = %d, want 1", len(got.RecentlyAddedAlbums))
|
||||
}
|
||||
want := uuidToString(album.ID)
|
||||
if got.RecentlyAddedAlbums[0] != want {
|
||||
t.Errorf("id = %q, want %q", got.RecentlyAddedAlbums[0], want)
|
||||
}
|
||||
}
|
||||
|
||||
+27
-20
@@ -40,19 +40,28 @@ func (h *handlers) handleGetTrack(w http.ResponseWriter, r *http.Request) {
|
||||
// handleGetAlbum implements GET /api/albums/{id}. Returns the album plus its
|
||||
// tracks (ordered by disc/track number via the underlying query) with
|
||||
// duration summed from the track list — keeps one source of truth.
|
||||
//
|
||||
// Two DB round trips: the album+artist join and the per-user tracks
|
||||
// list. Down from three (separate album, artist, tracks) before
|
||||
// GetAlbumWithArtist landed.
|
||||
func (h *handlers) handleGetAlbum(w http.ResponseWriter, r *http.Request) {
|
||||
q := dbq.New(h.pool)
|
||||
album, apiErr := resolveByID(r, "id", q.GetAlbumByID, "album")
|
||||
if apiErr != nil {
|
||||
writeErr(w, apiErr)
|
||||
id, ok := requireURLUUID(w, r, "id")
|
||||
if !ok {
|
||||
return
|
||||
}
|
||||
artist, err := q.GetArtistByID(r.Context(), album.ArtistID)
|
||||
row, err := q.GetAlbumWithArtist(r.Context(), id)
|
||||
if err != nil {
|
||||
h.logger.Error("api: get album artist failed", "err", err)
|
||||
if errors.Is(err, pgx.ErrNoRows) {
|
||||
writeErr(w, apierror.NotFound("album"))
|
||||
return
|
||||
}
|
||||
h.logger.Error("api: get album+artist failed", "err", err)
|
||||
writeErr(w, apierror.InternalMsg("lookup failed", err))
|
||||
return
|
||||
}
|
||||
album := row.Album
|
||||
artistName := row.ArtistName
|
||||
var userID pgtype.UUID
|
||||
if user, ok := auth.UserFromContext(r.Context()); ok {
|
||||
userID = user.ID
|
||||
@@ -68,20 +77,24 @@ func (h *handlers) handleGetAlbum(w http.ResponseWriter, r *http.Request) {
|
||||
refs := make([]TrackRef, 0, len(tracks))
|
||||
durSec := 0
|
||||
for _, t := range tracks {
|
||||
ref := trackRefFrom(t, album.Title, artist.Name)
|
||||
ref := trackRefFrom(t, album.Title, artistName)
|
||||
refs = append(refs, ref)
|
||||
durSec += ref.DurationSec
|
||||
}
|
||||
detail := AlbumDetail{
|
||||
AlbumRef: albumRefFrom(album, artist.Name, len(tracks), durSec),
|
||||
AlbumRef: albumRefFrom(album, artistName, len(tracks), durSec),
|
||||
Tracks: refs,
|
||||
}
|
||||
writeJSON(w, http.StatusOK, detail)
|
||||
}
|
||||
|
||||
// handleGetArtist implements GET /api/artists/{id}. Returns artist + albums;
|
||||
// each album carries its own track_count (one count query per album, same
|
||||
// pattern as subsonic). At M1 sizes (albums-per-artist << 100) this is fine.
|
||||
// each album carries its own track_count.
|
||||
//
|
||||
// Down from 1 + 1 + N queries (artist, albums, per-album CountTracksByAlbum)
|
||||
// to 1 + 1 (artist, albums-with-track-count via correlated subquery).
|
||||
// On a 30-album artist that's ~32 round trips collapsed to 2 — the
|
||||
// difference between "feels slow" and "feels instant" on detail nav.
|
||||
func (h *handlers) handleGetArtist(w http.ResponseWriter, r *http.Request) {
|
||||
q := dbq.New(h.pool)
|
||||
artist, apiErr := resolveByID(r, "id", q.GetArtistByID, "artist")
|
||||
@@ -89,25 +102,19 @@ func (h *handlers) handleGetArtist(w http.ResponseWriter, r *http.Request) {
|
||||
writeErr(w, apiErr)
|
||||
return
|
||||
}
|
||||
albums, err := q.ListAlbumsByArtist(r.Context(), artist.ID)
|
||||
rows, err := q.ListAlbumsByArtistWithTrackCount(r.Context(), artist.ID)
|
||||
if err != nil {
|
||||
h.logger.Error("api: list albums by artist failed", "err", err)
|
||||
writeErr(w, apierror.InternalMsg("lookup failed", err))
|
||||
return
|
||||
}
|
||||
refs := make([]AlbumRef, 0, len(albums))
|
||||
for _, a := range albums {
|
||||
count, cerr := q.CountTracksByAlbum(r.Context(), a.ID)
|
||||
if cerr != nil {
|
||||
h.logger.Error("api: count tracks failed", "err", cerr)
|
||||
writeErr(w, apierror.InternalMsg("lookup failed", cerr))
|
||||
return
|
||||
}
|
||||
refs := make([]AlbumRef, 0, len(rows))
|
||||
for _, row := range rows {
|
||||
// durationSec=0: not aggregated for nested album lists per spec data flow.
|
||||
refs = append(refs, albumRefFrom(a, artist.Name, int(count), 0))
|
||||
refs = append(refs, albumRefFrom(row.Album, artist.Name, int(row.TrackCount), 0))
|
||||
}
|
||||
detail := ArtistDetail{
|
||||
ArtistRef: artistRefFrom(artist, len(albums)),
|
||||
ArtistRef: artistRefFrom(artist, len(rows)),
|
||||
Albums: refs,
|
||||
}
|
||||
writeJSON(w, http.StatusOK, detail)
|
||||
|
||||
@@ -14,6 +14,7 @@ import (
|
||||
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/config"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/eventbus"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/playevents"
|
||||
)
|
||||
|
||||
@@ -443,7 +444,7 @@ func TestRoutesRegisteredInMount(t *testing.T) {
|
||||
r := chi.NewRouter()
|
||||
w := playevents.NewWriter(h.pool, slog.New(slog.NewTextHandler(io.Discard, nil)),
|
||||
30*time.Minute, 0.5, 30000)
|
||||
Mount(r, h.pool, h.logger, w, config.RecommendationConfig{RadioSize: 50, RadioSizeMax: 200, RecentlyPlayedHours: 1}, h.lidarrCfg, h.lidarrRequests, h.lidarrQuarantine, h.tracks, h.playlists, h.coverart, h.coverArtBackfillCap, h.coverSettings, h.scanner, h.scanCfg, nil, h.dataDir, nil)
|
||||
Mount(r, h.pool, h.logger, w, config.RecommendationConfig{RadioSize: 50, RadioSizeMax: 200, RecentlyPlayedHours: 1}, h.lidarrCfg, h.lidarrRequests, h.lidarrQuarantine, h.tracks, h.playlists, h.coverart, h.coverArtBackfillCap, h.coverSettings, h.scanner, h.scanCfg, nil, h.dataDir, nil, eventbus.New(), nil)
|
||||
|
||||
paths := []string{
|
||||
"/api/artists",
|
||||
|
||||
@@ -60,6 +60,7 @@ func (h *handlers) handleLikeTrack(w http.ResponseWriter, r *http.Request) {
|
||||
_ = playevents.CaptureContextualLikeIfPlaying(r.Context(), q, user.ID, id, h.logger)
|
||||
}
|
||||
h.logLikeChange(r, syncpkg.EntityLikeTrack, user.ID, id, syncpkg.OpUpsert)
|
||||
h.publishLikeEvent(user.ID, id, "track", true)
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
}
|
||||
|
||||
@@ -83,6 +84,7 @@ func (h *handlers) handleUnlikeTrack(w http.ResponseWriter, r *http.Request) {
|
||||
// Don't fail the response — soft-delete is best-effort.
|
||||
}
|
||||
h.logLikeChange(r, syncpkg.EntityLikeTrack, user.ID, id, syncpkg.OpDelete)
|
||||
h.publishLikeEvent(user.ID, id, "track", false)
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
}
|
||||
|
||||
@@ -111,6 +113,7 @@ func (h *handlers) handleLikeAlbum(w http.ResponseWriter, r *http.Request) {
|
||||
return
|
||||
}
|
||||
h.logLikeChange(r, syncpkg.EntityLikeAlbum, user.ID, id, syncpkg.OpUpsert)
|
||||
h.publishLikeEvent(user.ID, id, "album", true)
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
}
|
||||
|
||||
@@ -129,6 +132,7 @@ func (h *handlers) handleUnlikeAlbum(w http.ResponseWriter, r *http.Request) {
|
||||
return
|
||||
}
|
||||
h.logLikeChange(r, syncpkg.EntityLikeAlbum, user.ID, id, syncpkg.OpDelete)
|
||||
h.publishLikeEvent(user.ID, id, "album", false)
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
}
|
||||
|
||||
@@ -157,6 +161,7 @@ func (h *handlers) handleLikeArtist(w http.ResponseWriter, r *http.Request) {
|
||||
return
|
||||
}
|
||||
h.logLikeChange(r, syncpkg.EntityLikeArtist, user.ID, id, syncpkg.OpUpsert)
|
||||
h.publishLikeEvent(user.ID, id, "artist", true)
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
}
|
||||
|
||||
@@ -175,6 +180,7 @@ func (h *handlers) handleUnlikeArtist(w http.ResponseWriter, r *http.Request) {
|
||||
return
|
||||
}
|
||||
h.logLikeChange(r, syncpkg.EntityLikeArtist, user.ID, id, syncpkg.OpDelete)
|
||||
h.publishLikeEvent(user.ID, id, "artist", false)
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,70 @@
|
||||
// PUT /api/me/timezone — accept the client's IANA timezone and store
|
||||
// it on the user row. The system-playlist scheduler (#392 Half B)
|
||||
// reads this column to fire each user's daily 03:00 build in their
|
||||
// local time.
|
||||
//
|
||||
// Scheduler.Refresh(ctx, userID) is invoked in a later commit (Task 3)
|
||||
// so a timezone change takes effect synchronously rather than waiting
|
||||
// for the hourly reconciliation pass.
|
||||
|
||||
package api
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"net/http"
|
||||
"time"
|
||||
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/apierror"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/auth"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
||||
)
|
||||
|
||||
// putTimezoneBody is the JSON body for PUT /api/me/timezone.
|
||||
type putTimezoneBody struct {
|
||||
Timezone string `json:"timezone"`
|
||||
}
|
||||
|
||||
func (h *handlers) handlePutTimezone(w http.ResponseWriter, r *http.Request) {
|
||||
user, ok := auth.UserFromContext(r.Context())
|
||||
if !ok {
|
||||
writeErr(w, apierror.Unauthorized("unauthorized", "authentication required"))
|
||||
return
|
||||
}
|
||||
|
||||
var body putTimezoneBody
|
||||
if err := json.NewDecoder(r.Body).Decode(&body); err != nil {
|
||||
writeErr(w, apierror.BadRequest("bad_body", "invalid JSON body"))
|
||||
return
|
||||
}
|
||||
if body.Timezone == "" {
|
||||
writeErr(w, apierror.BadRequest("bad_body", "timezone is required"))
|
||||
return
|
||||
}
|
||||
if _, err := time.LoadLocation(body.Timezone); err != nil {
|
||||
writeErr(w, apierror.BadRequest("invalid_timezone",
|
||||
"timezone must be a valid IANA name (e.g. America/New_York)"))
|
||||
return
|
||||
}
|
||||
|
||||
q := dbq.New(h.pool)
|
||||
if err := q.UpdateUserTimezone(r.Context(), dbq.UpdateUserTimezoneParams{
|
||||
ID: user.ID,
|
||||
Timezone: body.Timezone,
|
||||
}); err != nil {
|
||||
h.logger.Error("api: update timezone", "err", err)
|
||||
writeErr(w, apierror.InternalMsg("update failed", err))
|
||||
return
|
||||
}
|
||||
|
||||
// Reschedule the user's daily build at their new timezone. Failure
|
||||
// here doesn't undo the DB write — the hourly reconciliation pass
|
||||
// would pick up the new tz within an hour at worst.
|
||||
if h.playlistScheduler != nil {
|
||||
if err := h.playlistScheduler.Refresh(r.Context(), user.ID); err != nil {
|
||||
h.logger.Warn("api: scheduler refresh after timezone update",
|
||||
"user_id", uuidToString(user.ID), "err", err)
|
||||
}
|
||||
}
|
||||
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
}
|
||||
@@ -0,0 +1,100 @@
|
||||
package api
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"encoding/json"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"os"
|
||||
"testing"
|
||||
|
||||
"github.com/go-chi/chi/v5"
|
||||
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
||||
)
|
||||
|
||||
func newMeTimezoneRouter(h *handlers) chi.Router {
|
||||
r := chi.NewRouter()
|
||||
r.Put("/api/me/timezone", h.handlePutTimezone)
|
||||
return r
|
||||
}
|
||||
|
||||
func TestPutTimezone_ValidIANA(t *testing.T) {
|
||||
if os.Getenv("MINSTREL_TEST_DATABASE_URL") == "" {
|
||||
t.Skip("MINSTREL_TEST_DATABASE_URL not set")
|
||||
}
|
||||
h, pool := testHandlers(t)
|
||||
user := seedUser(t, pool, "tz1", "irrelevant1", false)
|
||||
|
||||
body := bytes.NewBufferString(`{"timezone":"America/New_York"}`)
|
||||
req := httptest.NewRequest(http.MethodPut, "/api/me/timezone", body)
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
req = withUser(req, user)
|
||||
rec := httptest.NewRecorder()
|
||||
newMeTimezoneRouter(h).ServeHTTP(rec, req)
|
||||
|
||||
if rec.Code != http.StatusNoContent {
|
||||
t.Fatalf("status = %d, want 204; body=%s", rec.Code, rec.Body.String())
|
||||
}
|
||||
|
||||
// Verify the DB row was updated.
|
||||
got, err := dbq.New(pool).GetUserByID(context.Background(), user.ID)
|
||||
if err != nil {
|
||||
t.Fatalf("GetUserByID: %v", err)
|
||||
}
|
||||
if got.Timezone != "America/New_York" {
|
||||
t.Errorf("timezone = %q, want %q", got.Timezone, "America/New_York")
|
||||
}
|
||||
if !got.TimezoneUpdatedAt.Valid {
|
||||
t.Errorf("expected timezone_updated_at to be set after PUT")
|
||||
}
|
||||
}
|
||||
|
||||
func TestPutTimezone_InvalidIANA(t *testing.T) {
|
||||
if os.Getenv("MINSTREL_TEST_DATABASE_URL") == "" {
|
||||
t.Skip("MINSTREL_TEST_DATABASE_URL not set")
|
||||
}
|
||||
h, pool := testHandlers(t)
|
||||
user := seedUser(t, pool, "tz2", "irrelevant1", false)
|
||||
|
||||
body := bytes.NewBufferString(`{"timezone":"Not/A/Real/Zone"}`)
|
||||
req := httptest.NewRequest(http.MethodPut, "/api/me/timezone", body)
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
req = withUser(req, user)
|
||||
rec := httptest.NewRecorder()
|
||||
newMeTimezoneRouter(h).ServeHTTP(rec, req)
|
||||
|
||||
if rec.Code != http.StatusBadRequest {
|
||||
t.Fatalf("status = %d, want 400; body=%s", rec.Code, rec.Body.String())
|
||||
}
|
||||
|
||||
var errResp struct {
|
||||
Code string `json:"code"`
|
||||
}
|
||||
if err := json.NewDecoder(rec.Body).Decode(&errResp); err != nil {
|
||||
t.Fatalf("decode err response: %v", err)
|
||||
}
|
||||
if errResp.Code != "invalid_timezone" {
|
||||
t.Errorf("error code = %q, want invalid_timezone", errResp.Code)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPutTimezone_EmptyTimezone(t *testing.T) {
|
||||
if os.Getenv("MINSTREL_TEST_DATABASE_URL") == "" {
|
||||
t.Skip("MINSTREL_TEST_DATABASE_URL not set")
|
||||
}
|
||||
h, pool := testHandlers(t)
|
||||
user := seedUser(t, pool, "tz3", "irrelevant1", false)
|
||||
|
||||
body := bytes.NewBufferString(`{"timezone":""}`)
|
||||
req := httptest.NewRequest(http.MethodPut, "/api/me/timezone", body)
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
req = withUser(req, user)
|
||||
rec := httptest.NewRecorder()
|
||||
newMeTimezoneRouter(h).ServeHTTP(rec, req)
|
||||
|
||||
if rec.Code != http.StatusBadRequest {
|
||||
t.Fatalf("status = %d, want 400", rec.Code)
|
||||
}
|
||||
}
|
||||
@@ -112,6 +112,12 @@ func (h *handlers) handleGetCover(w http.ResponseWriter, r *http.Request) {
|
||||
return
|
||||
}
|
||||
w.Header().Set("Content-Type", imageContentType(path))
|
||||
// Cover bytes change rarely (cover-source enrichment, manual rescan,
|
||||
// rare MBID-driven re-fetch). One-day max-age + must-revalidate means
|
||||
// clients skip the conditional GET for the bulk of a session, but
|
||||
// stale art clears within 24h after a re-scan. ServeContent below
|
||||
// still emits Last-Modified for the conditional path when needed.
|
||||
w.Header().Set("Cache-Control", "public, max-age=86400, must-revalidate")
|
||||
http.ServeContent(w, r, filepath.Base(path), info.ModTime(), f)
|
||||
}
|
||||
|
||||
@@ -140,5 +146,11 @@ func (h *handlers) handleGetStream(w http.ResponseWriter, r *http.Request) {
|
||||
}
|
||||
w.Header().Set("Content-Type", audioContentType(track.FileFormat))
|
||||
w.Header().Set("Accept-Ranges", "bytes")
|
||||
// Track bytes are immutable for a given track id (the scanner
|
||||
// indexes by file_path; re-encoded files take new ids). One-year
|
||||
// max-age + immutable lets the client cache (LockCachingAudioSource
|
||||
// on the Flutter side, browser cache on web) skip even the
|
||||
// conditional GET on repeat plays.
|
||||
w.Header().Set("Cache-Control", "public, max-age=31536000, immutable")
|
||||
http.ServeContent(w, r, filepath.Base(track.FilePath), info.ModTime(), f)
|
||||
}
|
||||
|
||||
@@ -185,6 +185,7 @@ func (h *handlers) handleCreatePlaylist(w http.ResponseWriter, r *http.Request)
|
||||
h.writePlaylistErr(w, err, "create")
|
||||
return
|
||||
}
|
||||
h.publishPlaylistEvent("playlist.created", caller.ID, row.ID)
|
||||
writeJSON(w, http.StatusOK, playlistRowToView(row))
|
||||
}
|
||||
|
||||
@@ -240,6 +241,7 @@ func (h *handlers) handleUpdatePlaylist(w http.ResponseWriter, r *http.Request)
|
||||
h.writePlaylistErr(w, err, "update")
|
||||
return
|
||||
}
|
||||
h.publishPlaylistEvent("playlist.updated", caller.ID, playlistID)
|
||||
writeJSON(w, http.StatusOK, playlistRowToView(row))
|
||||
}
|
||||
|
||||
@@ -258,6 +260,7 @@ func (h *handlers) handleDeletePlaylist(w http.ResponseWriter, r *http.Request)
|
||||
h.writePlaylistErr(w, err, "delete")
|
||||
return
|
||||
}
|
||||
h.publishPlaylistEvent("playlist.deleted", caller.ID, playlistID)
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
}
|
||||
|
||||
@@ -294,6 +297,7 @@ func (h *handlers) handleAppendTracks(w http.ResponseWriter, r *http.Request) {
|
||||
h.writePlaylistErr(w, err, "append tracks")
|
||||
return
|
||||
}
|
||||
h.publishPlaylistEvent("playlist.tracks_changed", caller.ID, playlistID)
|
||||
detail, err := h.playlists.Get(r.Context(), caller.ID, playlistID)
|
||||
if err != nil {
|
||||
h.writePlaylistErr(w, err, "get-after-append")
|
||||
@@ -323,6 +327,7 @@ func (h *handlers) handleRemovePlaylistTrack(w http.ResponseWriter, r *http.Requ
|
||||
h.writePlaylistErr(w, err, "remove track")
|
||||
return
|
||||
}
|
||||
h.publishPlaylistEvent("playlist.tracks_changed", caller.ID, playlistID)
|
||||
detail, err := h.playlists.Get(r.Context(), caller.ID, playlistID)
|
||||
if err != nil {
|
||||
h.writePlaylistErr(w, err, "get-after-remove")
|
||||
@@ -355,6 +360,7 @@ func (h *handlers) handleReorderPlaylist(w http.ResponseWriter, r *http.Request)
|
||||
h.writePlaylistErr(w, err, "reorder")
|
||||
return
|
||||
}
|
||||
h.publishPlaylistEvent("playlist.tracks_changed", caller.ID, playlistID)
|
||||
detail, err := h.playlists.Get(r.Context(), caller.ID, playlistID)
|
||||
if err != nil {
|
||||
h.writePlaylistErr(w, err, "get-after-reorder")
|
||||
@@ -386,6 +392,11 @@ func (h *handlers) handleGetPlaylistCover(w http.ResponseWriter, r *http.Request
|
||||
return
|
||||
}
|
||||
full := filepath.Join(h.dataDir, *detail.CoverPath)
|
||||
// Playlist collages recompute when the playlist's tracks change
|
||||
// (system playlists re-rendered on rebuild, user playlists when
|
||||
// modified). 5 minutes is short enough for normal edits to feel
|
||||
// fresh, long enough to skip repeat fetches during a session.
|
||||
w.Header().Set("Cache-Control", "public, max-age=300, must-revalidate")
|
||||
http.ServeFile(w, r, full)
|
||||
}
|
||||
|
||||
|
||||
@@ -67,6 +67,9 @@ func (h *handlers) handleFlag(w http.ResponseWriter, r *http.Request) {
|
||||
}
|
||||
return
|
||||
}
|
||||
// Broadcast: the flagging user's other clients invalidate their
|
||||
// Hidden tab; admins' clients invalidate their quarantine queue.
|
||||
h.publishQuarantineEvent("quarantine.flagged", user.ID, trackID, true)
|
||||
writeJSON(w, http.StatusCreated, quarantineViewFrom(row))
|
||||
}
|
||||
|
||||
@@ -89,6 +92,8 @@ func (h *handlers) handleUnflag(w http.ResponseWriter, r *http.Request) {
|
||||
writeErr(w, apierror.InternalMsg("unflag failed", err))
|
||||
return
|
||||
}
|
||||
// Scoped to user: only their other clients need to invalidate.
|
||||
h.publishQuarantineEvent("quarantine.unflagged", user.ID, id, false)
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
}
|
||||
|
||||
|
||||
@@ -175,6 +175,7 @@ func (h *handlers) handleCreateRequest(w http.ResponseWriter, r *http.Request) {
|
||||
}
|
||||
}
|
||||
|
||||
h.publishRequestStatusChanged(row)
|
||||
writeJSON(w, http.StatusCreated, requestViewFrom(row))
|
||||
}
|
||||
|
||||
@@ -254,5 +255,6 @@ func (h *handlers) handleCancelRequest(w http.ResponseWriter, r *http.Request) {
|
||||
return
|
||||
}
|
||||
|
||||
h.publishRequestStatusChanged(row)
|
||||
writeJSON(w, http.StatusOK, requestViewFrom(row))
|
||||
}
|
||||
|
||||
@@ -118,6 +118,24 @@ type HomePayload struct {
|
||||
LastPlayedArtists []ArtistRef `json:"last_played_artists"`
|
||||
}
|
||||
|
||||
// HomeIndexPayload is the response body of GET /api/home/index — the
|
||||
// per-item rendering variant of /api/home. Same sections, same caps,
|
||||
// but each section is a flat slice of entity IDs (UUID strings)
|
||||
// instead of denormalized objects. Slices are non-nil at JSON encode
|
||||
// time so empty sections render as `[]`.
|
||||
//
|
||||
// Client fetches this, then hydrates each tile against the per-entity
|
||||
// endpoints (/api/albums/{id}, /api/artists/{id}, /api/tracks/{id})
|
||||
// for genuine progressive rendering. The section name implies the
|
||||
// entity type so no per-entry type tag is needed.
|
||||
type HomeIndexPayload struct {
|
||||
RecentlyAddedAlbums []string `json:"recently_added_albums"`
|
||||
RediscoverAlbums []string `json:"rediscover_albums"`
|
||||
RediscoverArtists []string `json:"rediscover_artists"`
|
||||
MostPlayedTracks []string `json:"most_played_tracks"`
|
||||
LastPlayedArtists []string `json:"last_played_artists"`
|
||||
}
|
||||
|
||||
// HistoryEvent is one play in a user's listening history. Used by
|
||||
// /api/me/history; one event per row from play_events.
|
||||
type HistoryEvent struct {
|
||||
|
||||
@@ -168,6 +168,41 @@ func (q *Queries) GetAlbumCoverageRollup(ctx context.Context) (GetAlbumCoverageR
|
||||
return i, err
|
||||
}
|
||||
|
||||
const getAlbumWithArtist = `-- name: GetAlbumWithArtist :one
|
||||
SELECT albums.id, albums.title, albums.sort_title, albums.artist_id, albums.release_date, albums.mbid, albums.cover_art_path, albums.created_at, albums.updated_at, albums.cover_art_source, albums.cover_art_sources_version, artists.name AS artist_name
|
||||
FROM albums
|
||||
JOIN artists ON artists.id = albums.artist_id
|
||||
WHERE albums.id = $1
|
||||
`
|
||||
|
||||
type GetAlbumWithArtistRow struct {
|
||||
Album Album
|
||||
ArtistName string
|
||||
}
|
||||
|
||||
// Combined fetch for /api/albums/{id}: returns the album row + the
|
||||
// joined artist name in a single round trip. Replaces a sequential
|
||||
// GetAlbumByID + GetArtistByID pair on the hot detail-page path.
|
||||
func (q *Queries) GetAlbumWithArtist(ctx context.Context, id pgtype.UUID) (GetAlbumWithArtistRow, error) {
|
||||
row := q.db.QueryRow(ctx, getAlbumWithArtist, id)
|
||||
var i GetAlbumWithArtistRow
|
||||
err := row.Scan(
|
||||
&i.Album.ID,
|
||||
&i.Album.Title,
|
||||
&i.Album.SortTitle,
|
||||
&i.Album.ArtistID,
|
||||
&i.Album.ReleaseDate,
|
||||
&i.Album.Mbid,
|
||||
&i.Album.CoverArtPath,
|
||||
&i.Album.CreatedAt,
|
||||
&i.Album.UpdatedAt,
|
||||
&i.Album.CoverArtSource,
|
||||
&i.Album.CoverArtSourcesVersion,
|
||||
&i.ArtistName,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
|
||||
const getAlbumsByIDs = `-- name: GetAlbumsByIDs :many
|
||||
SELECT id, title, sort_title, artist_id, release_date, mbid, cover_art_path, created_at, updated_at, cover_art_source, cover_art_sources_version FROM albums WHERE id = ANY($1::uuid[])
|
||||
`
|
||||
@@ -389,6 +424,56 @@ func (q *Queries) ListAlbumsByArtist(ctx context.Context, artistID pgtype.UUID)
|
||||
return items, nil
|
||||
}
|
||||
|
||||
const listAlbumsByArtistWithTrackCount = `-- name: ListAlbumsByArtistWithTrackCount :many
|
||||
SELECT albums.id, albums.title, albums.sort_title, albums.artist_id, albums.release_date, albums.mbid, albums.cover_art_path, albums.created_at, albums.updated_at, albums.cover_art_source, albums.cover_art_sources_version,
|
||||
(SELECT count(*) FROM tracks t WHERE t.album_id = albums.id)::bigint
|
||||
AS track_count
|
||||
FROM albums
|
||||
WHERE albums.artist_id = $1
|
||||
ORDER BY release_date NULLS LAST, sort_title
|
||||
`
|
||||
|
||||
type ListAlbumsByArtistWithTrackCountRow struct {
|
||||
Album Album
|
||||
TrackCount int64
|
||||
}
|
||||
|
||||
// Replaces the N+1 pattern in handleGetArtist (1 + N CountTracksByAlbum
|
||||
// per album). Returns each album joined with its track count via a
|
||||
// correlated subquery — single round trip regardless of album count.
|
||||
func (q *Queries) ListAlbumsByArtistWithTrackCount(ctx context.Context, artistID pgtype.UUID) ([]ListAlbumsByArtistWithTrackCountRow, error) {
|
||||
rows, err := q.db.Query(ctx, listAlbumsByArtistWithTrackCount, artistID)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
defer rows.Close()
|
||||
var items []ListAlbumsByArtistWithTrackCountRow
|
||||
for rows.Next() {
|
||||
var i ListAlbumsByArtistWithTrackCountRow
|
||||
if err := rows.Scan(
|
||||
&i.Album.ID,
|
||||
&i.Album.Title,
|
||||
&i.Album.SortTitle,
|
||||
&i.Album.ArtistID,
|
||||
&i.Album.ReleaseDate,
|
||||
&i.Album.Mbid,
|
||||
&i.Album.CoverArtPath,
|
||||
&i.Album.CreatedAt,
|
||||
&i.Album.UpdatedAt,
|
||||
&i.Album.CoverArtSource,
|
||||
&i.Album.CoverArtSourcesVersion,
|
||||
&i.TrackCount,
|
||||
); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
items = append(items, i)
|
||||
}
|
||||
if err := rows.Err(); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return items, nil
|
||||
}
|
||||
|
||||
const listAlbumsByGenre = `-- name: ListAlbumsByGenre :many
|
||||
SELECT DISTINCT ON (albums.id) albums.id, albums.title, albums.sort_title, albums.artist_id, albums.release_date, albums.mbid, albums.cover_art_path, albums.created_at, albums.updated_at, albums.cover_art_source, albums.cover_art_sources_version
|
||||
FROM albums
|
||||
|
||||
@@ -12,7 +12,7 @@ import (
|
||||
)
|
||||
|
||||
const listCrossUserLikedTracksForDiscover = `-- name: ListCrossUserLikedTracksForDiscover :many
|
||||
SELECT DISTINCT t.id, t.album_id, t.artist_id
|
||||
SELECT t.id, t.album_id, t.artist_id
|
||||
FROM general_likes gl
|
||||
JOIN tracks t ON t.id = gl.track_id
|
||||
WHERE gl.user_id != $1
|
||||
@@ -30,6 +30,7 @@ SELECT DISTINCT t.id, t.album_id, t.artist_id
|
||||
SELECT 1 FROM lidarr_quarantine q
|
||||
WHERE q.user_id = $1 AND q.track_id = t.id
|
||||
)
|
||||
GROUP BY t.id, t.album_id, t.artist_id
|
||||
ORDER BY md5(t.id::text || $2::text)
|
||||
LIMIT 60
|
||||
`
|
||||
@@ -50,6 +51,11 @@ type ListCrossUserLikedTracksForDiscoverRow struct {
|
||||
// rows (the caller's slot redistribution rolls the deficit into the
|
||||
// other two buckets).
|
||||
// $1 = user_id, $2 = date string for md5 ordering.
|
||||
//
|
||||
// GROUP BY (not SELECT DISTINCT) so the md5 ORDER BY expression need
|
||||
// not appear in the select list — Postgres rejects DISTINCT + ORDER BY
|
||||
// by-expression at plan time (SQLSTATE 42P10), which previously caused
|
||||
// the entire Discover build to fail silently.
|
||||
func (q *Queries) ListCrossUserLikedTracksForDiscover(ctx context.Context, arg ListCrossUserLikedTracksForDiscoverParams) ([]ListCrossUserLikedTracksForDiscoverRow, error) {
|
||||
rows, err := q.db.Query(ctx, listCrossUserLikedTracksForDiscover, arg.UserID, arg.Column2)
|
||||
if err != nil {
|
||||
|
||||
@@ -7,8 +7,25 @@ package dbq
|
||||
|
||||
import (
|
||||
"context"
|
||||
|
||||
"github.com/jackc/pgx/v5/pgtype"
|
||||
)
|
||||
|
||||
const deleteOldLibraryChanges = `-- name: DeleteOldLibraryChanges :execrows
|
||||
DELETE FROM library_changes WHERE changed_at < $1
|
||||
`
|
||||
|
||||
// Removes library_changes rows older than the given cutoff. Run from
|
||||
// the sync compactor goroutine on a daily tick. Returns the number of
|
||||
// rows deleted so the worker can log meaningful progress.
|
||||
func (q *Queries) DeleteOldLibraryChanges(ctx context.Context, changedAt pgtype.Timestamptz) (int64, error) {
|
||||
result, err := q.db.Exec(ctx, deleteOldLibraryChanges, changedAt)
|
||||
if err != nil {
|
||||
return 0, err
|
||||
}
|
||||
return result.RowsAffected(), nil
|
||||
}
|
||||
|
||||
const getLibraryChangesSince = `-- name: GetLibraryChangesSince :many
|
||||
SELECT id, entity_type, entity_id, op, changed_at
|
||||
FROM library_changes
|
||||
|
||||
@@ -522,6 +522,8 @@ type User struct {
|
||||
DisplayName *string
|
||||
AutoApproveRequests bool
|
||||
Email *string
|
||||
Timezone string
|
||||
TimezoneUpdatedAt pgtype.Timestamptz
|
||||
}
|
||||
|
||||
type UserInvite struct {
|
||||
|
||||
@@ -12,17 +12,19 @@ import (
|
||||
)
|
||||
|
||||
const listLastPlayedArtistsForUser = `-- name: ListLastPlayedArtistsForUser :many
|
||||
SELECT a.id, a.name, a.sort_name, a.mbid, a.created_at, a.updated_at, a.artist_thumb_path, a.artist_fanart_path, a.artist_art_source, a.artist_art_sources_version,
|
||||
cov.id AS cover_album_id,
|
||||
cnt.album_count::bigint AS album_count,
|
||||
max_started.started_at::timestamptz AS last_played_at
|
||||
FROM artists a
|
||||
JOIN LATERAL (
|
||||
SELECT max(pe.started_at) AS started_at
|
||||
WITH user_plays AS (
|
||||
SELECT t.artist_id, max(pe.started_at) AS last_started
|
||||
FROM play_events pe
|
||||
JOIN tracks t ON t.id = pe.track_id
|
||||
WHERE pe.user_id = $1 AND t.artist_id = a.id
|
||||
) max_started ON max_started.started_at IS NOT NULL
|
||||
WHERE pe.user_id = $1
|
||||
GROUP BY t.artist_id
|
||||
)
|
||||
SELECT a.id, a.name, a.sort_name, a.mbid, a.created_at, a.updated_at, a.artist_thumb_path, a.artist_fanart_path, a.artist_art_source, a.artist_art_sources_version,
|
||||
cov.id AS cover_album_id,
|
||||
cnt.album_count::bigint AS album_count,
|
||||
up.last_started::timestamptz AS last_played_at
|
||||
FROM user_plays up
|
||||
JOIN artists a ON a.id = up.artist_id
|
||||
LEFT JOIN LATERAL (
|
||||
SELECT id FROM albums
|
||||
WHERE artist_id = a.id AND cover_art_path IS NOT NULL
|
||||
@@ -32,7 +34,7 @@ LEFT JOIN LATERAL (
|
||||
SELECT count(*) AS album_count
|
||||
FROM albums WHERE artist_id = a.id
|
||||
) cnt ON true
|
||||
ORDER BY max_started.started_at DESC, a.id
|
||||
ORDER BY up.last_started DESC, a.id
|
||||
LIMIT $2
|
||||
`
|
||||
|
||||
@@ -52,6 +54,15 @@ type ListLastPlayedArtistsForUserRow struct {
|
||||
// a derived cover_album_id via a representative-album lateral join (most
|
||||
// recent album that has cover_art_path set). album_count joined for the
|
||||
// ArtistRef wire shape.
|
||||
//
|
||||
// Earlier shape iterated `FROM artists a` and ran a LATERAL play_events
|
||||
// subquery per artist — O(total_artists) plan even for users with a
|
||||
// handful of plays. New shape aggregates the user's plays by artist
|
||||
// via the play_events → tracks join up front (uses
|
||||
// play_events_user_track_idx + tracks pkey lookups), then attaches
|
||||
// the artist row and lateral cover/count subqueries only for the
|
||||
// artists that actually appear. Distinct-artists set is small for a
|
||||
// typical user, so cost is bounded by play history not library size.
|
||||
func (q *Queries) ListLastPlayedArtistsForUser(ctx context.Context, arg ListLastPlayedArtistsForUserParams) ([]ListLastPlayedArtistsForUserRow, error) {
|
||||
rows, err := q.db.Query(ctx, listLastPlayedArtistsForUser, arg.UserID, arg.Limit)
|
||||
if err != nil {
|
||||
@@ -87,24 +98,24 @@ func (q *Queries) ListLastPlayedArtistsForUser(ctx context.Context, arg ListLast
|
||||
}
|
||||
|
||||
const listMostPlayedTracksForUser = `-- name: ListMostPlayedTracksForUser :many
|
||||
WITH plays AS (
|
||||
SELECT track_id, count(*) AS cnt
|
||||
FROM play_events
|
||||
WHERE user_id = $1 AND was_skipped = false
|
||||
GROUP BY track_id
|
||||
)
|
||||
SELECT t.id, t.title, t.album_id, t.artist_id, t.track_number, t.disc_number, t.duration_ms, t.file_path, t.file_size, t.file_format, t.bitrate, t.mbid, t.genre, t.added_at, t.updated_at,
|
||||
albums.title AS album_title,
|
||||
artists.name AS artist_name
|
||||
FROM tracks t
|
||||
JOIN albums ON albums.id = t.album_id
|
||||
JOIN artists ON artists.id = t.artist_id
|
||||
JOIN play_events pe ON pe.track_id = t.id
|
||||
WHERE pe.user_id = $1
|
||||
AND pe.was_skipped = false
|
||||
AND NOT EXISTS (
|
||||
SELECT 1 FROM lidarr_quarantine q
|
||||
WHERE q.user_id = $1 AND q.track_id = t.id
|
||||
)
|
||||
GROUP BY t.id, t.title, t.album_id, t.artist_id, t.duration_ms, t.file_path,
|
||||
t.file_format, t.file_size, t.bitrate, t.track_number, t.disc_number,
|
||||
t.mbid, t.genre, t.added_at, t.updated_at,
|
||||
albums.title, artists.name
|
||||
ORDER BY count(*) DESC, t.id
|
||||
FROM plays p
|
||||
JOIN tracks t ON t.id = p.track_id
|
||||
JOIN albums ON albums.id = t.album_id
|
||||
JOIN artists ON artists.id = t.artist_id
|
||||
WHERE NOT EXISTS (
|
||||
SELECT 1 FROM lidarr_quarantine q
|
||||
WHERE q.user_id = $1 AND q.track_id = t.id
|
||||
)
|
||||
ORDER BY p.cnt DESC, t.id
|
||||
LIMIT $2
|
||||
`
|
||||
|
||||
@@ -122,6 +133,11 @@ type ListMostPlayedTracksForUserRow struct {
|
||||
// M6a: top-N tracks by completed-play count for the user. was_skipped
|
||||
// excludes skips so a user spamming next doesn't fabricate a top track.
|
||||
// Quarantined tracks (per-user soft-hide from M5b) are filtered out.
|
||||
//
|
||||
// Aggregate play_events first (uses play_events_user_track_idx) and
|
||||
// join through tracks/albums/artists only for the survivors. Earlier
|
||||
// shape did the join across every play_event row before grouping —
|
||||
// O(plays) instead of O(distinct tracks).
|
||||
func (q *Queries) ListMostPlayedTracksForUser(ctx context.Context, arg ListMostPlayedTracksForUserParams) ([]ListMostPlayedTracksForUserRow, error) {
|
||||
rows, err := q.db.Query(ctx, listMostPlayedTracksForUser, arg.UserID, arg.Limit)
|
||||
if err != nil {
|
||||
|
||||
@@ -308,7 +308,7 @@ SELECT p.artist_id,
|
||||
FROM plays p
|
||||
LEFT JOIN liked l ON l.artist_id = p.artist_id
|
||||
ORDER BY score DESC, p.artist_id
|
||||
LIMIT 3
|
||||
LIMIT 5
|
||||
`
|
||||
|
||||
type PickSeedArtistsRow struct {
|
||||
@@ -316,7 +316,10 @@ type PickSeedArtistsRow struct {
|
||||
Score int64
|
||||
}
|
||||
|
||||
// Top-3 most-engaged distinct artists in the user's last 7 days.
|
||||
// Top-5 most-engaged distinct artist candidates in the user's last 7
|
||||
// days. The Go-side picker (pickSeedArtistsForDay) shuffles these
|
||||
// daily-deterministically and takes the first 3 so the set of
|
||||
// "Songs like X" mixes rotates day-to-day.
|
||||
// Score = unskipped-play count + 5 if user has liked the artist.
|
||||
func (q *Queries) PickSeedArtists(ctx context.Context, userID pgtype.UUID) ([]PickSeedArtistsRow, error) {
|
||||
rows, err := q.db.Query(ctx, pickSeedArtists, userID)
|
||||
@@ -408,7 +411,7 @@ func (q *Queries) PickTopPlayedTrackForArtistByUser(ctx context.Context, arg Pic
|
||||
return id, err
|
||||
}
|
||||
|
||||
const pickTopPlayedTrackForUser = `-- name: PickTopPlayedTrackForUser :one
|
||||
const pickTopPlayedTracksForUser = `-- name: PickTopPlayedTracksForUser :many
|
||||
SELECT t.id
|
||||
FROM play_events pe
|
||||
JOIN tracks t ON t.id = pe.track_id
|
||||
@@ -417,16 +420,33 @@ SELECT t.id
|
||||
AND pe.was_skipped = false
|
||||
GROUP BY t.id
|
||||
ORDER BY COUNT(*) DESC, t.id
|
||||
LIMIT 1
|
||||
LIMIT 5
|
||||
`
|
||||
|
||||
// For-You seed selection. Returns the user's most-played non-skipped
|
||||
// track in the last 7 days; tie-break by track_id for determinism.
|
||||
func (q *Queries) PickTopPlayedTrackForUser(ctx context.Context, userID pgtype.UUID) (pgtype.UUID, error) {
|
||||
row := q.db.QueryRow(ctx, pickTopPlayedTrackForUser, userID)
|
||||
var id pgtype.UUID
|
||||
err := row.Scan(&id)
|
||||
return id, err
|
||||
// For-You candidate seeds. Returns the user's top-5 most-played
|
||||
// non-skipped tracks in the last 7 days; tie-break by track_id for
|
||||
// determinism. The Go-side picker (pickForYouSeedForDay) chooses one
|
||||
// of the returned rows as today's seed via userIDHash so the
|
||||
// candidate pool rotates day-to-day while staying stable within a
|
||||
// day.
|
||||
func (q *Queries) PickTopPlayedTracksForUser(ctx context.Context, userID pgtype.UUID) ([]pgtype.UUID, error) {
|
||||
rows, err := q.db.Query(ctx, pickTopPlayedTracksForUser, userID)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
defer rows.Close()
|
||||
var items []pgtype.UUID
|
||||
for rows.Next() {
|
||||
var id pgtype.UUID
|
||||
if err := rows.Scan(&id); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
items = append(items, id)
|
||||
}
|
||||
if err := rows.Err(); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return items, nil
|
||||
}
|
||||
|
||||
const tryClaimSystemPlaylistRun = `-- name: TryClaimSystemPlaylistRun :one
|
||||
|
||||
@@ -54,7 +54,7 @@ func (q *Queries) CountUsers(ctx context.Context) (int64, error) {
|
||||
const createUser = `-- name: CreateUser :one
|
||||
INSERT INTO users (username, password_hash, api_token, is_admin, display_name)
|
||||
VALUES ($1, $2, $3, $4, $5)
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at
|
||||
`
|
||||
|
||||
type CreateUserParams struct {
|
||||
@@ -87,6 +87,8 @@ func (q *Queries) CreateUser(ctx context.Context, arg CreateUserParams) (User, e
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
@@ -94,7 +96,7 @@ func (q *Queries) CreateUser(ctx context.Context, arg CreateUserParams) (User, e
|
||||
const createUserAdmin = `-- name: CreateUserAdmin :one
|
||||
INSERT INTO users (username, password_hash, api_token, is_admin, display_name)
|
||||
VALUES ($1, $2, $3, $4, $5)
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at
|
||||
`
|
||||
|
||||
type CreateUserAdminParams struct {
|
||||
@@ -130,6 +132,8 @@ func (q *Queries) CreateUserAdmin(ctx context.Context, arg CreateUserAdminParams
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
@@ -141,7 +145,7 @@ VALUES (
|
||||
(SELECT NOT EXISTS (SELECT 1 FROM users)),
|
||||
$4
|
||||
)
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at
|
||||
`
|
||||
|
||||
type CreateUserFirstAdminRaceParams struct {
|
||||
@@ -185,6 +189,8 @@ func (q *Queries) CreateUserFirstAdminRace(ctx context.Context, arg CreateUserFi
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
@@ -231,7 +237,7 @@ func (q *Queries) GetListenBrainzConfig(ctx context.Context, id pgtype.UUID) (Ge
|
||||
}
|
||||
|
||||
const getUserByAPIToken = `-- name: GetUserByAPIToken :one
|
||||
SELECT id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email FROM users WHERE api_token = $1
|
||||
SELECT id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at FROM users WHERE api_token = $1
|
||||
`
|
||||
|
||||
func (q *Queries) GetUserByAPIToken(ctx context.Context, apiToken string) (User, error) {
|
||||
@@ -250,12 +256,14 @@ func (q *Queries) GetUserByAPIToken(ctx context.Context, apiToken string) (User,
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
|
||||
const getUserByEmail = `-- name: GetUserByEmail :one
|
||||
SELECT id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email FROM users WHERE lower(email) = lower($1)
|
||||
SELECT id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at FROM users WHERE lower(email) = lower($1)
|
||||
`
|
||||
|
||||
// Used by forgot-password lookup. Lowercase comparison both sides
|
||||
@@ -277,12 +285,14 @@ func (q *Queries) GetUserByEmail(ctx context.Context, lower string) (User, error
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
|
||||
const getUserByID = `-- name: GetUserByID :one
|
||||
SELECT id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email FROM users WHERE id = $1
|
||||
SELECT id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at FROM users WHERE id = $1
|
||||
`
|
||||
|
||||
func (q *Queries) GetUserByID(ctx context.Context, id pgtype.UUID) (User, error) {
|
||||
@@ -301,12 +311,14 @@ func (q *Queries) GetUserByID(ctx context.Context, id pgtype.UUID) (User, error)
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
|
||||
const getUserByUsername = `-- name: GetUserByUsername :one
|
||||
SELECT id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email FROM users WHERE username = $1
|
||||
SELECT id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at FROM users WHERE username = $1
|
||||
`
|
||||
|
||||
func (q *Queries) GetUserByUsername(ctx context.Context, username string) (User, error) {
|
||||
@@ -325,10 +337,50 @@ func (q *Queries) GetUserByUsername(ctx context.Context, username string) (User,
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
|
||||
const listActiveUsersWithTimezones = `-- name: ListActiveUsersWithTimezones :many
|
||||
SELECT u.id, u.timezone FROM users u
|
||||
WHERE EXISTS (
|
||||
SELECT 1 FROM play_events pe
|
||||
WHERE pe.user_id = u.id
|
||||
AND pe.started_at > now() - INTERVAL '7 days'
|
||||
)
|
||||
`
|
||||
|
||||
type ListActiveUsersWithTimezonesRow struct {
|
||||
ID pgtype.UUID
|
||||
Timezone string
|
||||
}
|
||||
|
||||
// Returns (id, timezone) for every user with a play in the last 7
|
||||
// days. The system-playlist scheduler iterates this list at startup
|
||||
// and during its hourly reconciliation to discover newly-active /
|
||||
// no-longer-active users.
|
||||
func (q *Queries) ListActiveUsersWithTimezones(ctx context.Context) ([]ListActiveUsersWithTimezonesRow, error) {
|
||||
rows, err := q.db.Query(ctx, listActiveUsersWithTimezones)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
defer rows.Close()
|
||||
var items []ListActiveUsersWithTimezonesRow
|
||||
for rows.Next() {
|
||||
var i ListActiveUsersWithTimezonesRow
|
||||
if err := rows.Scan(&i.ID, &i.Timezone); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
items = append(items, i)
|
||||
}
|
||||
if err := rows.Err(); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return items, nil
|
||||
}
|
||||
|
||||
const listUsers = `-- name: ListUsers :many
|
||||
SELECT id, username, display_name, is_admin, auto_approve_requests, created_at
|
||||
FROM users
|
||||
@@ -374,7 +426,7 @@ func (q *Queries) ListUsers(ctx context.Context) ([]ListUsersRow, error) {
|
||||
|
||||
const regenerateApiToken = `-- name: RegenerateApiToken :one
|
||||
UPDATE users SET api_token = $2 WHERE id = $1
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at
|
||||
`
|
||||
|
||||
type RegenerateApiTokenParams struct {
|
||||
@@ -400,6 +452,8 @@ func (q *Queries) RegenerateApiToken(ctx context.Context, arg RegenerateApiToken
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
@@ -477,7 +531,7 @@ const updateUserAdmin = `-- name: UpdateUserAdmin :one
|
||||
UPDATE users
|
||||
SET is_admin = $2
|
||||
WHERE id = $1
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at
|
||||
`
|
||||
|
||||
type UpdateUserAdminParams struct {
|
||||
@@ -503,6 +557,8 @@ func (q *Queries) UpdateUserAdmin(ctx context.Context, arg UpdateUserAdminParams
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
@@ -511,7 +567,7 @@ const updateUserAutoApprove = `-- name: UpdateUserAutoApprove :one
|
||||
UPDATE users
|
||||
SET auto_approve_requests = $2
|
||||
WHERE id = $1
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at
|
||||
`
|
||||
|
||||
type UpdateUserAutoApproveParams struct {
|
||||
@@ -536,6 +592,8 @@ func (q *Queries) UpdateUserAutoApprove(ctx context.Context, arg UpdateUserAutoA
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
@@ -545,7 +603,7 @@ UPDATE users
|
||||
SET display_name = $2,
|
||||
email = $3
|
||||
WHERE id = $1
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email
|
||||
RETURNING id, username, password_hash, api_token, is_admin, created_at, subsonic_password, listenbrainz_token, listenbrainz_enabled, display_name, auto_approve_requests, email, timezone, timezone_updated_at
|
||||
`
|
||||
|
||||
type UpdateUserProfileParams struct {
|
||||
@@ -572,6 +630,28 @@ func (q *Queries) UpdateUserProfile(ctx context.Context, arg UpdateUserProfilePa
|
||||
&i.DisplayName,
|
||||
&i.AutoApproveRequests,
|
||||
&i.Email,
|
||||
&i.Timezone,
|
||||
&i.TimezoneUpdatedAt,
|
||||
)
|
||||
return i, err
|
||||
}
|
||||
|
||||
const updateUserTimezone = `-- name: UpdateUserTimezone :exec
|
||||
UPDATE users
|
||||
SET timezone = $2,
|
||||
timezone_updated_at = now()
|
||||
WHERE id = $1
|
||||
`
|
||||
|
||||
type UpdateUserTimezoneParams struct {
|
||||
ID pgtype.UUID
|
||||
Timezone string
|
||||
}
|
||||
|
||||
// Sets the user's IANA timezone and bumps timezone_updated_at. The
|
||||
// handler validates the timezone string via time.LoadLocation before
|
||||
// calling this; the DB does not re-validate.
|
||||
func (q *Queries) UpdateUserTimezone(ctx context.Context, arg UpdateUserTimezoneParams) error {
|
||||
_, err := q.db.Exec(ctx, updateUserTimezone, arg.ID, arg.Timezone)
|
||||
return err
|
||||
}
|
||||
|
||||
@@ -0,0 +1,3 @@
|
||||
ALTER TABLE users
|
||||
DROP COLUMN timezone,
|
||||
DROP COLUMN timezone_updated_at;
|
||||
@@ -0,0 +1,8 @@
|
||||
-- 0026_users_timezone.up.sql — per-user timezone for the system-playlist
|
||||
-- scheduler (#392 Half B). Default 'UTC' so existing rows + brand-new
|
||||
-- users have a safe value before their first client check-in via
|
||||
-- PUT /api/me/timezone. The scheduler reads this column to decide
|
||||
-- which IANA zone to anchor each user's daily 03:00 build to.
|
||||
ALTER TABLE users
|
||||
ADD COLUMN timezone text NOT NULL DEFAULT 'UTC',
|
||||
ADD COLUMN timezone_updated_at timestamptz;
|
||||
@@ -14,6 +14,26 @@ RETURNING *;
|
||||
-- name: GetAlbumByID :one
|
||||
SELECT * FROM albums WHERE id = $1;
|
||||
|
||||
-- name: GetAlbumWithArtist :one
|
||||
-- Combined fetch for /api/albums/{id}: returns the album row + the
|
||||
-- joined artist name in a single round trip. Replaces a sequential
|
||||
-- GetAlbumByID + GetArtistByID pair on the hot detail-page path.
|
||||
SELECT sqlc.embed(albums), artists.name AS artist_name
|
||||
FROM albums
|
||||
JOIN artists ON artists.id = albums.artist_id
|
||||
WHERE albums.id = $1;
|
||||
|
||||
-- name: ListAlbumsByArtistWithTrackCount :many
|
||||
-- Replaces the N+1 pattern in handleGetArtist (1 + N CountTracksByAlbum
|
||||
-- per album). Returns each album joined with its track count via a
|
||||
-- correlated subquery — single round trip regardless of album count.
|
||||
SELECT sqlc.embed(albums),
|
||||
(SELECT count(*) FROM tracks t WHERE t.album_id = albums.id)::bigint
|
||||
AS track_count
|
||||
FROM albums
|
||||
WHERE albums.artist_id = $1
|
||||
ORDER BY release_date NULLS LAST, sort_title;
|
||||
|
||||
-- name: GetAlbumByArtistAndTitle :one
|
||||
-- Scanner uses this for the no-mbid dedupe path: resolve-or-create.
|
||||
SELECT * FROM albums WHERE artist_id = $1 AND title = $2 LIMIT 1;
|
||||
|
||||
@@ -52,7 +52,12 @@ SELECT t.id, t.album_id, t.artist_id
|
||||
-- rows (the caller's slot redistribution rolls the deficit into the
|
||||
-- other two buckets).
|
||||
-- $1 = user_id, $2 = date string for md5 ordering.
|
||||
SELECT DISTINCT t.id, t.album_id, t.artist_id
|
||||
--
|
||||
-- GROUP BY (not SELECT DISTINCT) so the md5 ORDER BY expression need
|
||||
-- not appear in the select list — Postgres rejects DISTINCT + ORDER BY
|
||||
-- by-expression at plan time (SQLSTATE 42P10), which previously caused
|
||||
-- the entire Discover build to fail silently.
|
||||
SELECT t.id, t.album_id, t.artist_id
|
||||
FROM general_likes gl
|
||||
JOIN tracks t ON t.id = gl.track_id
|
||||
WHERE gl.user_id != $1
|
||||
@@ -70,6 +75,7 @@ SELECT DISTINCT t.id, t.album_id, t.artist_id
|
||||
SELECT 1 FROM lidarr_quarantine q
|
||||
WHERE q.user_id = $1 AND q.track_id = t.id
|
||||
)
|
||||
GROUP BY t.id, t.album_id, t.artist_id
|
||||
ORDER BY md5(t.id::text || $2::text)
|
||||
LIMIT 60;
|
||||
|
||||
|
||||
@@ -14,3 +14,9 @@ SELECT COALESCE(MAX(id), 0)::BIGINT FROM library_changes;
|
||||
|
||||
-- name: GetMinLibraryChangeCursor :one
|
||||
SELECT COALESCE(MIN(id), 0)::BIGINT FROM library_changes;
|
||||
|
||||
-- name: DeleteOldLibraryChanges :execrows
|
||||
-- Removes library_changes rows older than the given cutoff. Run from
|
||||
-- the sync compactor goroutine on a daily tick. Returns the number of
|
||||
-- rows deleted so the worker can log meaningful progress.
|
||||
DELETE FROM library_changes WHERE changed_at < $1;
|
||||
|
||||
@@ -206,24 +206,29 @@ LIMIT $3;
|
||||
-- M6a: top-N tracks by completed-play count for the user. was_skipped
|
||||
-- excludes skips so a user spamming next doesn't fabricate a top track.
|
||||
-- Quarantined tracks (per-user soft-hide from M5b) are filtered out.
|
||||
--
|
||||
-- Aggregate play_events first (uses play_events_user_track_idx) and
|
||||
-- join through tracks/albums/artists only for the survivors. Earlier
|
||||
-- shape did the join across every play_event row before grouping —
|
||||
-- O(plays) instead of O(distinct tracks).
|
||||
WITH plays AS (
|
||||
SELECT track_id, count(*) AS cnt
|
||||
FROM play_events
|
||||
WHERE user_id = $1 AND was_skipped = false
|
||||
GROUP BY track_id
|
||||
)
|
||||
SELECT sqlc.embed(t),
|
||||
albums.title AS album_title,
|
||||
artists.name AS artist_name
|
||||
FROM tracks t
|
||||
JOIN albums ON albums.id = t.album_id
|
||||
JOIN artists ON artists.id = t.artist_id
|
||||
JOIN play_events pe ON pe.track_id = t.id
|
||||
WHERE pe.user_id = $1
|
||||
AND pe.was_skipped = false
|
||||
AND NOT EXISTS (
|
||||
SELECT 1 FROM lidarr_quarantine q
|
||||
WHERE q.user_id = $1 AND q.track_id = t.id
|
||||
)
|
||||
GROUP BY t.id, t.title, t.album_id, t.artist_id, t.duration_ms, t.file_path,
|
||||
t.file_format, t.file_size, t.bitrate, t.track_number, t.disc_number,
|
||||
t.mbid, t.genre, t.added_at, t.updated_at,
|
||||
albums.title, artists.name
|
||||
ORDER BY count(*) DESC, t.id
|
||||
FROM plays p
|
||||
JOIN tracks t ON t.id = p.track_id
|
||||
JOIN albums ON albums.id = t.album_id
|
||||
JOIN artists ON artists.id = t.artist_id
|
||||
WHERE NOT EXISTS (
|
||||
SELECT 1 FROM lidarr_quarantine q
|
||||
WHERE q.user_id = $1 AND q.track_id = t.id
|
||||
)
|
||||
ORDER BY p.cnt DESC, t.id
|
||||
LIMIT $2;
|
||||
|
||||
-- name: ListLastPlayedArtistsForUser :many
|
||||
@@ -231,17 +236,28 @@ LIMIT $2;
|
||||
-- a derived cover_album_id via a representative-album lateral join (most
|
||||
-- recent album that has cover_art_path set). album_count joined for the
|
||||
-- ArtistRef wire shape.
|
||||
SELECT sqlc.embed(a),
|
||||
cov.id AS cover_album_id,
|
||||
cnt.album_count::bigint AS album_count,
|
||||
max_started.started_at::timestamptz AS last_played_at
|
||||
FROM artists a
|
||||
JOIN LATERAL (
|
||||
SELECT max(pe.started_at) AS started_at
|
||||
--
|
||||
-- Earlier shape iterated `FROM artists a` and ran a LATERAL play_events
|
||||
-- subquery per artist — O(total_artists) plan even for users with a
|
||||
-- handful of plays. New shape aggregates the user's plays by artist
|
||||
-- via the play_events → tracks join up front (uses
|
||||
-- play_events_user_track_idx + tracks pkey lookups), then attaches
|
||||
-- the artist row and lateral cover/count subqueries only for the
|
||||
-- artists that actually appear. Distinct-artists set is small for a
|
||||
-- typical user, so cost is bounded by play history not library size.
|
||||
WITH user_plays AS (
|
||||
SELECT t.artist_id, max(pe.started_at) AS last_started
|
||||
FROM play_events pe
|
||||
JOIN tracks t ON t.id = pe.track_id
|
||||
WHERE pe.user_id = $1 AND t.artist_id = a.id
|
||||
) max_started ON max_started.started_at IS NOT NULL
|
||||
WHERE pe.user_id = $1
|
||||
GROUP BY t.artist_id
|
||||
)
|
||||
SELECT sqlc.embed(a),
|
||||
cov.id AS cover_album_id,
|
||||
cnt.album_count::bigint AS album_count,
|
||||
up.last_started::timestamptz AS last_played_at
|
||||
FROM user_plays up
|
||||
JOIN artists a ON a.id = up.artist_id
|
||||
LEFT JOIN LATERAL (
|
||||
SELECT id FROM albums
|
||||
WHERE artist_id = a.id AND cover_art_path IS NOT NULL
|
||||
@@ -251,7 +267,7 @@ LEFT JOIN LATERAL (
|
||||
SELECT count(*) AS album_count
|
||||
FROM albums WHERE artist_id = a.id
|
||||
) cnt ON true
|
||||
ORDER BY max_started.started_at DESC, a.id
|
||||
ORDER BY up.last_started DESC, a.id
|
||||
LIMIT $2;
|
||||
|
||||
-- name: ListRediscoverAlbumsForUser :many
|
||||
|
||||
@@ -47,7 +47,10 @@ UPDATE system_playlist_runs
|
||||
UPDATE system_playlist_runs SET in_flight = false WHERE in_flight = true;
|
||||
|
||||
-- name: PickSeedArtists :many
|
||||
-- Top-3 most-engaged distinct artists in the user's last 7 days.
|
||||
-- Top-5 most-engaged distinct artist candidates in the user's last 7
|
||||
-- days. The Go-side picker (pickSeedArtistsForDay) shuffles these
|
||||
-- daily-deterministically and takes the first 3 so the set of
|
||||
-- "Songs like X" mixes rotates day-to-day.
|
||||
-- Score = unskipped-play count + 5 if user has liked the artist.
|
||||
WITH plays AS (
|
||||
SELECT t.artist_id,
|
||||
@@ -67,11 +70,15 @@ SELECT p.artist_id,
|
||||
FROM plays p
|
||||
LEFT JOIN liked l ON l.artist_id = p.artist_id
|
||||
ORDER BY score DESC, p.artist_id
|
||||
LIMIT 3;
|
||||
LIMIT 5;
|
||||
|
||||
-- name: PickTopPlayedTrackForUser :one
|
||||
-- For-You seed selection. Returns the user's most-played non-skipped
|
||||
-- track in the last 7 days; tie-break by track_id for determinism.
|
||||
-- name: PickTopPlayedTracksForUser :many
|
||||
-- For-You candidate seeds. Returns the user's top-5 most-played
|
||||
-- non-skipped tracks in the last 7 days; tie-break by track_id for
|
||||
-- determinism. The Go-side picker (pickForYouSeedForDay) chooses one
|
||||
-- of the returned rows as today's seed via userIDHash so the
|
||||
-- candidate pool rotates day-to-day while staying stable within a
|
||||
-- day.
|
||||
SELECT t.id
|
||||
FROM play_events pe
|
||||
JOIN tracks t ON t.id = pe.track_id
|
||||
@@ -80,7 +87,7 @@ SELECT t.id
|
||||
AND pe.was_skipped = false
|
||||
GROUP BY t.id
|
||||
ORDER BY COUNT(*) DESC, t.id
|
||||
LIMIT 1;
|
||||
LIMIT 5;
|
||||
|
||||
-- name: PickTopPlayedTrackForArtistByUser :one
|
||||
-- "Songs like X" seed selection. Returns the user's most-played non-skipped
|
||||
|
||||
@@ -142,3 +142,24 @@ RETURNING *;
|
||||
-- to keep the unique index happy and to make the lookup
|
||||
-- case-insensitive.
|
||||
SELECT * FROM users WHERE lower(email) = lower($1);
|
||||
|
||||
-- name: UpdateUserTimezone :exec
|
||||
-- Sets the user's IANA timezone and bumps timezone_updated_at. The
|
||||
-- handler validates the timezone string via time.LoadLocation before
|
||||
-- calling this; the DB does not re-validate.
|
||||
UPDATE users
|
||||
SET timezone = $2,
|
||||
timezone_updated_at = now()
|
||||
WHERE id = $1;
|
||||
|
||||
-- name: ListActiveUsersWithTimezones :many
|
||||
-- Returns (id, timezone) for every user with a play in the last 7
|
||||
-- days. The system-playlist scheduler iterates this list at startup
|
||||
-- and during its hourly reconciliation to discover newly-active /
|
||||
-- no-longer-active users.
|
||||
SELECT u.id, u.timezone FROM users u
|
||||
WHERE EXISTS (
|
||||
SELECT 1 FROM play_events pe
|
||||
WHERE pe.user_id = u.id
|
||||
AND pe.started_at > now() - INTERVAL '7 days'
|
||||
);
|
||||
|
||||
@@ -0,0 +1,96 @@
|
||||
// Package eventbus is an in-process publish/subscribe bus for real-time
|
||||
// events the server emits to subscribed clients (today: Flutter via SSE).
|
||||
//
|
||||
// Writers (likes handler, requests reconciler, scanner, etc.) call Publish
|
||||
// to announce a state change. Each connected SSE client holds a
|
||||
// subscription via Subscribe and forwards events to its HTTP response.
|
||||
//
|
||||
// The bus is intentionally simple:
|
||||
//
|
||||
// - Per-subscriber bounded channel buffer. If a subscriber's buffer is
|
||||
// full when an event arrives, the event is dropped FOR THAT SUBSCRIBER
|
||||
// ONLY — writers never block, and other subscribers are unaffected.
|
||||
// - No persistence. A client that connects after an event was emitted
|
||||
// will not see that event. SSE clients are expected to fetch a fresh
|
||||
// snapshot via the normal /api/* endpoints on (re)connect.
|
||||
// - No cross-process broadcast. v1 runs as a single Go binary; a future
|
||||
// multi-instance deployment will need a real broker (NATS / Redis
|
||||
// pub-sub / etc.) but that's out of scope here.
|
||||
package eventbus
|
||||
|
||||
import (
|
||||
"sync"
|
||||
)
|
||||
|
||||
// Event is a single broadcast message. Kind names follow a "domain.action"
|
||||
// convention (e.g. "track.liked", "request.status_changed"). UserID, when
|
||||
// non-empty, scopes the event to a specific user — subscribers receive
|
||||
// only events with UserID == their auth user OR with empty UserID (which
|
||||
// means "broadcast to everyone subscribed").
|
||||
type Event struct {
|
||||
Kind string `json:"kind"`
|
||||
UserID string `json:"user_id,omitempty"`
|
||||
Data map[string]any `json:"data"`
|
||||
}
|
||||
|
||||
// Bus is a fan-out broadcaster. Safe for concurrent use; the zero value is
|
||||
// not usable — call New().
|
||||
type Bus struct {
|
||||
mu sync.RWMutex
|
||||
subscribers map[chan Event]struct{}
|
||||
}
|
||||
|
||||
// New returns a Bus with no subscribers.
|
||||
func New() *Bus {
|
||||
return &Bus{subscribers: map[chan Event]struct{}{}}
|
||||
}
|
||||
|
||||
// Publish fans an event out to every subscriber. Non-blocking per
|
||||
// subscriber: if a subscriber's buffer is full, the event is dropped for
|
||||
// that subscriber rather than stalling the writer.
|
||||
func (b *Bus) Publish(e Event) {
|
||||
b.mu.RLock()
|
||||
defer b.mu.RUnlock()
|
||||
for ch := range b.subscribers {
|
||||
select {
|
||||
case ch <- e:
|
||||
default:
|
||||
// Subscriber buffer full — drop. The subscriber will resync
|
||||
// via a normal API fetch when the client decides to.
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Subscribe registers a new subscriber and returns its receive channel
|
||||
// plus an unsubscribe func. The buffer argument controls how many events
|
||||
// can be queued before drops occur; 16–64 is a reasonable range for an
|
||||
// SSE client that processes events promptly.
|
||||
//
|
||||
// Callers MUST invoke the returned unsubscribe func when done (typically
|
||||
// in a defer), or the subscription leaks.
|
||||
func (b *Bus) Subscribe(buffer int) (<-chan Event, func()) {
|
||||
if buffer <= 0 {
|
||||
buffer = 16
|
||||
}
|
||||
ch := make(chan Event, buffer)
|
||||
b.mu.Lock()
|
||||
b.subscribers[ch] = struct{}{}
|
||||
b.mu.Unlock()
|
||||
unsub := func() {
|
||||
b.mu.Lock()
|
||||
if _, ok := b.subscribers[ch]; ok {
|
||||
delete(b.subscribers, ch)
|
||||
close(ch)
|
||||
}
|
||||
b.mu.Unlock()
|
||||
}
|
||||
return ch, unsub
|
||||
}
|
||||
|
||||
// SubscriberCount returns the current number of active subscribers. For
|
||||
// tests + observability; not load-bearing in hot paths.
|
||||
func (b *Bus) SubscriberCount() int {
|
||||
b.mu.RLock()
|
||||
defer b.mu.RUnlock()
|
||||
return len(b.subscribers)
|
||||
}
|
||||
@@ -0,0 +1,150 @@
|
||||
package eventbus
|
||||
|
||||
import (
|
||||
"sync"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
func TestPublish_DeliversToSubscriber(t *testing.T) {
|
||||
t.Parallel()
|
||||
b := New()
|
||||
ch, unsub := b.Subscribe(4)
|
||||
defer unsub()
|
||||
|
||||
b.Publish(Event{Kind: "test.event", UserID: "u1", Data: map[string]any{"x": 1}})
|
||||
|
||||
select {
|
||||
case got := <-ch:
|
||||
if got.Kind != "test.event" || got.UserID != "u1" {
|
||||
t.Fatalf("unexpected event: %+v", got)
|
||||
}
|
||||
if got.Data["x"] != 1 {
|
||||
t.Fatalf("payload mismatch: %+v", got.Data)
|
||||
}
|
||||
case <-time.After(time.Second):
|
||||
t.Fatal("timed out waiting for event")
|
||||
}
|
||||
}
|
||||
|
||||
func TestPublish_FanOutToMultipleSubscribers(t *testing.T) {
|
||||
t.Parallel()
|
||||
b := New()
|
||||
ch1, unsub1 := b.Subscribe(4)
|
||||
ch2, unsub2 := b.Subscribe(4)
|
||||
defer unsub1()
|
||||
defer unsub2()
|
||||
|
||||
b.Publish(Event{Kind: "broadcast"})
|
||||
|
||||
for i, ch := range []<-chan Event{ch1, ch2} {
|
||||
select {
|
||||
case got := <-ch:
|
||||
if got.Kind != "broadcast" {
|
||||
t.Fatalf("ch%d: kind=%q", i, got.Kind)
|
||||
}
|
||||
case <-time.After(time.Second):
|
||||
t.Fatalf("ch%d: timed out", i)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestPublish_DropsWhenSubscriberBufferFull(t *testing.T) {
|
||||
t.Parallel()
|
||||
b := New()
|
||||
_, unsub := b.Subscribe(2) // tiny buffer
|
||||
defer unsub()
|
||||
|
||||
// Without draining the channel, push more events than the buffer holds.
|
||||
// Drops are silent; the assertion is that Publish does not block.
|
||||
done := make(chan struct{})
|
||||
go func() {
|
||||
for i := 0; i < 100; i++ {
|
||||
b.Publish(Event{Kind: "flood"})
|
||||
}
|
||||
close(done)
|
||||
}()
|
||||
|
||||
select {
|
||||
case <-done:
|
||||
// Good — Publish returned without blocking on the laggard.
|
||||
case <-time.After(2 * time.Second):
|
||||
t.Fatal("Publish blocked on a slow subscriber")
|
||||
}
|
||||
}
|
||||
|
||||
func TestUnsubscribe_RemovesFromBusAndClosesChannel(t *testing.T) {
|
||||
t.Parallel()
|
||||
b := New()
|
||||
ch, unsub := b.Subscribe(4)
|
||||
|
||||
if got := b.SubscriberCount(); got != 1 {
|
||||
t.Fatalf("after Subscribe: SubscriberCount=%d, want 1", got)
|
||||
}
|
||||
|
||||
unsub()
|
||||
|
||||
if got := b.SubscriberCount(); got != 0 {
|
||||
t.Fatalf("after unsub: SubscriberCount=%d, want 0", got)
|
||||
}
|
||||
|
||||
// Channel is closed: receive returns zero value with ok=false.
|
||||
if _, ok := <-ch; ok {
|
||||
t.Fatal("expected channel to be closed after unsubscribe")
|
||||
}
|
||||
}
|
||||
|
||||
func TestUnsubscribe_Idempotent(t *testing.T) {
|
||||
t.Parallel()
|
||||
b := New()
|
||||
_, unsub := b.Subscribe(4)
|
||||
unsub()
|
||||
unsub() // must not panic / double-close
|
||||
if got := b.SubscriberCount(); got != 0 {
|
||||
t.Fatalf("SubscriberCount=%d, want 0", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestPublish_ConcurrentWritersAndSubscribers(t *testing.T) {
|
||||
t.Parallel()
|
||||
b := New()
|
||||
|
||||
const (
|
||||
subs = 8
|
||||
perWriter = 50
|
||||
writers = 4
|
||||
bufferSize = 100
|
||||
)
|
||||
|
||||
var subWG sync.WaitGroup
|
||||
subWG.Add(subs)
|
||||
stops := make([]func(), 0, subs)
|
||||
for i := 0; i < subs; i++ {
|
||||
ch, unsub := b.Subscribe(bufferSize)
|
||||
stops = append(stops, unsub)
|
||||
go func() {
|
||||
defer subWG.Done()
|
||||
for range ch {
|
||||
// Drain until channel closes.
|
||||
}
|
||||
}()
|
||||
}
|
||||
|
||||
var pubWG sync.WaitGroup
|
||||
pubWG.Add(writers)
|
||||
for w := 0; w < writers; w++ {
|
||||
go func() {
|
||||
defer pubWG.Done()
|
||||
for i := 0; i < perWriter; i++ {
|
||||
b.Publish(Event{Kind: "concurrent"})
|
||||
}
|
||||
}()
|
||||
}
|
||||
pubWG.Wait()
|
||||
|
||||
// Tear down subscribers — channels close, goroutines exit.
|
||||
for _, stop := range stops {
|
||||
stop()
|
||||
}
|
||||
subWG.Wait()
|
||||
}
|
||||
@@ -0,0 +1,81 @@
|
||||
package library
|
||||
|
||||
import (
|
||||
"sync"
|
||||
|
||||
"github.com/jackc/pgx/v5/pgtype"
|
||||
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/eventbus"
|
||||
)
|
||||
|
||||
// Package-level bus pointer for scan lifecycle events (#392). Set once
|
||||
// at startup via SetEventBus; reads are nil-safe so test contexts that
|
||||
// never call SetEventBus simply skip publishing.
|
||||
//
|
||||
// A package-global is the right shape here because:
|
||||
//
|
||||
// - There is exactly one bus per process (the same instance powers
|
||||
// the SSE subscriber endpoint and every publisher across the codebase).
|
||||
// - Threading it through RunScan + TryStartScan + the Scheduler +
|
||||
// every test caller would touch ~10 call sites without changing
|
||||
// behavior at the boundaries that don't care.
|
||||
// - Other Go stdlib packages use the same pattern (log.SetDefault,
|
||||
// etc.) for process-wide singletons.
|
||||
var (
|
||||
busMu sync.RWMutex
|
||||
bus *eventbus.Bus
|
||||
)
|
||||
|
||||
// SetEventBus wires the live-event bus into the library package so scan
|
||||
// runs emit scan.run_started / scan.run_finished events. Call once during
|
||||
// process startup; subsequent calls overwrite the previous bus.
|
||||
func SetEventBus(b *eventbus.Bus) {
|
||||
busMu.Lock()
|
||||
defer busMu.Unlock()
|
||||
bus = b
|
||||
}
|
||||
|
||||
// publishScanEvent broadcasts a scan lifecycle event. No-op when no bus
|
||||
// has been set. Scan events are always broadcast (empty UserID) because
|
||||
// only admins see the scan status card; non-admin clients' invalidation
|
||||
// dispatcher will receive the event but won't have any provider keyed on
|
||||
// scan status, so the receive is harmless.
|
||||
func publishScanEvent(kind string, runID pgtype.UUID, data map[string]any) {
|
||||
busMu.RLock()
|
||||
b := bus
|
||||
busMu.RUnlock()
|
||||
if b == nil {
|
||||
return
|
||||
}
|
||||
payload := map[string]any{"run_id": uuidToBusString(runID)}
|
||||
for k, v := range data {
|
||||
payload[k] = v
|
||||
}
|
||||
b.Publish(eventbus.Event{
|
||||
Kind: kind,
|
||||
UserID: "", // broadcast
|
||||
Data: payload,
|
||||
})
|
||||
}
|
||||
|
||||
// uuidToBusString renders a pgtype.UUID in canonical 8-4-4-4-12 form.
|
||||
// Inlined to avoid a back-edge dependency on internal/api or another
|
||||
// helper-bearing package.
|
||||
func uuidToBusString(u pgtype.UUID) string {
|
||||
if !u.Valid {
|
||||
return ""
|
||||
}
|
||||
const hex = "0123456789abcdef"
|
||||
out := make([]byte, 36)
|
||||
pos := 0
|
||||
for i, b := range u.Bytes {
|
||||
if i == 4 || i == 6 || i == 8 || i == 10 {
|
||||
out[pos] = '-'
|
||||
pos++
|
||||
}
|
||||
out[pos] = hex[b>>4]
|
||||
out[pos+1] = hex[b&0xf]
|
||||
pos += 2
|
||||
}
|
||||
return string(out)
|
||||
}
|
||||
@@ -83,6 +83,7 @@ func RunScan(
|
||||
return pgtype.UUID{}, fmt.Errorf("insert scan_run: %w", err)
|
||||
}
|
||||
logger.Info("scan run started", "id", row.ID)
|
||||
publishScanEvent("scan.run_started", row.ID, nil)
|
||||
|
||||
var firstErr error
|
||||
captureErr := func(stage string, stageErr error) {
|
||||
@@ -228,5 +229,8 @@ func RunScan(
|
||||
}
|
||||
|
||||
logger.Info("scan run complete", "id", row.ID, "error", errMsg)
|
||||
publishScanEvent("scan.run_finished", row.ID, map[string]any{
|
||||
"error_message": errMsg,
|
||||
})
|
||||
return row.ID, firstErr
|
||||
}
|
||||
|
||||
@@ -10,6 +10,7 @@ import (
|
||||
"github.com/jackc/pgx/v5/pgxpool"
|
||||
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/eventbus"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/lidarrconfig"
|
||||
)
|
||||
|
||||
@@ -21,22 +22,65 @@ type Reconciler struct {
|
||||
pool *pgxpool.Pool
|
||||
lidarrCfg *lidarrconfig.Service
|
||||
logger *slog.Logger
|
||||
bus *eventbus.Bus
|
||||
tick time.Duration
|
||||
batch int32
|
||||
}
|
||||
|
||||
// NewReconciler constructs a Reconciler with production defaults:
|
||||
// 5-minute tick, batch size 50.
|
||||
func NewReconciler(pool *pgxpool.Pool, cfg *lidarrconfig.Service, logger *slog.Logger) *Reconciler {
|
||||
// 5-minute tick, batch size 50. Pass nil for bus when no SSE publishing
|
||||
// is desired (tests, or environments without the event stream enabled).
|
||||
func NewReconciler(pool *pgxpool.Pool, cfg *lidarrconfig.Service, logger *slog.Logger, bus *eventbus.Bus) *Reconciler {
|
||||
return &Reconciler{
|
||||
pool: pool,
|
||||
lidarrCfg: cfg,
|
||||
logger: logger,
|
||||
bus: bus,
|
||||
tick: 5 * time.Minute,
|
||||
batch: 50,
|
||||
}
|
||||
}
|
||||
|
||||
// publishCompleted broadcasts a request.status_changed event scoped to
|
||||
// the original requester. No-op when bus is nil.
|
||||
func (r *Reconciler) publishCompleted(row dbq.LidarrRequest) {
|
||||
if r.bus == nil {
|
||||
return
|
||||
}
|
||||
r.bus.Publish(eventbus.Event{
|
||||
Kind: "request.status_changed",
|
||||
UserID: formatUUIDForBus(row.UserID),
|
||||
Data: map[string]any{
|
||||
"request_id": formatUUIDForBus(row.ID),
|
||||
"status": "completed",
|
||||
"kind": string(row.Kind),
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
// formatUUIDForBus renders a pgtype.UUID as the canonical 8-4-4-4-12 hex
|
||||
// string. Mirrors helpers in internal/api/convert.go and other packages;
|
||||
// inlined here to avoid a back-edge dependency from lidarrrequests onto
|
||||
// the api layer.
|
||||
func formatUUIDForBus(u pgtype.UUID) string {
|
||||
if !u.Valid {
|
||||
return ""
|
||||
}
|
||||
const hex = "0123456789abcdef"
|
||||
out := make([]byte, 36)
|
||||
pos := 0
|
||||
for i, b := range u.Bytes {
|
||||
if i == 4 || i == 6 || i == 8 || i == 10 {
|
||||
out[pos] = '-'
|
||||
pos++
|
||||
}
|
||||
out[pos] = hex[b>>4]
|
||||
out[pos+1] = hex[b&0xf]
|
||||
pos += 2
|
||||
}
|
||||
return string(out)
|
||||
}
|
||||
|
||||
// Run blocks until ctx is cancelled, ticking every r.tick. Errors from
|
||||
// tickOnce are logged at WARN and never propagated.
|
||||
func (r *Reconciler) Run(ctx context.Context) {
|
||||
@@ -114,13 +158,17 @@ func (r *Reconciler) reconcileArtist(ctx context.Context, q *dbq.Queries, row db
|
||||
}
|
||||
return err
|
||||
}
|
||||
_, err = q.CompleteLidarrRequest(ctx, dbq.CompleteLidarrRequestParams{
|
||||
completed, err := q.CompleteLidarrRequest(ctx, dbq.CompleteLidarrRequestParams{
|
||||
ID: row.ID,
|
||||
MatchedArtistID: artistID,
|
||||
MatchedAlbumID: pgtype.UUID{},
|
||||
MatchedTrackID: pgtype.UUID{},
|
||||
})
|
||||
return err
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
r.publishCompleted(completed)
|
||||
return nil
|
||||
}
|
||||
|
||||
func (r *Reconciler) reconcileAlbum(ctx context.Context, q *dbq.Queries, row dbq.LidarrRequest) error {
|
||||
@@ -138,13 +186,17 @@ func (r *Reconciler) reconcileAlbum(ctx context.Context, q *dbq.Queries, row dbq
|
||||
}
|
||||
return err
|
||||
}
|
||||
_, err = q.CompleteLidarrRequest(ctx, dbq.CompleteLidarrRequestParams{
|
||||
completed, err := q.CompleteLidarrRequest(ctx, dbq.CompleteLidarrRequestParams{
|
||||
ID: row.ID,
|
||||
MatchedAlbumID: albumID,
|
||||
MatchedArtistID: pgtype.UUID{},
|
||||
MatchedTrackID: pgtype.UUID{},
|
||||
})
|
||||
return err
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
r.publishCompleted(completed)
|
||||
return nil
|
||||
}
|
||||
|
||||
func (r *Reconciler) reconcileTrack(ctx context.Context, q *dbq.Queries, row dbq.LidarrRequest) error {
|
||||
@@ -178,13 +230,17 @@ func (r *Reconciler) reconcileTrack(ctx context.Context, q *dbq.Queries, row dbq
|
||||
return err
|
||||
}
|
||||
|
||||
_, err = q.CompleteLidarrRequest(ctx, dbq.CompleteLidarrRequestParams{
|
||||
completed, err := q.CompleteLidarrRequest(ctx, dbq.CompleteLidarrRequestParams{
|
||||
ID: row.ID,
|
||||
MatchedAlbumID: albumID,
|
||||
MatchedTrackID: trackID,
|
||||
MatchedArtistID: pgtype.UUID{},
|
||||
})
|
||||
return err
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
r.publishCompleted(completed)
|
||||
return nil
|
||||
}
|
||||
|
||||
func isNoRows(err error) bool {
|
||||
|
||||
@@ -121,7 +121,7 @@ func TestReconciler_MatchesArtistByMBID(t *testing.T) {
|
||||
Kind: "artist", LidarrArtistMBID: artistMBID, ArtistName: "Boards of Canada",
|
||||
})
|
||||
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger())
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger(), nil)
|
||||
if err := rec.tickOnce(ctx); err != nil {
|
||||
t.Fatalf("tickOnce: %v", err)
|
||||
}
|
||||
@@ -158,7 +158,7 @@ func TestReconciler_MatchesAlbumByMBID(t *testing.T) {
|
||||
LidarrAlbumMBID: albumMBID, AlbumTitle: "Test Album",
|
||||
})
|
||||
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger())
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger(), nil)
|
||||
if err := rec.tickOnce(ctx); err != nil {
|
||||
t.Fatalf("tickOnce: %v", err)
|
||||
}
|
||||
@@ -200,7 +200,7 @@ func TestReconciler_MatchesTrackViaAlbumMBID(t *testing.T) {
|
||||
LidarrTrackMBID: trackMBID, TrackTitle: "Track One",
|
||||
})
|
||||
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger())
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger(), nil)
|
||||
if err := rec.tickOnce(ctx); err != nil {
|
||||
t.Fatalf("tickOnce: %v", err)
|
||||
}
|
||||
@@ -234,7 +234,7 @@ func TestReconciler_NoMatchLeavesPending(t *testing.T) {
|
||||
Kind: "artist", LidarrArtistMBID: "nonexistent-mbid-xyz", ArtistName: "Ghost Artist",
|
||||
})
|
||||
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger())
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger(), nil)
|
||||
if err := rec.tickOnce(ctx); err != nil {
|
||||
t.Fatalf("tickOnce: %v", err)
|
||||
}
|
||||
@@ -278,7 +278,7 @@ func TestReconciler_AlreadyCompletedRowNotReprocessed(t *testing.T) {
|
||||
t.Fatalf("CompleteLidarrRequest setup: %v", err)
|
||||
}
|
||||
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger())
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger(), nil)
|
||||
if err := rec.tickOnce(ctx); err != nil {
|
||||
t.Fatalf("tickOnce: %v", err)
|
||||
}
|
||||
@@ -313,7 +313,7 @@ func TestReconciler_DisabledIsNoOp(t *testing.T) {
|
||||
Kind: "artist", LidarrArtistMBID: artistMBID, ArtistName: "No-Op Artist",
|
||||
})
|
||||
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger())
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger(), nil)
|
||||
if err := rec.tickOnce(ctx); err != nil {
|
||||
t.Fatalf("tickOnce: %v", err)
|
||||
}
|
||||
@@ -345,7 +345,7 @@ func TestReconciler_RunRunsAtLeastOneTick(t *testing.T) {
|
||||
Kind: "artist", LidarrArtistMBID: mbid, ArtistName: "Run Artist",
|
||||
})
|
||||
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger())
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger(), nil)
|
||||
rec.tick = 25 * time.Millisecond
|
||||
|
||||
done := make(chan struct{})
|
||||
@@ -399,7 +399,7 @@ func TestReconciler_TrackKindNoTracksInAlbumYet(t *testing.T) {
|
||||
LidarrTrackMBID: "t-mbid-not-yet", TrackTitle: "Some Track",
|
||||
})
|
||||
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger())
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger(), nil)
|
||||
if err := rec.tickOnce(ctx); err != nil {
|
||||
t.Fatalf("tickOnce: %v", err)
|
||||
}
|
||||
@@ -428,7 +428,7 @@ func TestReconciler_AlbumKindNoMatchInAlbumsTable(t *testing.T) {
|
||||
LidarrAlbumMBID: "al-not-in-library", AlbumTitle: "Nope Album",
|
||||
})
|
||||
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger())
|
||||
rec := NewReconciler(pool, lidarrconfig.New(pool), newTestLogger(), nil)
|
||||
if err := rec.tickOnce(ctx); err != nil {
|
||||
t.Fatalf("tickOnce: %v", err)
|
||||
}
|
||||
|
||||
@@ -2,7 +2,7 @@ package playlists
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"log/slog"
|
||||
|
||||
"github.com/jackc/pgx/v5/pgtype"
|
||||
|
||||
@@ -34,24 +34,34 @@ type discoverTrack struct {
|
||||
// Returns up to discoverTotalSlots track IDs in the order they should
|
||||
// appear in the playlist (round-robin interleaved across buckets).
|
||||
// Empty slice when the library has no eligible tracks at all.
|
||||
func buildDiscoverCandidates(ctx context.Context, q *dbq.Queries, userID pgtype.UUID, dateStr string) ([]rankedCandidate, error) {
|
||||
//
|
||||
// Individual bucket query failures are logged and treated as empty —
|
||||
// the redistribution algorithm rolls the deficit into the surviving
|
||||
// buckets so one broken bucket can't silently kill the whole playlist.
|
||||
func buildDiscoverCandidates(ctx context.Context, q *dbq.Queries, logger *slog.Logger, userID pgtype.UUID, dateStr string) ([]rankedCandidate, error) {
|
||||
dormantRows, err := q.ListDormantArtistTracksForDiscover(ctx, dbq.ListDormantArtistTracksForDiscoverParams{
|
||||
UserID: userID, Column2: dateStr,
|
||||
})
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("dormant bucket: %w", err)
|
||||
logger.Warn("discover: dormant bucket failed; continuing with empty pool",
|
||||
"user_id", uuidStringPL(userID), "err", err)
|
||||
dormantRows = nil
|
||||
}
|
||||
crossUserRows, err := q.ListCrossUserLikedTracksForDiscover(ctx, dbq.ListCrossUserLikedTracksForDiscoverParams{
|
||||
UserID: userID, Column2: dateStr,
|
||||
})
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("cross-user bucket: %w", err)
|
||||
logger.Warn("discover: cross-user bucket failed; continuing with empty pool",
|
||||
"user_id", uuidStringPL(userID), "err", err)
|
||||
crossUserRows = nil
|
||||
}
|
||||
randomRows, err := q.ListRandomUnheardTracksForDiscover(ctx, dbq.ListRandomUnheardTracksForDiscoverParams{
|
||||
UserID: userID, Column2: dateStr,
|
||||
})
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("random bucket: %w", err)
|
||||
logger.Warn("discover: random bucket failed; continuing with empty pool",
|
||||
"user_id", uuidStringPL(userID), "err", err)
|
||||
randomRows = nil
|
||||
}
|
||||
|
||||
// Adapt sqlc-generated rows into the internal struct, then apply
|
||||
@@ -244,18 +254,41 @@ func redistributeSlots(buckets []bucketRequest) []int {
|
||||
|
||||
// interleaveBuckets round-robins items from the buckets in order. The
|
||||
// first item of each bucket appears before the second of any bucket.
|
||||
// interleaveBuckets walks each bucket round-robin, emitting one track
|
||||
// per bucket per pass. Tracks already seen in an earlier bucket (or an
|
||||
// earlier pass) are skipped — single-user servers hit this often
|
||||
// because the empty crossUser bucket redistributes slots to dormant +
|
||||
// random, and a dormant-artist track is also a valid random-unheard
|
||||
// pick. Without dedup the same track lands at two interleaved
|
||||
// positions, which on a 2-bucket round-robin (dormant+random)
|
||||
// produces ADJACENT duplicates in the playlist — exactly the
|
||||
// "every song has a duplicate right after it" report from v2026.05.13.0.
|
||||
//
|
||||
// Dedup priority is bucket order (caller-supplied), so a track in both
|
||||
// dormant and random is taken from dormant.
|
||||
func interleaveBuckets(buckets ...[]discoverTrack) []discoverTrack {
|
||||
total := 0
|
||||
for _, b := range buckets {
|
||||
total += len(b)
|
||||
}
|
||||
out := make([]discoverTrack, 0, total)
|
||||
seen := make(map[pgtype.UUID]struct{}, total)
|
||||
indices := make([]int, len(buckets))
|
||||
for {
|
||||
anyAppended := false
|
||||
for bi, b := range buckets {
|
||||
// Advance past tracks already taken from an earlier bucket
|
||||
// or an earlier pass.
|
||||
for indices[bi] < len(b) {
|
||||
if _, dup := seen[b[indices[bi]].ID]; !dup {
|
||||
break
|
||||
}
|
||||
indices[bi]++
|
||||
}
|
||||
if indices[bi] < len(b) {
|
||||
out = append(out, b[indices[bi]])
|
||||
t := b[indices[bi]]
|
||||
out = append(out, t)
|
||||
seen[t.ID] = struct{}{}
|
||||
indices[bi]++
|
||||
anyAppended = true
|
||||
}
|
||||
|
||||
@@ -137,3 +137,27 @@ func TestInterleaveBuckets_RoundRobin(t *testing.T) {
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestInterleaveBuckets_DedupsAcrossBuckets(t *testing.T) {
|
||||
// Single-user server scenario: crossUser bucket empty, dormant +
|
||||
// random share tracks. Without dedup, shared tracks land at
|
||||
// adjacent interleaved positions — the duplication users reported
|
||||
// on the Discover playlist in v2026.05.13.0.
|
||||
dormant := []discoverTrack{{ID: uuidN(1)}, {ID: uuidN(2)}, {ID: uuidN(3)}}
|
||||
crossUser := []discoverTrack{} // empty bucket, single-user server
|
||||
random := []discoverTrack{{ID: uuidN(1)}, {ID: uuidN(2)}, {ID: uuidN(4)}}
|
||||
got := interleaveBuckets(dormant, crossUser, random)
|
||||
|
||||
// Tracks 1 and 2 appear in both dormant and random — must be
|
||||
// emitted once each (from dormant, the earlier bucket). Track 3
|
||||
// is dormant-only, track 4 is random-only.
|
||||
if len(got) != 4 {
|
||||
t.Fatalf("len = %d, want 4 (3 unique from dormant + 1 unique from random)", len(got))
|
||||
}
|
||||
wantOrder := []byte{1, 2, 3, 4}
|
||||
for i, w := range wantOrder {
|
||||
if got[i].ID.Bytes[15] != w {
|
||||
t.Errorf("got[%d].ID = %d, want %d", i, got[i].ID.Bytes[15], w)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user