feat(web): TrackMenu rewrite — 9 entries in 4 groups (M7 #372)
Replaces the M5b-era FlagPopover-only menu with the full track-actions surface: queue (Play next, Add to queue), collection (Like/Unlike, Add to playlist… reserved for #352), navigation (Go to album/artist), lifecycle (Flag, Hide/Unhide, Remove from library — admin-only). Remove from library opens a new RemoveTrackPopover with a single "Also stop Lidarr from finding a replacement" checkbox. The destructive flow always deletes file + DB through Minstrel; the checkbox controls whether Lidarr is also told to unmonitor. Lidarr unmonitor failure flows back as lidarr_unmonitor_failed in the response — destructive part already succeeded. The component's prop API (track, direction) is unchanged so TrackRow and PlayerBar pick up the new entries with no code change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,102 @@
|
||||
<script lang="ts">
|
||||
import { Trash2 } from 'lucide-svelte';
|
||||
import { useQueryClient } from '@tanstack/svelte-query';
|
||||
import { removeTrack } from '$lib/api/admin/tracks';
|
||||
import { copyForCode } from '$lib/api/error-copy';
|
||||
import { qk } from '$lib/api/queries';
|
||||
import type { TrackRef } from '$lib/api/types';
|
||||
|
||||
let {
|
||||
track,
|
||||
onClose
|
||||
}: {
|
||||
track: TrackRef;
|
||||
onClose: () => void;
|
||||
} = $props();
|
||||
|
||||
const queryClient = useQueryClient();
|
||||
|
||||
let unmonitor = $state(false);
|
||||
let busy = $state(false);
|
||||
let error = $state<string | null>(null);
|
||||
|
||||
async function confirm() {
|
||||
busy = true;
|
||||
error = null;
|
||||
try {
|
||||
const result = await removeTrack(track.id, { unmonitor });
|
||||
// Invalidate caches for any vanished entity. The album/artist that
|
||||
// contained the track is always touched; if the parent rows were
|
||||
// tidied up by the server cascade, evict those too. Home payload
|
||||
// surfaces albums/artists on the landing page so it always
|
||||
// refreshes.
|
||||
await queryClient.invalidateQueries({ queryKey: qk.album(track.album_id) });
|
||||
await queryClient.invalidateQueries({ queryKey: qk.artist(track.artist_id) });
|
||||
await queryClient.invalidateQueries({ queryKey: qk.home() });
|
||||
if (result.deleted_album_id) {
|
||||
await queryClient.invalidateQueries({ queryKey: qk.album(result.deleted_album_id) });
|
||||
}
|
||||
if (result.deleted_artist_id) {
|
||||
await queryClient.invalidateQueries({ queryKey: qk.artist(result.deleted_artist_id) });
|
||||
}
|
||||
// Note: result.lidarr_unmonitor_failed is true when unmonitor was
|
||||
// requested AND Lidarr couldn't be reached. The destructive part
|
||||
// already succeeded; we still close the popover. A future toast
|
||||
// surface (if any) can pick up the flag.
|
||||
onClose();
|
||||
} catch (e: unknown) {
|
||||
const code = (e as { code?: string })?.code ?? 'unknown';
|
||||
error = copyForCode(code);
|
||||
} finally {
|
||||
busy = false;
|
||||
}
|
||||
}
|
||||
</script>
|
||||
|
||||
<div
|
||||
role="dialog"
|
||||
aria-modal="false"
|
||||
aria-labelledby="remove-track-popover-title"
|
||||
class="absolute right-0 z-30 mt-1 w-72 rounded-lg border border-border bg-surface p-3 shadow-xl"
|
||||
onclick={(e) => e.stopPropagation()}
|
||||
>
|
||||
<h4 id="remove-track-popover-title" class="text-sm font-medium text-text-primary">
|
||||
Remove "{track.title}" from your library?
|
||||
</h4>
|
||||
<p class="mt-1 text-xs text-text-muted">
|
||||
This deletes the file from disk.
|
||||
</p>
|
||||
|
||||
<label class="mt-3 flex items-start gap-2 text-sm text-text-primary">
|
||||
<input
|
||||
type="checkbox"
|
||||
bind:checked={unmonitor}
|
||||
class="mt-0.5 rounded border-border"
|
||||
/>
|
||||
<span>Also stop Lidarr from finding a replacement</span>
|
||||
</label>
|
||||
|
||||
{#if error}
|
||||
<p class="mt-2 text-xs text-action-destructive">{error}</p>
|
||||
{/if}
|
||||
|
||||
<div class="mt-3 flex justify-end gap-2">
|
||||
<button
|
||||
type="button"
|
||||
class="rounded-md border border-border px-2.5 py-1 text-sm text-text-secondary hover:text-text-primary disabled:opacity-50"
|
||||
onclick={onClose}
|
||||
disabled={busy}
|
||||
>
|
||||
Cancel
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
onclick={confirm}
|
||||
disabled={busy}
|
||||
class="inline-flex items-center gap-1 rounded-md border border-border bg-surface px-2.5 py-1 text-sm text-action-destructive hover:bg-surface-hover disabled:opacity-50"
|
||||
>
|
||||
<Trash2 size={14} strokeWidth={1} />
|
||||
{busy ? 'Removing…' : 'Remove'}
|
||||
</button>
|
||||
</div>
|
||||
</div>
|
||||
@@ -0,0 +1,114 @@
|
||||
import { afterEach, describe, expect, test, vi } from 'vitest';
|
||||
import { render, screen, fireEvent } from '@testing-library/svelte';
|
||||
import type { TrackRef } from '$lib/api/types';
|
||||
|
||||
const invalidateMock = vi.fn();
|
||||
vi.mock('@tanstack/svelte-query', async (orig) => {
|
||||
const actual = (await orig()) as Record<string, unknown>;
|
||||
return {
|
||||
...actual,
|
||||
useQueryClient: () => ({ invalidateQueries: invalidateMock })
|
||||
};
|
||||
});
|
||||
|
||||
vi.mock('$lib/api/admin/tracks', () => ({
|
||||
removeTrack: vi.fn()
|
||||
}));
|
||||
|
||||
import RemoveTrackPopover from './RemoveTrackPopover.svelte';
|
||||
import { removeTrack } from '$lib/api/admin/tracks';
|
||||
|
||||
const track: TrackRef = {
|
||||
id: 't1',
|
||||
title: 'Roygbiv',
|
||||
album_id: 'a1',
|
||||
album_title: 'Geogaddi',
|
||||
artist_id: 'ar1',
|
||||
artist_name: 'Boards of Canada',
|
||||
duration_sec: 240,
|
||||
stream_url: '/api/tracks/t1/stream'
|
||||
};
|
||||
|
||||
afterEach(() => vi.clearAllMocks());
|
||||
|
||||
describe('RemoveTrackPopover', () => {
|
||||
test('renders the title and subtext', () => {
|
||||
render(RemoveTrackPopover, { props: { track, onClose: vi.fn() } });
|
||||
expect(screen.getByText(/remove "roygbiv" from your library/i)).toBeInTheDocument();
|
||||
expect(screen.getByText(/this deletes the file from disk/i)).toBeInTheDocument();
|
||||
});
|
||||
|
||||
test('renders the Lidarr unmonitor checkbox', () => {
|
||||
render(RemoveTrackPopover, { props: { track, onClose: vi.fn() } });
|
||||
const cb = screen.getByRole('checkbox', { name: /also stop lidarr/i });
|
||||
expect(cb).toBeInTheDocument();
|
||||
expect((cb as HTMLInputElement).checked).toBe(false);
|
||||
});
|
||||
|
||||
test('Cancel button calls onClose without firing removeTrack', async () => {
|
||||
const onClose = vi.fn();
|
||||
render(RemoveTrackPopover, { props: { track, onClose } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /cancel/i }));
|
||||
expect(removeTrack).not.toHaveBeenCalled();
|
||||
expect(onClose).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
test('Remove without checkbox calls removeTrack with unmonitor=false', async () => {
|
||||
(removeTrack as ReturnType<typeof vi.fn>).mockResolvedValue({ deleted_track_id: 't1' });
|
||||
const onClose = vi.fn();
|
||||
render(RemoveTrackPopover, { props: { track, onClose } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /^remove$/i }));
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
expect(removeTrack).toHaveBeenCalledWith('t1', { unmonitor: false });
|
||||
expect(onClose).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
test('Remove with checkbox checked calls removeTrack with unmonitor=true', async () => {
|
||||
(removeTrack as ReturnType<typeof vi.fn>).mockResolvedValue({ deleted_track_id: 't1' });
|
||||
const onClose = vi.fn();
|
||||
render(RemoveTrackPopover, { props: { track, onClose } });
|
||||
await fireEvent.click(screen.getByRole('checkbox', { name: /also stop lidarr/i }));
|
||||
await fireEvent.click(screen.getByRole('button', { name: /^remove$/i }));
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
expect(removeTrack).toHaveBeenCalledWith('t1', { unmonitor: true });
|
||||
expect(onClose).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
test('failed remove surfaces error via copyForCode and does not close', async () => {
|
||||
(removeTrack as ReturnType<typeof vi.fn>).mockRejectedValue({ code: 'not_found' });
|
||||
const onClose = vi.fn();
|
||||
render(RemoveTrackPopover, { props: { track, onClose } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /^remove$/i }));
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
expect(onClose).not.toHaveBeenCalled();
|
||||
// copyForCode resolves "not_found" against error-copy.json — the
|
||||
// exact copy isn't important here; just confirm SOME error surfaced.
|
||||
// We assert by re-querying: any text inside the popover that's not
|
||||
// the title/subtext/labels would be the error message.
|
||||
expect(removeTrack).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
test('success invalidates album, artist and home queries', async () => {
|
||||
(removeTrack as ReturnType<typeof vi.fn>).mockResolvedValue({
|
||||
deleted_track_id: 't1',
|
||||
deleted_album_id: 'a1',
|
||||
deleted_artist_id: 'ar1'
|
||||
});
|
||||
render(RemoveTrackPopover, { props: { track, onClose: vi.fn() } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /^remove$/i }));
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
await Promise.resolve();
|
||||
expect(invalidateMock).toHaveBeenCalled();
|
||||
// Find the album / artist / home invalidations among the calls.
|
||||
const keys = invalidateMock.mock.calls.map((c) => c[0].queryKey);
|
||||
const flat = keys.map((k) => Array.isArray(k) ? k.join('|') : String(k));
|
||||
expect(flat.some((k) => k.startsWith('album|a1'))).toBe(true);
|
||||
expect(flat.some((k) => k.startsWith('artist|ar1'))).toBe(true);
|
||||
expect(flat.some((k) => k === 'home')).toBe(true);
|
||||
});
|
||||
});
|
||||
@@ -1,6 +1,29 @@
|
||||
<script lang="ts">
|
||||
import { MoreVertical, Flag } from 'lucide-svelte';
|
||||
import {
|
||||
MoreVertical,
|
||||
ListPlus,
|
||||
Plus,
|
||||
Heart,
|
||||
HeartOff,
|
||||
ListMusic,
|
||||
Album,
|
||||
Disc3,
|
||||
Flag,
|
||||
EyeOff,
|
||||
Eye,
|
||||
Trash2
|
||||
} from 'lucide-svelte';
|
||||
import { goto } from '$app/navigation';
|
||||
import { useQueryClient } from '@tanstack/svelte-query';
|
||||
import FlagPopover from './FlagPopover.svelte';
|
||||
import RemoveTrackPopover from './RemoveTrackPopover.svelte';
|
||||
import TrackMenuItem from './TrackMenuItem.svelte';
|
||||
import TrackMenuDivider from './TrackMenuDivider.svelte';
|
||||
import { user } from '$lib/auth/store.svelte';
|
||||
import { createLikedIdsQuery, likeEntity, unlikeEntity } from '$lib/api/likes';
|
||||
import { createMyQuarantineQuery, unflagTrack } from '$lib/api/quarantine';
|
||||
import { qk } from '$lib/api/queries';
|
||||
import { playNext, enqueueTrack } from '$lib/player/store.svelte';
|
||||
import type { TrackRef } from '$lib/api/types';
|
||||
|
||||
let {
|
||||
@@ -14,28 +37,100 @@
|
||||
} = $props();
|
||||
|
||||
let menuOpen = $state(false);
|
||||
let popoverOpen = $state(false);
|
||||
let flagOpen = $state(false);
|
||||
let removeOpen = $state(false);
|
||||
|
||||
const queryClient = useQueryClient();
|
||||
|
||||
const likedQ = $derived(createLikedIdsQuery());
|
||||
const liked = $derived.by(() => {
|
||||
const data = $likedQ?.data;
|
||||
if (!data) return false;
|
||||
return data.track_ids.includes(track.id);
|
||||
});
|
||||
|
||||
const hiddenQ = $derived(createMyQuarantineQuery());
|
||||
const hidden = $derived.by(() => {
|
||||
const rows = $hiddenQ?.data;
|
||||
if (!rows) return false;
|
||||
return rows.some((r) => r.track_id === track.id);
|
||||
});
|
||||
|
||||
const isAdmin = $derived(user.value?.is_admin === true);
|
||||
|
||||
function toggleMenu(e: MouseEvent) {
|
||||
e.stopPropagation();
|
||||
menuOpen = !menuOpen;
|
||||
}
|
||||
|
||||
function openFlag() {
|
||||
menuOpen = false;
|
||||
popoverOpen = true;
|
||||
}
|
||||
|
||||
function closeAll() {
|
||||
menuOpen = false;
|
||||
popoverOpen = false;
|
||||
flagOpen = false;
|
||||
removeOpen = false;
|
||||
}
|
||||
|
||||
function onPlayNext() {
|
||||
playNext(track);
|
||||
closeAll();
|
||||
}
|
||||
|
||||
function onAddToQueue() {
|
||||
enqueueTrack(track);
|
||||
closeAll();
|
||||
}
|
||||
|
||||
async function onToggleLike() {
|
||||
closeAll();
|
||||
if (liked) {
|
||||
await unlikeEntity(queryClient, 'track', track.id);
|
||||
} else {
|
||||
await likeEntity(queryClient, 'track', track.id);
|
||||
}
|
||||
}
|
||||
|
||||
async function onToggleHide() {
|
||||
if (hidden) {
|
||||
// Unhide: simple — unflag, then refresh the quarantine list.
|
||||
await unflagTrack(track.id);
|
||||
await queryClient.invalidateQueries({ queryKey: qk.myQuarantine() });
|
||||
closeAll();
|
||||
} else {
|
||||
// Hide: needs a reason. Reuse FlagPopover.
|
||||
menuOpen = false;
|
||||
flagOpen = true;
|
||||
}
|
||||
}
|
||||
|
||||
function onGoToAlbum() {
|
||||
closeAll();
|
||||
goto(`/albums/${track.album_id}`);
|
||||
}
|
||||
|
||||
function onGoToArtist() {
|
||||
closeAll();
|
||||
goto(`/artists/${track.artist_id}`);
|
||||
}
|
||||
|
||||
function onFlag() {
|
||||
menuOpen = false;
|
||||
flagOpen = true;
|
||||
}
|
||||
|
||||
function onRemoveOpen() {
|
||||
menuOpen = false;
|
||||
removeOpen = true;
|
||||
}
|
||||
|
||||
function onKeydown(e: KeyboardEvent) {
|
||||
if (!menuOpen && !flagOpen && !removeOpen) return;
|
||||
if (e.key === 'Escape') {
|
||||
e.preventDefault();
|
||||
closeAll();
|
||||
}
|
||||
}
|
||||
</script>
|
||||
|
||||
<svelte:window
|
||||
onclick={() => (menuOpen = false)}
|
||||
onkeydown={(e) => e.key === 'Escape' && closeAll()}
|
||||
/>
|
||||
<svelte:window onclick={() => (menuOpen = false)} onkeydown={onKeydown} />
|
||||
|
||||
<div class="relative inline-block">
|
||||
<button
|
||||
@@ -52,22 +147,56 @@
|
||||
{#if menuOpen}
|
||||
<div
|
||||
role="menu"
|
||||
class="absolute right-0 z-20 w-48 rounded-md border border-border bg-surface p-1 shadow-lg {direction === 'up' ? 'bottom-full mb-1' : 'top-full mt-1'}"
|
||||
class="absolute right-0 z-20 w-56 rounded-md border border-border bg-surface p-1 shadow-lg
|
||||
{direction === 'up' ? 'bottom-full mb-1' : 'top-full mt-1'}"
|
||||
onclick={(e) => e.stopPropagation()}
|
||||
>
|
||||
<button
|
||||
type="button"
|
||||
role="menuitem"
|
||||
onclick={openFlag}
|
||||
class="flex w-full items-center gap-2 rounded px-2 py-1.5 text-sm text-text-primary hover:bg-surface-hover"
|
||||
>
|
||||
<Flag size={14} strokeWidth={1} />
|
||||
Flag this track…
|
||||
</button>
|
||||
<TrackMenuItem icon={ListPlus} label="Play next" onclick={onPlayNext} />
|
||||
<TrackMenuItem icon={Plus} label="Add to queue" onclick={onAddToQueue} />
|
||||
|
||||
<TrackMenuDivider />
|
||||
|
||||
<TrackMenuItem
|
||||
icon={liked ? HeartOff : Heart}
|
||||
label={liked ? 'Unlike' : 'Like'}
|
||||
onclick={onToggleLike}
|
||||
/>
|
||||
<TrackMenuItem
|
||||
icon={ListMusic}
|
||||
label="Add to playlist…"
|
||||
disabled
|
||||
title="Coming with playlists"
|
||||
/>
|
||||
|
||||
<TrackMenuDivider />
|
||||
|
||||
<TrackMenuItem icon={Album} label="Go to album" onclick={onGoToAlbum} />
|
||||
<TrackMenuItem icon={Disc3} label="Go to artist" onclick={onGoToArtist} />
|
||||
|
||||
<TrackMenuDivider />
|
||||
|
||||
<TrackMenuItem icon={Flag} label="Flag this track…" onclick={onFlag} />
|
||||
<TrackMenuItem
|
||||
icon={hidden ? Eye : EyeOff}
|
||||
label={hidden ? 'Unhide' : 'Hide'}
|
||||
onclick={onToggleHide}
|
||||
/>
|
||||
{#if isAdmin}
|
||||
<TrackMenuItem
|
||||
icon={Trash2}
|
||||
label="Remove from library"
|
||||
onclick={onRemoveOpen}
|
||||
danger
|
||||
/>
|
||||
{/if}
|
||||
</div>
|
||||
{/if}
|
||||
|
||||
{#if popoverOpen}
|
||||
{#if flagOpen}
|
||||
<FlagPopover {track} onClose={closeAll} />
|
||||
{/if}
|
||||
|
||||
{#if removeOpen}
|
||||
<RemoveTrackPopover {track} onClose={closeAll} />
|
||||
{/if}
|
||||
</div>
|
||||
|
||||
@@ -1,16 +1,54 @@
|
||||
import { afterEach, describe, expect, test, vi } from 'vitest';
|
||||
import { render, screen, fireEvent } from '@testing-library/svelte';
|
||||
import TrackMenu from './TrackMenu.svelte';
|
||||
import { readable } from 'svelte/store';
|
||||
import type { TrackRef } from '$lib/api/types';
|
||||
|
||||
// Mutable mock-user handle so individual tests can flip is_admin / null
|
||||
// without re-importing the module under test.
|
||||
const userState = vi.hoisted(() => ({
|
||||
current: { id: 'u1', username: 'admin', is_admin: true } as
|
||||
| { id: string; username: string; is_admin: boolean }
|
||||
| null
|
||||
}));
|
||||
|
||||
vi.mock('$lib/auth/store.svelte', () => ({
|
||||
user: { get value() { return userState.current; } }
|
||||
}));
|
||||
|
||||
vi.mock('$app/navigation', () => ({
|
||||
goto: vi.fn()
|
||||
}));
|
||||
|
||||
vi.mock('$lib/api/likes', () => ({
|
||||
createLikedIdsQuery: () =>
|
||||
readable({ data: { track_ids: [], album_ids: [], artist_ids: [] }, isPending: false, isError: false }),
|
||||
likeEntity: vi.fn().mockResolvedValue(undefined),
|
||||
unlikeEntity: vi.fn().mockResolvedValue(undefined)
|
||||
}));
|
||||
|
||||
vi.mock('$lib/api/quarantine', () => ({
|
||||
flagTrack: vi.fn().mockResolvedValue({}),
|
||||
unflagTrack: vi.fn().mockResolvedValue(undefined),
|
||||
listMyQuarantine: vi.fn().mockResolvedValue([]),
|
||||
createMyQuarantineQuery: () => readable({ data: [], isPending: false, isError: false })
|
||||
}));
|
||||
|
||||
vi.mock('$lib/api/admin/tracks', () => ({
|
||||
removeTrack: vi.fn().mockResolvedValue({ deleted_track_id: 't1' })
|
||||
}));
|
||||
|
||||
vi.mock('$lib/player/store.svelte', () => ({
|
||||
playNext: vi.fn(),
|
||||
enqueueTrack: vi.fn()
|
||||
}));
|
||||
|
||||
vi.mock('@tanstack/svelte-query', async (orig) => {
|
||||
const actual = (await orig()) as Record<string, unknown>;
|
||||
return { ...actual, useQueryClient: () => ({ invalidateQueries: vi.fn() }) };
|
||||
});
|
||||
|
||||
vi.mock('$lib/api/quarantine', () => ({
|
||||
flagTrack: vi.fn().mockResolvedValue({})
|
||||
}));
|
||||
import TrackMenu from './TrackMenu.svelte';
|
||||
import { playNext, enqueueTrack } from '$lib/player/store.svelte';
|
||||
|
||||
const track: TrackRef = {
|
||||
id: 't1',
|
||||
@@ -23,18 +61,68 @@ const track: TrackRef = {
|
||||
stream_url: '/api/tracks/t1/stream'
|
||||
};
|
||||
|
||||
afterEach(() => vi.clearAllMocks());
|
||||
afterEach(() => {
|
||||
vi.clearAllMocks();
|
||||
userState.current = { id: 'u1', username: 'admin', is_admin: true };
|
||||
});
|
||||
|
||||
describe('TrackMenu', () => {
|
||||
test('opens menu on kebab click', async () => {
|
||||
test('kebab toggles aria-expanded', async () => {
|
||||
render(TrackMenu, { props: { track } });
|
||||
expect(screen.queryByRole('menu')).not.toBeInTheDocument();
|
||||
await fireEvent.click(screen.getByRole('button', { name: /track actions for roygbiv/i }));
|
||||
expect(screen.getByRole('menu')).toBeInTheDocument();
|
||||
expect(screen.getByRole('menuitem', { name: /flag this track/i })).toBeInTheDocument();
|
||||
const kebab = screen.getByRole('button', { name: /track actions for roygbiv/i });
|
||||
expect(kebab.getAttribute('aria-expanded')).toBe('false');
|
||||
await fireEvent.click(kebab);
|
||||
expect(kebab.getAttribute('aria-expanded')).toBe('true');
|
||||
});
|
||||
|
||||
test('Escape key closes menu', async () => {
|
||||
test('opening menu shows all 9 entries for an admin user', async () => {
|
||||
render(TrackMenu, { props: { track } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /track actions/i }));
|
||||
|
||||
expect(screen.getByRole('menuitem', { name: /play next/i })).toBeInTheDocument();
|
||||
expect(screen.getByRole('menuitem', { name: /add to queue/i })).toBeInTheDocument();
|
||||
expect(screen.getByRole('menuitem', { name: /^like$/i })).toBeInTheDocument();
|
||||
expect(screen.getByRole('menuitem', { name: /add to playlist/i })).toBeInTheDocument();
|
||||
expect(screen.getByRole('menuitem', { name: /go to album/i })).toBeInTheDocument();
|
||||
expect(screen.getByRole('menuitem', { name: /go to artist/i })).toBeInTheDocument();
|
||||
expect(screen.getByRole('menuitem', { name: /flag this track/i })).toBeInTheDocument();
|
||||
expect(screen.getByRole('menuitem', { name: /^hide$/i })).toBeInTheDocument();
|
||||
expect(screen.getByRole('menuitem', { name: /remove from library/i })).toBeInTheDocument();
|
||||
|
||||
expect(screen.getAllByRole('menuitem')).toHaveLength(9);
|
||||
});
|
||||
|
||||
test('"Remove from library" hidden for non-admin', async () => {
|
||||
userState.current = { id: 'u2', username: 'normal', is_admin: false };
|
||||
render(TrackMenu, { props: { track } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /track actions/i }));
|
||||
expect(screen.queryByRole('menuitem', { name: /remove from library/i })).not.toBeInTheDocument();
|
||||
expect(screen.getAllByRole('menuitem')).toHaveLength(8);
|
||||
});
|
||||
|
||||
test('"Add to playlist…" rendered as aria-disabled with tooltip', async () => {
|
||||
render(TrackMenu, { props: { track } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /track actions/i }));
|
||||
const item = screen.getByRole('menuitem', { name: /add to playlist/i });
|
||||
expect(item.getAttribute('aria-disabled')).toBe('true');
|
||||
expect(item.getAttribute('title')).toBe('Coming with playlists');
|
||||
});
|
||||
|
||||
test('"Play next" dispatches playNext(track)', async () => {
|
||||
render(TrackMenu, { props: { track } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /track actions/i }));
|
||||
await fireEvent.click(screen.getByRole('menuitem', { name: /play next/i }));
|
||||
expect(playNext).toHaveBeenCalledWith(track);
|
||||
});
|
||||
|
||||
test('"Add to queue" dispatches enqueueTrack(track)', async () => {
|
||||
render(TrackMenu, { props: { track } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /track actions/i }));
|
||||
await fireEvent.click(screen.getByRole('menuitem', { name: /add to queue/i }));
|
||||
expect(enqueueTrack).toHaveBeenCalledWith(track);
|
||||
});
|
||||
|
||||
test('Escape closes the menu', async () => {
|
||||
render(TrackMenu, { props: { track } });
|
||||
await fireEvent.click(screen.getByRole('button', { name: /track actions/i }));
|
||||
expect(screen.getByRole('menu')).toBeInTheDocument();
|
||||
@@ -47,6 +135,8 @@ describe('TrackMenu', () => {
|
||||
await fireEvent.click(screen.getByRole('button', { name: /track actions/i }));
|
||||
await fireEvent.click(screen.getByRole('menuitem', { name: /flag this track/i }));
|
||||
expect(screen.queryByRole('menu')).not.toBeInTheDocument();
|
||||
expect(screen.getByRole('dialog', { name: /flag this track as broken/i })).toBeInTheDocument();
|
||||
expect(
|
||||
screen.getByRole('dialog', { name: /flag this track as broken/i })
|
||||
).toBeInTheDocument();
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user