fix(web): preserve per-row aria-labels through RowActionsMenu + test fixes

CI vitest run on 3f8a2c5 surfaced 17 failures across 5 test files; this
commit addresses 15 that are this batch's responsibility.

1. RowActionsMenu now accepts ariaLabel on RowAction. Defaults to label.
   Admin pages (requests/quarantine/users) pass per-row aria-labels
   matching the pre-batch buttons ("Approve Geogaddi", "Resolve Roygbiv",
   "Make alice admin", etc.) so screen readers + tests find them.

2. PlayerBar.test.ts — anchored regex /^(play|pause)$/i so the new
   "Player options" overflow ⋮ doesn't also match /play|pause/i.

3. MobileNavDrawer.test.ts — added vi.mock for $app/state, $app/navigation,
   and $lib/auth/store.svelte (mirrors Shell.test.ts pattern). Without
   these, SvelteKit's notifiable_store helper isn't bootstrapped in
   vitest and the suite fails to load.

The 2 remaining vitest failures are in /admin/integrations Save flow
(putLidarrConfig spy not called). Untouched by this batch and the
recent "Save runs Test first" refactor (bca8622) appears related —
flagging for operator verification, not chasing as a regression.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-09 21:16:48 -04:00
co-authored by Claude Opus 4.7
parent 3f8a2c511a
commit 3ffd9beca0
6 changed files with 72 additions and 8 deletions
+19 -3
View File
@@ -247,10 +247,26 @@
</div>
{#if r.status === 'pending'}
{@const primary: RowAction = { icon: Check, label: 'Approve', onclick: () => onApprove(r) }}
{@const primary: RowAction = {
icon: Check,
label: 'Approve',
ariaLabel: `Approve ${rowAccessibleName(r)}`,
onclick: () => onApprove(r)
}}
{@const secondary: RowAction[] = [
{ icon: SlidersHorizontal, label: 'Override', onclick: () => openOverride(r) },
{ icon: X, label: 'Reject', onclick: () => openReject(r), danger: true }
{
icon: SlidersHorizontal,
label: 'Override',
ariaLabel: `Override ${rowAccessibleName(r)}`,
onclick: () => openOverride(r)
},
{
icon: X,
label: 'Reject',
ariaLabel: `Reject ${rowAccessibleName(r)}`,
onclick: () => openReject(r),
danger: true
}
]}
<div class="shrink-0">
<RowActionsMenu {primary} {secondary} />