Files
FabledSteward/steward/templates/ansible/playbook_editor.html
T
bvandeusenandClaude Opus 5.5 f47fc23265 fix(ui): delete prompts use data-confirm, so a quote in a name no longer runs script (#5099)
#5099 "A name containing a quote runs script when an admin clicks Delete".
Inline handlers like onclick="return confirm('Delete {{ rule.name }}?')" are
HTML-decoded before the JavaScript is parsed, so autoescaping did not stop a
name such as  x');fetch(…);//  from running.

- Every prompt (22 handlers, plus the docker prune and token revoke ones)
  is now data-confirm="…", read through dataset by one submit listener in
  base.html; nothing rendered is parsed as JavaScript.
- The remaining inline handlers take integers only (|int), and the time
  range buttons pass this.dataset.range.
- tests/test_inline_handlers.py fails on any {{ }} in an inline handler that
  is not |int, with a self-test; tests/_templates.py is the one template
  walker the template guards now share.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-06 14:30:13 -04:00

65 lines
3.1 KiB
HTML

{% extends "base.html" %}
{% from "_macros.html" import crumbs %}
{% block title %}{{ "Edit" if editing else "New" }} Playbook — Steward{% endblock %}
{% block breadcrumb %}{{ crumbs([("Ansible", "/ansible/"), ("Browse", "/ansible/browse"), (("Edit " ~ playbook_path) if editing else "New playbook", "")]) }}{% endblock %}
{% block content %}
<div style="display:flex;align-items:center;justify-content:space-between;margin-bottom:1.25rem;gap:1rem;flex-wrap:wrap;">
<h1 class="page-title" style="margin-bottom:0;">{{ "Edit playbook" if editing else "New playbook" }}</h1>
</div>
{% if error %}<div class="alert alert-error">{{ error }}</div>{% endif %}
{% if not editable_sources %}
<div class="card empty">
No writable playbook source is available. The built-in <code>steward-local</code> source should appear
automatically; you can also configure a local-dir source under <a href="/settings/ansible/">Settings → Ansible</a>.
</div>
{% else %}
<form method="post" action="/ansible/playbooks/save">{{ csrf_field() }}
<input type="hidden" name="editing" value="{{ '1' if editing else '0' }}">
<div style="display:flex;gap:1rem;flex-wrap:wrap;margin-bottom:1rem;">
<div class="form-group" style="margin-bottom:0;">
<label>Source</label>
{% if editing %}
<input type="text" value="{{ source_name }}" readonly style="color:var(--text-muted);">
<input type="hidden" name="source_name" value="{{ source_name }}">
{% else %}
<select name="source_name" required>
{% for s in editable_sources %}
<option value="{{ s.name }}" {% if s.name == source_name %}selected{% endif %}>{{ s.name }}</option>
{% endfor %}
</select>
{% endif %}
</div>
<div class="form-group" style="margin-bottom:0;flex:1;min-width:240px;">
<label>Filename / path (.yml or .yaml)</label>
<input type="text" name="playbook_path" value="{{ playbook_path }}" required
{% if editing %}readonly style="color:var(--text-muted);"{% endif %}
placeholder="maintenance/restart_nginx.yml">
</div>
</div>
<div class="form-group">
<label>Playbook (YAML)</label>
<textarea name="content" rows="22" spellcheck="false"
style="width:100%;font-family:ui-monospace,monospace;font-size:0.85rem;white-space:pre;overflow-wrap:normal;overflow-x:auto;">{{ content }}</textarea>
<p style="color:var(--text-dim);font-size:0.75rem;margin-top:0.35rem;">
Validated as YAML on save. Runs as the configured Ansible user — admin only.
</p>
</div>
<div style="display:flex;gap:0.5rem;">
<button type="submit" class="btn">Save</button>
<a href="/ansible/browse" class="btn btn-ghost">Cancel</a>
</div>
</form>
{% if editing %}
<form method="post" action="/ansible/playbooks/delete" style="margin-top:1rem;"
data-confirm="Delete {{ playbook_path }}?">{{ csrf_field() }}
<input type="hidden" name="source_name" value="{{ source_name }}">
<input type="hidden" name="playbook_path" value="{{ playbook_path }}">
<button type="submit" class="btn btn-danger btn-sm">Delete playbook</button>
</form>
{% endif %}
{% endif %}
{% endblock %}