bvandeusen
4fc8c96c41
The SNMP plugin ships in the image but logged "pysnmp not installed — SNMP polling disabled" on every poll, so polling never worked. Two coupled defects: 1. The Dockerfile installed only `.[ansible]`, so the `snmp` extra (pysnmp) was never bundled even though the plugin is first-party and shipped. 2. poller.py used the synchronous pysnmp HLAPI (`next(getCmd(...))`), which pysnmp-lextudio 6.x removed — it's asyncio-only now — so even with the dep present, polling would have thrown and silently returned nothing. The 5.x line that still has the sync API isn't safe on the image's Python 3.13. Fix: - Dockerfile: install `.[ansible,snmp]`. - poller.py: `poll_device_sync` → `async def poll_device` on the asyncio HLAPI, with a dual-version import (pysnmp 7.x `pysnmp.hlapi.v3arch.asyncio`/`get_cmd` + async `UdpTransportTarget.create`; pysnmp-lextudio 6.2.x `pysnmp.hlapi.asyncio`/`getCmd` + direct `UdpTransportTarget`) so a dependency bump can't silently re-break it. - scheduler.py: await poll_device directly; drop the run_in_executor wrapper and the now-unused asyncio import. - Add tests/plugins/snmp/test_poller.py covering the version→mpModel mapping, that the poller is a coroutine, and the graceful no-pysnmp path. Note: CI confirms import/load and the no-pysnmp path, but has no SNMP target — live polling against real devices is verified after deploy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Jg27rgypiW2efULXJDtMC
33 lines
1.2 KiB
Python
33 lines
1.2 KiB
Python
"""Unit tests for the SNMP poller (no pysnmp / no network).
|
|
|
|
The unit lane doesn't install the `snmp` extra, so these exercise the parts that
|
|
don't need pysnmp: the version→mpModel mapping, that the poller is async, and the
|
|
graceful "pysnmp missing → empty result" path. Live polling against a real device
|
|
is verified out-of-band (CI has no SNMP target). Uses asyncio.run() directly so it
|
|
doesn't depend on the pytest-asyncio mode.
|
|
"""
|
|
import asyncio
|
|
import inspect
|
|
|
|
from plugins.snmp import poller
|
|
|
|
|
|
def test_poll_device_is_coroutine():
|
|
# The scheduler awaits it directly (no executor) — it must be async.
|
|
assert inspect.iscoroutinefunction(poller.poll_device)
|
|
|
|
|
|
def test_mp_model_maps_version_to_int():
|
|
assert poller._mp_model("1") == 0 # SNMP v1
|
|
assert poller._mp_model("2c") == 1 # SNMP v2c
|
|
assert poller._mp_model("2") == 1 # anything non-"1" → v2c model
|
|
|
|
|
|
def test_poll_device_without_pysnmp_returns_empty(monkeypatch):
|
|
# When the optional dep is absent, polling is disabled gracefully (no raise).
|
|
monkeypatch.setattr(poller, "_pysnmp_available", lambda: False)
|
|
out = asyncio.run(
|
|
poller.poll_device("192.0.2.1", 161, "public", "2c", [{"oid": "1.3.6.1.2.1.1.3.0"}])
|
|
)
|
|
assert out == {}
|