Files
FabledSteward/tests/core/test_report_schedule.py
bvandeusenandClaude Opus 5.5 24700ee608
CI / lint (push) Successful in 2s
CI / integration (push) Successful in 56s
CI / unit (push) Successful in 1m24s
CI / publish (push) Successful in 1m9s
feat(settings): Settings brought into line with the rest of Steward (milestone 493)
The last page of #5214's walk. Settings still described Steward as it was
before monitors were unified and SNMP was rebuilt, drew its tabs below the
breadcrumb, and showed the report schedule in UTC.

- Tabs (#5377): settings/_tabs.html is a settings_tabs() macro called in
  each page's section_tabs block, above the trail, as Ansible's are. The
  breadcrumb guard also fails any page that {% include %}s a tab strip.
- Report time (#5378): reports.schedule_tz keeps the zone of whoever saved
  the schedule; check_and_send compares in it (report_due), and the form shows
  the day and hour on the reader's clock (schedule_in) under their zone's
  name. "Last sent" uses |when.
- Wording (#5379): the report contents list what the report holds (monitors,
  not ping-enabled hosts); "Ping latency" is "Response time" and says what it
  grades; plugin detail says enabling loads now and disabling needs a
  restart; the monitor interval says it applies on the next check (the
  scheduler reads it every pass); the dead list-config branch is gone.
- Traefik (#5380): the 5xx and 4xx cutoffs are settings
  (traefik.threshold.error_5xx_pct 0.1, error_4xx_pct 1.0) in a "Traefik
  routers" group on Thresholds while the plugin runs, read by router_state
  through error_cutoffs(). The Traefik page has a Thresholds button for
  admins, to /settings/thresholds/#traefik.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 13:28:43 -04:00

32 lines
1.4 KiB
Python

"""The weekly report's hour is kept in the zone of whoever saved it, and a
reader sees it on their own clock (#5378)."""
from datetime import datetime, timezone
from zoneinfo import ZoneInfo
from steward.core.reports import report_due, schedule_in
NY = ZoneInfo("America/New_York")
BERLIN = ZoneInfo("Europe/Berlin")
def test_sunday_eight_in_new_york_is_due_at_noon_utc_in_october():
sunday_noon_utc = datetime(2026, 10, 11, 12, 30, tzinfo=timezone.utc) # 08:30 EDT
assert report_due(sunday_noon_utc, 6, 8, NY)
assert not report_due(sunday_noon_utc, 6, 8, timezone.utc)
assert not report_due(datetime(2026, 10, 11, 8, 30, tzinfo=timezone.utc), 6, 8, NY)
def test_a_reader_sees_the_saved_hour_on_their_own_clock():
now = datetime(2026, 10, 8, 15, 0, tzinfo=timezone.utc)
assert schedule_in(6, 8, NY, NY, now) == (6, 8)
assert schedule_in(6, 8, NY, BERLIN, now) == (6, 14)
assert schedule_in(6, 8, timezone.utc, NY, now) == (6, 4) # an old UTC schedule, read in New York
assert schedule_in(0, 1, timezone.utc, NY, now) == (6, 21) # Monday 01:00 UTC is Sunday evening there
def test_what_a_reader_picks_and_saves_is_what_they_see_again():
now = datetime(2026, 10, 8, 15, 0, tzinfo=timezone.utc)
for day in range(7):
for hour in (0, 8, 23):
assert schedule_in(day, hour, BERLIN, BERLIN, now) == (day, hour)