bvandeusen/FabledSteward
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

test(sessions): fake users carry sessions_since; a reset ends older sessions (#5427)

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bvandeusen
2026-10-08 17:28:19 -04:00
co-authored by Claude Opus 5.5
parent 2995cfdd68
commit 46a301652b
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_sessions.py
+22 -3
View File
@@ -101,10 +101,13 @@ class _DB:
@pytest.mark.parametrize("user,login_age_s,keeps,role", [
# demoted, and a time zone set on the Account page since (milestone 490)
(SimpleNamespace(is_active=True, role=UserRole.viewer, time_zone="Europe/London"), 60, True, "viewer"),
(SimpleNamespace(is_active=False, role=UserRole.admin, time_zone=None), 60, False, None), # deactivated
(SimpleNamespace(is_active=True, role=UserRole.viewer, time_zone="Europe/London", sessions_since=None),
60, True, "viewer"),
(SimpleNamespace(is_active=False, role=UserRole.admin, time_zone=None, sessions_since=None),
60, False, None), # deactivated
(None, 60, False, None), # deleted
(SimpleNamespace(is_active=True, role=UserRole.admin, time_zone=None), 9 * 3600, False, None), # expired
(SimpleNamespace(is_active=True, role=UserRole.admin, time_zone=None, sessions_since=None),
9 * 3600, False, None), # expired
])
async def test_session_speaks_for_the_user_as_they_are(app, user, login_age_s, keeps, role):
app.db_sessionmaker = lambda: _DB(user)
@@ -116,3 +119,19 @@ async def test_session_speaks_for_the_user_as_they_are(app, user, login_age_s, k
assert ("user_id" in session) is keeps
assert session.get("user_role") == role
assert session.get("tz") == (user.time_zone if keeps else None)
@pytest.mark.parametrize("reset_ago_s,keeps", [(30, False), (120, True)])
async def test_a_password_reset_ends_the_sessions_begun_before_it(app, reset_ago_s, keeps):
"""#5427: signed in a minute ago; a reset 30 s ago ends the session, one
two minutes ago (before this sign-in) doesn't."""
from datetime import datetime, timezone
now = time.time()
user = SimpleNamespace(is_active=True, role=UserRole.viewer, time_zone=None,
sessions_since=datetime.fromtimestamp(now - reset_ago_s, timezone.utc))
app.db_sessionmaker = lambda: _DB(user)
app.config["PERMANENT_SESSION_LIFETIME"] = timedelta(hours=8)
async with app.test_request_context("/"):
session.update(user_id="u", user_role="viewer", username="a", login_at=now - 60)
await refresh_session_user()
assert ("user_id" in session) is keeps