bvandeusen
dd1b5e5ddb
CI & Build / Python lint (push) Successful in 3s
CI & Build / TypeScript typecheck (push) Successful in 12s
CI & Build / integration (push) Failing after 27s
CI & Build / Python tests (push) Successful in 50s
CI & Build / Build & push image (push) Successful in 1m42s
"What canonical helpers already live in this file?" was unanswerable: location lived only in the body markdown. It is now a jsonpath containment query over the `notes.data` mirror added by migration 0070. - One predicate in two dialects in services/knowledge.py: SQL (`data @?`, applied in the browse arm and the keyword arm before count/pagination, so totals stay honest) and Python (`location_matches`, for the semantic arm which post-filters candidates it already holds). Both must change together. - Parts are ANDed within a SINGLE locations entry — repo A in one entry and path B in another is not "recorded at A/B". `path` also matches as a directory prefix, via jsonpath `starts with` rather than `@>`, which the same GIN index serves. - `repo`/`path`/`symbol` reach the service, the REST list and the MCP tool under one name with one default (rule #33); the MCP docstring teaches the place form, and so does the reusing-code skill (plugin.json bumped). - UI: a Location disclosure beside the snippet search, with its own empty state — "nothing kept there, so what you're about to write is new." Settles #2083's open question (pre-0070 NULL `data`) by backfilling after all: `backfill_snippet_data` runs at startup, deriving the mirror from the body with the same parser the read path trusts. 0070's caution was about mangling a hand-edited body; this never touches the body. The alternative was a permanent second body-regex arm, or a query that silently answers "nothing here" for an old snippet and gets the helper written twice. Refs #2083, milestone #232.
98 lines
4.3 KiB
Python
98 lines
4.3 KiB
Python
"""Structural tests for the snippets blueprint — registration + handler/service
|
|
contracts. Full HTTP integration needs a live DB + auth the unit env lacks."""
|
|
import inspect
|
|
|
|
|
|
def test_snippets_blueprint_registered():
|
|
from scribe.routes.snippets import snippets_bp
|
|
assert snippets_bp.name == "snippets"
|
|
assert snippets_bp.url_prefix == "/api/snippets"
|
|
|
|
|
|
def test_snippets_blueprint_registered_in_app():
|
|
from scribe.app import create_app
|
|
app = create_app()
|
|
assert "snippets" in app.blueprints
|
|
|
|
|
|
def test_snippet_handlers_callable():
|
|
from scribe.routes import snippets as routes
|
|
for name in (
|
|
"list_snippets_route", "create_snippet_route", "get_snippet_route",
|
|
"update_snippet_route", "delete_snippet_route", "merge_snippet_route",
|
|
):
|
|
assert callable(getattr(routes, name))
|
|
|
|
|
|
def test_service_functions_take_user_id():
|
|
"""Routes must call snippet services with user_id — verify the contract."""
|
|
from scribe.services import snippets as svc
|
|
for fn_name in (
|
|
"create_snippet", "list_snippets", "get_snippet", "update_snippet",
|
|
"delete_snippet", "merge_snippets",
|
|
):
|
|
fn = getattr(svc, fn_name)
|
|
assert callable(fn)
|
|
assert "user_id" in inspect.signature(fn).parameters
|
|
|
|
|
|
def test_agent_and_web_surfaces_stay_at_parity():
|
|
"""The MCP tools and the REST routes are two callers of one service; a
|
|
capability on one has to exist on the other (rule #33). This guard exists
|
|
because they drifted apart once: MCP had no delete or `locations`, and the
|
|
web side had no `system_ids` and no near-duplicate gate."""
|
|
from scribe.mcp.tools import snippets as tools
|
|
from scribe.routes import snippets as routes
|
|
|
|
# Every write verb the web surface offers, the agent surface offers too.
|
|
for verb in ("create", "get", "list", "update", "delete", "merge"):
|
|
assert callable(getattr(tools, f"{verb}_snippets", None) or
|
|
getattr(tools, f"{verb}_snippet", None)), f"MCP lacks {verb}"
|
|
|
|
# Multi-location records are reachable from both.
|
|
assert "locations" in inspect.signature(tools.create_snippet).parameters
|
|
assert "locations" in inspect.signature(tools.update_snippet).parameters
|
|
assert "locations" in inspect.getsource(routes.create_snippet_route)
|
|
assert "locations" in inspect.getsource(routes.update_snippet_route)
|
|
|
|
# System association and the duplicate gate reach both.
|
|
assert "system_ids" in inspect.signature(tools.create_snippet).parameters
|
|
for route in (routes.create_snippet_route, routes.update_snippet_route):
|
|
assert "system_ids" in inspect.getsource(route)
|
|
assert "find_duplicate_note" in inspect.getsource(routes.create_snippet_route)
|
|
|
|
|
|
def test_project_scoping_reaches_every_caller():
|
|
"""A snippet search has to be narrowable to one project from both surfaces."""
|
|
from scribe.mcp.tools import snippets as tools
|
|
from scribe.routes import snippets as routes
|
|
from scribe.services import snippets as svc
|
|
assert "project_id" in inspect.signature(svc.list_snippets).parameters
|
|
assert "project_id" in inspect.signature(tools.list_snippets).parameters
|
|
assert "project_id" in inspect.getsource(routes.list_snippets_route)
|
|
|
|
|
|
def test_location_lookup_reaches_every_caller():
|
|
"""The reverse lookup — "what already lives here?" — has to be askable from
|
|
both surfaces, or an agent and a human get different answers about the same
|
|
file (rule #33)."""
|
|
from scribe.mcp.tools import snippets as tools
|
|
from scribe.routes import snippets as routes
|
|
from scribe.services import snippets as svc
|
|
for key in ("repo", "path", "symbol"):
|
|
assert key in inspect.signature(svc.list_snippets).parameters
|
|
assert key in inspect.signature(tools.list_snippets).parameters
|
|
assert f'request.args.get("{key}"' in inspect.getsource(routes)
|
|
|
|
|
|
def test_update_field_map_matches_service_kwargs():
|
|
"""Every field the PATCH route forwards must be a real update_snippet kwarg
|
|
(rule #33 interface-contract parity)."""
|
|
from scribe.routes import snippets as routes
|
|
from scribe.services import snippets as svc
|
|
params = inspect.signature(svc.update_snippet).parameters
|
|
for field in routes._STR_FIELDS:
|
|
assert field in params, f"update_snippet has no '{field}' kwarg"
|
|
assert "tags" in params
|
|
assert "project_id" in params
|