bvandeusenandClaude Fable 5
ff5f6438c4
CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 8s
CI & Build / TypeScript typecheck (push) Successful in 36s
CI & Build / integration (push) Successful in 1m3s
CI & Build / Python tests (push) Failing after 1m12s
CI & Build / Build & push image (push) Skipped
A project that opted out of an always-on rulebook at inception must not see
it anywhere: list_always_on_rules(project_id=) and the subscription-derived
set skip it (an exclusion is total), get_applicable_rules / rules_payload
carry `excluded_always_on` as the seventh key so the departure is visible
wherever the rules are, and the SessionStart block built for a bound project
names it ("Excluded for this project by its inception decision …"). MCP:
list_always_on_rules takes project_id; exclude_always_on_rulebook /
include_always_on_rulebook mirror suppress/unsuppress (owner-only; the
rulebook must be always_on — subscribed rulebooks are left by unsubscribing).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
60 lines
3.1 KiB
Python
60 lines
3.1 KiB
Python
"""Milestone 297 step 2 — always-on exclusions reach every rule surface.
|
|
|
|
The SQL is the integration lane's; here the contracts: rules_payload carries
|
|
the seventh key, list_always_on_rules takes project_id, the session-start
|
|
block names the excluded rulebooks, and the MCP tools mount.
|
|
"""
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
|
|
from scribe.services.rulebooks import rules_payload
|
|
|
|
|
|
def test_rules_payload_carries_excluded_always_on_as_the_seventh_key():
|
|
out = rules_payload({
|
|
"rules": [], "truncated": False, "subscribed_rulebooks": [],
|
|
"excluded_always_on": [{"id": 1, "title": "Family"}],
|
|
})
|
|
assert set(out) == {
|
|
"applicable_rules", "applicable_rules_truncated", "subscribed_rulebooks",
|
|
"project_rules", "suppressed_rules", "suppressed_topics", "excluded_always_on",
|
|
}
|
|
assert out["excluded_always_on"] == [{"id": 1, "title": "Family"}]
|
|
# An older applicable dict without the key still renders (empty list).
|
|
assert rules_payload({"rules": [], "truncated": False, "subscribed_rulebooks": []})["excluded_always_on"] == []
|
|
|
|
|
|
def test_list_always_on_rules_service_and_tool_take_a_project_id():
|
|
import inspect
|
|
|
|
from scribe.mcp.tools import rulebooks as tools
|
|
from scribe.services import rulebooks as svc
|
|
assert "project_id" in inspect.signature(svc.list_always_on_rules).parameters
|
|
assert "project_id" in inspect.signature(tools.list_always_on_rules).parameters
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_session_context_names_the_excluded_always_on_rulebooks():
|
|
from types import SimpleNamespace as NS
|
|
|
|
from scribe.services.plugin_context import build_session_context
|
|
rules = [NS(id=1, title="`dev` is home", topic_id=1, statement="x")]
|
|
project = NS(id=9, title="Widget", goal="", design_system_id=None)
|
|
with patch("scribe.services.plugin_context.rulebooks_svc.list_always_on_rules",
|
|
AsyncMock(return_value=rules)) as lao, \
|
|
patch("scribe.services.plugin_context.rulebooks_svc.excluded_always_on_rulebooks",
|
|
AsyncMock(return_value=[{"id": 5, "title": "Design standards"}])), \
|
|
patch("scribe.services.plugin_context._topic_titles", AsyncMock(return_value={1: "git"})), \
|
|
patch("scribe.services.plugin_context.projects_svc.get_project", AsyncMock(return_value=project)), \
|
|
patch("scribe.services.plugin_context.notes_svc.list_notes", AsyncMock(return_value=([], 0))), \
|
|
patch("scribe.services.plugin_context.rulebooks_svc.get_applicable_rules",
|
|
AsyncMock(return_value={"rules": [], "truncated": False, "subscribed_rulebooks": [],
|
|
"project_rules": [], "suppressed_rules": [],
|
|
"suppressed_topics": [], "excluded_always_on": []})):
|
|
out = await build_session_context(user_id=7, project_id=9)
|
|
# The always-on set was asked FOR THIS PROJECT, and the departure is named.
|
|
assert lao.await_args.kwargs.get("project_id") == 9
|
|
assert "Excluded for this project by its inception decision" in out["context"]
|
|
assert "Design standards (#5)" in out["context"]
|