bvandeusen
b49efdcb11
CI & Build / Python lint (push) Successful in 3s
CI & Build / TypeScript typecheck (push) Successful in 11s
CI & Build / integration (push) Successful in 30s
CI & Build / Python tests (push) Failing after 31s
CI & Build / Build & push image (push) Has been skipped
Narrow Scribe to a Claude-Code work system-of-record (milestone #194, decision note #1759). Wholesale removal per rule #22 — backend + schema half. Calendar/events + CalDAV: delete models/event, services/{events,caldav, caldav_sync}, routes/events, mcp/tools/events; strip event branches from backup (bump v3->v4), dashboard (upcoming_events), trash, recent, and the mcp server read-only allowlist + instructions. Typed entities (person/place/list): delete mcp/tools/entities; drop the notes.metadata (entity_meta) column from model/service/routes and the knowledge browse service. note_type STAYS — it also marks 'process' notes. Scheduler: event_scheduler -> recurrence_scheduler, keeping only the recurring-task spawn job (drops event reminders + CalDAV sync). Schema: migration 0069 drops the events table + notes.metadata column + orphan caldav settings rows (faithful downgrade recreates them). KEEP: recurrence.py (task recurrence), notifications task reminders, graph view, and every work surface. Frontend + plugin/docs true-up follow next. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BPtbSzA4JLMAKgFZ8VTg7Q
67 lines
2.4 KiB
Python
67 lines
2.4 KiB
Python
"""build_dashboard composition + helpers (services/dashboard.py).
|
|
|
|
Query semantics (ranking/caps/owner-scope) are exercised by manual smoke —
|
|
the repo's unit tests mock the DB, so SQL isn't executed here. These cover the
|
|
pure helpers and the section-isolation contract.
|
|
"""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
def test_task_row_maps_fields():
|
|
from scribe.services.dashboard import _task_row
|
|
n = MagicMock()
|
|
n.id = 5
|
|
n.title = "Wire reminders"
|
|
n.status = "in_progress"
|
|
n.priority = None
|
|
assert _task_row(n) == {
|
|
"id": 5, "title": "Wire reminders", "status": "in_progress", "priority": "none",
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_safe_returns_value_then_empty_on_error():
|
|
from scribe.services.dashboard import _safe
|
|
|
|
async def ok():
|
|
return [1, 2, 3]
|
|
|
|
async def boom():
|
|
raise RuntimeError("section blew up")
|
|
|
|
assert await _safe(ok(), []) == [1, 2, 3]
|
|
# a failing section returns the supplied empty default, not an exception
|
|
assert await _safe(boom(), []) == []
|
|
assert await _safe(boom(), {}) == {}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_dashboard_composes_sections():
|
|
import scribe.services.dashboard as dash
|
|
with patch.object(dash, "_active_projects", AsyncMock(return_value=["P"])), \
|
|
patch.object(dash, "_recently_completed", AsyncMock(return_value=["done"])), \
|
|
patch.object(dash, "_open_issues", AsyncMock(return_value=["iss"])), \
|
|
patch.object(dash, "_week_stats", AsyncMock(return_value={"open_total": 4})):
|
|
out = await dash.build_dashboard(user_id=1)
|
|
assert out == {
|
|
"active_projects": ["P"],
|
|
"recently_completed": ["done"],
|
|
"open_issues": ["iss"],
|
|
"week_stats": {"open_total": 4},
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_dashboard_isolates_failing_section():
|
|
import scribe.services.dashboard as dash
|
|
with patch.object(dash, "_active_projects", AsyncMock(side_effect=RuntimeError("db down"))), \
|
|
patch.object(dash, "_recently_completed", AsyncMock(return_value=["done"])), \
|
|
patch.object(dash, "_open_issues", AsyncMock(return_value=[])), \
|
|
patch.object(dash, "_week_stats", AsyncMock(return_value={})):
|
|
out = await dash.build_dashboard(user_id=1)
|
|
# failing section degrades to its empty default; others still populate
|
|
assert out["active_projects"] == []
|
|
assert out["recently_completed"] == ["done"]
|