bvandeusenandClaude Opus 5
0bcd4b5540
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / integration (push) Successful in 49s
CI & Build / TypeScript typecheck (push) Successful in 57s
CI & Build / Python tests (push) Failing after 1m3s
CI & Build / Build & push image (push) Skipped
A rule's home is its scope now: a rule in a rulebook topic is global, a rule on a project applies to that project, and retrieval reads that directly (#4074). A subscription had stopped changing anything a session received; a suppression muted rules from a subscription. Operator, 2026-09-15: "we have global and project scoped rules, we don't need the subscriptions now." What goes, whole (rule 22): - Migration 0101 drops project_rulebook_subscriptions, project_rule_suppressions and project_topic_suppressions, and strips subscribe_rulebooks (and 394's leftover exclude_always_on_rulebooks) from stored inception choices. - Service, MCP and REST: subscribe/unsubscribe and the four suppress/unsuppress operations. The Subscribers checklist, the subscribe chips, the skip buttons and the Suppressed section in the rules UI. - Inception asks two questions (design system, seed Systems). create_project and decide_project_inception lose subscribe_rulebooks. - Backup v15 stops exporting the three sections; older archives still restore, the keys simply unread. Trash no longer hard-deletes suppression rows. What changes meaning: - get_applicable_rules is a project's LISTING: its own rules, plus the global rules tagged to an area it works in. Untagged global rules apply everywhere and arrive by retrieval, so they are not listed. A co_surfaces partner on a different project is not dragged in. - list_rules(project_id) lists that project's own rules. - rules_payload drops subscribed_rulebooks and suppressed_*; the handshake's brief form is project_rules alone. - using-scribe's "Where a new rule goes" and inception sections, tool docstrings and docs say global vs project. Plugin 2026.09.15.1620. Milestone 414 step 2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01821k5B3Ysecp9fNYs92Kuy
52 lines
2.3 KiB
Python
52 lines
2.3 KiB
Python
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from tests.helpers import fake_task
|
|
|
|
|
|
pytestmark = pytest.mark.usefixtures("_bind_user")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_start_planning_tool_delegates_to_service():
|
|
payload = {"milestone": {"id": 5}, "applicable_rules": [], "project_rules": [],
|
|
"applicable_rules_truncated": False, "project_goal": "", "open_task_count": 0}
|
|
with patch("scribe.mcp.tools.tasks.planning_svc.start_planning",
|
|
AsyncMock(return_value=payload)) as mock:
|
|
from scribe.mcp.tools.tasks import start_planning
|
|
out = await start_planning(project_id=3, title="Plan it")
|
|
assert out["milestone"]["id"] == 5
|
|
# No body and no steps reach the service as None, so it seeds the template
|
|
# and takes the single-milestone path.
|
|
assert mock.call_args.kwargs == {
|
|
"user_id": 7, "project_id": 3, "title": "Plan it", "body": None, "steps": None,
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_task_augments_plan_with_rules():
|
|
applicable = {"rules": [{"id": 1, "title": "r"}], "truncated": False,
|
|
"project_rules": [{"id": 3, "title": "own"}]}
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.get_note_for_user",
|
|
AsyncMock(return_value=(fake_task(task_kind="plan", id=9, project_id=3), "owner"))), \
|
|
patch("scribe.mcp.tools.tasks.rulebooks_svc.get_applicable_rules",
|
|
AsyncMock(return_value=applicable)):
|
|
from scribe.mcp.tools.tasks import get_task
|
|
out = await get_task(task_id=9)
|
|
assert out["applicable_rules"] == [{"id": 1, "title": "r"}]
|
|
assert out["project_rules"] == [{"id": 3, "title": "own"}]
|
|
assert "subscribed_rulebooks" not in out
|
|
assert out["applicable_rules_truncated"] is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_task_work_kind_has_no_rules():
|
|
with patch("scribe.mcp.tools.tasks.notes_svc.get_note_for_user",
|
|
AsyncMock(return_value=(fake_task(task_kind="work", id=9, project_id=3), "owner"))), \
|
|
patch("scribe.mcp.tools.tasks.rulebooks_svc.get_applicable_rules",
|
|
AsyncMock()) as mock_rules:
|
|
from scribe.mcp.tools.tasks import get_task
|
|
out = await get_task(task_id=9)
|
|
assert "applicable_rules" not in out
|
|
assert not mock_rules.called
|