bvandeusenandClaude Fable 5
77bb3729a3
CI & Build / Python lint (push) Successful in 4s
CI & Build / Plugin hooks (push) Successful in 8s
CI & Build / integration (push) Successful in 24s
CI & Build / TypeScript typecheck (push) Successful in 33s
CI & Build / Python tests (push) Failing after 36s
CI & Build / Build & push image (push) Skipped
Second pass over the tests/ ledger after bbee0d0. fake_record(**attrs) is the
one MagicMock-with-real-attributes builder (to_dict mirrors them; the
note-2109 hazard documented once); fake_note/fake_task/fake_snippet/
fake_project/fake_milestone/fake_system/fake_rulebook/fake_topic/fake_rule
carry each model's ordinary defaults on top of it, replacing 14 per-file
factories (two rulebook trios in tool-vs-service wordings, _fake_task, _fake_ms,
_fake_project, _plan_note, _fake_snippet, two _snippet adapters now one-liners
over fake_snippet). FakeMCP replaces the five closure-over-a-list registrar
fakes (+ _Recorder); loc() and design_token_stub() replace the paired _loc /
_token / _T stand-ins; every hand-built async_session mock (9 helper defs and
14 inline copies) now starts from make_mock_session(). Call sites rewritten by
AST with each file's former defaults made explicit, so behaviour is unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
80 lines
2.8 KiB
Python
80 lines
2.8 KiB
Python
"""Tests for the prune logic — both rolling (pin_kind IS NULL) and the
|
|
auto-pin bucket (pin_kind='auto').
|
|
|
|
Design: docs/superpowers/specs/2026-05-13-note-version-pinning-design.md
|
|
"""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
|
|
async def test_create_version_prune_sql_filters_to_unpinned():
|
|
"""The DELETE statement issued by create_version's prune step must
|
|
include `pin_kind IS NULL` in the inner SELECT so pinned versions
|
|
aren't counted toward MAX_VERSIONS and can't be pruned by it."""
|
|
mock_session = make_mock_session()
|
|
select_result = MagicMock()
|
|
# No prior version → skips the throttle/dedupe early-return paths and
|
|
# proceeds straight to insert + prune.
|
|
select_result.scalars.return_value.first.return_value = None
|
|
mock_session.add = MagicMock()
|
|
mock_session.commit = AsyncMock()
|
|
mock_session.refresh = AsyncMock()
|
|
|
|
captured_sql: list[str] = []
|
|
|
|
async def execute_capture(stmt, *args, **kwargs):
|
|
captured_sql.append(str(stmt))
|
|
if len(captured_sql) == 1:
|
|
return select_result
|
|
return MagicMock()
|
|
|
|
mock_session.execute = AsyncMock(side_effect=execute_capture)
|
|
|
|
with patch(
|
|
"scribe.services.note_versions.async_session",
|
|
return_value=mock_session,
|
|
):
|
|
from scribe.services.note_versions import create_version
|
|
await create_version(
|
|
user_id=1, note_id=42, body="content", title="t", tags=["a"],
|
|
)
|
|
|
|
assert any("pin_kind IS NULL" in s for s in captured_sql), (
|
|
f"Expected prune SQL to filter pin_kind IS NULL; got: {captured_sql!r}"
|
|
)
|
|
|
|
|
|
async def test_prune_auto_pins_filters_to_auto_kind():
|
|
"""prune_auto_pins must filter to pin_kind='auto' so manual pins and
|
|
rolling rows aren't touched, and must bind MAX_AUTO_PINS as the OFFSET."""
|
|
mock_session = make_mock_session()
|
|
mock_session.commit = AsyncMock()
|
|
|
|
captured_sql: list[str] = []
|
|
captured_params: list[dict] = []
|
|
|
|
async def execute_capture(stmt, *args, **kwargs):
|
|
captured_sql.append(str(stmt))
|
|
try:
|
|
captured_params.append(dict(stmt.compile().params))
|
|
except Exception:
|
|
captured_params.append({})
|
|
return MagicMock()
|
|
|
|
mock_session.execute = AsyncMock(side_effect=execute_capture)
|
|
|
|
with patch(
|
|
"scribe.services.version_pinning.async_session",
|
|
return_value=mock_session,
|
|
):
|
|
from scribe.services.version_pinning import (
|
|
prune_auto_pins, MAX_AUTO_PINS,
|
|
)
|
|
await prune_auto_pins(user_id=1, note_id=42)
|
|
|
|
assert any("pin_kind = 'auto'" in s for s in captured_sql), (
|
|
f"expected auto-bucket filter in SQL; got: {captured_sql!r}"
|
|
)
|
|
assert any(
|
|
p.get("max_auto_pins") == MAX_AUTO_PINS for p in captured_params
|
|
), f"bound params: {captured_params!r}"
|