bvandeusenandClaude Opus 5.5
eb00554976
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 10s
CI & Build / Build & push image (push) Canceled after 0s
CI & Build / Python tests (push) Canceled after 23s
CI & Build / integration (push) Canceled after 27s
CI & Build / TypeScript typecheck (push) Canceled after 28s
The context fetch folded a timeout, an HTTP error and a refused key into one sentence that ended "enter_project() as needed" -- read as optional, so a session could start with no recent milestones or open tasks and no way to know what prior work existed. The fetch now names the cause and the elapsed time, retries once (6s) only where a retry can change the answer, and the fallback states enter_project as the first step, with the marker's project id when there is one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
55 lines
2.1 KiB
Python
55 lines
2.1 KiB
Python
"""A SessionStart that loads no project says why, and names the first move (#4366).
|
|
|
|
The fetch used to be `curl -f … || body=""`: a timeout, an HTTP error and a
|
|
refused key all produced one sentence, which ended by suggesting
|
|
`enter_project()` "as needed". A session that read it as optional started with
|
|
no recent milestones or open tasks, and so had no way to know which prior work
|
|
existed to look for. These pin the two halves of the fix on the path that needs
|
|
no server: the cause is named, and the fallback is a concrete first step.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import subprocess
|
|
from pathlib import Path
|
|
|
|
from tests.helpers import need_tools
|
|
|
|
HOOK = Path(__file__).resolve().parents[1] / "plugin" / "hooks" / "scribe_session_context.sh"
|
|
|
|
|
|
def run_hook(tmp_path: Path, url: str, marker_project: int | None = None) -> str:
|
|
need_tools("bash", "curl", "awk")
|
|
if marker_project is not None:
|
|
(tmp_path / ".scribe").write_text(json.dumps({
|
|
"instance": url, "project_id": marker_project, "project": "P",
|
|
}))
|
|
env = {**os.environ, "SCRIBE_URL": url, "SCRIBE_TOKEN": "t",
|
|
"CLAUDE_PROJECT_DIR": str(tmp_path)}
|
|
r = subprocess.run(["bash", str(HOOK)], input=b'{"source":"startup"}',
|
|
capture_output=True, env=env, timeout=60)
|
|
assert r.returncode == 0, r.stderr.decode()
|
|
return json.loads(r.stdout)["hookSpecificOutput"]["additionalContext"]
|
|
|
|
|
|
# Port 9 (discard) on loopback: refused at once, so both tries fail fast.
|
|
DEAD = "http://127.0.0.1:9"
|
|
|
|
|
|
def test_an_unreachable_instance_is_named_as_one(tmp_path):
|
|
out = run_hook(tmp_path, DEAD)
|
|
assert "could not be reached (curl exit 7, after a retry)" in out
|
|
|
|
|
|
def test_the_fallback_is_a_first_step_not_an_option(tmp_path):
|
|
out = run_hook(tmp_path, DEAD)
|
|
assert "as needed" not in out
|
|
assert "Start by finding this repo's project" in out
|
|
assert "before any other work" in out
|
|
|
|
|
|
def test_a_marker_names_the_exact_call(tmp_path):
|
|
out = run_hook(tmp_path, DEAD, marker_project=31)
|
|
assert "Start by calling `enter_project(31)`" in out
|