bvandeusenandClaude Opus 5
5b824c1626
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 8s
CI & Build / integration (push) Successful in 19s
CI & Build / TypeScript typecheck (push) Successful in 34s
CI & Build / Python tests (push) Successful in 58s
CI & Build / Build & push image (push) Successful in 43s
Retiring rulebook #2 left the /design drift panel with no data source, and because its empty state was well-written the feature read as working while it could only ever render "nothing designated" (#2419). The original question is genuinely gone: theme.css is generated from design system 2, so checking the system against a sheet derived from it would be a tautology. The question that survives is the one no server can answer. A generated sheet still has to be LOADED and APPLIED, and nothing checked that it was: absent the record declares a token the app doesn't have — the sheet was never regenerated after the record changed, or never loaded differs the app has it with another value — a stale sheet, or a later rule that overrode it unrecorded the app declares a token in the record's own family that the record has never heard of Both sides go through the same engine so the comparison is honest: declared values are set on an offscreen probe and read back, which performs the same var() substitution the browser already did to the live values. Comparing raw strings would mark every derived token as drift. The designation moved with the feature — design_rulebook_id becomes ui_design_system_id, with a migration deleting the retired key rather than leaving an inert row. The prose extractor it fed goes too (#2288 said its runtime role ended when the import landed). Three orphans of the same shape, found alongside and fixed here: - darkOverriddenNames hardcoded [data-theme="dark"]. The sheet went dark-first months ago, so it matched nothing and the "mode-aware" flag silently left the gallery. Now matches the SHAPE of a mode selector, which also holds for an install whose modes aren't light and dark. - groupFor's prefix table never heard of --fs-, so 110 tokens sat under "other". Groups now come from the record where there is one; the table can only know families that shipped with the product (rule #115). - The type scale was a hand-written table of nine sizes marked "no token", true when written and false since the scale was recorded. Now rendered from whatever size tokens the sheet declares, so it can't go stale twice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UaYUaouG9jjhATyuxCKrQs
45 lines
1.3 KiB
Python
45 lines
1.3 KiB
Python
"""retire the design_rulebook_id setting
|
|
|
|
Revision ID: 0075
|
|
Revises: 0074
|
|
Create Date: 2026-08-03
|
|
|
|
The /design panel used to compare a design RULEBOOK's prose claims against the
|
|
live tokens. That rulebook was imported into the design system and retired, and
|
|
the panel now compares the running app against the design system it was
|
|
generated from (#2419). Its designation moved with it:
|
|
|
|
design_rulebook_id -> ui_design_system_id
|
|
|
|
Nothing reads the old key any more, so this deletes the row rather than leaving
|
|
an inert one behind (rule #22 — remove the old path, including the setting it
|
|
read from). The values are not translatable: a rulebook id and a design system
|
|
id are ids in different tables, and guessing a mapping would silently point the
|
|
new panel at the wrong system.
|
|
|
|
Deleting settings rows by key is safe in a way dropping a column is not — the
|
|
table is free-form key/value, so an install that never designated one simply has
|
|
no row to delete.
|
|
|
|
Downgrade cannot restore what it never recorded, so it is a no-op rather than a
|
|
lie: the operator re-designates in Settings.
|
|
"""
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
|
|
|
|
revision = "0075"
|
|
down_revision = "0074"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.execute(
|
|
sa.text("DELETE FROM settings WHERE key = 'design_rulebook_id'")
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
pass
|