bvandeusenandClaude Opus 5
0bcd4b5540
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 13s
CI & Build / integration (push) Successful in 49s
CI & Build / TypeScript typecheck (push) Successful in 57s
CI & Build / Python tests (push) Failing after 1m3s
CI & Build / Build & push image (push) Skipped
A rule's home is its scope now: a rule in a rulebook topic is global, a rule on a project applies to that project, and retrieval reads that directly (#4074). A subscription had stopped changing anything a session received; a suppression muted rules from a subscription. Operator, 2026-09-15: "we have global and project scoped rules, we don't need the subscriptions now." What goes, whole (rule 22): - Migration 0101 drops project_rulebook_subscriptions, project_rule_suppressions and project_topic_suppressions, and strips subscribe_rulebooks (and 394's leftover exclude_always_on_rulebooks) from stored inception choices. - Service, MCP and REST: subscribe/unsubscribe and the four suppress/unsuppress operations. The Subscribers checklist, the subscribe chips, the skip buttons and the Suppressed section in the rules UI. - Inception asks two questions (design system, seed Systems). create_project and decide_project_inception lose subscribe_rulebooks. - Backup v15 stops exporting the three sections; older archives still restore, the keys simply unread. Trash no longer hard-deletes suppression rows. What changes meaning: - get_applicable_rules is a project's LISTING: its own rules, plus the global rules tagged to an area it works in. Untagged global rules apply everywhere and arrive by retrieval, so they are not listed. A co_surfaces partner on a different project is not dragged in. - list_rules(project_id) lists that project's own rules. - rules_payload drops subscribed_rulebooks and suppressed_*; the handshake's brief form is project_rules alone. - using-scribe's "Where a new rule goes" and inception sections, tool docstrings and docs say global vs project. Plugin 2026.09.15.1620. Milestone 414 step 2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01821k5B3Ysecp9fNYs92Kuy
49 lines
2.2 KiB
Python
49 lines
2.2 KiB
Python
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_start_planning_creates_milestone_and_returns_rules():
|
|
# start_planning now creates a MILESTONE (the plan container), not a
|
|
# kind=plan task; its body holds the seeded design template.
|
|
fake_milestone = MagicMock()
|
|
fake_milestone.to_dict.return_value = {"id": 5, "title": "Plan it", "status": "active"}
|
|
applicable = {
|
|
"rules": [{"id": 1, "title": "dev is home", "statement": "...",
|
|
"topic_title": "git-workflow", "rulebook_title": "FabledSword family"}],
|
|
"truncated": False,
|
|
"project_rules": [{"id": 3, "title": "own", "statement": "..."}],
|
|
}
|
|
with patch("scribe.services.planning.milestones_svc.create_milestone",
|
|
AsyncMock(return_value=fake_milestone)) as mock_create, \
|
|
patch("scribe.services.planning.rulebooks_svc.get_applicable_rules",
|
|
AsyncMock(return_value=applicable)), \
|
|
patch("scribe.services.planning.notes_svc.list_notes",
|
|
AsyncMock(return_value=([], 3))), \
|
|
patch("scribe.services.planning.projects_svc.get_project",
|
|
AsyncMock(return_value=MagicMock(goal="ship it"))):
|
|
from scribe.services.planning import start_planning
|
|
out = await start_planning(user_id=7, project_id=3, title="Plan it")
|
|
|
|
# Created a milestone with the seeded plan-body template.
|
|
kwargs = mock_create.call_args.kwargs
|
|
assert kwargs["project_id"] == 3
|
|
assert kwargs["status"] == "active"
|
|
assert "## Goal" in kwargs["body"] # seeded template
|
|
# Returned shape
|
|
assert out["milestone"]["id"] == 5
|
|
assert out["applicable_rules"][0]["title"] == "dev is home"
|
|
assert out["project_rules"][0]["id"] == 3
|
|
assert "subscribed_rulebooks" not in out
|
|
assert out["open_task_count"] == 3
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_start_planning_raises_when_project_not_found():
|
|
with patch("scribe.services.planning.projects_svc.get_project",
|
|
AsyncMock(return_value=None)):
|
|
from scribe.services.planning import start_planning
|
|
with pytest.raises(ValueError, match="project 999 not found"):
|
|
await start_planning(user_id=7, project_id=999, title="x")
|