feat(acl): shared records are search-only and always labelled as someone else's

Narrows the b7d6fc7 widening per the operator's call, and fixes a regression it
introduced. Decision recorded as note 2094.

Two scopes now, deliberately different:

  readable_notes_clause  — everything the ACL permits, including records reached
                           only via a direct/group note share. For EXPLICIT acts:
                           a search the caller typed, a fetch by id.
  browsable_notes_clause — the caller's own records plus anything in a project
                           they can reach. For PASSIVE surfaces: browse lists,
                           facet counts, the process->skill manifest.

The split is a trust boundary. Anything appearing unasked — in your own list,
your own counts, or as a skill installed on your machine — reads as material you
endorsed. A one-off someone shared with you hasn't earned that standing, so it
waits until you go looking. This also dissolves the shared-Process problem by
construction rather than by special case: the manifest is a passive surface, so a
directly-shared Process is never installed as an auto-surfacing skill.

Regression fix (#2093): b7d6fc7 widened the list queries but left the fetch path
owner-only, so on the MCP path a record could be listed and then not opened —
get_snippet raised not-found, get_process couldn't resolve, and the manifest
emitted stubs whose get_process call would fail. snippets.get_snippet and
notes.resolve_process now resolve the read scope. delete_snippet gained an
explicit can_write_note guard, since being able to SEE a shared snippet must not
imply being able to bin it.

Provenance, so nothing arrives looking like the operator's own work:
- access.describe_provenance / label_shared_items add shared/owner/permission;
  labelling costs no query when everything is the caller's own.
- MCP: get_snippet, list_snippets, get_process and list_processes carry it, and
  get_process now says outright NOT to follow a shared process verbatim — its
  follow-as-written contract was the sharpest instance of the problem.
- The skill stub for a shared Process names its author and asks for a go-ahead,
  instead of describing it as "the operator's saved Scribe process".
- Policy stated once in the MCP _INSTRUCTIONS and the reusing-code skill: a
  shared record is that person's suggestion, weigh it, attribute it, ask before
  adopting it.
- UI: shared snippets show "by <owner>" in the list and a notice above the code
  in the detail view, reusing SharedWithMeView's vocabulary.

Plugin 0.1.15 -> 0.1.16 (skill text changed).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RLwAaV4DQEmVyn496HnEvt

tests/test_services_access_visibility.py

@@ -33,6 +33,14 @@ async def _compiled_clause(group_ids: list[int]) -> str:
     return str(clause.compile(compile_kwargs={"literal_binds": True}))
 
 
+async def _compiled_browse_clause(group_ids: list[int]) -> str:
+    from scribe.services.access import browsable_notes_clause
+    with patch("scribe.services.access.async_session") as cls:
+        cls.return_value = _session_returning_groups(group_ids)
+        clause = await browsable_notes_clause(user_id=7)
+    return str(clause.compile(compile_kwargs={"literal_binds": True}))
+
+
 @pytest.mark.asyncio
 async def test_clause_covers_ownership_and_both_share_paths():
     sql = await _compiled_clause(group_ids=[])
@@ -69,3 +77,34 @@ async def test_owner_only_result_is_never_the_whole_table():
     sql = await _compiled_clause(group_ids=[])
     assert "true" not in sql.lower()
     assert "1 = 1" not in sql
+
+
+# --- browse scope: the trust boundary ---------------------------------------
+
+@pytest.mark.asyncio
+async def test_browse_scope_excludes_direct_note_shares():
+    """The whole point of the narrower scope (decision note 2094): a record
+    shared directly with you must NOT appear in a passive list. If `note_shares`
+    leaks in here, someone else's one-off lands in the operator's own browse
+    list, facet counts, and skill manifest as though they had recorded it."""
+    sql = await _compiled_browse_clause(group_ids=[3])
+    assert "note_shares" not in sql
+
+
+@pytest.mark.asyncio
+async def test_browse_scope_keeps_ownership_and_project_access():
+    sql = await _compiled_browse_clause(group_ids=[])
+    assert "notes.user_id = 7" in sql        # your own
+    assert "project_shares" in sql           # a project shared with you
+    assert "projects" in sql                 # a project you own
+
+
+@pytest.mark.asyncio
+async def test_browse_scope_is_strictly_narrower_than_read_scope():
+    """Browse must never surface something read scope wouldn't also allow —
+    otherwise a list could show a record the caller can't open."""
+    browse = await _compiled_browse_clause(group_ids=[3])
+    read = await _compiled_clause(group_ids=[3])
+    assert "note_shares" in read and "note_shares" not in browse
+    for shared_arm in ("notes.user_id = 7", "project_shares"):
+        assert shared_arm in browse and shared_arm in read

tests/test_shared_provenance.py

@@ -0,0 +1,107 @@
+"""Shared records must announce themselves.
+
+A record another user owns is that person's suggestion, not the operator's
+settled practice — and the two are indistinguishable unless every surface that
+hands one over says whose it is. These tests hold that line at the labelling
+helpers and at the process→skill manifest, which is the most consequential
+passive surface Scribe has (each entry becomes an auto-surfacing skill file).
+"""
+from unittest.mock import AsyncMock, MagicMock, patch
+
+import pytest
+
+
+def _session_returning_rows(rows):
+    result = MagicMock()
+    result.all.return_value = rows
+    session = AsyncMock()
+    session.__aenter__ = AsyncMock(return_value=session)
+    session.__aexit__ = AsyncMock(return_value=False)
+    session.execute = AsyncMock(return_value=result)
+    return session
+
+
+@pytest.mark.asyncio
+async def test_label_marks_only_foreign_rows():
+    from scribe.services.access import label_shared_items
+    items = [
+        {"id": 1, "user_id": 7},   # mine
+        {"id": 2, "user_id": 9},   # someone else's
+    ]
+    with patch("scribe.services.access.async_session") as cls:
+        cls.return_value = _session_returning_rows([(9, "alex")])
+        out = await label_shared_items(user_id=7, items=items)
+
+    mine, theirs = out
+    # An unmarked row must be unambiguously the caller's own.
+    assert "shared" not in mine and "owner" not in mine
+    assert theirs["shared"] is True
+    assert theirs["owner"] == "alex"
+
+
+@pytest.mark.asyncio
+async def test_label_skips_the_query_when_everything_is_mine():
+    """No foreign rows means no user lookup at all — labelling shouldn't cost a
+    query on the common single-owner path."""
+    from scribe.services.access import label_shared_items
+    with patch("scribe.services.access.async_session") as cls:
+        out = await label_shared_items(user_id=7, items=[{"id": 1, "user_id": 7}])
+        cls.assert_not_called()
+    assert out == [{"id": 1, "user_id": 7}]
+
+
+@pytest.mark.asyncio
+async def test_provenance_is_empty_for_your_own_record():
+    from scribe.services.access import describe_provenance
+    note = MagicMock(id=1, user_id=7)
+    assert await describe_provenance(user_id=7, note=note) == {}
+
+
+@pytest.mark.asyncio
+async def test_provenance_names_the_owner_and_permission():
+    from scribe.services.access import describe_provenance
+    note = MagicMock(id=1, user_id=9)
+    owner = MagicMock(username="alex")
+    session = AsyncMock()
+    session.__aenter__ = AsyncMock(return_value=session)
+    session.__aexit__ = AsyncMock(return_value=False)
+    session.get = AsyncMock(return_value=owner)
+    with patch("scribe.services.access.async_session") as cls, \
+         patch("scribe.services.access.get_note_permission",
+               AsyncMock(return_value="viewer")):
+        cls.return_value = session
+        got = await describe_provenance(user_id=7, note=note)
+    assert got == {"shared": True, "owner": "alex", "permission": "viewer"}
+
+
+@pytest.mark.asyncio
+async def test_shared_process_skill_stub_never_claims_to_be_the_operators():
+    """The stub description IS the skill's auto-surface trigger and the only
+    provenance a reader sees. For a shared Process it must name the author and
+    require a go-ahead — never read as "the operator's saved process"."""
+    from scribe.services import plugin_context
+
+    items = [
+        {"id": 1, "title": "Drift Audit", "snippet": "Sweep for drift.", "user_id": 7},
+        {"id": 2, "title": "Deploy Dance", "snippet": "Ship it.", "user_id": 9},
+    ]
+    with patch.object(plugin_context.knowledge_svc, "query_knowledge",
+                      AsyncMock(return_value=(items, 2))), \
+         patch.object(plugin_context, "label_shared_items",
+                      AsyncMock(side_effect=lambda uid, its: [
+                          it if it["user_id"] == uid
+                          else {**it, "shared": True, "owner": "alex"}
+                          for it in its
+                      ])):
+        out = await plugin_context.build_process_manifest(user_id=7)
+
+    own, shared = out["processes"]
+
+    assert "operator's saved Scribe process" in own["description"]
+    assert "shared" not in own
+
+    assert shared["shared"] is True
+    assert shared["owner"] == "alex"
+    assert "operator's saved Scribe process" not in shared["description"]
+    assert "alex" in shared["description"]
+    assert "go-ahead" in shared["description"]