bvandeusenandClaude Opus 5.5
4c150cbc2f
Twenty-eight test files described the code they guard by what it did before a fix. Each is now the property and the failure it prevents, in the present tense: the backfill snapshot, the per-dial calibration query, the rule scope, the lesson trigger filter, the subshell global, the trash owner scope, the version readout fallback, and others. A docstring line that narrated the backup suite's own history is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
86 lines
3.8 KiB
Python
86 lines
3.8 KiB
Python
"""The app must SAY what it is running, and must not lie when it cannot find out.
|
|
|
|
There is no frontend test runner in this repo, so these are source-inspection
|
|
guards in the unit lane — the same idiom `check_plugin.py` uses on the hook
|
|
shells. They are deliberately few and deliberately about ONE property each,
|
|
because a grep-shaped test that asserts a whole file's contents fails on every
|
|
refactor and gets deleted.
|
|
|
|
WHY THIS FILE EXISTS. With a deploy misbehaving, the instance has to be able to
|
|
say which commit is serving it. `/api/version` answers that; this is the other
|
|
half — the value reaching a person — and it goes wrong one way in particular:
|
|
*never let a blank stand in for `unknown`*. A readout
|
|
that renders a plausible value it never received is worse than one that renders
|
|
nothing, because it ends the investigation instead of starting it.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from pathlib import Path
|
|
|
|
FRONTEND = Path(__file__).resolve().parents[1] / "frontend" / "src"
|
|
|
|
|
|
def test_something_actually_reads_the_version_endpoint():
|
|
"""The endpoint is not enough; something must ask it.
|
|
|
|
An endpoint with no caller is reachable only by someone who already knows
|
|
to curl it, and a capability with no surface the operator can touch is
|
|
not shipped.
|
|
"""
|
|
hits = [p for p in FRONTEND.rglob("*.ts") if "/api/version" in p.read_text()]
|
|
assert hits, "nothing under frontend/src fetches /api/version"
|
|
|
|
|
|
def test_the_footer_does_not_default_to_a_plausible_version():
|
|
"""A failed fetch does not render a plausible version.
|
|
|
|
If `appVersion` starts life as the literal `"dev"` and the fetch swallows
|
|
its own failure, an instance that cannot answer renders exactly what a
|
|
healthy local build renders. Two very different states, one
|
|
string, and no way to tell them apart from the page.
|
|
|
|
Pinned as "the ref does not start at a version-shaped literal" rather than
|
|
as an exact initialiser, so a later refactor can change how the state is
|
|
held without failing here — what must not come back is the plausible
|
|
default.
|
|
"""
|
|
app = (FRONTEND / "App.vue").read_text()
|
|
match = re.search(r"const appVersion = ref[^;]*;", app)
|
|
assert match, "App.vue no longer declares appVersion — update this guard"
|
|
decl = match.group(0)
|
|
assert '"dev"' not in decl and "'dev'" not in decl, (
|
|
f"appVersion defaults to a version-shaped literal: {decl}\n"
|
|
"A failed fetch would render as a real-looking version. "
|
|
"Start from a not-answered-yet value instead."
|
|
)
|
|
|
|
|
|
def test_optional_version_fields_are_read_by_absence_not_falsiness():
|
|
"""`build` is a number and 0 is a legitimate ordering key.
|
|
|
|
The payload omits what it does not know rather than sending `""` or `0`, so
|
|
the renderer's job is to distinguish ABSENT from present. `||` cannot: it
|
|
would report a real `build` of 0 as unknown, and it is the form a person
|
|
reaches for by habit. `??` is the correct one, which is why this pins the
|
|
operator rather than the rendered output.
|
|
"""
|
|
view = (FRONTEND / "views" / "SettingsView.vue").read_text()
|
|
for field in ("channel", "build"):
|
|
assert f'versionInfo.{field} ?? "unknown"' in view, (
|
|
f"the {field} readout must use `?? \"unknown\"`, never `|| \"unknown\"` — "
|
|
"an absent field and a falsy one are different answers"
|
|
)
|
|
|
|
|
|
def test_the_version_request_carries_a_deadline():
|
|
"""A wait with no deadline cannot report that it failed.
|
|
|
|
This readout is consulted when an instance is misbehaving, which is exactly
|
|
when it may never answer. Without a deadline the surface sits on "still
|
|
loading" forever — the blank standing in for `unknown` again, arrived at
|
|
from the other direction.
|
|
"""
|
|
src = (FRONTEND / "api" / "version.ts").read_text()
|
|
assert "timeoutMs" in src, "the version fetch must pass a deadline"
|