bvandeusenandClaude Opus 5.5
0f5ef0be63
CI & Build / Python lint (push) Successful in 3s
CI & Build / Plugin hooks (push) Successful in 12s
CI & Build / TypeScript typecheck (push) Successful in 56s
CI & Build / integration (push) Successful in 1m4s
CI & Build / Python tests (push) Successful in 1m55s
CI & Build / Build & push image (push) Successful in 44s
Step 2 of the Scribe -> Grimoire rename. - src/scribe -> src/grimoire, and every import, patch target, module path, hypercorn entry point and `python -m grimoire.restore` with it; pyproject, uv.lock and the frontend package are named grimoire. - Image git.fabledsword.com/bvandeusen/fabledgrimoire; CI's Postgres service runs as grimoire / grimoire_test. - Compose files default the DB user, database and (prod) volume to grimoire, each overridable from .env, so an install created as Scribe keeps its data by setting POSTGRES_USER, POSTGRES_DB and PGDATA_VOLUME. - Backups are written as grimoire-<ts>.tar with format grimoire-backup-tar. Archives named scribe-* with the scribe-backup-tar manifest still restore and are still counted at the destination (folder and S3), with tests. - Exports, the MCP auth realm, the ASGI scope key and the persistent logger carry the new name. Kept on purpose: the secret-sealing key label stays "scribe.secrets.v1", because every stored secret was derived under it. Plugin identity (plugin name, hooks, env vars, .scribe marker, skills) is step 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
69 lines
2.8 KiB
Python
69 lines
2.8 KiB
Python
"""update_task closes a task with a one-line reminder of what the report needs.
|
|
|
|
This is the in-band half of reporting back: the skill and static context only
|
|
exist in the Claude Code plugin, and a tool response reaches every MCP client
|
|
at the moment a piece of work closes. Pinned on the response, not the wording.
|
|
|
|
The operator's own completion-report preferences do not ride here: they are
|
|
mounted on finishing work and arrive in `moment_rules` beside the delivered
|
|
reply shape, so this response carries no key of its own for them.
|
|
"""
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
pytestmark = pytest.mark.usefixtures("_bind_user")
|
|
|
|
|
|
async def _update(owed=None, **kwargs):
|
|
from grimoire.mcp.tools.tasks import update_task
|
|
|
|
note = MagicMock(id=5, user_id=7, project_id=3, started_at="2026-10-06T09:00:00+00:00")
|
|
note.to_dict.return_value = {"id": 5}
|
|
with patch("grimoire.mcp.tools.tasks.notes_svc.update_note", AsyncMock(return_value=note)), \
|
|
patch("grimoire.mcp.tools.tasks.systems_tools.attach_systems", AsyncMock()), \
|
|
patch("grimoire.mcp.tools.tasks.placement_svc.attach_placement", AsyncMock()), \
|
|
patch("grimoire.mcp.tools.tasks.family_adoption_svc.owed_since",
|
|
AsyncMock(return_value=list(owed or []))):
|
|
return await update_task(task_id=5, **kwargs)
|
|
|
|
|
|
@pytest.mark.parametrize("status", ["done", "cancelled"])
|
|
async def test_closing_a_task_carries_the_cue(status):
|
|
out = await _update(status=status)
|
|
assert "placement" in out["report_back"] and "needs them" in out["report_back"]
|
|
|
|
|
|
@pytest.mark.parametrize("kwargs", [{"status": "in_progress"}, {"status": "todo"}, {"body": "more notes"}])
|
|
async def test_other_updates_do_not(kwargs):
|
|
out = await _update(**kwargs)
|
|
assert "report_back" not in out
|
|
|
|
|
|
async def test_closing_carries_the_plain_cue_and_no_preference_key_of_its_own():
|
|
"""The retired key does not come back beside the moment delivery."""
|
|
from grimoire.mcp.tools.tasks import REPORT_BACK_CUE
|
|
|
|
out = await _update(status="done")
|
|
assert "reply_preferences" not in out
|
|
assert out["report_back"] == REPORT_BACK_CUE
|
|
|
|
|
|
_OWED = {"idea_id": 9, "idea_title": "Signed APK lane", "project_id": 4,
|
|
"project_title": "android two", "owed_task_id": 77}
|
|
|
|
|
|
async def test_closing_names_the_owed_adoptions_filed_while_the_task_was_open():
|
|
"""The finishing moment of family canon: owed family work filed
|
|
into a project during this task comes back for the report to name."""
|
|
from grimoire.services.family_adoption import OWED_CUE
|
|
|
|
out = await _update(owed=[_OWED], status="done")
|
|
assert out["family_owed"] == [_OWED]
|
|
assert out["report_back"].endswith(OWED_CUE) and "family_owed" in out["report_back"]
|
|
|
|
|
|
async def test_no_owed_adoptions_means_no_key():
|
|
out = await _update(owed=[], status="done")
|
|
assert "family_owed" not in out
|