dev → main: a name defined in two packages counts only in the canon's own (#6495) #219

Merged
bvandeusen merged 1 commits from dev into main 2026-10-26 22:26:20 -04:00
Owner

Brings b87178d to main. This fixes #6495 "A by-name "reference" edge cannot tell two definitions of the same name apart".

  • names_canon now takes defined_at, a map from each name to the repo paths that define it. When the repo also defines a canon's name somewhere the canon is not recorded, a mention counts only from the canon's own package.
  • Proposer version 8 → 9, so the next coverage refresh re-reads every row and replaces its reference edges.

CI on dev passed (run 9913).

🤖 Generated with Claude Code

Brings b87178d to main. This fixes #6495 "A by-name "reference" edge cannot tell two definitions of the same name apart". - `names_canon` now takes `defined_at`, a map from each name to the repo paths that define it. When the repo also defines a canon's name somewhere the canon is not recorded, a mention counts only from the canon's own package. - Proposer version 8 → 9, so the next coverage refresh re-reads every row and replaces its reference edges. CI on dev passed (run 9913). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
bvandeusen added 1 commit 2026-10-26 22:26:17 -04:00
fix(6495): a name defined in two packages counts only in the canon's own
CI & Build / Python lint (push) Successful in 2s
CI & Build / Plugin hooks (push) Successful in 14s
CI & Build / integration (push) Successful in 1m22s
CI & Build / TypeScript typecheck (push) Successful in 37s
CI & Build / Python tests (push) Successful in 1m59s
CI & Build / Build & push image (push) Successful in 43s
b87178d261
A by-name reference edge could not tell two definitions of one name apart:
in a Go repo that defines `file` as importRun.file (internal/files, the
canon) and as sftpRun.file (internal/replication), a mirror test calling
`m.file(` was recorded as a use of the canon.

names_canon now takes defined_at, every repo path that defines each name,
in place of the shape file's own names. The own-file rule is unchanged.
When the repo also defines the canon's name somewhere the canon is not
recorded, a mention counts only from the canon's own package: the
directory of a file location exactly, or under a directory location.
A name defined once resolves as before. Proposer version 8 -> 9, so the
next coverage refresh re-reads every row and replaces its reference edges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bvandeusen merged commit 0216634bd4 into main 2026-10-26 22:26:20 -04:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bvandeusen/FabledGrimoire#219