bvandeusenandClaude Opus 5
e3fd8c67d4
Milestone 406 retires pixiv (rule 171) in two phases at the operator's explicit ask: switch it off, then later delete its code. This is the switch-off. Steps 2 and 3 ship together because each is a half-state of the other: unregistered but still in the extension, pixiv creator pages would offer a button the backend then refuses. Reachability removed, never gated (rule 22 - no flag, no `if platform == "pixiv"`): - platforms registry: pixiv unregistered, so /api/platforms, the source validator and quick-add all refuse it through their existing unknown-platform paths. - NATIVE_INGESTER_PLATFORMS: pixiv removed. - extension_service: pixiv's quick-add URL pattern removed (the Python half of the JS mirror). - extension: pixiv's host permissions, content-script match, platform entry and artist pattern removed; popup's pixiv branches removed; and the whole pixiv PKCE OAuth flow cut out of background.js. That last one could not wait for phase 2 - a webRequest listener on a host the manifest no longer grants is at best dead and at worst a startup failure for the entire background script. On startup the extension now also removes any pixiv refresh token a browser still holds in storage, for the same reason as the server-side credential cleanup (3980). - frontend: the extension card stops listing pixiv; SourceActions' copy of the native list drops it. platformColor keeps rendering a pixiv key so existing pixiv posts do not look broken. The guard, and why a registry change alone was not enough. A source outlives its platform: the live instance still had one ENABLED pixiv source (step 1). Tracing it: the scheduler only selects enabled rows and every platform lookup uses .get(), so a disabled row is inert - but re-enabling it and pressing Check would have routed pixiv, no longer native, straight into the gallery-dl branch, which still has a pixiv extractor. And a worker can pick up a still-enabled row before a deploy's migration runs. So run_download and verify_source_credential - the two functions every download and credential probe pass through - now refuse any platform not in the registry: an unsupported_url failure for downloads, and an inconclusive (None, not False) verify, since nothing was probed so nothing was rejected. Generic by registration, so it covers deviantart's leftovers too. Positive-controlled: a supported gallery-dl platform must still reach gallery-dl, or a guard that refused everything would pass (rule 167). Migration 0097 disables sources on retired platforms (pixiv, deviantart) and clears their failure state exactly as disabling through the app does (1285), so the stale row stops being scheduled and stops showing as failing. Nothing is deleted: removing a source can collide with uq_post_artist_external_id_null_source on real data, which is phase 2's step 6 to check. No post or image is touched. Tests: the known-platform lists drop pixiv and gain retirement assertions beside deviantart's; pixiv's positive extension cases become negative guards; the pixiv sidecar post-URL test is deleted with the behaviour it tested; quick-add rejects a pixiv URL. The pixiv client/downloader/ingester suites stay - that code stays until phase 2. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHQB1YukL3VyvMK8rcbmV9
124 lines
4.3 KiB
Python
124 lines
4.3 KiB
Python
"""download_backends — the single predicate that routes a platform to the
|
|
native ingester vs. gallery-dl. Pure, no DB."""
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from backend.app.services.download_backends import (
|
|
NATIVE_INGESTER_PLATFORMS,
|
|
_campaign_resolution_error,
|
|
_native_ingester_cls,
|
|
_unsupported_platform_message,
|
|
run_download,
|
|
uses_native_ingester,
|
|
verify_source_credential,
|
|
)
|
|
from backend.app.services.gallery_dl import ErrorType
|
|
from backend.app.services.pixiv_ingester import PixivIngester
|
|
|
|
|
|
def test_native_platforms():
|
|
for platform in ("patreon", "subscribestar"):
|
|
assert uses_native_ingester(platform) is True
|
|
assert platform in NATIVE_INGESTER_PLATFORMS
|
|
|
|
|
|
def test_pixiv_is_no_longer_native():
|
|
"""Retired at milestone #406. The refusal below is what stops it falling
|
|
through to gallery-dl now that it is not native."""
|
|
assert uses_native_ingester("pixiv") is False
|
|
assert "pixiv" not in NATIVE_INGESTER_PLATFORMS
|
|
|
|
|
|
# --- the retired-platform guard (#406 phase 1) -----------------------------
|
|
|
|
|
|
class _RecordingGalleryDL:
|
|
"""Stands in for GalleryDLService: records whether a download was attempted."""
|
|
|
|
def __init__(self):
|
|
self.calls = []
|
|
|
|
async def download(self, **kwargs):
|
|
self.calls.append(kwargs["platform"])
|
|
return "reached gallery-dl"
|
|
|
|
|
|
def _ctx(platform):
|
|
return {
|
|
"platform": platform, "url": f"https://example.invalid/{platform}",
|
|
"artist_slug": "someone", "cookies_path": None, "auth_token": None,
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_a_retired_platform_never_reaches_a_downloader():
|
|
"""An enabled source on a retired platform is data that survives a deploy.
|
|
Unguarded, pixiv — no longer native — would fall straight through to the
|
|
gallery-dl branch, which still has a pixiv extractor."""
|
|
gdl = _RecordingGalleryDL()
|
|
result, campaign_id = await run_download(
|
|
ctx=_ctx("pixiv"), source_config=None, skip_value=False, mode=None,
|
|
gdl=gdl, sync_session_factory=None,
|
|
)
|
|
assert gdl.calls == []
|
|
assert result.success is False
|
|
assert result.error_type == ErrorType.UNSUPPORTED_URL
|
|
assert "pixiv" in result.error_message
|
|
assert campaign_id is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_a_supported_gallery_dl_platform_still_reaches_gallery_dl():
|
|
"""The positive control. Without it, a guard that refused EVERY platform
|
|
would pass the test above just as well (rule #167)."""
|
|
gdl = _RecordingGalleryDL()
|
|
result, _ = await run_download(
|
|
ctx=_ctx("hentaifoundry"), source_config=None, skip_value=False, mode=None,
|
|
gdl=gdl, sync_session_factory=None,
|
|
)
|
|
assert gdl.calls == ["hentaifoundry"]
|
|
assert result == "reached gallery-dl"
|
|
|
|
|
|
def test_the_guard_discriminates_by_registration():
|
|
assert _unsupported_platform_message("hentaifoundry") is None
|
|
assert _unsupported_platform_message("patreon") is None
|
|
assert _unsupported_platform_message("pixiv") is not None
|
|
assert _unsupported_platform_message("deviantart") is not None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_verifying_a_retired_platform_is_inconclusive_not_rejected():
|
|
"""Nothing is probed, so nothing is rejected — returning False would tell the
|
|
operator their credential is bad when the platform is simply gone."""
|
|
ok, message = await verify_source_credential(
|
|
platform="pixiv", url="https://www.pixiv.net/users/1", artist_slug="someone",
|
|
config_overrides=None, cookies_path=None, auth_token=None,
|
|
images_root=Path("/nonexistent"),
|
|
)
|
|
assert ok is None
|
|
assert "pixiv" in message
|
|
|
|
|
|
def test_gallery_dl_platforms_are_not_native():
|
|
# The platforms still served by gallery-dl must NOT route to the native
|
|
# ingester — guards an accidental over-broad migration.
|
|
for platform in ("hentaifoundry", "discord"):
|
|
assert uses_native_ingester(platform) is False
|
|
|
|
|
|
def test_unknown_platform_is_not_native():
|
|
assert uses_native_ingester("nonsense") is False
|
|
|
|
|
|
def test_pixiv_dispatches_to_its_ingester():
|
|
assert _native_ingester_cls("pixiv") is PixivIngester
|
|
|
|
|
|
def test_pixiv_resolution_error_names_the_expected_url_shape():
|
|
msg = _campaign_resolution_error("pixiv", "https://www.pixiv.net/artworks/1")
|
|
assert "pixiv user id" in msg
|
|
assert "users/<id>" in msg
|