bvandeusenandClaude Opus 5
45bb7044f7
CI and images / lint (push) Failing after 3s
CI and images / extension-version (push) Successful in 4s
CI and images / frontend-build (push) Successful in 31s
CI and images / backend-lint-and-test (push) Successful in 35s
CI and images / integration (push) Successful in 2m44s
CI and images / sign-extension (push) Skipped
CI and images / build-web (push) Skipped
CI and images / smoke-web (push) Skipped
CI and images / promote (push) Skipped
CI and images / build-agent (push) Skipped
Operator: "there is a repull every time this page loads is there a reason
this info isn't being tracked in the background and stored in some way?"
There was a reason and it had expired, and underneath it there was plain
waste.
The expired one: /api/system/workers was deliberately uncached because an
operator dragging the stepper must not be shown a pre-change value. That
stopped being true at 1353d34, when the UI began patching its row from the
write's reply instead of refetching.
The waste: size_worker_lanes already inspected the broker on a timer to
decide pool sizes — computing the pool, active, reserved and queue depth
the page shows, using them, and discarding them. The browser then asked
the broker for the same numbers four times a minute, per open tab.
So one inspect now feeds three things: the sizing decision, a stored
sample (worker_lane_sample, alembic 0107), and the celery roster. No
request path touches the broker at all — the roster refresh comes off
/api/system/health too, where it had been rate-limited to 20s and so made
worker liveness a function of whether anyone had a browser open.
Consequences, stated rather than hidden:
- The live figures are up to one sweep old. measured_at travels with each
lane and the page says how old, because a stale number presented as
current is how someone watches a queue "not move" that is moving.
- The sweep is the roster's only writer now, so its period and the
staleness thresholds are in a relationship. 60s against a 90s stale
threshold left one missed tick between normal and all-yellow — the
shape of lesson #4355 — so the period is 30s, named once in
worker_lanes, and system_health asserts its headroom at import with a
test stating the same thing in prose.
- An idle lane therefore also gives a worker back twice as fast. That is
the direction asked for: "idle instances quiet down when not running".
Also bounds the inspect in push_lane_cap, which was an await with no
deadline (rule 156) — harmless while it ran on a request, less so now
that it runs in a background task where a hang would be silent.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LVjrnpQjRgHdvq95rASoiR
34 lines
1.1 KiB
Python
34 lines
1.1 KiB
Python
"""Test doubles shared across modules.
|
|
|
|
Alongside `roster_builders.py`, which does the same job for fixture ROWS. A
|
|
double written twice in one change, in two test modules, for the same reason
|
|
belongs in one place — and a file of its own rather than `conftest.py`, which
|
|
is where fixtures live and gets imported by pytest on its own terms.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
class RecordingSession:
|
|
"""A session double that COLLECTS statements instead of running them.
|
|
|
|
Two production paths now own a sync session and write through it — the
|
|
sizing sweep's lane samples and its roster refresh — while this suite is
|
|
async. Rather than reimplement either writer (which would test a copy),
|
|
a test hands one of these in, then either asserts on what was collected or
|
|
replays the statements on the real async session.
|
|
|
|
Lives here because it was written twice in one change, in two test
|
|
modules, for the same reason.
|
|
"""
|
|
|
|
def __init__(self):
|
|
self.stmts: list = []
|
|
self.commits = 0
|
|
|
|
def execute(self, stmt):
|
|
self.stmts.append(stmt)
|
|
|
|
def commit(self) -> None:
|
|
self.commits += 1
|