bvandeusen and Claude Opus 5
005680f234
Build images / sign-extension (push) Successful in 2s
Build images / build-agent (push) Successful in 6s
CI / lint (push) Successful in 1s
CI / extension-version (push) Successful in 2s
CI / backend-lint-and-test (push) Successful in 39s
CI / frontend-build (push) Successful in 28s
Build images / build-web (push) Successful in 1m10s
Build images / smoke-web (push) Skipped
Build images / build-ml (push) Successful in 3m4s
Build images / promote (push) Skipped
CI / integration (push) Successful in 2m22s
fix: one source edit no longer wipes the campaign id and the backfill position
...
Source.config_overrides carries two unrelated things under one column: the operator's per-source download settings, and state FC writes for itself. update() treated the whole column as operator-owned and assigned it wholesale, so a dialog save discarded patreon_campaign_id and the entire #693 backfill state machine. Not a hand-edited-JSON edge case: SourceFormDialog's structured tab rebuilds the object from two fields, so saving without touching anything was enough.
_merged_config now merges: the operator's keys replace wholesale (removing a key must still remove it), FC's keys survive and are applied LAST so a stale echoed cursor cannot roll a walk backwards. App-managed is _-prefixed or *_campaign_id, both matching data already on disk, so no migration.
Preserving the id exposed a bug the wipe was MASKING: nothing cleared it when a source's URL changed, and patreon_resolver reads that cache before attempting any lookup. A repointed source would have resolved the old creator forever and 387 C4 would have reported a confident wrong match. So update() drops *_campaign_id when the URL actually changes - but keeps the backfill cursor, which the walk's own stall guard validates and which is expensive to rebuild.
test_update_changes_fields was DOCUMENTING the bug: it asserted config_overrides == {videos: False} on a source whose create() had armed _backfill_state, so it could only pass because the state had been destroyed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com >
Claude-Session: https://claude.ai/code/session_01LNXXULQDjVZmbuNa2G9mD9
2026-09-11 21:50:28 -04:00
..
2026-09-10 22:26:01 -04:00
2026-05-14 07:32:17 -04:00
2026-07-02 23:21:52 -04:00
2026-07-02 11:20:45 -04:00
2026-08-26 22:37:24 -04:00
2026-06-12 13:05:58 -04:00
2026-06-01 14:17:52 -04:00
2026-07-04 22:04:20 -04:00
2026-06-03 15:45:59 -04:00
2026-08-27 07:48:18 -04:00
2026-06-26 11:47:48 -04:00
2026-06-29 12:54:35 -04:00
2026-06-04 16:55:20 -04:00
2026-06-17 12:03:48 -04:00
2026-05-30 00:59:05 -04:00
2026-05-28 11:33:05 -04:00
2026-08-27 11:47:30 -04:00
2026-06-23 01:11:42 -04:00
2026-07-05 19:42:59 -04:00
2026-06-28 10:36:25 -04:00
2026-05-28 11:33:05 -04:00
2026-07-06 22:59:00 -04:00
2026-08-27 07:24:08 -04:00
2026-07-10 22:38:25 -04:00
2026-06-01 14:17:52 -04:00
2026-06-11 23:10:30 -04:00
2026-06-14 15:57:42 -04:00
2026-07-10 22:38:25 -04:00
2026-05-28 11:33:05 -04:00
2026-05-30 23:15:07 -04:00
2026-09-09 23:10:06 -04:00
2026-07-10 15:22:51 -04:00
2026-09-09 23:10:06 -04:00
2026-05-28 11:33:05 -04:00
2026-06-30 13:04:31 -04:00
2026-06-30 13:47:55 -04:00
2026-05-28 11:33:05 -04:00
2026-07-06 18:51:39 -04:00
2026-06-01 21:57:29 -04:00
2026-06-06 14:33:24 -04:00
2026-09-02 13:46:16 -04:00
2026-08-28 22:01:58 -04:00
2026-08-27 07:24:08 -04:00
2026-09-11 21:38:03 -04:00
2026-07-04 22:04:20 -04:00
2026-06-01 14:17:52 -04:00
2026-06-03 15:45:59 -04:00
2026-05-19 11:11:07 -04:00
2026-05-26 01:18:38 -04:00
2026-05-26 01:18:07 -04:00
2026-05-19 14:59:04 -04:00
2026-06-01 22:09:02 -04:00
2026-06-10 14:29:17 -04:00
2026-06-26 11:47:48 -04:00
2026-07-06 16:21:38 -04:00
2026-06-16 21:05:26 -04:00
2026-06-24 00:06:49 -04:00
2026-07-06 18:59:00 -04:00
2026-05-21 16:02:36 -04:00
2026-05-26 08:13:53 -04:00
2026-08-26 22:37:24 -04:00
2026-06-02 17:04:27 -04:00
2026-07-02 21:51:51 -04:00
2026-06-29 10:17:05 -04:00
2026-06-09 23:46:01 -04:00
2026-09-10 11:35:53 -04:00
2026-08-27 07:24:08 -04:00
2026-06-30 13:41:25 -04:00
2026-09-09 15:40:19 -04:00
2026-06-06 21:22:32 -04:00
2026-05-28 12:43:08 -04:00
2026-07-13 17:50:07 -04:00
2026-05-15 13:53:42 -04:00
2026-06-16 21:15:49 -04:00
2026-07-02 16:53:08 -04:00
2026-05-29 15:34:20 -04:00
2026-05-20 20:39:17 -04:00
2026-06-03 22:58:46 -04:00
2026-06-17 12:03:48 -04:00
2026-06-04 07:01:07 -04:00
2026-06-03 23:50:19 -04:00
2026-07-12 23:15:59 -04:00
2026-07-13 12:06:22 -04:00
2026-07-02 16:53:08 -04:00
2026-07-02 21:07:21 -04:00
2026-07-06 18:18:46 -04:00
2026-07-06 16:36:30 -04:00
2026-06-29 00:36:58 -04:00
2026-07-06 18:28:25 -04:00
2026-08-28 18:08:31 -04:00
2026-07-06 23:34:18 -04:00
2026-06-14 16:39:58 -04:00
2026-08-27 07:51:23 -04:00
2026-05-19 11:14:49 -04:00
2026-06-21 22:22:03 -04:00
2026-05-18 21:33:55 -04:00
2026-06-15 22:17:36 -04:00
2026-05-25 20:33:44 -04:00
2026-05-25 22:16:26 -04:00
2026-06-01 14:40:28 -04:00
2026-06-01 14:17:52 -04:00
2026-07-02 17:37:21 -04:00
2026-07-09 16:17:56 -04:00
2026-06-14 13:15:36 -04:00
2026-08-26 22:37:24 -04:00
2026-09-11 21:38:03 -04:00
2026-09-10 22:26:01 -04:00
2026-09-10 23:40:48 -04:00
2026-06-12 13:05:58 -04:00
2026-06-30 13:04:31 -04:00
2026-07-13 21:41:24 -04:00
2026-05-15 07:36:17 -04:00
2026-07-10 15:22:51 -04:00
2026-06-03 13:00:08 -04:00
2026-05-14 07:34:29 -04:00
2026-06-07 18:34:11 -04:00
2026-06-14 16:39:58 -04:00
2026-06-17 11:32:28 -04:00
2026-06-15 00:14:52 -04:00
2026-06-17 11:32:28 -04:00
2026-09-09 15:40:19 -04:00
2026-09-10 22:26:01 -04:00
2026-07-04 22:37:50 -04:00
2026-06-05 19:26:57 -04:00
2026-06-30 13:04:31 -04:00
2026-05-17 22:18:07 -04:00
2026-07-04 22:24:25 -04:00
2026-07-03 19:41:29 -04:00
2026-07-03 09:45:14 -04:00
2026-08-27 07:24:08 -04:00
2026-08-27 07:24:08 -04:00
2026-09-10 11:47:28 -04:00
2026-08-27 07:24:08 -04:00
2026-07-12 23:15:59 -04:00
2026-07-06 23:46:09 -04:00
2026-07-13 10:14:38 -04:00
2026-06-15 00:14:52 -04:00
2026-06-21 22:22:03 -04:00
2026-07-13 12:06:22 -04:00
2026-07-13 21:41:34 -04:00
2026-07-02 16:53:08 -04:00
2026-08-27 07:33:14 -04:00
2026-06-29 11:18:28 -04:00
2026-09-02 12:28:48 -04:00
2026-07-06 18:13:37 -04:00
2026-06-06 14:33:24 -04:00
2026-05-25 22:16:26 -04:00
2026-05-19 11:14:49 -04:00
2026-09-09 22:55:14 -04:00
2026-06-11 21:30:01 -04:00
2026-06-11 23:17:14 -04:00
2026-06-11 21:47:58 -04:00
2026-06-07 18:58:18 -04:00
2026-06-11 21:30:01 -04:00
2026-06-11 23:10:30 -04:00
2026-06-11 23:10:30 -04:00
2026-05-15 15:49:25 -04:00
2026-07-04 20:13:53 -04:00
2026-06-14 16:39:58 -04:00
2026-05-14 12:04:05 -04:00
2026-09-11 21:50:28 -04:00
2026-07-04 22:37:50 -04:00
2026-06-28 11:20:11 -04:00
2026-07-03 08:34:16 -04:00
2026-06-26 00:51:56 -04:00
2026-06-30 13:04:31 -04:00
2026-06-06 23:57:06 -04:00
2026-05-26 21:00:12 -04:00
2026-07-06 19:03:51 -04:00
2026-05-15 07:39:33 -04:00
2026-06-06 17:39:54 -04:00
2026-05-24 21:22:42 -04:00
2026-06-16 08:31:50 -04:00
2026-06-10 14:29:17 -04:00
2026-06-07 00:08:19 -04:00
2026-07-02 16:53:08 -04:00
2026-05-27 22:45:11 -04:00
2026-05-21 18:53:35 -04:00
2026-05-14 12:05:19 -04:00
2026-05-21 16:01:59 -04:00
2026-07-02 23:19:41 -04:00
2026-07-10 22:38:25 -04:00
2026-07-10 22:38:25 -04:00
2026-05-19 18:15:59 -04:00
2026-07-13 10:14:38 -04:00
2026-07-13 10:14:38 -04:00