Tagging & viewing roadmap: tag query surface + hygiene projections + Explore view (Clusters A/B/C) #128

Merged

bvandeusen merged 8 commits from dev into main 2026-06-23 08:57:34 -04:00

Conversation 0 Commits 8 Files Changed 38

+2221 -91

bvandeusen commented 2026-06-23 08:57:22 -04:00

Owner

Copy Link

Copy Source

Ships the full viewing/tagging feature roadmap (note #1045) — three clusters, all CI-green on dev (7b71292, run 1476). No schema changes (migration head stays 0054).

Cluster A — Tag query surface (milestone #97)

• #5 Clicking a tag chip in the image modal closes it and opens the gallery filtered for that tag.
• #6 OR / exclude tag filtering — one filter model, two editors: light include/exclude chips (click a chip to flip polarity) in the gallery filter bar, plus an advanced AND-of-OR + NOT builder (TagQueryBuilder.vue). Backend layered additively on the existing AND path (tag_or_groups + tag_exclude); URL grammar tag_or (repeatable) + tag_not.

Cluster B — Tag-hygiene projections (milestone #99)

• #7 Allowlist tuning dashboard: per-tag Applied + Covers counts and a live "covers ~N at threshold T" projection while dragging the threshold; a non-blocking post-accept toast when a suggestion newly allowlists a tag.
• #8 Tag-merge preview: a non-mutating dry-run (images moving / already-on-target / series pages / alias-or-delete / sample thumbnails, parity with the apply) shown before the irreversible merge.

Cluster C — Explore view + tag-gap closing (milestone #94)

• #94 Dedicated /explore view: anchor on an image, walk its visual neighbours (pgvector/SigLIP) with a breadcrumb, and close cluster-consensus tag gaps ("7 of 10 share this tag; these 3 don't") with apply-to-cluster (skips images that rejected the tag).
• #4 Modal quick wins: an always-on metadata HUD (dimensions/size/type) and a split Download button (default Download, chevron → Copy link).

Reuses existing primitives throughout (usePreviewCommit, utils/clipboard, the similar-search + bulk-tag services); new reusable common/TagPicker.vue. Dev-logs: #1055 / #1064 / #1071.

🤖 Generated with Claude Code

Ships the full viewing/tagging feature roadmap (note #1045) — three clusters, all CI-green on `dev` (`7b71292`, run 1476). No schema changes (migration head stays 0054). ## Cluster A — Tag query surface (milestone #97) - **#5** Clicking a tag chip in the image modal closes it and opens the gallery filtered for that tag. - **#6** OR / exclude tag filtering — one filter model, two editors: light include/exclude chips (click a chip to flip polarity) in the gallery filter bar, plus an advanced AND-of-OR + NOT builder (`TagQueryBuilder.vue`). Backend layered additively on the existing AND path (`tag_or_groups` + `tag_exclude`); URL grammar `tag_or` (repeatable) + `tag_not`. ## Cluster B — Tag-hygiene projections (milestone #99) - **#7** Allowlist tuning dashboard: per-tag Applied + Covers counts and a live "covers ~N at threshold T" projection while dragging the threshold; a non-blocking post-accept toast when a suggestion newly allowlists a tag. - **#8** Tag-merge preview: a non-mutating dry-run (images moving / already-on-target / series pages / alias-or-delete / sample thumbnails, parity with the apply) shown before the irreversible merge. ## Cluster C — Explore view + tag-gap closing (milestone #94) - **#94** Dedicated `/explore` view: anchor on an image, walk its visual neighbours (pgvector/SigLIP) with a breadcrumb, and close cluster-consensus tag gaps ("7 of 10 share this tag; these 3 don't") with apply-to-cluster (skips images that rejected the tag). - **#4** Modal quick wins: an always-on metadata HUD (dimensions/size/type) and a split Download button (default Download, chevron → Copy link). Reuses existing primitives throughout (`usePreviewCommit`, `utils/clipboard`, the similar-search + bulk-tag services); new reusable `common/TagPicker.vue`. Dev-logs: #1055 / #1064 / #1071. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

bvandeusen added 8 commits 2026-06-23 08:57:22 -04:00

feat(gallery): tag→gallery nav from modal chips (#5) + OR/exclude tag scope (#6a) ... 23fab983a0

Cluster A, milestone #97. #5: clicking an image-modal tag chip's body now
closes the modal and opens the gallery filtered for that one tag (fresh
filter); ✕/kebab stay as the explicit remove/rename controls.

#6a (backend of OR/exclude filtering): gallery_service._apply_scope gains a
structured tag model — tag_or_groups (AND-of-OR: one EXISTS(tag_id IN group)
per group) + tag_exclude (NOT EXISTS(tag_id IN exclude)) — layered additively
on the existing tag_ids AND path so cursors/facets/deep-links are untouched.
Threaded through scroll/timeline/jump_cursor/facets/similar + facets common
dict; _require_single_filter rejects post_id combined with OR/exclude. API
parses tag_or (repeatable → one OR-group each) + tag_not (csv exclude).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XCUHUGQLrBrkgyk1t49kpX

feat(gallery): OR/exclude tag filtering — light chips + advanced builder (#6b/c/d) ... 73dd301dbb

Cluster A, milestone #97. Completes the frontend of the structured tag filter
(backend landed in 23fab98).

#6b store: gallery.filter gains tag_or (OR-groups) + tag_exclude; one model,
serialized via tag_or (repeated key) + tag_not across activeFilterParam/
filterToQuery/applyFilterFromQuery/cloneFilter/loadSimilar; _resolveLabels
resolves names for every referenced id. useApi now appends array param values
as a repeated key (tag_or=a&tag_or=b).

#6c light editor (GalleryFilterBar): autocomplete pick → include chip; click a
chip body to flip include↔exclude (exclude = red minus); ✕ removes. An
"N OR-groups" chip + an Advanced button open the builder.

#6d advanced editor (TagQueryBuilder.vue + common/TagPicker.vue): AND-of-OR
group builder + NOT list. Unifies includes+OR-groups into one groups view,
splits back to tag_ids/tag_or on Apply so the URL stays compact. Writes the
same model the light chips edit.

Store serialization round-trip tests added.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XCUHUGQLrBrkgyk1t49kpX

feat(allowlist): coverage projection + applied-count + post-accept projection (#7a/#7b) ... e206778a5c

Cluster B, milestone #99. Backend for the allowlist tuning dashboard.

#7a: AllowlistService.coverage(tag_id, threshold) counts distinct images with
a prediction resolving to the tag (raw_name==tag.name OR (raw_name,category) in
the tag's aliases) scoring >= threshold — the gross candidate pool, mirroring
tasks.ml._confidence_for_tag resolution. list_all now carries applied_count
(grouped image_tag count) + coverage_count (at the row's threshold). New
GET /api/tags/<id>/allowlist/coverage?threshold= for the live what-if number.

#7b: /suggestions/accept + /alias return {allowlisted, tag_id, tag_name,
projected_count} (projection at the tag's threshold) instead of 204, so the UI
can show a non-blocking 'auto-applying to ~N images' toast. Apply still runs
async via apply_allowlist_tags — projected_count is an estimate.

Tests: coverage by threshold (direct + alias-with-category), list applied vs
coverage, coverage route (explicit/default/bad threshold), accept/alias payload
(newly-allowlisted vs already-on-list).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XCUHUGQLrBrkgyk1t49kpX

feat(tags): non-mutating merge preview + admin dry_run (#8a) ... 7127714316

Cluster B, milestone #99. TagService.merge_preview(source, target) computes the
same counts the apply produces (rule 93 parity) without mutating: images_moving
(source links the apply UPDATEs), images_already_on_target (links it drops),
source_total, series_pages, will_alias (_keep_as_alias), a kind/fandom
compatible flag (surfaced, not raised, so the UI can warn), and up to 6
thumbnails of the moving images. The admin /tags/<dest>/merge route gains a
dry_run flag returning the preview JSON.

Tests: preview moving-count == apply merged_count (parity), incompatible flagged
without raising, self/missing raise, admin dry_run returns preview + no mutation.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XCUHUGQLrBrkgyk1t49kpX

feat(tagging): allowlist tuning dashboard + post-accept toast + merge preview UI (#7c/#7d/#8b) ... e49cea3eba

Cluster B frontend, milestone #99.

#7c: AllowlistTable gains Applied + Covers columns and a live 'covers ~N at T'
projection as the operator drags a row's threshold (debounced coverage call,
then commits the threshold). allowlist store gains coverage(tagId, threshold)
and refreshes coverage_count after a save.

#7d: suggestions store surfaces a non-blocking toast when accept/alias newly
allowlists a tag — '<verb>: <tag> — allowlisted, auto-applying to ~N images'
(N is the projection; apply runs async). Falls back to the plain toast when
the tag was already allowlisted.

#8b: TagsView merge picker now previews the merge via usePreviewCommit before
committing — shows images moving / already-on-target / series pages / alias-or-
delete / a thumbnail sample, blocks the Merge button on an incompatible
kind/fandom. adminStore.mergeTags gains a dryRun option.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XCUHUGQLrBrkgyk1t49kpX

test(allowlist): unique image paths in coverage tests (CI fix) ... 0cd2f391ee

The new coverage tests' sequential shas (c{i:063d}) share their first 8 chars,
so deriving the image path from sha[:8] collided on uq_image_record_path. Use
the full sha in the path. Same hardening for test_api_suggestions._img.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XCUHUGQLrBrkgyk1t49kpX

feat(explore): cluster-consensus tag-gaps service + route (#94a) ... 0ecd1ce4f1

Cluster C, milestone #94. BulkTagService.tag_gaps(image_ids, threshold) finds
tags applied to >= threshold fraction of a visual neighbour set but not all of
it (the '7 of 10 share Miku; these 3 don't' signal). Each gap carries the
laggard image ids minus any TagSuggestionRejection rows, so apply-to-cluster
never re-proposes a tag a neighbour dismissed. 100%-common tags and <2-image
sets are excluded. New POST /api/images/cluster/tag-gaps.

Tests: consensus found / common excluded / missing ids; rejected laggard
excluded from missing; tag dropped when all laggards rejected; <2 images empty;
route shape + bad input.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XCUHUGQLrBrkgyk1t49kpX

feat(explore): Explore view + tag-gap closing + modal meta/download (#94b–d, #4a/b) ... 7b712920a4

Cluster C frontend, milestone #94.

#94b Explore walk: new /explore/:imageId route + ExploreView + explore store.
Anchor (reuse /api/gallery/image), neighbour grid (reuse /api/gallery/similar,
24), click a neighbour to re-anchor; in-memory breadcrumb that trims on
backtrack (route is the source of truth). Empty/loading/error + no-embedding
states.

#94c tag-gap closing: components/explore/TagGapPanel — fetches
/api/images/cluster/tag-gaps for the anchor+neighbours, a consensus-threshold
slider (default 60%), per gap shows present/total + the missing thumbnails +
'Apply to N missing' → /api/tags/images/bulk/tags (source manual) → re-fetch.

#94d entry points: 'Explore' button in the modal RelatedStrip; the TopNav entry
comes free from the route's meta.title.

#4a metadata HUD + #4b split Download: new modal ImageMetaBar (always-on, above
ProvenancePanel) shows dimensions/size/type and a split Download button
(default Download, chevron → Copy link via utils/clipboard — no clipboard-image,
rule 95).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XCUHUGQLrBrkgyk1t49kpX

bvandeusen merged commit 376d310693 into main 2026-06-23 08:57:34 -04:00

bvandeusen referenced this issue from a commit 2026-07-02 23:14:49 -04:00

feat(tags): system tags — is_system column, seeded hygiene tags, protection guards

bvandeusen referenced this issue from a commit 2026-07-02 23:19:43 -04:00

feat(ml): training hygiene — system-tagged images are absent from other concepts training

bvandeusen referenced this issue from a commit 2026-07-02 23:23:31 -04:00

feat(gallery): similar() hides presentation images (banner / editor screenshot)

bvandeusen referenced this issue from a commit 2026-07-03 08:34:18 -04:00

feat(tags): system-tag UI markers + full protection sweep (step 4 of #128)

bvandeusen referenced this issue from a commit 2026-07-03 08:40:12 -04:00

test: whole-table tag counts become non-system counts

bvandeusen referenced this pull request 2026-07-03 09:16:09 -04:00

SubscribeStar .art age fix, modal tag-flow sync, system tags / training hygiene (#128) #190

bvandeusen referenced this issue from a commit 2026-07-03 09:16:18 -04:00

Merge pull request 'SubscribeStar .art age fix, modal tag-flow sync, system tags / training hygiene (#128)' (#190) from dev into main

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

bvandeusen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bvandeusen/FabledCurator#128