FC-6 series authoring + backup/NFS hardening + UX fixes #83

Merged

bvandeusen merged 10 commits from dev into main 2026-06-07 19:31:05 -04:00

Conversation 0 Commits 10 Files Changed 40

+3313 -176

bvandeusen commented 2026-06-07 19:30:57 -04:00

Owner

Copy Link

Copy Source

Rolls up the FC-6 series-authoring milestone plus a batch of fixes. All on dev at green CI (run #259, daaa754).

FC-6 — series authoring (3 phases)

• 6.1 chapter layer — SeriesChapter over series_page (chapter_number + within-chapter page order); reading order = (chapter, page). Migration 0040 backfills one chapter per existing series. Chapter-aware manage view (rename, stated-page inputs, reorder, merge, delete, gap badges) + reader with chapter dividers.
• 6.2 post→series — promote a post to a new series or add it as a chapter of an existing one (1:1 default, mergeable); page-range parser; /series browse view + nav; PostSeriesMenu on PostCard.
• 6.3 assisted matcher — weighted additive scoring (title/artist/pages/tags — no single hard gate) surfaces SeriesSuggestion candidates; Suggestions tab with accept/dismiss + threshold/enable controls; time-boxed self-resuming rescan task. Migration 0041.

Backup / NFS hardening (#739)

• _run_bounded: Popen + bounded post-kill reap — a child stuck in an NFS D-state can no longer hold the concurrency-1 maintenance_long lane for hours (it killed normalize/reextract/audit/rescan alongside it).
• backup_db dumps to a local temp file, then shutil.moves the finished file to the NFS _backups dir — the long pg_dump phase is now a killable local write instead of an uninterruptible NFS one.
• Per-kind stall threshold in recover_stalled_backup_runs (db 40 min, images 7 h).

Fixes

• #740 tag-standardize "0 groups": stop zeroing the preview on click; disable the button while queued.
• #738 size Postgres /dev/shm via a tmpfs mount (Swarm ignores shm_size).
• Reset tab title on navigation (artist name no longer sticks on other tabs).
• Fandom modal: Enter accepts the selection instead of reopening the dropdown.

Schema: alembic head moves to 0041 (two new migrations).

🤖 Generated with Claude Code

Rolls up the FC-6 series-authoring milestone plus a batch of fixes. All on `dev` at green CI (run #259, `daaa754`). ## FC-6 — series authoring (3 phases) - **6.1 chapter layer** — `SeriesChapter` over `series_page` (chapter_number + within-chapter page order); reading order = (chapter, page). Migration `0040` backfills one chapter per existing series. Chapter-aware manage view (rename, stated-page inputs, reorder, merge, delete, gap badges) + reader with chapter dividers. - **6.2 post→series** — promote a post to a new series or add it as a chapter of an existing one (1:1 default, mergeable); page-range parser; `/series` browse view + nav; `PostSeriesMenu` on PostCard. - **6.3 assisted matcher** — weighted additive scoring (title/artist/pages/tags — no single hard gate) surfaces `SeriesSuggestion` candidates; Suggestions tab with accept/dismiss + threshold/enable controls; time-boxed self-resuming rescan task. Migration `0041`. ## Backup / NFS hardening (#739) - `_run_bounded`: Popen + bounded post-kill reap — a child stuck in an NFS D-state can no longer hold the concurrency-1 `maintenance_long` lane for hours (it killed normalize/reextract/audit/rescan alongside it). - `backup_db` dumps to a local temp file, then `shutil.move`s the finished file to the NFS `_backups` dir — the long pg_dump phase is now a killable local write instead of an uninterruptible NFS one. - Per-kind stall threshold in `recover_stalled_backup_runs` (db 40 min, images 7 h). ## Fixes - **#740** tag-standardize "0 groups": stop zeroing the preview on click; disable the button while queued. - **#738** size Postgres `/dev/shm` via a tmpfs mount (Swarm ignores `shm_size`). - Reset tab title on navigation (artist name no longer sticks on other tabs). - Fandom modal: Enter accepts the selection instead of reopening the dropdown. Schema: alembic head moves to `0041` (two new migrations). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

bvandeusen added 10 commits 2026-06-07 19:30:57 -04:00

fix(router): reset tab title on navigation (artist name stuck on other tabs) ... a92817677d

ArtistView set document.title to "<artist> — FabledCurator" on load but nothing
reset it when navigating away, so the artist name stuck on the Showcase/Gallery
tab title (operator-flagged 2026-06-07). Add a router.afterEach that sets the
title from meta.title on every navigation; detail views with no meta.title reset
to the default and then set their own dynamic title.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

fix(modal): Enter accepts the fandom instead of reopening the dropdown ... 677317244e

The Enter handler listened in the bubbling phase, so Vuetify's own input handler
(which opens the menu on Enter) fired first and my accept logic saw the menu
already opening and bailed — Enter popped the dropdown instead of submitting.
Bind it in the capture phase so it runs first, and stop the event when a fandom
is already selected so Vuetify never reopens the menu (operator-flagged
2026-06-07).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

fix(infra): size Postgres /dev/shm via tmpfs mount (shm_size ignored under Swarm) ... 43b02d79a4

The prod stack runs under Docker Swarm (docker stack deploy), which SILENTLY
IGNORES `shm_size` — container inspect showed ShmSize still 64MB after the
a183be7 fix, and vacuum_analyze kept hitting DiskFull resizing a ~64MB POSIX
DSM segment in /dev/shm (operator-flagged 2026-06-07). Replace the ignored
`shm_size: 512m` with a tmpfs mount on /dev/shm (size 512MB), which Swarm AND
plain Compose both honor. Requires a stack redeploy to take effect.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

feat(series): chapter layer over series_page — backend (FC-6.1) ... 1804a2c622

Adds an ordered chapter layer to series. Reading order becomes
(series_chapter.chapter_number, series_page.page_number); a chapter may be a
placeholder reserving a slot, and carries an optional parsed stated-page range
used to flag missing-page gaps. An image still lives in at most one series ⇒ one
chapter (image_id stays UNIQUE).

- models: series_chapter; series_page gains chapter_id (NOT NULL, cascade) +
  stated_page. Migration 0040 backfills every existing series into one
  auto-chapter holding its current flat pages — no data loss.
- SeriesService: chapter CRUD (create/update/reorder/delete/merge), page→chapter
  assignment, reorder_pages, chapter-aware set_cover; list_pages now returns
  chapters[] + gaps[] alongside a back-compat flat pages[]. Legacy series-wide
  reorder operates on the single default chapter and rejects multi-chapter series.
- API: chapter endpoints under /api/series/<tag>/chapters; POST pages accepts an
  optional chapter_id.
- TagService.merge now repoints series_chapter too, so a merged series' chapters
  (and their pages) survive the source tag's deletion instead of cascading away.
- Tests: new chapter suite; updated the 4 direct SeriesPage(...) constructions to
  supply chapter_id.

Frontend (chapter-aware manage view + reader) lands next; until then the
existing UI keeps working via the flat pages[] + single default chapter.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

feat(series): chapter-aware manage view + reader — frontend (FC-6.1) ... 8ad40da145

Completes FC-6.1: the series management UI now works in chapters.

- SeriesManageView: chapters as cards (inline-rename, stated-page range inputs,
  move up/down, merge-into-previous, delete, pick-as-add-target), pages
  drag-reorder WITHIN a chapter, a "gap: N-M missing" badge between chapters
  with a stated-page hole, and Add chapter / Add placeholder. The picker adds
  the selection into the targeted chapter.
- seriesManage store: chapter CRUD + reorderChapters/moveChapter/mergeChapter/
  reorderPages actions; consumes chapters[]/gaps[]; addSelected targets a chapter.
- Reader: page_number is now within-chapter, so anchors switched to a global
  `seq` (reading-order position) — fixes scroll/jump/active collisions across
  chapters — plus chapter-title dividers at each chapter boundary.
- Updated seriesManage.spec to the chaptered store shape.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

feat(series): post→series flows + browse list — backend (FC-6.2) ... db490e92df

The post-aware on-ramp + the data behind the missing Series browse view.

- page_number_parser: conservative stated-page parser (pages 9-12 / page 5 /
  [3/8] / 3 of 8), keyword-gated to avoid false positives. Pure + unit-tested.
- SeriesService.promote_post_to_series: a self-contained post becomes its own
  series — series tag named after the post, one chapter, the post's images as
  pages (ordered by capture order; stated pages parsed from title/description).
- SeriesService.add_post_as_chapter: append a post as the next chapter of an
  existing series, titled after the post and slotted by parsed page number
  (a "pages 1-4" post lands ahead of the "pages 9-12" chapter).
- SeriesService.list_series: browse cards — cover thumb, artist, chapter/page
  counts, gap flag, last-updated; sort recent|name|size + filter by artist.
- API: GET /api/series, POST /api/series/from-post, POST /api/series/<id>/add-post.
- Resolver uses ImageRecord.primary_post_id (same linkage the posts feed renders).

Frontend (Add-to-series control + Series view + nav) lands next.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

feat(series): Add-to-series control + Series browse view + nav (FC-6.2) ... 9e262cc5f0

Completes FC-6.2 with the UI.

- PostSeriesMenu: a "Series ▾" control on each post card — "New series from
  this post" (promote → navigates to manage) and "Add to existing series…"
  (dialog with a browsable picker loaded from GET /api/series, client-side
  filtered — avoids the empty-autocomplete #712 trap).
- SeriesView (/series): a top-level Series browse grid — cover, name, artist,
  chapter/page counts, gap badge; sort recent|name|size; cards → manage/read.
  meta.title adds it to the nav automatically (peer of Posts).
- seriesBrowse store for the list.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

feat(series): assisted-continuation matcher + suggestion queue — backend (FC-6.3) ... c0fd80e694

Confirm-only "this post may continue this series" matcher.

- series_suggestion table (post_id, series_tag_id, score, signals jsonb, status
  pending|added|dismissed, UNIQUE(post,series)); migration 0041 + two settings
  knobs (series_suggest_enabled, series_suggest_threshold).
- series_match_service: weighted additive score (title-stem / same-artist /
  page-continuity / shared-distinctive-tags), no single signal gating. The title
  "pattern" is derived on the fly from the post titles already in a series, so it
  sharpens as more are confirmed (no persisted state to drift). Candidates are
  bounded to the post's artist. match_post upserts pending suggestions (UNIQUE +
  on-conflict, respecting prior added/dismissed decisions).
- accept reuses add_post_as_chapter then marks 'added'; dismiss marks 'dismissed'.
- rescan_series_suggestions_task: settings-gated, time-boxed + self-resuming from
  a post-id cursor (maintenance_long lane), like normalize_tags_task.
- API: GET /series/suggestions, POST .../<id>/accept|dismiss, POST .../rescan.
- Settings: enabled + threshold exposed via /settings/import.
- Tests: pure scoring helpers + matcher/accept/dismiss/rescan lifecycle + UNIQUE
  dedup.

Frontend (Suggestions tab + settings card) lands next.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

feat(series): Suggestions tab + matcher controls — frontend (FC-6.3) ... 19a91a1641

Completes FC-6.3 with the UI.

- SeriesView gains tabs: Browse (the existing grid) + Suggestions.
- Suggestions tab: pending matches as rows (post → series, per-signal strength
  chips, score), Add (→ chapter) / Skip (→ dismiss); a "Matching on" toggle and
  a threshold field (both DB-backed via /settings/import), and a Rescan button
  that enqueues the background matcher.
- seriesSuggestions store wires load / accept / dismiss / rescan / settings.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

fix(backup,tags): unwedge backups on NFS (#739) + tag-standardize "0 groups" (#740) ... daaa7543a8

#739 — DB backups hung on NFS in uninterruptible D-state, defeating the 12-min
subprocess timeout AND Celery's hard limit, so a stuck pg_dump held the
concurrency-1 maintenance_long lane for hours — starving normalize_tags,
re-extract, audits, and the new series rescan (which is why #740 "never
applied"). Three fixes:
- _run_bounded: Popen + bounded post-kill reap; if the child is unkillable
  (D-state) we stop waiting and re-raise TimeoutExpired, freeing the slot. The
  orphan is reaped by the OS once its syscall clears.
- backup_db dumps to a LOCAL temp file then moves the finished .sql to the
  (NFS) _backups dir — pg_dump's long phase is now a DB-socket wait + local
  writes (killable) instead of an NFS write that hangs. backup_images keeps
  bounded-kill (too big to stage locally).
- recover_stalled_backup_runs: split the stall window — db 40 min (was sharing
  images' 7h), so a hung DB backup is flipped to error promptly.

#740 — Standardize tag casing showed "0 groups to change" the instant it was
clicked: onNormCommit overwrote the preview with zeros. Keep the real preview
visible and disable the button while queued; backend apply was already correct.

Tests: fake subprocess.Popen alongside run; bounded-kill fail-fast; local-temp
target; per-kind stall sweep.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

bvandeusen merged commit 747390631d into main 2026-06-07 19:31:05 -04:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

bvandeusen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bvandeusen/FabledCurator#83