External-attach orphan fix (#859) + image-less post display #108

Merged

bvandeusen merged 2 commits from dev into main 2026-06-15 01:55:36 -04:00

Conversation 0 Commits 2 Files Changed 9

+322 -67

bvandeusen commented 2026-06-15 01:55:31 -04:00

Owner

Copy Link

Copy Source

Merges two CI-green dev commits to main so they reach :latest:

• #859 — external-download attach orphan fix: per-link staging dir, path-safe unlink (never delete a file an ImageRecord points to), and an operator-triggered orphan-repair maintenance task with an NFS-stall abort guard. Fixes the 404-on-playback bug (TentaTime_Act3, StickySpoodge "Industrial Lust"). + regression tests.
• f897e25 — full-width body for image-less posts (drops the dead "no images" box).

No new migrations. No new runtime deps (the megatools/gdown image is unchanged) — but :latest still needs a forced re-pull after merge.

🤖 Generated with Claude Code

Merges two CI-green dev commits to main so they reach `:latest`: - **#859** — external-download attach orphan fix: per-link staging dir, path-safe unlink (never delete a file an ImageRecord points to), and an operator-triggered orphan-repair maintenance task with an NFS-stall abort guard. Fixes the 404-on-playback bug (TentaTime_Act3, StickySpoodge "Industrial Lust"). + regression tests. - **f897e25** — full-width body for image-less posts (drops the dead "no images" box). No new migrations. No new runtime deps (the megatools/gdown image is unchanged) — but `:latest` still needs a forced re-pull after merge. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

bvandeusen added 2 commits 2026-06-15 01:55:32 -04:00

feat(posts): full-width body for image-less posts (drop dead 'no images' box) ... f897e2534b

Text-only Patreon posts (WIP/announcement/poll — the bulk of a creator's feed)
rendered a big empty 'No images attached to this post' placeholder taking half
the card. Render the media column only when the post HAS images; image-less posts
let the title + body span the full width. Removes the now-dead PostEmptyThumbs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(external): path-safe unlink + per-link staging + orphan repair (#859) ... 949c9abcc6

External downloads import IN PLACE, so the post-attach dedup-skip unlink could
delete a file that IS an ImageRecord's backing file — orphaning the record and
404-ing on playback. Two sources of that:

- Two links on the same post (same film from mega + gdrive) emitted the same
  filename into one external/<post_id>/ dir; the second overwrote the first.
  Stage per-LINK now (external/<post_id>/<link_id>/) so each file keeps its path.
- The duplicate_hash/duplicate_phash branch unlinked `f` unconditionally. Make it
  path-safe: only unlink when `f` is NOT the existing record's canonical file.

Plus an operator-triggered orphan-repair maintenance task
(prune_missing_file_records_task) to clean up records already orphaned by the
bug: scans ImageRecords, deletes those whose file is gone (cascade), with an
NFS-stall guard that aborts without deleting if a large sample is mostly missing.
Wired through POST /api/admin/maintenance/prune-missing-files and a
MissingFileRepairCard in the Maintenance panel.

Tests: refetch-same-link keeps the canonical file; orphan repair deletes only
real orphans and aborts on the mostly-missing guard.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

bvandeusen merged commit fd84be40dd into main 2026-06-15 01:55:36 -04:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

bvandeusen

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bvandeusen/FabledCurator#108