bvandeusen/FabledCurator
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 12 Wiki Activity

Merge dev → main: per-post stdout diagnostics + post-field write DRY (#842/#753) #106

Merged
bvandeusen merged 2 commits from dev into main 2026-06-14 23:45:39 -04:00
Conversation 0 Commits 2 Files Changed 9
+96 -186
2 Commits
Author SHA1 Message Date
bvandeusenandClaude Opus 4.8 0d51b93aa7 refactor(importer): single _apply_post_fields predicate for both ingest paths (#842/#753)
CI / backend-lint-and-test (push) Successful in 42s
Details
CI / integration (push) Successful in 3m22s
Details
CI / lint (push) Successful in 3s
Details
CI / frontend-build (push) Successful in 27s
Details 
The per-media path (_apply_sidecar) and the post-record path (upsert_post_record)
each carried a VERBATIM copy of the post-field write (url/title/date/description/
attachment_count/raw_metadata + external-link sync). Two copies of one concept =
the divergence risk #753 targets. Consolidate into one _apply_post_fields(post,
sd) helper both call — a single predicate for how a post body/links get stored,
so the two sources can't drift. Behavior identical (fill-with-non-empty); both
paths already covered by existing importer tests.

Groundwork for the planned post-first ingest model (single authoritative post
record; media attaches to it) as more platforms move onto the native ingester.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-06-14 23:39:30 -04:00
bvandeusenandClaude Opus 4.8 eb811e11f6 refactor(ingest): per-post handling into run stdout via a downloader outcome (#842)
CI / lint (push) Successful in 3s
Details
CI / frontend-build (push) Successful in 22s
Details
CI / backend-lint-and-test (push) Successful in 38s
Details
CI / integration (push) Successful in 3m18s
Details 
Two corrections from operator review:
1. Reuse the existing 'Raw stdout' panel instead of a bespoke structured UI
   section — the native ingester now writes a per-post line into the run stdout
   (parity with gallery-dl's per-file stdout), so the per-post handling shows in
   the panel the operator already uses.
2. DRY: stop re-reading post['attributes'] inline in ingest_core. write_post_record
   now returns a PostRecordOutcome (path, post_type, title, body_chars) — mirroring
   the download_post -> MediaOutcome contract — and the downloader owns the read;
   ingest_core only formats the outcome into the log line.

Reverts the post_diagnostics metadata field + DownloadDetailModal 'Post capture'
section added earlier. Per-post line: 'post <id> [<post_type>] body: N chars' (+
' — EMPTY' when 0), so an empty body is self-explanatory by post_type.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-06-14 23:27:38 -04:00