bvandeusenandClaude Opus 5
5d0de7a682
Third Android run got further than either before it — all four ABIs cross-compiled, vendored OpenSSL and all — then the generator died: error: failed to run custom build command for `openssl-sys v0.9.117` That is the HOST build. The generator was a [[bin]] inside thoughtsync-ffi, so building it compiled that crate and therefore the core, reqwest, native-tls and openssl-sys for linux. The vendored-OpenSSL block is scoped to `cfg(target_os = "android")`, so the host build went looking for a system OpenSSL that ci-rust-android has no reason to carry. Adding libssl-dev to the image would have fixed it and been wrong: a code generator has no business linking the app's TLS stack to emit Kotlin. Splitting it into thoughtsync-uniffi-bindgen, whose only dependency is uniffi, removes the entire chain. Verified from the dependency graph rather than from a build that happened to succeed — `cargo tree -p thoughtsync-uniffi-bindgen` contains none of openssl-sys, native-tls, reqwest, thoughtsync-core or rusqlite. It stays a WORKSPACE MEMBER on purpose. Sharing one lockfile is what keeps uniffi here and uniffi linked into the .so at one version; they are two halves of one ABI, and a separate lockfile is precisely how they would drift apart. The cost is that the desktop lane now compiles ~15 generator crates it never runs — cheap next to Tauri, and better than leaving the crate unlinted. Drops the `bindgen` feature and required-features bin from thoughtsync-ffi, which existed only to keep those crates off the desktop lane and now have nothing to gate. Local fmt + clippy + test all green before pushing (107 tests). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
27 lines
1.0 KiB
TOML
27 lines
1.0 KiB
TOML
# Rust workspace. The framework-free client core, and the two shims that wrap it:
|
|
# the Tauri desktop app and the uniffi bindings the native Android client loads.
|
|
# Neither shim owns the core — that is the reason it is a crate at all rather than a
|
|
# module inside the desktop app (Scribe note 2730).
|
|
[workspace]
|
|
resolver = "2"
|
|
members = ["core", "desktop/src-tauri", "android/ffi", "android/bindgen"]
|
|
|
|
# Shared pins, so two consumers of the core cannot drift onto different versions of
|
|
# the same dependency and resolve differently.
|
|
[workspace.dependencies]
|
|
serde = { version = "1", features = ["derive"] }
|
|
serde_json = "1"
|
|
log = "0.4"
|
|
|
|
# Tauri's default release profile: smaller, faster shipped binaries.
|
|
#
|
|
# At the WORKSPACE root, not in the desktop member: cargo ignores profiles declared
|
|
# by a non-root package, so leaving it there would silently drop lto/strip/opt-level
|
|
# from every release build with only a warning to say so.
|
|
[profile.release]
|
|
codegen-units = 1
|
|
lto = true
|
|
opt-level = "s"
|
|
panic = "abort"
|
|
strip = true
|