.forgejo/workflows/ci.yml

@@ -193,8 +193,7 @@ jobs:
   # them ever executed by CI — and the schema the migrations build had never been
   # checked against the models that read it.
   #
-  # Runs for visibility and does NOT gate the build, matching the `test` lane and
+  # Gates the build, along with every other lane — see the `build` job's `needs`.
-  # FabledScribe's equivalent job.
   #
   # Job key stays separator-free ("integration") with no `name:` — rule 80. act_runner
   # derives the service-container name from the truncated job display name, and the
@@ -261,10 +260,16 @@ jobs:
 
   build:
     name: Build & push image
-    # Build gates on lint + typecheck. The `test` job runs in parallel for
+    # Every lane gates the build. This once stopped at lint + typecheck, on the
-    # visibility but does not block dev image builds (DB-backed integration
+    # reasoning that DB-backed testing happened manually against the dev image
-    # testing happens against the dev image manually, not on every push).
+    # rather than on every push — true until 6f21db8 added the integration lane,
-    needs: [gate, typecheck, lint]
+    # and false since.
+    #
+    # What that gap cost: run 4293 failed `test` and published :dev and :<sha>
+    # anyway, so the deployed server ran a build whose test lane was red. An image
+    # tag is the rollback substrate (family rule 46); one that can be published
+    # from a failing run is not a substrate you can roll back TO.
+    needs: [gate, typecheck, lint, test, integration]
     if: needs.gate.outputs.build == 'true'
     runs-on: python-ci
     container: