editor: detekt counts returns, so the promotion guards collapse into one

`promotingTasks` had four returns against ReturnCount's limit of two — three of
them the same `return this`. Collapsed into a null-or-task guard and a
`changed` flag, which says the contract more plainly anyway: the list comes
back untouched unless something was actually promoted.

Mirrored in blocks.ts even though nothing lints it there. The two files are
kept line-by-line alike on purpose, and letting them drift on shape is how the
next person stops trusting that reading one tells you the other.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

android/app/src/main/java/com/fabledsword/thoughtsync/ui/EditorBlock.kt

@@ -167,11 +167,13 @@ fun List<EditorBlock>.plusTask(): Pair<List<EditorBlock>, Long> {
  * only the way it is drawn.
  */
 internal fun List<EditorBlock>.promotingTasks(index: Int): List<EditorBlock> {
-    val block = getOrNull(index) ?: return this
+    val block = getOrNull(index)
-    if (block.isTask) return this
+    if (block == null || block.isTask) return this
     val split = splitBlocks(block.value.text, nextId())
-    if (split.size == 1 && !split.first().isTask) return this
+    // A single prose block back means there was nothing to promote. `splitBlocks` never
-    return take(index) + split + drop(index + 1)
+    // returns an empty list, so `first()` is safe.
+    val changed = split.size > 1 || split.first().isTask
+    return if (changed) take(index) + split + drop(index + 1) else this
 }
 
 /**

frontend/src/notes/blocks.ts

@@ -137,6 +137,8 @@ export function promoteTasks(blocks: EditorBlock[], index: number): EditorBlock[
   const block = blocks[index];
   if (!block || block.checked !== null) return blocks;
   const split = splitBlocks(block.text, nextId(blocks));
-  if (split.length === 1 && split[0].checked === null) return blocks;
+  // A single prose block back means there was nothing to promote. `splitBlocks` never
-  return [...blocks.slice(0, index), ...split, ...blocks.slice(index + 1)];
+  // returns an empty array, so `split[0]` is safe.
+  const changed = split.length > 1 || split[0].checked !== null;
+  return changed ? [...blocks.slice(0, index), ...split, ...blocks.slice(index + 1)] : blocks;
 }