frontend: dialogs keep focus, and a skip link past the chrome (task 1999)

BaseModal declared role="dialog" aria-modal="true" and then enforced none of it. Focus never moved into the panel, so Escape — handled ON the panel — did nothing at all in LabelsModal, the integration prompt and the shortcuts modal. Only the command palette escaped correctly, and only because it happens to focus its own input. Tab walked straight out of the dialog into the page that aria-modal had just told assistive tech was inert, and closing dropped focus to <body> so the next Tab restarted from the top of the document. All three are one contract, so it lives in BaseModal rather than in each of the four callers: focus in on open, Tab trapped, focus restored to the opener. The panel takes tabindex="-1" so it can hold focus itself when it wraps nothing focusable. CommandPalette's input focus still wins, because a child's mounted hook runs before its parent's. The skip link is the other half. The header and sidebar are a dozen-odd tab stops that repeat on every navigation, and a keyboard user walked all of them again to reach their notes. <main> takes tabindex="-1" as well, because several browsers scroll to a bare anchor without moving focus to it — which would have made the link look like it worked while leaving the next Tab back at the top. The rest of the audit came back clean: no click handlers on non-focusable elements, and all 30 focus:outline-none uses already pair with a focus-visible ring. M3.5's keyboard pass held up; the gaps were in focus management, not styling. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-16 12:54:08 -04:00
parent d6646a64fb
commit e7ee16c6cf
2 changed files with 92 additions and 6 deletions
@@ -210,6 +210,15 @@ async function signOut() {

 <template>
  <div class="flex min-h-full flex-col">
+    <!-- First tab stop on every page. The header and sidebar are a dozen-odd tab
+         stops that repeat on every navigation; without this a keyboard user walks
+         all of them again to reach their own notes. Hidden until focused. -->
+    <a
+      href="#main"
+      class="sr-only focus:not-sr-only focus:absolute focus:left-3 focus:top-3 focus:z-50 focus:rounded-md focus:bg-white focus:px-3 focus:py-2 focus:text-sm focus:font-medium focus:shadow-lg focus:outline-none focus:ring-2 focus:ring-brand dark:focus:bg-neutral-900"
+    >
+      Skip to notes
+    </a>
    <header
      class="sticky top-0 z-20 border-b border-neutral-200 bg-neutral-50/90 backdrop-blur dark:border-neutral-800 dark:bg-neutral-950/90"
    >
@@ -416,7 +425,10 @@ async function signOut() {
        </nav>
      </aside>

-      <main class="min-w-0 flex-1"><RouterView /></main>
+      <!-- tabindex="-1" so the skip link above actually moves FOCUS here, not just
+           the viewport — several browsers scroll to a plain anchor without focusing
+           it, which leaves the next Tab back at the top of the page. -->
+      <main id="main" tabindex="-1" class="min-w-0 flex-1 focus:outline-none"><RouterView /></main>
    </div>

    <LabelsModal v-if="managing" @close="managing = false" />