From 80324fba3b6d31ccb551189a441d007813d55c80 Mon Sep 17 00:00:00 2001
From: Bryan Van Deusen <bryan.vandeusen@fabledsword.com>
Date: Wed, 22 Jul 2026 08:26:19 -0400
Subject: [PATCH] =?UTF-8?q?m4.5:=20lists=20first-class=20=E2=80=94=20creat?=
 =?UTF-8?q?e=20a=20checklist=20straight=20from=20quick-add?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Checklist notes existed (M2) but could only be made by creating a text
note and toggling it in the editor — so they were undiscoverable. Now
the board's quick-add can make one in one shot.

- create endpoint accepts kind + items: POST /api/notes with
  kind:"list" and items:[...] creates a checklist note and its items
  atomically. A list note is non-empty when it has a title or ≥1 item.
- quick-add gets a checklist toggle (checkbox icon): flip it and each
  body line becomes an item on save; placeholder switches to
  "One item per line"; resets to a plain note after close.
- notes store create() accepts kind + items; parse_list_items() helper
  (trims, drops blanks) with a unit test.
- title placeholders now read "Title (optional)" in quick-add too.

Third item of M4.5. Display/editing of checklists was already built in
M2; this closes the creation gap.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FRgehjoz7Yv8LkUfADxACm
---
 frontend/src/components/QuickAdd.vue | 44 +++++++++++++++++++++++++---
 frontend/src/stores/notes.ts         |  8 ++++-
 src/thoughtsync/notes.py             | 21 +++++++++++--
 tests/test_notes.py                  |  8 +++++
 4 files changed, 74 insertions(+), 7 deletions(-)

diff --git a/frontend/src/components/QuickAdd.vue b/frontend/src/components/QuickAdd.vue
index 982fda1..1d0f8ce 100644
--- a/frontend/src/components/QuickAdd.vue
+++ b/frontend/src/components/QuickAdd.vue
@@ -2,6 +2,7 @@
 import { onBeforeUnmount, onMounted, nextTick, ref } from "vue";
 import { useNotesStore } from "../stores/notes";
 import ColorPicker from "./ColorPicker.vue";
+import Icon from "./Icon.vue";
 import type { NoteColor } from "../notes/colors";
 
 const props = withDefaults(defineProps<{ autofocus?: boolean }>(), { autofocus: false });
@@ -13,9 +14,17 @@ const saving = ref(false);
 const title = ref("");
 const body = ref("");
 const color = ref<NoteColor>("default");
+// 'text' = freeform note; 'list' = checklist (each body line becomes an item).
+const mode = ref<"text" | "list">("text");
 const root = ref<HTMLElement | null>(null);
 const bodyInput = ref<HTMLTextAreaElement | null>(null);
 
+function toggleMode() {
+  mode.value = mode.value === "list" ? "text" : "list";
+  bodyInput.value?.focus();
+  void nextTick(autoGrow);
+}
+
 async function open() {
   expanded.value = true;
   await nextTick();
@@ -45,7 +54,16 @@ async function persist(): Promise<void> {
   if (!hasContent()) return;
   saving.value = true;
   try {
-    await notes.create({ title: title.value, body: body.value, color: color.value });
+    if (mode.value === "list") {
+      // Each non-empty body line becomes a checklist item.
+      const items = body.value
+        .split("\n")
+        .map((l) => l.trim())
+        .filter(Boolean);
+      await notes.create({ title: title.value, body: "", color: color.value, kind: "list", items });
+    } else {
+      await notes.create({ title: title.value, body: body.value, color: color.value });
+    }
   } finally {
     saving.value = false;
   }
@@ -56,6 +74,7 @@ async function commit() {
   await persist();
   clearFields();
   expanded.value = false;
+  mode.value = "text"; // next capture starts as a plain note
 }
 
 // Shift+Enter: save the current note and immediately start a fresh one, staying
@@ -102,7 +121,7 @@ defineExpose({ open });
         <input
           v-model="title"
           type="text"
-          placeholder="Title"
+          placeholder="Title (optional)"
           class="w-full bg-transparent px-1 text-sm font-semibold outline-none placeholder:text-neutral-400"
           @keydown.enter.shift.prevent="commitAndContinue"
           @keydown.enter.exact.prevent="bodyInput?.focus()"
@@ -110,14 +129,31 @@ defineExpose({ open });
         <textarea
           ref="bodyInput"
           v-model="body"
-          placeholder="Take a note…    (Shift+Enter saves &amp; starts a new one)"
+          :placeholder="
+            mode === 'list'
+              ? 'One item per line…    (Shift+Enter saves)'
+              : 'Take a note…    (Shift+Enter saves &amp; starts a new one)'
+          "
           class="max-h-64 min-h-[4.5rem] w-full resize-none overflow-y-auto bg-transparent px-1 text-sm outline-none placeholder:text-neutral-400"
           @input="autoGrow"
           @keydown.enter.shift.prevent="commitAndContinue"
           @keydown.esc="commit"
         />
         <div class="flex items-center justify-between gap-2 pt-1">
-          <ColorPicker v-model="color" />
+          <div class="flex items-center gap-1">
+            <ColorPicker v-model="color" />
+            <button
+              type="button"
+              class="icon-btn"
+              :class="mode === 'list' ? 'text-brand-700 dark:text-brand' : ''"
+              :title="mode === 'list' ? 'Switch to a note' : 'Make a checklist'"
+              :aria-label="mode === 'list' ? 'Switch to a note' : 'Make a checklist'"
+              :aria-pressed="mode === 'list'"
+              @click="toggleMode"
+            >
+              <Icon name="checkbox" />
+            </button>
+          </div>
           <button
             type="button"
             class="rounded-md px-3 py-1.5 text-sm font-semibold text-neutral-700 hover:bg-neutral-100 focus:outline-none focus-visible:ring-2 focus-visible:ring-brand disabled:opacity-60 dark:text-neutral-200 dark:hover:bg-neutral-800"
diff --git a/frontend/src/stores/notes.ts b/frontend/src/stores/notes.ts
index 2e4e506..c8c2fc5 100644
--- a/frontend/src/stores/notes.ts
+++ b/frontend/src/stores/notes.ts
@@ -95,7 +95,13 @@ export const useNotesStore = defineStore("notes", () => {
     }
   }
 
-  async function create(input: { title: string; body: string; color: NoteColor }): Promise<void> {
+  async function create(input: {
+    title: string;
+    body: string;
+    color: NoteColor;
+    kind?: NoteKind;
+    items?: string[];
+  }): Promise<void> {
     reconcile(await api.post<Note>("/api/notes", input));
   }
 
diff --git a/src/thoughtsync/notes.py b/src/thoughtsync/notes.py
index 613c79e..87b0a74 100644
--- a/src/thoughtsync/notes.py
+++ b/src/thoughtsync/notes.py
@@ -59,6 +59,13 @@ def is_empty_note(title: str | None, body: str | None) -> bool:
     return not (title or "").strip() and not (body or "").strip()
 
 
+def parse_list_items(raw: object) -> list[str]:
+    """Trimmed, non-empty checklist item texts from a create payload's `items`."""
+    if not isinstance(raw, list):
+        return []
+    return [s.strip() for s in raw if isinstance(s, str) and s.strip()]
+
+
 def normalize_color(color: object) -> str:
     return color if color in NOTE_COLORS else "default"
 
@@ -387,7 +394,14 @@ async def create_note():
     data = await request.get_json(silent=True) or {}
     title = data.get("title") if isinstance(data.get("title"), str) else ""
     body = data.get("body") if isinstance(data.get("body"), str) else ""
-    if is_empty_note(title, body):
+    kind = data.get("kind") if data.get("kind") in ("text", "list") else "text"
+    # A checklist note's "content" is its items, not the body — so it's non-empty
+    # when it has a title or at least one item (quick-add can create one in one shot).
+    item_texts = parse_list_items(data.get("items")) if kind == "list" else []
+    if kind == "list":
+        if not (title.strip() or item_texts):
+            return jsonify({"error": "note is empty"}), 400
+    elif is_empty_note(title, body):
         return jsonify({"error": "note is empty"}), 400
     async with session_scope() as db:
         # New notes go to the top of the manual order.
@@ -402,11 +416,14 @@ async def create_note():
             title=clean_title,
             display_title=derive_display_title(clean_title, body),
             body=body,
+            kind=kind,
             color=normalize_color(data.get("color")),
             position=int(max_pos) + 1,
         )
         db.add(note)
-        await db.flush()  # assign note.id before writing links
+        await db.flush()  # assign note.id before writing items/links
+        for pos, text in enumerate(item_texts):
+            db.add(NoteItem(note_id=note.id, text=text, position=pos))
         await _rewrite_links(db, note)
         await db.commit()
         await db.refresh(note)
diff --git a/tests/test_notes.py b/tests/test_notes.py
index c0166e9..ff37129 100644
--- a/tests/test_notes.py
+++ b/tests/test_notes.py
@@ -8,6 +8,7 @@ from thoughtsync.notes import (
     is_empty_note,
     normalize_color,
     parse_link_titles,
+    parse_list_items,
     rewrite_link_title,
 )
 
@@ -130,6 +131,13 @@ def test_derive_display_title_caps_length():
     assert derive_display_title(long, "body") == "x" * 200
 
 
+def test_parse_list_items():
+    assert parse_list_items(["milk", " eggs ", "", "   ", "bread"]) == ["milk", "eggs", "bread"]
+    assert parse_list_items("not a list") == []
+    assert parse_list_items(None) == []
+    assert parse_list_items([1, "x", None, {"a": 1}]) == ["x"]
+
+
 def test_escape_like():
     # LIKE wildcards in user input must be neutralized so they match literally.
     assert _escape_like("100%") == "100\\%"