release / govulncheck (push) Successful in 15s
release / web (push) Failing after 1m21s
release / go (push) Successful in 1m35s
release / integration (push) Failing after 4m57s
release / android (push) Successful in 5m11s
release / Build signed APK (releases and dev) (push) Successful in 5m28s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Skipped
release / Verify release artifacts (tag releases only) (push) Skipped
Minstrel keeps its own list of what it is to get, keyed by MusicBrainz release group. A want comes from an approved request, a new release by a followed artist, or an album whose files went missing, and is held once the library has a full edition of it. - Migration 0081: release_type_profiles (Standard seeded: Album, EP, Single, studio only), follows, follow_seen_groups and wants. lidarr_requests becomes requests with plain *_mbid columns; approved album and track requests move onto the wanted list, approved artist requests become follows, and the library's album artists start out followed. missing_reacquisitions and the retry settings go. - internal/wanted: follows are checked against MusicBrainz discographies daily. The first check sets a baseline, and only releases after it are wanted unless the follow asked for what already exists. Profiles filter by primary and secondary type, so live recordings stay out unless a profile ticks Live. - internal/requests (was lidarrrequests): approving puts the request on the wanted list, and an artist request can be approved on a chosen profile. A request completes when its want is held. - The re-acquisition sweeper wants a missing album back instead of asking Lidarr; searching for it is the search schedule's (#5521). - Web: an admin Wanted page (Wanted, Missing files, Held, Following), a follow control on artist pages, a release-type profiles card on Integrations, "Approve on a profile" on Requests, and want state on Missing files. The artist detail API returns the artist's MBID. - Android: the request body sends artist_mbid, album_mbid and track_mbid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
42 lines
1.1 KiB
Go
42 lines
1.1 KiB
Go
package reacquisition
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
)
|
|
|
|
func TestValidateRejectsWhatTheCheckWouldReject(t *testing.T) {
|
|
// Each case mirrors a CHECK in migration 0056. Validating in Go as well
|
|
// means the API answers 400 with a readable message instead of surfacing
|
|
// a constraint violation.
|
|
cases := []struct {
|
|
name string
|
|
in Settings
|
|
}{
|
|
{"zero grace would fire on every transient unmount",
|
|
mutate(func(s *Settings) { s.GraceHours = 0 })},
|
|
{"grace beyond a month", mutate(func(s *Settings) { s.GraceHours = 721 })},
|
|
{"zero per pass means never sweep", mutate(func(s *Settings) { s.MaxPerPass = 0 })},
|
|
{"per pass beyond the cap", mutate(func(s *Settings) { s.MaxPerPass = 201 })},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
if err := validate(c.in); !errors.Is(err, ErrOutOfRange) {
|
|
t.Errorf("validate() = %v, want ErrOutOfRange", err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidateAcceptsDefaults(t *testing.T) {
|
|
if err := validate(Defaults); err != nil {
|
|
t.Fatalf("the shipped defaults must be valid, got %v", err)
|
|
}
|
|
}
|
|
|
|
func mutate(f func(*Settings)) Settings {
|
|
s := Defaults
|
|
f(&s)
|
|
return s
|
|
}
|