bvandeusenandClaude Opus 5.5
94a9c8cbe3
Merges Renovate's kit 3 (PR #149) and adapter-static 4 (PR #148) bumps, plus the migration they need. The mechanical part is `sv migrate sveltekit-3`, run one task at a time and reviewed: - svelte.config.js is gone. Its options move into sveltekit() in vite.config.ts, exported as kitOptions so vitest.config.ts runs the same kit setup, including the $test-utils alias the tests import. - $lib becomes #lib through package.json "imports". There is no src/lib/index, so only the "#lib/*" entry is kept. - tsconfig extends $app/tsconfig. - Peer floors raised to kit 3's requirements: svelte ^5.57.1, vite ^8.0.12, svelte-check ^4.7.5. By hand, from the codemod's list of non-automated tasks: - goto's replaceState option is now replace; keepFocus becomes reset: false. For the search typeahead, reset: false also stops the scroll-to-top, which is wanted while typing. - The test setup mocks drop pushState/replaceState and $app/paths base/assets, which kit 3 removed, and mock refreshAll in place of invalidateAll. - The other flagged files only read page.url or goto internal routes, so they needed no change. TypeScript goes to ^6, not the ^7 Renovate offers: kit 3 declares typescript ^6 as a peer and svelte-check 4.7 accepts ^5 || ^6. Move to 7 once both accept it. With Tailwind 4 and kit 3 in, `npm audit` on the whole tree reports 0, so the web lane now audits every dependency rather than only what ships to browsers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
63 lines
2.6 KiB
TypeScript
63 lines
2.6 KiB
TypeScript
import { afterEach, describe, expect, test, vi } from 'vitest';
|
|
import { render, screen, fireEvent } from '@testing-library/svelte';
|
|
import { readable } from 'svelte/store';
|
|
|
|
const cacheState = vi.hoisted(() => ({
|
|
data: { track_ids: ['t1'] as string[], album_ids: [] as string[], artist_ids: [] as string[] }
|
|
}));
|
|
|
|
vi.mock('#lib/api/likes.js', () => ({
|
|
createLikedIdsQuery: () => readable({ data: cacheState.data, isPending: false, isError: false }),
|
|
likeEntity: vi.fn().mockResolvedValue(undefined),
|
|
unlikeEntity: vi.fn().mockResolvedValue(undefined)
|
|
}));
|
|
|
|
import LikeButton from './LikeButton.svelte';
|
|
import { likeEntity, unlikeEntity } from '#lib/api/likes.js';
|
|
|
|
afterEach(() => {
|
|
vi.clearAllMocks();
|
|
cacheState.data = { track_ids: ['t1'], album_ids: [], artist_ids: [] };
|
|
});
|
|
|
|
describe('LikeButton', () => {
|
|
test('renders filled heart when track id IS in the set', () => {
|
|
render(LikeButton, { props: { entityType: 'track', entityId: 't1' } });
|
|
const btn = screen.getByRole('button', { name: /unlike/i });
|
|
expect(btn.getAttribute('aria-pressed')).toBe('true');
|
|
});
|
|
|
|
test('renders empty heart when track id is NOT in the set', () => {
|
|
render(LikeButton, { props: { entityType: 'track', entityId: 't2' } });
|
|
const btn = screen.getByRole('button', { name: /like/i });
|
|
expect(btn.getAttribute('aria-pressed')).toBe('false');
|
|
});
|
|
|
|
test('click on empty heart calls likeEntity', async () => {
|
|
render(LikeButton, { props: { entityType: 'track', entityId: 't2' } });
|
|
await fireEvent.click(screen.getByRole('button', { name: /like/i }));
|
|
expect(likeEntity).toHaveBeenCalledWith(expect.anything(), 'track', 't2');
|
|
});
|
|
|
|
test('click on filled heart calls unlikeEntity', async () => {
|
|
render(LikeButton, { props: { entityType: 'track', entityId: 't1' } });
|
|
await fireEvent.click(screen.getByRole('button', { name: /unlike/i }));
|
|
expect(unlikeEntity).toHaveBeenCalledWith(expect.anything(), 'track', 't1');
|
|
});
|
|
|
|
test('click stops propagation', async () => {
|
|
const parentClick = vi.fn();
|
|
const { container } = render(LikeButton, { props: { entityType: 'track', entityId: 't2' } });
|
|
const wrapper = container.parentElement!;
|
|
wrapper.addEventListener('click', parentClick);
|
|
await fireEvent.click(screen.getByRole('button', { name: /like/i }));
|
|
expect(parentClick).not.toHaveBeenCalled();
|
|
});
|
|
|
|
test('album entityType reads from album_ids set', () => {
|
|
cacheState.data = { track_ids: [], album_ids: ['al1'], artist_ids: [] };
|
|
render(LikeButton, { props: { entityType: 'album', entityId: 'al1' } });
|
|
expect(screen.getByRole('button', { name: /unlike/i }).getAttribute('aria-pressed')).toBe('true');
|
|
});
|
|
});
|