Files
minstrel/web/src/routes/page.test.ts
T
bvandeusenandClaude Opus 5.5 94a9c8cbe3 chore(deps): SvelteKit 3 with adapter-static 4 and TypeScript 6, full-tree npm audit (#5021)
Merges Renovate's kit 3 (PR #149) and adapter-static 4 (PR #148) bumps,
plus the migration they need. The mechanical part is `sv migrate
sveltekit-3`, run one task at a time and reviewed:

- svelte.config.js is gone. Its options move into sveltekit() in
  vite.config.ts, exported as kitOptions so vitest.config.ts runs the
  same kit setup, including the $test-utils alias the tests import.
- $lib becomes #lib through package.json "imports". There is no
  src/lib/index, so only the "#lib/*" entry is kept.
- tsconfig extends $app/tsconfig.
- Peer floors raised to kit 3's requirements: svelte ^5.57.1, vite
  ^8.0.12, svelte-check ^4.7.5.

By hand, from the codemod's list of non-automated tasks:

- goto's replaceState option is now replace; keepFocus becomes
  reset: false. For the search typeahead, reset: false also stops the
  scroll-to-top, which is wanted while typing.
- The test setup mocks drop pushState/replaceState and $app/paths
  base/assets, which kit 3 removed, and mock refreshAll in place of
  invalidateAll.
- The other flagged files only read page.url or goto internal routes,
  so they needed no change.

TypeScript goes to ^6, not the ^7 Renovate offers: kit 3 declares
typescript ^6 as a peer and svelte-check 4.7 accepts ^5 || ^6. Move to
7 once both accept it.

With Tailwind 4 and kit 3 in, `npm audit` on the whole tree reports 0,
so the web lane now audits every dependency rather than only what
ships to browsers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 10:50:39 -04:00

194 lines
7.1 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
import { render, screen, within } from '@testing-library/svelte';
import { readable } from 'svelte/store';
import { emptyLikesMock } from '../test-utils/mocks/likes';
import type { Playlist } from '#lib/api/types.js';
// Mock all the queries the home page constructs.
vi.mock('#lib/api/home.js', () => ({
createHomeQuery: () =>
readable({
data: {
recently_added_albums: [],
most_played_tracks: [],
rediscover_albums: [],
rediscover_artists: [],
last_played_artists: [],
you_might_like_albums: [],
you_might_like_artists: []
},
isPending: false,
isError: false,
refetch: vi.fn()
})
}));
vi.mock('#lib/api/playlists.js', () => ({
createPlaylistsQuery: vi.fn()
}));
vi.mock('#lib/api/me.js', () => ({
createSystemPlaylistsStatusQuery: vi.fn()
}));
// LikeButton imports — needed because the home renders cards that may use it.
vi.mock('#lib/api/likes.js', () => emptyLikesMock());
import Page from './+page.svelte';
import { createPlaylistsQuery } from '#lib/api/playlists.js';
import { createSystemPlaylistsStatusQuery } from '#lib/api/me.js';
const emptyPlaylistsResponse = { owned: [], public: [] };
beforeEach(() => {
(createPlaylistsQuery as unknown as ReturnType<typeof vi.fn>).mockImplementation(() =>
readable({ data: emptyPlaylistsResponse, isPending: false, isError: false })
);
(createSystemPlaylistsStatusQuery as unknown as ReturnType<typeof vi.fn>).mockReturnValue(
readable({
data: { in_flight: false, last_run_at: null, last_error: null },
isPending: false,
isError: false
})
);
});
afterEach(() => vi.clearAllMocks());
describe('home Playlists section', () => {
test('renders 5 placeholder cards when no playlists exist', () => {
// For-You + Discover in the Playlists row, plus 3 in the dedicated
// Songs-like row (#1491) = 5 placeholders total.
render(Page);
const placeholders = screen.queryAllByTestId('playlist-placeholder-card');
expect(placeholders).toHaveLength(5);
});
test('building status sets variant=building on placeholders', () => {
(createSystemPlaylistsStatusQuery as unknown as ReturnType<typeof vi.fn>).mockReturnValue(
readable({
data: { in_flight: true, last_run_at: null, last_error: null },
isPending: false,
isError: false
})
);
const { container } = render(Page);
const buildingPlaceholders = container.querySelectorAll('[data-variant="building"]');
expect(buildingPlaceholders.length).toBeGreaterThan(0);
});
test('renders For-You playlist + 3 placeholders when only for_you exists', () => {
const forYou: Playlist = {
id: 'fy',
user_id: 'u1',
owner_username: 'u1',
name: 'For You',
description: '',
is_public: false,
kind: 'system',
system_variant: 'for_you',
refreshable: false,
seed_artist_id: null,
cover_url: '',
track_count: 25,
duration_sec: 1500,
created_at: '2026-05-04T00:00:00Z',
updated_at: '2026-05-04T00:00:00Z'
};
(createPlaylistsQuery as unknown as ReturnType<typeof vi.fn>).mockImplementation(
(kind?: string) =>
kind === 'system'
? readable({
data: { owned: [forYou], public: [] },
isPending: false,
isError: false
})
: readable({ data: emptyPlaylistsResponse, isPending: false, isError: false })
);
render(Page);
expect(screen.getByText('For You')).toBeInTheDocument();
const placeholders = screen.queryAllByTestId('playlist-placeholder-card');
// 1 Discover placeholder (Playlists row) + 3 Songs-like placeholders
// (dedicated row) = 4 alongside the real For-You tile.
expect(placeholders).toHaveLength(4);
});
test('dedicated Songs-like row shows every generated mix, uncapped and out of Playlists', () => {
const makeSongsLike = (id: string, name: string): Playlist => ({
id,
user_id: 'u1',
owner_username: 'u1',
name,
description: '',
is_public: false,
kind: 'system',
system_variant: 'songs_like_artist',
refreshable: false,
seed_artist_id: 'a1',
cover_url: '',
track_count: 25,
duration_sec: 1500,
created_at: '2026-05-04T00:00:00Z',
updated_at: '2026-05-04T00:00:00Z'
});
// Six generated mixes — the old carousel capped at 3; the dedicated row shows all.
const owned = Array.from({ length: 6 }, (_, i) => makeSongsLike(`sl${i}`, `Songs like ${i}`));
(createPlaylistsQuery as unknown as ReturnType<typeof vi.fn>).mockImplementation(
(kind?: string) =>
kind === 'system'
? readable({ data: { owned, public: [] }, isPending: false, isError: false })
: readable({ data: emptyPlaylistsResponse, isPending: false, isError: false })
);
const { container } = render(Page);
for (let i = 0; i < 6; i++) {
expect(screen.getByText(`Songs like ${i}`)).toBeInTheDocument();
}
// The mixes live in the Songs-like row, not the Playlists carousel.
const playlistsSection = container.querySelector('[aria-label="Playlists"]') as HTMLElement;
expect(within(playlistsSection).queryByText('Songs like 0')).toBeNull();
const songsSection = container.querySelector('[aria-label="Songs like"]') as HTMLElement;
expect(within(songsSection).getByText('Songs like 0')).toBeInTheDocument();
// No placeholders once real mixes exist.
expect(within(songsSection).queryByTestId('playlist-placeholder-card')).toBeNull();
});
test('renders secondary system kinds (deep_cuts / new_for_you) in the Playlists row', () => {
// Operator backflow 2026-06-01: web Home surfaces the 5 secondary
// system kinds when generated. No placeholders for them — they
// depend on library shape, so missing means "not enough data."
const makePlaylist = (id: string, variant: string, name: string): Playlist => ({
id,
user_id: 'u1',
owner_username: 'u1',
name,
description: '',
is_public: false,
kind: 'system',
system_variant: variant,
refreshable: variant !== 'songs_like_artist',
seed_artist_id: null,
cover_url: '',
track_count: 25,
duration_sec: 1500,
created_at: '2026-05-04T00:00:00Z',
updated_at: '2026-05-04T00:00:00Z'
});
const owned = [
makePlaylist('fy', 'for_you', 'For You'),
makePlaylist('dc', 'deep_cuts', 'Deep cuts'),
makePlaylist('nfy', 'new_for_you', 'New for you')
];
(createPlaylistsQuery as unknown as ReturnType<typeof vi.fn>).mockImplementation(
(kind?: string) =>
kind === 'system'
? readable({ data: { owned, public: [] }, isPending: false, isError: false })
: readable({ data: emptyPlaylistsResponse, isPending: false, isError: false })
);
render(Page);
expect(screen.getByText('For You')).toBeInTheDocument();
expect(screen.getByText('Deep cuts')).toBeInTheDocument();
expect(screen.getByText('New for you')).toBeInTheDocument();
});
});