bvandeusen
aec10ce787
android / Build + lint + test (push) Failing after 1m41s
Discover suggestion artist images failed to load on Android while loading fine in the web client. Root cause: BaseUrlInterceptor unconditionally rewrote every outgoing request's scheme/host/port to AuthStore.baseUrl. That's correct for Minstrel-bound requests built with the http://placeholder.invalid sentinel (Retrofit's frozen baseUrl, every cover-URL builder, ServerImage's resolveServerUrl). But Lidarr surfaces artist artwork as absolute URLs to external hosts (artwork.musicbrainz.org, coverartarchive.org); rewriting those to the Minstrel host produced 404s that Coil silently fell back from to the User icon. Web works because the browser fetches the URL as authored. Coil on Android shares the OkHttp client (and so the interceptor chain) with Retrofit, which is why the bug surfaced here only. Add a PLACEHOLDER_HOST companion constant and short-circuit the rewrite for non-placeholder hosts. Test coverage: - placeholder host → rewritten to live baseUrl - absolute external URL → host/scheme/path preserved - unparseable baseUrl → falls through (no throw) AuthCookieInterceptor still attaches the Minstrel session cookie to external requests; external hosts ignore unrecognized cookies so that's not breaking anything, but it's worth a follow-up DRY pass to scope auth attachment the same way.