Files
minstrel/flutter_client/test/quarantine/quarantine_provider_test.dart
T
bvandeusen a9e277eb13 test(flutter): fix 6 latent failures uncovered by the drift cohort un-skip
All six tests had been silently skipped under @Tags(['drift']) for
6+ months, so they accumulated test-vs-implementation drift. Now
running against the libsqlite3-bearing ci-flutter:3.44 image, each
failed for a distinct reason. Diagnoses below.

audio_cache_manager_test 'usageBytes sums sizeBytes across rows':
  usageBytes() is a directory walk (authoritative on-disk total,
  catches orphan partials the index misses). The test inserted drift
  rows but never wrote files, so the walk returned 0. The actual API
  for summing drift sizeBytes is bucketUsage(). Rename to
  'bucketUsage sums drift sizeBytes across rows', use that API,
  assert liked+rolling == 350. Also give the two rows unique paths
  per row-shape sanity.

sync_controller_test (3 200-path tests, all returning null result):
  Map literals in Dart 3 with mixed value types infer as
  Map<String, Object>, not Map<String, dynamic>. The sync controller
  casts `resp.data as Map<String, dynamic>` (and several nested
  casts), which is invariant on generics and throws TypeError. The
  silent try/catch in sync() swallowed the throw and returned null.
  Real JSON parsing produces Map<String, dynamic>, so this never
  surfaced in production. Fix: route the test stub body through
  jsonDecode(jsonEncode(body)) in _stubDio — mimics real Dio's
  parsed-response shape. Affects '200 with artist upsert', '200 with
  track delete', and 'like_track upsert + delete round-trip'.

quarantine_provider_test 'flag keeps drift optimistic + queues
mutation on server failure':
  When the API stub throws, the controller catches + queues to
  CachedMutations. The drift watch() stream in MyQuarantineController
  was still in loading state when addTearDown disposed the
  container, tripping Riverpod's "StreamProvider disposed during
  loading" assertion. The success-path tests resolved before
  tearDown so they didn't see it. Fix: await one microtask before
  the test ends so the stream emits.

like_button_test 'tap toggles icon optimistically; rollback on error':
  After the LikeButton was migrated to LucideHeart in the Lucide
  sweep, the prior fix replaced the find.byIcon assertion with a
  heartFilled() helper reading LucideHeart.filled. But likesController
  .toggle() goes through an async chain (optimistic state flip + await
  api.like + state notification), which one frame of tester.pump()
  doesn't flush. Use pumpAndSettle after both tap and rollback toggle
  so the widget rebuilds with the new state before the assertion.

After this push, the drift cohort should be all-green on the
libsqlite3-bearing image. Fable #399 / local #62.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-20 18:52:05 -04:00

144 lines
4.7 KiB
Dart

import 'package:drift/native.dart' show NativeDatabase;
import 'package:flutter_riverpod/flutter_riverpod.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:minstrel/api/endpoints/quarantine.dart';
import 'package:minstrel/cache/audio_cache_manager.dart' show appDbProvider;
import 'package:minstrel/cache/db.dart';
import 'package:minstrel/models/track.dart';
import 'package:minstrel/quarantine/quarantine_provider.dart';
class _StubQuarantineApi implements QuarantineApi {
_StubQuarantineApi({this.shouldThrow = false});
bool shouldThrow;
int flagCalls = 0;
int unflagCalls = 0;
@override
Future<void> flag(String trackId, String reason, {String notes = ''}) async {
flagCalls++;
if (shouldThrow) throw Exception('simulated server failure');
}
@override
Future<void> unflag(String trackId) async {
unflagCalls++;
if (shouldThrow) throw Exception('simulated server failure');
}
}
const _track = TrackRef(
id: 't1',
title: 'Roygbiv',
albumId: 'a1',
albumTitle: 'Geogaddi',
artistId: 'ar1',
artistName: 'Boards of Canada',
durationSec: 137,
trackNumber: 4,
streamUrl: '',
);
ProviderContainer _container({required AppDb db, required QuarantineApi api}) {
return ProviderContainer(overrides: [
appDbProvider.overrideWithValue(db),
quarantineApiProvider.overrideWith((ref) async => api),
]);
}
Future<void> _seed(AppDb db) async {
await db.into(db.cachedQuarantineMine).insert(
CachedQuarantineMineCompanion.insert(
trackId: 't1',
reason: 'bad_rip',
createdAt: '2026-05-01T00:00:00Z',
trackTitle: 'Roygbiv',
albumId: 'a1',
albumTitle: 'Geogaddi',
artistId: 'ar1',
artistName: 'Boards of Canada',
),
);
}
void main() {
test('flag inserts a drift row and calls the server',
() async {
final db = AppDb(NativeDatabase.memory());
addTearDown(db.close);
final api = _StubQuarantineApi();
final container = _container(db: db, api: api);
addTearDown(container.dispose);
await container.read(myQuarantineProvider.future);
await container
.read(myQuarantineProvider.notifier)
.flag(_track, 'bad_rip', '');
expect(api.flagCalls, 1);
final rows = await db.select(db.cachedQuarantineMine).get();
expect(rows, hasLength(1));
expect(rows.first.trackId, 't1');
expect(rows.first.reason, 'bad_rip');
});
test('flag keeps drift optimistic + queues mutation on server failure', () async {
final db = AppDb(NativeDatabase.memory());
addTearDown(db.close);
final api = _StubQuarantineApi(shouldThrow: true);
final container = _container(db: db, api: api);
addTearDown(container.dispose);
await container.read(myQuarantineProvider.future);
// No longer rethrows — flag swallows the REST failure and queues
// for replay so the user's intent persists offline.
await container
.read(myQuarantineProvider.notifier)
.flag(_track, 'bad_rip', '');
final rows = await db.select(db.cachedQuarantineMine).get();
expect(rows, hasLength(1),
reason: 'optimistic drift row should persist across REST failure');
final mutations = await db.select(db.cachedMutations).get();
expect(mutations, hasLength(1),
reason: 'failed flag should have been enqueued for replay');
expect(mutations.first.kind, 'quarantine.flag');
// Let in-flight drift watch() streams settle before tearDown
// disposes the container — otherwise Riverpod's StreamProvider
// fires "disposed during loading state" on the queued-mutation
// path (the success path resolves before the awaits above
// complete, so it doesn't need this).
await Future<void>.delayed(Duration.zero);
});
test('unflag deletes the drift row and calls the server',
() async {
final db = AppDb(NativeDatabase.memory());
addTearDown(db.close);
await _seed(db);
final api = _StubQuarantineApi();
final container = _container(db: db, api: api);
addTearDown(container.dispose);
await container.read(myQuarantineProvider.future);
await container.read(myQuarantineProvider.notifier).unflag('t1');
expect(api.unflagCalls, 1);
final rows = await db.select(db.cachedQuarantineMine).get();
expect(rows, isEmpty);
});
test('isHidden reflects drift state', () async {
final db = AppDb(NativeDatabase.memory());
addTearDown(db.close);
await _seed(db);
final api = _StubQuarantineApi();
final container = _container(db: db, api: api);
addTearDown(container.dispose);
await container.read(myQuarantineProvider.future);
final ctrl = container.read(myQuarantineProvider.notifier);
expect(ctrl.isHidden('t1'), isTrue);
expect(ctrl.isHidden('t2'), isFalse);
});
}