release / govulncheck (push) Successful in 28s
release / web (push) Successful in 1m18s
release / go (push) Successful in 1m35s
release / android (push) Successful in 4m45s
release / Build signed APK (push) Successful in 4m57s
release / integration (push) Successful in 5m3s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Successful in 1m14s
release / Verify release artifacts (tag releases only) (push) Skipped
Minstrel keeps credentials it has to read back: indexer, Prowlarr and download-client keys and passwords, the AcoustID key, cover-art and tag provider keys, the SMTP password, and each user's ListenBrainz token and Subsonic password. They were stored in the clear; they are now sealed with AES-256-GCM under a per-column HKDF key derived from the stream secret, each value bound to its row. - internal/secret: Seal/Open/Reveal, and Columns, the one list of sealed columns (a backup will leave them out). Install takes the master key at startup; SealStored seals any value still in the clear, so an existing database is brought over in place on the first boot. - Every write seals and every read opens: acquire (one read path, getService / usableServices), acoustid settings, SMTP, ListenBrainz, Subsonic auth and password generation, cover-art and tag provider settings. - A value that does not open (the stream secret changed) is logged and reads as unset, to be entered again in Settings. docs/security.md says so. - Tests: secret unit tests (wrong owner/purpose/key, malformed, no key), a SealStored integration test over all eight columns plus a schema check that each listed column exists, and the existing tests now assert sealed storage. dbtest installs a test key for integration tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
91 lines
3.2 KiB
Go
91 lines
3.2 KiB
Go
package api
|
|
|
|
import (
|
|
"crypto/rand"
|
|
"encoding/base64"
|
|
"net/http"
|
|
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/apierror"
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/audit"
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/secret"
|
|
)
|
|
|
|
// The Subsonic password is for clients that sign in with Subsonic's t/s
|
|
// scheme (md5 of the password plus a salt). Checking that needs the password
|
|
// itself, so it is stored readable (migration 0003). That is why Minstrel
|
|
// generates it rather than letting the user choose one: a generated value
|
|
// can never be a login password reused from somewhere else, so a leaked
|
|
// users table gives up access to this server's /rest API and nothing more.
|
|
|
|
const subsonicPasswordBytes = 18 // 24 base64url characters
|
|
|
|
type subsonicPasswordStatusResp struct {
|
|
Enabled bool `json:"enabled"`
|
|
}
|
|
|
|
type subsonicPasswordResp struct {
|
|
Password string `json:"password"`
|
|
}
|
|
|
|
// handleGetMySubsonicPassword implements GET /api/me/subsonic-password. It
|
|
// reports only whether one is set; the value is shown once, when generated.
|
|
func (h *handlers) handleGetMySubsonicPassword(w http.ResponseWriter, r *http.Request) {
|
|
user, ok := requireUser(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, subsonicPasswordStatusResp{Enabled: user.SubsonicPassword != nil})
|
|
}
|
|
|
|
// handleGenerateMySubsonicPassword implements POST /api/me/subsonic-password:
|
|
// replaces any existing Subsonic password with a new random one and returns it.
|
|
func (h *handlers) handleGenerateMySubsonicPassword(w http.ResponseWriter, r *http.Request) {
|
|
user, ok := requireUser(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
b := make([]byte, subsonicPasswordBytes)
|
|
if _, err := rand.Read(b); err != nil {
|
|
h.logger.Error("generate subsonic password: rand failed", "err", err)
|
|
writeErr(w, apierror.Internal(err))
|
|
return
|
|
}
|
|
pw := base64.RawURLEncoding.EncodeToString(b)
|
|
sealed, err := secret.Seal(secret.SubsonicPassword.Purpose(), user.ID.String(), pw)
|
|
if err != nil {
|
|
h.logger.Error("generate subsonic password: seal failed", "err", err)
|
|
writeErr(w, apierror.Internal(err))
|
|
return
|
|
}
|
|
if err := dbq.New(h.pool).SetSubsonicPassword(r.Context(), dbq.SetSubsonicPasswordParams{
|
|
ID: user.ID,
|
|
SubsonicPassword: &sealed,
|
|
}); err != nil {
|
|
h.logger.Error("generate subsonic password: update failed", "err", err)
|
|
writeErr(w, apierror.Internal(err))
|
|
return
|
|
}
|
|
audit.WriteOrLog(r.Context(), h.pool, h.logger, user.ID, user.ID, audit.ActionSubsonicPasswordSet, nil)
|
|
writeJSON(w, http.StatusOK, subsonicPasswordResp{Password: pw})
|
|
}
|
|
|
|
// handleClearMySubsonicPassword implements DELETE /api/me/subsonic-password,
|
|
// which turns t/s and p= sign-in off for the account.
|
|
func (h *handlers) handleClearMySubsonicPassword(w http.ResponseWriter, r *http.Request) {
|
|
user, ok := requireUser(w, r)
|
|
if !ok {
|
|
return
|
|
}
|
|
if err := dbq.New(h.pool).SetSubsonicPassword(r.Context(), dbq.SetSubsonicPasswordParams{
|
|
ID: user.ID,
|
|
SubsonicPassword: nil,
|
|
}); err != nil {
|
|
h.logger.Error("clear subsonic password: update failed", "err", err)
|
|
writeErr(w, apierror.Internal(err))
|
|
return
|
|
}
|
|
audit.WriteOrLog(r.Context(), h.pool, h.logger, user.ID, user.ID, audit.ActionSubsonicPasswordClear, nil)
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|