release / govulncheck (push) Successful in 15s
release / web (push) Failing after 1m21s
release / go (push) Successful in 1m35s
release / integration (push) Failing after 4m57s
release / android (push) Successful in 5m11s
release / Build signed APK (releases and dev) (push) Successful in 5m28s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Skipped
release / Verify release artifacts (tag releases only) (push) Skipped
Minstrel keeps its own list of what it is to get, keyed by MusicBrainz release group. A want comes from an approved request, a new release by a followed artist, or an album whose files went missing, and is held once the library has a full edition of it. - Migration 0081: release_type_profiles (Standard seeded: Album, EP, Single, studio only), follows, follow_seen_groups and wants. lidarr_requests becomes requests with plain *_mbid columns; approved album and track requests move onto the wanted list, approved artist requests become follows, and the library's album artists start out followed. missing_reacquisitions and the retry settings go. - internal/wanted: follows are checked against MusicBrainz discographies daily. The first check sets a baseline, and only releases after it are wanted unless the follow asked for what already exists. Profiles filter by primary and secondary type, so live recordings stay out unless a profile ticks Live. - internal/requests (was lidarrrequests): approving puts the request on the wanted list, and an artist request can be approved on a chosen profile. A request completes when its want is held. - The re-acquisition sweeper wants a missing album back instead of asking Lidarr; searching for it is the search schedule's (#5521). - Web: an admin Wanted page (Wanted, Missing files, Held, Following), a follow control on artist pages, a release-type profiles card on Integrations, "Approve on a profile" on Requests, and want state on Missing files. The artist detail API returns the artist's MBID. - Android: the request body sends artist_mbid, album_mbid and track_mbid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
118 lines
3.6 KiB
Go
118 lines
3.6 KiB
Go
// Package reacquisition wants an album back when its files go missing,
|
|
// without anyone pressing anything (milestone #290; a want rather than a
|
|
// Lidarr request since M502 #5520).
|
|
//
|
|
// The unit of work is the ALBUM, not the track. Music is acquired as
|
|
// releases; there is no meaningful "fetch me one track", and a recording
|
|
// MBID is something plenty of files lack. Grouping also does most of the
|
|
// safety work: the loss that produced #2523 — three reorganised albums, ~40
|
|
// missing files — becomes three wants rather than forty.
|
|
package reacquisition
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"log/slog"
|
|
"sync"
|
|
|
|
"github.com/jackc/pgx/v5/pgxpool"
|
|
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
|
)
|
|
|
|
// Settings is the operator-tunable policy, mirroring the columns and CHECK
|
|
// ranges in migration 0056.
|
|
type Settings struct {
|
|
Enabled bool
|
|
GraceHours int32
|
|
MaxPerPass int32
|
|
}
|
|
|
|
// Defaults mirror migration 0056's column defaults. Duplicated here so a
|
|
// database that cannot be read still yields a sane policy rather than a
|
|
// zero-valued one — a zero grace window would fire on every transient
|
|
// unmount, which is the exact failure the grace period exists to prevent.
|
|
var Defaults = Settings{
|
|
Enabled: true,
|
|
GraceHours: 24,
|
|
MaxPerPass: 20,
|
|
}
|
|
|
|
// ErrOutOfRange is returned by Set for values migration 0056's CHECKs would
|
|
// reject, so the API layer answers 400 instead of surfacing a constraint
|
|
// violation.
|
|
var ErrOutOfRange = errors.New("reacquisition setting out of range")
|
|
|
|
// SettingsService caches the settings and owns their persistence. Cached
|
|
// because the sweeper reads them every pass and the admin card reads them on
|
|
// every render; neither needs a round-trip.
|
|
type SettingsService struct {
|
|
pool *pgxpool.Pool
|
|
logger *slog.Logger
|
|
|
|
mu sync.RWMutex
|
|
cur Settings
|
|
}
|
|
|
|
// NewSettingsService loads once and caches.
|
|
//
|
|
// Always returns a usable service, even alongside a non-nil error: a
|
|
// boot-time database hiccup should leave the sweeper running on defaults
|
|
// rather than take it out entirely. The error is returned so the caller can
|
|
// log that the cache holds defaults rather than stored state.
|
|
func NewSettingsService(ctx context.Context, pool *pgxpool.Pool, logger *slog.Logger) (*SettingsService, error) {
|
|
s := &SettingsService{pool: pool, logger: logger, cur: Defaults}
|
|
row, err := dbq.New(pool).GetReacquisitionSettings(ctx)
|
|
if err != nil {
|
|
return s, fmt.Errorf("reacquisition: load settings: %w", err)
|
|
}
|
|
s.cur = fromRow(row)
|
|
return s, nil
|
|
}
|
|
|
|
// Get returns the cached settings.
|
|
func (s *SettingsService) Get() Settings {
|
|
s.mu.RLock()
|
|
defer s.mu.RUnlock()
|
|
return s.cur
|
|
}
|
|
|
|
// Set validates, persists and re-caches.
|
|
func (s *SettingsService) Set(ctx context.Context, in Settings) (Settings, error) {
|
|
if err := validate(in); err != nil {
|
|
return Settings{}, err
|
|
}
|
|
row, err := dbq.New(s.pool).UpdateReacquisitionSettings(ctx, dbq.UpdateReacquisitionSettingsParams{
|
|
Enabled: in.Enabled,
|
|
GraceHours: in.GraceHours,
|
|
MaxPerPass: in.MaxPerPass,
|
|
})
|
|
if err != nil {
|
|
return Settings{}, fmt.Errorf("reacquisition: save settings: %w", err)
|
|
}
|
|
out := fromRow(row)
|
|
s.mu.Lock()
|
|
s.cur = out
|
|
s.mu.Unlock()
|
|
return out, nil
|
|
}
|
|
|
|
func validate(in Settings) error {
|
|
switch {
|
|
case in.GraceHours < 1 || in.GraceHours > 720:
|
|
return fmt.Errorf("%w: grace_hours must be 1-720", ErrOutOfRange)
|
|
case in.MaxPerPass < 1 || in.MaxPerPass > 200:
|
|
return fmt.Errorf("%w: max_per_pass must be 1-200", ErrOutOfRange)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func fromRow(row dbq.ReacquisitionSetting) Settings {
|
|
return Settings{
|
|
Enabled: row.Enabled,
|
|
GraceHours: row.GraceHours,
|
|
MaxPerPass: row.MaxPerPass,
|
|
}
|
|
}
|