Merges Renovate's kit 3 (PR #149) and adapter-static 4 (PR #148) bumps, plus the migration they need. The mechanical part is `sv migrate sveltekit-3`, run one task at a time and reviewed: - svelte.config.js is gone. Its options move into sveltekit() in vite.config.ts, exported as kitOptions so vitest.config.ts runs the same kit setup, including the $test-utils alias the tests import. - $lib becomes #lib through package.json "imports". There is no src/lib/index, so only the "#lib/*" entry is kept. - tsconfig extends $app/tsconfig. - Peer floors raised to kit 3's requirements: svelte ^5.57.1, vite ^8.0.12, svelte-check ^4.7.5. By hand, from the codemod's list of non-automated tasks: - goto's replaceState option is now replace; keepFocus becomes reset: false. For the search typeahead, reset: false also stops the scroll-to-top, which is wanted while typing. - The test setup mocks drop pushState/replaceState and $app/paths base/assets, which kit 3 removed, and mock refreshAll in place of invalidateAll. - The other flagged files only read page.url or goto internal routes, so they needed no change. TypeScript goes to ^6, not the ^7 Renovate offers: kit 3 declares typescript ^6 as a peer and svelte-check 4.7 accepts ^5 || ^6. Move to 7 once both accept it. With Tailwind 4 and kit 3 in, `npm audit` on the whole tree reports 0, so the web lane now audits every dependency rather than only what ships to browsers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
131 lines
4.8 KiB
TypeScript
131 lines
4.8 KiB
TypeScript
import { afterEach, describe, expect, test, vi } from 'vitest';
|
|
import { render, screen, fireEvent } from '@testing-library/svelte';
|
|
import type { AlbumRef, AlbumDetail, TrackRef } from '#lib/api/types.js';
|
|
import { FALLBACK_COVER } from '#lib/media/covers.js';
|
|
import { emptyLikesMock } from '../../test-utils/mocks/likes';
|
|
import { apiClientMock } from '../../test-utils/mocks/client';
|
|
import { makeTrack } from '$test-utils/fixtures/track';
|
|
|
|
vi.mock('#lib/api/client.js', () => apiClientMock());
|
|
vi.mock('#lib/player/store.svelte.js', () => ({
|
|
enqueueTracks: vi.fn(),
|
|
playQueue: vi.fn()
|
|
}));
|
|
|
|
vi.mock('#lib/api/likes.js', () => emptyLikesMock());
|
|
|
|
vi.mock('$app/navigation', () => ({ goto: vi.fn() }));
|
|
|
|
vi.mock('#lib/api/albums.js', async (orig) => {
|
|
const actual = (await orig()) as Record<string, unknown>;
|
|
return { ...actual, listAlbumTracks: vi.fn().mockResolvedValue([]) };
|
|
});
|
|
|
|
vi.mock('#lib/api/playlists.js', async (orig) => {
|
|
const { readable } = await import('svelte/store');
|
|
const actual = (await orig()) as Record<string, unknown>;
|
|
return {
|
|
...actual,
|
|
createPlaylistsQuery: () =>
|
|
readable({ data: { owned: [], public: [] }, isPending: false, isError: false }),
|
|
appendTracks: vi.fn().mockResolvedValue({ id: 'p1', tracks: [] }),
|
|
createPlaylist: vi.fn().mockResolvedValue({ id: 'p1', name: 'New' })
|
|
};
|
|
});
|
|
|
|
import AlbumCard from './AlbumCard.svelte';
|
|
import { api } from '#lib/api/client.js';
|
|
import { enqueueTracks, playQueue } from '#lib/player/store.svelte.js';
|
|
|
|
const album: AlbumRef = {
|
|
id: 'xyz',
|
|
title: 'Kind of Blue',
|
|
sort_title: 'Kind of Blue',
|
|
artist_id: 'm-davis',
|
|
artist_name: 'Miles Davis',
|
|
year: 1959,
|
|
track_count: 5,
|
|
duration_sec: 2630,
|
|
cover_url: '/api/albums/xyz/cover',
|
|
cover_art_source: null,
|
|
};
|
|
|
|
afterEach(() => vi.clearAllMocks());
|
|
|
|
describe('AlbumCard', () => {
|
|
test('renders cover, title, artist inside a link to /albums/:id', () => {
|
|
const { container } = render(AlbumCard, { props: { album } });
|
|
const link = screen.getByRole('link');
|
|
expect(link).toHaveAttribute('href', '/albums/xyz');
|
|
expect(link).toHaveTextContent('Kind of Blue');
|
|
expect(link).toHaveTextContent('Miles Davis');
|
|
// The year is intentionally omitted from the Home tile —
|
|
// dropped in the visual polish pass; the album detail page
|
|
// still shows it.
|
|
expect(link).not.toHaveTextContent('1959');
|
|
|
|
const img = container.querySelector('img') as HTMLImageElement;
|
|
expect(img.src).toContain('/api/albums/xyz/cover');
|
|
});
|
|
|
|
test('year is not rendered on the tile even when present', () => {
|
|
render(AlbumCard, { props: { album: { ...album, year: undefined } } });
|
|
expect(screen.queryByText(/1959/)).not.toBeInTheDocument();
|
|
});
|
|
|
|
test('broken cover falls back to FALLBACK_COVER asset', async () => {
|
|
const { container } = render(AlbumCard, { props: { album } });
|
|
const img = container.querySelector('img') as HTMLImageElement;
|
|
await fireEvent.error(img);
|
|
// jsdom resolves relative URLs against the test origin; assert containment
|
|
// rather than strict equality to keep the test agnostic of the host.
|
|
expect(img.src).toContain(FALLBACK_COVER);
|
|
});
|
|
|
|
test('+ queue button fetches album detail and calls enqueueTracks', async () => {
|
|
const tracks: TrackRef[] = [
|
|
makeTrack({
|
|
title: 'So What',
|
|
album_id: 'xyz', album_title: 'Kind of Blue',
|
|
artist_id: 'm-davis', artist_name: 'Miles Davis',
|
|
duration_sec: 545
|
|
})
|
|
];
|
|
const detail: AlbumDetail = { ...album, tracks, genres: [] };
|
|
(api.get as ReturnType<typeof vi.fn>).mockResolvedValueOnce(detail);
|
|
|
|
render(AlbumCard, { props: { album } });
|
|
await fireEvent.click(screen.getByRole('button', { name: /add to queue/i }));
|
|
|
|
expect(api.get).toHaveBeenCalledWith('/api/albums/xyz');
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
expect(enqueueTracks).toHaveBeenCalledWith(tracks);
|
|
});
|
|
|
|
test('play overlay click fetches album detail and calls playQueue at index 0', async () => {
|
|
const tracks: TrackRef[] = [
|
|
makeTrack({
|
|
title: 'So What',
|
|
album_id: 'xyz', album_title: 'Kind of Blue',
|
|
artist_id: 'm-davis', artist_name: 'Miles Davis',
|
|
duration_sec: 545
|
|
})
|
|
];
|
|
const detail: AlbumDetail = { ...album, tracks, genres: [] };
|
|
(api.get as ReturnType<typeof vi.fn>).mockResolvedValueOnce(detail);
|
|
|
|
render(AlbumCard, { props: { album } });
|
|
await fireEvent.click(screen.getByRole('button', { name: /play kind of blue/i }));
|
|
expect(api.get).toHaveBeenCalledWith('/api/albums/xyz');
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
expect(playQueue).toHaveBeenCalledWith(tracks, 0);
|
|
});
|
|
|
|
test('renders the bottom-right kebab menu trigger', () => {
|
|
render(AlbumCard, { props: { album } });
|
|
expect(screen.getByRole('button', { name: /Album actions for Kind of Blue/i })).toBeInTheDocument();
|
|
});
|
|
});
|